WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
32,325 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

6080 Commits

Author SHA1 Message Date
John Blackbourn 5576cd3978 Introduce `map_deep()`, a utility function that recursively maps a callable function to every item in an array or object. Works like `array_walk_recursive()` but works with objects too. 
Updates `rawurlencode_deep()`, `urlencode_deep()`, and `stripslashes_deep()` to use `map_deep()`. Introduces `urldecode_deep()` for completeness.

Props wpmuguru, nbachiyski, boonebgorges, MikeHansenMe, chriscct7, realloc, johnbillion
Fixes #22300

Built from https://develop.svn.wordpress.org/trunk@35252


git-svn-id: http://core.svn.wordpress.org/trunk@35218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 23:26:24 +00:00
Weston Ruter f676fdcee3 Customizer: Fix `margin-top` calculation for Themes section. 
Ensure that the Themes section calculates its `margin-top` as a panel, since the section behaves as one. Fixes regression caused by [35231].

See #33567.


Built from https://develop.svn.wordpress.org/trunk@35251


git-svn-id: http://core.svn.wordpress.org/trunk@35217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 22:41:25 +00:00
Scott Taylor 443ce28304 Media: in `wp_get_attachment_image_sizes()`, ensure that `$img_width` exists when the image does not. 
Props kraftbj.
See #33641.


Built from https://develop.svn.wordpress.org/trunk@35250


git-svn-id: http://core.svn.wordpress.org/trunk@35216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 22:12:24 +00:00
Scott Taylor c7b0db99a6 Unit Tests: better fixtures for `Tests_Meta_Slashes` and `Tests_WP_Customize_Section`. 
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35249


git-svn-id: http://core.svn.wordpress.org/trunk@35215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 21:29:24 +00:00
Scott Taylor 11d1e8af8b Unit Tests: better fixtures for `Tests_User_WpSetCurrentUser`. 
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35248


git-svn-id: http://core.svn.wordpress.org/trunk@35214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 21:19:24 +00:00
Scott Taylor 32bb609d88 Unit Tests: better fixtures for `Tests_User`. 
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35247


git-svn-id: http://core.svn.wordpress.org/trunk@35213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 21:15:25 +00:00
Scott Taylor a9134691d4 Unit Tests: better fixtures for `Tests_AdminBar`. Don't force-delete some posts: some filter callbacks are no-ops on Multisite if the post is vanquished. 
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35246


git-svn-id: http://core.svn.wordpress.org/trunk@35212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 20:49:24 +00:00
Scott Taylor 4204afdd40 Unit Tests: better fixtures for `Tests_Admin_Includes_Post`. 
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35245


git-svn-id: http://core.svn.wordpress.org/trunk@35211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 19:48:23 +00:00
Scott Taylor d54f567862 Unit Tests: `WP_UnitTest_Generator_Sequence` needs a static incrementer - otherwise, it assumes every test class is a reset, which it no longer is (it is now static). 
While we're at it, remove unnecessary `tearDown()` code.

See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35244


git-svn-id: http://core.svn.wordpress.org/trunk@35210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 19:25:24 +00:00
Scott Taylor 7d7c85b83d Unit Tests: after [35242], declare some missing instance props on individual test classes. 
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35243


git-svn-id: http://core.svn.wordpress.org/trunk@35209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 18:30:24 +00:00
Scott Taylor 7f8dca02b7 Unit Tests: after [35225], make `factory` a method/getter on `WP_UnitTestCase` and add magic methods for BC for every plugin that is extending `WP_UnitTestCase` and accessing the `$factory` instance prop. 
Props nerrad, wonderboymusic.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35242


git-svn-id: http://core.svn.wordpress.org/trunk@35208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 18:03:25 +00:00
Drew Jaynes 8a386cb24f Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35241


git-svn-id: http://core.svn.wordpress.org/trunk@35207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 15:13:25 +00:00
Drew Jaynes 767d091c74 Docs: Improve the hook doc for the `get_post_status` filter, introduced in [35233]. 
Also adds a missing parameter description for `$post`.

See #23458. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35240


git-svn-id: http://core.svn.wordpress.org/trunk@35206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 14:24:25 +00:00
Ella Iseulde Van Dorpe 08f71faac3 JSHint after [35238] 
Built from https://develop.svn.wordpress.org/trunk@35239


git-svn-id: http://core.svn.wordpress.org/trunk@35205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 07:11:24 +00:00
Ella Iseulde Van Dorpe 47e364de42 Admin: fix repositioning notices 
Fixes #34294.
Props afercia.

Built from https://develop.svn.wordpress.org/trunk@35238


git-svn-id: http://core.svn.wordpress.org/trunk@35204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 07:04:26 +00:00
Drew Jaynes 10d94ea673 Docs: Add a missing file header for wp-admin/includes/class-wp-list-table.php. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35237


git-svn-id: http://core.svn.wordpress.org/trunk@35203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 06:07:24 +00:00
Weston Ruter c7a951194d Customizer: Add unit test for `WP_Customize_Widgets::is_panel_active()`. 
See #33052.

Built from https://develop.svn.wordpress.org/trunk@35236


git-svn-id: http://core.svn.wordpress.org/trunk@35202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 04:44:25 +00:00
Sergey Biryukov a908d2d4b1 Embeds: Rename files, functions, and hooks added in [34903] to make it more clear what is oEmbed-specific and what isn't. 
See https://core.trac.wordpress.org/ticket/34272#comment:7 for full list of renamed functions and hooks.

Props swissspidy.
Fixes #34272.
Built from https://develop.svn.wordpress.org/trunk@35235


git-svn-id: http://core.svn.wordpress.org/trunk@35201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 01:21:25 +00:00
Sergey Biryukov 1157540283 Replace Quick Edit and Bulk Edit headings with `<legend>` elements. 
Props afercia.
Fixes #34289.
Built from https://develop.svn.wordpress.org/trunk@35234


git-svn-id: http://core.svn.wordpress.org/trunk@35200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 00:45:25 +00:00
Aaron Jorbin b778726e74 Improve `get_post_permalink` compatibility with non standard post status 
This adds a new filter named `get_post_status` to the function named `get_post_status` which can be used to make additional post types behave like unpublished post status in `get_post_permalink`.

Props misterbisson, antpb, iamfriendly
Fixes #23458


Built from https://develop.svn.wordpress.org/trunk@35233


git-svn-id: http://core.svn.wordpress.org/trunk@35199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 00:44:26 +00:00
Sergey Biryukov 7c2919c02b Merge two strings for expanding accordion and Customizer sections. 
Props pavelevap.
Fixes #33939.
Built from https://develop.svn.wordpress.org/trunk@35232


git-svn-id: http://core.svn.wordpress.org/trunk@35198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-17 00:28:25 +00:00
Weston Ruter 6bcd8ad757 Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview. 
Widgets panel will not wait to display until the preview loads.

Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.

Fixes #33052.
Fixes #33567.

Built from https://develop.svn.wordpress.org/trunk@35231


git-svn-id: http://core.svn.wordpress.org/trunk@35197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 23:48:25 +00:00
Sergey Biryukov 5c8522c022 Merge two warning strings. 
Props pavelevap.
Fixes #29740.
Built from https://develop.svn.wordpress.org/trunk@35230


git-svn-id: http://core.svn.wordpress.org/trunk@35196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 23:31:25 +00:00
Sergey Biryukov f98136c1b5 Sample permalink: Improve accessibility of changing the permalink on Edit Post screen. 
Props afercia.
Fixes #34255.
Built from https://develop.svn.wordpress.org/trunk@35229


git-svn-id: http://core.svn.wordpress.org/trunk@35195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 23:02:25 +00:00
Sergey Biryukov ac630ba233 Embeds: In `print_oembed_embed_styles()`, load non-minified file if `SCRIPT_DEBUG` is true. 
This is consistent with `print_oembed_embed_scripts()`.

Props MikeHansenMe.
Fixes #34321.
Built from https://develop.svn.wordpress.org/trunk@35228


git-svn-id: http://core.svn.wordpress.org/trunk@35194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 22:43:24 +00:00
Boone Gorges 4430e5dbbb Return `null` from `get_term()` on taxonomy mismatch. 
[34997] caused `get_term()` to return an error object in the case when
`$taxonomy` did not match the taxonomy of the located term. This was an
inadvertant change from the previous behavior, when `get_term()` would return
null in these cases.

Props dlh.
See #14162. Fixes #34332.
Built from https://develop.svn.wordpress.org/trunk@35227


git-svn-id: http://core.svn.wordpress.org/trunk@35193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 21:42:25 +00:00
Scott Taylor efb224e831 Unit Tests: PHP 5.2, I Hate You and You Are Bringing Me Down. 
#YOLOFriday

See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35226


git-svn-id: http://core.svn.wordpress.org/trunk@35192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 21:15:25 +00:00
Scott Taylor a2a65a06bd Unit Tests: one `$factory` to rule them all, and it shall be `static`. 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday


Built from https://develop.svn.wordpress.org/trunk@35225


git-svn-id: http://core.svn.wordpress.org/trunk@35191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 21:05:25 +00:00
Scott Taylor 3693228a9b Unit Tests: since [32953], we can just use `self::delete_user()` instead of using `if` logic for Multisite. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35224


git-svn-id: http://core.svn.wordpress.org/trunk@35190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 19:52:27 +00:00
Sergey Biryukov 7fdbebdd7d In `WP_Posts_List_Table`, correct the type for `$comment_pending_count`. 
See #11381.
Built from https://develop.svn.wordpress.org/trunk@35223


git-svn-id: http://core.svn.wordpress.org/trunk@35189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 18:25:25 +00:00
Sergey Biryukov dcf23c5e2a In `WP_Media_List_Table`, rename `$pending_count` to `$comment_pending_count` and mark it as protected, for consistency with `WP_Posts_List_Table`. 
See #11381.
Built from https://develop.svn.wordpress.org/trunk@35222


git-svn-id: http://core.svn.wordpress.org/trunk@35188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 18:23:27 +00:00
Drew Jaynes 1cb39b180f Docs: Standardize the file header summary for wp-admin/includes/file.php. 
Also adds an `@since` version and corrects the `@subpackage` value.

See #33701.

Built from https://develop.svn.wordpress.org/trunk@35221


git-svn-id: http://core.svn.wordpress.org/trunk@35187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 16:56:26 +00:00
Andrea Fercia dc0e7e1a79 Accessibility: Improve headings hierarchy in the Theme browser modal dialog. 
Fixes #34288.
Built from https://develop.svn.wordpress.org/trunk@35220


git-svn-id: http://core.svn.wordpress.org/trunk@35186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 15:56:25 +00:00
Andrea Fercia 7f4a0ebbf3 Bump H4 headings to H2 in the Updates screen for better accessibility. 
Fixes #34265.
Built from https://develop.svn.wordpress.org/trunk@35219


git-svn-id: http://core.svn.wordpress.org/trunk@35185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 15:45:28 +00:00
Dominik Schilling 0df9abe092 Travis CI: Use a pinned version of the object cache drop-in. 
Props tollmanz.
See #31491.
Built from https://develop.svn.wordpress.org/trunk@35218


git-svn-id: http://core.svn.wordpress.org/trunk@35184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 14:16:28 +00:00
Ella Iseulde Van Dorpe bafdd96ebf TinyMCE: add lang attribute 
This is needed to make `hyphens: auto;` work correctly.

Fixes #32555.

Built from https://develop.svn.wordpress.org/trunk@35217


git-svn-id: http://core.svn.wordpress.org/trunk@35183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 10:11:27 +00:00
Ella Iseulde Van Dorpe ef01315cac TinyMCE: make sure markers are removed after first init 
This is only relevant to non embeddable URLs.
After first init, markers were set but not removed,
causing an edited URL to revert when switching to text mode
or any paragraph after the URL to just contain that URL.

Fixes #33954.

Built from https://develop.svn.wordpress.org/trunk@35216


git-svn-id: http://core.svn.wordpress.org/trunk@35182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 05:43:26 +00:00
Helen Hou-Sandí fc02ca2d01 Account for icon alignment using text-indent in RTL. 
fixes #33808.

Built from https://develop.svn.wordpress.org/trunk@35215


git-svn-id: http://core.svn.wordpress.org/trunk@35181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 00:58:25 +00:00
Scott Taylor 438c2462e1 Unit Tests: add `SpeedTrapListener` to `phpunit/includes` and add the config node to `phpunit.xml.dist`. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35214


git-svn-id: http://core.svn.wordpress.org/trunk@35180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 00:28:23 +00:00
Dominik Schilling dd753ef3ad Travis: Extend our test suite with a memcached instance. 
To test persistent object caching Travis CI runs now a build on PHP 5.6 with memached enabled. The build uses the drop-in from https://github.com/tollmanz/wordpress-pecl-memcached-object-cache which is based on the PECL memcached extension.

Props pento, ocean90.
Fixes #31491.
Built from https://develop.svn.wordpress.org/trunk@35213


git-svn-id: http://core.svn.wordpress.org/trunk@35179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 22:52:25 +00:00
Dominik Schilling 22874716dd Multisite: Remove the strictness for `$using_paths` in `WP_Network::get_by_path()`. 
The network lookup was broken when using an external object cache because `$using_paths` isn't always a boolean. Added in [34099].

See #31985, #31491.
Built from https://develop.svn.wordpress.org/trunk@35212


git-svn-id: http://core.svn.wordpress.org/trunk@35178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 22:07:24 +00:00
Dominik Schilling 272ff97709 Tests: Remove the `@runTestsInSeparateProcesses` annotation for Ajax tests. 
They were added 3 years ago in [846/tests] because tests weren't excluded from the normal runs.

Reverts [35209] because it doesn't work with Xdebug.
`Tests_Ajax_Response::test_response_charset_in_header` is the only test which needs to run in a separate process, see [975/tests].

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35211


git-svn-id: http://core.svn.wordpress.org/trunk@35177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 21:31:24 +00:00
Drew Jaynes d4711aff8a Docs: Fix a typo in an inline comment in `wp_get_attachment_image_srcset_array()`. 
Props neoxx.
Fixes #34319.

Built from https://develop.svn.wordpress.org/trunk@35210


git-svn-id: http://core.svn.wordpress.org/trunk@35176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 20:52:24 +00:00
Dominik Schilling bcdad0aa12 Tests: Don't preserve the global state for Ajax tests when using an external object cache. 
Most of the Ajax tests are running in a separate PHP process, and thus PHPUnit attempts to preserve the global state from the parent process by serializing all globals. But this doesn't work for external object caches so we have to disable this "feature".

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35209


git-svn-id: http://core.svn.wordpress.org/trunk@35175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 20:35:23 +00:00
Aaron Jorbin 41b21cf23b Add Twenty Sixteen to travis builds 
This allows the automated tests to include Twenty Sixteen.

Fixes #34315. See #34306.


Built from https://develop.svn.wordpress.org/trunk@35208


git-svn-id: http://core.svn.wordpress.org/trunk@35174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 19:06:25 +00:00
Helen Hou-Sandí 7aabfdaca4 Circular focus styling for widgets and menus in the customizer. 
see #33808.

Built from https://develop.svn.wordpress.org/trunk@35207


git-svn-id: http://core.svn.wordpress.org/trunk@35173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 18:53:25 +00:00
Boone Gorges 76a89d95c3 Fix incorrect variable name introduced in [35197]. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35206


git-svn-id: http://core.svn.wordpress.org/trunk@35172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 18:48:24 +00:00
Sergey Biryukov 2d540d0280 In `WP::parse_request()` and `url_to_postid()`, don't skip objects that have a post status with `'exclude_from_search' => false`, e.g. `inherit`. 
This fixes pretty permalinks for attachments, broken in [35195].

Fixes #21970.
Built from https://develop.svn.wordpress.org/trunk@35205


git-svn-id: http://core.svn.wordpress.org/trunk@35171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:53:24 +00:00
Helen Hou-Sandí 395258bcaa Make the database update button primary. 
see #23738.

Built from https://develop.svn.wordpress.org/trunk@35204


git-svn-id: http://core.svn.wordpress.org/trunk@35170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:35:24 +00:00
Sergey Biryukov de730d605f Twenty Sixteen: Update `Gruntfile.js` to ignore the html5 shiv for JSHint. 
See #34306, #34315.
Built from https://develop.svn.wordpress.org/trunk@35203


git-svn-id: http://core.svn.wordpress.org/trunk@35169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:27:24 +00:00
Drew Jaynes 0905e847ae Docs: `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit` are part of the Navigation Menu API, but intended for use in the scope of administration. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35202


git-svn-id: http://core.svn.wordpress.org/trunk@35168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:26:24 +00:00
Helen Hou-Sandí 12290303a8 Box shadows still need `-webkit-`, turns out. 
see #33808, [35200].

Built from https://develop.svn.wordpress.org/trunk@35201


git-svn-id: http://core.svn.wordpress.org/trunk@35167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:09:26 +00:00
Helen Hou-Sandí 50288dea5a Circular focus styling for expand/collapse arrows. 
Affects postboxes, widgets, and nav menus, all in the admin.

props grvrulz for the initial patch.
see #33808.

Built from https://develop.svn.wordpress.org/trunk@35200


git-svn-id: http://core.svn.wordpress.org/trunk@35166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 16:47:25 +00:00
Ella Iseulde Van Dorpe 3eb4a57c27 TinyMCE: make captioned images draggable 
See #28003.

Built from https://develop.svn.wordpress.org/trunk@35199


git-svn-id: http://core.svn.wordpress.org/trunk@35165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 15:20:25 +00:00
Ella Iseulde Van Dorpe 3babb1682a Fix close button plugin modal after [18590] 
See #18590.


Built from https://develop.svn.wordpress.org/trunk@35198


git-svn-id: http://core.svn.wordpress.org/trunk@35164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 14:52:26 +00:00
Scott Taylor 9d4069e5d9 Unit Tests: add/upgrade the fixtures in `Tests_User_Query`. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35197


git-svn-id: http://core.svn.wordpress.org/trunk@35163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 07:29:24 +00:00
Scott Taylor 1603ccad71 Unit Tests: create fewer terms in `Tests_Term_getTerms::test_get_terms_parent_zero()` 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35196


git-svn-id: http://core.svn.wordpress.org/trunk@35162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 06:53:24 +00:00
Sergey Biryukov 8a6d07f596 In `WP::parse_request()` and `url_to_postid()`, if a post slug clashes with a trashed page, return the post instead of the page. 
Props kovshenin, SergeyBiryukov, igmoweb.
Fixes #21970.
Built from https://develop.svn.wordpress.org/trunk@35195


git-svn-id: http://core.svn.wordpress.org/trunk@35161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 06:49:25 +00:00
Scott Taylor 3bf9aa75a4 Unit Tests: upgrade the fixtures in `Tests_Post_Thumbnail_Template`. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35194


git-svn-id: http://core.svn.wordpress.org/trunk@35160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 06:40:24 +00:00
Scott Taylor 274d7f5bb0 Unit Tests: upgrade the fixtures in `Tests_Post_Revisions`. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35193


git-svn-id: http://core.svn.wordpress.org/trunk@35159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 06:32:25 +00:00
Scott Taylor 5b49ff3a48 Unit Tests: in `Tests_Comment_Query::test_get_comments_for_post()`, create fewer comments (5, instead of 10). 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35192


git-svn-id: http://core.svn.wordpress.org/trunk@35158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:57:25 +00:00
Scott Taylor 53ef754260 Unit Tests: after [35186], "upgrade" the Canonical fixtures. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35191


git-svn-id: http://core.svn.wordpress.org/trunk@35157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:51:24 +00:00
Sergey Biryukov 8aa7fb88f0 Remove a one-time variable from `edit_user()` added in [35189]. 
See #27317.
Built from https://develop.svn.wordpress.org/trunk@35190


git-svn-id: http://core.svn.wordpress.org/trunk@35156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:46:24 +00:00
Sergey Biryukov 7f08716c16 Users: Add `'illegal_user_logins'` filter to allow certain usernames to be blacklisted. 
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317.
Built from https://develop.svn.wordpress.org/trunk@35189


git-svn-id: http://core.svn.wordpress.org/trunk@35155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:43:26 +00:00
Scott Taylor b6b2baccbd Unit Tests: create more fixtures for `Tests_User`. When using a factory to create ad hoc users, use the inherited static prop `$static_factory` instead of the instance prop, `$factory`. If 2 factories are used out of sync, the generator sequences diverge and dupes can be created, causing an untold number of unforeseen errors. Yay. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35188


git-svn-id: http://core.svn.wordpress.org/trunk@35154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:30:25 +00:00
Sergey Biryukov 09ee95ea49 Themes: Add Install Parent Theme button for child themes that are missing a parent theme. 
Props rabmalin for initial patch.
Fixes #32668.
Built from https://develop.svn.wordpress.org/trunk@35187


git-svn-id: http://core.svn.wordpress.org/trunk@35153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:11:24 +00:00
Scott Taylor 5cebd10ced Unit Tests: implement `setUpBeforeClass()` and `tearDownAfterClass()` on `WP_UnitTestCase`. Use late static binding (plus a gross fallback for PHP 5.2) to check if `wpSetUpBeforeClass()` or `wpTearDownAfterClass()` exist on the called class, and then call it and pass a static `WP_UnitTest_Factory` instance via Dependency Injection, if it exists. 
This makes it way easier to add fixtures, and tear them down, without needing to instantiate `WP_UnitTest_Factory` in every class - removes the need to call `commit_transaction()` in each individual class.

See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35186


git-svn-id: http://core.svn.wordpress.org/trunk@35152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 04:44:25 +00:00
Scott Taylor e62864ce46 Unit Tests: in `Tests_Term`, create fixtures for posts. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35185


git-svn-id: http://core.svn.wordpress.org/trunk@35151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 03:48:25 +00:00
Sergey Biryukov e63ba31f93 Acessibility: Add back-compat styles for plugins that use `h3` inside the `.metabox-holder` container. 
Props afercia.
Fixes #33557.
Built from https://develop.svn.wordpress.org/trunk@35184


git-svn-id: http://core.svn.wordpress.org/trunk@35150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 03:38:25 +00:00
Scott Taylor ad90d33285 Unit Tests: in `Tests_Post`, create fixtures for users. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35183


git-svn-id: http://core.svn.wordpress.org/trunk@35149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 03:31:24 +00:00
Helen Hou-Sandí f3107e5842 Make some primary action buttons look primary. 
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload

props Dezzy for the initial patch.
fixes #23738.

Built from https://develop.svn.wordpress.org/trunk@35182


git-svn-id: http://core.svn.wordpress.org/trunk@35148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 03:08:24 +00:00
Scott Taylor 2c46a4dcba Unit Tests: in `Tests_Media::test_wp_get_attachment_image_srcset_array_no_width()`, just toggle metadata, instead of creating a new attachment. Shaves 75ms off the test. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35181


git-svn-id: http://core.svn.wordpress.org/trunk@35147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 02:55:24 +00:00
Sergey Biryukov 6d91caa931 Theme Editor: Repurpose the `'wp_theme_editor_filetypes'` filter added in [35134] to actually filter file types instead of files. 
Default types include 'php' and 'css' and cannot be removed, only new types can be added.

Props DrewAPicture, SergeyBiryukov.
Fixes #22924.
Built from https://develop.svn.wordpress.org/trunk@35180


git-svn-id: http://core.svn.wordpress.org/trunk@35146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 02:20:24 +00:00
Scott Taylor 317d62bfad Unit Tests: make a fixture in `Tests_Media` to represent the large image, instead of creating it 10 times. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35179


git-svn-id: http://core.svn.wordpress.org/trunk@35145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:43:24 +00:00
Scott Taylor 60ad26b4fd Unit Tests: move some oEmbed tests that can trigger HTTP calls to `Tests_External_HTTP_OEmbed`. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35178


git-svn-id: http://core.svn.wordpress.org/trunk@35144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:29:24 +00:00
Scott Taylor f19e4c9b46 Unit Tests: `Tests_Canonical` doesn't need to call `wp_set_current_user()` or implement `tearDown` because its grandparent calls `wp_set_current_user( 0 )` in `tearDown()`. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35177


git-svn-id: http://core.svn.wordpress.org/trunk@35143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:18:24 +00:00
Scott Taylor 972e76991f Unit Tests: `Tests_Comment` needs a `tearDownAfterClass` impl to avoid spillage. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35176


git-svn-id: http://core.svn.wordpress.org/trunk@35142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:06:24 +00:00
Scott Taylor 083537d213 Unit Tests: `Tests_Auth` needs a `tearDownAfterClass` impl to avoid spillage. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35175


git-svn-id: http://core.svn.wordpress.org/trunk@35141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:04:24 +00:00
Scott Taylor b7e9b93be3 Unit Tests: call `commit_transaction()` in `Tests_Auth` set up. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35174


git-svn-id: http://core.svn.wordpress.org/trunk@35140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 00:49:24 +00:00
Scott Taylor b1a39f1a6a Unit Tests: reuse fixtures in `Tests_Comment`. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35173


git-svn-id: http://core.svn.wordpress.org/trunk@35139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 00:39:23 +00:00
Scott Taylor e9db7c15fd Unit Tests: move `->test_readme()` out of `Tests_Basic` and into `Tests_External_HTTP_Basic` in `tests/external-http/`. 
I intend to move other `wp_remote_get()` tests into similar classes.

See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35172


git-svn-id: http://core.svn.wordpress.org/trunk@35138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 00:23:24 +00:00
Scott Taylor 351d78fbac Unit Tests: wrestle performance out of `Tests_Auth` by cloning the same user for a majority of the tests. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35171


git-svn-id: http://core.svn.wordpress.org/trunk@35137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 00:11:24 +00:00
Drew Jaynes 217b661703 Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35170


git-svn-id: http://core.svn.wordpress.org/trunk@35136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 23:44:25 +00:00
Drew Jaynes 43c10f7d35 Docs: Fix third-person singular verbs for summaries in wp-admin/includes/bookmarks.php. 
Also adds some missing parameter, return, and global descriptions, and one missing summary.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35169


git-svn-id: http://core.svn.wordpress.org/trunk@35135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 23:25:25 +00:00
Drew Jaynes c78ee60edd Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php. 
See #33701.

[ci skip]

Built from https://develop.svn.wordpress.org/trunk@35168


git-svn-id: http://core.svn.wordpress.org/trunk@35134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 22:49:24 +00:00
Drew Jaynes c3ee28ea06 Docs: wp-admin/includes/admin-filters.php is part of the Administration subpackage, update the summary. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35167


git-svn-id: http://core.svn.wordpress.org/trunk@35133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 22:35:24 +00:00
Drew Jaynes 2e2e898802 Docs: Add a version and standardize the file header summary for wp-admin/includes/admin.php. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35166


git-svn-id: http://core.svn.wordpress.org/trunk@35132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 22:32:24 +00:00
Boone Gorges a53fe085aa Fix incorrect variable names from [35164]. 
Cool story - the tests appeared to pass with the typos.

See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35165


git-svn-id: http://core.svn.wordpress.org/trunk@35131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 22:00:26 +00:00
Boone Gorges ba37dc9123 Share fixtures in `Tests_Admin_includesListTable` tests. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35164


git-svn-id: http://core.svn.wordpress.org/trunk@35130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 21:41:24 +00:00
Boone Gorges cb8a2f2e47 Share fixtures in `Tests_Get_Archives`. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35163


git-svn-id: http://core.svn.wordpress.org/trunk@35129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 21:30:25 +00:00
Boone Gorges 530111994d Create fewer fixtures in some tests. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35162


git-svn-id: http://core.svn.wordpress.org/trunk@35128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 21:24:24 +00:00
Helen Hou-Sandí 6820130e33 Screen options: Improve the "Apply" button 
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.

Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.

fixes #34295. see #22222, #23738.

Built from https://develop.svn.wordpress.org/trunk@35161


git-svn-id: http://core.svn.wordpress.org/trunk@35127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 18:58:25 +00:00
Andrea Fercia f1787056de Bump the "Status" H3 heading to H2 on the Edit Comment screen for better accessibility. 
Fixes #34286.
Built from https://develop.svn.wordpress.org/trunk@35160


git-svn-id: http://core.svn.wordpress.org/trunk@35126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:44:24 +00:00
Jeremy Felt 9dd1462fe3 MS: Introduce action `before_signup_header`. 
This aligns `wp-signup.php` a bit more `with `wp-activate.php` and, among other things, allows a plugin to redirect signup requests.

Props pbearne.
Fixes #17630.

Built from https://develop.svn.wordpress.org/trunk@35159


git-svn-id: http://core.svn.wordpress.org/trunk@35125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:32:49 +00:00
Andrea Fercia c4ff6317a7 Bump H3 headings to H2 on the legacy Link Manager screen for better accessibility. 
Fixes #34285.
Built from https://develop.svn.wordpress.org/trunk@35158


git-svn-id: http://core.svn.wordpress.org/trunk@35124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:32:24 +00:00
Drew Jaynes d01f1c2e15 Docs: Add missing file headers to two Toolbar API files: wp-includes/admin-bar.php and wp-includes/class-wp-admin-bar.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35157


git-svn-id: http://core.svn.wordpress.org/trunk@35123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:27:25 +00:00
Jeremy Felt b9b7592ee8 MS: Add "Settings" link under "Network Admin" toolbar menu. 
Props johnjamesjacoby.
Fixes #34287.

Built from https://develop.svn.wordpress.org/trunk@35156


git-svn-id: http://core.svn.wordpress.org/trunk@35122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:00:26 +00:00
Andrea Fercia 19eb905f58 Accessibility: update a jQuery selector used for the Plugin Cards after [35009]. 
When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.

Fixes #33818.
Built from https://develop.svn.wordpress.org/trunk@35155


git-svn-id: http://core.svn.wordpress.org/trunk@35121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 15:27:27 +00:00
Boone Gorges fde30ae8b7 Create fewer fixtures in XML-RPC `getComments` tests. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35154


git-svn-id: http://core.svn.wordpress.org/trunk@35120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 14:39:27 +00:00
John Blackbourn a5cca9c5ff Reinstate the Link Category admin screen after [34359]. 
See [13216]

Fixes #34284

Built from https://develop.svn.wordpress.org/trunk@35153


git-svn-id: http://core.svn.wordpress.org/trunk@35119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 01:51:26 +00:00