WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
32,031 Commits 50 Branches 749 Tags 983 MiB
Commit Graph

5779 Commits

Author SHA1 Message Date
Andrew Ozz 8164f8fe0e PressThis: 
- Remove unneeded passing of post formats strings to JS.
- Set the currently selected post format name with jQuery.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31589


git-svn-id: http://core.svn.wordpress.org/trunk@31570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-28 20:08:27 +00:00
Dominik Schilling 8ecb7f5d1e Press This: Backwards compatibility enhancements. 
* Add missing actions for printing styles/scripts.
* Since `$hook_suffix` is null, hardcode `press-this.php`.
* Restore body classes, add filter.
* Use boolean value instead of `__return_false()`.
* Use `wp_json_encode()`.
* Update docs for filters in script-loader.php.
* Make `<a href="%1$s">%2$s</a>` not translatable.

see #31373.
Built from https://develop.svn.wordpress.org/trunk@31588


git-svn-id: http://core.svn.wordpress.org/trunk@31569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-28 10:36:25 +00:00
Dominik Schilling c7dba8b015 Press This: RTL improvements. 
* Load the RTL version of press-this-editor.css.
* Use more semantic class names for the arrows, Makes it easier to swap the arrows in RTL, see #31478.

see #31474.
Built from https://develop.svn.wordpress.org/trunk@31577


git-svn-id: http://core.svn.wordpress.org/trunk@31558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-27 19:44:24 +00:00
Scott Taylor f6b1b01ecd Make a new function, `wp_delete_file()`. Use it. 
Props scribu, wonderboymusic.
Fixes #17864.

Built from https://develop.svn.wordpress.org/trunk@31575


git-svn-id: http://core.svn.wordpress.org/trunk@31556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-27 16:51:25 +00:00
Dominik Schilling 5e47a1f633 Press This: Use boolean value instead of __return_true(). Add missing hook docs. 
see #31373.
Built from https://develop.svn.wordpress.org/trunk@31571


git-svn-id: http://core.svn.wordpress.org/trunk@31552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-27 11:15:25 +00:00
Andrew Ozz 4593319ea7 PressThis: accessibility enhancements: 
- Add missing form labels.
- Add some screen-reader-text and aria-hidden attributes.
- Focus handling improvements.
- Change tagcloud-link into a button.
- Add missing ID attribute in tools.php.
Props afercia. Fixes #31449.
Built from https://develop.svn.wordpress.org/trunk@31566


git-svn-id: http://core.svn.wordpress.org/trunk@31547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-27 02:50:25 +00:00
Helen Hou-Sandí b95d99d1c1 Settings API: Allow passing a class to `add_settings_field()` via the `$args` array. 
While it's possible to target the wrapper element otherwise (currently a `tr`), this deficiency is made especially noticeable when custom code cannot take advantage of what core is doing, such as with avatars in #30168.

props valendesigns.
fixes #28975. see #30168.

Built from https://develop.svn.wordpress.org/trunk@31560


git-svn-id: http://core.svn.wordpress.org/trunk@31541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-26 19:59:25 +00:00
Sergey Biryukov 49dd31506f Press This: Use correct URL for update bookmarklet link. 
props kraftbj.
fixes #31461.
Built from https://develop.svn.wordpress.org/trunk@31556


git-svn-id: http://core.svn.wordpress.org/trunk@31537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-26 08:48:25 +00:00
Scott Taylor 7cb45f2402 Don't call the size function `count()` as part of a test condition in loops. Compute the size beforehand, and not on each iteration. 
Scrutinizer added a Performance label: these are the only violations.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31554


git-svn-id: http://core.svn.wordpress.org/trunk@31535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-26 05:48:24 +00:00
Scott Taylor 4310147e54 Add missing access modifiers to `WP_Press_This`. 
See #31456.

Built from https://develop.svn.wordpress.org/trunk@31552


git-svn-id: http://core.svn.wordpress.org/trunk@31533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-26 05:18:25 +00:00
Drew Jaynes 50bb433c66 Ignore the internal-use function `_wp_posts_page_notice()` from parsing for the code reference. 
See #17470.

Built from https://develop.svn.wordpress.org/trunk@31551


git-svn-id: http://core.svn.wordpress.org/trunk@31532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-26 03:08:28 +00:00
Helen Hou-Sandí ae3baa7c5b Hide irrelevant UI and display a message when editing the page for posts. 
Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust.

Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content.

props alexkingorg for the initial, long-suffering patch.
fixes #17470.

Built from https://develop.svn.wordpress.org/trunk@31550


git-svn-id: http://core.svn.wordpress.org/trunk@31531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-26 02:47:25 +00:00
Andrew Ozz 1857055bb8 PressThis v2, first run. Props michael-arestad, stephdau, marcelomazza, DrewAPicture, iseulde, afercia, kraftbj, rachelbaker, AramZS, dd32. See #31373. 
Built from https://develop.svn.wordpress.org/trunk@31534


git-svn-id: http://core.svn.wordpress.org/trunk@31515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-25 01:50:26 +00:00
Mark Jaquith 8b180b9a46 Add theme browsing and theme switching to the Customizer 
* Brings into core the Customizer Theme Switcher feature plugin
* You can now browse, preview, and activate themes right from the Customizer

fixes #31303.
props celloexpressions, afercia, westonruter, folletto, designsimply
Built from https://develop.svn.wordpress.org/trunk@31533


git-svn-id: http://core.svn.wordpress.org/trunk@31514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-24 20:31:24 +00:00
Drew Jaynes 4743843323 Add missing function and parameter descriptions to a variety of functions in wp-admin/includes/image-edit.php. 
Props NikV for the initial patch.
Fixes #31353.

Built from https://develop.svn.wordpress.org/trunk@31529


git-svn-id: http://core.svn.wordpress.org/trunk@31510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-24 06:07:26 +00:00
Jeremy Felt 7644e68119 Provide proper label associations and descriptions throughout the network admin 
* Add labels previously missing for many inputs throughout the network admin screen.
* Add proper `aria-describedby` attributes to provide better descriptions.
* Wrap grouped inputs with `fieldset` elements.
* Remove now unneeded `title` attributes when appropriate.

Props cfoellmann, afercia, rianrietveld.

Fixes #38406.

Built from https://develop.svn.wordpress.org/trunk@31517


git-svn-id: http://core.svn.wordpress.org/trunk@31498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-23 02:29:26 +00:00
Andrew Ozz 19dbf7b998 Improve table footer tab sequence by moving `<tfoot>` after `<tbody>`. Props afercia, rianrietveld, DrewAPicture. Fixes #30914. 
Built from https://develop.svn.wordpress.org/trunk@31513


git-svn-id: http://core.svn.wordpress.org/trunk@31494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-22 21:48:26 +00:00
Jeremy Felt 678982ee7e Do not activate plugins on initial installation in multisite. 
Check `is_multisite()` before activating a plugin that has been installed via AJAX. Without this check, the plugin would be automatically activated on the main site of the network.

Props ianmjones.

Fixes #31327.

Built from https://develop.svn.wordpress.org/trunk@31511


git-svn-id: http://core.svn.wordpress.org/trunk@31492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-22 21:30:25 +00:00
Sergey Biryukov 8eb25609e9 Dashboard: Add a filter for the query arguments used for the Recent Posts widget. 
props danielbachhuber.
fixes #29374.
Built from https://develop.svn.wordpress.org/trunk@31508


git-svn-id: http://core.svn.wordpress.org/trunk@31489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-22 19:57:24 +00:00
Sergey Biryukov 4b21c67738 Remove untranslatable period from a successful update message in `Bulk_Upgrader_Skin::add_strings()`. 
props mako09, DrewAPicture.
fixes #30793.
Built from https://develop.svn.wordpress.org/trunk@31506


git-svn-id: http://core.svn.wordpress.org/trunk@31487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-22 17:07:24 +00:00
Sergey Biryukov 19a43125cd Don't try to read a non-existent Exif:Title tag in `wp_read_image_metadata()`, as it's not a part of the Exif standard. 
props tyxla.
fixes #31043.
Built from https://develop.svn.wordpress.org/trunk@31462


git-svn-id: http://core.svn.wordpress.org/trunk@31443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-14 09:14:28 +00:00
Sergey Biryukov e2f5a8094e Avoid a PHP notice in `wp_install_language_form()` and `wp_dropdown_languages()` if the language doesn't have a ISO 639-1 code. 
props barrykooij.
fixes #31319.
Built from https://develop.svn.wordpress.org/trunk@31447


git-svn-id: http://core.svn.wordpress.org/trunk@31428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 11:23:26 +00:00
Sergey Biryukov 7b9d981a54 Use correct default values for some admin template functions. 
props ipm-frommen.
fixes #31308.
Built from https://develop.svn.wordpress.org/trunk@31446


git-svn-id: http://core.svn.wordpress.org/trunk@31427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 06:51:25 +00:00
Sergey Biryukov 5a0b01edf1 Rename unused argument and remove obsolete global in `iframe_header()`. 
props ipm-frommen.
fixes #31309.
Built from https://develop.svn.wordpress.org/trunk@31443


git-svn-id: http://core.svn.wordpress.org/trunk@31424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 05:31:26 +00:00
Sergey Biryukov 268d79cb77 `_list_meta_row()` should always return a string. 
props ipm-frommen.
fixes #31310.
Built from https://develop.svn.wordpress.org/trunk@31442


git-svn-id: http://core.svn.wordpress.org/trunk@31423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 04:22:26 +00:00
Sergey Biryukov 6fd67ad80e Correct parameter types for `Plugin_Upgrader::bulk_upgrade()` and `Theme_Upgrader::bulk_upgrade()`. 
props ipm-frommen.
fixes #31312.
Built from https://develop.svn.wordpress.org/trunk@31441


git-svn-id: http://core.svn.wordpress.org/trunk@31422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 04:19:27 +00:00
Sergey Biryukov 43583a1b9e Terminate JS statements in two admin files. 
props ipm-frommen.
fixes #31311.
Built from https://develop.svn.wordpress.org/trunk@31440


git-svn-id: http://core.svn.wordpress.org/trunk@31421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 04:09:27 +00:00
Helen Hou-Sandí 2a1f3c4c1f Posts list table: Add a filter to disable the months dropdown. 
It was previously possible to prevent it from displaying by filtering everything out from the results, but if one really doesn't want it, they should be able to short-circuit before the query even runs.

props norcross, SergeyBiryukov.
fixes #30254.

Built from https://develop.svn.wordpress.org/trunk@31438


git-svn-id: http://core.svn.wordpress.org/trunk@31419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-12 18:38:29 +00:00
Dion Hulse 3cec3655e9 Prevent IE9 and lower displaying the download file dialogue when attempting to upload using the `html4` Plupload handler. 
The HTML4 Plupload handler uses a hidden iframe to POST the upload form,
Unfortunately Internet Explorer 9 doesn't support the `application/json` 
content-type which `wp_send_json_success()` and requires `text/html` instead.

This partially reverts [30354], keeping the better error messages.

Fixes #31037 for trunk.

Built from https://develop.svn.wordpress.org/trunk@31429


git-svn-id: http://core.svn.wordpress.org/trunk@31410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-12 01:15:29 +00:00
Scott Taylor 6cb16f7a21 Remove unused media JS files. 
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31405


git-svn-id: http://core.svn.wordpress.org/trunk@31386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 22:45:28 +00:00
Sergey Biryukov 0e65ae6176 Remove redundant string with a typo introduced in [25481]. 
see #31217.
Built from https://develop.svn.wordpress.org/trunk@31404


git-svn-id: http://core.svn.wordpress.org/trunk@31385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 07:53:28 +00:00
Sergey Biryukov 12f4004989 Replace generic "Dear user" greeting in email notifications with a more personalized one. 
props Ipstenu.
fixes #31217.
Built from https://develop.svn.wordpress.org/trunk@31403


git-svn-id: http://core.svn.wordpress.org/trunk@31384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 07:47:27 +00:00
Sergey Biryukov f166a51809 Update body class when switching between admin color schemes. 
props valendesigns.
fixes #30488.
Built from https://develop.svn.wordpress.org/trunk@31400


git-svn-id: http://core.svn.wordpress.org/trunk@31381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 02:23:28 +00:00
Boone Gorges 72f18cb067 Don't parse empty 'tax_input' keys in `edit_post()`. 
This fixes a bug introduced in [31359] where saving a tax_input that contained
only whitespace would result in a random tag being erroneously added to the
post.

See #30615.
Built from https://develop.svn.wordpress.org/trunk@31392


git-svn-id: http://core.svn.wordpress.org/trunk@31373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 22:54:28 +00:00
Sergey Biryukov 1e0905793c Avoid inadvertent stomping of the original `$args` parameter passed to `plugins_api_result` and `themes_api_result` filters in `plugins_api()` and `themes_api()`, respectively. 
Fixes a regression introduced in [25956].

props Corphi, obenland.
fixes #29079.
Built from https://develop.svn.wordpress.org/trunk@31363


git-svn-id: http://core.svn.wordpress.org/trunk@31344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-07 06:21:22 +00:00
Boone Gorges b9e661dcae Parse non-hierarchical tag input into term IDs before sending to `wp_insert_post()`. 
When editing a post, non-hierarchical taxonomy terms are sent as the
comma-separated list entered into the tax_input metabox. Passing these
values directly to `wp_update_post()` meant that they were interpreted as
term slugs rather than term names, causing mismatches when a typed string
matched the slug of one term and the name of a different term. We fix the
problem by preprocessing tax_input data sent from post.php, converting it to
unambiguous term_ids before saving.

Props boonebgorges, ArminBraun.
Fixes #30615.
Built from https://develop.svn.wordpress.org/trunk@31359


git-svn-id: http://core.svn.wordpress.org/trunk@31340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 20:32:22 +00:00
Gary Pendergast d7c6ac95bc Upgrades: wp_usermeta is a global table in multisite, so it should only be upgraded by the single site routines when we're not in a multisite install. 
See #21212


Built from https://develop.svn.wordpress.org/trunk@31358


git-svn-id: http://core.svn.wordpress.org/trunk@31339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 13:41:22 +00:00
Gary Pendergast 7444799a82 Upgrades: When upgrading a table to utf8mb4, we should run the `ALTER TABLE` query, even if it doesn't have any text columns. This will update the table's default character set, so that any text columns added in the future will have the expected character set. 
See #21212 


Built from https://develop.svn.wordpress.org/trunk@31354


git-svn-id: http://core.svn.wordpress.org/trunk@31335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 05:59:23 +00:00
Gary Pendergast 555a9f0912 Upgrades: When deciding if we can upgrade a table to utf8mb4, make sure we're checking the character set, not the collation. 
Bump the DB version as well, as the update in [31349] wouldn't have triggered for anyone who tried it.

See #21212


Built from https://develop.svn.wordpress.org/trunk@31351


git-svn-id: http://core.svn.wordpress.org/trunk@31332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 05:26:21 +00:00
Gary Pendergast b2cf823105 WPDB: If a site is using the `utf8` charset, and their version of MySQL supports `utf8mb4`, auto-upgrade them to `utf8mb4`. 
This patch also resizes some indexes, to allow for the 767 byte index size limit in standard MySQL installs.

See #21212


Built from https://develop.svn.wordpress.org/trunk@31349


git-svn-id: http://core.svn.wordpress.org/trunk@31330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 04:51:22 +00:00
Gary Pendergast 5e4d135411 Shiny Updates: Fix a PHP warning when installing new plugins. 
Props lgladdy for the initial patch.

See #29820


Built from https://develop.svn.wordpress.org/trunk@31345


git-svn-id: http://core.svn.wordpress.org/trunk@31326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 00:34:21 +00:00
Gary Pendergast 27aa3e92d7 Shiny Updates: If the current user is not allowed to install/update plugins, we should return a JSON error, so it can be used by the JS handlers. 
See #29820


Built from https://develop.svn.wordpress.org/trunk@31335


git-svn-id: http://core.svn.wordpress.org/trunk@31316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 06:16:23 +00:00
Gary Pendergast b7926a518a Shiny Updates: Add capability checks to the ajax callbacks, to ensure the current user is allowed to install/update plugins. 
See #29820


Built from https://develop.svn.wordpress.org/trunk@31334


git-svn-id: http://core.svn.wordpress.org/trunk@31315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 06:05:22 +00:00
Gary Pendergast 9c69213f2b Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page. 
This also includes JS architecture that can be expanded to support theme, core and language pack updates.

Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture

See #29820


Built from https://develop.svn.wordpress.org/trunk@31333


git-svn-id: http://core.svn.wordpress.org/trunk@31314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 04:19:23 +00:00
Helen Hou-Sandí 62e65c3a35 Accessibility: remove remaining instances of accesskey. 
It is a poorly implemented browser feature, not particularly discoverable, and causes more problems than it helps solve.

props afercia.
fixes #29715.

Built from https://develop.svn.wordpress.org/trunk@31331


git-svn-id: http://core.svn.wordpress.org/trunk@31312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-04 03:46:24 +00:00
Dion Hulse e8f032c747 WP_Upgrader: Remove references to non-existant variables that have never existed. 
Props jdgrimes. Fixes  #29087

Built from https://develop.svn.wordpress.org/trunk@31327


git-svn-id: http://core.svn.wordpress.org/trunk@31308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-03 06:18:24 +00:00
Dion Hulse 92cb5936f1 Remove an unused parameter on install_plugins_upload(). 
Props michalzuber. Fixes #28964

Built from https://develop.svn.wordpress.org/trunk@31326


git-svn-id: http://core.svn.wordpress.org/trunk@31307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-03 06:14:22 +00:00
Boone Gorges eec82f9330 In `get_sample_permalink()`, override 'future' status before generating permalink. 
In [31114], `get_permalink()` was modified to prevent pretty permalinks from
being generated for posts with the 'future' post status. This inadvertently
broke the pretty permalink preview for scheduled posts. The fix is to include
the 'future' status in the list of statuses that `get_sample_permalink()` fakes
as 'publish' before it fetches a permalink.

Props DrewAPicture.
Fixes #30910.
Built from https://develop.svn.wordpress.org/trunk@31323


git-svn-id: http://core.svn.wordpress.org/trunk@31304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-02 16:50:22 +00:00
Boone Gorges f345a72c58 Prevent terms in a show_in_quick_edit=false taxonomy from being updated by a faked AJAX request. 
The UI for these taxonomies was hidden in [31308], but it remained possible to
send a direct POST request to the `inline-edit` endpoint to bypass the
restriction. The current changeset fixes this.

Props meloniq.
Fixes #26948.
Built from https://develop.svn.wordpress.org/trunk@31313


git-svn-id: http://core.svn.wordpress.org/trunk@31294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 19:38:24 +00:00
Boone Gorges e4f8d5e0bc Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases. 
See #26948.
Built from https://develop.svn.wordpress.org/trunk@31308


git-svn-id: http://core.svn.wordpress.org/trunk@31289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 19:29:22 +00:00
Boone Gorges abce542e5f Introduce 'show_in_quick_edit' parameter for `register_taxonomy()`. 
Setting 'show_in_quick_edit' to false when registering a custom taxonomy will
hide the taxonomy when editing posts using Quick Edit.

The new 'quick_edit_show_taxonomy' filter allows this behavior to be filtered
on a finer scale, as when you want a given taxonomy to be hidden for one post
type but not for others.

Props hlashbrooke.
Fixes #26948.
Built from https://develop.svn.wordpress.org/trunk@31307


git-svn-id: http://core.svn.wordpress.org/trunk@31288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 19:18:23 +00:00
Sergey Biryukov b05014805f Don't display the Help tab reference in Page Attributes meta box if Help tab was removed. 
props bananastalktome.
fixes #31164.
Built from https://develop.svn.wordpress.org/trunk@31303


git-svn-id: http://core.svn.wordpress.org/trunk@31284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 15:34:24 +00:00
Sergey Biryukov 5ac0568ee3 Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors. 
props tomdxw.
fixes #30927.
Built from https://develop.svn.wordpress.org/trunk@31300


git-svn-id: http://core.svn.wordpress.org/trunk@31281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 21:15:22 +00:00
Drew Jaynes 0f20ecca9c Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/taxonomy.php. 
Also adds a few missing parameter descriptions.

Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31293


git-svn-id: http://core.svn.wordpress.org/trunk@31274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 11:34:22 +00:00
Drew Jaynes f3033f34c6 Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/post.php 
Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31292


git-svn-id: http://core.svn.wordpress.org/trunk@31273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 11:32:22 +00:00
Drew Jaynes d95586e943 Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php. 
Also generally improve existing parameter, return, and other documentation in various function DocBlocks.

Props morganestes.
Fixes #30825.

Built from https://develop.svn.wordpress.org/trunk@31246


git-svn-id: http://core.svn.wordpress.org/trunk@31227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 09:15:22 +00:00
Drew Jaynes d41e669efe Ensure the correct list of default tabs for the Plugin Install screen are documented. 
Props stevenkword.
Fixes #31017.

Built from https://develop.svn.wordpress.org/trunk@31244


git-svn-id: http://core.svn.wordpress.org/trunk@31225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 08:44:22 +00:00
Sergey Biryukov 768624cb99 Use the site's local time to create the first post during installation. 
props extendwings.
fixes #29296.
Built from https://develop.svn.wordpress.org/trunk@31225


git-svn-id: http://core.svn.wordpress.org/trunk@31206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 10:07:23 +00:00
Scott Taylor 02a1f35ac8 Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions: 
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`. 
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31220


git-svn-id: http://core.svn.wordpress.org/trunk@31201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 22:51:21 +00:00
Scott Taylor eeda68bbda Fix some erroneous `@param` annotations. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31219


git-svn-id: http://core.svn.wordpress.org/trunk@31200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 22:44:25 +00:00
Scott Taylor 0f6d0b84d1 Remove unused local vars in `delete_plugins()`, `delete_theme()`, `WP_Date_Query->validate_date_values()`, `global_terms()`, and `WP_Text_Diff_Renderer_Table->_changed()`. 
This will clear out the "Unused Code" label in the next Scrutinizer report.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31217


git-svn-id: http://core.svn.wordpress.org/trunk@31198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 21:19:22 +00:00
Scott Taylor 7c5038feb6 Calling `->chown()` and `->chgrp()` in `WP_Filesystem_ftpsockets` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31216


git-svn-id: http://core.svn.wordpress.org/trunk@31197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 21:10:23 +00:00
Scott Taylor 6fa7021d62 Calling `->chown()` and `->chgrp()` in `WP_Filesystem_FTPext` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31215


git-svn-id: http://core.svn.wordpress.org/trunk@31196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 21:07:24 +00:00
Scott Taylor b8dd1f9c69 By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors. 
There are plenty of other kinds of errors, but this label will be cleared out.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31213


git-svn-id: http://core.svn.wordpress.org/trunk@31194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 19:13:23 +00:00
Scott Taylor bc55996a0b `@param` cleanup: 
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31212


git-svn-id: http://core.svn.wordpress.org/trunk@31193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 19:03:23 +00:00
Scott Taylor cde4c83091 [31210] broke Supportflow on dotorg, which declares these methods as `protected`. Switch to `protected` for the noop methods. The subclasses can make them more visible using `public`. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31211


git-svn-id: http://core.svn.wordpress.org/trunk@31192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 18:37:24 +00:00
Scott Taylor 3fb283db0a Add 2 noop methods to `WP_List_Table`: `->column_default()` and `->column_cb()`. 
`WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class.

These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31210


git-svn-id: http://core.svn.wordpress.org/trunk@31191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 17:42:22 +00:00
Scott Taylor 895794f74d In `WP_Filesystem_Base` subclasses that set `$wp_base`, remove this dead code. 
Unused since [8009] - "Make WP_Filesystem work with new directory constants"

There is currently no declared field and no `@property` annotation.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31209


git-svn-id: http://core.svn.wordpress.org/trunk@31190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 17:23:22 +00:00
Scott Taylor b29a20b90a `WP_Filesystem_Base` should declare `$errors` and `$options` as fields for use by subclasses. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31208


git-svn-id: http://core.svn.wordpress.org/trunk@31189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 17:10:43 +00:00
Scott Taylor 60c285aa22 In `wp_ajax_parse_media_shortcode()`, don't require a global `$post` for all passed shortcodes. 
`embed` is the only shortcode that requires a post ID. This will allow MCE views to work for `playlist`, `audio`, and `video` outside of the Edit Post screen.

See #30835.

Built from https://develop.svn.wordpress.org/trunk@31201


git-svn-id: http://core.svn.wordpress.org/trunk@31182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 05:19:22 +00:00
Scott Taylor 7f8b548df1 In HTML5, the `action` attribute is no longer required. Remove this attribute when empty. 
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.

Built from https://develop.svn.wordpress.org/trunk@31200


git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 04:16:24 +00:00
Scott Taylor fe6b5983df In PHP 5.0.0, `is_a()` became deprecated in favour of the `instanceof` operator. Calling `is_a()` would result in an `E_STRICT` warning. 
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.

To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.

`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.

Props markoheijnen, wonderboymusic.
Fixes #25672.

Built from https://develop.svn.wordpress.org/trunk@31188


git-svn-id: http://core.svn.wordpress.org/trunk@31169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 01:06:24 +00:00
Scott Taylor 6704875855 Replace the 3 remaining occurrences of `wpspin` GIF with `spinner`. 
Props avryl.
Fixes #27482.

Built from https://develop.svn.wordpress.org/trunk@31187


git-svn-id: http://core.svn.wordpress.org/trunk@31168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 00:33:22 +00:00
Helen Hou-Sandí 62a197d6bf List tables: Use CSS :nth-child() selectors for zebra striping. 
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.

Built from https://develop.svn.wordpress.org/trunk@31181


git-svn-id: http://core.svn.wordpress.org/trunk@31162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-14 22:14:22 +00:00
Scott Taylor b51593763a `WP_Themes_List_Table` accesses `$_pagination_args` from the parent class. Switch `$_pagination_args` to `protected` in `WP_List_Table`. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31167


git-svn-id: http://core.svn.wordpress.org/trunk@31148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:26:21 +00:00
Scott Taylor 4f6de09a5b Add a `private` field to `WP_Terms_List_Table`, `$level`. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31166


git-svn-id: http://core.svn.wordpress.org/trunk@31147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:23:22 +00:00
Scott Taylor 194932fd6b Add a `private` field to `WP_Posts_List_Table`, `$is_trash`. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31165


git-svn-id: http://core.svn.wordpress.org/trunk@31146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:22:22 +00:00
Scott Taylor 71f9bc3f42 Add a `private` field to `WP_Plugin_Install_List_Table`, `$error`. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31164


git-svn-id: http://core.svn.wordpress.org/trunk@31145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:19:22 +00:00
Scott Taylor 91312e71cd In lieu of refactoring, add a `private` field to `WP_MS_Themes_List_Table`, `$has_items`. Ideally, this class would overload `->has_items()` and not set a `private` field. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31163


git-svn-id: http://core.svn.wordpress.org/trunk@31144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:17:22 +00:00
Scott Taylor 86c0f63739 Add 2 `private` fields to `WP_Media_List_Table`, `$detached` and `$is_trash`. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31162


git-svn-id: http://core.svn.wordpress.org/trunk@31143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:08:21 +00:00
Scott Taylor df09597a65 After [31146], properly declare `$user_can` as a `private` field in `WP_Comments_List_Table`. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31161


git-svn-id: http://core.svn.wordpress.org/trunk@31142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:02:24 +00:00
Dion Hulse af92025162 More concise documentation for wp_install_maybe_enable_pretty_permalinks() 
See #6481. Props ericlewis.

Built from https://develop.svn.wordpress.org/trunk@31160


git-svn-id: http://core.svn.wordpress.org/trunk@31141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 04:33:23 +00:00
Dion Hulse a114d0929b The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable. 
See #6481. Props nacin, valendesigns

Built from https://develop.svn.wordpress.org/trunk@31159


git-svn-id: http://core.svn.wordpress.org/trunk@31140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 04:31:23 +00:00
Scott Taylor e6fc90f973 In `WP_List_Table`, only call magic method internals again whitelists of properties and methods, `$compat_fields` and `$compat_methods`. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31146


git-svn-id: http://core.svn.wordpress.org/trunk@31127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:20:22 +00:00
Scott Taylor 2749e46178 In `WP_Filesystem_Base`, make the only `private` member, `$cache`, `public` and remove magic methods. `$cache` was always `public` until [28487], has been essentially `public` via a magic method since. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31145


git-svn-id: http://core.svn.wordpress.org/trunk@31126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:04:22 +00:00
Boone Gorges 5c0ddb8602 Default `$parent` in `category_exists()` should default to null rather than 0. 
[29863] made the corresponding change in `term_exists()`. Failure to change the
default value in `category_exists()` meant that an unspecified value for
`$parent` would limit results to top-level categories.

Includes unit tests and corrected function documentation.

Props hissy.
Fixes #30975 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31140


git-svn-id: http://core.svn.wordpress.org/trunk@31121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 01:26:27 +00:00
Scott Taylor 5547115dc2 Fix some `@param` docs that have chars too close them. 
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.	

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31127


git-svn-id: http://core.svn.wordpress.org/trunk@31108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 06:57:22 +00:00
Scott Taylor 0a511680f4 Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31126


git-svn-id: http://core.svn.wordpress.org/trunk@31107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 06:54:23 +00:00
Scott Taylor da99d29a59 Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31125


git-svn-id: http://core.svn.wordpress.org/trunk@31106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 06:13:22 +00:00
Scott Taylor 1b3f91f500 Declare `$wp_version`, `$required_php_version`, and `$required_mysql_version` as globals in install and upgrade admin files. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31124


git-svn-id: http://core.svn.wordpress.org/trunk@31105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 05:57:22 +00:00
Scott Taylor 1bac6fb886 In `wp-admin/includes/revision.php`, `$post->modified` is a coding error. It should be `$post->post_modified`. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31123


git-svn-id: http://core.svn.wordpress.org/trunk@31104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 05:50:22 +00:00
Scott Taylor d6ce5dd553 `WP_Upgrader` will take any "skin" that is passed to it, and set `->skin` via composition. The default type of `->skin` is `WP_Upgrader_Skin`, which doesn't have methods declared for `->bulk_header()` and `->bulk_footer()`. Add noop methods to `WP_Upgrader_Skin`. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31122


git-svn-id: http://core.svn.wordpress.org/trunk@31103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 05:42:22 +00:00
Scott Taylor afd09f1f04 In `wp_ajax_upload_attachment()`, `wp_check_filetype_and_ext()` doesn't need a 3rd param - it already defaults to `null`. Passing `false` would fail a strict check 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31119


git-svn-id: http://core.svn.wordpress.org/trunk@31100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 04:55:25 +00:00
Sergey Biryukov 7b04e6d4f4 Add variable type for sync_category_tag_slugs() parameters. 
props tillkruess.
fixes #30718.
Built from https://develop.svn.wordpress.org/trunk@31113


git-svn-id: http://core.svn.wordpress.org/trunk@31094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 11:19:22 +00:00
Sergey Biryukov e214fce67f Use localized format for Last Updated date in plugin details modal, for consistency with [31055]. 
see #30717.
Built from https://develop.svn.wordpress.org/trunk@31110


git-svn-id: http://core.svn.wordpress.org/trunk@31091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 06:21:22 +00:00
Sergey Biryukov d5d0b367ab Improve documentation for media_handle_upload(). 
props ericlewis.
fixes #30962.
Built from https://develop.svn.wordpress.org/trunk@31109


git-svn-id: http://core.svn.wordpress.org/trunk@31090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 05:05:23 +00:00
Scott Taylor 8ee598169f After [31105], don't ditch the `isset()` calls for BC. Declare `$page_hook` as `null` so it is initialized for all execution paths but will still fail `isset()` checks. 
Fixes #30958.

Built from https://develop.svn.wordpress.org/trunk@31106


git-svn-id: http://core.svn.wordpress.org/trunk@31087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 22:52:22 +00:00
Scott Taylor 60e1dd409b Properly declare `$hook_suffix`, `$plugin_page`, `$typenow`, and `$taxnow` as globals in `wp-admin/admin.php`. 
Fixes #30958.

Built from https://develop.svn.wordpress.org/trunk@31105


git-svn-id: http://core.svn.wordpress.org/trunk@31086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 22:15:24 +00:00
Scott Taylor e4b6265c7a Overriding methods should do more than simply call the same method in the super class. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31101


git-svn-id: http://core.svn.wordpress.org/trunk@31082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 21:20:22 +00:00
Scott Taylor 4a1ad9acec Jump statements should not be followed by other statements (there were 5 lingering). 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31100


git-svn-id: http://core.svn.wordpress.org/trunk@31081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 21:15:22 +00:00
Scott Taylor 4feecb922c Use `&&` instead of `and` in the 3 places where `and` was used. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31099


git-svn-id: http://core.svn.wordpress.org/trunk@31080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 21:12:22 +00:00
Scott Taylor 383a5c6c24 In `wp-includes/plugin.php`, collapse 3 `else-newline-tab-if` statements. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31091


git-svn-id: http://core.svn.wordpress.org/trunk@31072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:13:24 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:05:25 +00:00
Dion Hulse a4ed093250 Enable Pretty Permalinks for new sites during install if the server supports it. 
See #6481, Props valendesigns, DrewAPicture & ericlewis

Built from https://develop.svn.wordpress.org/trunk@31089


git-svn-id: http://core.svn.wordpress.org/trunk@31070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 06:47:23 +00:00
Scott Taylor ac4e67b82e Perl-style comments should not be used 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31079


git-svn-id: http://core.svn.wordpress.org/trunk@31060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 05:52:24 +00:00
Scott Taylor e029005847 Access Modifiers: 
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31078


git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 05:44:23 +00:00
Scott Taylor ff98cfcf45 Pinking Shears. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31077


git-svn-id: http://core.svn.wordpress.org/trunk@31058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 05:03:23 +00:00
Sergey Biryukov 9b0e279e82 In dashboard activity widget, display a front-end link if the user cannot edit the post. 
props UaMV, DrewAPicture.
fixes #29025.
Built from https://develop.svn.wordpress.org/trunk@31075


git-svn-id: http://core.svn.wordpress.org/trunk@31056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 00:26:22 +00:00
Sergey Biryukov f2b5ac8ef1 Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices. 
props ocean90.
fixes #30827 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31074


git-svn-id: http://core.svn.wordpress.org/trunk@31055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 23:43:24 +00:00
Sergey Biryukov f601e45055 TinyMCE: Remove dashicon-no-alt.png, unused since [30694]. 
props kpdesign, MattyRob.
fixes #30791 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31073


git-svn-id: http://core.svn.wordpress.org/trunk@31054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 23:32:22 +00:00
Andrew Ozz 00ff6675a2 Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167. 
Built from https://develop.svn.wordpress.org/trunk@31070


git-svn-id: http://core.svn.wordpress.org/trunk@31051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 22:48:22 +00:00
Sergey Biryukov 483e7a36d7 Use localized format for Last Updated date on Add Plugins screen. 
props tyxla.
fixes #30717.
Built from https://develop.svn.wordpress.org/trunk@31055


git-svn-id: http://core.svn.wordpress.org/trunk@31036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 01:03:23 +00:00
Scott Taylor a9302b2e36 If `IMAGE_EDIT_OVERWRITE` is defined as `true`, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical). 
Props hew.
Fixes #30394.

Built from https://develop.svn.wordpress.org/trunk@31043


git-svn-id: http://core.svn.wordpress.org/trunk@31024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 02:52:24 +00:00
Scott Taylor f79eb196df Improve the handling of comma-separated mime-types in `wp_match_mime_types()`, particularly as pertains to the mime-type selector on the Media list table screen. 
Props mdgl.
Fixes #30788.

Built from https://develop.svn.wordpress.org/trunk@31042


git-svn-id: http://core.svn.wordpress.org/trunk@31023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 02:32:22 +00:00
Scott Taylor c5f9a7c26a Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library. 
Fixes #30584.

Built from https://develop.svn.wordpress.org/trunk@31037


git-svn-id: http://core.svn.wordpress.org/trunk@31018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 08:24:22 +00:00
Scott Taylor 190165cb32 Use the `'not_found'` label when there are no items for a taxonomy in the terms list table. 
Props SergeyBiryukov.
Fixes #30586.

Built from https://develop.svn.wordpress.org/trunk@31035


git-svn-id: http://core.svn.wordpress.org/trunk@31016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 06:20:21 +00:00
Scott Taylor af0e5cc851 Inline `<script>`s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need `CDATA` comments. 
Props tw2113 for the initial patch.
See #18788.

Built from https://develop.svn.wordpress.org/trunk@31034


git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 05:46:25 +00:00
Scott Taylor 618c5b4333 When outputting JS with a `Content-Type` header: 
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.

Props sergej.mueller.
Fixes #29196.

Built from https://develop.svn.wordpress.org/trunk@31029


git-svn-id: http://core.svn.wordpress.org/trunk@31010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 02:57:21 +00:00
Scott Taylor 5e4941023b `WP_List_Table`'s constructor registers an `'admin_footer'` callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when `wp_comment_reply()` invokes the class constructor without checking for the existing instance via the `$wp_list_table` global. 
We shall check the `$wp_list_table` global in `wp_comment_reply()`.

Props sorich87.
Fixes #17413.

Built from https://develop.svn.wordpress.org/trunk@31019


git-svn-id: http://core.svn.wordpress.org/trunk@31000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-01 19:55:35 +00:00
Scott Taylor 952a5c9971 Support chromeless Vimeo via MEjs: 
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)

Fixes #29267.

Built from https://develop.svn.wordpress.org/trunk@31016


git-svn-id: http://core.svn.wordpress.org/trunk@30997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 20:41:24 +00:00
Andrew Nacin bc60e63518 Use correct function name in docs for get_plugin_data(). 
props eliorivero.
fixes #30699.

Built from https://develop.svn.wordpress.org/trunk@31008


git-svn-id: http://core.svn.wordpress.org/trunk@30989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 08:08:22 +00:00
Boone Gorges 95dba4c8c0 When no plugins are active, return an empty array from `validate_active_plugins()`. 
This creates parity with the behavior of the function when plugins *are* active,
but none are invalid. It also makes it possible to write unit tests for the
function.

Props sgrant.
Fixes #30860.
Built from https://develop.svn.wordpress.org/trunk@31003


git-svn-id: http://core.svn.wordpress.org/trunk@30984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-30 19:31:22 +00:00
Scott Taylor bc1341628f Comment List Tables: 
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@30984


git-svn-id: http://core.svn.wordpress.org/trunk@30970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 23:27:25 +00:00
Scott Taylor 786caa4d55 Correct the `@param` docs for arguments that are truthy/falsey. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30983


git-svn-id: http://core.svn.wordpress.org/trunk@30969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 23:04:23 +00:00
Scott Taylor 5eb5afac34 For clarity, initialize some arrays that previously were only assigned via short circuit in loops. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30982


git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 22:47:22 +00:00
Scott Taylor 2dbd0d0a8f In `image_size_input_fields()`: 
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.

Built from https://develop.svn.wordpress.org/trunk@30981


git-svn-id: http://core.svn.wordpress.org/trunk@30967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 22:19:24 +00:00
Scott Taylor f19bec8754 In `wp_import_handle_upload()`: 
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@30980


git-svn-id: http://core.svn.wordpress.org/trunk@30966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 21:10:24 +00:00
Scott Taylor 42f5acd869 Improve some docs for `@param`. Remove an unneeded `$wpdb` global import. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30979


git-svn-id: http://core.svn.wordpress.org/trunk@30965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 20:56:22 +00:00
Scott Taylor 574fabf2bc Improve some `wp-admin/includes/class-wp-filesystem-*.php` docs for `@param`. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30978


git-svn-id: http://core.svn.wordpress.org/trunk@30964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 20:40:23 +00:00
Dominik Schilling eccd5a5eda Pass locale to wordpress.org theme/plugin API. 
In the future this will be used to return localized plugin/theme info.

see #30735.
Built from https://develop.svn.wordpress.org/trunk@30944


git-svn-id: http://core.svn.wordpress.org/trunk@30933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-16 22:39:22 +00:00
Andrew Nacin 8c3027c3c7 Call it 'Distraction-free writing mode' and update the help string. fixes #30657. 
Built from https://develop.svn.wordpress.org/trunk@30890


git-svn-id: http://core.svn.wordpress.org/trunk@30880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-16 10:07:23 +00:00
Andrew Nacin 7b015d507d Update/add plugin recommendation strings. 
Update [30887], add a translation function to the Vine string.

fixes #30337. see #30435.

Built from https://develop.svn.wordpress.org/trunk@30889


git-svn-id: http://core.svn.wordpress.org/trunk@30879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-16 10:06:24 +00:00
Andrew Nacin 23f4b0f62f Updates to the 'Log out everywhere' implementation. 
* Include a message and a disabled button when you're only logged in at one location.
 * Avoid leaking the session token in HTML.
 * Simplify, simplify, simplify.

see #30264.

Built from https://develop.svn.wordpress.org/trunk@30888


git-svn-id: http://core.svn.wordpress.org/trunk@30878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-16 09:15:23 +00:00
Dion Hulse 5661464d35 Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API. 
See #30245

Built from https://develop.svn.wordpress.org/trunk@30860


git-svn-id: http://core.svn.wordpress.org/trunk@30850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-15 14:08:23 +00:00
Andrew Nacin 180c596d7b Rename _wp_clear_update_cache() to wp_clean_update_cache(). 
This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."

wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.

see #30369.

Built from https://develop.svn.wordpress.org/trunk@30856


git-svn-id: http://core.svn.wordpress.org/trunk@30846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-15 08:55:22 +00:00
Andrew Ozz bb67aa9d5a Improve text for the DFW admin pointer. Remove the concatenation. 
Props kpdesign, ianmjones.
See #30671.
Built from https://develop.svn.wordpress.org/trunk@30837


git-svn-id: http://core.svn.wordpress.org/trunk@30827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-12 22:12:22 +00:00
Andrew Ozz 0aa0016488 Fix the search field width in the media modal, media library grid and on the install new plugins screen. Props helen, fixes #30658. 
Built from https://develop.svn.wordpress.org/trunk@30813


git-svn-id: http://core.svn.wordpress.org/trunk@30803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-11 04:12:23 +00:00
Sergey Biryukov 0ef8e683f2 Revert [28948], which caused a regression. 
see #29573 for trunk. see #28350.
Built from https://develop.svn.wordpress.org/trunk@30791


git-svn-id: http://core.svn.wordpress.org/trunk@30781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 21:14:23 +00:00
Andrew Ozz a445806c6f Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337. 
Built from https://develop.svn.wordpress.org/trunk@30782


git-svn-id: http://core.svn.wordpress.org/trunk@30772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 23:40:24 +00:00
Andrew Ozz ef0501e1bc Better docs for `Plugin_Upgrader::deactivate_plugin_before_upgrade()`. Props DrewAPicture. Fixes #29088. 
Built from https://develop.svn.wordpress.org/trunk@30762


git-svn-id: http://core.svn.wordpress.org/trunk@30752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 01:19:24 +00:00
Andrew Ozz 1bb4b6a82b Always return a value in `Plugin_Upgrader::deactivate_plugin_before_upgrade()`. Props jdgrimes. Fixes #29088. 
Built from https://develop.svn.wordpress.org/trunk@30761


git-svn-id: http://core.svn.wordpress.org/trunk@30751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 00:53:23 +00:00
Drew Jaynes 473ebca2af Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in `WP_Upgrader`, `Plugin_Upgrader`, `Theme_Upgrader`, `Language_Pack_Upgrader`, `Core_Upgrader`, and `File_upload_Upgrader`. 
Props jdgrimes, DrewAPicture.

See #29086.

Built from https://develop.svn.wordpress.org/trunk@30758


git-svn-id: http://core.svn.wordpress.org/trunk@30748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 00:26:22 +00:00
Drew Jaynes cc4ac906dc Fix a typo in the return description for `get_sample_permalink()`. 
Props TobiasBg.
Fixes #30591.

Built from https://develop.svn.wordpress.org/trunk@30755


git-svn-id: http://core.svn.wordpress.org/trunk@30745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:46:23 +00:00
John Blackbourn bdd00b3902 Improve various hook and filter docs so they are correctly parsed for the code reference. 
Fixes #30558
Props DrewAPicture

Built from https://develop.svn.wordpress.org/trunk@30754


git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:32:24 +00:00
Drew Jaynes 23707b1ada Convert various uses of `(optional)` in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP. 
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.

Props coffee2code.
Fixes #30591.

Built from https://develop.svn.wordpress.org/trunk@30753


git-svn-id: http://core.svn.wordpress.org/trunk@30743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:24:45 +00:00
Andrew Nacin 1cf7a49ffd Adjust [29806] and revert [29807] to restore placeholder and email copy order. 
Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0.

fixes #21089.

Built from https://develop.svn.wordpress.org/trunk@30742


git-svn-id: http://core.svn.wordpress.org/trunk@30732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-05 01:15:26 +00:00
John Blackbourn 543f408098 Correct the default value of the `show_split_view` argument for revisions so they are correctly displayed side by side ins 
tead of inline.

Fixes #24908

Built from https://develop.svn.wordpress.org/trunk@30739


git-svn-id: http://core.svn.wordpress.org/trunk@30729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-04 14:36:24 +00:00
Andrew Ozz 1bb20da03b Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557. 
Built from https://develop.svn.wordpress.org/trunk@30734


git-svn-id: http://core.svn.wordpress.org/trunk@30724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 22:00:29 +00:00
Andrew Ozz 5299e95360 Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458. 
Built from https://develop.svn.wordpress.org/trunk@30730


git-svn-id: http://core.svn.wordpress.org/trunk@30720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 18:18:23 +00:00
Drew Jaynes 8df7115760 Use the correct hash notation syntax for the `WP_Filesystem_Base::dirlist()` DocBlock. 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@30722


git-svn-id: http://core.svn.wordpress.org/trunk@30712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 10:11:22 +00:00
Andrew Ozz 04c2e80c03 Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557. 
Built from https://develop.svn.wordpress.org/trunk@30718


git-svn-id: http://core.svn.wordpress.org/trunk@30708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 23:23:23 +00:00
Andrew Ozz 71d0c1c977 Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458. 
Built from https://develop.svn.wordpress.org/trunk@30717


git-svn-id: http://core.svn.wordpress.org/trunk@30707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 23:11:24 +00:00
Andrew Ozz f1dcfa9712 Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568. 
Built from https://develop.svn.wordpress.org/trunk@30711


git-svn-id: http://core.svn.wordpress.org/trunk@30701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 20:40:22 +00:00
Drew Jaynes c4b9da857a Using let's properly in inline comments lets us move on to more pressing matters of inline documentation. 
Props trepmal.
Fixes #30570.

Built from https://develop.svn.wordpress.org/trunk@30703


git-svn-id: http://core.svn.wordpress.org/trunk@30693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 04:43:22 +00:00
John Blackbourn 6fcf4ed3c5 Prevent the deletion of a theme while it has an active child theme. 
Fixes #29580
Props karpstrucking, jesin

Built from https://develop.svn.wordpress.org/trunk@30697


git-svn-id: http://core.svn.wordpress.org/trunk@30687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 02:21:24 +00:00
Drew Jaynes ad297dab6d Correctly capitalize JavaScript throughout core docs. 
Fixes #30569.

Built from https://develop.svn.wordpress.org/trunk@30695


git-svn-id: http://core.svn.wordpress.org/trunk@30685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 00:31:22 +00:00
Scott Taylor 37a23b2c73 Improve various `@param` docs. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30682


git-svn-id: http://core.svn.wordpress.org/trunk@30672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 02:17:21 +00:00
Scott Taylor 2c32752abd Improve various `@param` docs for `src/wp-admin/*`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30680


git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 01:00:22 +00:00
Scott Taylor 65ab522a51 Improve various `@param` docs for List Tables. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30679


git-svn-id: http://core.svn.wordpress.org/trunk@30669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 00:33:23 +00:00
Scott Taylor da4c39480f Improve various `@param` docs for `src/wp-admin/includes/class-wp-filesystem-*.php`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30678


git-svn-id: http://core.svn.wordpress.org/trunk@30668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 00:13:22 +00:00
Scott Taylor 67417897ec Improve the `@param` docs for `src/wp-admin/includes/plugin.php`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30668


git-svn-id: http://core.svn.wordpress.org/trunk@30658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:23:23 +00:00
Scott Taylor 562ddb8316 Use `sanitize_mime_type()` instead of `urlencode()` when string-building `<option>` values in `->get_views()` for media list tables. 
`urlencode()` was introduced in [28553] via _duck and yours truly.

Got weirder after [29625].

Props birgire.
Fixes #30123.

Built from https://develop.svn.wordpress.org/trunk@30661


git-svn-id: http://core.svn.wordpress.org/trunk@30651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 20:23:23 +00:00
Drew Jaynes 78bb3e5ff5 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*. 
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30648


git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:28:24 +00:00
Drew Jaynes 3ceb75bd8e Specify a type (array) for the `$post_data` parameter in the DocBlock for `wp_autosave()`. 
Props tillkruess.
See #30508.

Built from https://develop.svn.wordpress.org/trunk@30645


git-svn-id: http://core.svn.wordpress.org/trunk@30635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 10:01:23 +00:00
Drew Jaynes e4425165ff Improve the inline documentation for `image_edit_apply_changes()`. 
Including:
* Add a correct type (array) for the `$changes` parameter
* Add the `@since` version
* Add proper descriptions for both parameters and the return value.

Props tillkruess for the initial patch.
See #30508.

Built from https://develop.svn.wordpress.org/trunk@30644


git-svn-id: http://core.svn.wordpress.org/trunk@30634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 09:59:22 +00:00
Andrew Ozz 760e3e5fbd Editor: no pointer for DFW v2 when editor-scrolling is not used. Pass `$post_type` in the `wp_editor_expand` filter. See #30458. 
Built from https://develop.svn.wordpress.org/trunk@30641


git-svn-id: http://core.svn.wordpress.org/trunk@30631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 06:37:21 +00:00
Drew Jaynes bb380687fa Add missing DocBlocks for several functions in wp-admin/includes/ms.php. 
Props dustyf.
See #30483.

Built from https://develop.svn.wordpress.org/trunk@30630


git-svn-id: http://core.svn.wordpress.org/trunk@30620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 05:06:23 +00:00
Drew Jaynes 3699ea4155 Use the correct type (integer) for the `$menu_id` parameter in the `wp_get_nav_menu_to_edit()` DocBlock. 
Also properly mark the parameter as optional and specify the default value.

Props jaimieolmstead for the initial patch.
Fixes #30540.

Built from https://develop.svn.wordpress.org/trunk@30627


git-svn-id: http://core.svn.wordpress.org/trunk@30617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 04:25:23 +00:00
Boone Gorges c6e752b063 In `get_default_post_to_edit()`, let 'post_name' be passed to filter. 
Previously, it was being overridden after the default post had been inserted
into the database, making it cumbersome to override with the 'wp_insert_post_data'
filter.

Props danielbachhuber.
Fixes #29847.
Built from https://develop.svn.wordpress.org/trunk@30626


git-svn-id: http://core.svn.wordpress.org/trunk@30616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-29 19:26:23 +00:00
Drew Jaynes 4432dc752b 4.1 Docs Audit: Various formatting fixes for inline documentation in class-wp-list-table.php and comment-template.php. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30610


git-svn-id: http://core.svn.wordpress.org/trunk@30600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:22:23 +00:00
Drew Jaynes 659413eb98 4.1 Docs Audit: Document the `$post` global in the DocBlock for `wp_print_revision_templates()`. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30602


git-svn-id: http://core.svn.wordpress.org/trunk@30592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 09:05:23 +00:00
Drew Jaynes da589fc375 4.1 Docs Audit: Fix a variety of issues with the DocBlock for the `default_page_template_title` filter. 
Includes hyphenating 'drop-down', ensuring the DocBlock itself is correctly indented, and wraps lines at an appropriate length.

See #30469.

Built from https://develop.svn.wordpress.org/trunk@30601


git-svn-id: http://core.svn.wordpress.org/trunk@30591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 09:00:24 +00:00
Drew Jaynes 5212725fbe 4.1 Docs Audit: Convert a hook reference to an inline `@see` tag in the hook docs for the `image_add_caption_text` filter. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30600


git-svn-id: http://core.svn.wordpress.org/trunk@30590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 08:56:24 +00:00
Sergey Biryukov 0a8b72866e Add missing periods to strings introduced in [30333]. 
props DrewAPicture.
see #30264.
Built from https://develop.svn.wordpress.org/trunk@30596


git-svn-id: http://core.svn.wordpress.org/trunk@30586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 06:26:22 +00:00
Drew Jaynes a899bbaee7 Improve inline documentation in `wp_ajax_destroy_sessions()`. 
If the token is set (`$keep` is a string), this means the user is viewing their own profile-editing screen and destroying their own sessions (except the current one). If it isn't set (`$keep` is null), the user is editing another user's profile and destroying all of their sessions with no exceptions.

See #30264, #30469

Built from https://develop.svn.wordpress.org/trunk@30595


git-svn-id: http://core.svn.wordpress.org/trunk@30585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 03:48:22 +00:00
Andrew Ozz 9597159393 Better error message when the admin is ssl and non-ssl oEmbed previews are not available in the editor. Props Japh, fixes #30533. 
Built from https://develop.svn.wordpress.org/trunk@30591


git-svn-id: http://core.svn.wordpress.org/trunk@30581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-27 22:37:24 +00:00
Andrew Ozz 97c81c4507 Editor: add a pointer for the new DFW button. Remove the wp350_media and wp360_revisions pointers from the same screens. See #30458. 
Built from https://develop.svn.wordpress.org/trunk@30574


git-svn-id: http://core.svn.wordpress.org/trunk@30564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 02:54:25 +00:00
Dominik Schilling f5e4c9ee04 Improve the focus style for review links in the plugin info modal. 
props johnbillion.
fixes #30375.
Built from https://develop.svn.wordpress.org/trunk@30555


git-svn-id: http://core.svn.wordpress.org/trunk@30544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 22:59:21 +00:00
Dominik Schilling e39c43ad6c Clear update caches when site language is changed. 
The update screen has a re-install button which could show the wrong language locale after the site language was changed. That's because the update data is cached. 
Introduce `_wp_clear_update_cache()` as a helper function to clean up the update cache.

props SergeyBiryukov, ocean90.
fixes #30369.
Built from https://develop.svn.wordpress.org/trunk@30554


git-svn-id: http://core.svn.wordpress.org/trunk@30543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 22:50:22 +00:00
Drew Jaynes 4b6abbaff4 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30546


git-svn-id: http://core.svn.wordpress.org/trunk@30535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 06:31:21 +00:00
Drew Jaynes 188e47869f Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `wp_salt()`
* Backtick-escape inline code in the return description for `get_avatar()`
* Various markdown formatting in the description for `add_filter()`
* Markdown-indent a code snippet in the description for `apply_filters()`
* Backtick-escape inline code in the `@see` description for `apply_filters_ref_array()`
* Backtick-escape inline code in the description for `do_action()`
* Backtick-escape variables in the parameter and return descriptions for `do_action_ref_array()`
* Various markdown formatting in the description for `get_plugin_data()`

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30544


git-svn-id: http://core.svn.wordpress.org/trunk@30533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 06:05:23 +00:00
Drew Jaynes 9955384dbe Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30543


git-svn-id: http://core.svn.wordpress.org/trunk@30532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:53:22 +00:00
Drew Jaynes de809a5a86 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30538


git-svn-id: http://core.svn.wordpress.org/trunk@30527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:19:23 +00:00
Drew Jaynes 273396fe1e Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Backtick-escapes a `<link>` tag in a parameter description for the `embed_oembed_discover` hook
* Inline code fixes in the summary and return description for `WP_List_Table::get_table_classes()`
* Removes HTML markup from the summary for `WP_List_Table::display_rows_or_placeholder()`
* Backtick-escapes a `<tr>` tag in a parameter description for `WP_Users_List_Table::single_row()`
* Converts non-DocBlocks into multi-line comments in `WP_Dependencies::do_items()`
* Removes HTML markup from the summary for the `comment_form_top` hook.
* Inline code and snippet fixes in the description for `wp_get_schedules()`

Props rarst for the initial patch.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30537


git-svn-id: http://core.svn.wordpress.org/trunk@30526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 04:58:22 +00:00
Helen Hou-Sandí 97b412af37 Admin notices: Add more variety and make more generically usable. 
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.

Built from https://develop.svn.wordpress.org/trunk@30505


git-svn-id: http://core.svn.wordpress.org/trunk@30494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 16:41:25 +00:00
Drew Jaynes a6fc2d610b Minor syntactical adjustments to the inline documentation for the `revision_text_diff_options` hook. 
Converts backticked-inline-code to inline `@see` tags (for the full benefit of Code Reference automagical behavior).

See [30396]. See #24908.

Built from https://develop.svn.wordpress.org/trunk@30497


git-svn-id: http://core.svn.wordpress.org/trunk@30486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 03:50:24 +00:00
Andrew Nacin 58dfcb9bb0 Validate image data. 
Built from https://develop.svn.wordpress.org/trunk@30458


git-svn-id: http://core.svn.wordpress.org/trunk@30449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 15:25:22 +00:00
Jeremy Felt 3a7b5748eb Prevent wpmu_delete_blog from removing the wrong uploads directory 
`wp_upload_dir()` includes some logic to fall back to the default site's upload directory if a specific directory for the requested site cannot be found. Because of this, if `wpmu_delete_blog()` is fired twice in a row for the same site, the main site's upload directory could be deleted as well.

This adds some checks in `wpmu_delete_blog()` so that we are confident in the site and it's upload directory's existence before dropping the site. Tests are added for when `ms_files_rewriting` is enabled or disabled.

Fixes #30121

Built from https://develop.svn.wordpress.org/trunk@30404


git-svn-id: http://core.svn.wordpress.org/trunk@30399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 06:53:22 +00:00
John Blackbourn 3e3c383e79 Introduce two new filters to the post revisions screen: 
* `process_text_diff_html` for contextually filtering a diffed line. Allows for the line to be processed in a different manner to the default `htmlspecialchars`.
 * `revision_text_diff_options` for filtering the options passed to `wp_text_diff()` when viewing a post revision.

Fixes #24908
Props adamsilverstein

Built from https://develop.svn.wordpress.org/trunk@30396


git-svn-id: http://core.svn.wordpress.org/trunk@30392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-19 23:21:23 +00:00
Dion Hulse 9b9289e0a3 Background Updates: Introduce support to take advantage of Group Writable (or World Writable) to Core Background updates. 
This is only enabled when new files will not be installed during the update (as indicated by the WordPress.org API), and does not apply to Plugin/Theme/Translation Background Updates.

Additionally, the code to determine if the 'direct' filesystem transport should be used has been tweaked for wider support (where getmyuid() was unavailalbe) which fixes #10424

See #10205, #30245

Built from https://develop.svn.wordpress.org/trunk@30384


git-svn-id: http://core.svn.wordpress.org/trunk@30381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-19 05:40:23 +00:00
Drew Jaynes 6b83230aa5 Fix parameter description syntax for `WP_Screen::get_option()`. 
Props zrothauser for the initial patch.
See [30368]. Fixes #30363.

Built from https://develop.svn.wordpress.org/trunk@30369


git-svn-id: http://core.svn.wordpress.org/trunk@30367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-17 17:11:23 +00:00
Drew Jaynes bc054387d9 Add a missing `@return` description for `WP_Screen::get_option()`. 
Also declare the default value for the `$key` parameter.

Props dustyf for the initial patch.
Fixes #30363.

Built from https://develop.svn.wordpress.org/trunk@30368


git-svn-id: http://core.svn.wordpress.org/trunk@30366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-17 17:08:21 +00:00
John Blackbourn cd99d5915f Decode the sample permalink shown to the user. This avoids showing encoded non-Latin characters in the sample permalink. 
Fixes #16496
Props linuxologos

Built from https://develop.svn.wordpress.org/trunk@30364


git-svn-id: http://core.svn.wordpress.org/trunk@30363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-17 03:00:21 +00:00
John Blackbourn 7cdbac53e8 Add a filter to the displayed title of the default page template. 
Fixes #27178
Props johnstonphilip

Built from https://develop.svn.wordpress.org/trunk@30360


git-svn-id: http://core.svn.wordpress.org/trunk@30359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-16 19:32:24 +00:00
John Blackbourn d88ed475b0 Switch to a `403` response code in places where it is more appropriate than a `500` due to permissions errors. 
Fixes #10551
Props nacin

Built from https://develop.svn.wordpress.org/trunk@30356


git-svn-id: http://core.svn.wordpress.org/trunk@30355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-16 06:16:22 +00:00
John Blackbourn fd15794b5c Add some specific JSON responses when there are user permission errors for AJAX file uploads. Replace some usage of `wp_json_encode()` with `wp_send_json_*()`. 
See #25849
Props gcorne

Built from https://develop.svn.wordpress.org/trunk@30354


git-svn-id: http://core.svn.wordpress.org/trunk@30353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-16 05:47:21 +00:00
John Blackbourn a005e0b11b Display a faux revision when a post only has one revision but has an autosave. 
Fixes #29044
Props adamsilverstein

Built from https://develop.svn.wordpress.org/trunk@30353


git-svn-id: http://core.svn.wordpress.org/trunk@30352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-16 03:36:23 +00:00
Gary Pendergast e61bebdbfc If a saving a post fails, remove any invalid characters (such as emoji) from the primary text fields, then try to save it again. 
See #21212.


Built from https://develop.svn.wordpress.org/trunk@30346


git-svn-id: http://core.svn.wordpress.org/trunk@30345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 21:34:22 +00:00
John Blackbourn c02845330e Introduce a button on the user profile screen which clears all other sessions, and on the user editing screen which clears all sessions. Only appears when there are applicable sessions which can be cleared. 
See #30264.
Props jorbin, ocean90, johnbillion


Built from https://develop.svn.wordpress.org/trunk@30333


git-svn-id: http://core.svn.wordpress.org/trunk@30332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 15:21:21 +00:00
Dominik Schilling f93a197089 Fix selector for the "Live Widget Previews" feature pointer. 
props rzen.
fixes #30158.
Built from https://develop.svn.wordpress.org/trunk@30332


git-svn-id: http://core.svn.wordpress.org/trunk@30331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 12:50:22 +00:00
Dion Hulse e17d09f233 PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628 
Built from https://develop.svn.wordpress.org/trunk@30311


git-svn-id: http://core.svn.wordpress.org/trunk@30310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 10:44:23 +00:00
Dion Hulse 3e702d8b52 Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally. 
See #29628

Built from https://develop.svn.wordpress.org/trunk@30310


git-svn-id: http://core.svn.wordpress.org/trunk@30309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 03:06:23 +00:00
Drew Jaynes 92c153aa8c Fix the syntax for some status-related documentation introduced in [30155]. 
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description

See #30230.

Built from https://develop.svn.wordpress.org/trunk@30284


git-svn-id: http://core.svn.wordpress.org/trunk@30284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 20:56:22 +00:00
Drew Jaynes 7081b906f4 Fix a couple of typos in the hook documentation for the `$option` filter in wp-admin/includes/class-wp-list-table.php. 
Props bobbingwide.
Fixes #30229.

Built from https://develop.svn.wordpress.org/trunk@30227


git-svn-id: http://core.svn.wordpress.org/trunk@30227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 16:05:22 +00:00
Drew Jaynes 256bea185d Add parameter and return descriptions to the `WP_List_Table::get_pagination_arg()` DocBlock. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30225


git-svn-id: http://core.svn.wordpress.org/trunk@30225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 15:55:23 +00:00
Scott Taylor 5e3a64e83d Correct some types in `wp-admin/*`-location files' doc blocks. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30203


git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 07:09:23 +00:00
Scott Taylor 7d7a8aa0eb Correct all `@return unknown` instances. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30202


git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 06:17:22 +00:00
Scott Taylor bd2521d5ee Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/deprecated.php` (pour one out). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30201


git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 06:08:22 +00:00
Scott Taylor 196d85a9f6 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/misc.php`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30200


git-svn-id: http://core.svn.wordpress.org/trunk@30200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 06:01:24 +00:00
Scott Taylor 37f94bdfd0 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/plugin.php`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30199


git-svn-id: http://core.svn.wordpress.org/trunk@30199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:59:22 +00:00
Scott Taylor 64167f0845 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/post.php`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30198


git-svn-id: http://core.svn.wordpress.org/trunk@30198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:55:22 +00:00
Scott Taylor d9d825db72 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/taxonomy.php`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30197


git-svn-id: http://core.svn.wordpress.org/trunk@30197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:50:23 +00:00
Scott Taylor 06f49a43a1 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/template.php`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30196


git-svn-id: http://core.svn.wordpress.org/trunk@30196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:45:24 +00:00
Scott Taylor 5a3256c00b Fill in the `@param` types for the args for `make_site_theme_from_default()`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30195


git-svn-id: http://core.svn.wordpress.org/trunk@30195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:43:21 +00:00
Scott Taylor ef944e8c19 Fill in the `@param` types for the args for `make_site_theme_from_oldschool()`, which is actually the name of a function? 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30194


git-svn-id: http://core.svn.wordpress.org/trunk@30194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:41:23 +00:00
Scott Taylor 082a1d06ae Fill in the `@param` types for the args for `dbDelta()`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30193


git-svn-id: http://core.svn.wordpress.org/trunk@30193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:40:22 +00:00
Scott Taylor 8eee18ec0e Fill in types for the `@param`s for `wp_comment_reply()`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30190


git-svn-id: http://core.svn.wordpress.org/trunk@30190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:21:22 +00:00
Jeremy Felt 796ceebb25 Use common core syntax for checking DOING_AJAX 
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.

props TobiasBg
Fixes #29891

Built from https://develop.svn.wordpress.org/trunk@30177


git-svn-id: http://core.svn.wordpress.org/trunk@30177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-02 02:24:23 +00:00
Scott Taylor 73c8e4cf10 Declare the `$update_count` and `$update_current` properties for `WP_Upgrader`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30171


git-svn-id: http://core.svn.wordpress.org/trunk@30171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 23:07:23 +00:00
Scott Taylor 3fc8778359 Declare the `$options` property for `WP_Upgrader_Skin`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30170


git-svn-id: http://core.svn.wordpress.org/trunk@30170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 23:03:22 +00:00
Scott Taylor 4d0f66854a Fix the return value doc for `WP_List_Table->get_pagination_arg()`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30169


git-svn-id: http://core.svn.wordpress.org/trunk@30169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 23:00:23 +00:00
Scott Taylor 6a109700d0 In `wp_ajax_get_tagcloud()`, bail immediately if `$_POST['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30168


git-svn-id: http://core.svn.wordpress.org/trunk@30168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 22:54:22 +00:00
Scott Taylor a786fb779c In `wp_ajax_ajax_tag_search()`, bail immediately if `$_GET['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30167


git-svn-id: http://core.svn.wordpress.org/trunk@30167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 22:48:22 +00:00
Scott Taylor 60b73c589c Display error message when Media Library upload fails. 
Props gcorne.
Fixes #29891.

Built from https://develop.svn.wordpress.org/trunk@30156


git-svn-id: http://core.svn.wordpress.org/trunk@30156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 20:25:23 +00:00
Scott Taylor be08f576df Improve some `post_status`-related documentation. 
Props ericlewis.
See #30230.

Built from https://develop.svn.wordpress.org/trunk@30155


git-svn-id: http://core.svn.wordpress.org/trunk@30155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 20:20:23 +00:00
Scott Taylor 0b9c1be743 In `WP_List_Table`, add a property, `$modes`, to allow `WP_Media_List_Table` to inherit `->view_switcher()`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30154


git-svn-id: http://core.svn.wordpress.org/trunk@30154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 19:56:24 +00:00
Boone Gorges 96b42c2fdc Allow resource_type to be specified in `get_ancestors()`. 
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.

Props filosofo.
Fixes #15029.
Built from https://develop.svn.wordpress.org/trunk@30141


git-svn-id: http://core.svn.wordpress.org/trunk@30141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 02:58:23 +00:00
Boone Gorges e9f6ee53bb Fix database schema update introduced in [30121]. 
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.

Fixes #22023.
Built from https://develop.svn.wordpress.org/trunk@30134


git-svn-id: http://core.svn.wordpress.org/trunk@30134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 01:11:22 +00:00
Scott Taylor a4963672d6 Add a single responsibility function for outputting Revisions JS templates: `wp_print_revision_templates()`. 
Use it in `wp-admin/revision.php`.

Props ericlewis.
Fixes #30220.

Built from https://develop.svn.wordpress.org/trunk@30129


git-svn-id: http://core.svn.wordpress.org/trunk@30129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 00:15:24 +00:00
Drew Jaynes 66c47f29bb Correct references of `@uses $wpdb` in core documentation to use `@global`. 
See #30191, [30105].
Fixes #30217.

Built from https://develop.svn.wordpress.org/trunk@30122


git-svn-id: http://core.svn.wordpress.org/trunk@30122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 17:56:22 +00:00
Boone Gorges 70631df84a Bump db_version and add upgrade routine for schema change in [30056]. 
Fixes #22023.
Built from https://develop.svn.wordpress.org/trunk@30121


git-svn-id: http://core.svn.wordpress.org/trunk@30121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 16:03:22 +00:00
Drew Jaynes f8657d5890 Remove redundant and erroneous `@uses` tag from most core inline documentation. 
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.

Built from https://develop.svn.wordpress.org/trunk@30105


git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 01:05:24 +00:00
John Blackbourn a866a7192f Introduce some actions and filters which aid plugins in revisioning post meta. 
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
 * `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
 * `wp_creating_autosave` action which is fired just before an autosave is created.

See #20564.
Props mattheu, adamsilverstein.

Built from https://develop.svn.wordpress.org/trunk@30091


git-svn-id: http://core.svn.wordpress.org/trunk@30091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-29 19:02:21 +00:00
Scott Taylor ee97a47c61 In `_wp_handle_upload()`, if `test_upload` is set to `false` in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage. 
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.

`$test_upload` override is now a noop.

Fixes #28208.

Built from https://develop.svn.wordpress.org/trunk@30076


git-svn-id: http://core.svn.wordpress.org/trunk@30076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-28 21:17:22 +00:00
Boone Gorges 502bc03090 Remove UNIQUE key from 'slug' column of terms table. 
Each slug is a unique and beautiful snowflake, but let's enforce that
uniqueness elsewhere.

Props hotchkissconsulting.
Fixes #22023.
Built from https://develop.svn.wordpress.org/trunk@30056


git-svn-id: http://core.svn.wordpress.org/trunk@30056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-28 18:37:18 +00:00
Gary Pendergast 007ec52958 Add `wp_json_encode()`, a wrapper for `json_encode()` that ensures everything is converted to UTF-8. 
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.


Built from https://develop.svn.wordpress.org/trunk@30055


git-svn-id: http://core.svn.wordpress.org/trunk@30055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-28 18:35:19 +00:00
Sergey Biryukov 3badb558f6 Remove one-time loop and redundant isset() checks in do_meta_boxes(). 
See [30022] for do_accordion_sections().

props ipm-frommen.
fixes #30093.
Built from https://develop.svn.wordpress.org/trunk@30040


git-svn-id: http://core.svn.wordpress.org/trunk@30040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-27 12:58:19 +00:00
Drew Jaynes f5cc9ba1be Add a missing asterisk in the DocBlock for `write_post()`. 
Also removes several `@uses` tags, which are no longer leveraged as part of the inline documentation standard.

Props tareq1988.
Fixes #30118.

Built from https://develop.svn.wordpress.org/trunk@30034


git-svn-id: http://core.svn.wordpress.org/trunk@30034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-26 23:56:18 +00:00
Sergey Biryukov 1bd594f033 Remove one-time loop and redundant isset() checks. 
props ipm-frommen.
fixes #30093.
Built from https://develop.svn.wordpress.org/trunk@30022


git-svn-id: http://core.svn.wordpress.org/trunk@30022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-25 16:34:18 +00:00
Drew Jaynes 3ad681b2ef Fix an invalid type for the `$section` parameter in the `do_settings_fields()` DocBlock. 
Props ipm-frommen.
See #30098.

Built from https://develop.svn.wordpress.org/trunk@30018


git-svn-id: http://core.svn.wordpress.org/trunk@30018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-25 13:38:23 +00:00
Sergey Biryukov 2c8e435aa5 Fix copy/paste errors in [27769]. 
props Corphi.
fixes #30054.
Built from https://develop.svn.wordpress.org/trunk@29977


git-svn-id: http://core.svn.wordpress.org/trunk@29723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-20 21:35:18 +00:00
Dion Hulse dbbd9fb5ec Filesystem: Fix the move() method of the SSH2 transport, which was using the SSH2 link rather than the SFTP link. 
Props nobleclem. Fixes #29405

Built from https://develop.svn.wordpress.org/trunk@29970


git-svn-id: http://core.svn.wordpress.org/trunk@29716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-20 07:46:19 +00:00
Dion Hulse 6792506741 Avoid a PHP Notice in the PemFTP Library by adding a missing function parameter. This parameter is unused by WordPress. 
Props hugodelgado. Fixes #29628

Built from https://develop.svn.wordpress.org/trunk@29969


git-svn-id: http://core.svn.wordpress.org/trunk@29715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-20 07:41:19 +00:00
Boone Gorges 24babfddb3 Allow apostrophes in email addresses when adding users via the Dashboard. 
Email addresses entered in a number of interfaces were not being stripslashed
properly, with the result that the emails were not being recognized as valid.

Fixes #18039.
Built from https://develop.svn.wordpress.org/trunk@29966


git-svn-id: http://core.svn.wordpress.org/trunk@29713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-19 20:30:19 +00:00
Sergey Biryukov 15a1e0731e Use proper functions for escaped translations. 
pros jcastaneda.
fixes #30012.
Built from https://develop.svn.wordpress.org/trunk@29961


git-svn-id: http://core.svn.wordpress.org/trunk@29708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-18 20:11:18 +00:00
Dominik Schilling 61819a36ea Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific. 
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.
Built from https://develop.svn.wordpress.org/trunk@29903


git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-15 17:21:19 +00:00
Sergey Biryukov 16a55620c3 Twenty Fifteen: Update some more bundled theme references after [29895]. 
see #29799.
Built from https://develop.svn.wordpress.org/trunk@29900


git-svn-id: http://core.svn.wordpress.org/trunk@29655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-15 14:35:18 +00:00
Sergey Biryukov e5d518abee Avoid PHP notices if 'plugin' is not set for tab=plugin-information. 
props avryl.
fixes #29936.
Built from https://develop.svn.wordpress.org/trunk@29882


git-svn-id: http://core.svn.wordpress.org/trunk@29638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-12 13:06:19 +00:00
Sergey Biryukov 471dc2022f Add missing label to comment type filter dropdown. 
props afercia.
fixes #29922.
Built from https://develop.svn.wordpress.org/trunk@29872


git-svn-id: http://core.svn.wordpress.org/trunk@29631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-11 02:26:18 +00:00
Sergey Biryukov f013b7e64b Remove "View" prefix from category filter dropdowns, for consistency with [27626]. 
props afercia.
see #29921.
Built from https://develop.svn.wordpress.org/trunk@29871


git-svn-id: http://core.svn.wordpress.org/trunk@29630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-11 02:23:18 +00:00
Sergey Biryukov 2c0947eeee Add missing labels to category filter dropdowns. 
props afercia.
fixes #29921.
Built from https://develop.svn.wordpress.org/trunk@29870


git-svn-id: http://core.svn.wordpress.org/trunk@29629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-11 02:21:19 +00:00
Dominik Schilling 57c41263d7 Language packs: Remove translations when deleting a theme or a plugin. 
This is for translation files in WP_LANG_DIR which are installed through a language pack.
Change `wp_get_installed_translations()` to only return a translation if the .mo file also exists.

fixes #29860.
Built from https://develop.svn.wordpress.org/trunk@29856


git-svn-id: http://core.svn.wordpress.org/trunk@29619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-08 19:05:20 +00:00
Dominik Schilling 04edb0a1d6 Update jQuery UI to 1.11.1. 
Because jQUI's build process no longer provides individual minified files we need some additional changes:
* Rename all files, remove the "jquery.ui." prefix. Add old files to `$_old_files`.
* Add and use non-minified files in /src.
* Add grunt task to minify jQuery UI files.
* (Non-minified files will not be shipped.)

Changelogs:
* http://jqueryui.com/changelog/1.11.0/
* http://jqueryui.com/changelog/1.11.1/

props Fab1en, ocean90.
fixes #29833.
Built from https://develop.svn.wordpress.org/trunk@29847


git-svn-id: http://core.svn.wordpress.org/trunk@29610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-07 15:28:24 +00:00
Dominik Schilling 197f0a30a4 Plugin search: Wrap results in a form to fix pagination's `paged` input field. 
props jesin, ocean90.
see #18724, for trunk.
Built from https://develop.svn.wordpress.org/trunk@29829


git-svn-id: http://core.svn.wordpress.org/trunk@29594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-03 13:08:16 +00:00
Sergey Biryukov e59c624ef6 Use correct links for filtering plugin reviews. 
props OriginalEXE.
fixes #29754.
Built from https://develop.svn.wordpress.org/trunk@29826


git-svn-id: http://core.svn.wordpress.org/trunk@29591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-03 08:09:17 +00:00
Scott Taylor 59ef20d458 In `activate_plugin()`, do not re-run the activation routine for already-active network-wide plugins. 
Adds unit test.

Props jbrinley.
Fixes #28651.

Built from https://develop.svn.wordpress.org/trunk@29818


git-svn-id: http://core.svn.wordpress.org/trunk@29584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-02 15:56:14 +00:00
Scott Taylor cf31ee092b Media List Table: account for `MEDIA_TRASH` in the bulk action dropdown. 
See #29742.

Built from https://develop.svn.wordpress.org/trunk@29810


git-svn-id: http://core.svn.wordpress.org/trunk@29576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-02 03:12:18 +00:00
Sergey Biryukov be631b3f1b Reorder placeholders for consistency. see [29806]. 
see #21089.
Built from https://develop.svn.wordpress.org/trunk@29807


git-svn-id: http://core.svn.wordpress.org/trunk@29573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-02 01:38:15 +00:00
Scott Taylor 258496edb6 In the `wp_new_blog_notification()` email template, include the login url. 
Props obenland, georgestephanis.
Fixes #21089.

Built from https://develop.svn.wordpress.org/trunk@29806


git-svn-id: http://core.svn.wordpress.org/trunk@29572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-02 01:28:16 +00:00
Mark Jaquith e1f2b3b9e2 Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org) 
see #27115
Built from https://develop.svn.wordpress.org/trunk@29789


git-svn-id: http://core.svn.wordpress.org/trunk@29561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-29 13:37:16 +00:00
Mark Jaquith 0d3b83551f Use HTTPS URLs for core.trac.wordpress.org 
see #27115
Built from https://develop.svn.wordpress.org/trunk@29788


git-svn-id: http://core.svn.wordpress.org/trunk@29560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-29 13:28:16 +00:00
Mark Jaquith 184fa46699 Use HTTPS links for planet.wordpress.org 
see #27115
Built from https://develop.svn.wordpress.org/trunk@29787


git-svn-id: http://core.svn.wordpress.org/trunk@29559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-29 13:24:15 +00:00
Mark Jaquith 28bf972789 Show the number of approved comments instead of all comments on 
the dashboard in the "At a glance" section.

fixes #26738. props benjmay
Built from https://develop.svn.wordpress.org/trunk@29785


git-svn-id: http://core.svn.wordpress.org/trunk@29557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-29 12:42:16 +00:00
Andrew Ozz 7a55ab9164 Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk. 
Built from https://develop.svn.wordpress.org/trunk@29776


git-svn-id: http://core.svn.wordpress.org/trunk@29548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-29 00:14:18 +00:00
Sergey Biryukov 9bf3007b55 Remove unnecessary CSS overriding on Add Plugins screen. 
props pavelevap.
fixes #29753.
Built from https://develop.svn.wordpress.org/trunk@29775


git-svn-id: http://core.svn.wordpress.org/trunk@29547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-28 20:26:17 +00:00
Sergey Biryukov ebdfe06843 Don't display an empty comment author IP link on Comments screen. 
props afercia.
fixes #29766.
Built from https://develop.svn.wordpress.org/trunk@29774


git-svn-id: http://core.svn.wordpress.org/trunk@29546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-28 06:38:18 +00:00
Sergey Biryukov dfe7775465 Remove extra space from a string. 
props pavelevap.
fixes #29752.
Built from https://develop.svn.wordpress.org/trunk@29767


git-svn-id: http://core.svn.wordpress.org/trunk@29539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-26 18:49:19 +00:00
Scott Taylor 2f328cc4c1 In `wp_ajax_replyto_comment()`, if `$_POST['comment_type']` is set, use it for the value of `$comment_type`, which the `compact()` call has assumed is set since [8720]. It never was. 
`wp_comment_reply()`'s output can be complete overridden by the `wp_comment_reply` filter, so this check is justified and makes the AJAX callback more flexible.

Props nerrad.
Fixes #29704.

Built from https://develop.svn.wordpress.org/trunk@29758


git-svn-id: http://core.svn.wordpress.org/trunk@29530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-23 03:29:16 +00:00
Scott Taylor 9768b89cc7 If the current user does not have the `delete_posts` cap on the current post type, don't list `delete` or `trash` as bulk actions for the relevant context of Post list table. 
Props mvd7793.
Fixes #20175.

Built from https://develop.svn.wordpress.org/trunk@29757


git-svn-id: http://core.svn.wordpress.org/trunk@29529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-23 02:58:16 +00:00
Sergey Biryukov 26124b9aad Pass the attachment ID to the 'image_add_caption_text' filter. 
fixes #29607.
Built from https://develop.svn.wordpress.org/trunk@29754


git-svn-id: http://core.svn.wordpress.org/trunk@29526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-21 10:11:16 +00:00
Sergey Biryukov 79d017a024 Add 'image_add_caption_text' filter for changing the pre-parse caption text before output to the editor. 
props collinsinternet, DrewAPicture.
fixes #29607.
Built from https://develop.svn.wordpress.org/trunk@29753


git-svn-id: http://core.svn.wordpress.org/trunk@29525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-21 09:56:17 +00:00
Andrew Nacin 1447092f6e Don't set ftp_credentials option when installling. see #29635. 
Built from https://develop.svn.wordpress.org/trunk@29749


git-svn-id: http://core.svn.wordpress.org/trunk@29521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-17 17:58:15 +00:00
Scott Taylor d0a327b0b9 Make the URL output in `_thickbox_path_admin_subfolder()` use `includes_url()`. 
Props voldemortensen.
Fixes #14157.

Built from https://develop.svn.wordpress.org/trunk@29741


git-svn-id: http://core.svn.wordpress.org/trunk@29515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-12 22:31:18 +00:00
Scott Taylor 69998d452b In `media_handle_upload()`, don't call `wp_read_image_metadata()` on things that aren't images (like videos). We never caught this error, because we are suppressing it by calling `@wp_read_image_metadata()`. 
Props jrf for the initial patch.
Fixes #28907.

Built from https://develop.svn.wordpress.org/trunk@29737


git-svn-id: http://core.svn.wordpress.org/trunk@29511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-11 20:15:17 +00:00
Andrew Ozz 69e7171f41 Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602 
Built from https://develop.svn.wordpress.org/trunk@29729


git-svn-id: http://core.svn.wordpress.org/trunk@29503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-10 22:40:16 +00:00
Scott Taylor fa0acbe3bb Don't overwrite the `length` property unnecessarily when generating metadata for audio and video files. 
Props jrf, wonderboymusic.
Fixes #29176.

Built from https://develop.svn.wordpress.org/trunk@29728


git-svn-id: http://core.svn.wordpress.org/trunk@29502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-10 21:57:15 +00:00
Sergey Biryukov 1eb26d3ff3 Use https for apps.wordpress.org links. 
props pento.
fixes #29595 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29721


git-svn-id: http://core.svn.wordpress.org/trunk@29495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-09 06:29:15 +00:00
Andrew Nacin f7392ef917 Pinking shears. 
Built from https://develop.svn.wordpress.org/trunk@29707


git-svn-id: http://core.svn.wordpress.org/trunk@29481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-04 15:23:16 +00:00
Andrew Nacin 00fac0639d Link to apps.wordpress.org instead of wordpress.org/mobile. 
props pento.
fixes #29496.

Built from https://develop.svn.wordpress.org/trunk@29703


git-svn-id: http://core.svn.wordpress.org/trunk@29477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-04 14:22:15 +00:00
Sergey Biryukov 2ff943b7b0 Restore the post type's view_item label for preview links that don't submit the changes. 
fixes #28350.
Built from https://develop.svn.wordpress.org/trunk@29695


git-svn-id: http://core.svn.wordpress.org/trunk@29470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-03 11:33:16 +00:00
Dominik Schilling de59e21b62 Language Pack Upgrader: Allow to disable asynchronously translation updates. 
* Don't touch VCS installs.
* Use the `async_update_translation` filter (which corresponds exactly to `auto_update_translation`) to entirely disable it, or based on the update offer. 

props nacin, ocean90.
fixes #28571.
Built from https://develop.svn.wordpress.org/trunk@29694


git-svn-id: http://core.svn.wordpress.org/trunk@29469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-03 10:38:17 +00:00
Andrew Nacin 8a9186b878 Media Library: Fix media trash handling. 
props ocean90, obenland.
fixes #29469.

Built from https://develop.svn.wordpress.org/trunk@29690


git-svn-id: http://core.svn.wordpress.org/trunk@29465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-03 06:47:16 +00:00
Dion Hulse e8f6320bb4 Language Pack Upgrader: Remove ALL pre-existing filters before performing a translation update these filters may act in an unexpected way during the upgrade process. 
See #29230. Fixes #29425.

Built from https://develop.svn.wordpress.org/trunk@29685


git-svn-id: http://core.svn.wordpress.org/trunk@29460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-03 05:38:14 +00:00
Andrew Nacin 4080e96339 Ensure oEmbed previews listen to [embed] width/height attributes. 
props azaozz.
fixes #29474.

Built from https://develop.svn.wordpress.org/trunk@29681


git-svn-id: http://core.svn.wordpress.org/trunk@29456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-03 00:40:16 +00:00
Helen Hou-Sandí 433210a907 Plugin install: Better styling to accommodate plugin icons. 
fixes #29466.

Built from https://develop.svn.wordpress.org/trunk@29679


git-svn-id: http://core.svn.wordpress.org/trunk@29454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-02 19:47:16 +00:00
Dominik Schilling c6af00d8b0 Language Pack Upgrader: Check return value before accessing the first array key. 
Prevents a fatal error when Language_Pack_Upgrader::bulk_upgrade() returns a WP_Error object.

fixes #29470.
Built from https://develop.svn.wordpress.org/trunk@29675


git-svn-id: http://core.svn.wordpress.org/trunk@29450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-02 18:28:17 +00:00
Dominik Schilling 81d600dcca Install: Only show the language chooser when we have access to the filesystem without asking for credentials. 
fixes #29397.
Built from https://develop.svn.wordpress.org/trunk@29673


git-svn-id: http://core.svn.wordpress.org/trunk@29448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-02 18:07:18 +00:00
Sergey Biryukov 5faf09a261 Restore 'insert-media-button' as an ID attribute for the first instance of media_buttons(). Remove IDs for subsequent instances. 
props nacin.
fixes #28090.
Built from https://develop.svn.wordpress.org/trunk@29671


git-svn-id: http://core.svn.wordpress.org/trunk@29445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-02 09:08:16 +00:00
Andrew Nacin 683238567d Plugin install: The sort callback doesn't need to be public. 
props helen.
fixes #28673.

Built from https://develop.svn.wordpress.org/trunk@29666


git-svn-id: http://core.svn.wordpress.org/trunk@29440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-02 06:51:16 +00:00
Helen Hou-Sandí b80c5d3e51 Comments: Simplify JS for inline edit and reply. 
fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@29662


git-svn-id: http://core.svn.wordpress.org/trunk@29436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-02 03:57:18 +00:00
Helen Hou-Sandí 6926e9aea6 Media: Translate a string for the search placeholder. 
props alex-ye.
fixes #29448.

Built from https://develop.svn.wordpress.org/trunk@29659


git-svn-id: http://core.svn.wordpress.org/trunk@29433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-01 19:54:16 +00:00
Helen Hou-Sandí 42afb446db Media: `views_upload` filter expects an array, not a string. 
see #28946.

Built from https://develop.svn.wordpress.org/trunk@29641


git-svn-id: http://core.svn.wordpress.org/trunk@29415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-27 03:06:27 +00:00
Andrew Nacin 69204000ca Adjust [29634] so the Upload Plugin button can be shown. see #29236. 
Built from https://develop.svn.wordpress.org/trunk@29637


git-svn-id: http://core.svn.wordpress.org/trunk@29411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-27 02:59:16 +00:00
Andrew Nacin 8f6fbcdc52 Plugin installer: Minor adjustments to aid with discovery. 
fixes #29387.

Built from https://develop.svn.wordpress.org/trunk@29636


git-svn-id: http://core.svn.wordpress.org/trunk@29410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-27 02:53:16 +00:00
Andrew Nacin ac3dd27737 Plugin/Theme Uploads: New capabilities; unify UIs; ensure compatibility with old filters. 
Introduce upload_plugins and upload_themes capabilities to allow blocking of plugin and theme uploads, versus the old hacky (and not secure) ways of just hiding UI tabs. These are simply meta capabilities that map to install_plugins and install_themes.
 
Also:
 * Use the same nice design for the plugin upload screen as the theme upload screen.
 * Better compatibility for the old install_themes_tabs filter added in [29002]. see #28578.
 * Ensure using the install_plugins_tabs filter to remove the upload tab removes the new button.
 * Use 'Add Plugins' instead of 'Install Plugins' to match 'Add Themes'.

fixes #29236.

Built from https://develop.svn.wordpress.org/trunk@29634


git-svn-id: http://core.svn.wordpress.org/trunk@29408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-27 01:32:18 +00:00
Dominik Schilling a32210ef42 Language Form: The language option for `$wp_local_package` should get the same attributes as the other languages. 
see #15677.
Built from https://develop.svn.wordpress.org/trunk@29633


git-svn-id: http://core.svn.wordpress.org/trunk@29407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-26 22:27:16 +00:00
Dominik Schilling d544610681 Language packs: No WPLANG anymore. 
* The WPLANG constant is no longer needed. Remove define('WPLANG', ''); from wp-config-sample.php. Populate WPLANG option based on the WPLANG constant. When get_option('WPLANG') is an empty string it will override WPLANG.
* Introduce translations_api() which is available to communicate with the translation API. Move translation install related functions to a new file.
* Replace mu_dropdown_languages() with wp_dropdown_languages(). wp_dropdown_languages() is now populated by the translation API.
* Remove wp_install_load_language() and allow load_default_textdomain() to switch a core translation.

fixes #13069, #15677, #19760, #28730, #29281. 
Built from https://develop.svn.wordpress.org/trunk@29630


git-svn-id: http://core.svn.wordpress.org/trunk@29404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-26 19:59:16 +00:00
Helen Hou-Sandí 9e8b9a78ca Media library: Unify headers between view modes. 
Includes back compat for `views_upload` links. These look a little awkward, but do not appear to be commonly used. Also prevents the view mode links from being dropped on smaller screens so a user doesn't get "stuck" in the list view.

This is different from other list tables, but aligns well with other uploaded content management screens (themes, plugins).

props pento, helen.
fixes #28946.

Built from https://develop.svn.wordpress.org/trunk@29625


git-svn-id: http://core.svn.wordpress.org/trunk@29399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-26 15:58:15 +00:00
Dominik Schilling 32030a073f RTL: Fix modal alignments. 
* Prevent horizontal scrollbars in Chrome.
* URL fields should be always LTR.
* Force the plugin details to be LTR for all screens, see #19778.

fixes #29352.
Built from https://develop.svn.wordpress.org/trunk@29623


git-svn-id: http://core.svn.wordpress.org/trunk@29397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-26 12:55:16 +00:00
Dominik Schilling 9972b54e62 Theme Upgrader: Set `is_multi` to true when doing bulk upgrades. 
fixes #29234.
Built from https://develop.svn.wordpress.org/trunk@29622


git-svn-id: http://core.svn.wordpress.org/trunk@29396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-26 09:24:17 +00:00
Dominik Schilling 5a67538b40 Language Pack Upgrader: Remove any pre-existing package checks and then set the new one for translations. 
fixes #29230.
Built from https://develop.svn.wordpress.org/trunk@29621


git-svn-id: http://core.svn.wordpress.org/trunk@29395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-26 09:20:18 +00:00
Scott Taylor 149346ff6e MCE View sandboxes: 
* Use a `MutationObserver` to listen to the `body` class of the parent editor frame.
* In `wpview_media_sandbox_styles()`, only return the MEjs stylesheets.
* In `wp_ajax_parse_media_shortcode()` and `wp_ajax_parse_embed()`, return an object instead of an HTML blob to allow passing `body` and `head` separately	

Props avryl, azaozz.
Fixes #29048.

Built from https://develop.svn.wordpress.org/trunk@29615


git-svn-id: http://core.svn.wordpress.org/trunk@29389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-26 04:46:15 +00:00
Helen Hou-Sandí b1b7d5f3a2 Only show one search form for the plugin installer. 
The field dropdown now appears in the filter bar only when doing a search.

see #28785.

Built from https://develop.svn.wordpress.org/trunk@29597


git-svn-id: http://core.svn.wordpress.org/trunk@29371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-25 16:03:16 +00:00
Andrew Nacin 4261ce75a6 Plugins: Only show details link if user can install plugins. 
fixes #17902.

Built from https://develop.svn.wordpress.org/trunk@29595


git-svn-id: http://core.svn.wordpress.org/trunk@29369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-25 15:28:17 +00:00
Sergey Biryukov b06652da92 Install Plugins: Don't wp_die() if API can't be reached. 
props johnbillion.
fixes #29361.
Built from https://develop.svn.wordpress.org/trunk@29594


git-svn-id: http://core.svn.wordpress.org/trunk@29368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-25 15:02:17 +00:00
Andrew Nacin 491f5cec39 Screen: Move editor scrolling screen option to the proper place. 
see [29336], see #28328.

Built from https://develop.svn.wordpress.org/trunk@29588


git-svn-id: http://core.svn.wordpress.org/trunk@29362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-24 17:57:16 +00:00
Andrew Nacin bb4db92621 Plugin install: Add icons to compatible/incompatible. see #29313. 
Built from https://develop.svn.wordpress.org/trunk@29586


git-svn-id: http://core.svn.wordpress.org/trunk@29360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-24 17:26:15 +00:00
Dominik Schilling 3a980c39c8 Apply accessibility improvements to Plugins screen too. 
props SergeyBiryukov.
fixes #29342.
Built from https://develop.svn.wordpress.org/trunk@29583


git-svn-id: http://core.svn.wordpress.org/trunk@29357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-24 16:22:16 +00:00
Dominik Schilling 49937c88f9 Plugin compatibility is based on your version of WordPress, not your install. 
fixes #29313.
Built from https://develop.svn.wordpress.org/trunk@29581


git-svn-id: http://core.svn.wordpress.org/trunk@29355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-24 16:14:16 +00:00
Dominik Schilling 6c9853930a Add missing array keys for connection type in `request_filesystem_credentials()`. 
see [28456].
fixes #29347.

Built from https://develop.svn.wordpress.org/trunk@29580


git-svn-id: http://core.svn.wordpress.org/trunk@29354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-24 16:04:18 +00:00
Andrew Ozz 42258a6d89 TinyMCE wpView: fix showing errors for non-embeddable URLs, no-ssl or no items. Props avryl, fixes #29114, see #29268. 
Built from https://develop.svn.wordpress.org/trunk@29577


git-svn-id: http://core.svn.wordpress.org/trunk@29351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-22 18:55:15 +00:00
Sergey Biryukov 039df6aac6 Plugin compatibility warnings should be red, not green. 
props avryl.
fixes #29309.
Built from https://develop.svn.wordpress.org/trunk@29574


git-svn-id: http://core.svn.wordpress.org/trunk@29348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-22 03:57:19 +00:00
Andrew Nacin e32fc4df46 Export: Add wxr_export_skip_commentmeta filter to match the _postmeta filter. 
props cfinke.
fixes #28745.

Built from https://develop.svn.wordpress.org/trunk@29573


git-svn-id: http://core.svn.wordpress.org/trunk@29347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-22 01:48:17 +00:00
Andrew Nacin 0eed9373e2 Introduce plugin icons in the installer. 
See http://wp.me/p2AvED-2P8 for the announcement and how to implement these.

props tellyworth.
see #28785.

Built from https://develop.svn.wordpress.org/trunk@29569


git-svn-id: http://core.svn.wordpress.org/trunk@29343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-21 19:11:17 +00:00
Andrew Ozz 53c047263b TinyMCE wpView: add a filter for the stylesheet URLs loaded in the sandbox iframes. See #29048. 
Built from https://develop.svn.wordpress.org/trunk@29559


git-svn-id: http://core.svn.wordpress.org/trunk@29334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-20 21:34:15 +00:00
Dominik Schilling 048b96f80d Media: Remove scan for lost attachments. 
This hasn't been worked for 4 years.

fixes #29169.

Built from https://develop.svn.wordpress.org/trunk@29550


git-svn-id: http://core.svn.wordpress.org/trunk@29326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-20 17:09:15 +00:00
Andrew Ozz bb862e8221 TinyMCE wpView: show an error when no items are found while parsing a audio/video/playlist shortcode. Props avryl, fixes #29114. 
Built from https://develop.svn.wordpress.org/trunk@29546


git-svn-id: http://core.svn.wordpress.org/trunk@29322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-19 23:23:16 +00:00
Sergey Biryukov c17155f9d7 * Add span to the list of allowed tags in plugin sections in plugin details modal. 
* Don't strip class attribute from div/span tags in plugin sections.

props tellyworth.
see #28884.
Built from https://develop.svn.wordpress.org/trunk@29511


git-svn-id: http://core.svn.wordpress.org/trunk@29288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-16 03:07:18 +00:00
Dominik Schilling 00aaf8de18 Plugin details: Use translation functions. 
props jesin.
fixes #29220.
Built from https://develop.svn.wordpress.org/trunk@29510


git-svn-id: http://core.svn.wordpress.org/trunk@29287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-15 20:51:16 +00:00
Dominik Schilling 7297f60992 Plugin details: Escape the donate link. 
see #27440.
Built from https://develop.svn.wordpress.org/trunk@29506


git-svn-id: http://core.svn.wordpress.org/trunk@29283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-15 17:17:16 +00:00
Dominik Schilling 1f20c88b68 Plugin install: Remove columns and screen options. 
fixes #28803.
Built from https://develop.svn.wordpress.org/trunk@29498


git-svn-id: http://core.svn.wordpress.org/trunk@29276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-15 09:38:15 +00:00
Scott Taylor 571111022e Media Grid, support `MEDIA_TRASH`: 
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.

Props koop for the knowledge sharing and thought partnership.
See #29145.

Built from https://develop.svn.wordpress.org/trunk@29490


git-svn-id: http://core.svn.wordpress.org/trunk@29268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-14 18:31:19 +00:00
Drew Jaynes d33c807723 Fix some documentation typos in various core files. 
Props vlajos.
Fixes #29199.

Built from https://develop.svn.wordpress.org/trunk@29479


git-svn-id: http://core.svn.wordpress.org/trunk@29257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-13 03:56:17 +00:00
Sergey Biryukov aed71de2d6 Plugin install: Make plugin groups translatable. 
props ocean90 for initial patch.
fixes #29092.
Built from https://develop.svn.wordpress.org/trunk@29477


git-svn-id: http://core.svn.wordpress.org/trunk@29255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-13 02:31:18 +00:00
Helen Hou-Sandí 093772f3c0 Plugin details modal: 
* Scroll all content, rather than the dual-pane scrolling awkwardness.
* Better align the header image and title overlay with the display on WordPress.org, at least at full-width.
* Move the close button outside of the modal itself, rather than overlay on top of colors we can't predict.

props stephdau, tellyworth, helen. fixes #27440.

Built from https://develop.svn.wordpress.org/trunk@29474


git-svn-id: http://core.svn.wordpress.org/trunk@29252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-12 23:02:16 +00:00
Drew Jaynes d60a081137 Add `@access` tags to constructor docblocks in list table classes. 
See #28679. See [29459].

Built from https://develop.svn.wordpress.org/trunk@29460


git-svn-id: http://core.svn.wordpress.org/trunk@29238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-10 02:22:16 +00:00
Drew Jaynes 8e86454467 Document default arguments for the `WP_List_Table` class. Also add referenced docblocks to extending class constructors. 
Props mikejolley for the initial patch.
Fixes #28679. See #28298.

Built from https://develop.svn.wordpress.org/trunk@29459


git-svn-id: http://core.svn.wordpress.org/trunk@29237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-10 02:18:17 +00:00
Drew Jaynes 647b6d907b Clean up some missing `@access` tags and other tweaks for 4.0.0-functionality docs. 
See #28885.

Built from https://develop.svn.wordpress.org/trunk@29455


git-svn-id: http://core.svn.wordpress.org/trunk@29233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-09 19:32:16 +00:00
Drew Jaynes a8583d5f19 Fix some words that aren't words. 
See #28885.

Built from https://develop.svn.wordpress.org/trunk@29454


git-svn-id: http://core.svn.wordpress.org/trunk@29232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-09 19:30:17 +00:00
Dominik Schilling 09e61f534b WP_Plugins_List_Table::bulk_actions() method declaration should match WP_List_Table, see [29440]. 
props imath.
fixes #29148.
Built from https://develop.svn.wordpress.org/trunk@29453


git-svn-id: http://core.svn.wordpress.org/trunk@29231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-09 14:46:17 +00:00
Andrew Ozz 4deee321e3 Editor: use the `post_edit_form_tag` action to add autocomplete="off" to the whole form on the Add/Edit Post screen in WebKit. Prevents editor problems when the browser's Back button is used. Fixes #28037. 
Built from https://develop.svn.wordpress.org/trunk@29448


git-svn-id: http://core.svn.wordpress.org/trunk@29226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-08 20:54:15 +00:00
Scott Taylor 19db9a253d `wp_dashboard_cached_rss_widget()` contained some `func_get_args()` code that was indescribably weird. 
This keeps it weird, but makes sure that `$check_urls` gets passed to the callback.

Props michalzuber, ocean90.
Fixes #28872.

Built from https://develop.svn.wordpress.org/trunk@29442


git-svn-id: http://core.svn.wordpress.org/trunk@29220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 21:47:16 +00:00
Scott Taylor 704a4c4803 Mark `WP_List_Table::bulk_actions()`'s argument `$which` as optional for BC. 
Fixes #29026.

Built from https://develop.svn.wordpress.org/trunk@29440


git-svn-id: http://core.svn.wordpress.org/trunk@29218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 21:30:15 +00:00
Scott Taylor ce7955cc9e Add screen reader text to list table date dropdown. 
See #29026.

Built from https://develop.svn.wordpress.org/trunk@29433


git-svn-id: http://core.svn.wordpress.org/trunk@29211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 19:44:15 +00:00
Scott Taylor c5dff42d51 Revert [29428] to avoid errors with Add Media for now. 
See #29026.

Built from https://develop.svn.wordpress.org/trunk@29432


git-svn-id: http://core.svn.wordpress.org/trunk@29210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 19:40:15 +00:00
Scott Taylor afb0b3e4ef Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view. 
Props afercia.
Fixes #29026.

Built from https://develop.svn.wordpress.org/trunk@29428


git-svn-id: http://core.svn.wordpress.org/trunk@29206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 05:20:16 +00:00
Scott Taylor 320ba69cf7 After [29201], use `aria-label` instead of `aria-labelledby` in `WP_Plugin_Install_List_Table::display_rows()`. 
Props nvwd, DrewAPicture.
Fixes #28853.

Built from https://develop.svn.wordpress.org/trunk@29424


git-svn-id: http://core.svn.wordpress.org/trunk@29202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 02:56:15 +00:00
Scott Taylor 64407235a9 `WP_List_Table::items` should be `public`, not `protected`. It is accessed in a subclass directly via `wp_ajax_get_comments()`. 
See [28493].
Fixes #29072.

Built from https://develop.svn.wordpress.org/trunk@29423


git-svn-id: http://core.svn.wordpress.org/trunk@29201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 02:51:16 +00:00
Andrew Nacin 40258a41b8 Language chooser imporvements. 
* Use a translated 'Continue' string.
 * Go back to using a select element.
 * Only show a spinner when we're installing a language. 

see #28577.

Built from https://develop.svn.wordpress.org/trunk@29372


git-svn-id: http://core.svn.wordpress.org/trunk@29150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-04 20:47:16 +00:00
Andrew Nacin 58b22fce7d Move plugin details link into the description area. 
fixes #17902.

Built from https://develop.svn.wordpress.org/trunk@29371


git-svn-id: http://core.svn.wordpress.org/trunk@29149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-04 18:49:17 +00:00
Dominik Schilling 410ca0a29c Plugin install: Improve styling of the no results message. 
see #28753.
Built from https://develop.svn.wordpress.org/trunk@29359


git-svn-id: http://core.svn.wordpress.org/trunk@29135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-02 15:24:16 +00:00
Dominik Schilling 68f16e0ef8 Language Upgrader: Don't print a footer when translations are updated async. 
fixes #28947.
Built from https://develop.svn.wordpress.org/trunk@29358


git-svn-id: http://core.svn.wordpress.org/trunk@29134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-02 15:16:16 +00:00
Dominik Schilling cd58a064cf Upgrader: Use always `window.postMessage` for decrement of update count bubbles when `IFRAME_REQUEST` is defined. 
Fixes decrement of translation update count bubbles when updated through the bulk upgrader.

fixes #29054.
Built from https://develop.svn.wordpress.org/trunk@29357


git-svn-id: http://core.svn.wordpress.org/trunk@29133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-02 14:37:16 +00:00
Dominik Schilling 608d505b24 Attach Media: Display the correct error message when search result is empty. 
fixes #29093.
Built from https://develop.svn.wordpress.org/trunk@29356


git-svn-id: http://core.svn.wordpress.org/trunk@29132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-02 14:24:15 +00:00
Dominik Schilling 8ea68677f3 Media Upload: Improve styling of error messages. 
props afercia, michalzuber.
fixes #29047.
Built from https://develop.svn.wordpress.org/trunk@29355


git-svn-id: http://core.svn.wordpress.org/trunk@29131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-02 14:14:19 +00:00
Dominik Schilling 203c44581b To improve troubleshooting use `esc_html()` for a failed embed. 
see #28195.
Built from https://develop.svn.wordpress.org/trunk@29354


git-svn-id: http://core.svn.wordpress.org/trunk@29130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-01 22:34:15 +00:00
Dominik Schilling 9a9b1791ca Add some braces to [29225]. 
see #28673.
Built from https://develop.svn.wordpress.org/trunk@29350


git-svn-id: http://core.svn.wordpress.org/trunk@29127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-01 21:04:15 +00:00
Dominik Schilling 12e961cb61 Plugin install: Add missing closing HTML tags. 
props jwenerd.
fixes #29090. see #28673.
Built from https://develop.svn.wordpress.org/trunk@29348


git-svn-id: http://core.svn.wordpress.org/trunk@29125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-01 20:44:14 +00:00
Helen Hou-Sandí 5d102f8e0b Use the word "Count" instead of the post type label in taxonomy list tables to prevent layout issues. It is also more accurate, as it represents a count of all post types, not just one. 
props philipjohn, GaVrA, seanchayes. fixes #17209.

Built from https://develop.svn.wordpress.org/trunk@29343


git-svn-id: http://core.svn.wordpress.org/trunk@29121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-01 18:32:15 +00:00
Andrew Ozz b9886e92e3 Editor scrolling: 
- Add a Screen Option to turn it on/off, and on()/off() methods from JS. Store the user preference.
- Fix delayed calls to resize() in the TinyMCE autoresize plugin.
See #28328.
Built from https://develop.svn.wordpress.org/trunk@29336


git-svn-id: http://core.svn.wordpress.org/trunk@29116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-01 02:43:17 +00:00
Sergey Biryukov ab3ce81661 In add_submenu_page(), avoid inadvertently copying classes of a menu item to the first submenu item. 
fixes #28936.
Built from https://develop.svn.wordpress.org/trunk@29326


git-svn-id: http://core.svn.wordpress.org/trunk@29107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-29 16:08:16 +00:00
Sergey Biryukov 4078e14d1e QuickPress: Disable autocomplete for content, enable "Save Draft" button on load. 
props morganestes, michalzuber.
fixes #27760.
Built from https://develop.svn.wordpress.org/trunk@29323


git-svn-id: http://core.svn.wordpress.org/trunk@29104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-29 15:34:16 +00:00
Sergey Biryukov 3f3395a086 Avoid PHP notices in Media Library if an attachment parent post type no longer exists. 
Synchronize the 'edit_post' capability check between the list table and the media grid.

fixes #27446.
Built from https://develop.svn.wordpress.org/trunk@29320


git-svn-id: http://core.svn.wordpress.org/trunk@29101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-29 01:41:16 +00:00
Dominik Schilling cc58ea9c49 Remove `parent::footer()` in `Language_Pack_Upgrader_Skin::bulk_footer()` as it prints a closing div which is not needed. 
props michalzuber.
fixes #28947.
Built from https://develop.svn.wordpress.org/trunk@29313


git-svn-id: http://core.svn.wordpress.org/trunk@29094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-28 09:06:17 +00:00
Dominik Schilling 7a67693b37 Add missing `screen-reader-text` CSS class in [29294]. 
see #28867.
Built from https://develop.svn.wordpress.org/trunk@29308


git-svn-id: http://core.svn.wordpress.org/trunk@29090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-27 13:43:17 +00:00
Scott Taylor 97fff7e952 Adds `<label>`s to current page selector and bulk actions `<select>` field so that screen readers have an explicit label. 
Props joedolson.
Fixes #28867.

Built from https://develop.svn.wordpress.org/trunk@29294


git-svn-id: http://core.svn.wordpress.org/trunk@29076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-25 00:20:16 +00:00
Scott Taylor 2ed316e16d Add exif `orientation` to data extracted in `wp_read_image_metadata()`. 
Props shanebp.
Fixes 28916.

Built from https://develop.svn.wordpress.org/trunk@29291


git-svn-id: http://core.svn.wordpress.org/trunk@29073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-24 22:14:16 +00:00
Scott Taylor a14f5b97d5 In `sanitize_file_name()`, replace `%20` and `+` with dashes. Remove unnecessary code from `_wp_handle_upload()`. 
Adds unit tests.

Props ericmann.
Fixes #16330.

Built from https://develop.svn.wordpress.org/trunk@29290


git-svn-id: http://core.svn.wordpress.org/trunk@29072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-24 22:09:16 +00:00
Helen Hou-Sandí 448275cce4 Media Grid: Remove fields from showing in the grid itself. 
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.

Built from https://develop.svn.wordpress.org/trunk@29280


git-svn-id: http://core.svn.wordpress.org/trunk@29062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-24 05:26:15 +00:00
Dominik Schilling 270a57075c Media Grid: Add a date filter. 
props ericlewis.
fixes #28895.
Built from https://develop.svn.wordpress.org/trunk@29271


git-svn-id: http://core.svn.wordpress.org/trunk@29053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-22 20:47:15 +00:00
John Blackbourn 4d53ee7d45 Add a `lang` attribute to each language listed on the language selector screen during installation. See #28858, #28577. 
Built from https://develop.svn.wordpress.org/trunk@29260


git-svn-id: http://core.svn.wordpress.org/trunk@29043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-21 21:51:16 +00:00
Sergey Biryukov 51db702770 Remove requirement for a minimum image size in the image editor. 
props ericlewis, solarissmoke.
fixes #11325.
Built from https://develop.svn.wordpress.org/trunk@29259


git-svn-id: http://core.svn.wordpress.org/trunk@29042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-21 19:10:14 +00:00
Sergey Biryukov 53c599563c Add screen reader text to announce that menu item accordion sections are expandable. Remove redundant title attribute. 
props joedolson.
fixes #28866.
Built from https://develop.svn.wordpress.org/trunk@29239


git-svn-id: http://core.svn.wordpress.org/trunk@29023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-19 02:21:14 +00:00
Sergey Biryukov c09a48a915 Add screen reader text for star ratings on Install Plugins screen. 
props joedolson.
fixes #28852.
Built from https://develop.svn.wordpress.org/trunk@29232


git-svn-id: http://core.svn.wordpress.org/trunk@29016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 23:41:14 +00:00
Andrew Nacin 9e33ac1bee Plugin Install screens: Pass locale and installed plugins to the API, for context. 
props tellyworth.
see #17902.

Built from https://develop.svn.wordpress.org/trunk@29227


git-svn-id: http://core.svn.wordpress.org/trunk@29011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 20:50:15 +00:00
Andrew Nacin 860f0922b7 Add 'Details' links to installed plugins. 
Installed plugins that are up to date are now returned in the update-check API response.

props tellyworth.
see #17902.

Built from https://develop.svn.wordpress.org/trunk@29226


git-svn-id: http://core.svn.wordpress.org/trunk@29010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 20:49:17 +00:00
Helen Hou-Sandí 4da975b68f Plugin install: display cards in groups if the API returns them with the appropriate information. props tellyworth. fixes #28673. 
Built from https://develop.svn.wordpress.org/trunk@29225


git-svn-id: http://core.svn.wordpress.org/trunk@29009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 19:35:14 +00:00
Helen Hou-Sandí a034c2076b Plugin install cards: 
* Move author attribution to its own line.
* Use `esc_url()` where appropriate.
* Better i18n.
* min-height for cards for a more even appearance.
* Show more cards on wide screens.
* Tighten up spacing below the filter bar.

props ocean90, helen. see #28785.

Built from https://develop.svn.wordpress.org/trunk@29219


git-svn-id: http://core.svn.wordpress.org/trunk@29003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 06:08:15 +00:00
Helen Hou-Sandí 02e3a7cbe3 Install Plugins screen: 
* Utilize the (currently-named) filter bar from the Add Themes screen.
* Move the upload link to the h2, also like the Add Themes screen.

see #28673.

Built from https://develop.svn.wordpress.org/trunk@29218


git-svn-id: http://core.svn.wordpress.org/trunk@29002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 04:50:15 +00:00
Sergey Biryukov be718ee860 Declare the variable before using it. 
props danielbachhuber.
fixes #28932.
Built from https://develop.svn.wordpress.org/trunk@29215


git-svn-id: http://core.svn.wordpress.org/trunk@28999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 22:01:14 +00:00
Scott Taylor fa02568c42 Merge `wp_handle_upload()` and `wp_handle_sideload()` by making them each wrap a new function: `_wp_handle_upload()`. 
Props DrewAPicture for docs.
Fixes #23686.

Built from https://develop.svn.wordpress.org/trunk@29209


git-svn-id: http://core.svn.wordpress.org/trunk@28993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 18:58:44 +00:00
Drew Jaynes 097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files. 
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 09:14:16 +00:00
Scott Taylor d395142fb9 In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text. 
Props joedolson.
Fixes #28853.

Built from https://develop.svn.wordpress.org/trunk@29201


git-svn-id: http://core.svn.wordpress.org/trunk@28985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-16 22:50:14 +00:00
Drew Jaynes 9ae01ba532 Fix a typo in the `@access` tag for `WP_List_Table::__get()`. 
Props joehoyle.
Fixes #28925. See #28885.

Built from https://develop.svn.wordpress.org/trunk@29199


git-svn-id: http://core.svn.wordpress.org/trunk@28983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-16 22:13:14 +00:00
Andrew Nacin 4bf7cdd49b DB schema change: Add comment_author_email(10) index. 
props tellyworth, pento.
fixes #21435.

Built from https://develop.svn.wordpress.org/trunk@29188


git-svn-id: http://core.svn.wordpress.org/trunk@28972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-16 15:54:16 +00:00
Scott Taylor 043715e8a4 Add a new AJAX action: `parse-media-shortcode`. This async call will replace JS rendering of audio/video/playlist shortcodes. 
See #28905.

Built from https://develop.svn.wordpress.org/trunk@29178


git-svn-id: http://core.svn.wordpress.org/trunk@28962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-15 22:08:14 +00:00
Scott Taylor 89d9bbd7f6 Make audio and video URLs/embed handlers work in `<iframe>`-sandbox'd MCE views. 
Introduce:
`get_editor_stylesheets()`
`wp_media_mce_styles()`.

See #28905.

Built from https://develop.svn.wordpress.org/trunk@29176


git-svn-id: http://core.svn.wordpress.org/trunk@28960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-15 21:51:15 +00:00
Dominik Schilling 1ecb1f0e8b Remove unused variable in `WP_Theme_Install_List_Table::install_theme_info()`. Unused since [26380]. 
props Corphi.
fixes #28749.
Built from https://develop.svn.wordpress.org/trunk@29173


git-svn-id: http://core.svn.wordpress.org/trunk@28957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 20:28:15 +00:00
Dominik Schilling d8ffbb19fc Remove `plugin_install_details_link` filter, which was added in [29047]. 
see #28785.
Built from https://develop.svn.wordpress.org/trunk@29171


git-svn-id: http://core.svn.wordpress.org/trunk@28955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 19:50:14 +00:00
Dominik Schilling 57c914f75a Customizer: Add meta capability `customize` which is mapped to `edit_theme_options`. 
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.

props westonruter, nacin.
fixes #28605.
Built from https://develop.svn.wordpress.org/trunk@29170


git-svn-id: http://core.svn.wordpress.org/trunk@28954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 19:01:16 +00:00
Scott Taylor c3b068a599 Missed one: `WP_MS_Sites_List_Table::display_rows()` must be `public`. 
Props extendwings.
Fixes #28894.


Built from https://develop.svn.wordpress.org/trunk@29166


git-svn-id: http://core.svn.wordpress.org/trunk@28950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 15:42:15 +00:00
Drew Jaynes 3665b5a1a1 Add periods to short descriptions for magic methods added in [28501], [28521], and [28524]. 
See #22234 and #28885.

Built from https://develop.svn.wordpress.org/trunk@29165


git-svn-id: http://core.svn.wordpress.org/trunk@28949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 01:12:14 +00:00
Drew Jaynes 204a4bc6bf Inline documentation cleanup for 4.0 audit. 
* phpDoc tweaks for `wp_get_available_translations_from_api()`, `wp_install_download_language_pack()`, and `wp_install_load_language()`, added in [29018]
 
See #28885.

Built from https://develop.svn.wordpress.org/trunk@29154


git-svn-id: http://core.svn.wordpress.org/trunk@28938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 00:17:15 +00:00
Drew Jaynes 79a4fd8fef Inline documentation for the 'plugin_install_details_link' hook added in [29047] should use a 3-digit, x.x.x-style `@since` version. 
See #28885.

Built from https://develop.svn.wordpress.org/trunk@29152


git-svn-id: http://core.svn.wordpress.org/trunk@28936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 00:10:15 +00:00
Drew Jaynes b8d47f48c5 Inline documentation cleanup for 4.0 audit. 
* Alignment for the 'term_search_min_chars' hook docs, added in [28892]
* Globals added for `wp_ajax_parse_embed()`, added [28580]

See #28885.

Built from https://develop.svn.wordpress.org/trunk@29151


git-svn-id: http://core.svn.wordpress.org/trunk@28935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 00:06:15 +00:00
Drew Jaynes 90d7cc27c2 Fill out inline documentation for magic methods added to the `WP_List_Table` class in [28493], [28521], and [28524]. 
See #22234 and #28885.

Built from https://develop.svn.wordpress.org/trunk@29148


git-svn-id: http://core.svn.wordpress.org/trunk@28932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-13 23:55:16 +00:00
Drew Jaynes e923e70d86 Fill out inline documentation for magic methods added to the `WP_Filesystem_Base` class in [28521]. 
See #22234 and #28885.

Built from https://develop.svn.wordpress.org/trunk@29147


git-svn-id: http://core.svn.wordpress.org/trunk@28931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-13 23:52:14 +00:00
Scott Taylor 176b9b2301 Fix mismatches in access modifiers for `WP_List_Table` + subclasses. 
Fixes #28843, #28879.

Built from https://develop.svn.wordpress.org/trunk@29137


git-svn-id: http://core.svn.wordpress.org/trunk@28921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-13 22:09:16 +00:00
Dominik Schilling 6ef23ea006 Lists View Switcher: Replace blank image with screen reader text. 
props davidakennedy.
fixes #28871.
Built from https://develop.svn.wordpress.org/trunk@29133


git-svn-id: http://core.svn.wordpress.org/trunk@28918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-13 11:05:15 +00:00
Dominik Schilling e398ae8161 Remove unused variable in `wp_dashboard_plugins_output()`. Unused since [26144]. 
props michalzuber.
see #28872.
Built from https://develop.svn.wordpress.org/trunk@29130


git-svn-id: http://core.svn.wordpress.org/trunk@28915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-13 10:31:16 +00:00
Dominik Schilling 8cbada97be Improvements to the plugin information modal: 
* Whitespace/braces cleanup for [29040].
* Reduce width of modal to 792px, which is the default banner size.
* Reduce banner height when screen height is smaller than 500px.
* Remove inline CSS.
* Re-use tab var in JS.
* Encode ampersands in links.

props avryl, michalzuber, ocean90.
see #27440.

Built from https://develop.svn.wordpress.org/trunk@29125


git-svn-id: http://core.svn.wordpress.org/trunk@28910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-12 22:08:16 +00:00
Sergey Biryukov 60a0b3b17d Use correct ID for plugin search input label. 
Make the search button name and ID consistent with the ones in WP_List_Table::search_box().

props joedolson.
fixes #28856.
Built from https://develop.svn.wordpress.org/trunk@29123


git-svn-id: http://core.svn.wordpress.org/trunk@28908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-12 17:45:15 +00:00
Scott Taylor 40725e9e67 Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses. 
Props SergeyBiryukov.
See #28843 and [28583].

Built from https://develop.svn.wordpress.org/trunk@29118


git-svn-id: http://core.svn.wordpress.org/trunk@28904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-12 03:27:14 +00:00
Scott Taylor 59ffcf668b Media Grid, for audio files: 
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`

See #28839.

Built from https://develop.svn.wordpress.org/trunk@29104


git-svn-id: http://core.svn.wordpress.org/trunk@28890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-11 20:55:15 +00:00
Sergey Biryukov cca7157c0d Escape taxonomy name when used in attributes in post_categories_meta_box(). 
props pbearne.
fixes #28836.
Built from https://develop.svn.wordpress.org/trunk@29099


git-svn-id: http://core.svn.wordpress.org/trunk@28885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-11 18:56:16 +00:00
Scott Taylor b16d3bd6ad Media Grid: make registering Screen Options for non-list tables more generic. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29079


git-svn-id: http://core.svn.wordpress.org/trunk@28865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 21:44:16 +00:00
Scott Taylor a9fb59151b Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29078


git-svn-id: http://core.svn.wordpress.org/trunk@28864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 21:26:16 +00:00
Scott Taylor a89060013b Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29077


git-svn-id: http://core.svn.wordpress.org/trunk@28863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 21:00:17 +00:00
Andrew Nacin e9d2d8ead9 Unload the current default textdomain in wp_install_load_language(). 
see #28577.

Built from https://develop.svn.wordpress.org/trunk@29059


git-svn-id: http://core.svn.wordpress.org/trunk@28847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 09:55:14 +00:00
Helen Hou-Sandí a180b44763 Display plugin install results as "cards" rather than in a list table, first run. 
props stephdau, ryelle, tellyworth, melchoyce. see #28785, #28646.


Built from https://develop.svn.wordpress.org/trunk@29047


git-svn-id: http://core.svn.wordpress.org/trunk@28835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-09 20:02:14 +00:00
Helen Hou-Sandí 2dfccee78f Improvements to the plugin information modal: 
* Show the banner image when available.
* Show contributors and ratings breakdown in the FYI box.
* Show reviews in a tab.

props stephdau, tellyworth, paulwilde, michalzuber. see #27440. fixes #19784, #22599, #26202.

Built from https://develop.svn.wordpress.org/trunk@29040


git-svn-id: http://core.svn.wordpress.org/trunk@28828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-09 17:28:17 +00:00
Drew Jaynes b10e168751 Add `@see` reference for `set_post_thumbnail()` in the phpDoc for `wp_ajax_set_attachment_thumbnail()`. 
See #27891.

Built from https://develop.svn.wordpress.org/trunk@29037


git-svn-id: http://core.svn.wordpress.org/trunk@28825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-08 20:36:13 +00:00
Scott Taylor 57dbc55e6e When setting the poster image for a video shortcode, set that image as the featured image for that attachment (if found) in the background. This AJAX functionality could be used for audio as well. 
Introduces `attachment_url_to_postid()` to attempt to turn URLs into post IDs.

Fixes #27891.

Built from https://develop.svn.wordpress.org/trunk@29029


git-svn-id: http://core.svn.wordpress.org/trunk@28817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-08 17:48:17 +00:00
John Blackbourn d237bc419d Narrower layout and loading spinner for the install screen language selector. See #28577 
Built from https://develop.svn.wordpress.org/trunk@29021


git-svn-id: http://core.svn.wordpress.org/trunk@28809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-08 00:33:15 +00:00
John Blackbourn 64f686b4c8 Focus and blur styling (via JS) for the install screen language selector. Props jorbin. See #28577 
Built from https://develop.svn.wordpress.org/trunk@29020


git-svn-id: http://core.svn.wordpress.org/trunk@28808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-08 00:30:14 +00:00
Andrew Nacin bc47136605 Language on install: Docs and naming cleanups. see #28577. 
Built from https://develop.svn.wordpress.org/trunk@29018


git-svn-id: http://core.svn.wordpress.org/trunk@28806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-07 21:49:15 +00:00
John Blackbourn ea46c7423a Correct the usage of the variable passed to `wp_install_download_language_pack()` and kill an unused local variable. Props michalzuber. Also avoid using the `$_REQUEST` superglobal in this function. See #28577. 
Built from https://develop.svn.wordpress.org/trunk@29016


git-svn-id: http://core.svn.wordpress.org/trunk@28804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-07 18:06:15 +00:00
Andrew Nacin 7a1351b411 Bring the language chooser to setup-config.php. 
see #28577.

Built from https://develop.svn.wordpress.org/trunk@29006


git-svn-id: http://core.svn.wordpress.org/trunk@28794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-05 05:14:15 +00:00
Sergey Biryukov 4b7a9edd27 Reinstate 'install_themes_tabs' filter. 
props ghost1227.
fixes #28578.
Built from https://develop.svn.wordpress.org/trunk@29002


git-svn-id: http://core.svn.wordpress.org/trunk@28790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-04 23:58:15 +00:00
Drew Jaynes eedd151405 Note in the hook docs for `preview_post_link` that the `$post` parameter was added. 
See #28729.

Built from https://develop.svn.wordpress.org/trunk@28979


git-svn-id: http://core.svn.wordpress.org/trunk@28768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 20:05:14 +00:00
Drew Jaynes d4dd02b4ae Remove backticks on `$post` variables in some short parameter descriptions. 
See [28653], [28654].
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28976


git-svn-id: http://core.svn.wordpress.org/trunk@28765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 19:28:14 +00:00
Drew Jaynes 0ac4474ce4 Fix an incomplete docblock for `wp_create_categories()` as part of `$post/$post_id` cleanup. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28975


git-svn-id: http://core.svn.wordpress.org/trunk@28764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 19:22:15 +00:00
John Blackbourn 38749f273c Use the admin scheme for theme preview URLs when installing new themes. See #21919. 
Built from https://develop.svn.wordpress.org/trunk@28974


git-svn-id: http://core.svn.wordpress.org/trunk@28763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 18:48:16 +00:00
Helen Hou-Sandí 5f6b531f70 Improve oEmbed caching. Introduces the concept of a TTL for oEmbed caches and a filter for `oembed_ttl`. 
We will no longer replace previously valid oEmbed responses with an `{{unknown}}` cache value. When this happens due to reaching a rate limit or a service going down, it is data loss, and is not acceptable. This means that oEmbed caches for a post are no longer deleted indiscriminately every time that post is saved.

oEmbed continues to be cached in post meta, with the addition of a separate meta key containing the timestamp of the last retrieval, which is used to avoid re-requesting a recently cached oEmbed response. By default, we consider a valued cached in the past day to be fresh. This can greatly reduce the number of outbound requests, especially in cases where a post containing multiple embeds is saved frequently.

The TTL used to determine whether or not to request a response can be filtered using `oembed_ttl`, thus allowing for the possibility of respecting the optional oEmbed response parameter `cache_age` or altering the period of time a cached value is considered to be fresh.

Now that oEmbeds are previewed in the visual editor as well as the media modal, oEmbed caches are often populated before a post is saved or published. By pre-populating and avoiding having to re-request that response, we also greatly reduce the chances of a stampede happening when a published post is visible before oEmbed caching is complete.

As it previously stood, a stampede was extremely likely to happen, as the AJAX caching was only triggered when `$_GET['message']` was 1. The published message is 6. We now trigger the caching every time `$_GET['message']` is present on the edit screen, as we are able to avoid triggering so many HTTP requests overall.

props markjaquith. fixes #14759. see #17210.

Built from https://develop.svn.wordpress.org/trunk@28972


git-svn-id: http://core.svn.wordpress.org/trunk@28761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 16:45:14 +00:00
Sergey Biryukov 4e75d406ec Pass $post object to 'preview_post_link' filter. 
props danielbachhuber.
fixes #28729.
Built from https://develop.svn.wordpress.org/trunk@28969


git-svn-id: http://core.svn.wordpress.org/trunk@28758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 14:42:15 +00:00
Sergey Biryukov 489693cd30 Remove non-breaking spaces from auto update email text. 
props trepmal.
fixes #28715.
Built from https://develop.svn.wordpress.org/trunk@28956


git-svn-id: http://core.svn.wordpress.org/trunk@28752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 12:46:17 +00:00
Sergey Biryukov 27ba686eee Simplify a condition in get_sample_permalink_html(). 
see #28350.
Built from https://develop.svn.wordpress.org/trunk@28948


git-svn-id: http://core.svn.wordpress.org/trunk@28745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 00:11:15 +00:00
Sergey Biryukov fc24029d65 Simplify logic in get_sample_permalink_html(), remove duplicated code. 
see #28350.
Built from https://develop.svn.wordpress.org/trunk@28947


git-svn-id: http://core.svn.wordpress.org/trunk@28744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 00:04:15 +00:00
Sergey Biryukov 16bb742b66 Display a correct preview link for drafts when permalinks are disabled. 
see #28350.
Built from https://develop.svn.wordpress.org/trunk@28946


git-svn-id: http://core.svn.wordpress.org/trunk@28743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 23:56:14 +00:00
Sergey Biryukov 8dcf86f94d Display consistent preview links for drafts. 
props mordauk.
fixes #28350.
Built from https://develop.svn.wordpress.org/trunk@28920


git-svn-id: http://core.svn.wordpress.org/trunk@28719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 10:02:16 +00:00
Andrew Ozz 5168f9c7c6 Secure embeds in the editor (first run): 
- When the user pastes an embeddable http URL, try to get the https embed.
- If an embed provider doesn't support ssl embeds, show a placeholder/error message.
- Revise the way we return error messages.
See #28195, #28507.
Built from https://develop.svn.wordpress.org/trunk@28919


git-svn-id: http://core.svn.wordpress.org/trunk@28718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 05:49:16 +00:00
Sergey Biryukov 5f0b156155 Prevent bulk actions from being performed when Filter button is clicked. 
props jesin.
fixes #28555.
Built from https://develop.svn.wordpress.org/trunk@28916


git-svn-id: http://core.svn.wordpress.org/trunk@28715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 01:10:15 +00:00
Scott Taylor c8936195f6 Allow comments in the trash to marked as spam. 
Props mordauk.
Fixes #19256.

Built from https://develop.svn.wordpress.org/trunk@28913


git-svn-id: http://core.svn.wordpress.org/trunk@28712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 23:19:16 +00:00
Scott Taylor 3d0a869a21 `WP_Filesystem_Base->abspath()` should use the `WPINC` constant 
Props wojtek.szkutnik
See #14157.

Built from https://develop.svn.wordpress.org/trunk@28904


git-svn-id: http://core.svn.wordpress.org/trunk@28703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:16:15 +00:00
Sergey Biryukov 08cea559a5 Set date format before going into the loop to avoid a PHP notice if 'lastupdated' column is filtered out. 
props jeremyfelt.
fixes #27614.
Built from https://develop.svn.wordpress.org/trunk@28898


git-svn-id: http://core.svn.wordpress.org/trunk@28697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 18:11:14 +00:00
Sergey Biryukov ae0e22b61c Fix feature pointer positioning issues for both LTR and RTL. 
fixes #28062.
Built from https://develop.svn.wordpress.org/trunk@28897


git-svn-id: http://core.svn.wordpress.org/trunk@28696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 16:06:14 +00:00
John Blackbourn 3f1c3dd4ca Normalise the schemes used in `get_home_path()` so it returns the correct path for sites using SSL in the admin area but not the front end. Fixes #25767. Props GregLone for the initial patch. 
Built from https://develop.svn.wordpress.org/trunk@28893


git-svn-id: http://core.svn.wordpress.org/trunk@28692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 10:29:14 +00:00
John Blackbourn 306dc7e646 Introduce a filter to control the minimum characters required for an AJAX term search. Fixes #13580. Props iamfriendly, brianlayman 
Built from https://develop.svn.wordpress.org/trunk@28892


git-svn-id: http://core.svn.wordpress.org/trunk@28691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 10:05:16 +00:00
Helen Hou-Sandí 81f9d12b07 Make the posts list table mode a sticky user setting. props garyc40, azaozz, ericmann. fixes #16774, #20335. 
Built from https://develop.svn.wordpress.org/trunk@28876


git-svn-id: http://core.svn.wordpress.org/trunk@28675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 02:17:15 +00:00
Scott Taylor f09663f784 Remove remaining Heartbeat API experimental notices 
Props DH-Shredder.
Fixes #28626.

Built from https://develop.svn.wordpress.org/trunk@28872


git-svn-id: http://core.svn.wordpress.org/trunk@28672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 02:06:14 +00:00
Scott Taylor 650261b549 In deprecated media iframe code, `attachment_fields_to_save` filter should not be called twice after initial image upload in post. 
Props SergeyBiryukov.
Fixes #20720.

Built from https://develop.svn.wordpress.org/trunk@28871


git-svn-id: http://core.svn.wordpress.org/trunk@28671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-27 21:32:16 +00:00
Andrew Ozz b9fd9db83b Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640. 
Built from https://develop.svn.wordpress.org/trunk@28847


git-svn-id: http://core.svn.wordpress.org/trunk@28651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 04:15:15 +00:00
Scott Taylor 9739b9b74d Only apply a subtle semi-transparent border to attachments that are images in the media list table. 
See [28842], #15860.


Built from https://develop.svn.wordpress.org/trunk@28843


git-svn-id: http://core.svn.wordpress.org/trunk@28647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 01:58:16 +00:00
Scott Taylor 41ab39f42c In `media_buttons()`, add a static var `$instance` to increment the `id` attribute of `insert-media-button-%d` on each call. 
Props ericlewis.
Fixes #28090.

Built from https://develop.svn.wordpress.org/trunk@28837


git-svn-id: http://core.svn.wordpress.org/trunk@28641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 01:05:14 +00:00
Scott Taylor b650c4fb55 Bring the list of `upload_filetypes` for multisite into modernity based on .com upgrades and supported extensions for audio and video. 
Fixes #24434.

Built from https://develop.svn.wordpress.org/trunk@28832


git-svn-id: http://core.svn.wordpress.org/trunk@28636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-25 18:00:15 +00:00
Scott Taylor 396e77b643 Use unobtrusive JS for Comment list table row actions. 
Props aubreypwd.
Fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@28810


git-svn-id: http://core.svn.wordpress.org/trunk@28618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 23:55:16 +00:00
Sergey Biryukov 8b272f4379 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly. 
fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28808


git-svn-id: http://core.svn.wordpress.org/trunk@28617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 22:21:15 +00:00
Sergey Biryukov 9ceb642b2a Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata(). 
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28806


git-svn-id: http://core.svn.wordpress.org/trunk@28615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 14:48:14 +00:00
Andrew Nacin c504fb41a1 Allow a language to be chosen before installing WordPress. First pass. 
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 

Built from https://develop.svn.wordpress.org/trunk@28774


git-svn-id: http://core.svn.wordpress.org/trunk@28587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 19:58:15 +00:00
Sergey Biryukov 5bd180bcbd Revert [28766]. 
see #28555.
Built from https://develop.svn.wordpress.org/trunk@28772


git-svn-id: http://core.svn.wordpress.org/trunk@28585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 02:23:13 +00:00
Sergey Biryukov cd7618399e Prevent bulk actions from being performed when Filter button is clicked. 
props layotte.
fixes #28555.
Built from https://develop.svn.wordpress.org/trunk@28766


git-svn-id: http://core.svn.wordpress.org/trunk@28579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 22:17:14 +00:00
Andrew Ozz 84f3e30f7b wpView: improve handling of embed errors/error messages, see #28195 
Built from https://develop.svn.wordpress.org/trunk@28754


git-svn-id: http://core.svn.wordpress.org/trunk@28568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-15 22:53:16 +00:00
Andrew Nacin aeac3e1654 Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This. 
fixes #28513.

Built from https://develop.svn.wordpress.org/trunk@28749


git-svn-id: http://core.svn.wordpress.org/trunk@28563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-12 18:09:13 +00:00
Scott Taylor 27523183bf Don't use variable variables in `touch_time()`. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28747


git-svn-id: http://core.svn.wordpress.org/trunk@28561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 21:05:16 +00:00
Scott Taylor 69fbe27f48 Don't use variable variables in `wp_reset_vars()`. Test by searching in list tables, etc. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28746


git-svn-id: http://core.svn.wordpress.org/trunk@28560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 20:00:15 +00:00
Scott Taylor 812ea43343 Don't use variable variables in `wp_dashboard_plugins_output()`. Variable variables aren't the worst thing about this function. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28742


git-svn-id: http://core.svn.wordpress.org/trunk@28556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 18:55:14 +00:00
John Blackbourn eb62aecbc3 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt. 
Built from https://develop.svn.wordpress.org/trunk@28731


git-svn-id: http://core.svn.wordpress.org/trunk@28545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 19:15:13 +00:00
John Blackbourn 03131233e2 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein. 
Built from https://develop.svn.wordpress.org/trunk@28730


git-svn-id: http://core.svn.wordpress.org/trunk@28544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 18:50:14 +00:00
Scott Taylor 05eeb16e30 Replace all uses of `like_escape()` with `$wpdb->esc_like()`. 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28712


git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:44:15 +00:00
Helen Hou-Sandí b5ef672c6b Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further. 
props ericlewis, shaunandrews, wonderboymusic.
see #24716.

Built from https://develop.svn.wordpress.org/trunk@28682


git-svn-id: http://core.svn.wordpress.org/trunk@28500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 22:01:18 +00:00
Sergey Biryukov 4b14fe0593 Remove one-time variable from add_settings_error(). 
props niallkennedy.
fixes #22228.
Built from https://develop.svn.wordpress.org/trunk@28681


git-svn-id: http://core.svn.wordpress.org/trunk@28499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 18:29:14 +00:00
Sergey Biryukov 26d0ad5e12 Remove redundant 'Visit author homepage' title attributes for plugins and themes. 
props joedolson.
fixes #26554.
Built from https://develop.svn.wordpress.org/trunk@28673


git-svn-id: http://core.svn.wordpress.org/trunk@28491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 04:52:16 +00:00
Drew Jaynes a6e536fba6 Make sure to use 3-digit x.x.x style for two 3.9.0 `@since` versions. 
Props netweb.
Fixes #28446.

Built from https://develop.svn.wordpress.org/trunk@28658


git-svn-id: http://core.svn.wordpress.org/trunk@28476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 05:35:16 +00:00
Drew Jaynes b0877f02a4 Make sure `$post` is properly documented as optional where applicable. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28653


git-svn-id: http://core.svn.wordpress.org/trunk@28471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 03:53:17 +00:00
Sergey Biryukov ee9d9133ac Avoid stomping of the $plugin variable in activate_plugin(). 
fixes #28102.
Built from https://develop.svn.wordpress.org/trunk@28644


git-svn-id: http://core.svn.wordpress.org/trunk@28462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 22:08:14 +00:00
Scott Taylor 9187e3bd55 Restore `$val` in `WP_Importer::bump_request_timeout()` - even though the parent class and `WP_Import` ignore the parameter, it creates an incompatible interface notice in the plugin. 
See [28629].


Built from https://develop.svn.wordpress.org/trunk@28637


git-svn-id: http://core.svn.wordpress.org/trunk@28455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 19:35:16 +00:00
Scott Taylor af860fbe84 Cleanup for `switch` statements: 
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.


Built from https://develop.svn.wordpress.org/trunk@28633


git-svn-id: http://core.svn.wordpress.org/trunk@28452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 17:58:15 +00:00
Drew Jaynes 1868c1fc4b Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php. 
Also add `@param` and `@return` descriptions.

See #28408.

Built from https://develop.svn.wordpress.org/trunk@28632


git-svn-id: http://core.svn.wordpress.org/trunk@28451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 17:38:14 +00:00
Scott Taylor c403768fa2 Remove some dead variable assignments. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28629


git-svn-id: http://core.svn.wordpress.org/trunk@28449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 16:59:14 +00:00
Sergey Biryukov d3e6a5ded0 Remove obsolete code from wp_dashboard_setup(). 
props kitchin.
fixes #26604.
Built from https://develop.svn.wordpress.org/trunk@28592


git-svn-id: http://core.svn.wordpress.org/trunk@28417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 15:41:15 +00:00
Sergey Biryukov 84422e6d7d Add BMP to the list of displayable image types. 
props ericlewis.
fixes #26808.
Built from https://develop.svn.wordpress.org/trunk@28589


git-svn-id: http://core.svn.wordpress.org/trunk@28414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 13:25:14 +00:00
Sergey Biryukov db9057f308 Remove redundant get_shortcode_regex() check. 
props kovshenin.
see #28195.
Built from https://develop.svn.wordpress.org/trunk@28587


git-svn-id: http://core.svn.wordpress.org/trunk@28412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 11:30:16 +00:00
Scott Taylor 3c1723afd7 When adding a URL in the `Insert from URL` state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields. 
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.

Built from https://develop.svn.wordpress.org/trunk@28581


git-svn-id: http://core.svn.wordpress.org/trunk@28406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:57:14 +00:00
Scott Taylor 89864b4a5a Don't pass embeds through `the_content()` when trying to render MCE previews, leverage `WP_Embed` and `do_shortcode()` instead. 
Props kovshenin.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28580


git-svn-id: http://core.svn.wordpress.org/trunk@28405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:43:15 +00:00
Scott Taylor 8b7b72d75e In `media_sideload_image()`, check the returned value of `download_url()` earlier to avoid attempting to `unlink()` an instance of `WP_Error`. 
Props georgestephanis. 
Fixes #28204.

Built from https://develop.svn.wordpress.org/trunk@28567


git-svn-id: http://core.svn.wordpress.org/trunk@28392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 21:33:14 +00:00
Scott Taylor 5b5b756edf In `get_terms_to_edit()`, call `get_object_term_cache()` before priming cache with `wp_get_object_terms()`. 
In `get_inline_data()`, do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.


Built from https://develop.svn.wordpress.org/trunk@28561


git-svn-id: http://core.svn.wordpress.org/trunk@28387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 19:29:14 +00:00
Scott Taylor 8d4d645629 Fix parsing in `wp_match_mime_types()` to allow some mime-types with `+` in them to appear in the list of filter links shown above the list table on `upload.php`. 
Props _duck.
Fixes #20672.


Built from https://develop.svn.wordpress.org/trunk@28553


git-svn-id: http://core.svn.wordpress.org/trunk@28379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 21:36:15 +00:00
Scott Taylor d22b5226a8 In `wp_dashboard_recent_posts()`, `$i` is set and never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28545


git-svn-id: http://core.svn.wordpress.org/trunk@28371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:56:15 +00:00
Scott Taylor 0e03abda62 `$theme_name` is set but no longer used in `wp_dashboard_right_now()`. The theme name is displayed with the call to `update_right_now_message()`. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28544


git-svn-id: http://core.svn.wordpress.org/trunk@28370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:54:13 +00:00
Scott Taylor b8d469600b These functions import `$wpdb` but do not use it. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28539


git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 17:37:14 +00:00
Sergey Biryukov 219321eedc Fix inconsistent header underlining and spacing in background update emails. 
fixes #28306.
Built from https://develop.svn.wordpress.org/trunk@28537


git-svn-id: http://core.svn.wordpress.org/trunk@28363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 09:41:15 +00:00
Sergey Biryukov 45d5e5d32f Use correct function name. 
props ericlewis.
fixes #28329.
Built from https://develop.svn.wordpress.org/trunk@28535


git-svn-id: http://core.svn.wordpress.org/trunk@28361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 07:59:16 +00:00
Scott Taylor 7de0b2b2c8 Upgrade `_WP_List_Table_Compat` to PHP5-style constructor. 
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28531


git-svn-id: http://core.svn.wordpress.org/trunk@28357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 17:20:17 +00:00
Scott Taylor 09ecc213c8 In `WP_Filesystem_Base`, the constructor is a noop, so it shouldn't even be declared. Setting it implies that `parent::__construct()` should be called by its subclasses. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28529


git-svn-id: http://core.svn.wordpress.org/trunk@28355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 16:46:14 +00:00
Scott Taylor 85f73cf458 Classes that have `__set()` also need `__isset()` and `__unset()`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28524


git-svn-id: http://core.svn.wordpress.org/trunk@28350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:52:14 +00:00
Scott Taylor 821246b4ae Some classes with `__get()` method also need `__set()`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28521


git-svn-id: http://core.svn.wordpress.org/trunk@28347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:31:15 +00:00
Scott Taylor dfa4de15fa Add missing access modifiers to methods/members in `Walker` and subclasses. Add a magic `__get()` method. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28514


git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:00:15 +00:00
Scott Taylor 2f513d3320 Fix some `hackificator` odds and ends in `wp-admin`: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:04:16 +00:00
Drew Jaynes 511eabe5f3 Improve inline documentation of default arguments for `post_format_meta_box()`, `post_tags_meta_box()`, and `post_categories_meta_box()`. 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@28499


git-svn-id: http://core.svn.wordpress.org/trunk@28325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 03:23:13 +00:00
Scott Taylor 130771a383 `hackificator` doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28497


git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:59:15 +00:00
Scott Taylor 1383990ae2 Add access modifier (`public`) to methods and members of `WP_Upgrader` and its subclasses. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28496


git-svn-id: http://core.svn.wordpress.org/trunk@28322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:29:15 +00:00
Scott Taylor 58ca85e106 Add access modifier (`public`) to methods and members of `WP_Upgrader_Skin` and its subclasses. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28495


git-svn-id: http://core.svn.wordpress.org/trunk@28321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:23:15 +00:00
Scott Taylor f090ff507d Add access modifiers to methods and members of `WP_Users_List_Table`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28494


git-svn-id: http://core.svn.wordpress.org/trunk@28320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:19:14 +00:00
Scott Taylor d28f6344de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28493


git-svn-id: http://core.svn.wordpress.org/trunk@28319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:17:15 +00:00
Scott Taylor 4e894f05f5 Add access modifier (`public`) to methods in `WP_Importer`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28492


git-svn-id: http://core.svn.wordpress.org/trunk@28318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:19:15 +00:00
Scott Taylor d5e35d187f Add access modifier (`public`) to members and methods in `WP_Filesystem_SSH2`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28491


git-svn-id: http://core.svn.wordpress.org/trunk@28317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:18:14 +00:00
Scott Taylor 41e1ecdfaf Add access modifier (`public`) to members and methods in `WP_Filesystem_ftpsockets`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28490


git-svn-id: http://core.svn.wordpress.org/trunk@28316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:14:14 +00:00
Scott Taylor 0dbc6b37a7 Add access modifier (`public`) to members and methods in `WP_Filesystem_FTPext`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28489


git-svn-id: http://core.svn.wordpress.org/trunk@28315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:12:15 +00:00
Scott Taylor eb750d0bd1 Add access modifier (`public`) to methods in `WP_Filesystem_Direct`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28488


git-svn-id: http://core.svn.wordpress.org/trunk@28314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:09:14 +00:00
Scott Taylor 7a378bc48f Add access modifiers to members and methods in `WP_Filesystem_Base`. Add magic `__get()` method for backwards compatibility. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28487


git-svn-id: http://core.svn.wordpress.org/trunk@28313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:06:14 +00:00
Scott Taylor e43e775c45 Add access modifier (`public`) to members and methods in `WP_Comments_List_Table` and `WP_Post_Comments_List_Table`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28486


git-svn-id: http://core.svn.wordpress.org/trunk@28312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 23:59:15 +00:00
Scott Taylor b9afafffe3 `hackificator` complains if you call `include 'file.php'` without the parens, needs to be `include( 'file.php' )` 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28479


git-svn-id: http://core.svn.wordpress.org/trunk@28306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 20:52:15 +00:00
Sergey Biryukov 8dacdb77be Fix wp_insert_link(), broken in [28406]/[28408]. 
see #22400.
Built from https://develop.svn.wordpress.org/trunk@28475


git-svn-id: http://core.svn.wordpress.org/trunk@28302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 09:56:15 +00:00
Drew Jaynes d75ca7aaaf Add inline documentation for default arguments in `wp_insert_category()`. 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@28474


git-svn-id: http://core.svn.wordpress.org/trunk@28301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 07:28:14 +00:00
Scott Taylor 4ce9706db1 Add inline comment after fix in [28467]. 
Props jesin.
Fixes #28292.


Built from https://develop.svn.wordpress.org/trunk@28468


git-svn-id: http://core.svn.wordpress.org/trunk@28295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 15:42:14 +00:00
Scott Taylor bdd1ae2fc7 Restore `$soucrce` in `WP_Upgrader::install_package()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28467


git-svn-id: http://core.svn.wordpress.org/trunk@28294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 15:40:15 +00:00
Scott Taylor 8eb9f2ffe4 Eliminate use of `extract()` in `request_filesystem_credentials()`. 
The only property that doesn't need to be set to a variable is `$password`.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28456


git-svn-id: http://core.svn.wordpress.org/trunk@28283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:26:15 +00:00
Scott Taylor 39de969bf2 Update inline docs for `wp_handle_upload|sideload` to reflect their non-use of `extract()`. 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28452


git-svn-id: http://core.svn.wordpress.org/trunk@28279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 17:41:16 +00:00
Scott Taylor 632eb5b17e Eliminate use of `extract()` in `wp_handle_sideload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28451


git-svn-id: http://core.svn.wordpress.org/trunk@28278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 16:15:14 +00:00
Scott Taylor 4caf3e79f3 Eliminate use of `extract()` in `wp_handle_upload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28450


git-svn-id: http://core.svn.wordpress.org/trunk@28277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 16:10:38 +00:00
Scott Taylor b2d1e73fd5 Eliminate the use of `extract()` in `WP_Upgrader`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28418


git-svn-id: http://core.svn.wordpress.org/trunk@28245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:02:14 +00:00
Scott Taylor d74272ecf5 Eliminate one of the uses of `extract()` in `wp_handle_upload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28417


git-svn-id: http://core.svn.wordpress.org/trunk@28244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 04:31:14 +00:00
Scott Taylor fc59804352 Eliminate one of the uses of `extract()` in `wp_handle_sideload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28416


git-svn-id: http://core.svn.wordpress.org/trunk@28243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 04:29:15 +00:00
Scott Taylor a7a6cb5bef Eliminate use of `extract()` in `Walker_Category_Checklist::start_el()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28411


git-svn-id: http://core.svn.wordpress.org/trunk@28238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:14:14 +00:00
Scott Taylor 7ebab48f4c Eliminate use of `extract()` in `wp_terms_checklist()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28410


git-svn-id: http://core.svn.wordpress.org/trunk@28237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:09:15 +00:00
Scott Taylor a75f8137bc Eliminate use of `extract()` in `wp_star_rating()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28409


git-svn-id: http://core.svn.wordpress.org/trunk@28236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:57:14 +00:00
Scott Taylor ff665b2f38 (REALLY) Eliminate use of `extract()` in `wp_insert_link()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28408


git-svn-id: http://core.svn.wordpress.org/trunk@28235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:55:16 +00:00
Scott Taylor 54321f4c6e Eliminate use of `extract()` in `get_media_item()`. 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28407


git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:45:15 +00:00
Scott Taylor 5f06d0f50a Eliminate use of `extract()` in `wp_insert_link()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28406


git-svn-id: http://core.svn.wordpress.org/trunk@28233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:28:14 +00:00
Scott Taylor fd9abeb0f9 Eliminate use of `extract()` in `post_tags_meta_box()` and `post_categories_meta_box()`. 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28391


git-svn-id: http://core.svn.wordpress.org/trunk@28219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:48:17 +00:00
Scott Taylor 9476cd33a3 Eliminate use of `extract()` in `WP_Terms_List_Table::display_rows_or_placeholder()`: 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28390


git-svn-id: http://core.svn.wordpress.org/trunk@28218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:37:14 +00:00
Scott Taylor aef35fe6a2 Eliminate use of `extract()` in `WP_List_Table::pagination()`: 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28389


git-svn-id: http://core.svn.wordpress.org/trunk@28217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:27:14 +00:00
Scott Taylor 530a107ec9 Eliminate use of `extract()` in `WP_Plugin_Install_List_Table::get_table_classes()`. It only needs to read `plural`, no need to extract. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28388


git-svn-id: http://core.svn.wordpress.org/trunk@28216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:17:14 +00:00
Scott Taylor 192e235672 Eliminate use of `extract()` in `WP_List_Table::ajax_response()`: 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28387


git-svn-id: http://core.svn.wordpress.org/trunk@28215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:14:14 +00:00
Scott Taylor 08d73b9e23 Eliminate use of `extract()` in `WP_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28386


git-svn-id: http://core.svn.wordpress.org/trunk@28214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:08:13 +00:00
Scott Taylor f617b8669a Eliminate use of `extract()` in `WP_Post_Comments_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28385


git-svn-id: http://core.svn.wordpress.org/trunk@28213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:04:14 +00:00
Scott Taylor 6bbc5b570c Eliminate use of `extract()` in `wp_insert_category()`. Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28374


git-svn-id: http://core.svn.wordpress.org/trunk@28202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 03:27:13 +00:00
Scott Taylor 2bea9fcc0b In `media_upload_gallery_form()`'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.


Built from https://develop.svn.wordpress.org/trunk@28368


git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:12:15 +00:00
Scott Taylor 88b96dc036 In `wp_read_image_metadata()`, the values from `exif_read_data()` should only override values from `iptcparse()` that are empty. 
Props SergeyBiryukov.
Fixes #23706.

Built from https://develop.svn.wordpress.org/trunk@28367


git-svn-id: http://core.svn.wordpress.org/trunk@28195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 05:54:15 +00:00
Scott Taylor e9f87b2688 Avoid a notice in `wp_save_image()` by checking `$meta['sizes']['thumbnail']` for `! empty()` before setting a variable to it. 
Props MikeHansenMe.
Fixes #17736.


Built from https://develop.svn.wordpress.org/trunk@28366


git-svn-id: http://core.svn.wordpress.org/trunk@28194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 03:42:14 +00:00
Scott Taylor 0b6729c3f9 In `WP_Terms_List_Table::single_row()`, call `sanitize_term()` on the passed term (`$tag`). 
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.

Built from https://develop.svn.wordpress.org/trunk@28360


git-svn-id: http://core.svn.wordpress.org/trunk@28188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:05:15 +00:00
Scott Taylor f22beb987c First pass at `wpview` logic for the `[embed]` shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28358


git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:36:18 +00:00
Drew Jaynes 81cfb9427a Fix mid-file section header style in wp-admin/includes/ajax-actions.php. 
See #28200.

Built from https://develop.svn.wordpress.org/trunk@28356


git-svn-id: http://core.svn.wordpress.org/trunk@28184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 05:02:13 +00:00
Drew Jaynes 0ef7244ce7 Add baseline doc blocks for all ajax handlers in ajax-actions.php. 
Fixes #28200.

Built from https://develop.svn.wordpress.org/trunk@28355


git-svn-id: http://core.svn.wordpress.org/trunk@28183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 05:00:19 +00:00
Drew Jaynes f609524261 Minor phpDoc fixes for the `got_rewrite`, `got_url_rewrite`, and `documentation_ignore_functions` hooks. 
Props GaryJ.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28352


git-svn-id: http://core.svn.wordpress.org/trunk@28180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 11:13:14 +00:00
Drew Jaynes 32e674f44e Use interpolation instead of concatenation for the `manage_{$screen->id}_columns` hook name. 
Props Otto42.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28348


git-svn-id: http://core.svn.wordpress.org/trunk@28176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 09:58:14 +00:00
Drew Jaynes 8906f83802 Use an interpolated hook name for `edit_{$post_type}_per_page` instead of `$per_page` and adjust docs accordingly. 
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.

Props Otto42 for the initial patch.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28347


git-svn-id: http://core.svn.wordpress.org/trunk@28175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 08:16:15 +00:00
Scott Taylor 1daa7d6723 Leverage `size_format()` when displaying `max_upload_size`: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.


Built from https://develop.svn.wordpress.org/trunk@28343


git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 18:25:14 +00:00
Scott Taylor c2d44c5736 In `wp-admin/includes/upgrade.php`, remove dead code: 
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28305


git-svn-id: http://core.svn.wordpress.org/trunk@28133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:27:15 +00:00
Scott Taylor aaa3eb07ad In `wp-admin/includes/update.php`, remove dead code: 
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used. 	

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28304


git-svn-id: http://core.svn.wordpress.org/trunk@28132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:21:14 +00:00
Scott Taylor b80cda5d17 In `WP_Screen::render_screen_options()`, remove dead code: 
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28303


git-svn-id: http://core.svn.wordpress.org/trunk@28131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:14:15 +00:00
Scott Taylor 2e417f0ca4 In `get_sample_permalink_html()`, `$view_link` is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28302


git-svn-id: http://core.svn.wordpress.org/trunk@28130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:11:14 +00:00
Scott Taylor 44e2d48a3c In `install_plugin_information()`, `$title` is set in a `foreach` loop and never used. This appears to be due to copy-pasting a previous `foreach` loop and not discarding these bits. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28301


git-svn-id: http://core.svn.wordpress.org/trunk@28129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:00:18 +00:00
Scott Taylor e57fa7300d In `wp-admin/includes/nav-menu.php`, remove dead code: 
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it. 
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used. 

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28300


git-svn-id: http://core.svn.wordpress.org/trunk@28128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:55:14 +00:00
Scott Taylor 85bdc64173 In `update_option_new_admin_email()`, `$email` is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28299


git-svn-id: http://core.svn.wordpress.org/trunk@28127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:48:14 +00:00
Scott Taylor 6066f85853 In `attachment_submit_meta_box()`, remove dead code: 
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28298


git-svn-id: http://core.svn.wordpress.org/trunk@28126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:45:14 +00:00
Scott Taylor 71ac0f21c2 In `get_media_item()`, `$tags` and `$_tags` are set and never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28297


git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:41:17 +00:00
Scott Taylor 3054b924a3 In `WP_Users_List_Table::get_views()`, `$current_role` is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28296


git-svn-id: http://core.svn.wordpress.org/trunk@28124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:33:15 +00:00
Scott Taylor 209f008d77 In `WP_MS_Users_List_Table::get_views()`, remove dead code: 
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28295


git-svn-id: http://core.svn.wordpress.org/trunk@28123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:30:14 +00:00
Scott Taylor 970477d25e In `WP_Media_List_Table`, remove dead code: 
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28293


git-svn-id: http://core.svn.wordpress.org/trunk@28121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:27:33 +00:00
Scott Taylor 28d98a89f3 In `ajax-actions.php`, remove dead code: 
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used. 

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28292


git-svn-id: http://core.svn.wordpress.org/trunk@28120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:19:14 +00:00
Sergey Biryukov 527a1ea6e3 Use a consistent context to remove duplicate strings. 
props pavelevap.
fixes #28123.
Built from https://develop.svn.wordpress.org/trunk@28287


git-svn-id: http://core.svn.wordpress.org/trunk@28115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 12:34:14 +00:00
Scott Taylor ded4871368 In `WP_List_Table::display_rows_or_placeholder()`, the call to `get_column_info()` in unnecessary and unused. The call to `get_column_count()` immediately after makes the same call internally. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28279


git-svn-id: http://core.svn.wordpress.org/trunk@28107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:32:15 +00:00
Scott Taylor dd73ad4299 In `edit_form_image_editor()`, `$filename` and `$title` are set and then unused. They shall be removed. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28271


git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:45:16 +00:00
Scott Taylor 644024dfc4 Dead code in `wp-admin/includes/file.php`: 
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28268


git-svn-id: http://core.svn.wordpress.org/trunk@28096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:22:14 +00:00
Scott Taylor 3d7a4e6798 Remove unused variable setting for `$revisions` in `wp_prepare_revisions_for_js()`. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28264


git-svn-id: http://core.svn.wordpress.org/trunk@28092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 03:45:14 +00:00
Scott Taylor 21379dcde0 Remove a dead variable, `$start`, from `wp_dashboard_recent_comments()`. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28263


git-svn-id: http://core.svn.wordpress.org/trunk@28091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 03:35:14 +00:00
Andrew Nacin f44e4226fa Move 'home' option to the top of populate_options(). 
fixes #28141.

Built from https://develop.svn.wordpress.org/trunk@28260


git-svn-id: http://core.svn.wordpress.org/trunk@28088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 21:57:14 +00:00
Sergey Biryukov 751e624ff7 Deprecate unused argument of delete_plugins(). Clarify @return value. 
props jdgrimes for initial patch.
fixes #28111.
Built from https://develop.svn.wordpress.org/trunk@28256


git-svn-id: http://core.svn.wordpress.org/trunk@28084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 10:24:15 +00:00
Sergey Biryukov 997cbaa03c Use a time constant in get_theme_feature_list() and File_Upload_Upgrader. 
props GaVrA.
fixes #28124.
Built from https://develop.svn.wordpress.org/trunk@28253


git-svn-id: http://core.svn.wordpress.org/trunk@28081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 08:26:24 +00:00
Drew Jaynes d77e78d685 Clean up duplicate hook notations and adjacency for calls to the `wp_signup_location` filter. 
Also adds braces missed in [25535].

See #26869.

Built from https://develop.svn.wordpress.org/trunk@28215


git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 07:12:14 +00:00
Drew Jaynes 029dd247be Ensure the `wp_edit_nav_menu_walker` filter is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28213


git-svn-id: http://core.svn.wordpress.org/trunk@28043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:50:15 +00:00
Drew Jaynes a9b74e2088 Ensure the `nav_menu_meta_box_object` filter hook is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28207


git-svn-id: http://core.svn.wordpress.org/trunk@28037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:14:15 +00:00
Andrew Nacin b89775445e Theme Installer: Proper redirection and action links post-install in multisite. 
fixes #27869.

Built from https://develop.svn.wordpress.org/trunk@28163


git-svn-id: http://core.svn.wordpress.org/trunk@27994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-19 18:18:16 +00:00
Andrew Nacin 2bc282957c Translate a string added in 3.7.1 but never translated previously. 
props SergeyBiryukov.
fixes #27819.

Built from https://develop.svn.wordpress.org/trunk@28145


git-svn-id: http://core.svn.wordpress.org/trunk@27976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:38:14 +00:00
Dion Hulse ca0b5c9859 Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815 
Built from https://develop.svn.wordpress.org/trunk@28137


git-svn-id: http://core.svn.wordpress.org/trunk@27968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 10:57:14 +00:00
Andrew Nacin fa3900168e Allow the API to add text to auto update emails. 
fixes #27812.

Built from https://develop.svn.wordpress.org/trunk@28134


git-svn-id: http://core.svn.wordpress.org/trunk@27965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 08:52:15 +00:00
Andrew Nacin 9f81d0526e Theme Installer: Revert to proxying through PHP for WordPress.org API requests. 
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.

Built from https://develop.svn.wordpress.org/trunk@28126


git-svn-id: http://core.svn.wordpress.org/trunk@27957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 01:16:14 +00:00
Andrew Nacin cb4eb9c13f Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.

Built from https://develop.svn.wordpress.org/trunk@28113


git-svn-id: http://core.svn.wordpress.org/trunk@27944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 07:48:14 +00:00
Andrew Ozz c9f5ed0801 Plupload: restore the settings in media_upload_form(), see #27763 
Built from https://develop.svn.wordpress.org/trunk@28110


git-svn-id: http://core.svn.wordpress.org/trunk@27941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:41:15 +00:00
Andrew Nacin 55b0cd935e Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.

Built from https://develop.svn.wordpress.org/trunk@28107


git-svn-id: http://core.svn.wordpress.org/trunk@27938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:00:14 +00:00
Andrew Nacin eca26bc5ae The widgets pointer requires the edit_theme_options capability. 
(It's hypothetically possible to have only switch_themes.)

see #27777.

Built from https://develop.svn.wordpress.org/trunk@28093


git-svn-id: http://core.svn.wordpress.org/trunk@27924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:53:15 +00:00
Andrew Nacin 497b0df4a5 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4. 
see #27777.

Built from https://develop.svn.wordpress.org/trunk@28090


git-svn-id: http://core.svn.wordpress.org/trunk@27921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:48:15 +00:00
Andrew Nacin c87ac82d7b Update $_old_files for 3.9. see #27775. 
Built from https://develop.svn.wordpress.org/trunk@28085


git-svn-id: http://core.svn.wordpress.org/trunk@27916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 18:27:17 +00:00
Drew Jaynes 5e51ea9940 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869

Built from https://develop.svn.wordpress.org/trunk@28083


git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 00:01:15 +00:00
Andrew Nacin 51412f2e9b Account for new cropping settings in the image editor. 
props Otto42, SergeyBiryukov.
fixes #19393.

Built from https://develop.svn.wordpress.org/trunk@28072


git-svn-id: http://core.svn.wordpress.org/trunk@27903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-11 03:10:14 +00:00
Drew Jaynes 252a5434ff Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php. 
Fixes #27711.

Built from https://develop.svn.wordpress.org/trunk@28040


git-svn-id: http://core.svn.wordpress.org/trunk@27870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 06:26:16 +00:00
Andrew Nacin e7fc009f7c Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns. 
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28037


git-svn-id: http://core.svn.wordpress.org/trunk@27867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 04:30:15 +00:00
Drew Jaynes f6df2c6921 Use the correct parameter variables in the hook docs for `wp_upgrade`. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27998


git-svn-id: http://core.svn.wordpress.org/trunk@27828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:13:15 +00:00
Drew Jaynes 181fe84d47 Align parameters in the hook docs for the `attachment_thumbnail_args` filter. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27997


git-svn-id: http://core.svn.wordpress.org/trunk@27827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:10:16 +00:00
Drew Jaynes bf75eebfa7 Add missing parameter descriptions to the PHPDocs for `WP_Upgrader_Skin::decrement_update_count()` and `Bulk_Upgrader_Skin::decrement_update_count()`. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27996


git-svn-id: http://core.svn.wordpress.org/trunk@27826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:02:15 +00:00
Andrew Nacin 2d710c6fad Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
props kovshenin.
see [27964], see #27452.

Built from https://develop.svn.wordpress.org/trunk@27990


git-svn-id: http://core.svn.wordpress.org/trunk@27820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 17:59:14 +00:00
Andrew Nacin 2f80a1c72f Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation. 
see #27452.

Built from https://develop.svn.wordpress.org/trunk@27975


git-svn-id: http://core.svn.wordpress.org/trunk@27805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 22:08:15 +00:00
Drew Jaynes a11553eafe Inline documentation for remaining hooks in wp-admin/includes/upgrade.php. 
Props jackreichert, vancoder.
Fixes #27646.

Built from https://develop.svn.wordpress.org/trunk@27965


git-svn-id: http://core.svn.wordpress.org/trunk@27795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 22:30:14 +00:00
Andrew Nacin 1ec9b44673 Better checks for contributors when saving posts. 
props dd32, kovshenin, plocha.
see #27452.

Built from https://develop.svn.wordpress.org/trunk@27964


git-svn-id: http://core.svn.wordpress.org/trunk@27794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 21:19:14 +00:00
Sergey Biryukov b48021f65f Clarify tooltips on Edit Image screen. 
props siobhan.
fixes #27651.
Built from https://develop.svn.wordpress.org/trunk@27939


git-svn-id: http://core.svn.wordpress.org/trunk@27769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 00:03:28 +00:00
Sergey Biryukov 2cb849fc52 Fix typo in verify_file_md5() description. see [25541]. 
props siobhan.
see #27651.
Built from https://develop.svn.wordpress.org/trunk@27938


git-svn-id: http://core.svn.wordpress.org/trunk@27768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 00:03:14 +00:00
Sergey Biryukov f8c39d6186 Use multiplication sign instead of a colon for selection size when editing an image. 
props siobhan.
fixes #27652.
Built from https://develop.svn.wordpress.org/trunk@27931


git-svn-id: http://core.svn.wordpress.org/trunk@27761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 09:46:17 +00:00
Andrew Nacin 803d4ff54d Remove old links_recently_updated_* DB options that never had a UI. 
fixes #27649.

Built from https://develop.svn.wordpress.org/trunk@27916


git-svn-id: http://core.svn.wordpress.org/trunk@27746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 03:10:15 +00:00
Dion Hulse 50a7503c2e Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633 
Built from https://develop.svn.wordpress.org/trunk@27905


git-svn-id: http://core.svn.wordpress.org/trunk@27736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-02 13:05:15 +00:00
Drew Jaynes 4af2840a47 Clarify PHPDoc return description for `media_handle_upload()`. 
Props jdgrimes.
Fixes #27519.

Built from https://develop.svn.wordpress.org/trunk@27880


git-svn-id: http://core.svn.wordpress.org/trunk@27711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-31 22:33:15 +00:00
Scott Taylor 01d2062af3 Cleanup up the display, escaping, and handling of ID3 data for media. Rename `wp_get_relevant_id3_keys()` to `wp_get_attachment_id3_keys()`. 
Props nacin.
See #27574.


Built from https://develop.svn.wordpress.org/trunk@27869


git-svn-id: http://core.svn.wordpress.org/trunk@27700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-31 05:16:16 +00:00
Andrew Nacin 8acf74fe7b Use correct formatting function. see [27864], see #27574. 
Built from https://develop.svn.wordpress.org/trunk@27866


git-svn-id: http://core.svn.wordpress.org/trunk@27697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-30 22:12:29 +00:00
Andrew Nacin c95f232727 Cleanups for audio/video metadata, see [27862]. 
see #27574.

Built from https://develop.svn.wordpress.org/trunk@27864


git-svn-id: http://core.svn.wordpress.org/trunk@27695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-30 21:08:14 +00:00
Scott Taylor 7eb24edf4e In `wp_generate_attachment_metadata()`, when an audio or video files contains upload-able image bits in its ID3 tags, only upload it if the image has not already been uploaded. Determine this by checking for a `_cover_hash` value in post meta that matches the `md5` representation of the bits. 
This prevents uploading an album of 10 songs and subsequently uploading 10 copies of the same album cover.

Props GregLone for the new filter/filter docs: `'attachment_thumbnail_args'`.
Fixes #27573.
 

Built from https://develop.svn.wordpress.org/trunk@27863


git-svn-id: http://core.svn.wordpress.org/trunk@27694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-30 20:54:15 +00:00
Scott Taylor d947a55495 Metadata for audio and video files: 
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.


Built from https://develop.svn.wordpress.org/trunk@27862


git-svn-id: http://core.svn.wordpress.org/trunk@27693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-30 19:28:16 +00:00
Andrew Nacin 3c1cdaa362 Restyle the image editor so it looks way less hideous. 
props avryl.
see #27544.

Built from https://develop.svn.wordpress.org/trunk@27842


git-svn-id: http://core.svn.wordpress.org/trunk@27676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-29 08:51:14 +00:00
Drew Jaynes 5613b40981 The `sidebar_admin_setup` hook should only be documented once in wp-admin/widgets.php. All others are duplicates. 
See #25374, #25501, #27531.

Built from https://develop.svn.wordpress.org/trunk@27823


git-svn-id: http://core.svn.wordpress.org/trunk@27657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-28 19:47:15 +00:00
Dominik Schilling c707faa639 Widget Customizer: Convert static WP_Customize_Widgets class into instantiated class and merge Options_Transaction into WP_Customize_Widgets. 
see #27504.
props westonruter.

Built from https://develop.svn.wordpress.org/trunk@27816


git-svn-id: http://core.svn.wordpress.org/trunk@27650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-28 14:07:14 +00:00
Andrew Nacin c3ca81ba94 Always decode special characters for email subjects. 
props tlovett1, jeremyfelt.
fixes #25346.

Built from https://develop.svn.wordpress.org/trunk@27801


git-svn-id: http://core.svn.wordpress.org/trunk@27636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-28 02:44:15 +00:00
Andrew Nacin bec78b5e11 Proper IDs for the custom fields box. 
props SergeyBiryukov.
fixes #14376.

Built from https://develop.svn.wordpress.org/trunk@27776


git-svn-id: http://core.svn.wordpress.org/trunk@27613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-27 06:56:14 +00:00
Andrew Nacin f9964e361c Fix docs for hooks in deactivate_plugins() and activate_plugin(). see #27189, #27188. 
Built from https://develop.svn.wordpress.org/trunk@27769


git-svn-id: http://core.svn.wordpress.org/trunk@27606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-27 02:02:14 +00:00
Scott Taylor fd0e34ec9f The bulk editor and post format meta box should use the same checks for available post formats. 
Props eightface.
Fixes #27187.


Built from https://develop.svn.wordpress.org/trunk@27762


git-svn-id: http://core.svn.wordpress.org/trunk@27599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-27 00:06:15 +00:00
Andrew Nacin b5d0471fef Merge some theme update strings. 
props pavelevap, yoavf.
fixes #25083.

Built from https://develop.svn.wordpress.org/trunk@27748


git-svn-id: http://core.svn.wordpress.org/trunk@27585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-26 20:08:15 +00:00
Andrew Nacin 2fd8b60c22 Avoid JS errors before the commentReply script loads. Let's make this unobtrusive soon. 
props aubreypwd.
fixes #24741.

Built from https://develop.svn.wordpress.org/trunk@27747


git-svn-id: http://core.svn.wordpress.org/trunk@27584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-26 18:53:15 +00:00
Andrew Nacin 8c3925760f Upgrader skins: Strip tags before displaying error data. 
fixes #25394.

Built from https://develop.svn.wordpress.org/trunk@27737


git-svn-id: http://core.svn.wordpress.org/trunk@27574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-26 14:39:16 +00:00
Andrew Nacin dd70d0e30b Don't allow the image editor thumbnail to be dragged. see #21811. 
Built from https://develop.svn.wordpress.org/trunk@27712


git-svn-id: http://core.svn.wordpress.org/trunk@27551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 16:21:16 +00:00
Andrew Nacin fbd1443a0b Restore the update message in the dashboard, removed in 3.8. 
props obenland.
fixes #26664.

Built from https://develop.svn.wordpress.org/trunk@27711


git-svn-id: http://core.svn.wordpress.org/trunk@27550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 14:36:15 +00:00
Andrew Nacin 156a5a234f Multisite: Don't set the $super_admins global in grant_super_admin(), revoke_super_admin(). 
Adds tests and docs.

props jdgrimes.
see #27205.

Built from https://develop.svn.wordpress.org/trunk@27706


git-svn-id: http://core.svn.wordpress.org/trunk@27545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 12:14:14 +00:00
Drew Jaynes 7dc9b02577 Correct misleading verbiage in 'print' hook docs. 
Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.

Props ericlewis for the initial patch.
Fixes #26924.

Built from https://develop.svn.wordpress.org/trunk@27695


git-svn-id: http://core.svn.wordpress.org/trunk@27534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 08:05:15 +00:00
Scott Taylor 4eadc109f8 In `wp_create_post_autosave()`, intersect the `$new_autosave`'s keys with the keys from `_wp_post_revision_fields()` to ensure that all expected fields are present. 
Props kovshenin.
Fixes #25416.


Built from https://develop.svn.wordpress.org/trunk@27690


git-svn-id: http://core.svn.wordpress.org/trunk@27529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 20:32:14 +00:00
Andrew Nacin c08ff58b13 Plugin Installer: Disable 'Latest Version Installed' buttons. 
props paulwilde.
see #26952.

Built from https://develop.svn.wordpress.org/trunk@27677


git-svn-id: http://core.svn.wordpress.org/trunk@27520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 03:41:15 +00:00
Andrew Nacin 9babc32900 Use correct variable. see [27373]. 
props TobiasBg.
fixes #14424.

Built from https://develop.svn.wordpress.org/trunk@27675


git-svn-id: http://core.svn.wordpress.org/trunk@27518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 03:25:16 +00:00
Drew Jaynes cb58f19135 Inline documentation for hooks in wp-admin/includes/taxonomy.php. 
Props kpdesign for the initial patch.
Fixes #27433.

Built from https://develop.svn.wordpress.org/trunk@27674


git-svn-id: http://core.svn.wordpress.org/trunk@27517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 03:14:15 +00:00
Drew Jaynes 0cee31065e Inline documentation for wp-admin/includes/class-wp-upgrader.php. 
Props kpdesign for some minor cleanup.
Fixes #27436.

Built from https://develop.svn.wordpress.org/trunk@27673


git-svn-id: http://core.svn.wordpress.org/trunk@27516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 03:00:15 +00:00
Drew Jaynes 8efd225e4d Inline documentation for hooks in wp-admin/includes/file.php. 
Fixes #27429.

Built from https://develop.svn.wordpress.org/trunk@27672


git-svn-id: http://core.svn.wordpress.org/trunk@27515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 02:45:15 +00:00
Drew Jaynes b4903834cf Remove some debug cruft accidentally committed in [27670]. 
See #27430.

Built from https://develop.svn.wordpress.org/trunk@27671


git-svn-id: http://core.svn.wordpress.org/trunk@27514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 02:38:17 +00:00
Drew Jaynes 1a0881f341 Inline documentation for hooks in wp-admin/includes/menu.php. 
Also fixes syntax for a few unrelated multi-line comments in the file.

Props kpdesign for some minor cleanup.
Fixes #27430.

Built from https://develop.svn.wordpress.org/trunk@27670


git-svn-id: http://core.svn.wordpress.org/trunk@27513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 02:35:14 +00:00
Drew Jaynes 0b8798684b Inline documentation for hooks in wp-admin/includes/dashboard.php. 
Props mauryaratan. Props kpdesign for some minor cleanup.
Fixes #25752.

Built from https://develop.svn.wordpress.org/trunk@27669


git-svn-id: http://core.svn.wordpress.org/trunk@27512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 02:21:15 +00:00
Drew Jaynes 155746131f Inline documentation for hooks in wp-admin/includes/post.php. 
Also moves the primary PHPDoc for the `edit_posts_per_page` hook to wp-admin/includes/post.php.

Props kpdesign for some cleanup.
Fixes #27431.

Built from https://develop.svn.wordpress.org/trunk@27667


git-svn-id: http://core.svn.wordpress.org/trunk@27510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 01:49:14 +00:00
Andrew Ozz 69b74a75cd Plupload: switch to urlstream upload method when the 'flash' runtime is used in non IE browsers. This ensures cookies are sent but limits the maximum file size that flash can handle. 
By default only IE9 and older use flash so this change is mostly for completeness. It would affect only the (extremely rare) cases where a plugin disables the html5 runtime.
Built from https://develop.svn.wordpress.org/trunk@27662


git-svn-id: http://core.svn.wordpress.org/trunk@27505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-23 23:45:19 +00:00
Scott Taylor 38d1fb971f Turn on thumbnail support for `attachment:audio` and `attachment:video`. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin. 
Fixes #27460.


Built from https://develop.svn.wordpress.org/trunk@27657


git-svn-id: http://core.svn.wordpress.org/trunk@27500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-23 02:35:14 +00:00
Dominik Schilling d1f3abe55c Remove "Show" prefix from filter dropdowns, see #26743. 
Built from https://develop.svn.wordpress.org/trunk@27626


git-svn-id: http://core.svn.wordpress.org/trunk@27469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 22:13:14 +00:00
Andrew Nacin 111e6a73be Skipping placeholders in a string will only catch translators off guard. 
see #27453, #27132.

Built from https://develop.svn.wordpress.org/trunk@27613


git-svn-id: http://core.svn.wordpress.org/trunk@27456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 05:53:14 +00:00
Andrew Nacin ecab3c3535 Remove two new strings from post_preview(). 
see #25272, #27453.

Built from https://develop.svn.wordpress.org/trunk@27612


git-svn-id: http://core.svn.wordpress.org/trunk@27455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 05:49:14 +00:00
Andrew Nacin 064f3d7191 Improve the autosave error message on nonce failure. 
see #27453, #25272.

Built from https://develop.svn.wordpress.org/trunk@27611


git-svn-id: http://core.svn.wordpress.org/trunk@27454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 05:47:22 +00:00
John Blackbourn 80fe1b0e79 Introduce permission checks for post queries and edit links in the At a Glance dashboard widget. Fixes #27132. Props mattheu. 
Built from https://develop.svn.wordpress.org/trunk@27596


git-svn-id: http://core.svn.wordpress.org/trunk@27439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-18 22:44:27 +00:00
John Blackbourn 181c2d091e Remove the "See more" toggle from the At a Glance dashboard widget. Fixes #26614. 
Built from https://develop.svn.wordpress.org/trunk@27583


git-svn-id: http://core.svn.wordpress.org/trunk@27426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-18 12:56:14 +00:00
Andrew Nacin b0188044a2 Heartbeat: Hooks should always receive unslashed data. 
This affects the privileged hooks; the unprivileged hooks already received unslashed data.

props johnbillion, TobiasBg.
fixes #27260.

Built from https://develop.svn.wordpress.org/trunk@27576


git-svn-id: http://core.svn.wordpress.org/trunk@27419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-18 00:15:15 +00:00
Andrew Nacin 3c3e9a530b Filesystem: Fix getchmod() for direct and ssh2 transports, for directories. 
props DavidAnderson.
fixes #26598.

Built from https://develop.svn.wordpress.org/trunk@27566


git-svn-id: http://core.svn.wordpress.org/trunk@27409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-17 20:17:15 +00:00
Andrew Nacin 6c03a28512 Cap and theme support checks for the welcome panel. 
props MikeHansenMe.
fixes #26276.

Built from https://develop.svn.wordpress.org/trunk@27563


git-svn-id: http://core.svn.wordpress.org/trunk@27406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-17 19:47:15 +00:00
Sergey Biryukov bfef727df3 Avoid PHP notices in Media Library if an attachment parent post type no longer exists. 
props wpsmith.
fixes #27439.
Built from https://develop.svn.wordpress.org/trunk@27560


git-svn-id: http://core.svn.wordpress.org/trunk@27403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-17 15:33:15 +00:00
Andrew Ozz 513b6992e5 Restyle the plugin install details modal to match the rest of the admin. Props avryl and paulwilde for initial mockup, see #26952 
Built from https://develop.svn.wordpress.org/trunk@27559


git-svn-id: http://core.svn.wordpress.org/trunk@27402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-16 18:28:17 +00:00
Sergey Biryukov ab03c0db64 Fix .comment-grey-bubble markup and remove a stray </h5> tag. 
props avryl.
fixes #27408.
Built from https://develop.svn.wordpress.org/trunk@27548


git-svn-id: http://core.svn.wordpress.org/trunk@27391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-15 04:32:15 +00:00
Dion Hulse 87c6791a41 WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265 
Built from https://develop.svn.wordpress.org/trunk@27546


git-svn-id: http://core.svn.wordpress.org/trunk@27389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-15 03:09:16 +00:00
Dominik Schilling f46a085f7c Widget Customizer: Use ?wp_customize=on. 
Let _wp_customize_include() handle customizer initialisation.
Sets also the priority for the Add Widget and Reorder buttons and removes debug cruft.

props westonruter.
fixes #27291.
Built from https://develop.svn.wordpress.org/trunk@27524


git-svn-id: http://core.svn.wordpress.org/trunk@27367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-13 18:38:14 +00:00
Scott Taylor 00e63d2d2c The Image Editor should apply changes to custom image sizes by checking `$_wp_additional_image_sizes` for `$size` in `wp_save_image()` before arbitrarily going to the options table. 
Props Otto42, SergeyBiryukov.
Fixes #19889.


Built from https://develop.svn.wordpress.org/trunk@27522


git-svn-id: http://core.svn.wordpress.org/trunk@27365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-13 04:18:14 +00:00
John Blackbourn cc7f0b61ec Correct the "View Post" button link when changing a post slug. Fixes #16477. Props aubreypwd. 
Built from https://develop.svn.wordpress.org/trunk@27508


git-svn-id: http://core.svn.wordpress.org/trunk@27351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 23:00:16 +00:00
John Blackbourn 75b86ecfb0 Avoid searching HTML tags when searching plugins and themes. Fixes #27136. Props enej. 
Built from https://develop.svn.wordpress.org/trunk@27507


git-svn-id: http://core.svn.wordpress.org/trunk@27350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 22:24:15 +00:00
Sergey Biryukov f29df4f74c Remove duplicate description of WP_List_Table class. 
props bravokeyl.
fixes #27346.
Built from https://develop.svn.wordpress.org/trunk@27502


git-svn-id: http://core.svn.wordpress.org/trunk@27345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 16:23:15 +00:00
Andrew Nacin fe260c6a15 Assign correct variable. 
props nendeb55.
fixes #27351. see #14424, [27373].

Built from https://develop.svn.wordpress.org/trunk@27501


git-svn-id: http://core.svn.wordpress.org/trunk@27344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 13:24:14 +00:00
Andrew Nacin 9aca2a65f8 Bring the theme browsing experience from 3.8 to the theme installer. First pass. 
props matveb with assists from me and gcorne.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27499


git-svn-id: http://core.svn.wordpress.org/trunk@27341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 07:47:15 +00:00
Drew Jaynes a271ca696b Fix docs for the `deactivate_$plugin` and `deactivated_plugin` hooks. 
Props wpsmith for the original patch.
Fixes #27189

Built from https://develop.svn.wordpress.org/trunk@27491


git-svn-id: http://core.svn.wordpress.org/trunk@27335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-10 21:34:17 +00:00
Andrew Nacin de769c267f Editor: Show 'View Post' for any post the author can read. 
This expands it to private posts and matches the logic in the toolbar.

props mordauk, SergeyBiryukov.
fixes #27059.

Built from https://develop.svn.wordpress.org/trunk@27483


git-svn-id: http://core.svn.wordpress.org/trunk@27327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-09 13:53:14 +00:00
Dominik Schilling 3e356d7bdf Admin Menu: Set default value of `$icon_url` in `add_menu_page()` to `dashicons-admin-generic`, fixes #26630. 
Built from https://develop.svn.wordpress.org/trunk@27482


git-svn-id: http://core.svn.wordpress.org/trunk@27326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-09 11:13:13 +00:00
Andrew Nacin fabb6d4898 Allow $crop in add_image_size() to receive crop anchors (top, left, right, bottom, center). 
This also applies to set_post_thumbnail_size() and image_resize_dimensions().

props bradt, wonderboymusic, DH-Shredder.
fixes #19393.

Built from https://develop.svn.wordpress.org/trunk@27472


git-svn-id: http://core.svn.wordpress.org/trunk@27317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 06:14:15 +00:00
Andrew Nacin 17ccbc86c9 Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context. 
see #13265.

Built from https://develop.svn.wordpress.org/trunk@27470


git-svn-id: http://core.svn.wordpress.org/trunk@27315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 04:19:16 +00:00
Andrew Nacin edfe443afc Remove lame debugging. see #23057. 
Built from https://develop.svn.wordpress.org/trunk@27467


git-svn-id: http://core.svn.wordpress.org/trunk@27312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 03:16:27 +00:00
Andrew Nacin 60953e88fd Normalize $reassign in wp_delete_user() to ensure the hooks receive consistent values. 
fixes #23057.

Built from https://develop.svn.wordpress.org/trunk@27466


git-svn-id: http://core.svn.wordpress.org/trunk@27311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 03:16:14 +00:00
Sergey Biryukov 0a0589414e Fix docblock formatting in [27462]. see #23057. 
Built from https://develop.svn.wordpress.org/trunk@27463


git-svn-id: http://core.svn.wordpress.org/trunk@27308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 01:26:13 +00:00
Sergey Biryukov 9c6504120f Pass $reassign parameter to 'delete_user' and 'deleted_user' actions. 
props genkisan.
fixes #23057.
Built from https://develop.svn.wordpress.org/trunk@27462


git-svn-id: http://core.svn.wordpress.org/trunk@27307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 01:23:15 +00:00
Andrew Nacin 449ffedfb9 maybe_regenerate_attachment_metadata() is now wp_maybe_generate_attachment_metadata(). 
props kovshenin.
fixes #26825.

Built from https://develop.svn.wordpress.org/trunk@27441


git-svn-id: http://core.svn.wordpress.org/trunk@27288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-06 19:34:14 +00:00
Drew Jaynes c64dc20146 Inline documentation for hooks in wp-admin/includes/class-wp-theme-install-list-table.php. 
Props kpdesign for the cleanup.
Fixes #27293.

Built from https://develop.svn.wordpress.org/trunk@27430


git-svn-id: http://core.svn.wordpress.org/trunk@27277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-06 13:44:14 +00:00
Andrew Nacin e853a9cc57 Add widget management to the customizer. 
This brings in the Widget Customizer plugin: https://wordpress.org/plugins/widget-customizer/.

props westonruter, shaunandrews, michael-arestad, johnregan3, akeda, topher1kenobe, topquarky, bobbravo2, ricardocorreia. And for good measure, props westonruter.
see #27112.

Built from https://develop.svn.wordpress.org/trunk@27419


git-svn-id: http://core.svn.wordpress.org/trunk@27266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-05 20:41:14 +00:00
Andrew Nacin 39fcb291fe Always convert auto-drafts to drafts in edit_draft() and _wp_translate_postdata(). 
This regressed due to refactoring in [26995]. This commit fixes Quick Draft.

see #25272.

Built from https://develop.svn.wordpress.org/trunk@27405


git-svn-id: http://core.svn.wordpress.org/trunk@27252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-05 06:26:14 +00:00
Andrew Ozz 7121bb490d Restyles the modal for attaching media to posts, take II (also some autoprefixer and imagemin). Props avryl, see #26952. 
Built from https://develop.svn.wordpress.org/trunk@27403


git-svn-id: http://core.svn.wordpress.org/trunk@27250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-05 03:54:15 +00:00
Andrew Ozz 19efb78b48 Restyles the modal for attaching media to posts, props avryl, see #26952 
Built from https://develop.svn.wordpress.org/trunk@27401


git-svn-id: http://core.svn.wordpress.org/trunk@27248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-04 23:11:13 +00:00
Andrew Nacin 2c68373c83 Convert the post lock icon to a dashicon. 
props melchoyce, DH-Shredder.
fixes #26796.

Built from https://develop.svn.wordpress.org/trunk@27392


git-svn-id: http://core.svn.wordpress.org/trunk@27240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-04 06:53:14 +00:00
Dominik Schilling 00f224624e "At a Glance" widget: Move `get_avatar()` line out of if-block. 
This allows you to show avatars for custom comment types via the `get_avatar_comment_types` filter.

props zodiac1978.
fixes #26944.
Built from https://develop.svn.wordpress.org/trunk@27384


git-svn-id: http://core.svn.wordpress.org/trunk@27232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 20:14:14 +00:00
Drew Jaynes 690481f8e8 Generalize the hook documentation for the `set-screen-option` filter. 
The filter covers more than [items]_per_page screen options.

Fixes #26186.

Built from https://develop.svn.wordpress.org/trunk@27379


git-svn-id: http://core.svn.wordpress.org/trunk@27228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 17:51:14 +00:00
Drew Jaynes 849ce35cb9 Inline documentation for hooks in wp-admin/includes/misc.php. 
Props JoshuaAbenazer.
Fixes #26186

Built from https://develop.svn.wordpress.org/trunk@27375


git-svn-id: http://core.svn.wordpress.org/trunk@27224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 17:20:16 +00:00
Andrew Nacin cc7a2e29f5 Slight renaming in our callback in [27373]. see #14424. 
Built from https://develop.svn.wordpress.org/trunk@27374


git-svn-id: http://core.svn.wordpress.org/trunk@27223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 17:09:14 +00:00
Mark Jaquith fb56a9942b Eliminate some of our last remaining `create_function()` instances 
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore

props obenland, markjaquith, nacin. fixes #14424
Built from https://develop.svn.wordpress.org/trunk@27373


git-svn-id: http://core.svn.wordpress.org/trunk@27222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 16:21:16 +00:00
Andrew Nacin 0c16c0477b Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc. 
props Ipstenu, markjaquith.
see #27115.

Built from https://develop.svn.wordpress.org/trunk@27369


git-svn-id: http://core.svn.wordpress.org/trunk@27219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 02:34:27 +00:00
Andrew Nacin ffc4ca7b01 Introduce get_site_by_path() and further rewrite the site detection process for multisite. 
This is the first big step to supporting arbitrary domains and paths. In this new approach, sites are detected first where possible, then the network is inferred. Allows filtering for arbitrary path segments, smooths out some weirdness, and removes various restrictions. A sunrise plugin could do much of its work by adding filters, if those are even needed.

see #27003.

Built from https://develop.svn.wordpress.org/trunk@27359


git-svn-id: http://core.svn.wordpress.org/trunk@27209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-02 22:25:14 +00:00
Drew Jaynes c0e436d3d3 Inline documentation for hooks in wp-admin/includes/image-edit.php. 
Props theorboman. Props kpdesign for the cleanup.
Fixes #26149.

Built from https://develop.svn.wordpress.org/trunk@27357


git-svn-id: http://core.svn.wordpress.org/trunk@27208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-02 20:56:15 +00:00
Drew Jaynes 5da89414a8 Inline documentation for hooks in wp-admin/includes/class-wp-plugins-list-table.php. 
Props nicolealleyinteractivecom, kpdesign.
Fixes #26957.

Built from https://develop.svn.wordpress.org/trunk@27356


git-svn-id: http://core.svn.wordpress.org/trunk@27207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-02 20:48:14 +00:00
Drew Jaynes 16941beac1 Tweak inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props kpdesign.
Fixes #26203.

Built from https://develop.svn.wordpress.org/trunk@27355


git-svn-id: http://core.svn.wordpress.org/trunk@27206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-02 20:32:15 +00:00
Drew Jaynes 15068e1cd4 Inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props leewillis77.
Fixes #26203.

Built from https://develop.svn.wordpress.org/trunk@27342


git-svn-id: http://core.svn.wordpress.org/trunk@27194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-01 15:00:15 +00:00
Dion Hulse d5775c8b6c Upgrader: Remove more debug from r27336. See #25860 
Built from https://develop.svn.wordpress.org/trunk@27339


git-svn-id: http://core.svn.wordpress.org/trunk@27191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-01 06:06:14 +00:00
Dion Hulse 487efa7957 Upgrader: Remove some debug from r27336. See #25860 
Built from https://develop.svn.wordpress.org/trunk@27338


git-svn-id: http://core.svn.wordpress.org/trunk@27190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-01 06:04:14 +00:00
Dion Hulse 6b280a820e Upgrader: Remove two stray spaces. See #25860 
Built from https://develop.svn.wordpress.org/trunk@27337


git-svn-id: http://core.svn.wordpress.org/trunk@27189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-01 06:02:15 +00:00
Dion Hulse c94a32b0ad Upgrader: Copy wp-includes/version.php over last, to avoid an installation failing with the new version.php in place. Fixes #25860 
Built from https://develop.svn.wordpress.org/trunk@27336


git-svn-id: http://core.svn.wordpress.org/trunk@27188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-01 06:01:16 +00:00
Scott Taylor e92770ba93 * Videos should always render at the same aspect ratio. 
* Don't force a pseudo-mime-type for `.m4v` files
* Uniformly adapt to `$content_width` when setting video dimensions on the front end
* Add the `height` attribute to the initial `<video>` in the video playlist JS template
* Add some defensive/responsive CSS for a/v on the Edit Media page

See #27243.


Built from https://develop.svn.wordpress.org/trunk@27328


git-svn-id: http://core.svn.wordpress.org/trunk@27180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-28 21:28:14 +00:00
John Blackbourn 44e34f826b Don't filter out network-only plugins from the Plugins screen if they're individually active on the current site. Add some code comments for clarity. Props mordauk 
Built from https://develop.svn.wordpress.org/trunk@27326


git-svn-id: http://core.svn.wordpress.org/trunk@27178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-28 20:22:14 +00:00
Sergey Biryukov 5f0f676199 Use a consistent format for translator comments. 
props GaryJ.
fixes #27228.
Built from https://develop.svn.wordpress.org/trunk@27325


git-svn-id: http://core.svn.wordpress.org/trunk@27177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-28 08:09:13 +00:00
Sergey Biryukov e7467f9b44 Remove temporary hooks added in [26865]. 
fixes #26661.
Built from https://develop.svn.wordpress.org/trunk@27324


git-svn-id: http://core.svn.wordpress.org/trunk@27176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-28 00:45:16 +00:00
Sergey Biryukov f291730aec Avoid an undefined index notice in wp_doc_link_parse(). 
props pross for initial patch.
fixes #27214.
Built from https://develop.svn.wordpress.org/trunk@27323


git-svn-id: http://core.svn.wordpress.org/trunk@27175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-27 23:16:13 +00:00
Sergey Biryukov bc036d0843 Avoid an undefined index notice in wp_handle_upload(). 
props tivnet.
fixes #27225.
Built from https://develop.svn.wordpress.org/trunk@27319


git-svn-id: http://core.svn.wordpress.org/trunk@27171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-27 21:16:15 +00:00
Andrew Ozz d896fa2487 Upgrade Plupload to 2.1.1, props kovshenin, see #25663 
Built from https://develop.svn.wordpress.org/trunk@27316


git-svn-id: http://core.svn.wordpress.org/trunk@27168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-27 20:01:16 +00:00
Andrew Nacin bee73edb62 Unslash in the time-format and date-format ajax endpoints. 
props GregLone.
fixes #27216.

Built from https://develop.svn.wordpress.org/trunk@27305


git-svn-id: http://core.svn.wordpress.org/trunk@27158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-27 00:05:14 +00:00
Drew Jaynes 8dc5888cfa Improve inline documentation for `WP_Users_List_Table`. 
Props leewillis77 for the initial patch.
Fixes #26564.

Built from https://develop.svn.wordpress.org/trunk@27301


git-svn-id: http://core.svn.wordpress.org/trunk@27154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-26 22:20:17 +00:00
Andrew Nacin 13e868ac55 Decrement update count bubbles as plugins/themes are updated, live. 
props gcorne, mitchoyoshitaka.
fixes #17703.

Built from https://develop.svn.wordpress.org/trunk@27280


git-svn-id: http://core.svn.wordpress.org/trunk@27136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-26 06:55:14 +00:00
Andrew Nacin 9c9c824de2 Clarify return values for get_preferred_from_update_core() and get_core_updates(). 
props SergeyBiryukov.
fixes #20251.

Built from https://develop.svn.wordpress.org/trunk@27264


git-svn-id: http://core.svn.wordpress.org/trunk@27121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 17:20:13 +00:00
Drew Jaynes cb8951b0b3 Remove all `@package` and `@subpackage` PHPDoc tags not at the file- or class-levels in core. 
See #27200.

Built from https://develop.svn.wordpress.org/trunk@27262


git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 17:14:14 +00:00
Andrew Nacin bf028ce1e3 Remove _relocate_children(), which has had no purpose for some time. 
props SergeyBiryukov, scribu.
fixes #19367.

Built from https://develop.svn.wordpress.org/trunk@27261


git-svn-id: http://core.svn.wordpress.org/trunk@27118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 17:10:14 +00:00
Andrew Nacin c102fd5a9d Make the user arguments for get_edit_profile_url() and get_dashboard_url() optional, defaulting to the current user. 
props garyc40.
fixes #16686.

Built from https://develop.svn.wordpress.org/trunk@27260


git-svn-id: http://core.svn.wordpress.org/trunk@27117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 17:08:13 +00:00
Drew Jaynes 94549c1a4a Inline documentation for hooks in wp-admin/includes/screen.php. 
Props enej, kpdesign.
Fixes #26821.

Built from https://develop.svn.wordpress.org/trunk@27256


git-svn-id: http://core.svn.wordpress.org/trunk@27113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 10:05:14 +00:00
Drew Jaynes 0ab444cd42 Inline documentation for hooks in wp-admin/includes/class-wp-posts-list-table.php. 
Props nicolealleyinteractivecom, kpdesign.
Fixes #26397.

Built from https://develop.svn.wordpress.org/trunk@27255


git-svn-id: http://core.svn.wordpress.org/trunk@27112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 06:12:13 +00:00
Sergey Biryukov 0cbdf53b18 Fix theme preview URL for themes loaded via AJAX on Install Themes screen. 
props ocean90.
fixes #27128.
Built from https://develop.svn.wordpress.org/trunk@27247


git-svn-id: http://core.svn.wordpress.org/trunk@27104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 00:01:14 +00:00
Drew Jaynes ad3861242d Inline documentation for hooks in wp-admin/includes/template.php. 
Props shelob9 for the initial patch. Props kpdesign.
Fixes #26089.

Built from https://develop.svn.wordpress.org/trunk@27237


git-svn-id: http://core.svn.wordpress.org/trunk@27094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-23 22:44:13 +00:00
Sergey Biryukov f9d5020cb5 Use filtered per_page value in WP_Plugin_Install_List_Table and WP_Theme_Install_List_Table. 
props brasofilo.
fixes #25675.
Built from https://develop.svn.wordpress.org/trunk@27221


git-svn-id: http://core.svn.wordpress.org/trunk@27078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-21 18:30:14 +00:00
Andrew Nacin 912379a022 Simplify error in validate_file_to_edit(). 
props MattyRob for initial patch.
fixes #25924.

Built from https://develop.svn.wordpress.org/trunk@27219


git-svn-id: http://core.svn.wordpress.org/trunk@27076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-21 14:46:14 +00:00
Drew Jaynes 61538d3f5e Inline documentation for hooks in wp-admin/includes/image.php. 
Props theorboman, kpdesign.
Fixes #25832.

Built from https://develop.svn.wordpress.org/trunk@27202


git-svn-id: http://core.svn.wordpress.org/trunk@27059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-20 06:27:13 +00:00
John Blackbourn 32114a645d Add screen-reader friendly variations of some short text links in the Publish meta box. Fixes #25459. 
Built from https://develop.svn.wordpress.org/trunk@27196


git-svn-id: http://core.svn.wordpress.org/trunk@27055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-19 22:44:16 +00:00
Helen Hou-Sandí ab31bf8683 Once upon a time not long ago, 
The admin CSS was merged in #18314.
After a couple years as it stood,
The mess it had become just was no good.
One day we realized Grunt is pretty cool,
And said "we should use this as our build tool!"
Now we can maintain separate files with ease,
Using @import and cssmin meets all our needs.
Welcome to the future of the WordPress stylesheets,
And thanks to Slick Rick for the beats.

props jorbin for the initial patch.
fixes #26669.

Built from https://develop.svn.wordpress.org/trunk@27195


git-svn-id: http://core.svn.wordpress.org/trunk@27054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-19 21:43:14 +00:00
Sergey Biryukov 6919d9f197 Use correct variable. props avryl. fixes #27153. 
Built from https://develop.svn.wordpress.org/trunk@27194


git-svn-id: http://core.svn.wordpress.org/trunk@27053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-19 15:29:14 +00:00
Scott Taylor ca4045ce76 Use `selected()` where appropriate in `touch_time()`, `page_template_dropdown()`, and `parent_dropdown()`. Also, add proper docs. 
Props meloniq, DrewAPicture.
Fixes #25889.


Built from https://develop.svn.wordpress.org/trunk@27188


git-svn-id: http://core.svn.wordpress.org/trunk@27047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-17 22:27:15 +00:00
Andrew Nacin 5f0981788d Detect and handle symlinking of plugins in plugin_basename(). 
props rmccue, MikeSchinkel, jdgrimes.
see #16953.

Built from https://develop.svn.wordpress.org/trunk@27158


git-svn-id: http://core.svn.wordpress.org/trunk@27024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-10 23:00:15 +00:00
Drew Jaynes 30c7a12aa2 Fix docs spacing missed in [27136]. 
See #27070.

Built from https://develop.svn.wordpress.org/trunk@27137


git-svn-id: http://core.svn.wordpress.org/trunk@27004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 22:19:11 +00:00
Drew Jaynes 8b3c9c6b97 Improve inline documentation for `submit_button()`. 
See #27070.

Built from https://develop.svn.wordpress.org/trunk@27136


git-svn-id: http://core.svn.wordpress.org/trunk@27003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 22:14:12 +00:00
Drew Jaynes de97319ad8 Clarify `submit_button()` `$type` parameter docs to mention that the value doubles as the CSS class attribute. 
See #27070

Built from https://develop.svn.wordpress.org/trunk@27135


git-svn-id: http://core.svn.wordpress.org/trunk@27002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 22:11:15 +00:00
Andrew Nacin dbea669271 Improve parameter documentation of add_meta_box(). 
props philiparthurmoore, DrewAPicture.
fixes #26698.

Built from https://develop.svn.wordpress.org/trunk@27132


git-svn-id: http://core.svn.wordpress.org/trunk@26999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 00:55:12 +00:00
Scott Taylor 03dda3b273 Introduce `maybe_regenerate_attachment_metadata( $attachment )`. On the Edit Media screen, call it for Audio and Video files. 
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.

This is the minimum viable product for #26825, but leaving the ticket open unless this function needs to be called in other places.

See #26825.


Built from https://develop.svn.wordpress.org/trunk@27127


git-svn-id: http://core.svn.wordpress.org/trunk@26994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-07 22:41:12 +00:00
Helen Hou-Sandí 0100dd772a Merge colors.css into wp-admin.css. Non-default color schemes became overloads rather than swaps in the 3.8 redesign. Benefits include: 
* No more border-width, border-style, border-color insanity.
* Point releases are much less likely to require extra finagling to avoid rebuilding the color schemes.
* Yours truly has a better overall vision of ~14,000 lines of admin CSS and where we go from here.

1,065 net lines of red, y'all.
props helen, jorbin. fixes #18380.

Built from https://develop.svn.wordpress.org/trunk@27106


git-svn-id: http://core.svn.wordpress.org/trunk@26973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-06 06:25:18 +00:00
Drew Jaynes 68f9370ae9 Inline documentation for hooks in wp-admin/includes/class-wp-ms-themes-list-table.php. 
Also marks two hooks in wp-admin/includes/class-wp-themes-list-table.php as duplicates.

Props ShinichiN, kpdesign, DrewAPicture.
Fixes #25608.

Built from https://develop.svn.wordpress.org/trunk@27090


git-svn-id: http://core.svn.wordpress.org/trunk@26962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-04 08:25:13 +00:00
Drew Jaynes 771f8dc244 Inline documentation for hooks in wp-admin/includes/class-wp-terms-list-table.php. 
Props Ajay, kpdesign.
Fixes #26209.

Built from https://develop.svn.wordpress.org/trunk@27089


git-svn-id: http://core.svn.wordpress.org/trunk@26961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-04 07:56:12 +00:00
Andrew Ozz 87c3c8adc0 Open previews of different posts in different windows/tabs. Prevent confusion when using a former preview window again if the user navigated to edit another post. If the first post is still being edited, clicking Preview there will use the current window to show the preview. Props ippetkov, fixes #20233. 
Built from https://develop.svn.wordpress.org/trunk@27079


git-svn-id: http://core.svn.wordpress.org/trunk@26952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-02 23:50:13 +00:00
Andrew Nacin 39e32ed1eb Consistently trim and unslash search queries for the users list tables. 
props aubreypwd.
fixes #26115.

Built from https://develop.svn.wordpress.org/trunk@27077


git-svn-id: http://core.svn.wordpress.org/trunk@26950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-02 22:10:12 +00:00
Drew Jaynes 0715a1d551 Inline documentation for hooks in wp-admin/includes/export.php. 
Props cmmarslender, kpdesign.
Fixes #26894.

Built from https://develop.svn.wordpress.org/trunk@27048


git-svn-id: http://core.svn.wordpress.org/trunk@26922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-28 08:10:12 +00:00