Commit Graph

246 Commits

Author SHA1 Message Date
Drew Jaynes 5e51ea9940 Priority fixes for various existing hook documentation.
Props kpdesign.
See #26869

Built from https://develop.svn.wordpress.org/trunk@28083


git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 00:01:15 +00:00
Drew Jaynes acf9fbc808 Remove a blank line and @global reference in the PHPDoc for `comment_author_email_link()`.
Props norcross, ocean90.
Fixes #27655.

Built from https://develop.svn.wordpress.org/trunk@27943


git-svn-id: http://core.svn.wordpress.org/trunk@27773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 04:36:15 +00:00
Andrew Nacin 502ac958e5 Pass walker arguments to get_comment_link() so pagination works when wp_list_comments() is used outside the comment template.
props SergeyBiryukov.
fixes #27007.

Built from https://develop.svn.wordpress.org/trunk@27799


git-svn-id: http://core.svn.wordpress.org/trunk@27634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 02:38:14 +00:00
Sergey Biryukov 8343fabff6 Avoid a notice in trackback_rdf() if user agent is not set.
props joostdevalk.
fixes #27374.
Built from https://develop.svn.wordpress.org/trunk@27514


git-svn-id: http://core.svn.wordpress.org/trunk@27357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-12 12:54:15 +00:00
Andrew Nacin 1699153d26 Pass the comment object to the get_comment_date and get_comment_time.
props SergeyBiryukov.
fixes #19849.

Built from https://develop.svn.wordpress.org/trunk@27283


git-svn-id: http://core.svn.wordpress.org/trunk@27139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 16:41:14 +00:00
Drew Jaynes cb8951b0b3 Remove all `@package` and `@subpackage` PHPDoc tags not at the file- or class-levels in core.
See #27200.

Built from https://develop.svn.wordpress.org/trunk@27262


git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:14:14 +00:00
Drew Jaynes c8665c5973 Fix a typo in the PHPDoc for `comment_author_email_link()`.
See #27083.

Built from https://develop.svn.wordpress.org/trunk@27157


git-svn-id: http://core.svn.wordpress.org/trunk@27023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-10 04:07:12 +00:00
Drew Jaynes 8eb2d3610b Inline documentation cleanup in wp-includes/comment-template.php.
This cleanup follows [25567] and brings the docs in-line with standards that at the time had not yet been finalized.

These changes include
* Moving in-line `@see` tags to their own lines
* Using docs-specific variables in hook docs
* Fixing line-wrapping throughout
* Typos and punctuation
* Converting hash notation values to variables per the standard

Fixes #27083. See #20495.

Built from https://develop.svn.wordpress.org/trunk@27156


git-svn-id: http://core.svn.wordpress.org/trunk@27022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-10 03:20:12 +00:00
Drew Jaynes cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Andrew Nacin 808653e2a3 Add echo arguments to wp_list_comments() and Walker_Comment, allowing non-echo usage.
props mikelittle.
fixes #10948.

Built from https://develop.svn.wordpress.org/trunk@26353


git-svn-id: http://core.svn.wordpress.org/trunk@26254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 14:59:10 +00:00
Andrew Nacin d0cfa40983 Add jshintrc to qunit.
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Drew Jaynes 15fb059069 Inline documentation for the Walker_Comment class in wp-includes/comment-template.php
Fixes #25388.

Built from https://develop.svn.wordpress.org/trunk@25588


git-svn-id: http://core.svn.wordpress.org/trunk@25505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 23:29:11 +00:00
Drew Jaynes 681b1c35b5 Inline documentation for hooks in wp-includes/comment-template.php.
Fixes #25396.

Built from https://develop.svn.wordpress.org/trunk@25584


git-svn-id: http://core.svn.wordpress.org/trunk@25501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 21:21:09 +00:00
Drew Jaynes 731db6bcb5 Inline documentation for `comment_form()` argument defaults missed in [25573].
See #25388.

Built from https://develop.svn.wordpress.org/trunk@25575


git-svn-id: http://core.svn.wordpress.org/trunk@25492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 17:30:08 +00:00
Drew Jaynes fe40604971 Improve inline documentation of arguments for `comment_form()`.
See #25388.

Built from https://develop.svn.wordpress.org/trunk@25573


git-svn-id: http://core.svn.wordpress.org/trunk@25490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 17:16:08 +00:00
Drew Jaynes e4987beba3 Inline documentation improvements for wp-includes/comment-template.php.
Changes include:
- Existing phpdoc block improvements
- Inclusion of defaults for optional parameters
- Hash-notated argument arrays
- Removal of unnecessary or redundant tagging.

Also standardization of int|WP_Post function parameters.

These changes clear the way toward less redundancy for hook docs in a future ticket.

Still left: Fully documented arguments in `comment_form()` and a pass through Walker_Comment.

See #20495. See #25388.

Built from https://develop.svn.wordpress.org/trunk@25567


git-svn-id: http://core.svn.wordpress.org/trunk@25485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 04:16:08 +00:00
Dominik Schilling 8546983da6 Replace !$user_ID with !is_user_logged_in(). props garyc40. see #15508.
Built from https://develop.svn.wordpress.org/trunk@25562


git-svn-id: http://core.svn.wordpress.org/trunk@25480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-22 10:16:09 +00:00
Scott Taylor 11db0d3b01 Add an `$args` parameter to `comment_text` and `get_comment_text` filters. Adds filter docs. Improve docblocks for `get_comment_text()` and `comment_text()`.
Props simonwheatley, ericlewis, DrewAPicture.
Fixes #14856. 


Built from https://develop.svn.wordpress.org/trunk@25555


git-svn-id: http://core.svn.wordpress.org/trunk@25475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 18:18:09 +00:00
Drew Jaynes 98d5c50e5f Clarify phpdoc for `get_comment_author_link()`.
props nofearinc. Fixes #24508.

Built from https://develop.svn.wordpress.org/trunk@25494


git-svn-id: http://core.svn.wordpress.org/trunk@25415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 05:56:10 +00:00
Sergey Biryukov 7407bd1946 Inline documentation for get_comment_reply_link() and 'comment_reply_link' filter.
props DrewAPicture.
fixes #25310.
Built from https://develop.svn.wordpress.org/trunk@25428


git-svn-id: http://core.svn.wordpress.org/trunk@25352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 19:20:09 +00:00
Sergey Biryukov 9e9b9b5508 Make sure $args is an array before treating it as such. fixes #25151 for trunk.
Built from https://develop.svn.wordpress.org/trunk@25151


git-svn-id: http://core.svn.wordpress.org/trunk@25130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-28 05:28:09 +00:00
Andrew Nacin e01352fe2f Ensure a user exists in get_comment_author().
props azaozz.
see #24084.

Built from https://develop.svn.wordpress.org/trunk@25136


git-svn-id: http://core.svn.wordpress.org/trunk@25116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-27 13:17:09 +00:00
Andrew Nacin 71af3a2004 Remove pattern="" in the comment form (HTML5 mode) to avoid mistaken :invalid styles.
This was originally included for Opera 10, but is not needed as of Opera 11, and current is Opera 15.

props jorbin, markjaquith.
fixes #24475.



git-svn-id: http://core.svn.wordpress.org/trunk@24573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 21:59:10 +00:00
Dominik Schilling f27e762085 Replace the `cite` element with a `b` element to markup the comment author in comment_html5().
In HTML5 the `cite` element isn't valid for just an author's name.
"The cite element represents the title of a work [..] A person's name is not the title of a work" (http://www.w3.org/TR/html5/text-level-semantics.html#the-cite-element)

fixed #24522.

git-svn-id: http://core.svn.wordpress.org/trunk@24539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-01 18:26:16 +00:00
Andrew Nacin ca1e73ca84 Comment form: Add HTML classes.
* #respond gains .comment-respond
 * #reply-title gains .comment-reply-titlw
 * form gains .comment-form

props obenland.
see #23851.



git-svn-id: http://core.svn.wordpress.org/trunk@24525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-27 21:18:08 +00:00
Andrew Nacin 5969819038 `add_theme_support( 'html5', array( 'comment-list', 'search-form', 'comment-form' ) );'
props obenland.
see #23850.



git-svn-id: http://core.svn.wordpress.org/trunk@24417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 15:31:34 +00:00
Sergey Biryukov 4b13a1ffa4 Fix E_STRICT notices in walkers. props dvarga. see #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 03:29:15 +00:00
Andrew Nacin 7cc15a2e7f Remove use of global $id from comment_form() and the media list table. see #24330.
git-svn-id: http://core.svn.wordpress.org/trunk@24337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-23 18:40:16 +00:00
Sergey Biryukov 57c10eadbb Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714.
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:27:31 +00:00
Andrew Nacin 92b4636e17 Required arguments can't follow optional arguments.
Make required arguments optional in confirm_blog_signup().

Mark arguments as required in _future_post_hook(), the walker method display_element(), get_author_link() (deprecated), and the WP_Widget constructor.

props rlerdorf.
see #24210.



git-svn-id: http://core.svn.wordpress.org/trunk@24126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:26:31 +00:00
Sergey Biryukov 2c63da143b Fix inconsistent spacing in comment_form(). props sim, TravisHoffman. fixes #23878.
git-svn-id: http://core.svn.wordpress.org/trunk@23932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-07 23:57:35 +00:00
Mark Jaquith b3f6427c6f Improve wp_list_comments() markup.
* Whitespace cleanup
* Accepts format=html5 which uses some of the HTML5 elements
* Some helpful HTML comments to help untangle the HTML
* Other misc code cleanup

props lancewillett, obenland, georgestephanis. fixes #20088.

git-svn-id: http://core.svn.wordpress.org/trunk@23694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-14 04:26:04 +00:00
Mark Jaquith a1e32d3217 Add the ability to use HTML5 input types in the comment form.
props jorbin, georgestephanis, obenland. fixes #15080

git-svn-id: http://core.svn.wordpress.org/trunk@23689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 20:31:43 +00:00
Andrew Nacin f994ff39ac Add filters to comments_link_feed(), comment_link(), and get_comments_link(). esc_url() the echoed output of comments_link().
props MarcusPope.
fixes #19210.



git-svn-id: http://core.svn.wordpress.org/trunk@23624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-06 19:57:31 +00:00
Ryan Boren 3854fe2e0f Put required field indicators within labels. Update styling of bundled themes to accommodate. Props MikeHansenMe. fixes #21897
git-svn-id: http://core.svn.wordpress.org/trunk@22123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-05 16:34:32 +00:00
Ryan Boren 359de78b7d Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 18:26:25 +00:00
Ryan Boren faca571a3a Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 18:21:47 +00:00
Ryan Boren cfb35a9d85 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 16:29:28 +00:00
ryan 7b49ad8493 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-30 18:30:03 +00:00
ryan 50fc51d8d2 Don't attempt to define the COMMENTS_TEMPLATE constant twice. Props kitchin. fixes #21337
git-svn-id: http://core.svn.wordpress.org/trunk@21330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 17:54:35 +00:00
ryan ef95736bce Set the global comment var before invoking callbacks in wp_list_comments(). Props sirzooro. fixes #21184
git-svn-id: http://core.svn.wordpress.org/trunk@21324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 16:27:48 +00:00
ryan 01dd4131b8 Don't allow unfiltered HTML comments from a frame. Props nacin. fixes #20812
git-svn-id: http://core.svn.wordpress.org/trunk@20974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 20:47:08 +00:00
nacin 5ab06c336e In comment_form(), pass the $post_id to comments_open(). props insertvisionhere. fixes #20572.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 01:47:22 +00:00
ryan de41bc288b Introduce WP_User::exists(). see #20372
git-svn-id: http://svn.automattic.com/wordpress/trunk@20378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-06 19:18:45 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan 83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
ryan fd1393ab7a Clear strict notices for the walkers. fixes #19249
git-svn-id: http://svn.automattic.com/wordpress/trunk@19679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 23:03:46 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin 30ff37104d Don't use $user_identity global. props duck_. fixes #19146.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 21:35:44 +00:00
duck_ e4ed63fc6f Fix typos in documentation (wp-includes/[a-h]). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 16:02:41 +00:00