oandregal
6476fd96ec
Section styles: improve performance and conceptual consistency.
...
These changes involve:
- Move shared variation definitions from styles.blocks.variations to styles.variations
- Remove blockTypes from styles.variations.
- Do not register shared variations from theme style variation or primary theme.json files.
- Move the merging of theme.json data into the WP_Theme_JSON_Resolver and WP_Theme_JSON classes.
These changes improve performance and are more future-proof API wise.
See conversation at https://github.com/WordPress/gutenberg/issues/62686
Props aaronrobertshaw, oandregal, andrewserong, joemcgill, talldanwp, andrewserong, ramonopoly, richtabor, youknowriad.
See #61312 , #61451 .
Built from https://develop.svn.wordpress.org/trunk@58466
git-svn-id: http://core.svn.wordpress.org/trunk@57915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-24 08:51:16 +00:00
isabel_brison
43b4079e2b
Editor: fix root padding for children of alignfull flow layouts.
...
Updates the root padding CSS selectors so direct children of full width container blocks with flow layout receive padding.
Props isabel_brison, aaronrobertshaw.
Fixes #61464 .
Built from https://develop.svn.wordpress.org/trunk@58444
git-svn-id: http://core.svn.wordpress.org/trunk@57893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-20 08:03:14 +00:00
oandregal
c9fa3d2f32
Global styles: prevent duplicate CSS for block style variations.
...
Props aaronrobertshaw, mukesh27, ramonopoly, isabel_brison, oandregal.
Fixes #61443 .
Built from https://develop.svn.wordpress.org/trunk@58422
git-svn-id: http://core.svn.wordpress.org/trunk@57871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-17 09:44:10 +00:00
isabel_brison
93177aa249
Editor: fix custom CSS output for block style variations.
...
Adds custom CSS to the block style variation rules output by `get_styles_for_block` in class `WP_Theme_JSON`.
Props isabel_brison, aaronrobertshaw.
Fixes #61425 .
Built from https://develop.svn.wordpress.org/trunk@58421
git-svn-id: http://core.svn.wordpress.org/trunk@57870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-17 03:49:11 +00:00
oandregal
d2ebe7d776
Section styles: add slug to override non-kebab-cased variations.
...
Props aaronrobertshaw, oandregal.
Fixes #61440 .
Built from https://develop.svn.wordpress.org/trunk@58413
git-svn-id: http://core.svn.wordpress.org/trunk@57862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-14 09:05:11 +00:00
hellofromTonya
b5ec907fb0
Code Modernization: Use wp_trigger_error() instead of trigger_error().
...
Replaces `trigger_error()` with `wp_trigger_error()`.
The usage of `wp_trigger_error()` avoids generating `E_USER` family errors unless `WP_DEBUG` is on. In doing so, users should not see these messages in normal production.
Notes:
* Removes `E_USER_NOTICE` when passed as an argumnent, as it's the default error level.
* An empty string is passed for the function name when its name is already in the error message or does not add value to the error message.
* Externally maintained libraries are not included.
Follow-up to [55204], [25956], [29630], [38883], [52062], [52049], [54272], [38883], [55245], [51599], [14452], [38883], [24976].
Props prasadkarmalkar, rajinsharwar, thelovekesh, hellofromTonya, swissspidy.
Fixes #59652 .
Built from https://develop.svn.wordpress.org/trunk@58409
git-svn-id: http://core.svn.wordpress.org/trunk@57858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-13 20:50:14 +00:00
oandregal
43dd91cdc6
Editor: code quality improvements for theme.json migrate API
...
Backports https://github.com/WordPress/gutenberg/pull/62305
Follow-up to [58328], #61282 .
Props ajlende, oandregal, ramonopoly, mukesh27.
Fixes #61282 .
Built from https://develop.svn.wordpress.org/trunk@58354
git-svn-id: http://core.svn.wordpress.org/trunk@57806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-06 08:02:16 +00:00
oandregal
2b50b6ab1d
Editor: improve code quality of theme.json classes.
...
Follow-up to [58328], #61282 .
Props ajlende, ramonopoly.
Fixes #61370 .
Built from https://develop.svn.wordpress.org/trunk@58339
git-svn-id: http://core.svn.wordpress.org/trunk@57795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-05 08:13:15 +00:00
ellatrix
5b9f383603
Editor: Add theme.json v3 migrations.
...
See https://github.com/WordPress/wordpress-develop/pull/6616 .
See also the original Gutenberg PRs:
* https://github.com/WordPress/gutenberg/pull/58409
* https://github.com/WordPress/gutenberg/pull/61328
* https://github.com/WordPress/gutenberg/pull/61842
* https://github.com/WordPress/gutenberg/pull/62199
* https://github.com/WordPress/gutenberg/pull/62252
Fixes #61282 .
Props ajlende, talldanwp, ramonopoly, ellatrix.
Built from https://develop.svn.wordpress.org/trunk@58328
git-svn-id: http://core.svn.wordpress.org/trunk@57785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-04 11:55:14 +00:00
ellatrix
12bc7a8bcd
Editor: add textAlign block support.
...
See https://github.com/WordPress/gutenberg/pull/59531 .
See https://github.com/WordPress/gutenberg/pull/61182 .
See https://github.com/WordPress/gutenberg/pull/61717 .
See https://github.com/WordPress/wordpress-develop/pull/6590 .
Fixes #61256 .
Props wildworks, ellatrix.
Built from https://develop.svn.wordpress.org/trunk@58314
git-svn-id: http://core.svn.wordpress.org/trunk@57771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-06-04 05:36:20 +00:00
Pascal Birchler
bec7acd268
Docs: Improve docblock for `WP_Theme_JSON::get_stylesheet()`.
...
See #60699 .
Built from https://develop.svn.wordpress.org/trunk@58266
git-svn-id: http://core.svn.wordpress.org/trunk@57729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-31 09:40:15 +00:00
noisysocks
e2417763fa
Fix indentation and whitespace in WP_Theme_JSON and WP_Theme_JSON_Resolver
...
Props mukesh27.
Follows r58264.
See #61312 .
Built from https://develop.svn.wordpress.org/trunk@58265
git-svn-id: http://core.svn.wordpress.org/trunk@57728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-31 06:01:15 +00:00
noisysocks
51c676d7ea
Block Themes: Add section styling via extended block style variations
...
Provide users with the ability to style entire sections of a page without
having to tediously reapply the same sets of styles.
This is done by extending block style variations to apply to nested blocks.
See https://github.com/WordPress/gutenberg/pull/57908 .
Fixes #61312 .
Props aaronrobertshaw, talldanwp, ramonopoly, isabel_brison, andrewserong.
Built from https://develop.svn.wordpress.org/trunk@58264
git-svn-id: http://core.svn.wordpress.org/trunk@57727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-31 05:49:14 +00:00
isabel_brison
bfab5160b3
Editor: Update util for scoping CSS selectors.
...
Adds early return for existing scope_selector method in preparation for extending block style variations.
Props aaronrobertshaw, audrasjb, isabel_brison.
Fixes #61120 .
Built from https://develop.svn.wordpress.org/trunk@58245
git-svn-id: http://core.svn.wordpress.org/trunk@57708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-30 05:22:05 +00:00
isabel_brison
6f9de6388c
Editor: Add scoping of feature level global styles selectors.
...
Ensures that feature-level selectors for block style variations are correctly scoped when generating a theme.json stylesheet.
Props aaronrobertshaw, audrasjb, vcanales, isabel_brison.
Fixes #61119 .
Built from https://develop.svn.wordpress.org/trunk@58244
git-svn-id: http://core.svn.wordpress.org/trunk@57707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-30 04:40:07 +00:00
isabel_brison
1b218aaa39
Editor: add aspect ratio presets support.
...
Enables customizing the list of aspect ratio options available through theme.json.
Props fabiankaegy, isabel_brison, swissspidy.
Built from https://develop.svn.wordpress.org/trunk@58242
git-svn-id: http://core.svn.wordpress.org/trunk@57705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-30 03:10:10 +00:00
isabel_brison
e3f4aa35d8
Editor: level global styles specificity at 0-1-0.
...
Adjusts the block level global styles selectors so they have a consistent specificity of 0-1-0, and adjusts base and layout global style selectors to their minimum required specificity.
Props aaronrobertshaw, isabel_brison, andrewserong, mukesh27.
Fixes #61165 .
Built from https://develop.svn.wordpress.org/trunk@58241
git-svn-id: http://core.svn.wordpress.org/trunk@57704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-30 01:16:07 +00:00
ellatrix
6a2b736c2f
Theme JSON: Extract util to get valid block style variations.
...
Extracts the repeated collection of valid block style variations into a util that can be reused or updated in a single place for future work around extending block style variations.
Backports https://github.com/WordPress/gutenberg/pull/61030 .
Props aaronrobertshaw, audrasjb.
Fixes #61121 .
Built from https://develop.svn.wordpress.org/trunk@58228
git-svn-id: http://core.svn.wordpress.org/trunk@57691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-29 07:46:11 +00:00
isabel_brison
0bf7df15f3
Editor: improve consistency of root padding.
...
Improve the behaviour of global padding when useRootPaddingAwareAlignments is enabled in theme.json to be more consistent across blocks, templates and patterns.
Props richtabor, isabel_brison, andrewserong.
Fixes #61304 .
Built from https://develop.svn.wordpress.org/trunk@58226
git-svn-id: http://core.svn.wordpress.org/trunk@57689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-29 05:15:14 +00:00
noisysocks
1284a7fe99
Block Themes: Allow setting site-wide background images in theme.json
...
Syncs the necessary changes from Gutenberg to allow setting site-wide
background images using the top-level `styles.background` key in `theme.json`.
Props ramonopoly.
Fixes #61123 .
Built from https://develop.svn.wordpress.org/trunk@58222
git-svn-id: http://core.svn.wordpress.org/trunk@57685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-28 06:06:11 +00:00
isabel_brison
ff2929bf19
Editor: pass fluid typography theme.json settings to `wp_get_typography_font_size_value`.
...
Updates `wp_get_typography_font_size_value` to accept an array of theme.json settings instead of a boolean derived from global state.
Props ramonopoly, audrasjb.
Fixes #61118 .
Built from https://develop.svn.wordpress.org/trunk@58171
git-svn-id: http://core.svn.wordpress.org/trunk@57634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-18 23:18:15 +00:00
isabel_brison
00b440c27d
Editor: move global CSS custom properties to `:root` selector.
...
Changes the rules outputting global styles CSS custom properties to use `:root` instead of `body`, and cleans up some unused variables.
Props ramonopoly, isabel_brison.
Fixes #61135 .
Built from https://develop.svn.wordpress.org/trunk@58123
git-svn-id: http://core.svn.wordpress.org/trunk@57588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-09 04:09:13 +00:00
isabel_brison
9fd435aa15
Editor: fix spacing in function doc.
...
Correctly formats spacing in `get_layout_styles` docblock.
Props mukesh27, sabernhardt.
See #60981 .
Built from https://develop.svn.wordpress.org/trunk@58030
git-svn-id: http://core.svn.wordpress.org/trunk@57496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-04-22 07:20:09 +00:00
isabel_brison
9ecc777ded
Editor: limit layout rules on themes without theme.json.
...
Removes output of base rules for flow and constrained layout types on themes without theme.json.
Props evanltd, poena, isabel_brison, andrewserong, oandregal.
See #60981 .
Built from https://develop.svn.wordpress.org/trunk@58028
git-svn-id: http://core.svn.wordpress.org/trunk@57494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-04-22 05:30:13 +00:00
Pascal Birchler
00d06db33d
Docs: Fix various typos and spelling mistakes.
...
Props swissspidy, jucaduca, sergeybiryukov.
See #60699 .
Built from https://develop.svn.wordpress.org/trunk@57987
git-svn-id: http://core.svn.wordpress.org/trunk@57473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-04-12 17:47:13 +00:00
isabel_brison
8fbd2fc6f4
Editor: skip outputting base layout rules if content and wide size values don’t exist.
...
Skip outputting layout rules that reference content and wide sizes CSS variables, if no layout sizes exist in the current `theme.json`.
Props andrewserong.
Fixes #60936 .
Built from https://develop.svn.wordpress.org/trunk@57948
git-svn-id: http://core.svn.wordpress.org/trunk@57445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-04-09 07:20:15 +00:00
Pascal Birchler
0c4eec233d
Editor: disable `shadow.defaultPresets` for classic themes.
...
With this change default shadow presets are never shown for classic themes, and classic themes have no options for adding custom ones.
This essentially reverts [57717] and [57827] / [57828], which had unintended consequences.
Props ajlende, oandregal, madhudollu, swissspidy, get_dave, andrewserong, desrosj.
Fixes #60815 .
Built from https://develop.svn.wordpress.org/trunk@57885
git-svn-id: http://core.svn.wordpress.org/trunk@57386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-03-27 16:00:12 +00:00
Pascal Birchler
2a334ede98
Editor: Simplify sanitization code path in `WP_Theme_JSON` after [57496]
...
Removes the custom `WP_Theme_JSON::is_assoc()` method again in favor of the existing `wp_is_numeric_array()` helper function.
Props mmaattiiaass, costdev, swissspidy, spacedmonkey.
Fixes #60360 .
Built from https://develop.svn.wordpress.org/trunk@57751
git-svn-id: http://core.svn.wordpress.org/trunk@57252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-03-02 13:41:05 +00:00
Pascal Birchler
29a2c3a05a
Editor: add `shadow.defaultPresets` to appearance tools opt-ins.
...
Props madhudollu.
Fixes #60633 .
Built from https://develop.svn.wordpress.org/trunk@57717
git-svn-id: http://core.svn.wordpress.org/trunk@57218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:22:11 +00:00
youknowriad
9f0595ab4a
Editor: Check for null values in Theme JSON to cater for blockGap.
...
When resolving theme.json preset variables, add a check to make sure the value is not empty before we run it through strpos() and preg_match_all().
Props ramonopoly, mukesh27, get_dave.
Fixes #60613 .
Built from https://develop.svn.wordpress.org/trunk@57716
git-svn-id: http://core.svn.wordpress.org/trunk@57217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:15:13 +00:00
youknowriad
8f1ccc91ae
Editor: Fix block style variation selector generation.
...
These changes fix the generation of selectors for block style variations. Previously, an incorrect CSS selector could be generated if the block's base selector used an element tag etc.
Props aaronrobertshaw, youknowriad, mukesh27.
Fixes #60453 .
Built from https://develop.svn.wordpress.org/trunk@57547
git-svn-id: http://core.svn.wordpress.org/trunk@57048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-07 08:53:13 +00:00
youknowriad
e28108b73e
Editor: Sanitize nested array in theme.json properly.
...
WP_Theme_JSON sanitization is now able to sanitize data contained on indexed arrays.
So certain data from theme.json, for example, settings.typography.fontFamilies which is a JSON array will be sanitized.
Props mmaattiiaass, mukesh27.
Fixes #60360 .
Built from https://develop.svn.wordpress.org/trunk@57496
git-svn-id: http://core.svn.wordpress.org/trunk@56997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-31 10:55:10 +00:00
isabel_brison
2140b001bd
Editor: introduce `dimensions.aspectRatio` block support.
...
Adds front end rendering logic for the `dimensions.aspectRatio` block support as well as the required logic in `WP_Theme_JSON` and the style engine.
Props andrewserong.
Fixes #60365 .
Built from https://develop.svn.wordpress.org/trunk@57491
git-svn-id: http://core.svn.wordpress.org/trunk@56992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-31 02:54:17 +00:00
isabel_brison
04eb7ecf30
Editor: reduce specificity of block style variation selector.
...
Removes duplicate classname from the block style variation selector generated in `WP_Theme_JSON`’s `get_blocks_metadata` function.
Props flixos90, joemcgill, mukesh27, isabel_brison.
Fixes #60312 .
Built from https://develop.svn.wordpress.org/trunk@57490
git-svn-id: http://core.svn.wordpress.org/trunk@56991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-30 23:51:15 +00:00
youknowriad
02cdd7f047
Editor: Fix Theme.json application of custom root selector for styles.
...
Theme.json stylesheets attempting to use a custom root selector are generated with in correct styles.
Props aaronrobertshaw, get_dave, mukesh27.
Fixes #60343 .
Built from https://develop.svn.wordpress.org/trunk@57352
git-svn-id: http://core.svn.wordpress.org/trunk@56858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-25 10:43:12 +00:00
youknowriad
7343352744
Editor: Unset reference used in foreach statement.
...
In PHP it is a good practice to unset $value if it was created by reference in a foreach loop, as the reference is still valid outside the loop, and this avoids accidental bugs.
Props get_dave.
Fixes #60326 .
Built from https://develop.svn.wordpress.org/trunk@57340
git-svn-id: http://core.svn.wordpress.org/trunk@56846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-23 17:11:11 +00:00
isabel_brison
90088c4c92
Editor: add size and repeat to background image support.
...
Adds background size and background repeat style processing to the background image block support and `WP_Style_Engine` definitions.
Props andrewserong, mukesh27.
Fixes #60175 .
Built from https://develop.svn.wordpress.org/trunk@57254
git-svn-id: http://core.svn.wordpress.org/trunk@56760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-09 06:12:18 +00:00
isabel_brison
d966a9f046
Editor: add setting to disable layout content and wide size controls.
...
Adds support for an `allowCustomContentAndWideSize` setting in `WP_Theme_JSON` valid settings.
Props andrewserong.
Fixes #60133 .
Built from https://develop.svn.wordpress.org/trunk@57247
git-svn-id: http://core.svn.wordpress.org/trunk@56753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-08 06:23:14 +00:00
Sergey Biryukov
25a147845b
I18N: Move code out of translatable strings in a few error messages.
...
Follow-up to [54272], [56101].
Props rabmalin, Presskopp.
Fixes #59563 .
Built from https://develop.svn.wordpress.org/trunk@57135
git-svn-id: http://core.svn.wordpress.org/trunk@56646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-11-25 21:19:30 +00:00
isabel_brison
5951111cba
Editor: fix incorrect block custom CSS output.
...
Fixes output of block custom CSS when multiple rules require a descendant selector.
Props wildworks, mikachan.
Fixes #59499 .
Built from https://develop.svn.wordpress.org/trunk@56812
git-svn-id: http://core.svn.wordpress.org/trunk@56324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-10-10 03:43:22 +00:00
audrasjb
b5bddaa39d
Editor: Fix wrong `@since` mention in `remove_insecure_properties()`.
...
Follow-up to [56502].
See #59108 .
Built from https://develop.svn.wordpress.org/trunk@56778
git-svn-id: http://core.svn.wordpress.org/trunk@56290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-10-04 19:03:26 +00:00
Sergey Biryukov
9bf6faff7c
Editor: Reduce the use of the `_wp_array_get()` function to improve performance.
...
`_wp_array_get()` is an expensive function, and it's called thousands of times on each page view on the front end. While the function performance was slightly improved in #58376 , it is still called more times than it should be.
This commit aims to further optimize its usage:
* In many cases, `_wp_array_get()` can be replaced with a much simpler and faster `isset()` check.
* The `isset()` function is capable of checking nested arrays, so `isset( $foo['a']['b']['c'] )` will return false even if `$foo['a']` is unset, without throwing any errors or warnings.
* When `_wp_array_get()` cannot be directly replaced with `isset()`, it would be good practice to wrap it in an `isset()` function so that `_wp_array_get()` only runs when it needs to.
Original PR from Gutenberg repository:
* [https://github.com/WordPress/gutenberg/pull/51116 #51116 Performance improvement: Reduce the use of the _wp_array_get() function]
Follow-up to [55851], [56382].
Props aristath, jrf, spacedmonkey, mukesh27, swissspidy, hellofromTonya.
Fixes #59405 .
Built from https://develop.svn.wordpress.org/trunk@56709
git-svn-id: http://core.svn.wordpress.org/trunk@56221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-26 13:47:20 +00:00
isabel_brison
2f5d2da8f8
Editor: add lightbox setting.
...
Adds lightbox as a valid setting to `WP_Theme_JSON` class and as an image block setting in theme.json.
Props czapla, costdev, desrosj.
Fixes #59393 .
Built from https://develop.svn.wordpress.org/trunk@56643
git-svn-id: http://core.svn.wordpress.org/trunk@56155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-21 06:35:20 +00:00
isabel_brison
9c827704be
Editor: fix pattern alignment in editor view.
...
Adjusts root padding for synced patterns in the editor to avoid discrepancies with the front end view.
Props aaronrobertshaw, mukesh27.
Fixes #59359.
Built from https://develop.svn.wordpress.org/trunk@56615
git-svn-id: http://core.svn.wordpress.org/trunk@56127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-19 01:45:21 +00:00
isabel_brison
82f6ce639b
Editor: add background image support.
...
Adds a new background block support with the ability to set a background image on blocks that opt into it.
Props andrewserong, mukesh27.
Fixes #59357 .
Built from https://develop.svn.wordpress.org/trunk@56614
git-svn-id: http://core.svn.wordpress.org/trunk@56126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-19 01:29:23 +00:00
isabel_brison
df3137aca1
Editor: add text orientation for blocks with typography support.
...
Adds a new text orientation option to the typography block support, implemented with CSS writing-mode.
Props poena.
Fixes #59306 .
Built from https://develop.svn.wordpress.org/trunk@56605
git-svn-id: http://core.svn.wordpress.org/trunk@56117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-18 06:49:20 +00:00
Sergey Biryukov
e5490118af
Coding Standards: Include one space after `function` keyword for closures.
...
Note: This is enforced by WPCS 3.0.0.
Reference: [https://github.com/WordPress/WordPress-Coding-Standards/pull/2328 WPCS: PR #2328 Core: properly check formatting of function declaration statements].
Props jrf.
See #59161 , #58831 .
Built from https://develop.svn.wordpress.org/trunk@56559
git-svn-id: http://core.svn.wordpress.org/trunk@56071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-12 15:23:18 +00:00
Sergey Biryukov
b80ce60f70
Coding Standards: Use pre-increment/decrement for stand-alone statements.
...
Note: This is enforced by WPCS 3.0.0:
1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.
References:
* [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators WordPress PHP Coding Standards: Increment/decrement operators]
* [https://github.com/WordPress/WordPress-Coding-Standards/pull/2130 WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators]
Props jrf.
See #59161 , #58831 .
Built from https://develop.svn.wordpress.org/trunk@56549
git-svn-id: http://core.svn.wordpress.org/trunk@56061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-09 09:28:26 +00:00
isabel_brison
b7439d5712
Editor: tweak root padding styles.
...
Removes root padding from children of flex and grid layout blocks when root padding aware alignments are set.
Props andrewserong, ramonopoly.
Fixes #59295 .
Built from https://develop.svn.wordpress.org/trunk@56546
git-svn-id: http://core.svn.wordpress.org/trunk@56058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-08 00:51:18 +00:00
isabel_brison
43a50913d6
Editor: performance enhancements to `class-wp-theme-json`.
...
Removes unnecessary sanitisation of hardcoded strings and avoids looping over style presets without classes or variables.
Props flixos90.
Fixes #59304 .
Built from https://develop.svn.wordpress.org/trunk@56545
git-svn-id: http://core.svn.wordpress.org/trunk@56057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-08 00:26:21 +00:00