Commit Graph

31 Commits

Author SHA1 Message Date
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Andrew Nacin f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett 6268f714e0 Twenty Ten: update code comments to reflect WP inline docs standards. Props DrewAPicture, closes #25256.
Built from https://develop.svn.wordpress.org/trunk@25627


git-svn-id: http://core.svn.wordpress.org/trunk@25544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 17:04:10 +00:00
Lance Willett f8bbb4c6d0 Twenty Ten: clean up r22617, remove extra end comment and indent code. See #20469.
git-svn-id: http://core.svn.wordpress.org/trunk@22621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 22:06:01 +00:00
Lance Willett 9ebd8d18ac Twenty Ten: move the "Comments closed" text outside the `have_comments()` conditional, props kovshenin. Closes #20469.
git-svn-id: http://core.svn.wordpress.org/trunk@22617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 21:35:42 +00:00
ryan 9f5c80eb92 Use one space, not two, after trailing punctuation. Prop Zeo. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-16 17:13:16 +00:00
ryan 7142f4ec36 Check if comment paging is on. Props iandstewart. fixes #13739
git-svn-id: http://svn.automattic.com/wordpress/trunk@15145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-05 14:55:18 +00:00
nacin 113825eaa0 Use p.nopassword instead of div.nopassword in Twenty Ten. props zeo, fixes #13692.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-02 22:45:21 +00:00
nacin 7fb0cc62a6 In Twenty Ten, make classes on larr/rarr consistent, and make sure those are translated. props zeo, see #13198.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 05:35:14 +00:00
nacin a35791a4ae In Twenty Ten, final pass on inline docs et al. props jorbin, zeo. fixes #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-21 18:56:27 +00:00
nacin f713b87e31 In Twenty Ten, documentation and code improvements. see #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-17 06:36:11 +00:00
nacin ff32a9aa28 Various minor tweaks to file-level phpdoc in Twentyten. props dremeda. see #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-17 06:32:03 +00:00
nacin ff66f09ec9 @subpackage cannot have spaces.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 17:10:21 +00:00
nacin 61725ced93 Remove unnecessary and out-of-place Twenty Ten filter. Also, tabs not spaces. see #13198.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 06:26:18 +00:00
nacin 3e035809a1 Twenty Ten spacing and string cleanups. props zeo, markmcwilliams. see #13198. Add a twentyten_credits filter, props nathanrice, fixes #12804. Also clean up the generator/credits string.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-04 07:01:09 +00:00
nbachiyski 855ac9ef4a Use _n() instead of comments_number() in twentyten, because it doesn't handle plurals properly. Props zeo and dimadin. Fixes #13187
git-svn-id: http://svn.automattic.com/wordpress/trunk@14358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 01:07:49 +00:00
nacin 2c26a7b63c Remove unnecessary space in 2010 comments.php. props zeo, fixes #13196.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-30 22:39:37 +00:00
nacin a4c7fb5869 Rough cut of Twenty Ten inline documentation. see #12695. props jorbin, demetris.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-29 22:03:15 +00:00
nacin 40773a776b Remove trailing whites and double semicolons.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:36:49 +00:00
iammattthomas a70633cedc Coding standards cleanup in twentyten, see #9015. Props sivel
git-svn-id: http://svn.automattic.com/wordpress/trunk@13720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-16 20:17:22 +00:00
dd32 7b2c083769 Better internationalisation for TwentyTen. Props filosofo. Fixes #12384
git-svn-id: http://svn.automattic.com/wordpress/trunk@13498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-28 11:43:04 +00:00
markjaquith 0744c77fbf revert function rename from r13129 which broke the comments form. props beaulebens. see #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-16 00:21:06 +00:00
dd32 93b372f1f8 Comments.php PHP cleanup. See #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-14 01:16:58 +00:00
dd32 20c0e6c2ef Fix comment listing, Correct Indentations. See #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-14 01:12:51 +00:00
dd32 f2799cb2e9 Formatting, Translations & Whitespace. Props ptahdunbar. See #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-14 01:00:22 +00:00
ryan 152304f1e1 Use comment_form(). Props beaulebens. see #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-08 21:02:08 +00:00
ryan b235937bcc Escape some attributes. Fix search form action. see #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-08 20:28:13 +00:00
ryan 1e4d04ee6b Use post_password_required(). see #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-08 18:24:01 +00:00
ryan 0ad559106d gettext for twentyten. see #12170
git-svn-id: http://svn.automattic.com/wordpress/trunk@13024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-08 17:59:08 +00:00
ryan 1fb181a4eb Twenty Ten initial import. Props Ian Stewart, Matt Thomas, and others. see #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 16:16:26 +00:00