WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
42,982 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

30185 Commits

Author SHA1 Message Date
Helen Hou-Sandí b456e9c9c8 Upgrade/Install: Consistent layout and accurate messages on the update screen. 
* Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available.
* Adds a message if a version control system has been detected, as automatic updates are disabled in that case.
* Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data.
* Removes some older strings related to auto-updates, which greatly simplifies the above.
* Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice.

Props audrasjb, pbiron, helen.
Fixes #51742.

Built from https://develop.svn.wordpress.org/trunk@49638


git-svn-id: http://core.svn.wordpress.org/trunk@49376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 20:28:04 +00:00
Sergey Biryukov cce65c9baf Users: Use `do_action_ref_array()` for `pre_get_users` and `pre_get_terms` actions. 
This brings some consistency with the other similar actions:

* `pre_get_comments`
* `pre_get_networks`
* `pre_get_posts`
* `pre_get_sites`
* `pre_user_query`

Follow-up to [29363] and [37572].

Props andy, adamsilverstein, hellofromTonya, desrosj, SergeyBiryukov.
Fixes #50961.
Built from https://develop.svn.wordpress.org/trunk@49637


git-svn-id: http://core.svn.wordpress.org/trunk@49375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 20:09:05 +00:00
desrosj bcb9027236 Build/Test Tools: Update the `package.json` `engines` to point to the new LTS versions of Node/NPM. 
Props mkaz, jorbin.
Fixes #51749.
Built from https://develop.svn.wordpress.org/trunk@49636


git-svn-id: http://core.svn.wordpress.org/trunk@49374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 19:52:00 +00:00
Sergey Biryukov dfc3eeff10 General: Rename the `wp_error_checked` action to `is_wp_error_instance` for clarity. 
Follow-up to [49022], [49023].

Props johnbillion, helen, johnjamesjacoby, Mte90, alexstandiford, hellofromTonya, jnylen0, SergeyBiryukov.
Fixes #40568.
Built from https://develop.svn.wordpress.org/trunk@49635


git-svn-id: http://core.svn.wordpress.org/trunk@49373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 19:21:05 +00:00
desrosj 50bf937ebb Build/Test Tools: Update several NPM dependencies. 
These updates were applied when running `npm install`.

See #50769.
Built from https://develop.svn.wordpress.org/trunk@49634


git-svn-id: http://core.svn.wordpress.org/trunk@49372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 19:19:06 +00:00
desrosj 634e6b16c8 Twenty Twenty-One: Sync the latest changes for 5.6 RC1. 
For a full list of changes since [49574-49577], see https://github.com/WordPress/twentytwentyone/compare/aa284fd...trunk.

Props poena, luminuu, kjellr, ryelle, aristath.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49633


git-svn-id: http://core.svn.wordpress.org/trunk@49371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 19:00:08 +00:00
Sergey Biryukov cf75a715c4 App Passwords: Regenerate the `.htaccess` file to add a new rule. 
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems.

This bumps the database version and updates the file so the change is applied to sites upon upgrading to 5.6.

Follow-up to [49534].

Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51723.
Built from https://develop.svn.wordpress.org/trunk@49632


git-svn-id: http://core.svn.wordpress.org/trunk@49370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 17:24:06 +00:00
Sergey Biryukov f97647c207 Plugins: Make sure the HTML ID attributes for plugin checkboxes are unique. 
Follow-up to [48374].

Props helen, sabernhardt, kishanjasani, mukesh27, hareesh-pillai.
Fixes #51256.
Built from https://develop.svn.wordpress.org/trunk@49631


git-svn-id: http://core.svn.wordpress.org/trunk@49369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 16:48:09 +00:00
Sergey Biryukov 7860b364fe Docs: Further remove tautology from comments in `recurse_dirsize()` tests. 
Follow-up to [49212], [49616], [49628].

See #19879.
Built from https://develop.svn.wordpress.org/trunk@49630


git-svn-id: http://core.svn.wordpress.org/trunk@49368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 15:50:06 +00:00
Sergey Biryukov 5801fc9a93 Multisite: Rename the `calculate_current_dirsize` filter to `pre_recurse_dirsize`. 
Set the default value to `false`. This brings some consistency with the `pre_get_space_used` filter.

Follow-up to [49212], [49616], [49628].

See #19879.
Built from https://develop.svn.wordpress.org/trunk@49629


git-svn-id: http://core.svn.wordpress.org/trunk@49367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 15:44:07 +00:00
Sergey Biryukov e123448589 Docs: Adjust comments for `recurse_dirsize()` and related tests per the documentation standards. 
Follow-up to [49212], [49616].

See #19879.
Built from https://develop.svn.wordpress.org/trunk@49628


git-svn-id: http://core.svn.wordpress.org/trunk@49366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 15:38:10 +00:00
Sergey Biryukov f7d3a8b5c4 App Passwords: Add missing i18n for an error message. 
Follow-up to [49617].

See #51513.
Built from https://develop.svn.wordpress.org/trunk@49627


git-svn-id: http://core.svn.wordpress.org/trunk@49365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 10:21:08 +00:00
Sergey Biryukov 1642f9bb1d Docs: Document the `$args` parameter of `wp_oembed_get()`. 
Link to `wp_oembed_get()` as the canonical source when documenting additional arguments in various `WP_oEmbed` methods.

Follow-up to [49620].

See #51269.
Built from https://develop.svn.wordpress.org/trunk@49626


git-svn-id: http://core.svn.wordpress.org/trunk@49364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 10:11:11 +00:00
noisysocks 9f065de733 Customize: Temporary fix for autosave restore notice not being removed 
Fixes the "There is a more recent autosave of your changes" notice from not
being removed when the dismiss button is clicked.

The problem is caused by the notice being initialized twice: once by the
`common` script and then again by the `customize-controls` script.

This temporary fix prevents `customize-controls` from initializing a notice if
it has already been initialized.

A better fix would be to not initialize notices twice. This can be done by
removing `common` as a dependency of `updates` when `deprecateL10nObject` is
removed.

When this happens (est: 5.7), this temporary fix should be reverted.

Fixes #51425.
See #51317.
Props karthikbhatb, dlh, SergeyBiryukov.

Built from https://develop.svn.wordpress.org/trunk@49625


git-svn-id: http://core.svn.wordpress.org/trunk@49363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 04:45:11 +00:00
noisysocks a3c8b3ddea Customize: Ensure multiple CSS classes are passed to nav_menu_link_attributes as an array 
When multiple CSS classes are added to a menu item, the nav_menu_link_attributes
filter should be called with $item->classes set to an array of CSS class names.

When previewing in the Customizer, however, a single string was being passed to
$item->classes because WP_Customize_Nav_Menu_Item_Setting::preview() bypasses
wp_update_nav_menu_item() and instead uses filter_wp_get_nav_menu_items().

The fix is to make filter_wp_get_nav_menu_items() match what
wp_update_nav_menu_item() does and split the string into an array.

Fixes #43113.
Props dlh.

Built from https://develop.svn.wordpress.org/trunk@49624


git-svn-id: http://core.svn.wordpress.org/trunk@49362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 04:31:08 +00:00
noisysocks fb2f5a743b Editor: Update WordPress packages for RC1 
@wordpress/block-directory: 1.17.3 -> 1.17.4
@wordpress/block-library: 2.26.3 -> 2.26.4
@wordpress/edit-post: 3.25.3 -> 3.25.4

Fixes #51793.
Props isabel_brison.

Built from https://develop.svn.wordpress.org/trunk@49623


git-svn-id: http://core.svn.wordpress.org/trunk@49361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 04:13:29 +00:00
Peter Wilson 30b79ebd28 Permalinks: Prevent attachment pages 404ing following [49563]. 
This largely reverts [49563] due to attachment pages returning 404: File not found errors when they use the `inherit` status.

Permalink changes to attachment pages are retained when they are descendants of trashed or deleted posts.

Props Toro_Unit, helen, johnbillion, peterwilsoncc.
Fixes #51776.
See #5272.


Built from https://develop.svn.wordpress.org/trunk@49622


git-svn-id: http://core.svn.wordpress.org/trunk@49360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 03:29:12 +00:00
desrosj 03eba7beb2 Code Modernization: Only call `libxml_disable_entity_loader()` in PHP < 8. 
This function has been deprecated in PHP 8.0 because in libxml 2.9.0, external entity loading is disabled by default, so this function is no longer needed to protect against XXE attacks.

This change fixes an instance of `libxml_disable_entity_loader()` within the getID3 library that has not yet been included in a tagged release for the library.

Props jrf, hellofromtonya.
Fixes #50898.
Built from https://develop.svn.wordpress.org/trunk@49621


git-svn-id: http://core.svn.wordpress.org/trunk@49359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-17 01:00:08 +00:00
Helen Hou-Sandí 85b28a939f Embeds: Document $args in wp_oembed_get(). 
Props hellofromTonya, audrasjb, SergeyBiryukov.
Fixes #51269.

Built from https://develop.svn.wordpress.org/trunk@49620


git-svn-id: http://core.svn.wordpress.org/trunk@49358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 23:13:08 +00:00
whyisjake 3c51950baf Feeds: Add an early exit when calling RSS functions directly. 
While this file is depracated, it shouldn't throw errors when called directly.

Fixes #35835.

Props thib3113, dd32, TheGP, flymike, zodiac1978, williampatton.

Built from https://develop.svn.wordpress.org/trunk@49619


git-svn-id: http://core.svn.wordpress.org/trunk@49357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 22:52:05 +00:00
whyisjake ec9434735a Build/Test Tools: Update several NPM dependencies. 
These updates were applied by running `npm i`. These are changing some `http` links to `https`.

See #50769.

Built from https://develop.svn.wordpress.org/trunk@49618


git-svn-id: http://core.svn.wordpress.org/trunk@49356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 22:47:06 +00:00
TimothyBlynJacobs d9b35c8e98 App Passwords: Unify availability language. 
Previously App Passwords used a mix of "enabled" and "available". We've now standardized on using "available".

Additionally, we now use a 501 status code when indicating that App Passwords is not available.

Props SergeyBiryukov, ocean90, TimothyBlynJacobs.
Fixes #51513.

Built from https://develop.svn.wordpress.org/trunk@49617


git-svn-id: http://core.svn.wordpress.org/trunk@49355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 22:42:04 +00:00
Helen Hou-Sandí aceaf33edd Multisite: More consistency for `clean_dirsize_cache()`. 
Props SergeyBiryukov.
Fixes #19879.

Built from https://develop.svn.wordpress.org/trunk@49616


git-svn-id: http://core.svn.wordpress.org/trunk@49354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 22:31:06 +00:00
Sergey Biryukov 7712866212 Script Loader: Correct version for jQuery Migrate. 
Follow-up to [49338].

See #51621, #50564.
Built from https://develop.svn.wordpress.org/trunk@49615


git-svn-id: http://core.svn.wordpress.org/trunk@49353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 21:36:05 +00:00
Helen Hou-Sandí 14bd8cc469 Posts, Post Types: Go back to "Auto Draft" for CPTs without title support. 
Reverts [49288] due to late point in 5.6 cycle and lack of update in Gutenberg package to account for the string change.
See #45516.

Built from https://develop.svn.wordpress.org/trunk@49614


git-svn-id: http://core.svn.wordpress.org/trunk@49352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 19:44:07 +00:00
Helen Hou-Sandí ee48cca207 Media: Avoid fatal error in `wp_prepare_attachment_for_js(). 
In certain contexts, in particular on the front-end, `get_media_states()` is not availble.

Props rebasaurus.
Fixes #51791.

Built from https://develop.svn.wordpress.org/trunk@49613


git-svn-id: http://core.svn.wordpress.org/trunk@49351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 19:20:09 +00:00
Sergey Biryukov 801152b9d7 Docs: Fix typo in `wp_get_object_terms` filter DocBlock. 
Follow-up to [49597].

See #50768.
Built from https://develop.svn.wordpress.org/trunk@49612


git-svn-id: http://core.svn.wordpress.org/trunk@49350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 17:28:08 +00:00
Sergey Biryukov 6a8f9bf499 Docs: Add missing full stop for a comment in `create_initial_rest_routes()`. 
Follow-up to [49154].

Props david.binda.
Fixes #51788.
Built from https://develop.svn.wordpress.org/trunk@49611


git-svn-id: http://core.svn.wordpress.org/trunk@49349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 16:48:12 +00:00
John Blackbourn 753ae723ad Docs: Corrections and improvements to inline docs relating to the REST API. 
See #50768

Built from https://develop.svn.wordpress.org/trunk@49610


git-svn-id: http://core.svn.wordpress.org/trunk@49348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 11:04:12 +00:00
Sergey Biryukov b51eeb4eef Docs: Drop `src/` from `pre_render_block` duplicate hook reference. 
Follow-up to [49608].

See #51612.
Built from https://develop.svn.wordpress.org/trunk@49609


git-svn-id: http://core.svn.wordpress.org/trunk@49347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 10:53:11 +00:00
noisysocks 341704d640 Editor: Move pre_render_block, render_block_data, render_block_context 
Move the pre_render_block, render_block_data, and render_block_context
filters from render_block() to WP_Block. This ensures that they are
called for all blocks, including nested blocks, not just top-level
blocks.

Fixes #51612.
Props gaambo, gziolo, TimothyBlynJacobs.

Built from https://develop.svn.wordpress.org/trunk@49608


git-svn-id: http://core.svn.wordpress.org/trunk@49346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-16 00:47:11 +00:00
TimothyBlynJacobs 44125fc590 App Passwords: Include authorization rewrite rule in default multisite .htaccess 
This rule was previously added to `WP_Rewrite`, but multisite uses a different .htaccess generation mechanism.

Props pbiron.
Fixes #51772.
See [49109].

Built from https://develop.svn.wordpress.org/trunk@49607


git-svn-id: http://core.svn.wordpress.org/trunk@49345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-15 17:46:06 +00:00
John Blackbourn 14d60739d1 Build/Test Tools: Misc test enhancements. 
See #51344

Built from https://develop.svn.wordpress.org/trunk@49606


git-svn-id: http://core.svn.wordpress.org/trunk@49344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-15 17:19:10 +00:00
John Blackbourn bd52453064 Built/Test Tools: Switch to a data provider for the default user role and capability tests. 
This test previously performed 1,010 assertions, and a failure in any one would prevent the other assertions from running. Using a data provider means simultaneous failures will all be reported at once.

See #51344, #32394

Built from https://develop.svn.wordpress.org/trunk@49605


git-svn-id: http://core.svn.wordpress.org/trunk@49343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-15 14:59:06 +00:00
John Blackbourn 2062b81430 Build/Test Tools: Ensure user capability assertions are performed for all default roles. 
The existing assertions were erroneously placed outside the iteration of all users, and therefore were only run against the last user in the list, which is the Subscriber role.

See #51344, #32394

Built from https://develop.svn.wordpress.org/trunk@49604


git-svn-id: http://core.svn.wordpress.org/trunk@49342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-15 14:19:08 +00:00
John Blackbourn ffe8f1cba4 Build/Test Tools: Standardise the name, signature, and usage of the `wpSetUpBeforeClass()` method that's used in test classes. 
This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its `$factory` parameter.

See #51344

Built from https://develop.svn.wordpress.org/trunk@49603


git-svn-id: http://core.svn.wordpress.org/trunk@49341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-15 14:01:06 +00:00
Sergey Biryukov b618452411 Twenty Nineteen: Remove unnecessary references to some variables in `twentynineteen_hsl_hex()` before they are defined. 
Props ankitmaru, sabernhardt.
Fixes #49052.
Built from https://develop.svn.wordpress.org/trunk@49602


git-svn-id: http://core.svn.wordpress.org/trunk@49340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-15 12:16:09 +00:00
John Blackbourn 1daf22cae6 Build/Test Tools: Improve the reliability of the test that ensures correct dependency order when inline scripts are used. 
This test already ensures `WP_Scripts->do_concat` is true, therefore it has no dependency on `SCRIPT_DEBUG` being false. This means the test can run in an environment where the `.min` suffix is not used.

This change allows for the test to pass in this situation.

See #36392, #51734, #51344

Built from https://develop.svn.wordpress.org/trunk@49601


git-svn-id: http://core.svn.wordpress.org/trunk@49339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-14 17:22:05 +00:00
John Blackbourn 48f35e42fc Docs: For clarity, add some information about the return types of `get_option()`. 
Props ReneHermi, johannadevos

See #51278

Built from https://develop.svn.wordpress.org/trunk@49600


git-svn-id: http://core.svn.wordpress.org/trunk@49338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-14 17:02:05 +00:00
Sergey Biryukov df2644a14a Docs: Add missing descriptions for `_WP_List_Table_Compat` methods. 
Props johannadevos, SaeedFard, swissspidy, desrosj, SergeyBiryukov.
Fixes #46842.
Built from https://develop.svn.wordpress.org/trunk@49599


git-svn-id: http://core.svn.wordpress.org/trunk@49337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-14 16:54:08 +00:00
John Blackbourn 429079a9b2 Docs: Revert an accidental revert of this package name. 
See #51414, #50768

Built from https://develop.svn.wordpress.org/trunk@49598


git-svn-id: http://core.svn.wordpress.org/trunk@49336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-14 16:40:07 +00:00
John Blackbourn 170ca32007 Docs: Various docblock corrections and improvements. 
See #50768

Built from https://develop.svn.wordpress.org/trunk@49597


git-svn-id: http://core.svn.wordpress.org/trunk@49335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-14 16:35:06 +00:00
Sergey Biryukov 185607c417 Docs: Add missing descriptions for `Automatic_Upgrader_Skin` methods. 
Props johannadevos, dilipbheda.
Fixes #44546.
Built from https://develop.svn.wordpress.org/trunk@49596


git-svn-id: http://core.svn.wordpress.org/trunk@49334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-14 16:23:10 +00:00
Sergey Biryukov ec051cfb3e Docs: Clarify that `get_pages()` returns an array of pages, not an HTML list. 
Props ben.meredith@gmail.com, ovenall, johannadevos.
Fixes #39049. See #51768.
Built from https://develop.svn.wordpress.org/trunk@49595


git-svn-id: http://core.svn.wordpress.org/trunk@49333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-14 15:01:13 +00:00
John Blackbourn 1260493569 Docs: Correct the Chocolatey package name for Node in the local environment setup instructions. 
Props pbearne

See #51414

Built from https://develop.svn.wordpress.org/trunk@49594


git-svn-id: http://core.svn.wordpress.org/trunk@49332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-14 10:17:08 +00:00
Andrew Ozz d817ad9b55 Upgrade/Install: Ensure the current user can update core when saving the auto-update options. 
See #51742.
Built from https://develop.svn.wordpress.org/trunk@49593


git-svn-id: http://core.svn.wordpress.org/trunk@49331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-13 16:57:13 +00:00
Sergey Biryukov 0bc22bb1fc Upgrade/Install: Account for the `automatic_updater_disabled` filter in core auto-update settings UI. 
Follow-up to [49587].

Props markparnell, audrasjb.
See #51742.
Built from https://develop.svn.wordpress.org/trunk@49592


git-svn-id: http://core.svn.wordpress.org/trunk@49330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-13 11:14:08 +00:00
Sergey Biryukov d6a597efe2 I18N: Remove HTML tags from translatable strings on WordPress Updates screen. 
Follow-up to [49587].

Props fierevere.
See #51742.
Built from https://develop.svn.wordpress.org/trunk@49591


git-svn-id: http://core.svn.wordpress.org/trunk@49329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-13 10:50:08 +00:00
Helen Hou-Sandí 845371edab Post-WordPress 5.6 Beta 4 bump. 
Built from https://develop.svn.wordpress.org/trunk@49590


git-svn-id: http://core.svn.wordpress.org/trunk@49328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 23:45:10 +00:00
Helen Hou-Sandí 81659521ad WordPress 5.6 Beta 4, for real. 
Built from https://develop.svn.wordpress.org/trunk@49589


git-svn-id: http://core.svn.wordpress.org/trunk@49327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 23:08:08 +00:00
Helen Hou-Sandí 16feb07916 WordPress 5.6 Beta 4. 
Built from https://develop.svn.wordpress.org/trunk@49588


git-svn-id: http://core.svn.wordpress.org/trunk@49326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 23:02:09 +00:00
Helen Hou-Sandí 582ca50733 Upgrade/Install: Better UI for auto-update settings on update screen. 
This adds clearer messages about what your current settings mean for updates, uses a more compact link-based action instead of a checkbox to change the setting, and respects constants and filters.

Props audrasjb, karmatosed, helen, azaozz, hedgefield, marybaum.
Fixes #51742.

Built from https://develop.svn.wordpress.org/trunk@49587


git-svn-id: http://core.svn.wordpress.org/trunk@49325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 22:37:10 +00:00
Sergey Biryukov c5257328b7 Customize: Exclude widget ID attributes from search. 
Having search terms match the ID attributes leads to confusing results, specifically when the admin interface is set to a language other than English.

Follow-up to [27650].

Props afercia, dlh, noisysocks.
Fixes #46456.
Built from https://develop.svn.wordpress.org/trunk@49586


git-svn-id: http://core.svn.wordpress.org/trunk@49324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 22:05:09 +00:00
Sergey Biryukov 7baab642c1 Bundled Themes: Add `block-patterns` tag to Twenty Nineteen and Twenty Twenty. 
Follow-up to [49347], [49348].

See #51098, #51099.
Built from https://develop.svn.wordpress.org/trunk@49585


git-svn-id: http://core.svn.wordpress.org/trunk@49323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 21:56:12 +00:00
Sergey Biryukov 87fbad7286 Bundled Themes: Introduce block patterns for Twenty Seventeen. 
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena.
Fixes #51100.
Built from https://develop.svn.wordpress.org/trunk@49584


git-svn-id: http://core.svn.wordpress.org/trunk@49322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 21:22:12 +00:00
Sergey Biryukov b6f30e3009 Bundled Themes: Introduce block patterns for Twenty Sixteen. 
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena, jffng.
Fixes #51101.
Built from https://develop.svn.wordpress.org/trunk@49583


git-svn-id: http://core.svn.wordpress.org/trunk@49321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 21:14:12 +00:00
Sergey Biryukov f2364f163b Administration: Make sure auto-update counts properly update when bulk deleting plugins or themes. 
Props pbiron, noisysocks, desrosj, audrasjb, hellofromTonya.
Fixes #50870.
Built from https://develop.svn.wordpress.org/trunk@49582


git-svn-id: http://core.svn.wordpress.org/trunk@49320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 20:42:10 +00:00
Helen Hou-Sandí d5fd3bd452 Upgrade/Install: Enable all core autoupdates for new installs. 
Likely needs more work for multisite installs.

Reference: https://make.wordpress.org/core/2020/11/10/wp5-6-auto-update-implementation-change/

Props audrasjb, azaozz.
See #51743.

Built from https://develop.svn.wordpress.org/trunk@49581


git-svn-id: http://core.svn.wordpress.org/trunk@49319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 20:22:09 +00:00
John Blackbourn 9115246f72 General: Convert `wp_array_get()` to a "private" function and add tests. 
This function may be promoted in the future if it's deemed useful enough.

Props dd32, jorgefilipecosta, Hareesh Pillai

Fixes #51720

Built from https://develop.svn.wordpress.org/trunk@49580


git-svn-id: http://core.svn.wordpress.org/trunk@49318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 20:20:12 +00:00
Sergey Biryukov 1d738052b1 Editor: Update packages. 
The following package versions were changed:

@wordpress/block-directory: 1.17.2 -> 1.17.3
@wordpress/block-editor: 5.1.2 -> 5.1.3
@wordpress/block-library: 2.26.2 -> 2.26.3
@wordpress/edit-post: 3.25.2 -> 3.25.3
@wordpress/editor: 9.24.2 -> 9.24.3
@wordpress/format-library: 1.25.2 -> 1.25.3
@wordpress/reusable-blocks: 1.0.2 -> 1.0.3

See https://github.com/WordPress/gutenberg/pull/26874 for the list of fixed bugs.

Props isabel_brison.
Fixes #51696.
Built from https://develop.svn.wordpress.org/trunk@49579


git-svn-id: http://core.svn.wordpress.org/trunk@49317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 19:36:36 +00:00
desrosj 6703f8efee Twenty Twenty-One: Use consistent casing in strings. 
This converts strings using Title Case to sentence case, which is currently preferred for consistency (see discussions on #40244).

Also included is the replacement of an escaped apostrophe with `&#8217;`, which is also preferred per the Internationalization guidelines.

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49578


git-svn-id: http://core.svn.wordpress.org/trunk@49316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 19:30:11 +00:00
desrosj 5de5b186f3 Twenty Twenty-One: Ignore the `node_modules` folder in SVN. 
[49576] mistakenly partially reverted [49250].

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49577


git-svn-id: http://core.svn.wordpress.org/trunk@49315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 19:07:10 +00:00
desrosj d23292b3c0 Twenty Twenty-One: Ignore `.css.map` files. 
These are generated when Sass is compiled, but should never be committed.

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49576


git-svn-id: http://core.svn.wordpress.org/trunk@49314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 19:00:10 +00:00
desrosj ee888ad547 Twenty Twenty-One: Convert inline ESLint comments to JSHint. 
WordPress Core currently uses JSHint instead of ESlint.

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49575


git-svn-id: http://core.svn.wordpress.org/trunk@49313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 18:48:08 +00:00
desrosj 967d29d83d Twenty Twenty-One: Merge the latest changes changes from GitHub for Beta 4. 
In addition to syncing the latest changes, this change also merges the theme’s `.scss` files and other related build tool configurations required to compile the theme’s CSS.

This will allow development of the theme to continue on Trac after 5.6 is released and the GitHub repository is archived.

For a full list of changes since [], see e7d5991...aa284fd.

Props poena, luminuu kjellr, aristath, justinahinon.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49574


git-svn-id: http://core.svn.wordpress.org/trunk@49312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 18:36:15 +00:00
TimothyBlynJacobs 5ee48d6915 App Passwords: MOAR accessibility improvements. 
Corrects the "Application Name" field's aria-describedby attribute and makes the description visible.

Props alexstine, SergeyBiryukov.
Fixes #51580.

Built from https://develop.svn.wordpress.org/trunk@49573


git-svn-id: http://core.svn.wordpress.org/trunk@49311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 18:14:08 +00:00
Sergey Biryukov d772517fcc Database: Clean up the `post_category` column removed from DB schema for new installations in WordPress 2.8. 
Its presence may conflict with `WP_Post::__get()`, which should generally fill the non-existent `post_category` property, but is not triggered if the column exists in the database.

Follow-up to [10895].

Props leogermani, davidbaumwald, hellofromTonya.
Fixes #51288.
Built from https://develop.svn.wordpress.org/trunk@49572


git-svn-id: http://core.svn.wordpress.org/trunk@49310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 17:55:11 +00:00
Sergey Biryukov 250d0660b2 Build/Test Tools: Only enforce PHP extension requirements when running core tests. 
This allows other users of the WordPress unit test suite framework to run their own unit tests without needing the GD extension, which should only be a requirement if running core tests.

Follow-up to [49535].

Props jamescollins.
Fixes #50640.
Built from https://develop.svn.wordpress.org/trunk@49571


git-svn-id: http://core.svn.wordpress.org/trunk@49309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 17:25:13 +00:00
Sergey Biryukov 8e58e38ef9 Build/Tests Tools: Restore [49491], accidentally reverted in [49566]. 
See #39210.
Built from https://develop.svn.wordpress.org/trunk@49570


git-svn-id: http://core.svn.wordpress.org/trunk@49308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 17:15:08 +00:00
Sergey Biryukov 6ac50d705c Build/Tests Tools: Restore [49535], accidentally reverted in [49566]. 
See #39210.
Built from https://develop.svn.wordpress.org/trunk@49569


git-svn-id: http://core.svn.wordpress.org/trunk@49307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 17:08:11 +00:00
antpb 522a7a5d40 Media: Allow users to switch from media grid to list mode in media library. 
Fixes issue where media modal would open when switching from grid to list mode.

Props mista-flo, mukesh27.

Fixes #51396.

Built from https://develop.svn.wordpress.org/trunk@49568


git-svn-id: http://core.svn.wordpress.org/trunk@49306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 15:46:07 +00:00
antpb 8efbef867c Media: Improve count in Media Library pagination. 
Deleting all visible items on the last page of the media library previously left a blank page with no media items available. Using `wp_count_attachements` instead of `found_posts` solves the problem.

Props donsony, karmatosed, desrosj, mista-flo, justinahinon.

Fixes #39968.

Built from https://develop.svn.wordpress.org/trunk@49567


git-svn-id: http://core.svn.wordpress.org/trunk@49305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 15:40:09 +00:00
Dominik Schilling abc9d961d5 I18N: Revert [49236] for now to investigate alternative implementations. 
See #39210, #51678, #26511.
Built from https://develop.svn.wordpress.org/trunk@49566


git-svn-id: http://core.svn.wordpress.org/trunk@49304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 14:43:09 +00:00
Sergey Biryukov 4446e597a7 Feeds: Register transient feed cache handler using the recommended method for SimplePie 1.3 or later. 
This fixes a "Non-static method cannot be called statically" fatal error when calling `fetch_feed()` on PHP 8.

Follow-up to [21644], [21652], [22366], [22599].

Props dd32, afragen, Senning, markoheijnen, ComputerGuru, useStrict, Ipstenu, nacin, l3rady, HoaSi, NathanAtmoz, fabifott, jfoulquier, thefarlilacfield, subscriptiongroup, rogerlos, Mte90, mopsyd, dossy, stulab, MadtownLems, roikles, justlevine, joostdevalk, OptimizingMatters, hellofromTonya, bph, ayeshrajans, SergeyBiryukov.
Fixes #29204.
Built from https://develop.svn.wordpress.org/trunk@49565


git-svn-id: http://core.svn.wordpress.org/trunk@49303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 14:36:10 +00:00
Sergey Biryukov 9c6f41419c Coding Standards: Pass an empty string instead of `null` as the `$replacement` parameter to `_deprecated_file()`. 
Follow-up to [48327].

See #50767.
Built from https://develop.svn.wordpress.org/trunk@49564


git-svn-id: http://core.svn.wordpress.org/trunk@49302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 11:17:07 +00:00
Peter Wilson 5da8c0fceb Canonical: Prevent ID enumeration of private post slugs. 
Add check to `redirect_canonical()` to ensure the destination post is not using a private post status.

Props dd32, Denis-de-Bernardy, donmhico, helen, nacin, peterwilsoncc, pishmishy, TimothyBlynJacobs, tzafrir, Viper007Bond, whyisjake.
Fixes #5272.


Built from https://develop.svn.wordpress.org/trunk@49563


git-svn-id: http://core.svn.wordpress.org/trunk@49301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 04:16:08 +00:00
Sergey Biryukov 3a1265e188 I18N: Add trailing punctuation to some translator comments. 
Follow-up to [49549].

See #51580.
Built from https://develop.svn.wordpress.org/trunk@49562


git-svn-id: http://core.svn.wordpress.org/trunk@49300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-11 10:41:07 +00:00
Sergey Biryukov 9db9343826 Docs: Clarify `sprintf()` usage for the `before_widget` argument of `register_sidebar()`. 
Follow-up to [49203], [49560].

See #19709.
Built from https://develop.svn.wordpress.org/trunk@49561


git-svn-id: http://core.svn.wordpress.org/trunk@49299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-11 10:39:09 +00:00
Helen Hou-Sandí 19b035f04b Widgets: Do not use wrapping container in the admin. 
This is due to the new `before|after_sidebar` args, which are empty by default, but can introduce markup that causes admin JS to stop working.

Also adds documentation for the `sprintf()` on `before_sidebar`.

Props audrasjb, lpointet.
See #19709.

Built from https://develop.svn.wordpress.org/trunk@49560


git-svn-id: http://core.svn.wordpress.org/trunk@49298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 20:40:09 +00:00
Helen Hou-Sandí 135c75c396 Editor: Display short description from block directory in results. 
Props dd32, ryelle.
Fixes #51212.

Built from https://develop.svn.wordpress.org/trunk@49559


git-svn-id: http://core.svn.wordpress.org/trunk@49297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 20:26:08 +00:00
Sergey Biryukov 1f984603a2 Help/About: Add Site Health Status dashboard widget to the Help → Content tab. 
Reorder the items in the help tab to align with their default position on the Dashboard screen.

Follow-up to [47063], [47300].

Props nlpro.
Fixes #51745.
Built from https://develop.svn.wordpress.org/trunk@49558


git-svn-id: http://core.svn.wordpress.org/trunk@49296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 19:05:10 +00:00
Sergey Biryukov e503ee45d6 TinyMCE: Update to 4.9.11. 
Changelog:
https://www.tiny.cloud/docs-4x/changelog/#version4911july132020
https://github.com/tinymce/tinymce/blob/4.x/changelog.txt

A full list of changes in this update can be found on GitHub:
https://github.com/tinymce/tinymce/compare/4.9.10...4.9.11

See #51051.
Built from https://develop.svn.wordpress.org/trunk@49557


git-svn-id: http://core.svn.wordpress.org/trunk@49295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 10:44:08 +00:00
Andrew Ozz 16458d8fd2 Tests QUnit: Remove restriction on running the TinyMCE Textpattern WP plugin tests in PhantomJS. 
Props @desrosj.
Fixes #42009.
Built from https://develop.svn.wordpress.org/trunk@49556


git-svn-id: http://core.svn.wordpress.org/trunk@49294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 09:18:10 +00:00
antpb 64beb3ee49 Media: Removes duplicate alignment fix for browser uploader. 
See #41648

Built from https://develop.svn.wordpress.org/trunk@49555


git-svn-id: http://core.svn.wordpress.org/trunk@49293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 23:43:07 +00:00
desrosj 964c353504 Tests: Remove duplicate `fields` key in `WP_Query` test. 
Introduced in [46188].

See #51344.
Built from https://develop.svn.wordpress.org/trunk@49554


git-svn-id: http://core.svn.wordpress.org/trunk@49292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 23:41:06 +00:00
antpb 4f2e88a574 Media: Adjusts alignment of file name text in browser uploader. 
Sets a defined size for text alongside the media browser uploader button fixing alignment on popular browsers.

Props krupajnanda, mikeschroder, aaroncampbell, lucagrandicelli, andraganescu, samful, sabernhardt, andystitt829, kburgoine.
Fixes #41648

Built from https://develop.svn.wordpress.org/trunk@49553


git-svn-id: http://core.svn.wordpress.org/trunk@49291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 23:34:09 +00:00
Helen Hou-Sandí c57ce00691 Feeds: Don't treat media URLs with fragments as unique for enclosures. 
Props archduck, dshanske.
Fixes #47421.

Built from https://develop.svn.wordpress.org/trunk@49552


git-svn-id: http://core.svn.wordpress.org/trunk@49290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 20:28:07 +00:00
desrosj 8562263fd6 Build/Test Tools: Remove PHP >= 5.3 check. 
WordPress no longer supports PHP < 5.6.20. This check is no longer necessary.

Fixes #51737.
Built from https://develop.svn.wordpress.org/trunk@49551


git-svn-id: http://core.svn.wordpress.org/trunk@49289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 19:42:06 +00:00
antpb 9901c9a48d Media: Adjust box-sizing for audio players. 
Fix cropped container around playhead time in audio player.

Props ravipatel, sabernhardt, audrasjb, SergeyBiryukov, 
Fixes #51685

Built from https://develop.svn.wordpress.org/trunk@49550


git-svn-id: http://core.svn.wordpress.org/trunk@49288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 19:34:08 +00:00
TimothyBlynJacobs 74969e7fbe App Passwords: Further accessibility improvements. 
- Add a label to the readonly password input.
- Handle focus loss after revoking app passwords.
- Handle focus loss after dismissing notices.
- Mark app name as `aria-required`.
- Use `aria-label` for detailed revoke button text instead of `title`.
- Use `-1` for `tabindex` instead of `0`.

Props alexstine, afercia, sabernhardt, audrasjb, joedolson, TimothyBlynJacobs.
Fixes #51580.

Built from https://develop.svn.wordpress.org/trunk@49549


git-svn-id: http://core.svn.wordpress.org/trunk@49287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 18:05:08 +00:00
desrosj 4040866754 Build/Test Tools: Clean up the new contributor welcome message. 
Props ocean90, jeffpaul.
See #50401.
Built from https://develop.svn.wordpress.org/trunk@49548


git-svn-id: http://core.svn.wordpress.org/trunk@49286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 17:31:08 +00:00
Sergey Biryukov 8114076a50 Tests: Use `assertSame()` in some newly introduced tests. 
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [48937], [48939], [48940], [48944].

See #38266.
Built from https://develop.svn.wordpress.org/trunk@49547


git-svn-id: http://core.svn.wordpress.org/trunk@49285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:45:08 +00:00
Sergey Biryukov 5b62b44c15 Coding Standards: Use consistent formatting for error messages in `WP_Image_Editor_Imagick::write_image()` and `::strip_meta()`. 
See #50767.
Built from https://develop.svn.wordpress.org/trunk@49546


git-svn-id: http://core.svn.wordpress.org/trunk@49284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:35:05 +00:00
Sergey Biryukov 3e3328a269 General: Set `svn:eol-style` for some new files in `phpunit/includes`. 
Follow-up to [48845], [49037], [49226], [49230].

See #51113.
Built from https://develop.svn.wordpress.org/trunk@49545


git-svn-id: http://core.svn.wordpress.org/trunk@49283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:25:08 +00:00
John Blackbourn 34765ddb64 Docs: Docblock corrections relating to `WP_Post` objects. 
See #51373, #50768

Built from https://develop.svn.wordpress.org/trunk@49544


git-svn-id: http://core.svn.wordpress.org/trunk@49282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:15:08 +00:00
Sergey Biryukov 847a2e22a0 Tests: Remove empty `export` directory. 
Follow-up to [30518], [31253], [34328].

See #51344.
Built from https://develop.svn.wordpress.org/trunk@49543


git-svn-id: http://core.svn.wordpress.org/trunk@49281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:11:08 +00:00
John Blackbourn 3688a9394e Media: Restore the ability of `WP_Image_Editor_Imagick->save()` to create a missing directory when needed. 
Props eemitch, mikeschroder, hellofromTonya, p00ya, johnbillion

Fixes #51665

Built from https://develop.svn.wordpress.org/trunk@49542


git-svn-id: http://core.svn.wordpress.org/trunk@49280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 13:18:04 +00:00
Sergey Biryukov 2d8633bf22 I18N: Merge duplicate "Column" strings, remove unnecessary context. 
Props ramiy, justinahinon, garrett-eclipse, audrasjb.
Fixes #47259.
Built from https://develop.svn.wordpress.org/trunk@49541


git-svn-id: http://core.svn.wordpress.org/trunk@49279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 11:17:07 +00:00
Sergey Biryukov 2c5607307f Coding Standards: Adjust formatting in `WP_Block::render()` for better readability. 
Follow-up to [49310], [49539].

See #51606.
Built from https://develop.svn.wordpress.org/trunk@49540


git-svn-id: http://core.svn.wordpress.org/trunk@49278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 11:01:05 +00:00
Sergey Biryukov a2d42351c5 Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings. 
Standardize on "Go to..." as a more appropriate option for most cases.

Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora.
Fixes #47235.
Built from https://develop.svn.wordpress.org/trunk@49539


git-svn-id: http://core.svn.wordpress.org/trunk@49277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 10:53:10 +00:00
Sergey Biryukov 4a18c93f42 Networks and Sites: Assign the array of site or network data returned from filters to the respective class property: 
* The array of network data returned from the `networks_pre_query` filter is assigned to the `networks` property of the current `WP_Network_Query` instance.
* The array of site data returned from the `sites_pre_query` filter is assigned to the `sites` property of the current `WP_Site_Query` instance.

This avoids the performance overhead of calling `WP_Network_Query::get_networks()` or `WP_Site_Query::get_sites()` twice: first when creating the object instance, then to retrieve the filtered results.

This also makes the filters a bit more consistent with other similar filters, e.g. `posts_pre_query`, `terms_pre_query`, `comments_pre_query`, or `users_pre_query`.

Follow-up to [46086], [48990].

Props yakimun, spacedmonkey.
Fixes #51333.
Built from https://develop.svn.wordpress.org/trunk@49538


git-svn-id: http://core.svn.wordpress.org/trunk@49276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-08 11:47:06 +00:00
Sergey Biryukov 5683c46277 Site Health: Validate the test result data format in JS before using it. 
This will discard any invalid responses instead of causing fatal errors.

It also makes badges optional, on the same basis as actions are optional. They are expected, but there may be situations where they are not present.

Props Clorith, dogwithblog, kraftbj, whyisjake, SergeyBiryukov.
Fixes #50145.
Built from https://develop.svn.wordpress.org/trunk@49537


git-svn-id: http://core.svn.wordpress.org/trunk@49275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-08 09:52:10 +00:00
Sergey Biryukov c66edd0439 REST API: Use `_n()` in some error messages for proper plural forms support. 
Follow-up to [47923], [49053].

Props audrasjb, tobifjellner, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51727.
Built from https://develop.svn.wordpress.org/trunk@49536


git-svn-id: http://core.svn.wordpress.org/trunk@49274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-07 21:59:11 +00:00
Sergey Biryukov ec9b010cea Build/Test Tools: Check if all the required PHP extensions are loaded before running the test suite. 
Add the GD extension as a hard requirement.

This improves the reliability of the test suite and ensures that if the test infrastructure changes in the future and a platform requirement such as GD accidentally gets removed, the tests fail with an appropriate error message.

Follow-up to [48592].

Props ayeshrajans, jrf, johnbillion.
Fixes #50640.
Built from https://develop.svn.wordpress.org/trunk@49535


git-svn-id: http://core.svn.wordpress.org/trunk@49273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-07 13:20:07 +00:00
TimothyBlynJacobs 2559fb2a8d App Passwords: Bump database version to flush rewrite rules. 
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems. This bumps the database version so the change is applied to sites upon upgrading to 5.6.

Fixes #51723.

Built from https://develop.svn.wordpress.org/trunk@49534


git-svn-id: http://core.svn.wordpress.org/trunk@49272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 22:15:09 +00:00
Sergey Biryukov af95efdd34 Docs: Add a `@see` reference to `esc_url()` from `esc_url_raw()`. 
Follow-up to [49512].

See #50585.
Built from https://develop.svn.wordpress.org/trunk@49513


git-svn-id: http://core.svn.wordpress.org/trunk@49268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 14:16:07 +00:00
Sergey Biryukov 6dd28116a1 Docs: Improve return value description for `esc_url()`. 
Add a reference to `esc_url()` from `esc_url_raw()` return value description.

Props stevenlinx, audrasjb, helen.
Fixes #50585.
Built from https://develop.svn.wordpress.org/trunk@49512


git-svn-id: http://core.svn.wordpress.org/trunk@49267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 14:03:06 +00:00
Sergey Biryukov 3f7d705cfe Bundled Themes: Correct list block alignment in editor styles. 
Additionally:
* Indent nested lists in list and category blocks.
* Match ordered and unordered indentation for the classic block's lists.

This applies to:
* Twenty Ten
* Twenty Eleven
* Twenty Thirteen
* Twenty Fourteen
* Twenty Fifteen
* Twenty Sixteen
* Twenty Seventeen

Props sabernhardt, amolv, kjellr, audrasjb, francina.
Fixes #51157.
Built from https://develop.svn.wordpress.org/trunk@49511


git-svn-id: http://core.svn.wordpress.org/trunk@49266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 11:53:05 +00:00
Sergey Biryukov a3faece50b Twenty Twenty: Correctly indent nested unordered lists in RTL editor styles. 
Props sabernhardt.
Fixes #51574.
Built from https://develop.svn.wordpress.org/trunk@49510


git-svn-id: http://core.svn.wordpress.org/trunk@49265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 11:38:09 +00:00
Sergey Biryukov 42b6ece059 Docs: Fix typo in a comment in `Walker::display_element()`. 
Props david.binda, sabernhardt.
Fixes #51713.
Built from https://develop.svn.wordpress.org/trunk@49509


git-svn-id: http://core.svn.wordpress.org/trunk@49264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 18:46:10 +00:00
Sergey Biryukov 3426581eaa Twenty Thirteen: Correct alignment of blocks inside a `full-width` or `wide-width` group block. 
Props sabernhardt.
Fixes #51440.
Built from https://develop.svn.wordpress.org/trunk@49508


git-svn-id: http://core.svn.wordpress.org/trunk@49263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 15:05:07 +00:00
Sergey Biryukov eb6b93f327 Twenty Twenty: Correct heading blocks alignment in editor styles. 
This explicitly sets top and bottom margins instead of defining all four sides in shorthand notation.

Props sabernhardt, Lumne.
Fixes #51148.
Built from https://develop.svn.wordpress.org/trunk@49507


git-svn-id: http://core.svn.wordpress.org/trunk@49262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 15:02:10 +00:00
Sergey Biryukov ee7ff18b54 Docs: Improve documentation for `WP_Query::is_archive()` per the documentation standards. 
Follow-up to [49504].

See #50545.
Built from https://develop.svn.wordpress.org/trunk@49506


git-svn-id: http://core.svn.wordpress.org/trunk@49261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 09:44:05 +00:00
Sergey Biryukov f22633f20b Docs: Consistently place `@see` tags after `@since` in `WP_Query` methods, per the documentation standards. 
See #50768.
Built from https://develop.svn.wordpress.org/trunk@49505


git-svn-id: http://core.svn.wordpress.org/trunk@49260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 09:42:10 +00:00
Helen Hou-Sandí 1a2bdd7491 Improve documentation for `is_archive()`. 
Props stevenlinx.
Fixes #50545.

Built from https://develop.svn.wordpress.org/trunk@49504


git-svn-id: http://core.svn.wordpress.org/trunk@49259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 17:03:09 +00:00
Sergey Biryukov 87cdca8cd6 Docs: Change the `@since` entry for `template` and `template_lock` post type arguments to `5.0.0`. 
These arguments were introduced with the initial block editor, but not documented previously.

Follow-up to [49495].

Props TimothyBlynJacobs.
See #46261.
Built from https://develop.svn.wordpress.org/trunk@49496


git-svn-id: http://core.svn.wordpress.org/trunk@49255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 02:47:05 +00:00
Sergey Biryukov 096323d8a5 Docs: Add documentation for the `template_lock` argument to `register_post_type()`. 
Add a `@since` entry for `template` and `template_lock` arguments.

Follow-up to [49041], [49492], [49494].

See #46261.
Built from https://develop.svn.wordpress.org/trunk@49495


git-svn-id: http://core.svn.wordpress.org/trunk@49254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 02:32:08 +00:00
Sergey Biryukov ec60115f2a Docs: Adjust documentation for some `WP_Post_Type` properties: 
* Split the summary for `$template` per the documentation standards. The summary should be a single sentence.
* Change the type for `$template_lock` to `string|false`, to clarify that `true` is not supported.
* Fix typo in `$delete_with_user` description, adjust for better readability.

Follow-up to [49041], [49492].

See #46261.
Built from https://develop.svn.wordpress.org/trunk@49494


git-svn-id: http://core.svn.wordpress.org/trunk@49253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 02:30:09 +00:00
Sergey Biryukov 618fb979c6 Docs: Add a reference to `wp_insert_post()` for information on the arguments accepted by `wp_update_post()`. 
See #50768.
Built from https://develop.svn.wordpress.org/trunk@49493


git-svn-id: http://core.svn.wordpress.org/trunk@49252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 01:39:06 +00:00
noisysocks 4be65decb7 Editor: Add explicit template and template_lock attributes 
Add and document the template and template_lock attributes on WP_Post_Type that
are used by the block editor.

Props metalandcoffee.
See #46261.

Built from https://develop.svn.wordpress.org/trunk@49492


git-svn-id: http://core.svn.wordpress.org/trunk@49251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 01:05:10 +00:00
desrosj 107f669f15 Build/Test Tools: Disable update attempts while running unit tests. 
This fixes an issue introduced in [49369] that causes l10n related tests to fail when the PHPUnit test suite is run multiple times without hints of the site being under version control.

[49369] removed the `.git` folder from the ZIP artifact created during the initial setup job. This ZIP file is used by the later jobs in the workflow that run the test suite. The absence of the `.git` folder in these later jobs caused the language packs initially loaded from `phpunit/data/languages` folder to be updated asynchronously, resulting in unexpected values when running the tests a second time.

This change disables all Core auto-update and asynchronous language pack update attempts when running PHPUnit tests.

Props ocean90, SergeyBiryukov.
See #50401.
Fixes #51670.
Built from https://develop.svn.wordpress.org/trunk@49491


git-svn-id: http://core.svn.wordpress.org/trunk@49250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 21:09:08 +00:00
desrosj 5392af9208 Upgrade/Install: Change the notice displayed after saving auto-update settings to `.notice-success`. 
This better conveys the message of the notice and brings consistency with other success notices throughout Core.

Props audrasjb.
Fixes #51701.
Built from https://develop.svn.wordpress.org/trunk@49490


git-svn-id: http://core.svn.wordpress.org/trunk@49249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 17:55:06 +00:00
John Blackbourn 3cee52b362 Docs: Add more information about how to use filters that run before WordPress initialises. 
Fixes #50134

Built from https://develop.svn.wordpress.org/trunk@49489


git-svn-id: http://core.svn.wordpress.org/trunk@49248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 17:36:09 +00:00
John Blackbourn 238e69d9a6 Tests: Remove some useless assertions from the image editor tests. 
In each of these instances the variable being tested is a directly instantiated object and can never be a `WP_Error`, unlike when `wp_get_image_editor()` is used.

See #51344

Built from https://develop.svn.wordpress.org/trunk@49488


git-svn-id: http://core.svn.wordpress.org/trunk@49247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 15:52:11 +00:00
Sergey Biryukov a940c08357 Docs: Document the `$linkdata` parameter of `wp_insert_link()` using hash notation. 
Props stevenlinx, peterwilsoncc.
Fixes #50853.
Built from https://develop.svn.wordpress.org/trunk@49487


git-svn-id: http://core.svn.wordpress.org/trunk@49246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 03:52:10 +00:00
Helen Hou-Sandí 3b64a19eeb Post-WordPress 5.6 Beta 3 version bump. 
Built from https://develop.svn.wordpress.org/trunk@49486


git-svn-id: http://core.svn.wordpress.org/trunk@49245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 21:22:04 +00:00
Helen Hou-Sandí 2f6286db83 WordPress 5.6 Beta 3. 
Built from https://develop.svn.wordpress.org/trunk@49485


git-svn-id: http://core.svn.wordpress.org/trunk@49244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:59:07 +00:00
Sergey Biryukov 1543954adc Docs: Update description for the `$context` parameter of `sanitize_title()` and `sanitize_title_with_dashes()`. 
This brings some consistency between the two DocBlocks and adjusts the latter one per the documentation standards.

Follow-up to [49482].

See #50569.
Built from https://develop.svn.wordpress.org/trunk@49484


git-svn-id: http://core.svn.wordpress.org/trunk@49243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:20:07 +00:00
Helen Hou-Sandí a3581edd84 Upgrade/Install: Update help tab text to include major WordPress updates. 
Props audrasjb.
Fixes #51653.

Built from https://develop.svn.wordpress.org/trunk@49483


git-svn-id: http://core.svn.wordpress.org/trunk@49242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:16:06 +00:00
Helen Hou-Sandí f2875b6f7c Formatting: Update docs for `$context` in `sanitize_title_with_dashes()`. 
Props stevenlinx, audrasjb.
Fixes #50569.

Built from https://develop.svn.wordpress.org/trunk@49482


git-svn-id: http://core.svn.wordpress.org/trunk@49241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:12:06 +00:00
desrosj 6a39c891b2 Customize: Ensure menu items expand horizontally on large screens. 
Props clorith, garrett-eclipse.
Fixes #51647.
Built from https://develop.svn.wordpress.org/trunk@49481


git-svn-id: http://core.svn.wordpress.org/trunk@49240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:07:05 +00:00
Helen Hou-Sandí da4b76c6b3 Site Health: Site errors are for *this* site, not necessarily *your* site. 
Props techboyg5, Clorith, audrasjb.
Fixes #51524.

Built from https://develop.svn.wordpress.org/trunk@49480


git-svn-id: http://core.svn.wordpress.org/trunk@49239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:55:07 +00:00
Helen Hou-Sandí be95ec2c27 About: Optimize freedoms sprite and add 2 column layout. 
Props garrett-eclipse, ryelle.
Fixes #46363.

Built from https://develop.svn.wordpress.org/trunk@49479


git-svn-id: http://core.svn.wordpress.org/trunk@49238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:46:14 +00:00
desrosj e0669ddaae Bundled Themes: Sync Twenty Twenty-One with the latest changes from GitHub. 
For a full list of changes since [49330], see 5759e96...e7d5991.

Props poena, luminuu, ryelle, kjellr, aristath, justinahinon, felipeelia, joostdevalk.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49478


git-svn-id: http://core.svn.wordpress.org/trunk@49237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:45:07 +00:00
desrosj e3a467a55a Upgrade/Install: Prevent removal of additional data from plugin update info. 
This switches to using `wp_parse_args()` instead of a combination of `array_merge()` and `array_intersect_key()` when ensuring that all expected default keys are present in the update information for a plugin.

This prevents non-default data returned by 3rd-party plugins from being unintentionally stripped out.

Props peterwilsoncc, chriscct7.
Fixes #51609.
Built from https://develop.svn.wordpress.org/trunk@49477


git-svn-id: http://core.svn.wordpress.org/trunk@49236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:13:07 +00:00
Helen Hou-Sandí 409bd27659 Remove accidentally duplicated code introduced in [49475]. 
See #46536.

Built from https://develop.svn.wordpress.org/trunk@49476


git-svn-id: http://core.svn.wordpress.org/trunk@49235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:09:09 +00:00
Helen Hou-Sandí 340c834fa3 Privacy: More precise checking of user request action names. 
Props garrett-eclipse.
Fixes #46536.

Built from https://develop.svn.wordpress.org/trunk@49475


git-svn-id: http://core.svn.wordpress.org/trunk@49234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 18:42:04 +00:00
Helen Hou-Sandí cc74786052 General: Make some inline comments more descriptive. 
Props jorbin.
Fixes #51683.

Built from https://develop.svn.wordpress.org/trunk@49474


git-svn-id: http://core.svn.wordpress.org/trunk@49233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 18:04:07 +00:00
noisysocks cfa1fb8c83 Editor: Update packages 
@wordpress/block-directory@1.17.2
@wordpress/block-editor@5.1.2
@wordpress/block-library@2.26.2
@wordpress/edit-post@3.25.2
@wordpress/editor@9.24.2
@wordpress/format-library@1.25.2
@wordpress/reusable-blocks@1.0.2

Props isabel_brison.
See #51696.

Built from https://develop.svn.wordpress.org/trunk@49473


git-svn-id: http://core.svn.wordpress.org/trunk@49232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 04:56:37 +00:00
Sergey Biryukov f39fc10544 Docs: Use a consistent plural form of "status". 
Props Collizo4sky, Presskopp, davidbaumwald.
Fixes #51690.
Built from https://develop.svn.wordpress.org/trunk@49472


git-svn-id: http://core.svn.wordpress.org/trunk@49231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 01:38:07 +00:00
Sergey Biryukov 89ce61835d Upgrade/Install: Switch "Check again" link on WordPress Updates screen to sentence case. 
This brings some consistency with other text links on the screen, e.g. "View version details" for plugins or themes.

Follow-up to [49150].

Props afercia.
See #51523.
Built from https://develop.svn.wordpress.org/trunk@49471


git-svn-id: http://core.svn.wordpress.org/trunk@49230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 01:17:09 +00:00
Sergey Biryukov 7941c32ad3 Twenty Sixteen: Ensure the `<nav>` elements in widgets do not affect bottom margin. 
Follow-up to [49208].

Props sabernhardt.
Fixes #51445.
Built from https://develop.svn.wordpress.org/trunk@49470


git-svn-id: http://core.svn.wordpress.org/trunk@49229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-31 02:56:05 +00:00
Sergey Biryukov 4091f41a07 Twenty Fifteen: Ensure the `<nav>` elements in widgets do not affect bottom margin. 
Follow-up to [49208].

Props sabernhardt.
See #51445.
Built from https://develop.svn.wordpress.org/trunk@49469


git-svn-id: http://core.svn.wordpress.org/trunk@49228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-31 02:54:11 +00:00
whyisjake 4b91d4e523 Upgrade/Install: During the install process, add additional checking for exising tables. 
If reinstalling WordPress, there is a condition where tables would exist in the database. Ensures that when that is the case, the install process can carry along without issue.

Fixes #51676.

Props xknown, garubi, mukesh27, desrosj, johnbillion, metalandcoffee, davidbaumwald, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@49452


git-svn-id: http://core.svn.wordpress.org/trunk@49211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-30 17:52:07 +00:00
Peter Wilson c8d5bc3c50 Taxonomy: Revert Light-weight/partial term counts. 
Partial revert of [49141], [49171], [49316].

All functional changes are removed, appropriate term counting unit tests are retained.

See #40351.

Built from https://develop.svn.wordpress.org/trunk@49451


git-svn-id: http://core.svn.wordpress.org/trunk@49210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-30 04:59:08 +00:00
Sergey Biryukov 812826a231 Tests: Remove the `GLOB_BRACE` flag for `glob()` function from unit tests. 
The flag was previously used in PDF preview tests when cleaning up temporary files.

As noted in the PHP documentation, the flag is not available on some non-GNU systems, like Solaris or Alpine Linux.

Follow-up to [40130].

Props amykamala, sawanoboly.
Fixes #51661.
Built from https://develop.svn.wordpress.org/trunk@49450


git-svn-id: http://core.svn.wordpress.org/trunk@49209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-30 02:03:07 +00:00
Adam Silverstein 25918dd10b Users: Password generation - restore "Cancel" aria label after r49248. 
Restore the "Cancel" button aria label to "Cancel password change" after it was inadvertently changed in r49248.

Props SergeyBiryukov.
Fixes #42852.


Built from https://develop.svn.wordpress.org/trunk@49392


git-svn-id: http://core.svn.wordpress.org/trunk@49151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:43:06 +00:00
Adam Silverstein b8d1d01cc5 REST API: JS Client - improve collection route construction for empty parents. 
Fix an issue where the constructed path for hierarchical collections could contain a double slash ("//") when items contained empty parents, causing an error.

Props nicomollet.
Fixes #44745.

Built from https://develop.svn.wordpress.org/trunk@49390


git-svn-id: http://core.svn.wordpress.org/trunk@49149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:32:05 +00:00
desrosj 9c5173ffa6 Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page. 
Props xknown, zieladam, peterwilsoncc, whyisjake.
Merges [49379] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49388


git-svn-id: http://core.svn.wordpress.org/trunk@49147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:09:13 +00:00
desrosj 84a7bde414 Meta: Sanitize meta key before checking protection status. 
Props zieladam, peterwilsoncc, xknown, whyisjake.
Merges [49377,49381] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49387


git-svn-id: http://core.svn.wordpress.org/trunk@49146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:08:06 +00:00