Scott Taylor
2f513d3320
Fix some `hackificator` odds and ends in `wp-admin`:
...
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28500
git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Scott Taylor
41e1ecdfaf
Add access modifier (`public`) to members and methods in `WP_Filesystem_ftpsockets`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28490
git-svn-id: http://core.svn.wordpress.org/trunk@28316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:14:14 +00:00
Sergey Biryukov
cdba99d3b3
Being consistent is the gist, no single @since should have been missed.
...
see #26713 .
Built from https://develop.svn.wordpress.org/trunk@26869
git-svn-id: http://core.svn.wordpress.org/trunk@26755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-25 02:00:11 +00:00
Dion Hulse
c43600ea4b
First pass at documenting the WP_Filesystem methods. This also introduces stubs of the methods into the base class which are documented, which subclasses can override, some methods were cleaned up at the same time.
...
See #18476 See #23122 . Props kurtpayne, bananastalktome, and, DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@25560
git-svn-id: http://core.svn.wordpress.org/trunk@25478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-22 04:44:10 +00:00
Dion Hulse
26ebfca466
Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237
...
Built from https://develop.svn.wordpress.org/trunk@25349
git-svn-id: http://core.svn.wordpress.org/trunk@25311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-11 08:27:10 +00:00
Dion Hulse
7a6fad844a
WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments.
...
Built from https://develop.svn.wordpress.org/trunk@25305
git-svn-id: http://core.svn.wordpress.org/trunk@25267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 02:55:09 +00:00
Dion Hulse
6d1ffc62ea
WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237
...
Built from https://develop.svn.wordpress.org/trunk@25304
git-svn-id: http://core.svn.wordpress.org/trunk@25266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 02:43:08 +00:00
Dion Hulse
db6cf37f91
WP_Filesystem: FTP Sockets: Avoid using the file_exists() / is_exists() / exists() PemFTP functionality as it's buggy on ncFTPd servers, switching to listing the file instead which is what we use for the FTP Extension transport. Fixes #14049
...
Built from https://develop.svn.wordpress.org/trunk@25274
git-svn-id: http://core.svn.wordpress.org/trunk@25240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 08:29:09 +00:00
Helen Hou-Sandí
b1f1579604
its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-20 15:55:32 +00:00
dd32
2a708450ec
WP_Filesystem: Return symlinked directory names correctly, previously the FTP extensions would return it as 'source -> dest' instead of simply 'source'. Props kurtpayne. Fixes #17846
...
git-svn-id: http://core.svn.wordpress.org/trunk@21223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-06 11:39:39 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
dd32
53062d6414
WP_Filesystem_*::mkdir() untrailingslash path consistently, don't waste time attempting to create an "empty" path. See #15575 . Props lordandrei and SergeyBiryukov for initial patches.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-13 10:43:38 +00:00
ryan
04487fc268
Constructor cleanup. Props ocean90. fixes #16768
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-29 20:05:12 +00:00
dd32
a83a2842ea
Optimisations to WP_Filesystem; Pass known information to called functions. Props aldenta (John Ford) for investigation and patch. See #10913
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-03-22 00:04:15 +00:00
nacin
30d6eb32c6
Remove redundant isset() and empty() checks.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@13770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-19 21:29:21 +00:00
dd32
65176075c0
Standardise return values in WP_Filesystem::dirlist(), ::chmod() and ::exists()
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 01:59:30 +00:00
dd32
a87c1e3ca9
Reduce code duplication, Formatting cleanups, Reduce Chmod IO calls. See #10913 for excess IO calls.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 01:31:40 +00:00
dd32
a8793e00c0
Fix recursive chmod for WP_Filesystem. Props reaperhulk for FtpExt. Fixes #11261
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 01:12:29 +00:00
dd32
41e561b941
Standardise WP_Filesystem_*::put_contents() arguments to support chmod reliably across all transports. Fixes #10889
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-14 09:23:53 +00:00
azaozz
791cebe932
Typo fixes, props dd32, fixes #11030
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-25 17:30:58 +00:00
azaozz
103ba096a7
Include 'hidden' directories in filesystem dirlist by default, props dd32, fixes #10774
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-09-15 02:21:00 +00:00
ryan
8e3808bce2
Remove trailing whitespace
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-09-14 14:03:32 +00:00
azaozz
5c21d67399
WP_Filesystem fixes and phpdoc, props hakre dd32, see #10304
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-16 08:34:53 +00:00
azaozz
ca27f326a9
Add constants for ftp connections timeouts, props dd32, see #10522
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-15 12:01:04 +00:00
ryan
1cd542a5e2
consolidate plugin/theme/core upgrade/install functions. Props DD32. see #7875
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-19 19:36:28 +00:00
ryan
ff657986ff
Revert FTP parts of [10919]. fixes #9535 see #9525
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@10930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-14 17:16:44 +00:00
ryan
31a2bbad76
WPFS cleanups. Props DD32. fixes #9525
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@10919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-13 16:11:02 +00:00
westi
121f0754c6
Autodetect binary files for FTP filesystems. Fixes #7568 props DD32.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@8990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-26 06:53:57 +00:00
westi
7f894ae416
phpdoc for wp-admin. See #7496 props santosj.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@8645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-14 06:30:38 +00:00
ryan
35b18e5034
Trailing whitespace cleanup
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@8600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-09 05:36:14 +00:00
ryan
d1d186cd35
WP_Filesystem updates from DD32. See #7059
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@8018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-30 16:14:05 +00:00
ryan
ffd63e3b33
Make WP_Filesystem work with new directory constants. Props DD32. fixes #7059
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@8009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-29 17:29:32 +00:00
ryan
6c8d35de32
Allow wp-content to exist outside of webroot. Props sambauers. see #6938
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-27 17:55:24 +00:00
ryan
c69821c5e0
FTP find_base_dir fixes from DD32. see #5586
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-21 05:15:21 +00:00
ryan
ca900d471c
Check return of tmpfile(). see #5586
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-19 20:36:23 +00:00
ryan
a4dc527de4
Basedir location fixes for ftp fs from DD32. see #6245
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-18 00:13:11 +00:00
ryan
a6180f4427
Fix var name. see #6236
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-16 18:18:35 +00:00
ryan
a66d723e9b
find_base_dir fixes from DD32. see #6245
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-16 09:50:35 +00:00
ryan
568d64e73e
FTP CWD fixes from DD32. see #6245
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-16 09:49:10 +00:00
ryan
4be6f03439
i18n fixes from nbachiyski. fixes #6226
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-14 19:56:43 +00:00
ryan
d1753e67e6
Auto update fixes from DD32. see #5586
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-11 16:37:44 +00:00
ryan
12a0f3a403
ftpsockets fix from DD32. see #5586
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-06 18:14:58 +00:00
ryan
607ef8887d
wpfs fixes from DD32. see #5586
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-06 06:06:13 +00:00
ryan
beb71f0932
wp-fs fixes from DD32. see #5586
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-04 17:10:17 +00:00
ryan
04c9051a7d
Remove trailing whites.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-02 20:17:30 +00:00
ryan
c71d96e269
Plugin updater updates. see #5586
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-01 21:20:23 +00:00
ryan
e495d173a1
Instantiate errors object for ftpsockets class.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-26 05:23:05 +00:00
ryan
5b696274a0
Set eol-style to native
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-20 00:12:48 +00:00
ryan
a39ee17da9
ftp fs tweaks. see #5586
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-11 08:46:11 +00:00
ryan
9aab2ce97a
First cut at plugin update. Props DD32 for the filesystem abstraction. see #5586
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-11 05:45:54 +00:00