162785c65f
Customize: Fix reversal of nav menu item's `type` and `object` properties for page stub added in customizer.
...
Amends [38906].
See #38164 .
Fixes #40277 .
Built from https://develop.svn.wordpress.org/trunk@40380
git-svn-id: http://core.svn.wordpress.org/trunk@40287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-05 23:29:42 +00:00
35d8daf000
Quick/Bulk Edit: Fix the Tag suggestions position on the Bulk Edit textarea.
...
Always passes the complete `position` object to the jQuery autocomplete widget.
Also checks if an autocomplete instance already exists on the Bulk Edit textarea.
Props davidbenton.
Fixes #40242 .
Built from https://develop.svn.wordpress.org/trunk@40357
git-svn-id: http://core.svn.wordpress.org/trunk@40264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-31 16:35:45 +00:00
8256ecfecb
Customize: Improve i18n for strings in hidden widget area notices.
...
Amends [40312].
Props westonruter, ocean90, swissspidy, SergeyBiryukov, michelleweber for copywriting.
See #33567 , #33052 .
Fixes #39087 .
Built from https://develop.svn.wordpress.org/trunk@40330
git-svn-id: http://core.svn.wordpress.org/trunk@40237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-24 22:03:42 +00:00
e78707aad4
Customize: Prevent client-side validation from being cleared when no corresponding server-side validation is present.
...
See #36944 .
Fixes #39770 .
Built from https://develop.svn.wordpress.org/trunk@40319
git-svn-id: http://core.svn.wordpress.org/trunk@40226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 18:12:44 +00:00
085b50b20d
Customize: Show notice in Widgets panel when there are additional widget areas not rendered in preview.
...
This extends the existing behavior which only showed a message only when there were no widget areas rendered in the preview. The number of non-rendered widget areas is indicated. Also removes needles deletion of `wp.customize.Widgets.data.l10n` property which hindered plugins.
See #33567 , #33052 .
Fixes #39087 .
Built from https://develop.svn.wordpress.org/trunk@40312
git-svn-id: http://core.svn.wordpress.org/trunk@40219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 19:03:45 +00:00
e69b9b244c
Customize: Fix failure to collapse expanded sections and panels that become deactivated.
...
Improve jsdoc for `onChangeActive` function. Restores fix from [34557] which got dropped in [38648].
Props dlh, westonruter.
See #34391 , #33509 .
Fixes #39430 .
Built from https://develop.svn.wordpress.org/trunk@40304
git-svn-id: http://core.svn.wordpress.org/trunk@40211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-19 00:04:43 +00:00
3e189479a7
List Tables: Hide 'Empty Trash' and 'Empty Spam' buttons when view is already empty.
...
Props ivantedja, Presskopp, printsachen1, Jaydeep Rami, mathieuhays, cazm.
Fixes #38341 .
Built from https://develop.svn.wordpress.org/trunk@40297
git-svn-id: http://core.svn.wordpress.org/trunk@40204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-17 16:54:42 +00:00
e9f73b06b6
Docs: Correct the description for `wp.updates.deleteTheme`.
...
Props MattyRob.
Fixes #40110 .
Built from https://develop.svn.wordpress.org/trunk@40279
git-svn-id: http://core.svn.wordpress.org/trunk@40194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-11 16:13:46 +00:00
6944c8f3a6
List Tables: After [38703], [38706], and [40118], adjust the jQuery selector to make the selection of a range of checkboxes work again.
...
Unprop afercia.
Fixes #40056 .
Built from https://develop.svn.wordpress.org/trunk@40268
git-svn-id: http://core.svn.wordpress.org/trunk@40187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-10 19:14:46 +00:00
9092fd01e1
Taxonomy: Correct the formatting of HTML entities when generating the screen reader text for tag removal.
...
Props adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@40181
git-svn-id: http://core.svn.wordpress.org/trunk@40120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-06 13:14:41 +00:00
d303e3d9ca
Plugins: After [38703], adjust the selector for checkbox selection to account for nested tables.
...
Props afercia, swissspidy, reldev.
Fixes #39739 .
Built from https://develop.svn.wordpress.org/trunk@40118
git-svn-id: http://core.svn.wordpress.org/trunk@40055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-24 23:10:44 +00:00
bc1fc91ec8
REST API: JS client - QUnit tests for custom namespace route discovery.
...
Add QUnit tests for the parsing of custom namespace routes. Add a custom schema fixture based on the `wp-js-widgets` plugin. Test that the client can parse the widget namespace in the schema and correctly construct the expected group of models and collections. Also includes a small unrelated QUnit fix to ensure nav-menu test passes when it is loaded without its tests executing as well as a small jshint fix, adding a missing semicolon since [40107].
Props jnylen0.
Fixes #39561 .
Built from https://develop.svn.wordpress.org/trunk@40109
git-svn-id: http://core.svn.wordpress.org/trunk@40046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-24 18:40:40 +00:00
33286df4c1
Themes: enable browser history support in add new theme screen.
...
Enable history support for the new theme screen, including navigating theme details and closing the details modal. Theme selection is now also bookmark-able, so linking to a URL like `/wp-admin/theme-install.php?theme=twentyseventeen` correctly opens the theme preview.
Props dd32.
Fixes #36613 .
Built from https://develop.svn.wordpress.org/trunk@40107
git-svn-id: http://core.svn.wordpress.org/trunk@40044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-24 17:48:42 +00:00
c7b217cee9
JavaScript: when starting Backbone history, stop if previously started.
...
Prevent a potential error condition if Backbone history is started by a plugin or theme before core tries to start it.
Props tfrommen.
Fixes #39612 .
Built from https://develop.svn.wordpress.org/trunk@40076
git-svn-id: http://core.svn.wordpress.org/trunk@40013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-17 22:00:42 +00:00
222ee437fe
Update/Install: Give context to "Deleted! string to allow for differentiation between theme and plugin translations.
...
Props swissspidy.
See #39747 . See #37290 .
Built from https://develop.svn.wordpress.org/trunk@40035
git-svn-id: http://core.svn.wordpress.org/trunk@39972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-31 09:59:40 +00:00
9264813949
Update/Install: Give context to some more install/update strings to allow for differentiation between theme and plugin translations.
...
Fixes #39747 . See #37290 .
Built from https://develop.svn.wordpress.org/trunk@40034
git-svn-id: http://core.svn.wordpress.org/trunk@39971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-31 09:27:41 +00:00
b076f7e4a8
Plugins: Remove trailing pipe symbol in sub navigation after updating the last plugin.
...
Props sagarprajapati.
Fixes #39655 .
Built from https://develop.svn.wordpress.org/trunk@40025
git-svn-id: http://core.svn.wordpress.org/trunk@39962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-28 17:01:46 +00:00
a6d772108d
Media: ensure JavaScript initialized when media edit screen is loaded directly.
...
Fix a JavaScript error when the media edit screen is loaded directly via a url such as `/wp-admin/post.php?post={post_id}&action=edit&image-editor`. Add a check in `imgLoaded` for `this.hold.sizer` which is set up during initialization and required for the cropping tool. Call `init` if this is undefined.
Props NoseGraze.
Fixes #38138 .
Built from https://develop.svn.wordpress.org/trunk@40020
git-svn-id: http://core.svn.wordpress.org/trunk@39957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-27 18:30:43 +00:00
b6281dbd75
Customize: Trim whitespace from nav menu item titles so that the underlying object's original title appears as input placeholder and in the control's title.
...
Whitespace is trimmed from titles in PHP when saved in any case, so this aligns the client-side behavior with what happens on the server.
Amends [38618].
See #38015 .
Fixes #39600 .
Built from https://develop.svn.wordpress.org/trunk@39994
git-svn-id: http://core.svn.wordpress.org/trunk@39931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-26 18:08:40 +00:00
8d8f5616b7
Menus: trigger an event when menu items are added or removed.
...
Fire a `menu-item-added` event after a menu item is added to the DOM. Fire a `menu-removing-item` event before a menu item is removed from the DOM. Enables hooking into and responding to menu changes.
Props welcher, adamsilverstein.
Fixes #31218 .
Built from https://develop.svn.wordpress.org/trunk@39928
git-svn-id: http://core.svn.wordpress.org/trunk@39865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 16:15:42 +00:00
85ee190163
Formatting: fix `wpautop()` to stop adding paragraph tags around `<figcaption>`.
...
Fixes #39307 for trunk.
Built from https://develop.svn.wordpress.org/trunk@39912
git-svn-id: http://core.svn.wordpress.org/trunk@39849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 01:06:40 +00:00
ee3052fdbe
Docs: some improvements/fixes for editor.js.
...
See #38933 .
Built from https://develop.svn.wordpress.org/trunk@39911
git-svn-id: http://core.svn.wordpress.org/trunk@39848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 00:49:41 +00:00
6032bd6e32
Docs: Use 3-digit, x.x.x style semantic versioning for `@since` entries in `wp-admin/js/image-edit.js`.
...
See #38748 .
Built from https://develop.svn.wordpress.org/trunk@39740
git-svn-id: http://core.svn.wordpress.org/trunk@39680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-06 22:13:20 +00:00
e8c65e0df1
Docs: Use 3-digit, x.x.x style semantic versioning for `@since` entries in `wp-admin/js/word-count.js`.
...
See #37718 .
Built from https://develop.svn.wordpress.org/trunk@39739
git-svn-id: http://core.svn.wordpress.org/trunk@39679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-06 22:12:39 +00:00
e654c81f10
Docs: Add documentation for `wp-admin/js/editor.js`.
...
Props terwdan, ireneyoast.
Fixes #38933 .
Built from https://develop.svn.wordpress.org/trunk@39738
git-svn-id: http://core.svn.wordpress.org/trunk@39678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-06 22:11:57 +00:00
8912d6b134
Updates: Properly define `$filesystemForm` to handle error in modals.
...
Ammends [39657].
See #39057 .
Built from https://develop.svn.wordpress.org/trunk@39689
git-svn-id: http://core.svn.wordpress.org/trunk@39629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-05 07:24:43 +00:00
5468850b10
Customize: Update `customize.php` URL with `changeset_uuid` param the instant a change is made instead of deferring until the changeset update request responds.
...
Props asalce.
Fixes #39227 .
Built from https://develop.svn.wordpress.org/trunk@39686
git-svn-id: http://core.svn.wordpress.org/trunk@39626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-05 05:18:43 +00:00
05f07e13d9
Updates: Show the Authentication key settings after selecting the SSH transport in both the modal, and also on the plugin/theme updates screen.
...
Props afercia.
Fixes #39057 for trunk.
Built from https://develop.svn.wordpress.org/trunk@39657
git-svn-id: http://core.svn.wordpress.org/trunk@39597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-30 07:44:41 +00:00
f7ba137f19
Customize: Fix visible edit shortcuts for `wp_nav_menu()` instances using the `menu` arg (such as in the Custom Menu widget) instead of the `theme_location` arg.
...
Also fix logic for `focus-control-for-setting` handler to focus on the first control (lowest `priority` value) associated with a given setting instead of the last control encountered when iterating over all controls, as this ensures the first control in a `nav_menu` section is focused rather than the last one.
Props westonruter, sirbrillig.
See #27403 .
Fixes #39101 .
Built from https://develop.svn.wordpress.org/trunk@39622
git-svn-id: http://core.svn.wordpress.org/trunk@39562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-20 22:05:43 +00:00
ee36cf9214
Themes: Add missing square bracket in jQuery selector.
...
Fixes a bug in Safari where the UI wasn't updated after deleting a theme due to
the incomplete selector.
Props Hristo Sg.
Fixes #39246 .
Built from https://develop.svn.wordpress.org/trunk@39586
git-svn-id: http://core.svn.wordpress.org/trunk@39526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 09:32:41 +00:00
1b96e389c0
Customize: Fix inability to delete nav menus by preventing `preview` filters from being added during `customize_save` admin ajax request.
...
Also prevent setting `nav_menu_locations[...]` values to `NaN` which gets sent as `null`.
Amends [38810].
See #30937 .
Fixes #39103 .
Built from https://develop.svn.wordpress.org/trunk@39558
git-svn-id: http://core.svn.wordpress.org/trunk@39498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 06:30:46 +00:00
f1c383454b
Customize: Prevent scrolling `custom_css` textarea to top when pressing tab.
...
Props tyxla, sstoqnov for testing, celloexpressions for testing.
See #38667 .
Fixes #39134 .
Built from https://develop.svn.wordpress.org/trunk@39557
git-svn-id: http://core.svn.wordpress.org/trunk@39497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 00:44:40 +00:00
d94530e721
Customize: Collapse available nav menu items panel when clicking outside over preview or over existing items.
...
Props rockwell15.
Fixes #38953 .
Built from https://develop.svn.wordpress.org/trunk@39548
git-svn-id: http://core.svn.wordpress.org/trunk@39488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 06:16:40 +00:00
993f895c29
Accessibility: Remove inappropriate content from the Plugins screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39535
git-svn-id: http://core.svn.wordpress.org/trunk@39475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 18:48:40 +00:00
a9600d1a53
Accessibility: Remove inappropriate content from the Themes screen heading.
...
Props joedolson.
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39528
git-svn-id: http://core.svn.wordpress.org/trunk@39468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 23:12:41 +00:00
6a3de4d857
Customize: Ensure `changeset_uuid` query param is removed from the `customize.php` window's location once a changeset has been published (committed) with starter content.
...
Props westonruter, dlh for testing.
See #30937 .
Fixes #39081 .
Built from https://develop.svn.wordpress.org/trunk@39504
git-svn-id: http://core.svn.wordpress.org/trunk@39444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-05 16:56:42 +00:00
97f4180916
Customize: Prevent posts/pages imported via starter content from being dropped when adding post/page stubs via nav menus and the dropdown-pages control.
...
Props westonruter, dlh for testing.
See #38114 , #34923 .
Fixes #39071 .
Built from https://develop.svn.wordpress.org/trunk@39502
git-svn-id: http://core.svn.wordpress.org/trunk@39442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-05 16:47:41 +00:00
113833953d
Docs: Add inline documentation for `image-edit.js`.
...
Adds JSDoc DocBlocks to the imageEdit methods.
Props: andizer, rensw90.
Fixes #38748 .
Built from https://develop.svn.wordpress.org/trunk@39493
git-svn-id: http://core.svn.wordpress.org/trunk@39433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 21:35:40 +00:00
b2c65c9a95
Customize: Fix regression in ability to hide fields for advanced menu properties in nav menu item controls.
...
Props westonruter, celloexpressions.
See #34391 .
Fixes #38952 .
Built from https://develop.svn.wordpress.org/trunk@39378
git-svn-id: http://core.svn.wordpress.org/trunk@39318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-30 18:01:43 +00:00
b2c12e463a
Customize: Fix regression in ability to create submenus for nav menus via drag and drop.
...
See #34391 .
Fixes #38948 .
Props delawski, adamsilverstein.
Built from https://develop.svn.wordpress.org/trunk@39376
git-svn-id: http://core.svn.wordpress.org/trunk@39316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-30 17:43:43 +00:00
6b5d960453
Customize: Clean up docs and code style for customize changes in 4.7.
...
* Adds missing `resolve`/`fail` for promise returned by `loadThemePreview`.
* Adds missing jsdoc blocks and tags.
* Adds missing phpdoc and makes corrections.
See #37770 .
Fixes #38908 .
Built from https://develop.svn.wordpress.org/trunk@39345
git-svn-id: http://core.svn.wordpress.org/trunk@39285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-23 06:05:32 +00:00
2fadd7a895
Docs: Use 3-digit, x.x.x style semantic versioning for `@since 4.7.0` entries.
...
See #37770 .
Built from https://develop.svn.wordpress.org/trunk@39281
git-svn-id: http://core.svn.wordpress.org/trunk@39221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-17 18:28:30 +00:00
c2bc6df69a
Customize: Ensure Close button actually closes customizer (instead of going back) after switching to a different theme inside a `customize-loader` iframe.
...
Fixes #38833 .
Built from https://develop.svn.wordpress.org/trunk@39271
git-svn-id: http://core.svn.wordpress.org/trunk@39211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-16 22:17:29 +00:00
de0835dead
Customize: Only show video header controls if previewing front page; show explanatory notice when controls are hidden.
...
Also include todo for the `header_video` control's `button_labels`. See #38796 .
Props westonruter, joemcgill, celloexpressions.
Fixes #38778 .
Built from https://develop.svn.wordpress.org/trunk@39237
git-svn-id: http://core.svn.wordpress.org/trunk@39177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-15 03:47:30 +00:00
5f7bbe66d7
Posts, Post Types: Fix Quick Edit to correctly set the page template for non-hierarchical post types.
...
Props dd32, swissspidy.
Fixes #38655 .
Built from https://develop.svn.wordpress.org/trunk@39210
git-svn-id: http://core.svn.wordpress.org/trunk@39150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-13 07:42:31 +00:00
2b81ceddf9
Customize: Prevent previewer from appearing to freeze when refreshing too fast.
...
Fixes race condition issue where a previous iframe fails to get destroyed, leaving a iframe pending loading persistently shown.
Props nikeo, westonruter.
Fixes #38728 .
Built from https://develop.svn.wordpress.org/trunk@39199
git-svn-id: http://core.svn.wordpress.org/trunk@39139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-10 22:43:32 +00:00
25a052bac7
Customize: Fix loading of theme screenshots in themes section and remove erroneous borders on hover.
...
Fixes regressions introduced in [38648].
Props delawski, mckernanin.
See #34391 .
Fixes #38222 .
Built from https://develop.svn.wordpress.org/trunk@39153
git-svn-id: http://core.svn.wordpress.org/trunk@39093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-07 21:47:30 +00:00
5ea1e6fd80
Customize: Allow tab characters in custom CSS input.
...
Pressing `Esc` followed by `Tab` allows for tabbing to the next element.
Props afercia, coffee2code, westonruter.
See #35395 .
Fixes #38667 .
Built from https://develop.svn.wordpress.org/trunk@39149
git-svn-id: http://core.svn.wordpress.org/trunk@39089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-06 19:09:33 +00:00
53c8c68365
Administration: Ensure collapse menu is usable with a keyboard
...
Currently, the "Collapse menu" item is not focusable and keyboard users can't collapse/expand the admin menu. This aims to fix it so that screen readers no longer announce it as a clickable but it remains unfocusable and thus unusable. So it's now a button.
Quoting joedolson at WordCamp Chicago 2014:
"If it's supposed to act like a button, it should be a button."
Also includes a grunt:precommit run that picked up some postcss changes to src/wp-includes/css/customize-preview.css
Fixes #29958 .
Props ajercia, ipm-frommen for an iterative patch, valendesigns for an iterative patch, GaryJ for feedback, joedolson for feedback, helen for feedback
Built from https://develop.svn.wordpress.org/trunk@39141
git-svn-id: http://core.svn.wordpress.org/trunk@39081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-04 17:18:57 +00:00
1281a28382
Customize: Revert theme install feature.
...
This is a great goal for core, and is close, but it is not in shape to be shipped for 4.7 and there is not enough time left in the development cycle to alter and polish sufficiently. There are bugs, but more than that, there are more fundamental questions around the use of existing UI, general UX, and how findable themes are (not) on the .org side.
see #37661 .
Built from https://develop.svn.wordpress.org/trunk@39140
git-svn-id: http://core.svn.wordpress.org/trunk@39080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-04 17:18:26 +00:00
Weston Ruter
Andrea Fercia
Pascal Birchler
Sergey Biryukov
John Blackbourn
Adam Silverstein
Andrew Ozz
Dion Hulse
Konstantin Obenland
Aaron Jorbin
Helen Hou-Sandí