Commit Graph

27076 Commits

Author SHA1 Message Date
Sergey Biryukov fa8e82efab Send nocache_headers() on installation screens and when redirecting to them.
fixes #29248.
Built from https://develop.svn.wordpress.org/trunk@29599


git-svn-id: http://core.svn.wordpress.org/trunk@29373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 17:40:16 +00:00
Helen Hou-Sandí a20fc80aeb Media Grid: Move CSS into an admin-only file.
`media-views.css` can be loaded on the front, which does not need this extra CSS.

fixes #29340.

Built from https://develop.svn.wordpress.org/trunk@29598


git-svn-id: http://core.svn.wordpress.org/trunk@29372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 16:51:15 +00:00
Helen Hou-Sandí b1b7d5f3a2 Only show one search form for the plugin installer.
The field dropdown now appears in the filter bar only when doing a search.

see #28785.

Built from https://develop.svn.wordpress.org/trunk@29597


git-svn-id: http://core.svn.wordpress.org/trunk@29371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 16:03:16 +00:00
Helen Hou-Sandí 713857625e Make filter bar CSS less verbose and redundant.
Also removes an unused handler in the theme feature filter.

see #28794.

Built from https://develop.svn.wordpress.org/trunk@29596


git-svn-id: http://core.svn.wordpress.org/trunk@29370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:58:15 +00:00
Andrew Nacin 4261ce75a6 Plugins: Only show details link if user can install plugins.
fixes #17902.

Built from https://develop.svn.wordpress.org/trunk@29595


git-svn-id: http://core.svn.wordpress.org/trunk@29369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:28:17 +00:00
Sergey Biryukov b06652da92 Install Plugins: Don't wp_die() if API can't be reached.
props johnbillion.
fixes #29361.
Built from https://develop.svn.wordpress.org/trunk@29594


git-svn-id: http://core.svn.wordpress.org/trunk@29368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:02:17 +00:00
Andrew Ozz 488e2aa4cf Editor expand: add border to the Text editor resize helper, helps calculating the height in some cases. Fixes #29225
Built from https://develop.svn.wordpress.org/trunk@29593


git-svn-id: http://core.svn.wordpress.org/trunk@29367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 03:43:17 +00:00
Andrew Ozz 58752f91db Editor scrolling: fix window height when switching Visual to Text and the editor is shorter. Props mackensen, fixes #29226.
Built from https://develop.svn.wordpress.org/trunk@29592


git-svn-id: http://core.svn.wordpress.org/trunk@29366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 23:12:15 +00:00
Andrew Nacin 15b0d10544 Plugin details: Adjust plugin title when it does not have a banner.
Smaller, bold, and Open Sans, like other modals. Only use Helvetica Neue when the plugin has a banner.

see [29040], see #27440.

Built from https://develop.svn.wordpress.org/trunk@29591


git-svn-id: http://core.svn.wordpress.org/trunk@29365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 20:48:15 +00:00
Andrew Nacin bab83d0f5a Plugin details: Correctly calculate the height of the right column for plugins without banners.
Comment these magic numbers.

see #27440, [29474].

Built from https://develop.svn.wordpress.org/trunk@29590


git-svn-id: http://core.svn.wordpress.org/trunk@29364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 20:45:17 +00:00
Helen Hou-Sandí ea05215581 Version bump.
Built from https://develop.svn.wordpress.org/trunk@29589


git-svn-id: http://core.svn.wordpress.org/trunk@29363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 18:44:18 +00:00
Andrew Nacin 491f5cec39 Screen: Move editor scrolling screen option to the proper place.
see [29336], see #28328.

Built from https://develop.svn.wordpress.org/trunk@29588


git-svn-id: http://core.svn.wordpress.org/trunk@29362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 17:57:16 +00:00
Andrew Nacin fa120992e4 Equal margins for plugin icons. see #28785.
Built from https://develop.svn.wordpress.org/trunk@29587


git-svn-id: http://core.svn.wordpress.org/trunk@29361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 17:56:15 +00:00
Andrew Nacin bb4db92621 Plugin install: Add icons to compatible/incompatible. see #29313.
Built from https://develop.svn.wordpress.org/trunk@29586


git-svn-id: http://core.svn.wordpress.org/trunk@29360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 17:26:15 +00:00
Scott Taylor 1335ff3e40 Media Grid: Don't make checkboxes tabbable when in bulk select media grid mode, fixes tabbing in bulk select mode.
Props adamsilverstein.
See #28822.

Built from https://develop.svn.wordpress.org/trunk@29585


git-svn-id: http://core.svn.wordpress.org/trunk@29359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:55:15 +00:00
Scott Taylor d5d0b37c35 Media Grid: restore focus to the selected item when shift-tab away from the attachment details sidebar.
Fixes #29303.

Built from https://develop.svn.wordpress.org/trunk@29584


git-svn-id: http://core.svn.wordpress.org/trunk@29358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:43:16 +00:00
Dominik Schilling 3a980c39c8 Apply accessibility improvements to Plugins screen too.
props SergeyBiryukov.
fixes #29342.
Built from https://develop.svn.wordpress.org/trunk@29583


git-svn-id: http://core.svn.wordpress.org/trunk@29357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:22:16 +00:00
Helen Hou-Sandí 8a545bf05e Media: Only fire keyboard events for the Attachments view once.
Firing them twice was breaking arrow key navigation in media attachment grids.

props gcorne.
fixes #29304.

Built from https://develop.svn.wordpress.org/trunk@29582


git-svn-id: http://core.svn.wordpress.org/trunk@29356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:17:16 +00:00
Dominik Schilling 49937c88f9 Plugin compatibility is based on your version of WordPress, not your install.
fixes #29313.
Built from https://develop.svn.wordpress.org/trunk@29581


git-svn-id: http://core.svn.wordpress.org/trunk@29355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:14:16 +00:00
Dominik Schilling 6c9853930a Add missing array keys for connection type in `request_filesystem_credentials()`.
see [28456].
fixes #29347.

Built from https://develop.svn.wordpress.org/trunk@29580


git-svn-id: http://core.svn.wordpress.org/trunk@29354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:04:18 +00:00
Andrew Ozz 61292620c5 Editor scrolling:
- Pin the TinyMCE statusbar (elements path) to the bottom.
- Add support for pinning the menu when present.
- Add borders from CSS.
- Optimize getting most elements outerHeight.
Part props avryl, fixes #29293, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29579


git-svn-id: http://core.svn.wordpress.org/trunk@29353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 05:11:16 +00:00
Drew Jaynes 09c3fd98d0 Fix a couple of misplaced/misordered argument descriptions in the `WP_Query` arguments hash notation.
See #25367.

Built from https://develop.svn.wordpress.org/trunk@29578


git-svn-id: http://core.svn.wordpress.org/trunk@29352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-23 19:36:17 +00:00
Andrew Ozz 42258a6d89 TinyMCE wpView: fix showing errors for non-embeddable URLs, no-ssl or no items. Props avryl, fixes #29114, see #29268.
Built from https://develop.svn.wordpress.org/trunk@29577


git-svn-id: http://core.svn.wordpress.org/trunk@29351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 18:55:15 +00:00
Andrew Ozz f2c881cf3b TinyMCE: update to 4.1.4-20140822. Changes:
- Fixed bug where sometimes the resize rectangles wouldn't properly render on images on WebKit/Blink. 9a2d01cc14
- Fixed nodeChanged selection issue where the image selection wouldn't be removed if you clicked right after/before it. dd729c67e0
- Fixed bug in list plugin where delete/backspace would merge empty LI elements in lists incorrectly. caadfb05dd
See #29310
Built from https://develop.svn.wordpress.org/trunk@29576


git-svn-id: http://core.svn.wordpress.org/trunk@29350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 17:44:16 +00:00
Sergey Biryukov 5487c3bd8f Fix unintended box-shadow in the opposite corner of thickbox Close icon.
props ocean90.
fixes #29311.
Built from https://develop.svn.wordpress.org/trunk@29575


git-svn-id: http://core.svn.wordpress.org/trunk@29349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 16:04:18 +00:00
Sergey Biryukov 039df6aac6 Plugin compatibility warnings should be red, not green.
props avryl.
fixes #29309.
Built from https://develop.svn.wordpress.org/trunk@29574


git-svn-id: http://core.svn.wordpress.org/trunk@29348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 03:57:19 +00:00
Andrew Nacin e32fc4df46 Export: Add wxr_export_skip_commentmeta filter to match the _postmeta filter.
props cfinke.
fixes #28745.

Built from https://develop.svn.wordpress.org/trunk@29573


git-svn-id: http://core.svn.wordpress.org/trunk@29347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 01:48:17 +00:00
Andrew Ozz 3d60d9f875 Autosave: prevent setting multiple stale `wp-saving-post-*` cookies when the browser disregards "session cookies" expiration on quit:
- Add expiration time of 24 hours for these cookies.
- Rename them to `wp-saving-post` (no post_id) so there is never more than one cookie per domain.
Fixes #29294.
Built from https://develop.svn.wordpress.org/trunk@29572


git-svn-id: http://core.svn.wordpress.org/trunk@29346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 00:25:16 +00:00
Andrew Ozz 5545f24b4f TinyMCE wpView: prevent errors when pasting multiple non-embeddable URLs, props avryl, fixes #29268
Built from https://develop.svn.wordpress.org/trunk@29571


git-svn-id: http://core.svn.wordpress.org/trunk@29345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 00:14:17 +00:00
Andrew Ozz c3c20549c5 TinyMCE: update to 4.1.4. Changelog: http://www.tinymce.com/develop/changelog/?type=tinymce. Fixes #29310
Built from https://develop.svn.wordpress.org/trunk@29570


git-svn-id: http://core.svn.wordpress.org/trunk@29344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 23:53:18 +00:00
Andrew Nacin 0eed9373e2 Introduce plugin icons in the installer.
See http://wp.me/p2AvED-2P8 for the announcement and how to implement these.

props tellyworth.
see #28785.

Built from https://develop.svn.wordpress.org/trunk@29569


git-svn-id: http://core.svn.wordpress.org/trunk@29343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 19:11:17 +00:00
Scott Taylor 31e599943d Media Grid: after [29566], account for Trash and Delete.
See #28842.

Built from https://develop.svn.wordpress.org/trunk@29568


git-svn-id: http://core.svn.wordpress.org/trunk@29342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 04:42:16 +00:00
Scott Taylor 1ab43c41c0 Media Grid: don't hide the uploader progress bar for individual items.
See [29527], #29037.

Built from https://develop.svn.wordpress.org/trunk@29567


git-svn-id: http://core.svn.wordpress.org/trunk@29341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 04:38:17 +00:00
Scott Taylor 7029af94e7 Media Grid: after completing a Bulk action, switch from `select` to `edit` mode.
Fixes #28842.

Built from https://develop.svn.wordpress.org/trunk@29566


git-svn-id: http://core.svn.wordpress.org/trunk@29340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 04:20:16 +00:00
Scott Taylor ca180e2544 Media Grid: don't auto-select attachments upon upload.
Props ocean90.
See #28842.

Built from https://develop.svn.wordpress.org/trunk@29565


git-svn-id: http://core.svn.wordpress.org/trunk@29339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 03:54:14 +00:00
Scott Taylor d6213d64a5 After [29543], the iframe sandboxes for media need to load Open Sans. Playlists look aggressively bad without it. Adds font styles for the body.
See #29048.

Built from https://develop.svn.wordpress.org/trunk@29564


git-svn-id: http://core.svn.wordpress.org/trunk@29338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 03:36:16 +00:00
Scott Taylor 8f810cbaa4 `media.view.Attachment`: set all of the view attributes in the same hash.
See [29299], #23560.

Built from https://develop.svn.wordpress.org/trunk@29562


git-svn-id: http://core.svn.wordpress.org/trunk@29337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 02:53:14 +00:00
Sergey Biryukov afe7639c7b Add missing box-shadow for pingbacks in Dashboard Activity widget.
props chrisl27.
fixes #29198.
Built from https://develop.svn.wordpress.org/trunk@29561


git-svn-id: http://core.svn.wordpress.org/trunk@29336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 02:37:16 +00:00
Scott Taylor 6352d703a0 Media Grid/Modal Keyboard navigation improvements:
* Add focus to arrows on Next/Previous in the grid's modal on left/right keypress, and add the necessary CSS for `:focus`
* When in a disabled input in the grid modal, allow the left/right keys to work
* Make the image editor return a `$.Deferred` so that there isn't a race condition with UI loading. 
* Assign focus when the edit image mode is rendered so that the modal can be closed on Esc press

Props wonderboymusic, adamsilverstein (for the initial patch).
See #23560.

Built from https://develop.svn.wordpress.org/trunk@29560


git-svn-id: http://core.svn.wordpress.org/trunk@29335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 02:35:17 +00:00
Andrew Ozz 53c047263b TinyMCE wpView: add a filter for the stylesheet URLs loaded in the sandbox iframes. See #29048.
Built from https://develop.svn.wordpress.org/trunk@29559


git-svn-id: http://core.svn.wordpress.org/trunk@29334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 21:34:15 +00:00
Scott Taylor 557861446f Cleanup after [29220]:
`media.controller.Library` is State/Backbone Model and should not touch views.

See #23560.

Built from https://develop.svn.wordpress.org/trunk@29558


git-svn-id: http://core.svn.wordpress.org/trunk@29333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 20:00:16 +00:00
Sergey Biryukov b89389da60 Don't limit WP_Embed::cache_oembed() to posts and pages.
props bordoni, helen.
fixes #28639.
Built from https://develop.svn.wordpress.org/trunk@29557


git-svn-id: http://core.svn.wordpress.org/trunk@29332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 19:32:16 +00:00
Scott Taylor a43cfb4f96 Cleanup after [29220]:
* `media.view.Attachment` should not reach outside itself with global jQuery selectors
* `media.view.Attachment.Details` will re-render when `media.view.Attachment`'s single status changes. Add a `ready` callback to apply initial input focus

See #23560.

Built from https://develop.svn.wordpress.org/trunk@29556


git-svn-id: http://core.svn.wordpress.org/trunk@29331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 19:29:17 +00:00
Scott Taylor 31bb46d0fc Initial cleanup after [29220]:
* Alter/remove some jQuery global selectors, views should only manage themselves
* Trigger an event for attachments when arrow keys are pressed: `attachment:keydown:arrow`
* `media.view.Attachments` should listen for `attachment:keydown:arrow`
* Favor scoped selectors over globals

See #23560.

Built from https://develop.svn.wordpress.org/trunk@29555


git-svn-id: http://core.svn.wordpress.org/trunk@29330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 19:14:15 +00:00
Scott Taylor dc4d08e032 `wpmu_activate_signup()` returns an `array` or `WP_Error`. The array keys it returns can be different based on context of `$signup`. The return value was previously `extract()`'d, so the value of `$blog_id` was secretly undefined when being passed to `get_blogaddress_by_id()` in some cases.
If `$result['blog_id']` is not set, make sure `$url` is set to an empty string so that the proper "activated" message is shown to the user.

Props imath.
See [28373].
Fixes #29191.

Built from https://develop.svn.wordpress.org/trunk@29554


git-svn-id: http://core.svn.wordpress.org/trunk@29329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:30:16 +00:00
Dominik Schilling 9f91625fb6 Insert Media: Don't select a model if it's already selected.
props avryl, adamsilverstein.
fixes #29152.

Built from https://develop.svn.wordpress.org/trunk@29553


git-svn-id: http://core.svn.wordpress.org/trunk@29328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:20:15 +00:00
Scott Taylor 2808d5c523 Media Grid: Cleanup toggling of Next/Previous in Edit modal.
Fixes #29264.

Built from https://develop.svn.wordpress.org/trunk@29551


git-svn-id: http://core.svn.wordpress.org/trunk@29327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:11:15 +00:00
Dominik Schilling 048b96f80d Media: Remove scan for lost attachments.
This hasn't been worked for 4 years.

fixes #29169.

Built from https://develop.svn.wordpress.org/trunk@29550


git-svn-id: http://core.svn.wordpress.org/trunk@29326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:09:15 +00:00
Scott Taylor d4d1fcda0f `wp_update_term()` should mimic `wp_insert_term()` and set a value for `$term_group` before the `alias_of` logic runs. This ensures that `$term_group` exists when `compact()` is called.
See [28461].
Fixes #29278.

Built from https://develop.svn.wordpress.org/trunk@29549


git-svn-id: http://core.svn.wordpress.org/trunk@29325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:04:18 +00:00
Dominik Schilling 3d98d94878 Media Grid: Don't hide error messages behind the toolbar.
fixes #29141.
Built from https://develop.svn.wordpress.org/trunk@29548


git-svn-id: http://core.svn.wordpress.org/trunk@29324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 16:48:16 +00:00