Commit Graph

62 Commits

Author SHA1 Message Date
Sergey Biryukov 2a0489ec49 Docs: Replace `@returns` tags in JS docs with `@return`.
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

See #48303.
Built from https://develop.svn.wordpress.org/trunk@46800


git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 18:01:03 +00:00
Andrea Fercia 72979b167d Accessibility: Improve the placeholder "prompt" text in the post title and Quick Draft widget.
Old browsers didn't support the HTML placeholder attribute. For a number of years, `<label>` elements have been used in a few places in WordPress to emulate placeholders. It's time to improve semantics and interaction, use real placeholders when possible, and clean up some JavaScript.

- Quick Draft widget: it now uses visible `<label>` elements and a real `placeholder` attribute 
- removes the related JavaScript
- Post title:
  - keeps the "prompt" label for backwards compatibility
  - improves the JavaScript to make the "prompt" label stay visible on focus and disappear when typing, like real placeholder do
- changes the post "prompt" text from "Enter title here" to "Add title" for consistency with the Block Editor 
- cleans-up some CSS

Props Cheffheid, afercia.
Fixes #42390.

Built from https://develop.svn.wordpress.org/trunk@44896


git-svn-id: http://core.svn.wordpress.org/trunk@44727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-14 17:39:53 +00:00
omarreiss bdbaccce37 General: Explicitly assigns all JS globals to the window.
Many variables in the JavaScript were defined in the global scope without being explicitly assigned to the window. When built with Webpack, the code gets encapsulated in anonymous functions and those implicit globals get assigned to the wrong scope. This patch prevents that from happening.

Fixes #44371. See #43731.

Built from https://develop.svn.wordpress.org/trunk@43577


git-svn-id: http://core.svn.wordpress.org/trunk@43406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-19 13:33:24 +00:00
atimmer bde558be2f Docs: Add file doc `@output` annotations.
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.

The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.

Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361.

Built from https://develop.svn.wordpress.org/trunk@43347


git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
atimmer f544da9b38 Docs: Improve JS Docs for `wp-admin/js/dashboard.js`.
Props jipmoors, andizer, ireneyoast, boblinthorst.
Fixes #42831.

Built from https://develop.svn.wordpress.org/trunk@42393


git-svn-id: http://core.svn.wordpress.org/trunk@42222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-14 14:11:51 +00:00
Aaron Jorbin b8fc8cb59c Dashboard: Remove "Try Gutenberg" callout.
Reverting this for 4.9. It will be added back in a future version of WordPress. This doesn't mean that you shouldn't be trying Gutenberg, just that it isn't ready for a call out to a larger audience. But if you are the type to read commit messages, https://github.com/WordPress/gutenberg could use your pull requests and comments on issues.

Reverts [41931] [41900] [41896] [41895]
See #41316


Built from https://develop.svn.wordpress.org/trunk@41978


git-svn-id: http://core.svn.wordpress.org/trunk@41812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 20:48:47 +00:00
Gary Pendergast df8ab820ef Dashboard: Remove a rogue comma introduced in [41895].
See #41316.


Built from https://develop.svn.wordpress.org/trunk@41896


git-svn-id: http://core.svn.wordpress.org/trunk@41730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 12:39:46 +00:00
Gary Pendergast 3981736cd6 Dashboard: Introduce a "Try Gutenberg" callout.
To encourage more people to try Gutenberg, this new Dashboard box allows site users to easily install and try out Gutenberg.

Props pento, melchoyce, joen, karmatosed.
Fixes #41316.


Built from https://develop.svn.wordpress.org/trunk@41895


git-svn-id: http://core.svn.wordpress.org/trunk@41729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 10:04:47 +00:00
Andrea Fercia c56dbad284 Accessibility: Improve the Dashboard Nearby Events widget `wp.a11y.speak()` messages.
Avoids to announce the "city updated" message on page load.

Fixes #42037.

Built from https://develop.svn.wordpress.org/trunk@41682


git-svn-id: http://core.svn.wordpress.org/trunk@41516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-02 19:25:45 +00:00
Andrea Fercia 1a8f7ab144 Dashboard: Don't trigger an Events search when the search field is empty.
Fixes #40816.

Built from https://develop.svn.wordpress.org/trunk@40799


git-svn-id: http://core.svn.wordpress.org/trunk@40657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 17:27:43 +00:00
Andrew Ozz 7a9ce6d03f Dashboard: Improve the handling of locations determined by geolocating the IP address and by entering a city name. Fix couple of edge cases, and some names.
Props iandunn coreymckrill.
Fixes #40702.
Built from https://develop.svn.wordpress.org/trunk@40790


git-svn-id: http://core.svn.wordpress.org/trunk@40648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 05:48:42 +00:00
Andrew Ozz daab579a88 Dashboard:
- Close the form after obtaining a valid location.
- Fix focusing the toggle button after closing the form.
- Fix aria attribute values.
- Fix positions in IE11.
- Some JS and CSS cleanup.

Props afercia, coreymckrill.
Fixes #40735.
Built from https://develop.svn.wordpress.org/trunk@40789


git-svn-id: http://core.svn.wordpress.org/trunk@40647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 04:01:41 +00:00
Andrew Ozz b952bf4eae Dashboard: Update the existing WordPress News dashboard widget to also include upcoming meetup events and WordCamps near the current user’s location.
Props @afercia, @andreamiddleton, @azaozz, @camikaos, @coreymckrill, @chanthaboune, @courtneypk, @dd32, @iandunn, @iseulde, @mapk, @mayukojpn, @melchoyce, @nao, @obenland, @pento, @samuelsidler, @stephdau, @tellyworth.
See #40702.
Built from https://develop.svn.wordpress.org/trunk@40607


git-svn-id: http://core.svn.wordpress.org/trunk@40477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-10 20:04:42 +00:00
Andrew Ozz a6cf0b41a6 JS: in event callbacks replace the very outdated `return false` with `preventDefault()`.
Props adamsilverstein.
Fixes #18590.
Built from https://develop.svn.wordpress.org/trunk@34977


git-svn-id: http://core.svn.wordpress.org/trunk@34942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 01:27:27 +00:00
Andrew Ozz 8cbfdfa51b Fix dragging to the bottom of the screen on the Dashboard.
Props eltobiano. See #32094.
Built from https://develop.svn.wordpress.org/trunk@32505


git-svn-id: http://core.svn.wordpress.org/trunk@32475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 23:50:28 +00:00
Sergey Biryukov 4078e14d1e QuickPress: Disable autocomplete for content, enable "Save Draft" button on load.
props morganestes, michalzuber.
fixes #27760.
Built from https://develop.svn.wordpress.org/trunk@29323


git-svn-id: http://core.svn.wordpress.org/trunk@29104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-29 15:34:16 +00:00
Andrew Nacin c593fe63d3 Don't auto-resize Quick Draft textarea in IE < 9. Avoids IE8 crash.
props morganestes.
fixes #27761.

Built from https://develop.svn.wordpress.org/trunk@28103


git-svn-id: http://core.svn.wordpress.org/trunk@27934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 18:25:15 +00:00
John Blackbourn 181c2d091e Remove the "See more" toggle from the At a Glance dashboard widget. Fixes #26614.
Built from https://develop.svn.wordpress.org/trunk@27583


git-svn-id: http://core.svn.wordpress.org/trunk@27426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 12:56:14 +00:00
Andrew Nacin ab733945b5 Properly detect line height of Quick Draft textarea.
props batmoo.
fixes #26915 for trunk.

Built from https://develop.svn.wordpress.org/trunk@27021


git-svn-id: http://core.svn.wordpress.org/trunk@26897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-23 18:03:12 +00:00
Matt Thomas cd465575f1 Expand the Quick Draft section by default. Fixes #26463, props bassgang.
Built from https://develop.svn.wordpress.org/trunk@26813


git-svn-id: http://core.svn.wordpress.org/trunk@26700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 00:43:11 +00:00
Helen Hou-Sandí 1a3a45dcef Auto-resize the Quick Draft textarea. props lessbloat, markjaquith, helen. fixes #26053.
Built from https://develop.svn.wordpress.org/trunk@26564


git-svn-id: http://core.svn.wordpress.org/trunk@26455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:35:09 +00:00
Andrew Ozz e5b13dfdf3 Dashboard: set containment for postboxes to "document" and give empty sortables some min-height so postboxes can be dropped there. Props lessbloat, fixes #26026.
Built from https://develop.svn.wordpress.org/trunk@26429


git-svn-id: http://core.svn.wordpress.org/trunk@26329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-27 02:03:10 +00:00
Helen Hou-Sandí 2c9af1367e Dashboard columns:
* Improve responsive breakpoints for.
* Remove obsolete network admin option.
* Remove unnecessary JS.

props SergeyBiryukov, kraftbj, lessbloat. fixes #26074.

Built from https://develop.svn.wordpress.org/trunk@26392


git-svn-id: http://core.svn.wordpress.org/trunk@26292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 05:09:10 +00:00
Helen Hou-Sandí e911c4272a Dashboard JS cleanup. props kadamwhite, helen. see #25824.
Built from https://develop.svn.wordpress.org/trunk@26390


git-svn-id: http://core.svn.wordpress.org/trunk@26290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 04:38:09 +00:00
Helen Hou-Sandí f9469c921d Contain Dashboard widget dragging. props lessbloat. fixes #26026.
Built from https://develop.svn.wordpress.org/trunk@26372


git-svn-id: http://core.svn.wordpress.org/trunk@26272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 00:55:09 +00:00
Andrew Nacin ef007d1a40 Fix JSHint errors in three files.
props tommcfarlin.
fixes #25942, #25943, #25944.

Built from https://develop.svn.wordpress.org/trunk@26232


git-svn-id: http://core.svn.wordpress.org/trunk@26139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 23:19:09 +00:00
Andrew Nacin 791e807f08 More dash updates.
* Shuffle around some pixels.
 * Rename some things that weren't caught in [26220].
 * Revert default-widgets.php change from [26144].
props lessbloat.
see #25824.

Built from https://develop.svn.wordpress.org/trunk@26230


git-svn-id: http://core.svn.wordpress.org/trunk@26137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 22:23:09 +00:00
Andrew Nacin 2cc8ed1594 Dash cleanup.
* Use wp_add_dashboard_widget() rather than add_meta_box().
 * Use original functions like wp_dashboard_primary(), wp_dashboard_right_now(), wp_dashboard_quick_press() (where possible).
 * Only include plugins section of the news widget when appropriate, which necessitates the set_current_screen() via the ajax action.
 * Remove some debug cruft that was preventing caching and invalidation.
 * Simplify lots of things where possible.
see #25824.

Built from https://develop.svn.wordpress.org/trunk@26220


git-svn-id: http://core.svn.wordpress.org/trunk@26128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 20:15:10 +00:00
Andrew Nacin 809b335f7a Merge the new dashboard design into core.
Merges https://github.com/growthdesigner/wp-dash.

props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824.

Built from https://develop.svn.wordpress.org/trunk@26144


git-svn-id: http://core.svn.wordpress.org/trunk@26055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 22:09:10 +00:00
Daryl Koopersmith 1e19ec5fb4 Media in QuickPress: Ensure wpActiveEditor is set when the "Add Media" button is clicked. fixes #22021, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 01:40:47 +00:00
Andrew Ozz b404fbdb85 QuickPress: add some JS to set wpActiveEditor when the title or content is focused, fixes #22021
git-svn-id: http://core.svn.wordpress.org/trunk@22517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 03:05:48 +00:00
Andrew Nacin 1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin cfdab676fa Replace QuickPress labels with gray prompt texts. Stylish, but also done for localization purposes (string lengths). props ocean90. fixes #21754.
git-svn-id: http://core.svn.wordpress.org/trunk@21894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 18:45:44 +00:00
Andrew Nacin 2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
bumpbot af84dbcf93 Compress scripts/styles: 3.4-alpha-20192.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-15 13:58:27 +00:00
ryan 3f94d307b3 About face. Revert [19628]. Gonna improve Plugins widget instead of tossing it. see #19573
git-svn-id: http://svn.automattic.com/wordpress/trunk@19629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-23 00:25:09 +00:00
ryan 40345f1d63 Remove Plugins dashboard widget. fixes #19573
git-svn-id: http://svn.automattic.com/wordpress/trunk@19628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-22 21:57:21 +00:00
nacin dd697967bf Change show/hide storage mechanism for show_welcome_panel. 0 = hide, 1 = show, 2 = show if the multisite owner. Make welcome panel dismissable without JS (openable too via the URL). fixes #19338, fixes #19127.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 18:30:45 +00:00
azaozz 507643807a Welcome Screen: remove white space, make the second dismiss link work, see #11651
git-svn-id: http://svn.automattic.com/wordpress/trunk@19345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-19 00:42:22 +00:00
nacin 1494ca6b9f Use a better method for [19133]. see #11651.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 23:09:59 +00:00
nacin 04915a9b07 Show the welcome screen when one shows it from Screen Options, advances to a page, then uses the browser's back button to return. see #11651.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 23:08:24 +00:00
nacin 11a800a3d9 Move welcome panel link to a 'Show on screen' checkbox. see #11651.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 21:43:21 +00:00
koopersmith 1391717cfa Welcome panel contents and functionality. see #11651.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 16:41:26 +00:00
azaozz 5d756ba5d2 Fix another .attr() vs .prop() case, props ocean90, fixes #17546
git-svn-id: http://svn.automattic.com/wordpress/trunk@18024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-24 16:49:01 +00:00
azaozz 2081fd0504 Cleanup in dashboard.js, props scribu, fixes 17292
git-svn-id: http://svn.automattic.com/wordpress/trunk@17784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-30 23:31:34 +00:00
azaozz 298bfc2910 Don't trigger "Exception thrown and not caught" error in jQuery 1.5.2 in IE
git-svn-id: http://svn.automattic.com/wordpress/trunk@17783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-30 19:42:31 +00:00
nacin 8b5122b411 Don't load the QuickPress widget via XHR. see #16927. Reverts [16725] as it's no longer needed. Reverts part of [14815], which introduced the behavior, see #10917.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 12:02:24 +00:00
markjaquith 4920e7a54f Recompress some JS scripts that were done without YUI munging.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 08:04:58 +00:00
markjaquith 3a7b4b71d4 Prevent double Thickbox caption line for Dashboard QuickPress uploads. props ocean90. fixes #15169
git-svn-id: http://svn.automattic.com/wordpress/trunk@16671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 20:48:52 +00:00
ryan bbd2895543 Cause infinite recursion caused by malformed URLs. Props mdawaffe. fixes #14655
git-svn-id: http://svn.automattic.com/wordpress/trunk@15971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-26 13:43:26 +00:00