Ryan Boren
cc5ed3a485
Change all core API to expect unslashed rather than slashed arguments.
...
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.
Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.
Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.
Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.
Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.
Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.
Plugins should use wp_unslash() on data being passed to core API.
Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.
Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.
Remove many no longer necessary calls to $wpdb->escape() and esc_sql().
In wp_get_referer() and wp_get_original_referer(), return unslashed data.
Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.
Switch several queries over to prepare().
Expect something to break.
Props alexkingorg
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Sergey Biryukov
7a77f47f55
Use correct escaping function. fixes #23334 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 05:52:23 +00:00
Sergey Biryukov
08269aa6b0
Remove unused error string. props pavelevap. fixes #22107 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 05:36:28 +00:00
Helen Hou-Sandí
767f34de86
Restore the following:
...
* Box shadow for screen options/help tabs focus state.
* Text shadow on the about screen badge to match the text shadow in the graphic itself.
* Border for credits screen gravatars, in place of the previous box shadow.
props nacin. see #23415 .
git-svn-id: http://core.svn.wordpress.org/trunk@23409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 23:50:55 +00:00
Bot (Assets)
b05107c526
Compress scripts/styles: 3.6-alpha-23408.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 22:58:44 +00:00
Helen Hou-Sandí
32562f25e9
Begin simplifying some of the visual elements in the admin, starting with gradients. White space purposefully not currently altered. props lessbloat, melchoyce, aaroncampbell, sabreuse. see #23415 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 22:43:48 +00:00
Peter Westwood
f8cc93b62e
Revisions: Pass the whole revision being filtered along with context about which side it is to the _wp_post_revision_field_$field filters.
...
Fixes #19932 props pollett, ethitter.
git-svn-id: http://core.svn.wordpress.org/trunk@23404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 21:42:03 +00:00
Bot (Assets)
7d2eeb5aed
Compress scripts/styles: 3.6-alpha-23400.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 22:58:42 +00:00
Mark Jaquith
c2f837a3b4
Allow Backround Image's "select a file" link to be activated by pressing return on the keyboard.
...
props adamsilverstein. fixes #22606
git-svn-id: http://core.svn.wordpress.org/trunk@23399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:51:19 +00:00
Mark Jaquith
00dbfdf89e
Document the mysterious seventh parameter of add_meta_box().
...
props wonderboymusic, markjaquith. fixes #17515
git-svn-id: http://core.svn.wordpress.org/trunk@23397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:37:34 +00:00
Mark Jaquith
ddd1b94184
Link post formats in posts list table. Use a dash for standard, like we do for absence of tags. see #16047 Next: use icons, not text descriptions.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:34:51 +00:00
Mark Jaquith
dab5a6ef7d
Fix some tabbing issues on the post editing screen. Add Media no longer skipped when going backwards from content. Save Draft no longer skipped when going forwards from content.
...
props adamsilverstein. fixes #23195 and #22933
git-svn-id: http://core.svn.wordpress.org/trunk@23395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:30:09 +00:00
Helen Hou-Sandí
1c816c795b
Open external links to plugin homepages, plugin author homepages, and theme author homepages in a new window/tab. props SergeyBiryukov. fixes #20839 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:20:01 +00:00
Mark Jaquith
da5c7a7c62
"Lookup" is a noun. "Look up" is the verb form. If you doubt me, you should have lookuped in a dictionary.
...
props johnbillion, SergeyBiryukov. fixes #22386
git-svn-id: http://core.svn.wordpress.org/trunk@23393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:19:04 +00:00
Mark Jaquith
2fb915f860
Display post formats in the posts list table.
...
props nacin, garyc40, DrewAPicture, wonderboymusic, aaroncampbell.
fixes #16047
git-svn-id: http://core.svn.wordpress.org/trunk@23392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:10:05 +00:00
Bot (Assets)
b1adfbb54a
Compress scripts/styles: 3.6-alpha-23386.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-04 14:38:03 +00:00
Andrew Ozz
6c41e93fec
Heartbeat API: throttle down when the window looses focus or when the user is inactive, always send 'screen_id', change the interval settings to 'fast' (5sec), 'standard' (15sec) and 'slow' (60sec), the interval can be changed from PHP, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-03 07:03:27 +00:00
Helen Hou-Sandí
f452214f24
Maintain theme screenshot aspect ratio on the update screen. props cochran. fixes #23164 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 17:02:01 +00:00
Andrew Nacin
55ba72f46e
Confirm a user exists before deleting them in wp_delete_user() and wpmu_delete_user(). props scribu, fixes #23067 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 04:41:02 +00:00
Sergey Biryukov
2967871d34
Return WP_Error from wp_crop_image() if saving has failed. props macbrink. fixes #23325 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 02:01:59 +00:00
Andrew Nacin
91e3f2b866
Clean up rendering of the title column in the posts list table. Simplify branching. Use get_userdata() rather than get_user_by( 'id' ). Change string to '%s is currently editing'. see #23312 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:54:06 +00:00
Andrew Ozz
0674bbfa8a
Posts screen: show when a post is "locked", hide the checkbox, Quick Edit and Trash links, props dh-shredder, see #23312
...
git-svn-id: http://core.svn.wordpress.org/trunk@23371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:31:06 +00:00
Andrew Ozz
3911ebded5
New icons: make the .icon32 container larger to prevent clipping, see #23333
...
git-svn-id: http://core.svn.wordpress.org/trunk@23370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:01:35 +00:00
Andrew Ozz
855e0d8f3a
New icons take one, props empireoflight, see #23333
...
git-svn-id: http://core.svn.wordpress.org/trunk@23369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 00:22:40 +00:00
Sergey Biryukov
6cb5f510b8
Select "Attribute all posts to..." radio button automatically when selecting a username from the dropdown. fixes #23224 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-01 18:43:23 +00:00
Sergey Biryukov
e9eb36face
Only show "There is a pending change of your e-mail..." message on the current user's profile page. fixes #23146 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-01 01:50:19 +00:00
Andrew Ozz
98bf511b56
Heartbeat API: first run, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-29 06:15:25 +00:00
Helen Hou-Sandí
28f6c5bcf4
Remove the long-broken and questionably useful [more]/[less] toggle for hierarchical taxonomies in Quick/Bulk Edit. Nobody seems to have noticed in the nearly 3 years it's been broken. fixes #23006
...
git-svn-id: http://core.svn.wordpress.org/trunk@23354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 22:36:15 +00:00
Sergey Biryukov
72784ad6c2
Consistently use a helper function instead of directly printing the disabled attribute.
...
Remove an erroneous esc_attr() call.
fixes #23194 .
git-svn-id: http://core.svn.wordpress.org/trunk@23352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 03:23:01 +00:00
Sergey Biryukov
3e917ac75f
Make sure the post exists before checking its ID. fixes #23026 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 02:55:06 +00:00
Sergey Biryukov
3d8a1289d2
Add missing inline descriptions.
...
props momo360modena, aaronholbrook.
see #20494 , fixes #23304 .
git-svn-id: http://core.svn.wordpress.org/trunk@23350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 02:20:47 +00:00
Sergey Biryukov
428e9baba7
Correct return value for WP_Filesystem_Base::gethchmod(). props bananastalktome. fixes #23121 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 01:55:39 +00:00
Sergey Biryukov
2366239798
Prevent an unintended visibility change from "Password protected" to "Public" when updating the post.
...
props thomasvanderbeek. fixes #23065 .
git-svn-id: http://core.svn.wordpress.org/trunk@23338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-23 03:30:04 +00:00
Sergey Biryukov
8e32770793
Define the variable before using it. fixes #23181 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-23 03:00:20 +00:00
Andrew Ozz
50ceba1323
Autop: <samp> is not a block tag, props toscho, fixes #18807
...
git-svn-id: http://core.svn.wordpress.org/trunk@23327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-22 19:05:21 +00:00
Helen Hou-Sandí
b538d6163f
Make sure .widefat border and background coloring only applies to tables. props MikeHansenMe. fixes #21936 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-22 14:44:04 +00:00
Mark Jaquith
a24c40fb00
Consistently use $wp_rewrite->index instead of hardcoding "index.php".
...
props wonderboymusic. fixes #7337
git-svn-id: http://core.svn.wordpress.org/trunk@23305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-18 13:44:22 +00:00
Andrew Ozz
b59edea3cb
Main editor: when setting or saving the height, look only at elements that have style="height:..." set. Reset a previously saved erroneous "ed_size" value (over 5000px) to the default height of 360px. Fixes #23042 for trunk.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-16 19:10:38 +00:00
Dion Hulse
33d913220b
Core Update: Fix a issue which caused automatic upgrades from 2.7 to 3.5+ to fail. Pre-2.7 WP_Filesystem::wp_content_dir() returned unslashed paths. Introduced in [22227]. See #23177
...
git-svn-id: http://core.svn.wordpress.org/trunk@23297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-11 10:16:45 +00:00
Mark Jaquith
e841b1f3cf
Resolve DOCUMENT_ROOT symlinks and standardize Windows slashing for various paths related to Multisite rewrite rule generation. props SergeyBiryukov, nacin, wpewill. fixes #23104 and #23073 for trunk
...
git-svn-id: http://core.svn.wordpress.org/trunk@23295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-10 08:08:14 +00:00
Andrew Nacin
1fa8476425
Ensure we wp_die() at the end of an ajax action. see #23055 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-07 03:59:44 +00:00
Andrew Nacin
5d980a8e8e
Whenever we have compat fields to render, send a dummy menu_order field (which was always sent in 3.4) to ensure an unchecked checkbox can still be processed by attachment_fields_to_save. fixes #22868 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-05 03:50:28 +00:00
Bot (Assets)
d64b1cfa34
Compress scripts/styles: 3.6-alpha-23279.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 22:34:43 +00:00
Andrew Ozz
cc834e52bf
Taxonomy postbox: fix toggling with "Choose from the most used tags" when several postboxes are shown, props SergeyBiryukov, fixes #23112 for trunk
...
git-svn-id: http://core.svn.wordpress.org/trunk@23278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 20:54:11 +00:00
Peter Westwood
f683fc7677
Tighten our braces. Fixes #23118 props evansolomon.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 10:13:51 +00:00
Bot (Assets)
ed9743d358
Compress scripts/styles: 3.6-alpha-23257.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-03 22:58:37 +00:00
Dion Hulse
9f6638747d
Upgrade: When upgrading from WordPress 3.5, if an empty twentytwelve theme directory exists, remove it to allow the installation of Twenty Twelve. See #22856 . For trunk
...
git-svn-id: http://core.svn.wordpress.org/trunk@23253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-03 07:42:16 +00:00
Andrew Nacin
f0a8acc6b6
Don't stomp existing sizes inside wp_save_image().
...
props markoheijnen.
see #22985 .
for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@23246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-03 05:23:36 +00:00
Andrew Nacin
7b1503ad73
Fix the sprite positioning for HiDPI sorting arrows.
...
props lessbloat.
see #23071 .
for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@23245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-02 23:51:09 +00:00
Andrew Nacin
5491a56363
Remove deleted files on upgrade, including wp-app.php and class-wp-atom-server.php.
...
props duck_
see #22855
for trunk
git-svn-id: http://core.svn.wordpress.org/trunk@23203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-26 20:34:30 +00:00
Bot (Assets)
0fd3e567d7
Compress scripts/styles: 3.6-alpha-23200.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-23 22:58:43 +00:00
Helen Hou-Sandí
11f2a581ec
Allow non-hierarchical taxonomy labels in Bulk Edit to span the available width. Props SergeyBiryukov, tar.gz. fixes #22703 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-23 16:30:12 +00:00
Bot (Assets)
cb8c12d384
Compress scripts/styles: 3.6-alpha-23193. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-21 18:52:36 +00:00
Helen Hou-Sandí
b1f1579604
its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-20 15:55:32 +00:00
Helen Hou-Sandí
1570a67bef
Nav menu item selection lists no longer need to be specifically de-whitespaced to match hierarchical taxonomy metaboxes. props corvannoorloos. See #22954 for trunk.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-19 19:43:22 +00:00
Helen Hou-Sandí
0ff8123713
Align the "Available Themes" header with the search form. props wycks. fixes #22928 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-18 19:45:49 +00:00
Dion Hulse
39a19e1d76
When copying new bundled themes & plugins, bail early if the distro doesn't include the bundled item. This prevents us from creating an empty directory in the destination when the source doesn't exist. See #22856
...
git-svn-id: http://core.svn.wordpress.org/trunk@23179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-15 03:09:50 +00:00
Mark Jaquith
21963e265a
Fix code vomit in IIS rewrite rule generation. fixes #22920 for trunk. props toscho.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-13 22:54:36 +00:00
Andrew Nacin
de3a5b8694
Use 3 * HOUR_IN_SECONDS rather than 10800.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-12 07:30:28 +00:00
Andrew Nacin
5431638e74
We no longer care if wp-admin/index.php is parseable by PHP 4. (And it's not, anyway.) If a user hits the root or wp-admin/install.php, they do get a proper warning.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-11 16:08:58 +00:00
Andrew Nacin
60be66457a
Only show help for upload_path and upload_url_path if those fields are visible. fixes #21720 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-09 17:04:08 +00:00
Bot (Assets)
695d624bdd
Compress scripts/styles: 3.5-RC4-23127.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 21:00:25 +00:00
Andrew Nacin
db649fbc8d
Remove 'Insert Multiple Images' from the about page as it is now completely invisible in the UI. Requiring shift-click but not mentioning it is a bad omen. props helenyhou. fixes #22455 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 20:58:34 +00:00
Andrew Nacin
a90521652e
Final screenshot on the about page for the media manager.
...
props lessbloat.
props matt for the photos.
fixes #22455 .
git-svn-id: http://core.svn.wordpress.org/trunk@23109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 19:49:42 +00:00
Andrew Nacin
cfe6e9ed09
Rip keyboard shortcuts out of the image editor help. props helenyhou. fixes #22786 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 09:21:27 +00:00
Bot (Assets)
395f2b5073
Compress scripts/styles: 3.5-RC3-23099.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 06:58:33 +00:00
Mark Jaquith
1419b404a8
Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743 . props koopersmith, nacin, helenyhou.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:52:19 +00:00
Mark Jaquith
68524f7c6f
Run the attachment_fields_to_save filter even if we don't get the fields we used to get. props nacin. fixes #22774
...
git-svn-id: http://core.svn.wordpress.org/trunk@23094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:34:17 +00:00
Bot (Assets)
dd4f8b9273
Compress scripts/styles: 3.5-RC3-23093.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:26:39 +00:00
Daryl Koopersmith
30440dbb66
Add a canonical location for media frames, an alias to fetch attachments, and frame caching to custom header. fixes #22775 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:06:49 +00:00
Andrew Nacin
08401b9e3c
Fix branchhing in edit_post() where attachment_fields_to_save would only run when the alt text was sent. It should run whenever an attachment is saved. props sc0ttclark. fixes #22774 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:50:31 +00:00
Daryl Koopersmith
8efc323e2e
Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:28:21 +00:00
Bot (Assets)
4f3c1bb8f1
Compress scripts/styles: 3.5-RC3-23084.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:42:44 +00:00
Andrew Nacin
173806d7a1
Restore the Description field to the media UI in 3.5.
...
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.
Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.
Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.
Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768 , this should be fixed. For now, Description stays.
This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984 ). So, here is a more obvious 'workaround' for the tooltip community.
Finally, this:
* Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
* Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
* Hides the 'Describe this file...' placeholder when a field is read-only in the modal.
props nacin, helenyhou.
fixes #22759 .
git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:41:06 +00:00
Andrew Nacin
a13a011265
Translate the 'First Steps with WordPress' Codex link. props SergeyBiryukov, fixes #22767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:51:24 +00:00
Andrew Nacin
ce11438e77
Media list table: Fix the categories column, hidden thanks to a typo. props eddiemoya, fixes #22764 . see #21240 , #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:49:51 +00:00
Andrew Nacin
2763e74dd8
Script loader: Chunk the script names as passed to load-scripts.php into 128-character pieces. Avoids hitting a limit for the length of a single variable, such as suhosin.get.max_value_length which defaults to 512. fixes #22757 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 18:57:56 +00:00
Mark Jaquith
bc8ddb3e64
Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613
...
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:29:24 +00:00
Bot (Assets)
1077e9ce03
Compress scripts/styles: 3.5-RC3-23059.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:58:34 +00:00
Andrew Nacin
40ae89369f
Admin ajax: Roll back new-style error sending in set-post-thumbnail. The JS handlers know to parse an unrecognized response (like -1 or 0) as a failure. see #21776 . see #22750 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:34:00 +00:00
Andrew Nacin
dc9e6144be
Fix inserting of multiple attachments with captions when the first attachment does not have a caption. props azaozz. fixes #22720 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:59:25 +00:00
Andrew Nacin
aaf5d77d35
Remove options-privacy.php, as intended by [21838]. see #16416 . see #22349 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:16:54 +00:00
Andrew Nacin
0bd02ac6bb
Use correct button class hierarchy to ensure the 'Update' button is button-large. see #21598 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:02:25 +00:00
Andrew Nacin
36554dd983
Move utils.js (cookie and user setting functions) to wp-includes to enable front-end use.
...
Make it a dependency of media-views (and therefore media-editor). Move its userSettings JS object from admin-header to being paired with the script in script loader.
see #22730 .
git-svn-id: http://core.svn.wordpress.org/trunk@23036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:29:56 +00:00
Ryan Boren
a200c702e0
Only show Delete in media modal if the user can delete.
...
Props nacin, koopersmith
fixes #22711
git-svn-id: http://core.svn.wordpress.org/trunk@23032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:33:51 +00:00
Bot (Assets)
32c83140d0
Compress scripts/styles: 3.5-RC3-23025.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 16:25:14 +00:00
Andrew Nacin
d2a9957ad8
Media: Disable 'Insert gallery' and 'Set featured image' if nothing is queued. Converts selection toolbars to use the newer view manager. props koopersmith, fixes #22714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 16:21:57 +00:00
Andrew Nacin
f82679b3ad
Update the 'Retina Ready' screenshot on the about page to reflect version 3.5, Twenty Twelve, and such. It's the little things. props lessbloat. fixes #22455 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 15:04:19 +00:00
Andrew Nacin
13c9bb4d38
About page: Update retina screenshot to remove the old Upload/Insert icon from QuickPress. props lessbloat. see #22455 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 07:28:39 +00:00
Bot (Assets)
a1bb2f0054
Compress scripts/styles: 3.5-RC2-23018.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 06:58:31 +00:00
Andrew Ozz
f803bad096
Editor: add sanity limit for editor height of 5000px, save only when resizing the Visual or the Text editor, fixes #22708
...
git-svn-id: http://core.svn.wordpress.org/trunk@23016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 06:01:47 +00:00
Andrew Nacin
a052c19497
Missing RTL for [21944]. props helenyhou. fixes #22707 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 05:06:24 +00:00
Andrew Nacin
3e1f7a6ef4
Updated media screenshot for the about page. props lessbloat. fixes #22455 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:13:30 +00:00
Andrew Nacin
3422c8deb6
RTL support for Masonry on the custom header page. fixes #22709 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:08:32 +00:00
Bot (Assets)
30cf064068
Compress scripts/styles: 3.5-RC2-23007. props koopersmith. :-)
...
git-svn-id: http://core.svn.wordpress.org/trunk@23007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 01:29:58 +00:00
Ryan Boren
61a9471024
Final round of media UX improvements.
...
Props koopersmith
fixes #21390 #22502
git-svn-id: http://core.svn.wordpress.org/trunk@23006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 01:26:03 +00:00
Andrew Nacin
9a1ef788ce
RTL fixes for the tags meta box and two search inputs. props SergeyBiryukov. fixes #22707 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 00:47:54 +00:00
Ryan Boren
63662a9b7b
In the QuickPress media modal, use the new post id when a post is published.
...
Props nacin, koopersmith
fixes #22673
git-svn-id: http://core.svn.wordpress.org/trunk@22994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 07:17:10 +00:00
Bot (Assets)
b8a9b78359
Compress scripts/styles: 3.5-RC2-22988.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 05:42:30 +00:00
Andrew Nacin
105cf57225
In Firefox, style placeholder text a dark gray since the browser doesn't do it for us. props helenyhou, fixes #22689 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 05:17:23 +00:00
Andrew Nacin
787e7f8347
When creating a network, use get_home_path() to calculate where .htaccess (or web.config) lives. fixes #22639 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 03:42:02 +00:00
Andrew Nacin
e0587d894e
Remove errant space.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 02:59:04 +00:00
Andrew Nacin
f74e41b389
Correctly calculate the location of wp-config.php, used in the instructions for setting up a network. see #22639 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 02:54:29 +00:00
Andrew Nacin
5d0933d884
Bring Featured Images back into the main media dialog.
...
Most users don't realize that the Featured Image meta box exists; if they do, few use it.
Restores the old meta box UI, including the admin_post_thumbnail_html filter. If a plugin is using _wp_post_thumbnail_html() in conjunction with Thickbox elsewhere, it will also magically still work.
Specific underlying changes:
* Converts the modal view to use the view manager, which means that a call to open() will automatically call render and attach if necessary.
* Doesn't automatically set a state in wp.media, to allow code to customize the states to be added before activation.
props koopersmith.
fixes #21776 .
git-svn-id: http://core.svn.wordpress.org/trunk@22979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 02:38:10 +00:00
Andrew Nacin
3f532c3bd8
Customizer: Ensure that the 'Collapse' button is styled properly (overridding the admin button style). props helenyhou. fixes #22684 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 00:42:11 +00:00
Andrew Nacin
27bf82201b
Allow the 'Uploaded to this post' view to be sorted, saving the resulting order as menu_order.
...
This functionality is designed to be backwards compatible with manual querying for attachments by menu_order.
props koopersmith.
see #22607 .
git-svn-id: http://core.svn.wordpress.org/trunk@22967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 16:06:31 +00:00
Ryan Boren
b7b54c00e9
Namespace the dashboard widget nonce to avoid collisions with plugins.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 00:12:43 +00:00
Ryan Boren
847f435e9f
Directly access post_status instead of using get_post_status() when checking for auto-draft status. Attachments with their inherit post_status were getting the auto-draft status of their parent when using get_post_status(). This caused some things to display improperly on the edit attachment page.
...
Props nacin, miqrogroove
fixes #22672
git-svn-id: http://core.svn.wordpress.org/trunk@22963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-01 23:12:30 +00:00
Andrew Nacin
cb3b72f3be
Remove stray single quote in attachment_submit_meta_box(). props Yogi T. fixes #22674 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-01 18:59:16 +00:00
Ryan Boren
22bc8cc437
Properly pass WordPress uploading errors to wp.Uploader.
...
Props koopersmith
fixes #22655
git-svn-id: http://core.svn.wordpress.org/trunk@22954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:40:09 +00:00
Bot (Assets)
41db8c91ff
Compress scripts/styles: 3.5-RC2-22953. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:20:51 +00:00
Ryan Boren
f07c7f5163
Refine media state machine methods.
...
* state( id ) becomes setState( id )
* get( id ) becomes state( id )
* state() stays the same
* previous() becomes lastState()
Props koopersmith
fixes #22652
git-svn-id: http://core.svn.wordpress.org/trunk@22952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:19:11 +00:00
Ryan Boren
ea3e47bc08
Add a create_posts check to _wp_translate_postdata(). Move the edit_post check to the top of the function.
...
Props nacin
fixes #22417
git-svn-id: http://core.svn.wordpress.org/trunk@22950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 14:03:47 +00:00
Bot (Assets)
0924e6facd
Compress scripts/styles: 3.5-RC2-22949.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:52:16 +00:00
Ryan Boren
d4abd95449
Scope button classes so they can be used on the frontend without interfering with theme styles.
...
Props helenyhou, koopersmith
fixes #22644
git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:40:59 +00:00
Ryan Boren
c7c590ce3c
RTL fixes for media and color picker.
...
Props ocean90
see #22453
git-svn-id: http://core.svn.wordpress.org/trunk@22947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:34:16 +00:00
Ryan Boren
4c22897819
Update permalink structure input when selecting a structure with the radio buttons.
...
Props nacin
fixes #22645
git-svn-id: http://core.svn.wordpress.org/trunk@22931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 00:01:26 +00:00
Andrew Nacin
24b82f2c3b
Nonces for dashboard controls.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 00:01:02 +00:00
Ryan Boren
27d943786b
Introduce API to add back the description field in the new media popup.
...
Props nacin
fixes #22642
git-svn-id: http://core.svn.wordpress.org/trunk@22929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 23:52:30 +00:00
Andrew Nacin
ee158786ba
Media help. props DrewAPicture, merty, Ipstenu. fixes #22451 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 17:51:54 +00:00
Bot (Assets)
53bdcd5b63
Compress scripts/styles: 3.5-RC1-22922.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 16:17:06 +00:00
Andrew Nacin
ef662a5822
Use jQuery .html() when processing HTML.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 02:42:06 +00:00
Andrew Nacin
7e13a6656c
Verify attachment parent during upload.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 02:39:34 +00:00
Andrew Nacin
a8d599eae5
Fix disabling of the link manager on upgrade from 3.4.2 when there are no links.
...
In the 3.4 branch we bumped the DB version past the version used for disabling links in trunk, preventing it from running. In the future, we must avoid increasing branch DB version bumps to HEAD.
props SergeyBiryukov.
fixes #22626 .
git-svn-id: http://core.svn.wordpress.org/trunk@22911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 00:37:30 +00:00
Bot (Assets)
cbd32060e8
Compress scripts/styles: 3.5-RC1-22909.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 22:58:34 +00:00
Andrew Nacin
61caecfa93
Use the create_posts post type cap in more places. Remove the janky create_posts meta cap. see #16714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 22:28:20 +00:00
Andrew Nacin
346e45c56b
Adjust size of the 'Clear List' list table button. Fix placement of other buttons next to bulk actions. props johnbillion, SergeyBiryukov, fixes #22621 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 22:20:45 +00:00
Andrew Nacin
7322ea40d6
Reorganize and polish the About WordPress 3.5 screen. Offer strings for translation.
...
props lessbloat, helenyhou, markjaquith, nacin.
fixes #22455 .
git-svn-id: http://core.svn.wordpress.org/trunk@22903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 21:00:09 +00:00
Ryan Boren
ea0d28db29
Route uploads through async-upload.php instead of admin-ajax.php.
...
Props nacin, koopersmith
fixes #22622
git-svn-id: http://core.svn.wordpress.org/trunk@22902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 20:17:57 +00:00
Andrew Nacin
f63e0b1df9
Use create_posts whenever linking to post-new.php. props johnbillion. fixes #16714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 18:24:11 +00:00
Andrew Nacin
6074924272
Don't label the form on media-new.php an upload form to avoid esoteric breakage. In past lives, the form has been more complicated than the standard .wp-upload-form use case, with submit buttons that are not just for the uploader, which means we really can't disable them here.
...
Reverts part of [22663]. see #20855 .
git-svn-id: http://core.svn.wordpress.org/trunk@22880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 22:41:15 +00:00
Bot (Assets)
f940c40302
Compress scripts/styles: 3.5-RC1-22879. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 20:58:37 +00:00
Andrew Nacin
45ce9d2a96
Media: Introduce wp.media.editor.open(editor_id) and leverage it in distraction-free writing (fullscreen). props azaozz, koopersmith. fixes #22541 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 19:09:00 +00:00
Andrew Nacin
fe3ace4f05
Feature pointers:
...
* Finalize the text for the media pointer. Offer it for translation.
* Remove the favorites pointer.
fixes #22454 .
git-svn-id: http://core.svn.wordpress.org/trunk@22874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 18:58:07 +00:00
Bot (Assets)
735c64c965
Compress scripts/styles: 3.5-RC1-22873.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 16:58:37 +00:00
Ryan Boren
cc9b248937
Always send nocache_headers() for admin-ajax.php. This prevents iOS from caching ajax calls. http://stackoverflow.com/questions/12506897/is-safari-on-ios-6-caching-ajax-results
...
Turn off multi selection uploads for mobile devices. Currently Plupload cannot upload multiple files in iOS Safari. Only the first file makes it to the queue.
Empty wp on unload to work around caching in iOS Safari.
Props azaozz, miqrogroove, nacin
fixes #22552
git-svn-id: http://core.svn.wordpress.org/trunk@22872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 16:17:53 +00:00
Ryan Boren
c1bd9e3795
Show plugin activation message when activating a network only plugin on a single site installation.
...
Props nacin
fixes #22576
git-svn-id: http://core.svn.wordpress.org/trunk@22871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 16:08:35 +00:00
Ryan Boren
939a47ba48
Add a delete link to the media modal.
...
Props merty, nacin, koopersmith
fixes #22524
git-svn-id: http://core.svn.wordpress.org/trunk@22869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:50:59 +00:00
Ryan Boren
11c5f2c1fc
Only show the image edit button for image attachments. Props markoheijnen. fixes #22596
...
git-svn-id: http://core.svn.wordpress.org/trunk@22867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:06:02 +00:00
Ryan Boren
adae728f00
Fix dragging in IE10 on touch devices.
...
Props georgestephanis, koopersmith
fixes #22583
git-svn-id: http://core.svn.wordpress.org/trunk@22866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:00:00 +00:00
Ryan Boren
d4159bf041
In wp_image_editor(), use wp_image_editor_supports() to check for rotation capabilities rather than directly checking the existence of the imagerotate function.
...
In WP_Image_Editor_GD::test(), check for existence of imagerotate if the rotate capability is required.
Props DH-Shredder
fixes #22597
git-svn-id: http://core.svn.wordpress.org/trunk@22863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 14:36:55 +00:00
Andrew Nacin
902314ad3c
No AYS or autosave for attachments on post.php. Reverts part of [22725]. fixes #22491 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 02:02:32 +00:00
Ryan Boren
cef5227d7f
Rather than question ourselves, exclaim!
...
Props PotterSys
see #22455
git-svn-id: http://core.svn.wordpress.org/trunk@22856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 00:27:36 +00:00
Ryan Boren
e55bebac25
Show a better message ondmins on link-manager.php, link-add.php, link.php when links are disabled.
...
Props nacin
fixes #22569
git-svn-id: http://core.svn.wordpress.org/trunk@22855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 00:20:27 +00:00
Ryan Boren
eb404cc867
Consolidate some strings. Props SergeyBiryukov. see #21087
...
git-svn-id: http://core.svn.wordpress.org/trunk@22854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 23:12:11 +00:00
Ryan Boren
b7c0d84c7f
In media_upload_flash_bypass(), pass the post id in the media-new.php url.
...
In media-new.php, use post_id from REQUEST if passed and the current user can edit the post.
Fixes adding media with the browser uploader.
Props nacin, ocean90
fixes #22572
git-svn-id: http://core.svn.wordpress.org/trunk@22853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 23:10:19 +00:00
Andrew Nacin
4e9e4bf2cf
Back compat for media_buttons_context, which is not the correct filter for adding new media buttons. If you want to add additional media buttons, use the media_buttons action instead. fixes #22559 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:32:35 +00:00
Ryan Boren
7df6a903f5
In wp.media.editor:send, revert back to the old field names used by media_upload_form_handler() for easier back compat.
...
Fix notices in wp_ajax_send_attachment_to_editor().
Props nacin, azaozz, miqrogroove
fixes #22553
git-svn-id: http://core.svn.wordpress.org/trunk@22847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:08:50 +00:00
Ryan Boren
5b94b6b43e
In media_buttons(), consult global post_ID if get_post() comes up with nothing.
...
Default postID to 0 in wp_enqueue_media().
Props nacin
fixes #22085
git-svn-id: http://core.svn.wordpress.org/trunk@22846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:03:37 +00:00
Andrew Nacin
c1e9ddd316
Don't use wp_send_json_* handlers in the upload-attachment XHR handler.
...
The difference is the content type: application/json (which jQuery deserializes automatically for us) and the default text/html.
jQuery correctly handles application/json requests for IE, so we can continue to use the wp_send_json_* handlers elsewhere. Plupload rolls its own requests and does not handle application/json correctly. So, keep the standard text/html content type on upload-attachment.
props koopersmith.
see #22446 .
git-svn-id: http://core.svn.wordpress.org/trunk@22845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 20:12:50 +00:00
Andrew Nacin
ab5c08a120
Media: When inserting an attachment, if the item is unattached (no post_parent), attach it to the post. fixes #22085 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 16:34:42 +00:00
Ryan Boren
8dc401468e
Make is_upload_space_available() available for front end page loads. Fixes fatal error when calling wp_editor() from the front end.
...
Props scribu, itworx
fixes #22585
git-svn-id: http://core.svn.wordpress.org/trunk@22840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 14:42:43 +00:00
Bot (Assets)
a4c7232ce6
Compress scripts/styles: 3.5-RC1-22839.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 03:47:40 +00:00
Andrew Nacin
262ee531cb
Only pass the current screen to the list table constructor when we have a screen to work with. This is not the case for admin-ajax requests. fixes #22570 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 03:39:29 +00:00
Andrew Nacin
bfce253d49
Media: Remove vestige CSS that prevents thumbnails from always showing on media-new.php. props duck_. fixes #22547 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 03:37:25 +00:00
Andrew Nacin
450b96a773
Use correct variable in wp_ajax_save_attachment(). see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 02:50:01 +00:00
Ryan Boren
52dcf95dcd
Gettext markup for a welcome screen string. Props SergeyBiryukov, xibe. fixes #22546
...
git-svn-id: http://core.svn.wordpress.org/trunk@22831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-23 16:42:31 +00:00
Andrew Ozz
cc58c611ec
Do not optimize/smush/ImageOptim GIFs. Most are either not reduced in size or reduced only couple of bytes but the optimization messes with the transparency/matte. Fixes #22536 , see #22381
...
git-svn-id: http://core.svn.wordpress.org/trunk@22829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 19:08:22 +00:00
Andrew Nacin
efd9913490
Mustn't forget to hide the legacy media uploader! see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 13:23:27 +00:00
Bot (Assets)
2430f0f974
Compress scripts/styles: 3.5-beta3-22819.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 10:58:36 +00:00
Andrew Nacin
9120cf3375
WP_Image_Editor: the last stand.
...
* Have wp_get_image_editor() rather than WP_Image_Editor::get_instance(). Having static factory methods would be less confusing if there weren't also static methods tied to individual editor implementations.
* Lazy-load the WP_Image_Editor base class and editor implementations.
* Have WP_Image_Editor_GD::supports_mime_type() actually check which types it supports.
* Deprecate gd_edit_image_support() in favor of wp_image_editor_supports().
props DH-Shredder, scribu, markoheijnen. fixes #22356 . see #6821 .
git-svn-id: http://core.svn.wordpress.org/trunk@22817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 09:52:16 +00:00
Andrew Nacin
67b5e59b68
Two initial feature pointers for WordPress 3.5: plugin favorites and the media dialog. One offered for translation. props nacin, lessbloat, DrewAPicture. see #22454 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 09:24:11 +00:00
Andrew Nacin
de95e1498e
About page for WordPress 3.5, first pass. Not yet offered for translation. props lessbloat, johnbillion. see #22455 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 09:16:26 +00:00
Andrew Nacin
c760270ca6
Updates to post.php help text for posts and pages, including a new section on inserting media. props DrewAPicture, Ipstenu. see #22451 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 09:00:39 +00:00
Andrew Nacin
9bba27f4e5
Fix various typos and omissions across a number of help tabs. props DrewAPicture, Ipstenu. see #22451 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 08:45:15 +00:00
Bot (Assets)
3006ca6a6c
Compress scripts/styles: 3.5-beta3-22808.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 04:58:35 +00:00
Daryl Koopersmith
0d08430cfe
Media: Replace the thumbnail on post.php using a request variable instead of the referer. props ocean90. fixes #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 03:43:16 +00:00
Bot (Assets)
3be0694d83
Compress scripts/styles: 3.5-beta3-22801.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 22:58:36 +00:00
Dion Hulse
bcbfb232f7
Correct get_home_path() for cases where WordPress is installed in a subdirectory called /wp/, previously it would match on /wp-admin instead of /wp causing an incorrect return path. Props SergeyBiryukov. Fixes #20449
...
git-svn-id: http://core.svn.wordpress.org/trunk@22800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 22:39:59 +00:00
Andrew Nacin
67530d0154
Fix action link styling in IE7 and IE8. props SergeyBiryukov. fixes #22467 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 22:34:08 +00:00
Andrew Ozz
bc2f40d303
Fix typo in [22795]
...
git-svn-id: http://core.svn.wordpress.org/trunk@22796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 21:16:19 +00:00
Andrew Ozz
522376a1f1
Improve AYS comparison on the Edit Attachment screen, props nacin, fixes #22491
...
git-svn-id: http://core.svn.wordpress.org/trunk@22795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 21:11:21 +00:00
Bot (Assets)
f328a74f77
Compress scripts/styles: 3.5-beta3-22793.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 21:03:21 +00:00
Andrew Nacin
c1467fb68d
Revert [22767] and fix icon alignment issues in the sprites themselves. props lessbloat. fixes #22527 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 19:17:01 +00:00
Andrew Nacin
55a6c62e76
Support attachment_fields_to_save and attachment_fields_to_edit for attachments going through post.php. see #22186 . see #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 18:53:00 +00:00
Andrew Nacin
dfb844b64b
Remove legacy media uploader bits from custom-header.php and custom-background.php. see #22186 , #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 17:44:49 +00:00
Andrew Nacin
f26102a248
Redirect post-new.php?post_type=attachment to media-new.php. see #22491 , #22083 , #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 17:40:53 +00:00
Daryl Koopersmith
cfdea9673b
Media: Move the new sections of media-upload.js to media-editor.js to allow the media modal to be used on the front end and prevent dependency conflicts with older themes and plugins. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 16:46:32 +00:00
Peter Westwood
ecbbb81587
Posting: Improve the capability checking _wp_translate_postdata() when updating posts.
...
* Use the specific post_type's 'edit_post' cap
* Pass the ID of the post being edited.
Fixes #22417
git-svn-id: http://core.svn.wordpress.org/trunk@22769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 16:34:57 +00:00
Daryl Koopersmith
bfc8690006
Media: Backwards compatibility for the many send_to_editor filters. props nacin. see #22186 , #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 16:02:20 +00:00
Andrew Nacin
f1752a5568
Move the admin menu icons up one pixel, to restore their 3.4 positioning. props lessbloat. fixes #22527 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 15:37:43 +00:00
Andrew Nacin
9b54e5c380
Have the media modal direct users to media-new.php for the browser uploader. fixes #22444 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 15:30:48 +00:00
Andrew Nacin
229a919b27
media-new.php: Remove unused scripts, strings, error handling, save handling, and save button. fixes #22083 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 15:10:17 +00:00
Bot (Assets)
852d90b3d6
Compress scripts/styles: 3.5-beta3-22763.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 14:58:31 +00:00
Daryl Koopersmith
e0ebe09802
Media: Backwards compatibility for the disable_captions filter. see #22186 , #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 14:27:22 +00:00
Daryl Koopersmith
4d01db3f0a
Media: Use the wp.media.string functions when generating embed strings. Embed captions now work. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 14:20:01 +00:00
Andrew Nacin
75c464671d
Revert accidental changes to admin/includes/media.php in [22755]. see #22083 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 14:04:24 +00:00
Daryl Koopersmith
c901a4825e
Media: Make the attachment object optional when using the wp.media.string methods. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 13:53:15 +00:00
Andrew Nacin
1935e74233
Properly nest the if tag. props helenyhou. see #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 13:32:26 +00:00
Daryl Koopersmith
7a4b96d78f
Customizer: Track the link that was used to open the customizer and restore focus on close. props lessbloat. fixes #21283 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 13:17:10 +00:00
Andrew Nacin
e276fc44be
Have media-new.php return simple rows of basic attachment data, with an 'Edit' link next to each taking them to post.php (in a new window). Not ideal, but this is largely a fallback screen at this point.
...
This is bolted on to existing code, the vast majority of which is destined to be ripped out in 3.6 once things settle.
see #22083 .
git-svn-id: http://core.svn.wordpress.org/trunk@22755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 13:05:44 +00:00
Andrew Nacin
07a0349e2c
Remove cruft from media-new.php. No need to keep extra parameters around (including post ID, which is always 0 here). see #22083 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 12:27:12 +00:00
Andrew Nacin
f6b9a928e5
Split media-new.php and media-upload.php into distinct files.
...
* media-new.php will remain the entry point for uploading isolated files, and for using the browser-based uploader (versus Plupload).
* media-upload.php is the legacy (pre-3.5) media uploader.
see #22083 .
git-svn-id: http://core.svn.wordpress.org/trunk@22751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 12:19:40 +00:00
Andrew Nacin
96576a2dca
Properly refresh the thumbnail on post.php after an image edit. props ocean90. see #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 12:05:24 +00:00
Andrew Nacin
9ad10730c0
Non-images don't have alternative text. props helenyhou. see #21391 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 12:03:35 +00:00
Andrew Nacin
8f3a9e1907
Stop inserting title attributes for images inserted into the editor by modifying get_image_send_to_editor(), not the generic get_image_tag().
...
see #18984 , [22409].
git-svn-id: http://core.svn.wordpress.org/trunk@22747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 11:50:30 +00:00
Daryl Koopersmith
ff482e86fb
Media: Add filters for image-only libraries. see #22514 , #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 11:04:23 +00:00
Daryl Koopersmith
5b11aea8f5
Media: Dynamically generate attachment filters using get_post_mime_types().
...
Moves `get_post_mime_types()` from `wp-admin/includes/post.php` to `wp-includes/post.php`.
fixes #22514 , see #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 10:18:59 +00:00
Andrew Nacin
51f2e14b46
Use a variable that is set a few lines up. $post_id is set only in post.php, not post-new.php. fixes #21092 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 09:35:23 +00:00
Andrew Nacin
418c9985f7
Media: For pages, use 'Insert into page' rather than 'Insert into post'.
...
Custom post types can use the media_view_strings filter. No new post type "labels" for now.
see #22712 . see #21092 (and #19696 ).
git-svn-id: http://core.svn.wordpress.org/trunk@22735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 23:22:03 +00:00
Bot (Assets)
6764610cbb
Compress scripts/styles: 3.5-beta3-22734.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 22:58:28 +00:00
Andrew Nacin
0b8e9af39a
Color picker: Instant feedback when typing a color. Strengthens alt + arrows for moving around the palette. props mattwiebe. fixes #22475 . fixes #22388 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 22:02:09 +00:00
Andrew Nacin
e9f355e623
Customizer: Let return/enter fire click events for dropdowns and links. Remove errant focus event. Re-add box shadow and border for the overlay header. props lessbloat. see #21283 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 21:25:54 +00:00
Andrew Ozz
769e1236af
Skip To links: visually hide by only setting top: -1000em; (this should make them work well in all screen readers), fixes #21312
...
git-svn-id: http://core.svn.wordpress.org/trunk@22730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 21:14:49 +00:00
Bot (Assets)
4d00db15b4
Compress scripts/styles: 3.5-beta3-22729.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 20:58:28 +00:00
Andrew Nacin
0656bbd3ab
Use standard link colors with the skip links. see #21310 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 20:25:54 +00:00
Andrew Ozz
32ef39f0f6
Skip links: simplified look with more contrast, props sabreuse, fixes #21310
...
git-svn-id: http://core.svn.wordpress.org/trunk@22726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 19:58:47 +00:00
Andrew Ozz
0e38402629
Don't load autosave.js on the attachment editing screen, add simple AYS on unload if there are changes, props helenyhou, fixes #22491
...
git-svn-id: http://core.svn.wordpress.org/trunk@22725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 19:46:38 +00:00
Bot (Assets)
0bc99fe9f5
Compress scripts/styles: 3.5-beta3-22724.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:58:31 +00:00
Andrew Nacin
3da5e3a7fc
Fix up the 'Attach' dialog on upload.php.
...
We are de-emphasising attaching (see [22630]) but this is existing
core functionality and will remain for now. This commit just cleans
it up a bit so as to be less embarrassing.
props lessbloat, helenyhou.
fixes #20164 .
git-svn-id: http://core.svn.wordpress.org/trunk@22723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:50:15 +00:00
Andrew Nacin
d6c85b1373
IE RTL fixes for .screen-reader-text. props lessbloat. see #22467 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:26:32 +00:00
Andrew Nacin
7e0061375a
No-JS fixes.
...
* Hide QuickPress.
* Hide the gap between the title and content editor.
* Hide 'select all' checkboxes in list tables.
* Hide a non-functioning link in the custom fields metabox.
* Hide non-functioning buttons in the featured image box (same as in 3.4).
* RTL and miscellany.
props TobiasBg, lessbloat, ocean90. fixes #22456 .
git-svn-id: http://core.svn.wordpress.org/trunk@22719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:20:14 +00:00
Bot (Assets)
530d5248f7
Compress scripts/styles: 3.5-beta3-22717.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 14:58:32 +00:00
Daryl Koopersmith
00377a42f4
Media: Remove default gallery shortcode attributes when generating shortcode output. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 14:38:20 +00:00
Daryl Koopersmith
3f630bf0fa
Media: Correctly fetch the default post ID when editing a gallery. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 14:33:48 +00:00
Daryl Koopersmith
e25565f4b7
Media: Allow all galleries to be sortable. fixes #22488 , see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 14:04:59 +00:00
Bot (Assets)
38b7b820aa
Compress scripts/styles: 3.5-beta3-22701.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:58:28 +00:00
Daryl Koopersmith
b75ec467b2
Media: Whoops. Remove error_log. see [22699], #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:40:31 +00:00
Daryl Koopersmith
b1f720c616
Media: Improve media buttons on the front end.
...
* Use a less specific selector (the body, actually) to delegate opening the media dialog.
* Allow the editor ID to be the empty string so the `media_buttons` action can be called without arguments.
see #22284 , #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:35:30 +00:00
Andrew Nacin
cb9485a772
Color Picker keyboard accessibility. So awesome. props lessbloat, mattwiebe. see #22475 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:02:07 +00:00
Andrew Nacin
1d7a837f38
Welcome panel IE fixes. props SergeyBiryukov, see #19687 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 01:56:45 +00:00
Andrew Nacin
83eeb80dfb
Custom Header: Remove Farbtastic-era "Reset Text Color" button. Show default color when JS is disabled. props DrewAPicture. fixes #22461 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 01:53:59 +00:00
Andrew Nacin
c185f0c9bd
Use correct variable. see #17860 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 21:43:47 +00:00
Andrew Nacin
fa76d11e93
As wp_dropdown_roles() only prints editable roles, ensure that the
...
"selected" role passed into it on the user-edit screen is editable.
props johnjamesjacoby. see #22361 .
git-svn-id: http://core.svn.wordpress.org/trunk@22687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 19:23:54 +00:00
Andrew Nacin
d88922565e
Less insane multiple role handling in the users list table.
...
If the user has more than one role, opt to show the first role that is
'editable', if present. Otherwise, fall back to the remaining roles.
In the future, we should show a comma-separated list of all roles,
editable or otherwise, and this list should be filterable, either by user,
or by the roles which can appear. Probably both.
In multisite, only hide users that have no capabilities (in case they
possess a leftover, empty wp_xx_capabilities key from the MU days),
not users that have no role, as they may have a cap but no role.
see #22361 . fixes #17860 .
git-svn-id: http://core.svn.wordpress.org/trunk@22686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 19:16:31 +00:00
Bot (Assets)
63930c9404
Compress scripts/styles: 3.5-beta3-22683.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 10:58:31 +00:00
Andrew Nacin
6aabe72fe0
IE sanity for the welcome panel. props lessbloat, JustinSainton. fixes #19687 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 09:53:31 +00:00
Andrew Nacin
4b9ef4ee05
Remove errant return. props SergeyBiryukov. see #22186 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 09:48:34 +00:00
Bot (Assets)
fa3497237b
Compress scripts/styles: 3.5-beta3-22678.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:58:31 +00:00
Andrew Nacin
bd158c503f
Move code from image_attachment_fields_to_edit() to get_attachment_fields_to_edit(). The level of abstraction is unnecessary, and it makes it more difficult to call only the filter in the new media modal. Also, that function is sloooow. see #22186 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:10:38 +00:00
Daryl Koopersmith
fe1e4e3f56
Media: Insert each attachment into the editor individually.
...
This allows the `wpeditimage` plugin to correctly identify `caption` shortcodes.
fixes #22459 , see #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 07:30:53 +00:00
Andrew Nacin
479d27013a
Avoid doing all of the extra work in get_attachment_fields_to_edit() for fields we will just discard. We just need the filter, and the taxonomies. see #22186 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 07:20:47 +00:00
Bot (Assets)
f8b7c4ee59
Compress scripts/styles: 3.5-beta3-22668.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:58:29 +00:00
Daryl Koopersmith
bda3b4c53d
Media: Properly display selected featured image data if the featured image is not in the first section of the library. see #22494 , #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:56:54 +00:00
Daryl Koopersmith
b222046481
Media: Blur the "Add Images" button when the media modal is opened. fixes #22445 , see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:34:41 +00:00
Andrew Nacin
f5e7edf2f2
Add manual new lines to a string, as double quotes with \n is not optimal due to sprintf-parsing reasons. props SergeyBiryukov, fixes #22486 . see #22260 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:11:42 +00:00
Andrew Nacin
e3069d9d62
Re-enable a .wp-upload-form submit button whenever any file input in that form has a file selected, to minimize the potential for issues. props kovshenin. fixes #20855 . see [22459].
...
git-svn-id: http://core.svn.wordpress.org/trunk@22663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:07:04 +00:00
Bot (Assets)
29a9b52ca9
Compress scripts/styles: 3.5-beta3-22657. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 02:58:28 +00:00
Andrew Nacin
97032e08aa
Revert page on front changes. Reverts [22127] [22129] [22135] [22136]. see #16379 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 01:28:32 +00:00
Bot (Assets)
cae8ce47fc
Compress scripts/styles: 3.5-beta3-22650.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 00:58:49 +00:00
Andrew Nacin
47dfed43b4
Blue admin color scheme fixes. Fix admin menu styling. props melchoyce, helenyhou. fixes #22248 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 23:49:54 +00:00
Andrew Nacin
d0768e2d23
Fix QuickPress submission spinner. props ocean90. fixes #22496 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 23:46:01 +00:00
Bot (Assets)
ec8890d9a1
Compress scripts/styles: 3.5-beta3-22642.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 16:58:30 +00:00
Andrew Ozz
9ae963d9a7
RTL: fix styling of Skip To links, see #22453
...
git-svn-id: http://core.svn.wordpress.org/trunk@22641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 16:49:17 +00:00
Andrew Ozz
e09ea56a23
RTL fixes and improvements: add-media, image-editor, the spinners, the featured image button, some css cleanup, props ocean90, maor, SergeyBiryukov, ramiy, see #22453
...
git-svn-id: http://core.svn.wordpress.org/trunk@22640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 16:19:37 +00:00
Bot (Assets)
bc796cd26e
Compress scripts/styles: 3.5-beta3-22639.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 22:58:30 +00:00
Andrew Ozz
c4fd7d119b
Welcome screen: clean up the css, improve the html, add RTL styles, props helenyhou TobiasBg ocean90, fixes #21368 , see #22453
...
git-svn-id: http://core.svn.wordpress.org/trunk@22638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 21:51:39 +00:00
Bot (Assets)
85afdd2ef7
Compress scripts/styles: 3.5-beta3-22637.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 20:58:31 +00:00
Andrew Ozz
981419d292
Make the admin menu and toolbar work well on mobile devices (take 2), props georgestephanis, fixes #20614 , fixes #22382
...
git-svn-id: http://core.svn.wordpress.org/trunk@22636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 20:14:17 +00:00
Ryan Boren
06ee370814
Pinking shears
...
git-svn-id: http://core.svn.wordpress.org/trunk@22634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 15:11:29 +00:00
Andrew Nacin
dc0786c0ae
Pull the list of popular importers from WordPress.org.
...
These are the importers we suggest on import.php, prompting the user to
install the relevant plugin for the import they want to go through.
If the API is inaccessible, it falls back to a hard-coded list that should
be kept sync'd with the API with each major version of WordPress. This API
enables us to add new importers between releases, as they are completed or
if services gain quick adoption. As a last resort, we can also temporarily
disable importers that are broken (due to API changes, for example).
The importer currently returns English strings (which are then run through
translate() for existing strings), but the locale is passed to the API,
allowing us to ship translated strings if we wish to be adventurous.
props dllh for the assist.
fixes #18977 .
git-svn-id: http://core.svn.wordpress.org/trunk@22632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 07:20:04 +00:00
Bot (Assets)
fbc68cd7c6
Compress scripts/styles: 3.5-beta3-22631.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:58:29 +00:00
Andrew Nacin
c5f94e316e
Media Library list table: Rename 'Attached to' to 'Uploaded to'.
...
In 3.5, we have chosen to de-emphasize the "attaching" part of the
post-attachment relationship. Existing functionality remains the same,
but UI emphasis is now placed on "parent" being where the item was
originally uploaded.
fixes #22439 .
git-svn-id: http://core.svn.wordpress.org/trunk@22630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:56:05 +00:00
Andrew Nacin
7183a9cce9
Introduce a new, cross-browser HiDPI CSS @media rule to be used everywhere.
...
{{{
@media print,
(-o-min-device-pixel-ratio: 5/4),
(-webkit-min-device-pixel-ratio: 1.25),
(min-resolution: 120dpi) {
}}}
Serve HiDPI graphics for printing, regardless of screen resolution.
Specify Opera's vendor-prefixed device pixel ratio property, for Opera desktop.
Specify a minimum Webkit device pixel ratio of 1.25 instead of 1.5, to serve
2x images to Android devices that are between 1 and 1.5x (like the Nexus 7).
Firefox and Opera will respond to 1.5x on these devices, but Chrome will not.
Specify min-resolution, which covers Firefox 19. Opera on Android also supports
min-resolution, but Opera Mini does not support dppx, so the dpi unit is used.
props iammattthomas for the exhaustive research.
props lessbloat for patching.
fixes #22238 .
git-svn-id: http://core.svn.wordpress.org/trunk@22629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:50:08 +00:00
Andrew Nacin
0a888e8aa0
Prevent notices when post_id is not passed to the old media upload forms. props ldebrouwer. fixes #22465 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:42:14 +00:00
Andrew Nacin
7db73c3be2
Fix the padding of the waiting spinner when replying to comments. props lessbloat, SergeyBiryukov. fixes #22449 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:39:50 +00:00
Andrew Nacin
afd3c7eeb3
Fix minified RTL style loading via load-styles.php. props ocean90. fixes #22482 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 22:18:33 +00:00
Ryan Boren
33ac1bd021
Show the update nag in the network admin.
...
Props Mamaduka
fixes #20959
git-svn-id: http://core.svn.wordpress.org/trunk@22618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 21:52:48 +00:00
Bot (Assets)
a5641f8814
Compress scripts/styles: 3.5-beta3-22607. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 00:58:33 +00:00
Andrew Ozz
a19764fcdc
Editor: disable the textarea resizing handle on touch devices (cannot be used there), don't save TinyMCE's height in iOS as the user cannot set/change it there (it expands the iframe to full height), see #21718
...
git-svn-id: http://core.svn.wordpress.org/trunk@22606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 00:34:07 +00:00
Bot (Assets)
b26b39e3bc
Compress scripts/styles: 3.5-beta3-22596.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-15 02:58:37 +00:00
Andrew Nacin
52007a46c1
Round rather than floor values in image editing JS to avoid decrementing values on each run. props SergeyBiryukov. fixes #22011 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-15 02:20:29 +00:00
Bot (Assets)
29abff2525
Compress scripts/styles: 3.5-beta3-22584.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 22:58:34 +00:00
Andrew Nacin
d6813ffb35
For postboxes, only show arrows/handles on hover when JS is enabled (for HiDPI). props TobiasBg. fixes #21611 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 22:22:55 +00:00
Bot (Assets)
93b55dca26
Compress scripts/styles: 3.5-beta3-22572. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 15:00:31 +00:00
Andrew Nacin
f68b6006de
wp_generate_attachment_metadata() should not call WP_Image_Editor if there's nothing to resize. props mdawaffe. fixes #22438 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 14:26:52 +00:00
Daryl Koopersmith
3cfbf3c4bb
Media: Declare wp.media.string methods in a single object. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 09:31:53 +00:00
Daryl Koopersmith
fd6b847330
Media: Make edit gallery button use new media. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 09:06:10 +00:00
Daryl Koopersmith
b2db6270ee
Media: Restore 3.4 editor behavior and remove TinyMCE views.
...
* Reactivates the `wpgallery` and `wpeditimage` TinyMCE plugins. Deactivates the `wpviews` TinyMCE plugin.
* Moves still-relevant logic from `mce-views.js` to `media-upload.js` and `shortcode.js`.
* No longer include `wp-includes/js/mce-views.js`. This code will not be used in 3.5, and should be considered unstable.
* Currently, this is the real 3.4 experience; as such, editing triggers the old modals. Changing this is the next major step.
When reassessing views, we should look over all of these tickets and anticipate these bugs accordingly.
fixes #21813 , #22123 , #22155 , #22161 , #22257 , #22266 , #22318 , #22407 , see #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 07:17:22 +00:00
Andrew Nacin
7b74142364
Revert accordion-delay code from [22400] that was causing problems. props lessbloat. fixes #21283 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 05:03:33 +00:00
Daryl Koopersmith
5ed166d269
Media: Activate the featured image toolbar when the media dialog is first opened. see #21390 , #21776 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 02:39:54 +00:00
Ryan Boren
02d80201fa
In wp_crop_image(), preserve both src_file and src. src_file must be preserved even when url fopen is used so that we don't try to save to a filename based on the url.
...
see #6821
git-svn-id: http://core.svn.wordpress.org/trunk@22553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 00:03:55 +00:00
Bot (Assets)
8c60f41b2f
Compress scripts/styles: 3.5-beta2-22551. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-12 22:58:31 +00:00
Daryl Koopersmith
2d87f983ad
Media: Add Embed from URL tab.
...
Note: There is a bug that currently blocks adding several successive embeds.
see #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-12 05:57:12 +00:00
Bot (Assets)
e84d1f724d
Compress scripts/styles: 3.5-beta2-22546.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 22:58:32 +00:00
Daryl Koopersmith
1e19ec5fb4
Media in QuickPress: Ensure wpActiveEditor is set when the "Add Media" button is clicked. fixes #22021 , see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 01:40:47 +00:00
Daryl Koopersmith
82213846c3
Media: Add backwards compatibility for attachment_fields_to_edit and attachment_fields_to_save. see #22186 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 01:26:42 +00:00
Bot (Assets)
bbb099b2dd
Compress scripts/styles: 3.5-beta2-22540.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 22:58:34 +00:00
Ryan Boren
31e669df5a
Pass an attachment ID, not a file path, to _load_image_to_edit_path() from wp_crop_image(). This fixes handling of attachments that require url fopen to access the image.
...
Allow passing urls instead of just file paths to WP_Image_Editor_Imagick::load() and WP_Image_Editor_GD::load() so that attachments requiring URL fopen can be handled.
see #6821
git-svn-id: http://core.svn.wordpress.org/trunk@22538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 20:42:27 +00:00
Daryl Koopersmith
790464193d
Media: Add custom URL as an option to attachment display properties. see #21390 , #22206 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 20:36:46 +00:00
Andrew Ozz
e7a27494b7
Admin menu: sync the .folded and @media .auto-fold styles, fixes #21998
...
git-svn-id: http://core.svn.wordpress.org/trunk@22536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 19:41:12 +00:00
Daryl Koopersmith
30e0a600bf
Media: Add title, caption, and alt text, and attachment info to sidebar.
...
* Improve sidebar styles.
* Separate the hybrid title/caption field.
* Improve the sidebar image thumbnail.
* Remove filenames from inside the non-image icon thumbnail.
* Properly sync title/caption/alt.
see #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 18:25:04 +00:00
Andrew Nacin
e7767b1eba
Add comments to time intervals we cannot express with the constants. Fix a comment. props SergeyBiryukov. fixes #20987 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 18:13:09 +00:00
Daryl Koopersmith
ead998c57d
Media: Keep the selected featured image in the media modal in sync with the page. fixes #22404 , see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 08:40:35 +00:00
Daryl Koopersmith
bed08350f4
Media: Backwards compatibility for media_upload_tabs.
...
* Adds `createIframeStates()` to the `MediaFrame` view. It creates states and bindings for the `media_upload_tabs` output, and is included on `MediaFrame.Post` by default.
* Hijacks `tb_remove()` when the media modal is open to ensure the modal closes correctly.
* Adds a `chromeless` parameter to thickbox media tab URLs to render the UI without the old row of tabs.
see #22186 , #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 07:51:37 +00:00
Andrew Nacin
e14ff50cfb
Don't allow non-image uploads for custom headers and backgrounds. props kovshenin. fixes #22149 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 05:36:37 +00:00
Andrew Nacin
2d13e264a4
URLs should be esc_url(), not esc_attr().
...
git-svn-id: http://core.svn.wordpress.org/trunk@22520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 05:30:51 +00:00
Andrew Nacin
7ba61388a4
Use event delegation for Add Media, allowing the event to bubble up to #wpbody. Keeps the Add Media button functional on a second use of QuickPress. fixes #22255 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 04:39:44 +00:00
Andrew Ozz
b404fbdb85
QuickPress: add some JS to set wpActiveEditor when the title or content is focused, fixes #22021
...
git-svn-id: http://core.svn.wordpress.org/trunk@22517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 03:05:48 +00:00
Bot (Assets)
c57076aab7
Compress scripts/styles: 3.5-beta2-22515.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 22:58:35 +00:00
Andrew Nacin
e77ec92846
Customizer: Passes focus to the upload tab to avoid focus changing when a drag event occurs from outside the browser. props lessbloat. fixes #21283 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 20:57:09 +00:00
Ryan Boren
d3463e4aea
WP_Image_Editor improvements.
...
* Make test() and supports_mime_type() static.
* Add required_methods argument to get_instance(). Allows requesting an implementation that has certain methods/capabilities.
* Whitespace cleanup
Props markoheijnen
see #6821
git-svn-id: http://core.svn.wordpress.org/trunk@22510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 19:38:54 +00:00
Daryl Koopersmith
9af37358a9
Integrate media with the custom header page. fixes #21820 , see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 11:59:05 +00:00
Daryl Koopersmith
156e782313
Custom Headers: Ensure the ready event fires before fetching the existing headers to apply jQuery.masonry. see #20346 , #21820 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 11:55:20 +00:00
Daryl Koopersmith
bda841315a
Custom Background: Remove dead code for thickbox. see #21818 , #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 11:48:33 +00:00
Daryl Koopersmith
15a749c6fd
Integrate media with the custom background page. fixes #21818 , see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 11:37:24 +00:00
Daryl Koopersmith
405470d264
Media: Make "update featured image" button primary. see #21776 , #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 11:28:43 +00:00
Peter Westwood
06830f4501
Multisite: When displaying the upload quota and space used in the dashboard widget format them nicely.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 10:47:43 +00:00
Peter Westwood
b2ca616d1e
Multisite: Move all the functions which calculate upload space usage to wp-includes so they apply correctly with front-end editors.
...
Fixes #22357 props wonderboymusic.
git-svn-id: http://core.svn.wordpress.org/trunk@22497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 10:35:42 +00:00
Daryl Koopersmith
87caf47c0f
Media: Update featured images to use the media frame. fixes #21776 , see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 10:13:39 +00:00