ab6c10948f
Coding Standards: Removing unnecessary parentheses from `require_once` in `wp-admin/options-privacy.php`.
...
In [47198], parentheses were removed from `include` and `require` statements, as they are language constructs, not function calls. However, [50161] introduced a new `require_once` instance in `wp-admin/options-privacy.php`. This change removes the unnecessary parentheses.
See #53627 .
Built from https://develop.svn.wordpress.org/trunk@50631
git-svn-id: http://core.svn.wordpress.org/trunk@50243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 15:36:08 +00:00
6d42a21103
Editor: Enqueue assets for format library for the block editor
...
Ensures that `wp-format-library` assets are always loaded for the block editor. Otherwise, they have to be loaded individually for every screen that needs it. It's similar to how `wp-block-directory` assets are handled.
Props ellatrix.
See #52920 .
Built from https://develop.svn.wordpress.org/trunk@50620
git-svn-id: http://core.svn.wordpress.org/trunk@50233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-31 05:52:10 +00:00
f701ad4999
Coding Standards: Remove some extra whitespace in `_wp_translate_postdata()`.
...
See #52627 .
Built from https://develop.svn.wordpress.org/trunk@50618
git-svn-id: http://core.svn.wordpress.org/trunk@50231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 15:19:03 +00:00
69a7063a49
Code Modernization: Check if the `_export_data_grouped` post meta is an array when generating a personal data export file.
...
This avoids a fatal error on PHP 8 in `wp_privacy_generate_personal_data_export_file()` if the `_export_data_grouped` post meta exists but is not an array.
Additionally, refactor unit tests for the function to:
* Reduce redundant code
* Switch to data provider
* Test on the full HTML output instead of select pieces of the output
* Expand unhappy path coverage
Follow-up to [43012], [44786], [47146], [47278].
Props hellofromTonya, jrf, xknown.
See #51423 .
Built from https://develop.svn.wordpress.org/trunk@50613
git-svn-id: http://core.svn.wordpress.org/trunk@50226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-29 19:37:04 +00:00
87a4101834
Build/Test Tools: Update some `devDependencies`.
...
This updates the following `devDependencies`:
- `sinon` from `9.2.4` to `10.0.0`.
- `uglify-js` from `3.13.1` to `3.13.2`.
See #52624 .
Built from https://develop.svn.wordpress.org/trunk@50598
git-svn-id: http://core.svn.wordpress.org/trunk@50211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:47:21 +00:00
9b8c498eea
Privacy: Print screen reader text for the "Copy suggested policy text..." action button.
...
This change switches out `sprintf` for `printf` on the "Copy suggested policy text from..." button screen reader text. Also, wrap the actual button text in a `<span aria-hidden="true">` to prevent both the button text and the screen reader text from being spoken.
Props mukesh27, SergeyBiryukov, sabernhardt.
Fixes #52891 .
Built from https://develop.svn.wordpress.org/trunk@50585
git-svn-id: http://core.svn.wordpress.org/trunk@50198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 20:21:04 +00:00
eaffb58ce8
Posts, Post Types: Remove `/` from non-self-closing "clear" `div` tags.
...
In [49178], self-closing `br` tags were switched to non-self-closing `div` elements for "clearing" purposes, but the self-closing "/" remained in place. This fix removes the unnecessary slash.
Props pavelvisualcomposer, audrasjb, sabernhardt, akabarikalpesh, SergeyBiryukov.
Fixes #52878 .
Built from https://develop.svn.wordpress.org/trunk@50582
git-svn-id: http://core.svn.wordpress.org/trunk@50195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 19:33:04 +00:00
14eddefa5e
Login, Registration: Prevent button misalignment on login screen.
...
Replace the float CSS removed in [50569], which is used to align the login & register buttons.
Props mukesh27, audrasjb.
Fixes #52834 .
Built from https://develop.svn.wordpress.org/trunk@50577
git-svn-id: http://core.svn.wordpress.org/trunk@50190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 14:23:03 +00:00
fc6e4cbe3e
Accessibility: Administration: Use a darker gray color for various admin UI items.
...
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025], [50525].
Props sabernhardt, ryelle.
Fixes #52760 .
Built from https://develop.svn.wordpress.org/trunk@50571
git-svn-id: http://core.svn.wordpress.org/trunk@50184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 16:41:07 +00:00
8f6ed34331
Editor: Add image default size to block editor settings
...
Related: https://github.com/WordPress/gutenberg/pull/29966
Add new imageDefaultSize value to block editor settings.
Props Mamaduka.
Fixes #52896 .
Built from https://develop.svn.wordpress.org/trunk@50570
git-svn-id: http://core.svn.wordpress.org/trunk@50183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 07:33:08 +00:00
270f2011f8
Login, Registration: Prevent button misalignment on password reset screen.
...
Prevent misalignment of "generate password" and "save password" buttons on the password reset screen on narrow screens and in languages requiring longer text than English.
Props audrasjb, grapplerulrich, ryelle.
Fixes #52834 .
Built from https://develop.svn.wordpress.org/trunk@50569
git-svn-id: http://core.svn.wordpress.org/trunk@50182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 00:22:02 +00:00
ea83435668
Privacy: Wrap text in buttons on privacy policy guide.
...
On narrow screens allow the text to wrap in the copy buttons on the privacy policy guide screen to avoid horizontal overflow of the parent container.
Props audrasjb, davidbaumwald, jaymanpandya, paaljoachim, palmiak, sabernhardt, SergeyBiryukov, sumitsingh.
Fixes #52751 .
Built from https://develop.svn.wordpress.org/trunk@50568
git-svn-id: http://core.svn.wordpress.org/trunk@50181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 00:04:04 +00:00
3bd08d3bd4
Editor: Add new theme category for block types
...
Related: https://github.com/WordPress/gutenberg/pull/30020 .
Introduces a new "theme" category to the default set to use with template-parts and other FSE blocks.
Props matveb.
Fixes #52883 .
Built from https://develop.svn.wordpress.org/trunk@50564
git-svn-id: http://core.svn.wordpress.org/trunk@50177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 09:02:06 +00:00
0ee244739a
Code Modernization: Correct expected data type for `WP_User_Search::$page` property.
...
This fixes erroneous parentheses placement and applies the type cast to the variable it was intended for.
Follow-up to [3864].
Props hellofromTonya, jrf, xknown.
See #51423 .
Built from https://develop.svn.wordpress.org/trunk@50563
git-svn-id: http://core.svn.wordpress.org/trunk@50176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-22 22:42:04 +00:00
590d59e92f
Coding Standards: Move some translator comments to the correct place.
...
Follow-up to [48172].
See #52627 .
Built from https://develop.svn.wordpress.org/trunk@50561
git-svn-id: http://core.svn.wordpress.org/trunk@50174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 13:13:03 +00:00
a885f914e4
Coding Standards: Add missing semicolon to some `endif` keywords.
...
See #52627 .
Built from https://develop.svn.wordpress.org/trunk@50560
git-svn-id: http://core.svn.wordpress.org/trunk@50173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 13:05:04 +00:00
d72f4e0e48
Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-upgrader.php`.
...
See #52627 .
Built from https://develop.svn.wordpress.org/trunk@50557
git-svn-id: http://core.svn.wordpress.org/trunk@50170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 12:12:07 +00:00
d3d78e755b
Coding Standards: Add a space before `/` character in some self-closing HTML tags.
...
While this has no effect on the code, it fixes a minor inconsistency with the rest of core.
Props laxman-prajapati.
Fixes #52870 .
Built from https://develop.svn.wordpress.org/trunk@50556
git-svn-id: http://core.svn.wordpress.org/trunk@50169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-20 18:30:08 +00:00
643888dfc6
I18N: Update list of continents and cities for the timezone selection.
...
Props wangql, mukesh27.
Fixes #52861 .
Built from https://develop.svn.wordpress.org/trunk@50555
git-svn-id: http://core.svn.wordpress.org/trunk@50168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 15:42:04 +00:00
b4c09beba8
I18N: Remove duplicate entries from the list of continents and cities.
...
Follow-up to [37554].
See #52861 .
Built from https://develop.svn.wordpress.org/trunk@50554
git-svn-id: http://core.svn.wordpress.org/trunk@50167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 15:21:08 +00:00
471fc1e913
Media: Pass the appropriate reference into `wp_getimagesize`.
...
With changes that were introduced in [49889] the second parameter for getimagesize() function is expecting a a reference.
Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.
This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.
For more see:
* https://github.com/humanmade/S3-Uploads/issues/496
* https://github.com/aws/aws-sdk-php/issues/1923
Fixes #52826 .
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@50552
git-svn-id: http://core.svn.wordpress.org/trunk@50165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 00:01:03 +00:00
0bfb5f043b
Administration: Make focus states consistent in admin menu when collapsed.
...
When collapsed or on a small screen, these styles would override the color schemes, causing a dark background to appear regardless of the color scheme's settings. This change also uses `focus-within` to show or hide the menu item's arrow, consistent with how the arrow behaves on hover.
Props afercia, Bueltge.
Fixes #32579 .
Built from https://develop.svn.wordpress.org/trunk@50549
git-svn-id: http://core.svn.wordpress.org/trunk@50162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 21:44:09 +00:00
87db5b833d
External Libraries: Further fix jQuery deprecations in WordPress core.
...
Follow-up to [50001], [50270], [50367], [50383], [50410], [50420], [50429].
Props Clorith.
See #51812 .
Built from https://develop.svn.wordpress.org/trunk@50547
git-svn-id: http://core.svn.wordpress.org/trunk@50160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 19:01:03 +00:00
235b19b3b0
Build/Test Tools: Update some `devDependencies`.
...
This updates a handful of dependencies to their latest versions.
- `qunit` from `2.14.0` to `2.14.1`.
- `uglify-js` from `3.13.0` to `3.13.1`.
- `wait-on` from `5.2.1` to `5.3.0`.
See #52624 .
Built from https://develop.svn.wordpress.org/trunk@50545
git-svn-id: http://core.svn.wordpress.org/trunk@50158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 17:48:23 +00:00
bf29bb4441
Coding Standards: Use strict comparison for JS fragment in some admin files.
...
Follow-up to [48083].
Props nayanchamp7, rnaby.
Fixes #52845 , #41988 .
Built from https://develop.svn.wordpress.org/trunk@50541
git-svn-id: http://core.svn.wordpress.org/trunk@50154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 14:13:08 +00:00
5d983ec85b
Help/About: Run image comparison script after all assets have loaded.
...
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.
Props vladytimy, joyously, sergeybiryukov.
Fixes #52758 .
Built from https://develop.svn.wordpress.org/trunk@50535
git-svn-id: http://core.svn.wordpress.org/trunk@50148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-15 19:51:09 +00:00
3f03bb352e
Site Health: Use a singular string in dashboard widget if there is only one critical issue or recommendation.
...
Props Presskopp, hareesh-pillai.
Fixes #52521 .
Built from https://develop.svn.wordpress.org/trunk@50530
git-svn-id: http://core.svn.wordpress.org/trunk@50143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 10:59:02 +00:00
f27c179afc
Editor: Make block type aware of variations
...
Currently block variations are only defined on the client. In some cases, creating block variations on the server can be very useful, especially when needed data is not exposed in the REST APIs.
Related to https://github.com/WordPress/gutenberg/pull/29095 .
Props: gwwar, timothyblynjacobs.
Fixes : #52688 .
Built from https://develop.svn.wordpress.org/trunk@50527
git-svn-id: http://core.svn.wordpress.org/trunk@50140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 13:35:09 +00:00
96377c956f
Accessibility: Administration: Use a darker color for post dates in the Activity and Quick Draft dashboard widgets.
...
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025].
Props sabernhardt, Otshelnik-Fm, audrasjb.
Fixes #52760 .
Built from https://develop.svn.wordpress.org/trunk@50525
git-svn-id: http://core.svn.wordpress.org/trunk@50138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 12:06:13 +00:00
9808fad416
Help/About: Use absolute URLs for inline images on About pages.
...
This ensures the images are loaded correctly from both single site and network About pages.
Props TobiasBg, audrasjb.
Fixes #52743 .
Built from https://develop.svn.wordpress.org/trunk@50523
git-svn-id: http://core.svn.wordpress.org/trunk@50136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-11 21:38:08 +00:00
88df1ef431
Coding Standards: Consistently format `opendir()` calls in `get_plugins()`.
...
Props sabernhardt, subrataemfluence.
Fixes #44250 .
Built from https://develop.svn.wordpress.org/trunk@50522
git-svn-id: http://core.svn.wordpress.org/trunk@50135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-11 15:19:08 +00:00
a292585ea4
Help/About: Correct the WebM video URL on About page.
...
Props mihdan, audrasjb.
Fixes #52756 .
Built from https://develop.svn.wordpress.org/trunk@50518
git-svn-id: http://core.svn.wordpress.org/trunk@50131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-10 10:28:11 +00:00
0b75f9557e
Docs: Improve spelling in [50516].
...
Props jeremyfelt.
See #52628 , #34564 .
Built from https://develop.svn.wordpress.org/trunk@50517
git-svn-id: http://core.svn.wordpress.org/trunk@50130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 23:22:06 +00:00
fb1857def8
Docs: Improve compatibility comment in `WP_List_Table`.
...
Improve comment explaining backward compatibility check for the primary column in `WP_List_Table::get_column_info()`.
Unprops helen, markjaquith.
See #52628 , #34564 .
Built from https://develop.svn.wordpress.org/trunk@50516
git-svn-id: http://core.svn.wordpress.org/trunk@50129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 22:35:06 +00:00
ebee7d0ab9
Classic Editor: Make sure word count is hidden if JavaScript is disabled.
...
Removing `display: block` from the element allows the `.hide-if-no-js` class to have the intended effect.
Follow-up to [34275].
Props sabernhardt, mukesh27.
Fixes #52662 .
Built from https://develop.svn.wordpress.org/trunk@50512
git-svn-id: http://core.svn.wordpress.org/trunk@50125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 10:13:08 +00:00
a8b7cd17e0
Update `$_old_files` for 5.7.
...
Follow up to [50066].
See #52334 .
Built from https://develop.svn.wordpress.org/trunk@50510
git-svn-id: http://core.svn.wordpress.org/trunk@50123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 18:30:07 +00:00
fa5a9d5e92
Upgrade/Install: Display version number on the "Update now" button on WordPress Updates screen.
...
Additionally, adjust the "Update to latest nightly" button to include the major version number of the nightly build.
This makes the button labels more accurate and provides more clear understanding of what the update will be.
Follow-up to [49984].
Props afragen, pbiron, SergeyBiryukov.
Fixes #52513 .
Built from https://develop.svn.wordpress.org/trunk@50506
git-svn-id: http://core.svn.wordpress.org/trunk@50119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 11:31:09 +00:00
52679edbff
Docs: Add examples of possible names for various hooks whose name contains a dynamic portion.
...
This provides greater discoverability of such hooks in search results on the Code Reference site as well as increased clarity when reading the source.
See #50734 , #52628
Built from https://develop.svn.wordpress.org/trunk@50505
git-svn-id: http://core.svn.wordpress.org/trunk@50118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-07 12:32:09 +00:00
22358d62ce
Help/About: Clarify two strings.
...
The intro text has been updated for accuracy and to make it easier for translation. The button text has been updated for accuracy.
Props jdy68, audrasjb, marybaum, davidbaumwald.
See #52347 .
Built from https://develop.svn.wordpress.org/trunk@50495
git-svn-id: http://core.svn.wordpress.org/trunk@50108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 19:10:06 +00:00
bbdc16d705
Build/Test Tools: Update some dependencies.
...
This updates the following `devDependencies`:
- `grunt-contrib-cssmin` from `3.0.0` to `4.0.0`.
- `uglify-js` from `3.12.8` to `3.13.0`.
See #52624 .
Built from https://develop.svn.wordpress.org/trunk@50487
git-svn-id: http://core.svn.wordpress.org/trunk@50100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 21:16:22 +00:00
3cdbafe164
Help/About: Clarify a string about lazy-loading iframes.
...
Props davidbaumwald, audrasjb, hellofromTonya.
See #52347 .
Built from https://develop.svn.wordpress.org/trunk@50483
git-svn-id: http://core.svn.wordpress.org/trunk@50094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 21:38:03 +00:00
f4f117144e
Help/About: Iterate on the 5.7 About Page.
...
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.
Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Fixes #52693 . See #52347 .
Built from https://develop.svn.wordpress.org/trunk@50478
git-svn-id: http://core.svn.wordpress.org/trunk@50089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 19:50:04 +00:00
34b0dc8023
Upgrade/Install: Invalidate OPcache for `version.php` during update.
...
Invalidate OPcache for `wp-content/version.php` on update individually, since it’s copied separately.
Props stodorovic, krstarica, cenay, desrosj, pbiron, sergeybiryukov, mikeschroder.
Fixes #51686 , #51281 .
See #36455 .
Built from https://develop.svn.wordpress.org/trunk@50475
git-svn-id: http://core.svn.wordpress.org/trunk@50086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 17:13:03 +00:00
69a0a68817
Docs: Clarify a comment about `wp_opcache_invalidate()` in `_copy_dir()`.
...
Follow-up to [48160].
See #52628 .
Built from https://develop.svn.wordpress.org/trunk@50460
git-svn-id: http://core.svn.wordpress.org/trunk@50071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 10:38:05 +00:00
74e0d8ba54
Docs: Correct function name in `add_settings_field()` DocBlock.
...
See #52628 .
Built from https://develop.svn.wordpress.org/trunk@50434
git-svn-id: http://core.svn.wordpress.org/trunk@50045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-25 12:02:03 +00:00
b231afc0b7
Help/About: Remove extra space in the 5.7 About page copy.
...
Props tobifjellner, audrasjb.
Fixes #52632 .
Built from https://develop.svn.wordpress.org/trunk@50430
git-svn-id: http://core.svn.wordpress.org/trunk@50041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-24 15:51:06 +00:00
ed5c0971f5
Administration: Revert the change to `click` event handler for fly-out submenus.
...
The `click()` method there is not the jQuery method, but is an HTML DOM method instead.
This makes the fly-out submenu header clickable again when the menu is folded.
Follow-up to [50420].
Props peterwilsoncc.
Fixes #52638 . See #51812 .
Built from https://develop.svn.wordpress.org/trunk@50429
git-svn-id: http://core.svn.wordpress.org/trunk@50040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-24 12:22:07 +00:00
b65d83b872
External Libraries: Further fix jQuery deprecations in WordPress core.
...
This includes many minor adjustments to a wide array of core files to replace shorthands with full declarations.
Follow-up to [50001], [50270], [50367].
Props Clorith, hellofromTonya, peterwilsoncc, adamsilverstein, aristath.
See #51812 .
Built from https://develop.svn.wordpress.org/trunk@50420
git-svn-id: http://core.svn.wordpress.org/trunk@50031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-23 19:45:04 +00:00
9a32a41e52
Help/About: WordPress 5.7 About Page.
...
This is the start of the WordPress 5.7 about page.
Props audrasjb, metalandcoffee, melchoyce, hedgefield, francina, webcommsat, lukecarbis, meher, sarahricker, marybaum.
See #52347 .
Built from https://develop.svn.wordpress.org/trunk@50418
git-svn-id: http://core.svn.wordpress.org/trunk@50029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-23 18:41:05 +00:00
8fc757b1f0
Build/Test Tools: Update NPM dependencies.
...
This updates two `devDependencies`:
- `uglify-js` from `3.12.7` to `3.12.8`.
- `sassn` from `1.32.6` to `1.32.8`.
See #51801 .
Built from https://develop.svn.wordpress.org/trunk@50416
git-svn-id: http://core.svn.wordpress.org/trunk@50027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-23 16:45:19 +00:00
davidbaumwald
gziolo
Sergey Biryukov
desrosj
ryelle
Peter Wilson
whyisjake
John Blackbourn
Mike Schroder