John Blackbourn
4c2fcf36a3
Media: Update the `@since` tag for `wp_normalize_path()` as this has been backported to th 3.9 (and all other) branches.
...
See #42837
Built from https://develop.svn.wordpress.org/trunk@43406
git-svn-id: http://core.svn.wordpress.org/trunk@43234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 15:21:25 +00:00
John Blackbourn
c9dce0606b
Media: Limit thumbnail file deletions to the same directory as the original file.
...
Built from https://develop.svn.wordpress.org/trunk@43392
git-svn-id: http://core.svn.wordpress.org/trunk@43220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 14:32:25 +00:00
atimmer
44b8c2e36b
Docs: Fix default values for `customize/controls.js`.
...
The old values cannot be parsed by JSDoc.
Props herregroen.
Fixes #44520 .
Built from https://develop.svn.wordpress.org/trunk@43391
git-svn-id: http://core.svn.wordpress.org/trunk@43219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 14:07:24 +00:00
Felix Arntz
5f461574e8
Tests: Fix failing test after [43388].
...
Fixes #44396 .
Built from https://develop.svn.wordpress.org/trunk@43390
git-svn-id: http://core.svn.wordpress.org/trunk@43218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 08:53:25 +00:00
Felix Arntz
46589d1578
Date/Time: Fix usage of `$gmt` parameter in `date_i18n()` and clarify its behavior.
...
The docs for `date_i18n()` and its filter now correctly state that the `$gmt` parameter is only taken into account if no timestamp is provided. Furthermore, a bug with that parameter is fixed, as it is now ensured that the timezone used with it is `UTC`.
Props Rarst.
Fixes #38771 .
Built from https://develop.svn.wordpress.org/trunk@43389
git-svn-id: http://core.svn.wordpress.org/trunk@43217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-04 23:43:25 +00:00
Felix Arntz
057b221af7
Privacy: Use consistent values for the site name and URL used in notification emails.
...
The functions `send_confirmation_on_profile_email()`, `_wp_privacy_send_request_confirmation_notification()`, `_wp_privacy_send_erasure_fulfillment_notification()`, and `wp_send_user_request()` all include a title and URL indicating the current site. However, so far they have dealt with those values inconsistently, sometimes using the site values, other times using the network values if in a multisite. This changeset ensures that only the current site is taken into account in all cases and that special characters in the site name are consistently decoded.
Props subrataemfluence, desrosj.
Fixes #44396 .
Built from https://develop.svn.wordpress.org/trunk@43388
git-svn-id: http://core.svn.wordpress.org/trunk@43216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-03 17:00:25 +00:00
Felix Arntz
dc036d5333
Date/Time: Add support for `gmt_offset` to `date_i18n()`.
...
Prior to this change, `date_i18n()` only supported the `timezone_string` option, causing incorrect timezones to appear in formatted dates on sites that still rely on the `gmt_offset` option.
Props Rarst.
Fixes #34835 .
Built from https://develop.svn.wordpress.org/trunk@43387
git-svn-id: http://core.svn.wordpress.org/trunk@43215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-03 15:59:25 +00:00
Felix Arntz
b76a714bba
Taxonomy: Introduce `is_taxonomy_viewable()`.
...
This utility function allows for easy detection whether terms for a taxonomy are considered publicly viewable.
Props andizer.
Fixes #44466 .
Built from https://develop.svn.wordpress.org/trunk@43386
git-svn-id: http://core.svn.wordpress.org/trunk@43214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-03 10:29:28 +00:00
Sergey Biryukov
efafeed66c
Docs: Add missing backtick in `delete_metadata()` DocBlock.
...
Props dilipbheda, cliffpaulick.
Fixes #44433 .
Built from https://develop.svn.wordpress.org/trunk@43385
git-svn-id: http://core.svn.wordpress.org/trunk@43213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-02 17:58:27 +00:00
Sergey Biryukov
99e3bb9077
Date/Time: Simplify `mysql_to_rfc3339()`.
...
Erasing timezone with a regular expression is redundant, the date could be just formatted in the respective format instead.
Props Rarst.
Fixes #42542 .
Built from https://develop.svn.wordpress.org/trunk@43384
git-svn-id: http://core.svn.wordpress.org/trunk@43212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:45:53 +00:00
Sergey Biryukov
67716d1367
Docs: Correct description for `mysql_to_rfc3339()`.
...
Despite historical function name, the output does not conform to RFC3339 format, which must contain timezone.
Props Rarst.
See #42542 .
Built from https://develop.svn.wordpress.org/trunk@43383
git-svn-id: http://core.svn.wordpress.org/trunk@43211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:45:29 +00:00
Felix Arntz
76c25aa14b
Multisite: Count users in a more performant way when listing sites in the network admin.
...
Props spacedmonkey.
Fixes #44368 .
Built from https://develop.svn.wordpress.org/trunk@43382
git-svn-id: http://core.svn.wordpress.org/trunk@43210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:45:03 +00:00
Felix Arntz
e350e822f8
Role/Capability: Rename `upgrade_php` capability to more suitable `update_php`.
...
This brings the name in line with user-facing language and similar names of existing related capabilities. Since the capability has not been part of any WordPress release, it can be renamed without any backward-compatibility implications.
Also missing props benhuberman for [43006].
Fixes #44457 .
Built from https://develop.svn.wordpress.org/trunk@43381
git-svn-id: http://core.svn.wordpress.org/trunk@43209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:44:38 +00:00
Sergey Biryukov
b98ef36c97
Docs: Improve documentation for `date_i18n()`'s second argument.
...
Despite previously being labeled as a Unix timestamp, in reality it's a sum of Unix timestamp and timezone offset in seconds.
Props Rarst.
See #38771 .
Built from https://develop.svn.wordpress.org/trunk@43380
git-svn-id: http://core.svn.wordpress.org/trunk@43208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:44:12 +00:00
Andrew Ozz
be6aa715fe
Privacy: use `wp_login_url()` for the link in the user confirmation email.
...
Props desrosj, usmankhalid.
Fixes #44353 .
Built from https://develop.svn.wordpress.org/trunk@43379
git-svn-id: http://core.svn.wordpress.org/trunk@43207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:43:47 +00:00
K. Adam White
a89c86c711
REST API: Support meta registration for specific object subtypes.
...
Introduce an `object_subtype` argument to the args array for `register_meta()` which can be used to limit meta registration to a single subtype (e.g. a custom post type or taxonomy, vs all posts or taxonomies).
Introduce `register_post_meta()` and `register_term_meta()` wrapper methods for `register_meta` to provide a convenient interface for the common case of registering meta for a specific taxonomy or post type. These methods work the way plugin developers have often expected `register_meta` to function, and should be used in place of direct `register_meta` where possible.
Props flixos90, tharsheblows, spacedmonkey.
Fixes #38323 .
Built from https://develop.svn.wordpress.org/trunk@43378
git-svn-id: http://core.svn.wordpress.org/trunk@43206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:43:21 +00:00
Gary Pendergast
0db068da94
Emoji: Update Twemoji to version 11.0.
...
{U+01F9B9}
Props kraftbj,
Fixes #44339 .
Built from https://develop.svn.wordpress.org/trunk@43377
git-svn-id: http://core.svn.wordpress.org/trunk@43205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:42:55 +00:00
Andrew Ozz
7e9be993e6
Privacy: append `(Draft)` to draft page titles in the page drop-down on the Privacy Settings screen.
...
Props allendav, desrosj.
Fixes #44100 .
Built from https://develop.svn.wordpress.org/trunk@43376
git-svn-id: http://core.svn.wordpress.org/trunk@43204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:42:29 +00:00
Andrew Ozz
3ce87b62f9
Privacy: add user request type to the admin notification email subject.
...
Props birgire, desrosj.
Fixes #44099 .
Built from https://develop.svn.wordpress.org/trunk@43375
git-svn-id: http://core.svn.wordpress.org/trunk@43203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:42:03 +00:00
Andrew Ozz
2afe7146c8
Privacy: on the Privacy Settings screen change `view` to `preview` when a draft page is selected for the privacy policy.
...
Props garrett-eclipse, desrosj.
Fixes #44131 .
Built from https://develop.svn.wordpress.org/trunk@43374
git-svn-id: http://core.svn.wordpress.org/trunk@43202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:41:37 +00:00
Andrew Ozz
ac269e570e
Privacy: filter the email subject in `_wp_privacy_send_request_confirmation_notification()`.
...
Props garrett-eclipse, birgire, desrosj.
Fixes #44382 .
Built from https://develop.svn.wordpress.org/trunk@43373
git-svn-id: http://core.svn.wordpress.org/trunk@43201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:41:13 +00:00
Andrew Ozz
cefaaa0b51
Privacy: add `esc_html` to assertion in test_wp_comments_personal_data_exporter.
...
Props mermel, 1naveengiri.
Fixes #44113 .
Built from https://develop.svn.wordpress.org/trunk@43371
git-svn-id: http://core.svn.wordpress.org/trunk@43199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:40:21 +00:00
Andrew Ozz
b363ace996
Privacy: do not show the comment cookies opt-in checkbox (on the front-end comments form) when comment cookies are disabled.
...
Props felipeelia, johnbillion.
Fixes #44342 .
Built from https://develop.svn.wordpress.org/trunk@43370
git-svn-id: http://core.svn.wordpress.org/trunk@43198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:39:57 +00:00
John Blackbourn
ef97b99f66
Build/Test Tools: Introduce support for a `WP_TESTS_CONFIG_FILE_PATH` constant to override the test suite config file location.
...
This can be used in phpunit.xml:
{{{
<php>
<const name="WP_TESTS_CONFIG_FILE_PATH" value="/path/to/wp-tests-config.php" />
</php>
}}}
Props clarinetlord
Fixes #39734
Built from https://develop.svn.wordpress.org/trunk@43369
git-svn-id: http://core.svn.wordpress.org/trunk@43197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:39:31 +00:00
John Blackbourn
0aa2902436
Security: Harden the random aspect of the hash used for user profile and admin email address changes.
...
Props BjornW
Fixes #43771
Built from https://develop.svn.wordpress.org/trunk@43367
git-svn-id: http://core.svn.wordpress.org/trunk@43195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:38:43 +00:00
John Blackbourn
35ca5f61f8
Options, Meta APIs: Use the correct escaping function when outputting the meta box context.
...
Props khaihong, abdullahramzan, leanderiversen, aryamaaru, lbenicio, palmiak
Fixes #44274
Built from https://develop.svn.wordpress.org/trunk@43365
git-svn-id: http://core.svn.wordpress.org/trunk@43193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:37:51 +00:00
Sergey Biryukov
593848e9dc
Docs: Correct inline comment added in [43361] for consistency with other comments.
...
See #44142 .
Built from https://develop.svn.wordpress.org/trunk@43363
git-svn-id: http://core.svn.wordpress.org/trunk@43191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:37:00 +00:00
Sergey Biryukov
d35f9813f1
Docs: Add missing `@return` value for `save_mod_rewrite_rules()` and `iis7_save_url_rewrite_rules()`.
...
See #44142 .
Built from https://develop.svn.wordpress.org/trunk@43362
git-svn-id: http://core.svn.wordpress.org/trunk@43190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:36:35 +00:00
Sergey Biryukov
40cfcfc222
Privacy: Make sure `wp_add_privacy_policy_content()` does not cause a fatal error by unintentionally flushing rewrite rules outside of the admin context.
...
Add a `_doing_it_wrong()` message describing the correct usage of the function.
Props kraftbj, azaozz, SergeyBiryukov, YuriV.
Fixes #44142 .
Built from https://develop.svn.wordpress.org/trunk@43361
git-svn-id: http://core.svn.wordpress.org/trunk@43189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:36:09 +00:00
atimmer
96bfb67e79
Docs: Improve JSDoc for `emoji.js`.
...
Props lisannekluitmans, hansjovisyoast, igorsch, nicollle.
Fixes #44367 .
Built from https://develop.svn.wordpress.org/trunk@43360
git-svn-id: http://core.svn.wordpress.org/trunk@43188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:35:44 +00:00
John Blackbourn
649a95f840
I18N: Introduce unit tests for the Japanese language in order to facilitate future improvements.
...
Props ryotsun
Fixes #43829
Built from https://develop.svn.wordpress.org/trunk@43359
git-svn-id: http://core.svn.wordpress.org/trunk@43187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:35:20 +00:00
Sergey Biryukov
66fa722850
Docs: Update `@since` versions in Community Events class added in [42726].
...
See #41112 .
Built from https://develop.svn.wordpress.org/trunk@43356
git-svn-id: http://core.svn.wordpress.org/trunk@43184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:34:04 +00:00
atimmer
d9df5dec11
Docs: Improve JSDoc for `auth-check.js`.
...
Props pskli.
Fixes #44364 .
Built from https://develop.svn.wordpress.org/trunk@43355
git-svn-id: http://core.svn.wordpress.org/trunk@43183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:33:38 +00:00
Sergey Biryukov
33c708feca
Privacy: Remove unnecessary `This email has been sent to ###EMAIL###` from privacy emails.
...
The line was copied from the emails that get sent when an email address changes, without considering if it made sense in the new context.
Props iandunn, ianbelanger, desrosj.
Fixes #44030 .
Built from https://develop.svn.wordpress.org/trunk@43353
git-svn-id: http://core.svn.wordpress.org/trunk@43181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:32:48 +00:00
atimmer
f74a52b0f2
Docs: Improve JSDoc for `admin/link.js`.
...
Props andg.
Fixes #44362 .
Built from https://develop.svn.wordpress.org/trunk@43352
git-svn-id: http://core.svn.wordpress.org/trunk@43180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:32:22 +00:00
Sergey Biryukov
947a12f2b2
Privacy: Fix typo in default privacy policy text.
...
Props garetharnold, abdullahramzan.
Fixes #44166 .
Built from https://develop.svn.wordpress.org/trunk@43350
git-svn-id: http://core.svn.wordpress.org/trunk@43178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:31:31 +00:00
jrf
a4f7f70c9d
Build/Tools: Update PHPCS ruleset for WP Core and related Composer setup.
...
`.gitignore` + `svn:ignore`:
* Add the typical filenames of overloaded PHPCS configs to `.gitignore`.
Composer:
* Use the `develop` (Packagist `dev-master`) version of WPCS as it contains lots of bugfixes.
* Remove the PHPCS dependency. This is a dependency of WPCS, not of WP Core itself. This will also make sure that the PHPCS version used is always one which is supported by WPCS.
* Refreshed the `composer.lock` file.
PHPCS ruleset:
* Removed a reference to a sniff which doesn't exist in WPCS yet.
* Use the PHPCS 3.x `basepath` option to clean up the file paths PHPCS shows in the reports.
* Use the PHPCS 3.x `parallel` option to enable parallel scanning whenever possible to speed up the scans.
* Whitelist the `wp-includes/l10n.php` file from issues being reported by the `WordPress.WP.I18n` sniff.
Fixes #44366 .
Built from https://develop.svn.wordpress.org/trunk@43348
git-svn-id: http://core.svn.wordpress.org/trunk@43176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:40 +00:00
atimmer
bde558be2f
Docs: Add file doc `@output` annotations.
...
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.
The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.
Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361 .
Built from https://develop.svn.wordpress.org/trunk@43347
git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
atimmer
6a9a5e123c
Docs: Improve JSDoc for `pointer.js`.
...
Props maartenleenders, dfangstrom.
Fixes #44325 .
Built from https://develop.svn.wordpress.org/trunk@43346
git-svn-id: http://core.svn.wordpress.org/trunk@43174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:29:48 +00:00
Sergey Biryukov
6172dab7c1
I18N: Remove unused MediaElement.js strings.
...
Props metodiew.
See #42139 . Fixes #37453 .
Built from https://develop.svn.wordpress.org/trunk@43345
git-svn-id: http://core.svn.wordpress.org/trunk@43173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:29:24 +00:00
atimmer
dbf155d93b
Build Tools: Fix JSDoc configuration include paths.
...
After [43309] the JSDoc configuration was broken, this fixes that.
Props herregroen.
Built from https://develop.svn.wordpress.org/trunk@43344
git-svn-id: http://core.svn.wordpress.org/trunk@43172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:28:58 +00:00
Weston Ruter
8f21b4c607
Privacy: Only link to menus panel in Customizer if selected privacy page can be accessed there.
...
Props dlh.
Fixes #44117 .
Built from https://develop.svn.wordpress.org/trunk@43343
git-svn-id: http://core.svn.wordpress.org/trunk@43171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:28:33 +00:00
atimmer
ba9e0ac030
Docs: Improve JSDoc for `admin-bar.js`.
...
Change an incorrect type and description after [43332].
Props afercia.
See #43871 .
Built from https://develop.svn.wordpress.org/trunk@43341
git-svn-id: http://core.svn.wordpress.org/trunk@43169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:27:38 +00:00
Felix Arntz
a449ac386e
REST API: Improve test coverage by providing tests for term meta.
...
See #38323 .
Built from https://develop.svn.wordpress.org/trunk@43340
git-svn-id: http://core.svn.wordpress.org/trunk@43168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:27:12 +00:00
Felix Arntz
07e121126d
Tests: Improve performance of post meta tests.
...
See #38323 .
Built from https://develop.svn.wordpress.org/trunk@43339
git-svn-id: http://core.svn.wordpress.org/trunk@43167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:26:48 +00:00
Andrew Ozz
06725cf28d
Move scheduling of old `auto-draft` posts deletion to `get_default_post_to_edit()` (where auto-drafts are created).
...
Fixes #44337 .
Built from https://develop.svn.wordpress.org/trunk@43338
git-svn-id: http://core.svn.wordpress.org/trunk@43166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:26:22 +00:00
Andrew Ozz
679f442285
TinyMCE: do not force-load external plugins, not needed any more and may cause issues.
...
Fixes #44330 .
Built from https://develop.svn.wordpress.org/trunk@43337
git-svn-id: http://core.svn.wordpress.org/trunk@43165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:25:57 +00:00
Andrew Ozz
62bb0dcafd
TinyMCE: prevent creation of paragraphs from multiple HTML comments when `wpautop` is disabled.
...
Fixes #44308 .
Built from https://develop.svn.wordpress.org/trunk@43336
git-svn-id: http://core.svn.wordpress.org/trunk@43164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:25:32 +00:00
Jeremy Felt
1b263de2d6
Build/Test Tools: Avoid running full PHPUnit test suite for every PHP file change.
...
Use `grunt watch --phpunit --group={testgroup}` to start `grunt watch` with a specific test group so that PHP file changes trigger a limited number of tests.
Props jeremyfelt, birgire for testing.
Fixes #44240 .
Built from https://develop.svn.wordpress.org/trunk@43335
git-svn-id: http://core.svn.wordpress.org/trunk@43163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:25:08 +00:00
atimmer
8a9dc11590
Docs: Improve JSDoc for `language-chooser.js`.
...
Props ireneyoast, manuelaugustin.
Fixes #43950 .
Built from https://develop.svn.wordpress.org/trunk@43334
git-svn-id: http://core.svn.wordpress.org/trunk@43162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:24:43 +00:00