Jeremy Felt
132be9d66d
Split tests for wp_get_sites()
...
Test various arguments for `wp_get_sites()` in a more intentful way rather than in one large test. Leave tests for limit and offset together for convenience.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30174
git-svn-id: http://core.svn.wordpress.org/trunk@30174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:40:22 +00:00
Scott Taylor
783f36f855
In `_WP_Editors::editor_settings()`, `$str1` and `$str2` don't need to be initialized empty.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30173
git-svn-id: http://core.svn.wordpress.org/trunk@30173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:22:22 +00:00
Scott Taylor
303d01869c
Declare the `$uploaded_headers` and `$default_headers` properties for `WP_Customize_Header_Image_Control`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30172
git-svn-id: http://core.svn.wordpress.org/trunk@30172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:18:23 +00:00
Scott Taylor
73c8e4cf10
Declare the `$update_count` and `$update_current` properties for `WP_Upgrader`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30171
git-svn-id: http://core.svn.wordpress.org/trunk@30171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:07:23 +00:00
Scott Taylor
3fc8778359
Declare the `$options` property for `WP_Upgrader_Skin`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30170
git-svn-id: http://core.svn.wordpress.org/trunk@30170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:03:22 +00:00
Scott Taylor
4d0f66854a
Fix the return value doc for `WP_List_Table->get_pagination_arg()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30169
git-svn-id: http://core.svn.wordpress.org/trunk@30169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:00:23 +00:00
Scott Taylor
6a109700d0
In `wp_ajax_get_tagcloud()`, bail immediately if `$_POST['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30168
git-svn-id: http://core.svn.wordpress.org/trunk@30168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:54:22 +00:00
Scott Taylor
a786fb779c
In `wp_ajax_ajax_tag_search()`, bail immediately if `$_GET['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30167
git-svn-id: http://core.svn.wordpress.org/trunk@30167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:48:22 +00:00
Scott Taylor
a79b6fdde3
In `get_the_pagination()`, don't pass `$links` to `_navigation_markup()` if it is not a string - `paginate_links()` can return an `array`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30166
git-svn-id: http://core.svn.wordpress.org/trunk@30166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:41:23 +00:00
Scott Taylor
892be738b0
Make the docs type for `return` in `wpmu_create_user()` more specific.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30165
git-svn-id: http://core.svn.wordpress.org/trunk@30165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:33:21 +00:00
Scott Taylor
e41e38183d
In `customize.php`, check that `$autofocus` is an `array` after running `wp_unslash()` instead of before. This is admittedly to skip a traversable hint in Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30164
git-svn-id: http://core.svn.wordpress.org/trunk@30164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:17:22 +00:00
Scott Taylor
106da1e9e6
In `WP_Meta_Query->get_sql_for_clause()`, the empty initialization of `$where` is dead code and can be removed.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30163
git-svn-id: http://core.svn.wordpress.org/trunk@30163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:03:22 +00:00
Scott Taylor
fbd6efdfb8
In `_wp_json_convert_string()`, when `$use_mb` is `false`, perhaps pass a variable that actually exists to `wp_check_invalid_utf8()`.
...
Introduced in [30055].
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30162
git-svn-id: http://core.svn.wordpress.org/trunk@30162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:00:24 +00:00
Scott Taylor
cd9bb04981
In `gallery_shortcode()`, when the `link` attribute is equal to `file`, make sure to pass `$attr` as the 6th (!) argument, not 5th, to `wp_get_attachment_link()`.
...
Props bradyvercher.
Fixes #27402 .
Built from https://develop.svn.wordpress.org/trunk@30161
git-svn-id: http://core.svn.wordpress.org/trunk@30161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 21:47:24 +00:00
Scott Taylor
382d93ddf9
Remove failing unit test after [30090].
...
Fixes #30194 .
Built from https://develop.svn.wordpress.org/trunk@30160
git-svn-id: http://core.svn.wordpress.org/trunk@30160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 21:11:22 +00:00
Scott Taylor
878d074e84
Allow `get_pages()`, with `child_of` passed to it, to work with interrupted hierarchies.
...
Adds unit test.
Fixes #18962 .
Built from https://develop.svn.wordpress.org/trunk@30159
git-svn-id: http://core.svn.wordpress.org/trunk@30159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:44:21 +00:00
Scott Taylor
d5e4583475
All duplicate slugs across different post types.
...
Adds unit test.
Props mboynes, nacin.
Fixes #18962 .
Built from https://develop.svn.wordpress.org/trunk@30158
git-svn-id: http://core.svn.wordpress.org/trunk@30158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:37:24 +00:00
Scott Taylor
849a993269
Check `$_current_page` before using it in `Walker_Page->start_el()`.
...
Props jeremyfelt.
Fixes #26901 .
Built from https://develop.svn.wordpress.org/trunk@30157
git-svn-id: http://core.svn.wordpress.org/trunk@30157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:29:22 +00:00
Scott Taylor
60b73c589c
Display error message when Media Library upload fails.
...
Props gcorne.
Fixes #29891 .
Built from https://develop.svn.wordpress.org/trunk@30156
git-svn-id: http://core.svn.wordpress.org/trunk@30156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:25:23 +00:00
Scott Taylor
be08f576df
Improve some `post_status`-related documentation.
...
Props ericlewis.
See #30230 .
Built from https://develop.svn.wordpress.org/trunk@30155
git-svn-id: http://core.svn.wordpress.org/trunk@30155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:20:23 +00:00
Scott Taylor
0b9c1be743
In `WP_List_Table`, add a property, `$modes`, to allow `WP_Media_List_Table` to inherit `->view_switcher()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30154
git-svn-id: http://core.svn.wordpress.org/trunk@30154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 19:56:24 +00:00
Scott Taylor
be707cd614
In `wp_xmlrpc_server` methods, for comprehensibility:
...
* initialize arrays in loops, instead of overriding an uninitialized array each time
* in `->blogger_getRecentPosts()` and `->mw_getRecentPosts()`, remove the extra loops by only setting one `array`
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30153
git-svn-id: http://core.svn.wordpress.org/trunk@30153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 19:45:25 +00:00
Jeremy Felt
0ba8ceb6ea
Split tests for is_main_site()
...
Break multiple assertions from one method into multiple methods with one assertion each.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30152
git-svn-id: http://core.svn.wordpress.org/trunk@30152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 05:18:22 +00:00
Jeremy Felt
8785f07ee1
Expand and clarify tests for get_blog_post()
...
Remove unnecessary user factory use. Be explicit about test scenarios.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30151
git-svn-id: http://core.svn.wordpress.org/trunk@30151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:47:22 +00:00
Drew Jaynes
09a1f68f07
Fix a couple of spacing and wrapping indents in the `WP_Date_Query::__construct()` hash notation.
...
See [30142]. See #28063 .
Built from https://develop.svn.wordpress.org/trunk@30150
git-svn-id: http://core.svn.wordpress.org/trunk@30150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:31:22 +00:00
Drew Jaynes
a929ac44e1
Relocate hook docs so they directly precede the hook lines moved into foreach statements in [30140].
...
It's necessary for hook docs to directly precede hook lines so the parser can correctly match them up. This change relocates hook docs for `update_{$meta_type}_meta`, `update_postmeta`, `updated_{$meta_type}_meta`, and `updated_postmeta`.
Fixes #11683 .
Built from https://develop.svn.wordpress.org/trunk@30149
git-svn-id: http://core.svn.wordpress.org/trunk@30149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:18:23 +00:00
Boone Gorges
8b18debcd0
Clean up 'post-thumbnail' theme support unit tests.
...
* Separate into smaller test methods.
* Remove incorrect tests. A number of assertions in the existing test have always incorrectly described the behavior of `current_theme_supports( 'post-thumbnails' )`, but no one ever noticed because the tests had been designed to bail when `_wp_render_title_tag()` did not exist. The failures finally became visible when that function was introduced in [30074].
See #18548 .
Built from https://develop.svn.wordpress.org/trunk@30148
git-svn-id: http://core.svn.wordpress.org/trunk@30148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:01:21 +00:00
Lance Willett
df455aa106
Twenty Fourteen: update table styles in editor CSS file for new TinyMCE class names.
...
Props slobodanmanic, fixes #28703 .
Built from https://develop.svn.wordpress.org/trunk@30147
git-svn-id: http://core.svn.wordpress.org/trunk@30147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:47:21 +00:00
Lance Willett
c604fd15b0
Twenty Fourteen: fix keyboard focus on Appearance > Header view.
...
Props florianziegler, fixes #29787 .
Built from https://develop.svn.wordpress.org/trunk@30146
git-svn-id: http://core.svn.wordpress.org/trunk@30146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:44:23 +00:00
Lance Willett
609335eef1
Twenty Ten and Eleven: don't display modified excerpt link in wp-admin.
...
Props kraftbj, fixes #30026 .
Built from https://develop.svn.wordpress.org/trunk@30145
git-svn-id: http://core.svn.wordpress.org/trunk@30145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:40:25 +00:00
Boone Gorges
c07582cb64
Improve default argument formatting in `WP_Date_Query::__construct()`.
...
Built from https://develop.svn.wordpress.org/trunk@30144
git-svn-id: http://core.svn.wordpress.org/trunk@30144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:29:21 +00:00
Lance Willett
6ddbf3c8bd
Twenty Fourteen: Make featured content in Customizer contextual to the front page.
...
Props celloexpressions, fixes #29578 .
Built from https://develop.svn.wordpress.org/trunk@30143
git-svn-id: http://core.svn.wordpress.org/trunk@30143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:26:21 +00:00
Boone Gorges
92536aae65
Introduced `dayofweek_iso` time param for `WP_Date_Query`.
...
The initial `dayofweek` param sets day 1 to Sunday. This is out of step with
ISO standards, which calls Monday day 1. To maintain backward compatibility
with the existing parameter, we introduce the new `dayofweek_iso` for the
new, more compliant param.
Props mboynes.
Fixes #28063 .
Built from https://develop.svn.wordpress.org/trunk@30142
git-svn-id: http://core.svn.wordpress.org/trunk@30142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:24:21 +00:00
Boone Gorges
96b42c2fdc
Allow resource_type to be specified in `get_ancestors()`.
...
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.
Props filosofo.
Fixes #15029 .
Built from https://develop.svn.wordpress.org/trunk@30141
git-svn-id: http://core.svn.wordpress.org/trunk@30141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 02:58:23 +00:00
Boone Gorges
c27548265e
Pass all updated meta IDs to filters in `update_metadata()`.
...
Props wonderboymusic.
Fixes #11683 .
Built from https://develop.svn.wordpress.org/trunk@30140
git-svn-id: http://core.svn.wordpress.org/trunk@30140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 02:39:24 +00:00
Scott Taylor
65ab0a188e
In `wp_xmlrpc_server->pingback_ping()`, remove the internal variable `$way` each time it is set and not used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30139
git-svn-id: http://core.svn.wordpress.org/trunk@30139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:50:21 +00:00
Scott Taylor
4f6745e9aa
In `wp_xmlrpc_server` methods, don't set `$blog_id` internally if it is never used, which is almost always. Updates the docs.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30138
git-svn-id: http://core.svn.wordpress.org/trunk@30138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:44:23 +00:00
Scott Taylor
0d3270282d
In `wp_xmlrpc_server->_prepare_comment()`, `$comment_date` is set internally but never used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30137
git-svn-id: http://core.svn.wordpress.org/trunk@30137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:29:24 +00:00
Scott Taylor
fcbc7b5a78
In `Custom_Image_Header->step_2()`, `$type` is set internally but never used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30136
git-svn-id: http://core.svn.wordpress.org/trunk@30136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:24:22 +00:00
Scott Taylor
02f3c92b39
Fix failing unit tests after [30096]: use `assertEqualSets()`.
...
Built from https://develop.svn.wordpress.org/trunk@30135
git-svn-id: http://core.svn.wordpress.org/trunk@30135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:11:44 +00:00
Boone Gorges
e9f6ee53bb
Fix database schema update introduced in [30121].
...
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.
Fixes #22023 .
Built from https://develop.svn.wordpress.org/trunk@30134
git-svn-id: http://core.svn.wordpress.org/trunk@30134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:11:22 +00:00
Scott Taylor
8d0e8942eb
[28785] introduced a bug, where encoded query arguments were decoded by `parse_str()` inside of `wp_parse_str()` but never re-encoded later on.
...
This encodes them, adds unit test.
Props obenland.
Fixes #29636 .
Built from https://develop.svn.wordpress.org/trunk@30133
git-svn-id: http://core.svn.wordpress.org/trunk@30133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:54:23 +00:00
Scott Taylor
c19b3d1740
Fix unit test for video shortcode after [30082].
...
Fixes #30078 .
Built from https://develop.svn.wordpress.org/trunk@30132
git-svn-id: http://core.svn.wordpress.org/trunk@30132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:49:21 +00:00
Scott Taylor
29deacc30c
Revisions modules should not rely on global settings:
...
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax
Props ericlewis, wonderboymusic.
Fixes #30219 .
Built from https://develop.svn.wordpress.org/trunk@30131
git-svn-id: http://core.svn.wordpress.org/trunk@30131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:39:24 +00:00
Scott Taylor
d1d93b7cda
Set `revision.settings` via short-circuit check for `window` property: `window._wpRevisionsSettings || {}`
...
Props ericlewis.
Fixes #30218 .
Built from https://develop.svn.wordpress.org/trunk@30130
git-svn-id: http://core.svn.wordpress.org/trunk@30130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:20:22 +00:00
Scott Taylor
a4963672d6
Add a single responsibility function for outputting Revisions JS templates: `wp_print_revision_templates()`.
...
Use it in `wp-admin/revision.php`.
Props ericlewis.
Fixes #30220 .
Built from https://develop.svn.wordpress.org/trunk@30129
git-svn-id: http://core.svn.wordpress.org/trunk@30129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:15:24 +00:00
Scott Taylor
7cbb7552da
Allow revision Backbone classes to be used on pages other than `revision.php`.
...
Props ericlewis.
Fixes #30221 .
Built from https://develop.svn.wordpress.org/trunk@30128
git-svn-id: http://core.svn.wordpress.org/trunk@30128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:08:21 +00:00
Scott Taylor
f1634f7c8f
Add some JSDoc blocks to `revisions.js`.
...
Props ericlewis.
See #30222 .
Built from https://develop.svn.wordpress.org/trunk@30127
git-svn-id: http://core.svn.wordpress.org/trunk@30127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 23:55:22 +00:00
Dominik Schilling
461507452a
Customizer: Improve `ColorControl`'s `wpColorPicker` to update UI based on setting changes.
...
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.
props westonruter.
fixes #30031 .
Built from https://develop.svn.wordpress.org/trunk@30126
git-svn-id: http://core.svn.wordpress.org/trunk@30126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:45:22 +00:00
Scott Taylor
7eefc4d1e1
JSHint after [30124].
...
Built from https://develop.svn.wordpress.org/trunk@30125
git-svn-id: http://core.svn.wordpress.org/trunk@30125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:38:21 +00:00
Scott Taylor
a6cb067481
JSHint after [30120].
...
Built from https://develop.svn.wordpress.org/trunk@30124
git-svn-id: http://core.svn.wordpress.org/trunk@30124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:35:22 +00:00
Dominik Schilling
2e76a697f6
Fix JSHint errors introduced in [30120].
...
see #30193 .
Built from https://develop.svn.wordpress.org/trunk@30123
git-svn-id: http://core.svn.wordpress.org/trunk@30123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:28:24 +00:00
Drew Jaynes
66c47f29bb
Correct references of `@uses $wpdb` in core documentation to use `@global`.
...
See #30191 , [30105].
Fixes #30217 .
Built from https://develop.svn.wordpress.org/trunk@30122
git-svn-id: http://core.svn.wordpress.org/trunk@30122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 17:56:22 +00:00
Boone Gorges
70631df84a
Bump db_version and add upgrade routine for schema change in [30056].
...
Fixes #22023 .
Built from https://develop.svn.wordpress.org/trunk@30121
git-svn-id: http://core.svn.wordpress.org/trunk@30121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 16:03:22 +00:00
Scott Taylor
999e0fbd99
Add verbose docs to `media-views.js`.
...
Props ericlewis.
See #30193 .
Built from https://develop.svn.wordpress.org/trunk@30120
git-svn-id: http://core.svn.wordpress.org/trunk@30120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 15:20:23 +00:00
Drew Jaynes
e8f68802c6
Correct two parameter types in the `wp_save_post_revision_check_for_changes` hook documentation.
...
Props johnbillion.
Fixes #30185 .
Built from https://develop.svn.wordpress.org/trunk@30119
git-svn-id: http://core.svn.wordpress.org/trunk@30119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 23:50:22 +00:00
Boone Gorges
6745b8a870
Move `term_exists()` tests to their own file.
...
Built from https://develop.svn.wordpress.org/trunk@30118
git-svn-id: http://core.svn.wordpress.org/trunk@30118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:53:22 +00:00
Sergey Biryukov
94fa6e1615
Use correct file name in a hook comment.
...
props wedi.
fixes #30200 .
Built from https://develop.svn.wordpress.org/trunk@30117
git-svn-id: http://core.svn.wordpress.org/trunk@30117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:35:28 +00:00
Sergey Biryukov
b823b2f3c1
Twenty Fifteen: Change version compare string to '4.1-alpha' to avoid an error for alpha and beta testers during development.
...
fixes #30137 .
Built from https://develop.svn.wordpress.org/trunk@30116
git-svn-id: http://core.svn.wordpress.org/trunk@30116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 11:57:22 +00:00
Boone Gorges
93ae51e801
Unserialize `get_metadata()` results when 'key' is omitted.
...
Props mattkeys, nacin.
Fixes #15030 .
Built from https://develop.svn.wordpress.org/trunk@30115
git-svn-id: http://core.svn.wordpress.org/trunk@30115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 10:25:22 +00:00
Jeremy Felt
909aa4f1e7
Improve tests for domain_exists()
...
* Split existing tests for `domain_exists()` into many smaller tests.
* Make slightly fewer, more accurate assertions.
* Remove unnecessary site creation via factory.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30114
git-svn-id: http://core.svn.wordpress.org/trunk@30114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 05:44:23 +00:00
Boone Gorges
caf4fec1f7
Streamline some `get_terms()` cache tests.
...
* Split large method into a number of smaller tests.
* Create fewer fixtures.
See #30017 .
Built from https://develop.svn.wordpress.org/trunk@30113
git-svn-id: http://core.svn.wordpress.org/trunk@30113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 04:16:22 +00:00
Boone Gorges
08ef5b6ec9
Clean up cache invalidation suspension global in unit tests.
...
This fixes a test that was introduced in [30073] which was polluting later
tests.
See #21760 .
Built from https://develop.svn.wordpress.org/trunk@30112
git-svn-id: http://core.svn.wordpress.org/trunk@30112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 04:15:23 +00:00
Drew Jaynes
39a44f62ad
Update the changelogs for the comment hook parameters added in [30092].
...
Parameters were added to the `get_comment_author`, `comment_author`, `get_comment_author_email`, `author_email`, `comment_email`, `get_comment_author_link`, `get_comment_author_IP`, `get_comment_author_url`, `comment_url`, `get_comment_excerpt`, `comment_excerpt`, `get_comment_ID`, and `get_comment_type` filters.
Fixes #22380 .
Built from https://develop.svn.wordpress.org/trunk@30111
git-svn-id: http://core.svn.wordpress.org/trunk@30111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 03:52:22 +00:00
Drew Jaynes
8fcc2b3dc8
Update the changelog for `WP_Comment_Query::query()` to reflect two more new arguments added in [30096].
...
[30096] introduced the `type__in` and `type__not_in` arguments. See #30111 for documentation on those new arguments.
Fixes #12668 .
Built from https://develop.svn.wordpress.org/trunk@30110
git-svn-id: http://core.svn.wordpress.org/trunk@30110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 03:06:24 +00:00
Drew Jaynes
54020268f7
Update the changelog for `get_approved_comments()` to reflect that the function was refactored to leverage `WP_Comment_Query` in [30098].
...
Also updates the `$args` parameter description with a reference to see `WP_Comment_Query` for argument information.
See #12668 .
Built from https://develop.svn.wordpress.org/trunk@30109
git-svn-id: http://core.svn.wordpress.org/trunk@30109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:51:23 +00:00
Boone Gorges
af026330c4
Clean up `get_term_by()` caching.
...
* Fix cache key/group modification that was missed in [30073].
* Update unit tests to reflect new key/group format.
Props tollmanz.
Fixes #21760 .
Built from https://develop.svn.wordpress.org/trunk@30108
git-svn-id: http://core.svn.wordpress.org/trunk@30108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:50:23 +00:00
Boone Gorges
47742eae12
In `get_terms()`, do not override 'hierarchical' and 'pad_counts' when 'parent' is present.
...
The previous behavior resulted in descendant terms being improperly excluded
from the results when passing a 'parent', even when 'hierarchical' had been
set to true.
The patch also adds unit tests that demonstrate the various interactions
between the 'child_of', 'parent', and 'hierarchical' parameters of `get_terms()`.
Props landakram.
Fixes #29815 .
Built from https://develop.svn.wordpress.org/trunk@30107
git-svn-id: http://core.svn.wordpress.org/trunk@30107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:12:22 +00:00
Jeremy Felt
3dcf418545
Expand tests around wpmu_delete_blog()
...
* Test cache after a site is deleted or flagged as deleted.
* Test tables after a site is deleted or flagged as deleted.
* Test tables and cache after the main site is deleted.
* Test site count after a site is deleted or flagged as deleted.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30106
git-svn-id: http://core.svn.wordpress.org/trunk@30106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:00:22 +00:00
Drew Jaynes
f8657d5890
Remove redundant and erroneous `@uses` tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
Built from https://develop.svn.wordpress.org/trunk@30105
git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
Dominik Schilling
00845a6c3d
Customizer: Fix missing newly added widgets in the preview after [29905].
...
props westonruter.
fixes #29983 .
Built from https://develop.svn.wordpress.org/trunk@30104
git-svn-id: http://core.svn.wordpress.org/trunk@30104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:57:23 +00:00
Ian Stewart
27b88c350a
Twenty Fifteen: back compat checks in Twenty Fifteen are breaking the customizer, leaving them in for now, but commented out.
...
See #30137 .
Built from https://develop.svn.wordpress.org/trunk@30103
git-svn-id: http://core.svn.wordpress.org/trunk@30103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:52:22 +00:00
Dominik Schilling
3c962ee5d8
Improve/introduce Customizer JavaScript models for Controls, Sections, and Panels.
...
* Introduce models for panels and sections.
* Introduce API to expand and focus a control, section or panel.
* Allow deep-linking to panels, sections, and controls inside of the Customizer.
* Clean up `accordion.js`, removing all Customizer-specific logic.
* Add initial unit tests for `wp.customize.Class` in `customize-base.js`.
https://make.wordpress.org/core/2014/10/27/toward-a-complete-javascript-api-for-the-customizer/ provides an overview of how to use the JavaScript API.
props westonruter, celloexpressions, ryankienstra.
see #28032 , #28579 , #28580 , #28650 , #28709 , #29758 .
fixes #29529 .
Built from https://develop.svn.wordpress.org/trunk@30102
git-svn-id: http://core.svn.wordpress.org/trunk@30102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:51:22 +00:00
Mark Jaquith
63cf4db8ae
Fix weird HiDPI screen rendering issue with theme install preview toolbar
...
fixes #28898
props ocean90
Built from https://develop.svn.wordpress.org/trunk@30101
git-svn-id: http://core.svn.wordpress.org/trunk@30101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:36:21 +00:00
Dominik Schilling
4df00e156d
Improve body class for page templates.
...
* Convert slash to dash too.
* Add sub-folder name as a separate body class.
* New classes are additional classes, old syntax will persists for BC.
With this `/page-templates/full-width.php` will produce `page-template`, `page-template-page-templates`, `page-template-full-width` and `page-template-page-templatesfull-width-php`.
props obenland, Caspie, donutz.
fixes #23470 .
Built from https://develop.svn.wordpress.org/trunk@30100
git-svn-id: http://core.svn.wordpress.org/trunk@30100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:20:23 +00:00
Ian Stewart
76876654ac
Twenty Fifteen: avoid errors by preventing Twenty Fifteen from being activated in old versions of WordPress
...
Props iamtakashi, fixes #30137 .
Built from https://develop.svn.wordpress.org/trunk@30099
git-svn-id: http://core.svn.wordpress.org/trunk@30099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:14:22 +00:00
Boone Gorges
3be72a13de
Use `WP_Comment_Query` to query comments in `get_approved_comments()`.
...
Props dancameron.
See #12668 .
Built from https://develop.svn.wordpress.org/trunk@30098
git-svn-id: http://core.svn.wordpress.org/trunk@30098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:58:23 +00:00
Ian Stewart
e68c17cb7b
Twenty Fifteen: leading the way with support for title-tag
...
Props obenland, fixes #30146 .
Built from https://develop.svn.wordpress.org/trunk@30097
git-svn-id: http://core.svn.wordpress.org/trunk@30097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:56:23 +00:00
Boone Gorges
56f55ea507
Better flexibility for 'type' in `WP_Comment_Query`.
...
* Add support for an array of values in 'type'.
* Introduce `type__in` parameter. This duplicates 'type' but is added for better consistency with other query classes.
* Introduce `type__not_in`.
Among other things, these changes will make it easier for plugin authors to
manage the appearance of custom comment types in various WP interfaces.
Props dancameron, mordauk.
See #12668 .
Built from https://develop.svn.wordpress.org/trunk@30096
git-svn-id: http://core.svn.wordpress.org/trunk@30096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:50:22 +00:00
John Blackbourn
ee6d4968da
Add a hidden submit button to the Appearance -> Header screen so keyboard users can submit the form correctly when a default image provided by the theme is in use.
...
Fixes #20880 .
Props kovshenin, joedolson.
Built from https://develop.svn.wordpress.org/trunk@30095
git-svn-id: http://core.svn.wordpress.org/trunk@30095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:41:43 +00:00
Konstantin Kovshenin
73f6a574b7
Use a nested meta query when querying by role in `WP_User_Query`.
...
If a user query includes a meta query together with a role argument,
nest the original meta query and append the role meta query with an
AND relationship.
fixes #23849 , #27026 .
Built from https://develop.svn.wordpress.org/trunk@30094
git-svn-id: http://core.svn.wordpress.org/trunk@30094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:41:22 +00:00
Boone Gorges
beaa3f6928
Support an empty string passed as a status in `WP_Comment_Query`.
...
The changes in [30084] broke backward compatibility with interfaces that
manually passed an empty string for the value of 'status', such as on
wp-admin/edit-comments.php.
Fixes #29612 .
Built from https://develop.svn.wordpress.org/trunk@30093
git-svn-id: http://core.svn.wordpress.org/trunk@30093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 19:51:23 +00:00
Peter Westwood
664f19e28a
Comment Template Tags: Improve the availability of context information in comment template tag filters.
...
Fixes #22380 props momo360modena, tareq1988.
Built from https://develop.svn.wordpress.org/trunk@30092
git-svn-id: http://core.svn.wordpress.org/trunk@30092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 19:07:22 +00:00
John Blackbourn
a866a7192f
Introduce some actions and filters which aid plugins in revisioning post meta.
...
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
* `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
* `wp_creating_autosave` action which is fired just before an autosave is created.
See #20564 .
Props mattheu, adamsilverstein.
Built from https://develop.svn.wordpress.org/trunk@30091
git-svn-id: http://core.svn.wordpress.org/trunk@30091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 19:02:21 +00:00
John Blackbourn
9a16b52018
Revert [28610] in order to avoid infinite redirect loops on reverse proxies which proxy from HTTPS to HTTP. This will be revisited at some point, possibly as an option via a filter.
...
Fixes #28610 .
Built from https://develop.svn.wordpress.org/trunk@30090
git-svn-id: http://core.svn.wordpress.org/trunk@30090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 18:37:25 +00:00
Mark Jaquith
6de35acf28
Increase both mystery and humanism
...
Built from https://develop.svn.wordpress.org/trunk@30089
git-svn-id: http://core.svn.wordpress.org/trunk@30089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 03:20:24 +00:00
Boone Gorges
e9adba887d
Introduce `'pre_delete_term'` hook.
...
Props cmmarslender.
Fixes #30127 .
Built from https://develop.svn.wordpress.org/trunk@30088
git-svn-id: http://core.svn.wordpress.org/trunk@30088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 02:44:22 +00:00
John Blackbourn
d70744e95c
Correct some logic to populate the `defaultValue` variable when `data.defaultValue` begins with a hash symbol.
...
Props antpb
Fixes #30125
Built from https://develop.svn.wordpress.org/trunk@30087
git-svn-id: http://core.svn.wordpress.org/trunk@30087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 02:43:22 +00:00
Boone Gorges
4013156e51
Be more specific in documentation of 'slug' param for `get_terms()`.
...
Props jfarthing84.
Fixes #23636 .
Built from https://develop.svn.wordpress.org/trunk@30086
git-svn-id: http://core.svn.wordpress.org/trunk@30086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 02:35:23 +00:00
Boone Gorges
d7a62c01c4
Improve global variable setting in `setup_postdata()`.
...
`setup_postdata()` is responsible for setting a number of global variables
that are used for post pagination (`$pages`, `$page`, `$nextpage`) and the
generation of post excerpts (`$more`). These variables should be sensitive to
the currently running instance of `WP_Query` - rather than the main query -
so that these features work properly inside of secondary `WP_Query` loops.
This changeset moves the logic of `setup_postdata()` into a method on `WP_Query`,
and converts `setup_postdata()` to a wrapper.
Props boonebgorges, wonderboymusic.
See #25349 .
Fixes #9256 , #20904 .
Built from https://develop.svn.wordpress.org/trunk@30085
git-svn-id: http://core.svn.wordpress.org/trunk@30085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 02:32:24 +00:00
Boone Gorges
3b90929c3e
Support multiple 'status' values in `WP_Comment_Query`.
...
This change required turning the SQL concatenation into the generation of an
array, for greater flexibility.
Props karpstrucking, ebinnion.
Fixes #29612 .
Built from https://develop.svn.wordpress.org/trunk@30084
git-svn-id: http://core.svn.wordpress.org/trunk@30084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 02:22:23 +00:00
Scott Taylor
6142a650b7
Allow developers to override the `settings.success` callback for MediaElement players.
...
Props nofearinc.
Fixes #30029 .
Built from https://develop.svn.wordpress.org/trunk@30083
git-svn-id: http://core.svn.wordpress.org/trunk@30083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 01:21:24 +00:00
Scott Taylor
3d8e31fb82
Don't hardcode `height` for videos - this was a workaround for MediaElement internals causing problems. Responsive videos now work properly and don't cause extra whitespace.
...
Fixes MediaElement by hand in the interim: https://github.com/johndyer/mediaelement/pull/1337
Video playlists were completely broken by this.
Fixes #30078 .
Built from https://develop.svn.wordpress.org/trunk@30082
git-svn-id: http://core.svn.wordpress.org/trunk@30082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 00:47:24 +00:00
Lance Willett
85d3601ef6
Twenty Fifteen: only escape HTML attribute output with `esc_attr()`. See #30133 , props ocean90.
...
Built from https://develop.svn.wordpress.org/trunk@30081
git-svn-id: http://core.svn.wordpress.org/trunk@30081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 23:08:23 +00:00
Boone Gorges
865e8b5faf
Remove call to `wp_get_last_changed()` from unit tests.
...
This function was removed in [30073].
See #21760 .
Built from https://develop.svn.wordpress.org/trunk@30080
git-svn-id: http://core.svn.wordpress.org/trunk@30080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 22:03:25 +00:00
Aaron Jorbin
2261f4ceb4
Update images based on grunt imagemin
...
The new version of imagemin that was added in r30059 condenses some images more.
see #30141
Built from https://develop.svn.wordpress.org/trunk@30079
git-svn-id: http://core.svn.wordpress.org/trunk@30079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 22:02:22 +00:00
Mark Jaquith
a81a321f9a
Docs and code standards cleanup for [30055] (`wp_json_encode()` & friends)
...
fixes #28786
props TobiasBg
Built from https://develop.svn.wordpress.org/trunk@30078
git-svn-id: http://core.svn.wordpress.org/trunk@30078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 21:29:23 +00:00
Boone Gorges
682fb09f01
Update inline docs for [30052].
...
Fixes #23261 .
Built from https://develop.svn.wordpress.org/trunk@30077
git-svn-id: http://core.svn.wordpress.org/trunk@30077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 21:26:22 +00:00
Scott Taylor
ee97a47c61
In `_wp_handle_upload()`, if `test_upload` is set to `false` in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage.
...
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.
`$test_upload` override is now a noop.
Fixes #28208 .
Built from https://develop.svn.wordpress.org/trunk@30076
git-svn-id: http://core.svn.wordpress.org/trunk@30076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 21:17:22 +00:00
Mark Jaquith
45afcde640
Define `JSON_PRETTY_PRINT` so it can be used with `wp_json_encode()`
...
* `JSON_PRETTY_PRINT` was introduced in PHP 5.4
* Now you can use it with lower PHP versions, without a notice
fixes #30139
see #28786
Built from https://develop.svn.wordpress.org/trunk@30075
git-svn-id: http://core.svn.wordpress.org/trunk@30075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 21:13:22 +00:00