Commit Graph

15549 Commits

Author SHA1 Message Date
Sergey Biryukov 8cc6732b03 Consistently handle an empty site title in Site and My Sites toolbar menus.
see #28682.
Built from https://develop.svn.wordpress.org/trunk@30598


git-svn-id: http://core.svn.wordpress.org/trunk@30588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 08:13:24 +00:00
Sergey Biryukov 8c091940a3 When live-updating site title in toolbar, fall back to the site url if the title is empty.
props avryl.
see #28682.
Built from https://develop.svn.wordpress.org/trunk@30597


git-svn-id: http://core.svn.wordpress.org/trunk@30587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 08:12:23 +00:00
Sergey Biryukov 0a8b72866e Add missing periods to strings introduced in [30333].
props DrewAPicture.
see #30264.
Built from https://develop.svn.wordpress.org/trunk@30596


git-svn-id: http://core.svn.wordpress.org/trunk@30586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 06:26:22 +00:00
Drew Jaynes a899bbaee7 Improve inline documentation in `wp_ajax_destroy_sessions()`.
If the token is set (`$keep` is a string), this means the user is viewing their own profile-editing screen and destroying their own sessions (except the current one). If it isn't set (`$keep` is null), the user is editing another user's profile and destroying all of their sessions with no exceptions.

See #30264, #30469

Built from https://develop.svn.wordpress.org/trunk@30595


git-svn-id: http://core.svn.wordpress.org/trunk@30585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 03:48:22 +00:00
Andrew Ozz 9a4a968172 Editor: move the DFW v2 transitions CSS from editor.css to wp-admin.css. They are needed only on the Edit Post screen.
See #30453.
Built from https://develop.svn.wordpress.org/trunk@30594


git-svn-id: http://core.svn.wordpress.org/trunk@30584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 02:36:23 +00:00
Andrew Ozz 9e8f2c7794 Editor: use the Alt+Shift+W keyboard shortcut for new DFW from both the Visual and Text editors. Props afercia, fixes #30450.
Built from https://develop.svn.wordpress.org/trunk@30593


git-svn-id: http://core.svn.wordpress.org/trunk@30583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 01:44:22 +00:00
John Blackbourn 8f219ed949 Revert [30032] so appropriate PHP warnings aren't masked.
Fixes #28743

Built from https://develop.svn.wordpress.org/trunk@30592


git-svn-id: http://core.svn.wordpress.org/trunk@30582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 01:29:23 +00:00
Andrew Ozz 9597159393 Better error message when the admin is ssl and non-ssl oEmbed previews are not available in the editor. Props Japh, fixes #30533.
Built from https://develop.svn.wordpress.org/trunk@30591


git-svn-id: http://core.svn.wordpress.org/trunk@30581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 22:37:24 +00:00
Ian Stewart 85e5ab64a5 Twenty Fifteen: better highlights for tapped links in iOS Safari.
Props iamtakashi, fixes #30524.



Built from https://develop.svn.wordpress.org/trunk@30590


git-svn-id: http://core.svn.wordpress.org/trunk@30580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 20:41:22 +00:00
Ian Stewart e2133880c1 Twenty Fifteen: overflow hidden can hide focus outlines here so out it goes.
Props iamtakashi, fixes #30523.


Built from https://develop.svn.wordpress.org/trunk@30589


git-svn-id: http://core.svn.wordpress.org/trunk@30579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 20:36:24 +00:00
Ian Stewart 2e123ad458 Twenty Fifteen: minor corrections to borders and post title colors in custom color schemes.
Props iamtakashi, fixes #30521.



Built from https://develop.svn.wordpress.org/trunk@30588


git-svn-id: http://core.svn.wordpress.org/trunk@30578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 20:34:24 +00:00
Gary Pendergast 8990b1c1fc WPDB: Remove the addition of `STRICT_ALL_TABLES`, added in [30400]. This proved to be incompatible with too many plugins, as well as being incompatible with MySQL 5.7.
See #21212.

Built from https://develop.svn.wordpress.org/trunk@30587


git-svn-id: http://core.svn.wordpress.org/trunk@30577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 11:00:23 +00:00
Andrew Ozz 4d651b90bb Editor: limit scrolling triggered when TinyMCE is auto-resized to 100px. Prevents auto-scrolling on page load. Fixes #30515.
Built from https://develop.svn.wordpress.org/trunk@30586


git-svn-id: http://core.svn.wordpress.org/trunk@30576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 01:00:25 +00:00
Boone Gorges 213ecc8a07 Revert shared taxonomy term splitting for 4.1.
This is a revert of [30494], [30492], [30347], and [30334]. The latter
changeset was a revert of [30336], which was a revert of [30241].

Watch for Term Splitting, Version III in version 4.2, coming soon to a
WordPress trunk near you.

See #30335, #5809.
Built from https://develop.svn.wordpress.org/trunk@30585


git-svn-id: http://core.svn.wordpress.org/trunk@30575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 00:05:22 +00:00
Andrew Ozz 92bcf2dbcb Remove unused CSS and JS from wp-mce-help.php, see #30517.
Built from https://develop.svn.wordpress.org/trunk@30584


git-svn-id: http://core.svn.wordpress.org/trunk@30574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 23:23:23 +00:00
Andrew Ozz 4855f36478 Editor: fix warnings in class-wp-editor.php, see #30453.
Built from https://develop.svn.wordpress.org/trunk@30583


git-svn-id: http://core.svn.wordpress.org/trunk@30573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 23:04:21 +00:00
Mark Jaquith 1d3b040d7d Remove old DFW width adjustment help text.
fixes #30517
Built from https://develop.svn.wordpress.org/trunk@30582


git-svn-id: http://core.svn.wordpress.org/trunk@30572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 22:30:23 +00:00
Dominik Schilling 47f89b1d91 Remove unbounded check for "install.php" in `wp_not_installed()`.
The check is true for `wp-admin/plugin-install.php` and `wp-admin/theme-install.php` too. This will end in a redirect to `/wp-admin/upgrade.php` or a screen with a bunch of errors.
The `WP_INSTALLING` constant was added in WordPress 1.5.1 to `wp-admin/install.php` which makes the check for "install.php" redundant.

props joemcgill.
fixes #29694.
Built from https://develop.svn.wordpress.org/trunk@30581


git-svn-id: http://core.svn.wordpress.org/trunk@30571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 20:56:23 +00:00
Drew Jaynes e4f52df62c Fix DocBlock formatting for `wp_generate_password()`.
Props stevegrunwell for the initial patch.
Fixes #30509.

Built from https://develop.svn.wordpress.org/trunk@30580


git-svn-id: http://core.svn.wordpress.org/trunk@30570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 20:38:23 +00:00
Dominik Schilling 7e0c893415 Comments: Use proper HTTP response codes for validation errors.
props miqrogroove, solarissmoke, mackensen.
fixes #11286.
Built from https://develop.svn.wordpress.org/trunk@30579


git-svn-id: http://core.svn.wordpress.org/trunk@30569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 20:17:24 +00:00
Dominik Schilling 184d327ff4 Network Admin: Improve width of input fields on Add New Site and Edit Site screens.
props honeysilvas.
fixes #16383.
Built from https://develop.svn.wordpress.org/trunk@30578


git-svn-id: http://core.svn.wordpress.org/trunk@30568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 19:51:23 +00:00
John Blackbourn 3a4f742175 Remove the `wp_is_trusted_network()` function pending further discussion on terminology and behaviour.
See #30145

Built from https://develop.svn.wordpress.org/trunk@30577


git-svn-id: http://core.svn.wordpress.org/trunk@30567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 19:27:23 +00:00
Dominik Schilling e002b0fc07 Type cast `$nonce` to string in `wp_verify_nonce()`.
props jesin.
fixes #29542.
Built from https://develop.svn.wordpress.org/trunk@30576


git-svn-id: http://core.svn.wordpress.org/trunk@30566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 19:19:23 +00:00
Dion Hulse aba2a6bcfd Fix the PHPDoc example for _split_str_by_whitespace().
Props voldemortensen. Fixes #30504

Built from https://develop.svn.wordpress.org/trunk@30575


git-svn-id: http://core.svn.wordpress.org/trunk@30565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 03:52:22 +00:00
Andrew Ozz 97c81c4507 Editor: add a pointer for the new DFW button. Remove the wp350_media and wp360_revisions pointers from the same screens. See #30458.
Built from https://develop.svn.wordpress.org/trunk@30574


git-svn-id: http://core.svn.wordpress.org/trunk@30564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 02:54:25 +00:00
Andrew Ozz af1e417d4e Editor:
- Add CSS reset for the TinyMCE fullscreen mode when used on the Edit Post screen.
- Fix loading of the old and new DFW buttons, use another arg. passed to WP_Editors.
- Reset editor-expand when exiting TinyMCE fullscreen mode.
Fixes #30453.
Built from https://develop.svn.wordpress.org/trunk@30573


git-svn-id: http://core.svn.wordpress.org/trunk@30563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 02:50:24 +00:00
Ian Stewart 7e4486803b Twenty Fifteen: docs correction.
Props rachelbaker, DrewAPicture, fixes #30456


Built from https://develop.svn.wordpress.org/trunk@30572


git-svn-id: http://core.svn.wordpress.org/trunk@30562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 21:11:22 +00:00
Ian Stewart 99c003c35d Twenty Fifteen: update the .pot file.
Props iamtakashi, fixes #30433.


Built from https://develop.svn.wordpress.org/trunk@30571


git-svn-id: http://core.svn.wordpress.org/trunk@30561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 21:08:23 +00:00
Ian Stewart a360658866 Twenty Fifteen: make sure the 'says:' in comments is readable by a screen-reader.
Fixes #30479.


Built from https://develop.svn.wordpress.org/trunk@30570


git-svn-id: http://core.svn.wordpress.org/trunk@30560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 21:05:23 +00:00
Ian Stewart e11418abdc Twenty Fifteen: docs correction and cleanup.
Props DrewAPicture, see #30149.


Built from https://develop.svn.wordpress.org/trunk@30569


git-svn-id: http://core.svn.wordpress.org/trunk@30559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 20:57:24 +00:00
Ian Stewart 7a643924c2 Twenty Fifteen: correct number of menus used in comments
Props jeherve, see #30149


Built from https://develop.svn.wordpress.org/trunk@30568


git-svn-id: http://core.svn.wordpress.org/trunk@30558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 20:38:25 +00:00
Ian Stewart cb2dcb9820 Twenty Fifteen: remove unneeded custom header admin callbacks.
Props philiparthurmoore, fixes #30432.


Built from https://develop.svn.wordpress.org/trunk@30567


git-svn-id: http://core.svn.wordpress.org/trunk@30556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 15:12:22 +00:00
Ian Stewart a88ec3f9de Twenty Fifteen: prevent too-wide tables from popping out of posts.
Props iamtakashi, fixes #30420


Built from https://develop.svn.wordpress.org/trunk@30566


git-svn-id: http://core.svn.wordpress.org/trunk@30555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 15:04:23 +00:00
Ian Stewart 654047e35b Twenty Fifteen: pinching to zoom in on landscape on iPads is breaking the layout with the sticky sidebar. Providing a one-column view on those screens looks good and will likely prevent other bugs we don't even know about.
Props iamtakashi, fixes #30366.



Built from https://develop.svn.wordpress.org/trunk@30565


git-svn-id: http://core.svn.wordpress.org/trunk@30554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 14:58:21 +00:00
Ian Stewart 45343aa5d2 Twenty Fifteen: a shorter header on small screens when there is no header text or header image looks more correct.
Props iamtakashi, fixes #30326.



Built from https://develop.svn.wordpress.org/trunk@30564


git-svn-id: http://core.svn.wordpress.org/trunk@30553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 14:47:22 +00:00
Dominik Schilling 61fd87f1f7 Update `embedded.png` after running `grunt imagemin`.
After [30059] and [30079] we still had four images which could be minified. Three of them are handled by [30562], the last one by this.

fixes #30141.
Built from https://develop.svn.wordpress.org/trunk@30563


git-svn-id: http://core.svn.wordpress.org/trunk@30552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 14:09:22 +00:00
Andrew Ozz 0517ee7c6e TwentyFifteen:
- Fix image caption alignment in the editor.
- Remove unused var from functions.js.
Also includes few images that were shrunk a bit when running grunt precommit.
Fixes #30493.
Built from https://develop.svn.wordpress.org/trunk@30562


git-svn-id: http://core.svn.wordpress.org/trunk@30551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 06:12:22 +00:00
Gary Pendergast a62fc4e4e5 When `json_encode()` returns a JSON string containing `'null'` in PHP 5.4 or earlier, `wp_json_encode()` will now sanity check the data, as older versions of PHP failed to encode non UTF-8 characters correctly, instead returning `'null'`.
Fixes #30471.

Built from https://develop.svn.wordpress.org/trunk@30561


git-svn-id: http://core.svn.wordpress.org/trunk@30550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 05:01:23 +00:00
Andrew Ozz f3ba529c2f TinyMCE: don't hide the image toolbar when the iframe window fires onresize. There is a bug in several browsers that triggers onresize when a tooltip is shown, only in RTL mode. Also use better variable name. Fixes #30147.
Built from https://develop.svn.wordpress.org/trunk@30560


git-svn-id: http://core.svn.wordpress.org/trunk@30549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 04:31:23 +00:00
Jeremy Felt a71d642a05 Add basic unit tests for `is_plugin_active_for_network()`
Props rodrigosprimo
Fixes #30491

Built from https://develop.svn.wordpress.org/trunk@30559


git-svn-id: http://core.svn.wordpress.org/trunk@30548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 04:03:25 +00:00
Andrew Ozz 20e753a8c7 TinyMCE: use the actual image node when calculating the position of the toolbar. Fixes a bug in old IE. See #30147.
Built from https://develop.svn.wordpress.org/trunk@30558


git-svn-id: http://core.svn.wordpress.org/trunk@30547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 01:22:21 +00:00
Boone Gorges 94b72ccba4 Add basic unit tests for `is_plugin_active()` and `is_plugin_inactive()`.
Props voldemortensen.
Fixes #30489.
Built from https://develop.svn.wordpress.org/trunk@30557


git-svn-id: http://core.svn.wordpress.org/trunk@30546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 01:13:23 +00:00
Dominik Schilling 5742174ba8 Remove incorrect documentation for `wp.media()`.
props ericlewis.
fixes #30090.
Built from https://develop.svn.wordpress.org/trunk@30556


git-svn-id: http://core.svn.wordpress.org/trunk@30545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 23:12:22 +00:00
Dominik Schilling f5e4c9ee04 Improve the focus style for review links in the plugin info modal.
props johnbillion.
fixes #30375.
Built from https://develop.svn.wordpress.org/trunk@30555


git-svn-id: http://core.svn.wordpress.org/trunk@30544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 22:59:21 +00:00
Dominik Schilling e39c43ad6c Clear update caches when site language is changed.
The update screen has a re-install button which could show the wrong language locale after the site language was changed. That's because the update data is cached. 
Introduce `_wp_clear_update_cache()` as a helper function to clean up the update cache.

props SergeyBiryukov, ocean90.
fixes #30369.
Built from https://develop.svn.wordpress.org/trunk@30554


git-svn-id: http://core.svn.wordpress.org/trunk@30543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 22:50:22 +00:00
Dominik Schilling 6b51f14c6f Customizer: Only show the default button in the upload control if there is a default attachment.
props celloexpressions.
see #21483.
Built from https://develop.svn.wordpress.org/trunk@30553


git-svn-id: http://core.svn.wordpress.org/trunk@30542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 22:31:23 +00:00
Dominik Schilling d187a5eeba Customizer: Don't override `Section.isContextuallyActive()` in `SidebarSection`.
This fixes a bug where empty widget areas get deactivated in the Customizer.

fixes #30378.
see #30235.
props westonruter.
Built from https://develop.svn.wordpress.org/trunk@30552


git-svn-id: http://core.svn.wordpress.org/trunk@30541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 22:26:23 +00:00
Dominik Schilling aace02c0c0 Update the Iris color picker to version 1.0.6.
Changes: https://github.com/Automattic/Iris/compare/1.0.4...1.0.6

props mattwiebe.
fixes #30365.
Built from https://develop.svn.wordpress.org/trunk@30551


git-svn-id: http://core.svn.wordpress.org/trunk@30540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 22:17:22 +00:00
Dominik Schilling 3cb1fb9c18 Editor CSS: Add missing semicolons.
props cfoellmann.
fixes #30487.
Built from https://develop.svn.wordpress.org/trunk@30550


git-svn-id: http://core.svn.wordpress.org/trunk@30539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 21:54:23 +00:00
Boone Gorges 4ba21e7e0b Fix the unit tests for Imagick alpha.
These tests were written to use the `assertImageAtAlpha()` helper method, whose
internals were specific to GD. As a result, the tests could not pass. This
changeset introduces GD- and Imagick-specific versions of this method.

Props voldemortensen.
Fixes #24871.
Built from https://develop.svn.wordpress.org/trunk@30549


git-svn-id: http://core.svn.wordpress.org/trunk@30538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 20:57:24 +00:00
Boone Gorges db7b12e25c Declare an explicit 'order' in `test_get_comments_by_user()`.
This change fixes broken builds on older versions of MySQL. See #30462.

Assertions regarding indeterminate secondary ORDER BY clauses will go in
separate test methods. See #30478.
Built from https://develop.svn.wordpress.org/trunk@30548


git-svn-id: http://core.svn.wordpress.org/trunk@30537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 14:56:25 +00:00
Peter Westwood 6c40c6f2e2 Fix the passing of commenter cookie data to the comment API so that we don't try and fetch all unapproved comments for users with no-email address when we only have an author.
Fixes #19623

Built from https://develop.svn.wordpress.org/trunk@30547


git-svn-id: http://core.svn.wordpress.org/trunk@30536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 10:51:22 +00:00
Drew Jaynes 4b6abbaff4 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30546


git-svn-id: http://core.svn.wordpress.org/trunk@30535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 06:31:21 +00:00
Drew Jaynes 3b6c9519a8 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape HTML tags in several argument descriptions for `wp_link_pages()`
* Remove an HTML tag from the summary for `prepend_attachment()`
* Backtick-escape inline code in the description for `get_extended()`
* Backtick-escape inline code in the description for `get_post_type_labels()`
* Various markdown formatting in the description for `add_rewrite_endpoint()`
* Markdown-indent a code snippet in the file header for wp-includes/shortcodes.php
* Markdown-indent code snippets in the description for `add_shortcode()

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30545


git-svn-id: http://core.svn.wordpress.org/trunk@30534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 06:15:24 +00:00
Drew Jaynes 188e47869f Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `wp_salt()`
* Backtick-escape inline code in the return description for `get_avatar()`
* Various markdown formatting in the description for `add_filter()`
* Markdown-indent a code snippet in the description for `apply_filters()`
* Backtick-escape inline code in the `@see` description for `apply_filters_ref_array()`
* Backtick-escape inline code in the description for `do_action()`
* Backtick-escape variables in the parameter and return descriptions for `do_action_ref_array()`
* Various markdown formatting in the description for `get_plugin_data()`

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30544


git-svn-id: http://core.svn.wordpress.org/trunk@30533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 06:05:23 +00:00
Drew Jaynes 9955384dbe Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30543


git-svn-id: http://core.svn.wordpress.org/trunk@30532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:53:22 +00:00
Drew Jaynes b8c612ca1c Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the file header for wp-admin/install-helper.php
* Add markdown formatting and two inline `@see` tags to the description for `translate()`
* Markdown-indent a code snippet in the description for `_n_noop()`
* Remove HTML tags from the summary for `get_media_embedded_in_content()`
* Remove an HTML tag from the summary for `wpview_media_sandbox_styles()`

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30542


git-svn-id: http://core.svn.wordpress.org/trunk@30531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:47:23 +00:00
Drew Jaynes 07c58f5cca Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `_deprecated_argument()`
* Markdown-indent a code snippet in the description for `wp_localize_script()`
* Backtick-escape HTML tags in two parameter descriptions for `wp_register()`
* Various DocBlock formatting in the description for `get_bloginfo()`
* Remove HTML tag from the summary for `_wp_render_title_tag()`
* Backtick-escape a HTML tag in the description for `get_archives_link()`
* Markdown-indent a code snippet in the description for `wp_admin_css_color()`
* Markdown-indent a code snippet in the description for the `welcome_panel` hook

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30541


git-svn-id: http://core.svn.wordpress.org/trunk@30530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:39:22 +00:00
Drew Jaynes 39da8dd15e Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements in wp-includes/formatting.php:
* Markdown-indent code snippets in the description for `wptexturize()`
* Backtick-escape inline code in a parameter description for `_wptexturize_pushpop_element()`
* Backtick-escape inline code in the description for `shortcode_unautop()`
* Backtick-escape HTML tags in the description for `convert_chars()`
* Markdown-indent a code snippet in the description for `_split_str_by_whitespace()`
* Backtick-escape an `<img>` tag in the description for `translate_smiley()`
* Add markdown formatting to the description for `links_add_target()`
* Backtick-escape HTML tags in the description for `wp_strip_all_tags()`

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30540


git-svn-id: http://core.svn.wordpress.org/trunk@30529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:30:25 +00:00
Drew Jaynes cc68de7006 Ensure the DocBlock directly precedes the hook line for the `post_edit_form_tag` action in wp-admin/edit-form-advanced.php.
This fixes the parser getting confused about which DocBlock belongs to which hook or function in this file.

See #30473.

Built from https://develop.svn.wordpress.org/trunk@30539


git-svn-id: http://core.svn.wordpress.org/trunk@30528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:22:23 +00:00
Drew Jaynes de809a5a86 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30538


git-svn-id: http://core.svn.wordpress.org/trunk@30527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:19:23 +00:00
Drew Jaynes 273396fe1e Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escapes a `<link>` tag in a parameter description for the `embed_oembed_discover` hook
* Inline code fixes in the summary and return description for `WP_List_Table::get_table_classes()`
* Removes HTML markup from the summary for `WP_List_Table::display_rows_or_placeholder()`
* Backtick-escapes a `<tr>` tag in a parameter description for `WP_Users_List_Table::single_row()`
* Converts non-DocBlocks into multi-line comments in `WP_Dependencies::do_items()`
* Removes HTML markup from the summary for the `comment_form_top` hook.
* Inline code and snippet fixes in the description for `wp_get_schedules()`

Props rarst for the initial patch.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30537


git-svn-id: http://core.svn.wordpress.org/trunk@30526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 04:58:22 +00:00
Drew Jaynes 8f6188ae53 Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Two arguments in `_walk_bookmarks()`
* A code snippet in the class header for `WP_Roles`
* A code snippet in the class header for `WP_HTTP_Proxy`
* Inline code fixes in the summary and a parameter description for `WP_oEmbed::discover()`
* An argument description in `_WP_Editors::parse_settings()`
* Inline code fixes in the summary and a parameter description the `embed_oembed_discover` hook.

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30536


git-svn-id: http://core.svn.wordpress.org/trunk@30525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 04:42:22 +00:00
Drew Jaynes 6d0cdd7148 Remove HTML `<head>` tags from DocBlock summaries in wp-admin/admin-header.php.
Also better-specify the `$hook_suffix` value in the `admin_head-$hook_suffix` hook docs per hook documentation precedent.

Props rarst for the initial patch.
See #30473

Built from https://develop.svn.wordpress.org/trunk@30535


git-svn-id: http://core.svn.wordpress.org/trunk@30524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 04:27:23 +00:00
Gary Pendergast 12684e0ec8 `json_encode()` returns different results for non UTF-8 strings in PHP 5.5+, versus earlier versions of PHP.
This fixes the unit tests that fail in earlier versions, see #30471 for fixing this globally in `wp_json_encode()`.

Built from https://develop.svn.wordpress.org/trunk@30534


git-svn-id: http://core.svn.wordpress.org/trunk@30523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 01:56:24 +00:00
Gary Pendergast 18ae2c0b44 Split the tests for `wp_json_encode()` into smaller chunks (let's all them "units"). Skip a couple of these tests when running on older versions of PHP that don't support the tested functionality.
See #28786.

Built from https://develop.svn.wordpress.org/trunk@30533


git-svn-id: http://core.svn.wordpress.org/trunk@30522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 23:52:23 +00:00
Drew Jaynes 0fb8811fb6 Improve return description for `get_file_data()` documentation.
Also convert an incorrect use of `@see` to `@link`.

Props 5um17 for the initial patch.
Fixes #30466.

Built from https://develop.svn.wordpress.org/trunk@30532


git-svn-id: http://core.svn.wordpress.org/trunk@30521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 17:57:22 +00:00
Andrew Ozz e8a4452f05 Color Schemes: fix the pointer UP arrow color, fixes #30460.
Built from https://develop.svn.wordpress.org/trunk@30531


git-svn-id: http://core.svn.wordpress.org/trunk@30520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 01:26:23 +00:00
Boone Gorges 58256224fe Remove failing `test_network_limit()` XML-RPC test.
Test added as a patch on #21292.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30530


git-svn-id: http://core.svn.wordpress.org/trunk@30519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 01:23:22 +00:00
Boone Gorges 20302cbd82 Better rewrite rule flushing in `test_permalink_without_title()`.
This ensures that the test is not polluted by permalink structure changes in
earlier tests.
Built from https://develop.svn.wordpress.org/trunk@30529


git-svn-id: http://core.svn.wordpress.org/trunk@30518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 01:20:24 +00:00
Boone Gorges 144d7ed48c Ensure that `wpdb_exposed_methods_for_testing` is available to all tests.
It should be defined in a common library file so that all tests have access to
it, even when run in isolation.

See [30345], #21212.
Built from https://develop.svn.wordpress.org/trunk@30528


git-svn-id: http://core.svn.wordpress.org/trunk@30517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 00:47:22 +00:00
Boone Gorges de1f2d6ad7 Ensure `sanitize_user()` expected test values are lowercase on multisite.
[30524] neglected to account for the fact that multisite forces user logins to
lowercase.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30527


git-svn-id: http://core.svn.wordpress.org/trunk@30516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 21:30:24 +00:00
Boone Gorges 21771656ea Stop checking Trac to skip tests against open tickets.
In general, skipped tests should live only in patches, which are committed at
the same time that the corresponding bug is fixed. In cases where it's
necessary to skip a test, use `markTestSkipped()` to declare this fact
explicitly.

We continue to check Trac when using `WP_UnitTestCase` to run non-core tests.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30526


git-svn-id: http://core.svn.wordpress.org/trunk@30515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 21:11:24 +00:00
Boone Gorges a18e2f68c7 Repair the `seems_utf8()` tests that use Big5 encoding.
* Provide sample data that is actually encoded in Big5.
* Do some actual assertions against that data.

Props akumria.
Fixes #30455.
Built from https://develop.svn.wordpress.org/trunk@30525


git-svn-id: http://core.svn.wordpress.org/trunk@30514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:57:24 +00:00
Boone Gorges 503defbf43 Remove failing test related to the 'offset' param of `WP_Query`.
This test has been added as a patch to #18897.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30524


git-svn-id: http://core.svn.wordpress.org/trunk@30513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:46:22 +00:00
Boone Gorges 6a5c146953 Remove failing test related to `wp_list_pages()`.
The test has been added as a patch to #27326.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30523


git-svn-id: http://core.svn.wordpress.org/trunk@30512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:44:22 +00:00
Boone Gorges 181fec554f Remove failing test related to `wp_unique_post_slug()`.
The test has been added as a patch to #18962.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30522


git-svn-id: http://core.svn.wordpress.org/trunk@30511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:42:22 +00:00
Boone Gorges 7481a15ad8 Remove failing `is_textdomain_loaded()` test.
The removed test has been added as a patch to the original ticket, #21319.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30521


git-svn-id: http://core.svn.wordpress.org/trunk@30510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:37:22 +00:00
Boone Gorges 4c40127397 Remove failing assertions from `is_serialized()` tests.
They have been moved to new test methods, which have been attached as a patch
to the ticket #9930.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30520


git-svn-id: http://core.svn.wordpress.org/trunk@30509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:35:22 +00:00
Boone Gorges 4f47412a03 Remove failing test in the `hooks` group.
The removed test has been added as a patch to #21169.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30519


git-svn-id: http://core.svn.wordpress.org/trunk@30508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:26:22 +00:00
Boone Gorges f1b5a879c5 Remove skipped tests for `WP_Export_Query`.
These tests have been added as a patch to the ticket where the new
functionality was originally proposed, #22435.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30518


git-svn-id: http://core.svn.wordpress.org/trunk@30507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:23:22 +00:00
Boone Gorges 550f8ad9e8 Remove skipped tests for unimplemented JS plural functions.
The tests have been added as a patch for the original ticket, #22229.

Props MikeHansenMe.
See #22229.
Built from https://develop.svn.wordpress.org/trunk@30517


git-svn-id: http://core.svn.wordpress.org/trunk@30506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:12:23 +00:00
Boone Gorges 3042b7afd5 Remove failing test for unimplemented `wp_mail()` enhancement.
The removed test has been added as a patch to the original ticket, #15448.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30516


git-svn-id: http://core.svn.wordpress.org/trunk@30505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:06:25 +00:00
Boone Gorges 025d1b388b Improvements to encoded character formatting tests.
In `sanitize_title_with_dashes()` and `sanitize_user()` tests, we break large
test methods into smaller ones in order to isolate those that actually describe
the bug being reported in ticket #10823. The unit tests that are continuing to
fail have been attached as a patch to that ticket.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30515


git-svn-id: http://core.svn.wordpress.org/trunk@30504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 19:54:21 +00:00
Boone Gorges 3422675eda Remove failing tests related to square brackets being stripped in URL sanitizers.
These tests have been added as a patch to their original ticket, #16859.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30514


git-svn-id: http://core.svn.wordpress.org/trunk@30503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 15:40:22 +00:00
Boone Gorges c4d9abb74f Remove failing tests related to `WP_User::__unset()`.
These tests have been added as a patch to their original ticket, #20043.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30513


git-svn-id: http://core.svn.wordpress.org/trunk@30502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 15:36:22 +00:00
Boone Gorges cb4f0c8b8e Declare user_email when setting up fixtures for `count_user_posts()` tests.
Because `setUpBeforeClass()` is called statically and creates its own factory
object, the iterator logic from previous tests is not carried over to these
fixtures, and we risk the possibility of user_email clashes when the tests are
run in certain limited configurations.
Built from https://develop.svn.wordpress.org/trunk@30512


git-svn-id: http://core.svn.wordpress.org/trunk@30501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 15:05:22 +00:00
Boone Gorges cc10fa74a5 Improve performance of post revision order test.
`test_revision_order()` was written ([28541], #26042) to ensure that revision
order was properly preserved in two different cases: (1) where the post_date
varied (in which case the revisions would be sorted by post_date DESC) and
(2) where the post_date was the same (in which case sorting would fall back on
ID DESC). In an attempt to ensure that both of these scenarios arose in the
context of a single test, 100 posts were created. We can make the process far
more efficient by manually creating the revisions with the post_dates
explicitly declared, and splitting the two different cases into two separate
test methods.

This test was previously the single worst offender in the entire suite, taking
upwards of 15 seconds to run. All that most maddens and torments; all that stirs
up the lees of things; all truth with malice in it; all that cracks the sinews
and cakes the brain; all the subtle demonisms of life and thought; all evil, to
crazy Boone, were visibly personified, and made practically assailable in
`test_revision_order()`.

See #30017.
Built from https://develop.svn.wordpress.org/trunk@30511


git-svn-id: http://core.svn.wordpress.org/trunk@30500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 14:18:23 +00:00
Boone Gorges 9f40944e49 Remove some failing unit tests from the `post` group.
These tests have been added as a patch to ticket #19373.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30510


git-svn-id: http://core.svn.wordpress.org/trunk@30499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 12:04:25 +00:00
Andrew Ozz d3604f485d TinyMCE: set the image toolbar's z-index to be the same as the other TinyMCE panels, or it is under the editor when in fullscreen mode. See #30147.
Built from https://develop.svn.wordpress.org/trunk@30509


git-svn-id: http://core.svn.wordpress.org/trunk@30498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 02:43:24 +00:00
John Blackbourn 78367f22d5 Abstract the theme browser route paths into attributes so they can be easily overridden.
Fixes #30116
Props matveb

Built from https://develop.svn.wordpress.org/trunk@30508


git-svn-id: http://core.svn.wordpress.org/trunk@30497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 17:30:22 +00:00
John Blackbourn b66c58f76a Update the inline docs for `wp_die()` to reflect parameter changes made in r30355
See #10551

Built from https://develop.svn.wordpress.org/trunk@30507


git-svn-id: http://core.svn.wordpress.org/trunk@30496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 17:08:23 +00:00
John Blackbourn 53a9e3b420 Add support for `WP_Error` objects passed to `wp_send_json_error()`. The error object gets output as an array of error codes and messages, rather than as an empty object.
Fixes #28978
Props paulschreiber

Built from https://develop.svn.wordpress.org/trunk@30506


git-svn-id: http://core.svn.wordpress.org/trunk@30495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:56:23 +00:00
Helen Hou-Sandí 97b412af37 Admin notices: Add more variety and make more generically usable.
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.

Built from https://develop.svn.wordpress.org/trunk@30505


git-svn-id: http://core.svn.wordpress.org/trunk@30494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:41:25 +00:00
Helen Hou-Sandí c83f96ec61 Sessions UI: Ensure screen readers provide feedback on action taken.
Also fixes some invalid HTML that occurs on DOM changes.

props joedolson.
fixes #30364.

Built from https://develop.svn.wordpress.org/trunk@30504


git-svn-id: http://core.svn.wordpress.org/trunk@30493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:25:23 +00:00
Helen Hou-Sandí 541e6d31af oEmbed: Add support for the Vine endpoint.
props niallkennedy.
fixes #30426.

Built from https://develop.svn.wordpress.org/trunk@30503


git-svn-id: http://core.svn.wordpress.org/trunk@30492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:04:23 +00:00
Drew Jaynes b0db6e6deb Convert `<title>` to "title tag" in the DocBlock summary for the `admin_title` hook.
Fixes #30437.

Built from https://develop.svn.wordpress.org/trunk@30502


git-svn-id: http://core.svn.wordpress.org/trunk@30491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 07:12:23 +00:00
Sergey Biryukov 8f2842a07e Replace invalid use of ltrim() in attachment_url_to_postid() with substr().
props bradyvercher.
fixes #30346.
Built from https://develop.svn.wordpress.org/trunk@30501


git-svn-id: http://core.svn.wordpress.org/trunk@30490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 06:35:22 +00:00
Sergey Biryukov aad05ece16 Set min-height for menu item title. Add a fallback for empty-titled items.
props philiparthurmoore.
fixes #30283.
Built from https://develop.svn.wordpress.org/trunk@30500


git-svn-id: http://core.svn.wordpress.org/trunk@30489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 05:57:22 +00:00
John Blackbourn 2aabde8f74 Remove whitespace accidentally introduced in r30498
See #30335

Built from https://develop.svn.wordpress.org/trunk@30499


git-svn-id: http://core.svn.wordpress.org/trunk@30488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 04:01:22 +00:00