Commit Graph

14353 Commits

Author SHA1 Message Date
Dominik Schilling 3524302a52 Media Grid: Align "Apply" button on small screens.
fixes #28903.
Built from https://develop.svn.wordpress.org/trunk@29307


git-svn-id: http://core.svn.wordpress.org/trunk@29089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-27 12:15:16 +00:00
Dominik Schilling 9c77f419f6 Fix jshint errors introduced in [29284] and [29299].
Built from https://develop.svn.wordpress.org/trunk@29306


git-svn-id: http://core.svn.wordpress.org/trunk@29088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-27 11:49:15 +00:00
Dominik Schilling ab151eca85 Media Grid: Ignore user setting for `content`.
fixes #29034.
Built from https://develop.svn.wordpress.org/trunk@29305


git-svn-id: http://core.svn.wordpress.org/trunk@29087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-27 11:44:18 +00:00
Dominik Schilling abbe1d0383 Media Grid: Improve dropzone margins when viewport height is <400px.
see #28851.
Built from https://develop.svn.wordpress.org/trunk@29304


git-svn-id: http://core.svn.wordpress.org/trunk@29086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-26 15:30:16 +00:00
Dominik Schilling a777a561fa Media Grid: Add context for "or" in [29296].
see #28851.
Built from https://develop.svn.wordpress.org/trunk@29303


git-svn-id: http://core.svn.wordpress.org/trunk@29085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-26 14:37:19 +00:00
Andrew Ozz b9f97e8352 TinyMCE:
- Fix complex character input in Japanese, Chinese, etc. Was broken in getCursorOffset() in editor-expand.js.
- Disable auto-scrolling in some edge cases when editor expanding is enabled.
See #28328.

Built from https://develop.svn.wordpress.org/trunk@29302


git-svn-id: http://core.svn.wordpress.org/trunk@29084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-26 00:08:19 +00:00
Helen Hou-Sandí f3ede5702e Don't interfere with browser-based autocomplete in the link modal. props SergeyBiryukov. fixes #28685.
Built from https://develop.svn.wordpress.org/trunk@29301


git-svn-id: http://core.svn.wordpress.org/trunk@29083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 15:57:16 +00:00
Scott Taylor 0e4c8b2b0c Media Grid: when closing the modal, automatically focus the proper attachment by reading the model's ID, which is unique.
Props adamsilverstein (for the red), wonderboymusic (for the green).
Fixes #28857.

Built from https://develop.svn.wordpress.org/trunk@29299


git-svn-id: http://core.svn.wordpress.org/trunk@29081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 01:00:16 +00:00
Andrew Ozz 9436186ee4 TinyMCE wpView:
- Fix opening the media modal on clicking Edit in Firefox.
- Fix range errors when restoring the selection bookmark in IE11 after editing a view.
See #28595.
Built from https://develop.svn.wordpress.org/trunk@29298


git-svn-id: http://core.svn.wordpress.org/trunk@29080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 00:56:15 +00:00
Scott Taylor eccb5a7e9c Media Grid: make check `box-shadow` more subtle.
See #28842.

Built from https://develop.svn.wordpress.org/trunk@29297


git-svn-id: http://core.svn.wordpress.org/trunk@29079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 00:47:15 +00:00
Scott Taylor 477a823d25 Media Grid: improve uploader styles.
Props michalzuber, ericlewis.
See #28851.

Built from https://develop.svn.wordpress.org/trunk@29296


git-svn-id: http://core.svn.wordpress.org/trunk@29078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 00:31:15 +00:00
Scott Taylor 97604df447 Media Grid: change text to "Close Media Panel" to provide context for screen readers.
Props joedolson.
Fixes #28976.

Built from https://develop.svn.wordpress.org/trunk@29295


git-svn-id: http://core.svn.wordpress.org/trunk@29077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 00:26:15 +00:00
Scott Taylor 97fff7e952 Adds `<label>`s to current page selector and bulk actions `<select>` field so that screen readers have an explicit label.
Props joedolson.
Fixes #28867.

Built from https://develop.svn.wordpress.org/trunk@29294


git-svn-id: http://core.svn.wordpress.org/trunk@29076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 00:20:16 +00:00
Scott Taylor 0005433983 Correct a few `@param` docs for `$walker`.
Props dnaber-de.
Fixes #29011.

Built from https://develop.svn.wordpress.org/trunk@29293


git-svn-id: http://core.svn.wordpress.org/trunk@29075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 22:25:16 +00:00
Scott Taylor a14f5b97d5 In `sanitize_file_name()`, replace `%20` and `+` with dashes. Remove unnecessary code from `_wp_handle_upload()`.
Adds unit tests.

Props ericmann.
Fixes #16330.

Built from https://develop.svn.wordpress.org/trunk@29290


git-svn-id: http://core.svn.wordpress.org/trunk@29072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 22:09:16 +00:00
Scott Taylor 27866228af Media Grid: UI improvements to Attachment modal.
Props ryelle.
See #28844.

Built from https://develop.svn.wordpress.org/trunk@29289


git-svn-id: http://core.svn.wordpress.org/trunk@29071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 21:55:17 +00:00
Scott Taylor c83f891d54 Media Grid: remove pencil icon from attachment hover and a bunch of unused CSS.
Fixes #28945.

Built from https://develop.svn.wordpress.org/trunk@29288


git-svn-id: http://core.svn.wordpress.org/trunk@29070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 21:18:18 +00:00
Scott Taylor 36fb0b8148 Media Grid CSS: Media modal close icon should be consistent with other modals.
Props celloexpressions.
Fixes #29012.

Built from https://develop.svn.wordpress.org/trunk@29287


git-svn-id: http://core.svn.wordpress.org/trunk@29069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 21:07:15 +00:00
Scott Taylor 1f22888b56 Remove white box-shadow divider from uploading status area for consistency.
Props paulwilde.
Fixes #28751.

Built from https://develop.svn.wordpress.org/trunk@29286


git-svn-id: http://core.svn.wordpress.org/trunk@29068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 21:04:15 +00:00
Scott Taylor 9382741cbe Don't render Attachment Display Settings when `display` is set to `false`. Currently, the value for `display` in the `media.view.AttachmentsBrowser` instance in the `media.view.MediaFrame.Select` frame is set to the value for `displaySettings`.
These values do different things, so check for the existence of `display` on the state before arbitrarily setting it to the `displaySettings` value.

Real world: this hides display settings when you select an image while editing a Gallery.

Fixes #28653.

Built from https://develop.svn.wordpress.org/trunk@29285


git-svn-id: http://core.svn.wordpress.org/trunk@29067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 20:58:16 +00:00
Scott Taylor 78518beb6b When gallery settings are overridden, the JS-generated shortcodes need to check the new defaults before deleting attributes that it suspects are the same as the original default values.
`wp.media.collection` has a new method to do this: `setDefaults()`.	Also flips the use of `_.extend` to allow this method to be overriden on instance creation.

See #28693.

Built from https://develop.svn.wordpress.org/trunk@29284


git-svn-id: http://core.svn.wordpress.org/trunk@29066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 20:00:16 +00:00
Scott Taylor 58741e0909 The Underscore templates for Gallery settings should respect defaults when marking an `<option>` as `selected`.
See #28693.

Built from https://develop.svn.wordpress.org/trunk@29283


git-svn-id: http://core.svn.wordpress.org/trunk@29065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 19:35:15 +00:00
Scott Taylor 5be43cfeb1 Media Grid: Manage focus when toggling between the grid and an edit attachment modal
Props adamsilverstein for the initial patch.
Fixes #28857.

Built from https://develop.svn.wordpress.org/trunk@29282


git-svn-id: http://core.svn.wordpress.org/trunk@29064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 19:05:15 +00:00
Helen Hou-Sandí 6f44e96d70 Set default values for attachment meta and ID3 data when preparing for JS to avoid errors in rendering templates. props ericmann for the initial patch. fixes #29013.
Built from https://develop.svn.wordpress.org/trunk@29281


git-svn-id: http://core.svn.wordpress.org/trunk@29063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 18:04:18 +00:00
Helen Hou-Sandí 448275cce4 Media Grid: Remove fields from showing in the grid itself.
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.

Built from https://develop.svn.wordpress.org/trunk@29280


git-svn-id: http://core.svn.wordpress.org/trunk@29062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 05:26:15 +00:00
Andrew Ozz da0b98a8f0 Editor scrolling:
- Improve TinyMCE resizing when a floated block is at the end of the content.
- Improve setting the padding/margin under the toolbar on loading.
- Add custom event on TinyMCE resizing and use it to adjust the pinning (if needed).
Part props avryl, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29279


git-svn-id: http://core.svn.wordpress.org/trunk@29061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 01:33:15 +00:00
Helen Hou-Sandí 795c97d08b Add support for `attachment_fields_to_edit` in the attachment details modal. props ericlewis. fixes #28991, see #24716.
Built from https://develop.svn.wordpress.org/trunk@29278


git-svn-id: http://core.svn.wordpress.org/trunk@29060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 22:09:18 +00:00
Scott Taylor cb2d88a092 After [29179], remove the last instance of `this.isCompatibleSrc()`.
Props kovshenin.
See #28905.


Built from https://develop.svn.wordpress.org/trunk@29277


git-svn-id: http://core.svn.wordpress.org/trunk@29059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 17:54:15 +00:00
Drew Jaynes cc82d1bea4 Fix a typo in the PHPDoc for `wp_register_sidebar_widget()`.
Props Jonnyauk.
Fixes #29007.

Built from https://develop.svn.wordpress.org/trunk@29276


git-svn-id: http://core.svn.wordpress.org/trunk@29058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 17:21:18 +00:00
Drew Jaynes e329b34f37 Fix a typo in the PHPDoc for `get_stylesheet()`.
Props lgedeon.
Fixes #28985.

Built from https://develop.svn.wordpress.org/trunk@29275


git-svn-id: http://core.svn.wordpress.org/trunk@29057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 05:11:16 +00:00
Helen Hou-Sandí 3cee43e6ce Revert [29267], as it causes unit test breakage and appears unnecessary. see #28986.
Built from https://develop.svn.wordpress.org/trunk@29274


git-svn-id: http://core.svn.wordpress.org/trunk@29056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 02:23:15 +00:00
Andrew Ozz 8e973f2c29 wpView: make sure the editor is focused before selecting/deselecting a view, or IE may throw an invalid range error, see #28595.
Built from https://develop.svn.wordpress.org/trunk@29273


git-svn-id: http://core.svn.wordpress.org/trunk@29055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 21:53:16 +00:00
Andrew Ozz c40feac4d9 wpView: consolidate pausePlayers() and unsetPlayers(), they are almost the same. Prevent errors when instead of a player ME.js shows only a "Download File" placeholder (in IE). See #28905.
Built from https://develop.svn.wordpress.org/trunk@29272


git-svn-id: http://core.svn.wordpress.org/trunk@29054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 21:49:16 +00:00
Dominik Schilling 270a57075c Media Grid: Add a date filter.
props ericlewis.
fixes #28895.
Built from https://develop.svn.wordpress.org/trunk@29271


git-svn-id: http://core.svn.wordpress.org/trunk@29053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:47:15 +00:00
Dominik Schilling de8961d631 Update the versions of several devDependencies in `package.json`.
Run `npm update` in the project root to receive updates.

props mjbanks, jorbin, netweb.
see #27340.
Built from https://develop.svn.wordpress.org/trunk@29270


git-svn-id: http://core.svn.wordpress.org/trunk@29052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:41:44 +00:00
Dominik Schilling f0bca68069 Media CSS: Fix typo in `box-shadow` property for WebKit and update indentation to match the other ones.
Built from https://develop.svn.wordpress.org/trunk@29268


git-svn-id: http://core.svn.wordpress.org/trunk@29050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 19:58:18 +00:00
Scott Taylor 0702527010 Media Grid: general JS cleanup.
Props ericlewis.
See #28965.


Built from https://develop.svn.wordpress.org/trunk@29266


git-svn-id: http://core.svn.wordpress.org/trunk@29049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 16:21:15 +00:00
Sergey Biryukov fcb1687039 Media Grid: Fix missing padding in RTL in Attachment Details modal.
see #28980.
Built from https://develop.svn.wordpress.org/trunk@29265


git-svn-id: http://core.svn.wordpress.org/trunk@29048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 03:18:15 +00:00
Sergey Biryukov 809baf442b Media Grid: Swap arrow direction in RTL in Attachment Details modal.
props adamsilverstein.
fixes #28980.
Built from https://develop.svn.wordpress.org/trunk@29264


git-svn-id: http://core.svn.wordpress.org/trunk@29047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 03:08:15 +00:00
Helen Hou-Sandí 89a8316946 Move the "view" link for attachment details to the sidebar and use more specific language. Removes an unnecessary JS handler. fixes #28977.
Built from https://develop.svn.wordpress.org/trunk@29263


git-svn-id: http://core.svn.wordpress.org/trunk@29046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 02:20:15 +00:00
Sergey Biryukov 8923bb0c0e Media Grid: Add a View button to Attachment Details modal.
props adamsilverstein.
fixes #28977.
Built from https://develop.svn.wordpress.org/trunk@29262


git-svn-id: http://core.svn.wordpress.org/trunk@29045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 01:30:16 +00:00
Andrew Ozz b9222c9e1e TinyMCE: include 85e22b58e9that and quote one more use of "float". This is "reserved as future keyword by older ECMAScript specifications" according to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar and can throw a syntax error. See #28576.
Built from https://develop.svn.wordpress.org/trunk@29261


git-svn-id: http://core.svn.wordpress.org/trunk@29044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-21 23:05:15 +00:00
Sergey Biryukov b3f6108438 Remove a redundant condition for comment feeds from WP_Query::get_posts().
props engelen.
fixes #28401.
Built from https://develop.svn.wordpress.org/trunk@29257


git-svn-id: http://core.svn.wordpress.org/trunk@29040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-21 15:38:14 +00:00
Sergey Biryukov a9c9827de4 Gruntfile: Change import rules to include RTL stylesheets when running CSSJanus.
see #28966.
Built from https://develop.svn.wordpress.org/trunk@29256


git-svn-id: http://core.svn.wordpress.org/trunk@29039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-21 02:51:16 +00:00
Peter Westwood 1f147d24b1 XMLRPC: Switch the file deletion alias to be deleteFile to more closely make uploadFile.
Fixes #5310 props SergeyBiryukov.

Built from https://develop.svn.wordpress.org/trunk@29255


git-svn-id: http://core.svn.wordpress.org/trunk@29038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-20 14:02:15 +00:00
Peter Westwood 673916b39f Post beta2 version bump to 4.0-beta2-29254
Built from https://develop.svn.wordpress.org/trunk@29254


git-svn-id: http://core.svn.wordpress.org/trunk@29037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-20 13:59:15 +00:00
Scott Taylor 0d387bf76e `WP_Dependencies->recurse_deps()`: tuck the recursion into `elseif` so the `foreach` doesn't break on the first item.
See [29252].

Built from https://develop.svn.wordpress.org/trunk@29253


git-svn-id: http://core.svn.wordpress.org/trunk@29036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-20 00:34:15 +00:00
Scott Taylor f93abf2bea `wp_script_is( ..., 'enqueued' )` needs to check dependencies recursively - a single item's dependencies may only be a subset of the full dependency tree. Adds a new method on `WP_Dependencies` called `->recurse_deps()`.
Adds unit test.

Props wonderboymusic, SergeyBiryukov, mikejolley.
Fixes #28404.

Built from https://develop.svn.wordpress.org/trunk@29252


git-svn-id: http://core.svn.wordpress.org/trunk@29035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-20 00:29:16 +00:00
Scott Taylor baf7f5604d After [29200], switch back to using `static` vars instead of adding 2 `global`s, as per Sergey.
Fixes #28697.

Built from https://develop.svn.wordpress.org/trunk@29250


git-svn-id: http://core.svn.wordpress.org/trunk@29034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 23:14:15 +00:00
Scott Taylor 021b07a161 Call `untrailingslashit()` when adding a theme directory in `register_theme_directory()`. This prevents double-slashing in generated URLs. Don't add a directory if it is already present.
Adds unit tests.
Props obenland, wonderboymusic.
Fixes #28662.

Built from https://develop.svn.wordpress.org/trunk@29249


git-svn-id: http://core.svn.wordpress.org/trunk@29033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 23:07:15 +00:00