WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
26,772 Commits 50 Branches 749 Tags 983 MiB
Commit Graph

14353 Commits

Author SHA1 Message Date
Sergey Biryukov 428a83259e Avoing a PHP warning in media modal if the attached file does not exist. 
props kovshenin.
see #24716.
Built from https://develop.svn.wordpress.org/trunk@28959


git-svn-id: http://core.svn.wordpress.org/trunk@28755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 14:37:15 +00:00
Sergey Biryukov f84ef60b52 Canonical redirects should only be applied for GET requests. 
props c.axelsson.
fixes #27498.
Built from https://develop.svn.wordpress.org/trunk@28958


git-svn-id: http://core.svn.wordpress.org/trunk@28754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 14:11:14 +00:00
Sergey Biryukov 19a3159082 Make default 'template' argument of the_taxonomies() and get_the_taxonomies() translatable. 
props juliobox.
fixes #28714.
Built from https://develop.svn.wordpress.org/trunk@28957


git-svn-id: http://core.svn.wordpress.org/trunk@28753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 13:21:16 +00:00
Drew Jaynes 6dd339f215 Specify the `$single` parameter default for `get_post_meta()`. Docs spacing. 
See #28708.

Built from https://develop.svn.wordpress.org/trunk@28955


git-svn-id: http://core.svn.wordpress.org/trunk@28751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 03:30:14 +00:00
Sergey Biryukov 81103f482a Mark $single parameter of get_post_meta() as optional. 
props netweb.
fixes #28708.
Built from https://develop.svn.wordpress.org/trunk@28954


git-svn-id: http://core.svn.wordpress.org/trunk@28750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 03:26:16 +00:00
Drew Jaynes 52fbb3c484 Fix parameter description for `$append` in `wp_set_object_terms()` inline docs. 
See #26570.

Built from https://develop.svn.wordpress.org/trunk@28952


git-svn-id: http://core.svn.wordpress.org/trunk@28749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 01:39:15 +00:00
Sergey Biryukov 1b23dd8f05 Clarify the docs and add more unit tests for wp_set_object_terms(). 
props DrewAPicture.
fixes #26570.
Built from https://develop.svn.wordpress.org/trunk@28951


git-svn-id: http://core.svn.wordpress.org/trunk@28748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 01:28:15 +00:00
Drew Jaynes 41b7269f16 Remove duplicate of the 'oembed_providers' filter accidentally introduced in [28949]. 
Move annoted table of oEmbed providers into the existing filter docs.

See #28507.
Fixes #28372. 

Built from https://develop.svn.wordpress.org/trunk@28950


git-svn-id: http://core.svn.wordpress.org/trunk@28747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 00:34:15 +00:00
Drew Jaynes e618b986bf Introduce an annotated list of oEmbed providers, their flavors, whether they support SSL, and when they were added to the `oembed_providers` filter docs. 
See #28507.
Fixes #28372.

Built from https://develop.svn.wordpress.org/trunk@28949


git-svn-id: http://core.svn.wordpress.org/trunk@28746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 00:19:15 +00:00
Sergey Biryukov fc24029d65 Simplify logic in get_sample_permalink_html(), remove duplicated code. 
see #28350.
Built from https://develop.svn.wordpress.org/trunk@28947


git-svn-id: http://core.svn.wordpress.org/trunk@28744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 00:04:15 +00:00
Sergey Biryukov 63a875ce80 Use correct variable. 
props azaozz.
see #24472.
Built from https://develop.svn.wordpress.org/trunk@28945


git-svn-id: http://core.svn.wordpress.org/trunk@28742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 23:30:15 +00:00
Sergey Biryukov 63b1667a01 Add a filter for wp_editor() settings. 
props DH-Shredder, JPry, DrewAPicture.
fixes #24472.
Built from https://develop.svn.wordpress.org/trunk@28944


git-svn-id: http://core.svn.wordpress.org/trunk@28741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 23:03:15 +00:00
Sergey Biryukov 788597141a Make wp_kses_no_null() remove any invalid control characters in a string. 
props mauteri, miqrogroove.
fixes #28506.
Built from https://develop.svn.wordpress.org/trunk@28942


git-svn-id: http://core.svn.wordpress.org/trunk@28740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 18:01:17 +00:00
Sergey Biryukov 177fe21194 Asterisk is an allowed character in a URI and should not be stripped out by wp_sanitize_redirect(). 
fixes #28362.
Built from https://develop.svn.wordpress.org/trunk@28939


git-svn-id: http://core.svn.wordpress.org/trunk@28737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 15:56:15 +00:00
Sergey Biryukov 575425ffbe Add @since for get_translations_for_domain(). 
props DrewAPicture.
see #28690.
Built from https://develop.svn.wordpress.org/trunk@28938


git-svn-id: http://core.svn.wordpress.org/trunk@28736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 15:29:13 +00:00
Sergey Biryukov 440c78d405 Some fixes for get_weekstartend() docs. 
see #26185.
Built from https://develop.svn.wordpress.org/trunk@28937


git-svn-id: http://core.svn.wordpress.org/trunk@28735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 14:59:15 +00:00
Drew Jaynes 300c53e6fe General inline documentation improvements in wp-includes/functions.php. 
Second run. See #26185.

Built from https://develop.svn.wordpress.org/trunk@28936


git-svn-id: http://core.svn.wordpress.org/trunk@28734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 01:44:15 +00:00
Sergey Biryukov 7e226aaa70 WP_Date_Query: The inclusive logic should include all times within the date range. 
props mboynes, oso96_2000, DrewAPicture.
fixes #26653.
Built from https://develop.svn.wordpress.org/trunk@28935


git-svn-id: http://core.svn.wordpress.org/trunk@28733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 01:18:15 +00:00
Sergey Biryukov 7a47b7585d Move ms-load.php and ms-default-constants.php inclusion back to ms-settings.php to avoid breaking WP-CLI. 
Use require_once() to allow for ms-settings.php to be included multiple times while testing.

props jeremyfelt.
see #27884.
Built from https://develop.svn.wordpress.org/trunk@28934


git-svn-id: http://core.svn.wordpress.org/trunk@28732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 23:50:15 +00:00
Sergey Biryukov f7703c03d3 Remove free-spacing modifier and extra spaces from wp_extract_urls() pattern. 
fixes #28222.
Built from https://develop.svn.wordpress.org/trunk@28933


git-svn-id: http://core.svn.wordpress.org/trunk@28731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 23:09:16 +00:00
Andrew Ozz 99c9ef1a59 TinyMCE: 
- Update the 'paste' plugin including cb36a78e54
- Better filtering of WebKit inserted &nbsp.
- Remove empty paragraphs and all inline styles on pasting but preserve styles added in the editor. This brings back the WP 3.8 behavior and makes pasting in all browsers work the same.
See #28016
Built from https://develop.svn.wordpress.org/trunk@28932


git-svn-id: http://core.svn.wordpress.org/trunk@28730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 21:55:18 +00:00
Dominik Schilling 958ab24709 Customizer: Support `textarea` and commonly-used input types as control type in `WP_Customize_Control`. 
Add `input_attrs` property to support custom input attributes.

(Demo plugin attached to ticket.)

props celloexpressions.
fixes #28477.
Built from https://develop.svn.wordpress.org/trunk@28930


git-svn-id: http://core.svn.wordpress.org/trunk@28728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 19:48:13 +00:00
Scott Taylor a71d57da0a Remove obsolete comment in `wptexturize()`. 
http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-06-30&sort=asc#m879104

See [28831].

Built from https://develop.svn.wordpress.org/trunk@28929


git-svn-id: http://core.svn.wordpress.org/trunk@28727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 17:59:14 +00:00
Sergey Biryukov ca650bd79c Replace a redundant ! is_preview() check with a more appropriate one. 
fixes #20496.
Built from https://develop.svn.wordpress.org/trunk@28928


git-svn-id: http://core.svn.wordpress.org/trunk@28726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 17:19:14 +00:00
Helen Hou-Sandí e1db9240b7 Support descriptions for individual customizer controls. 
* Control title (label) markup will also only be output if specified.
* Control section descriptions are no longer italicized for visual hierarchy / differentiation.

props celloexpressions. fixes #27981.

Built from https://develop.svn.wordpress.org/trunk@28927


git-svn-id: http://core.svn.wordpress.org/trunk@28725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 15:55:17 +00:00
Sergey Biryukov 2752456493 Document @return value for load_plugin_textdomain(). props jdgrimes. 
Document $path parameter for load_child_theme_textdomain().

fixes #28690.
Built from https://develop.svn.wordpress.org/trunk@28924


git-svn-id: http://core.svn.wordpress.org/trunk@28723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 13:52:15 +00:00
Sergey Biryukov f799048057 Pass $url parameter to wp_embed_defaults() and 'embed_defaults' filter. 
props wpsmith, sabreuse, jacobdubail.
fixes #20151.
Built from https://develop.svn.wordpress.org/trunk@28923


git-svn-id: http://core.svn.wordpress.org/trunk@28722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 11:16:15 +00:00
Sergey Biryukov c8d8610a15 Avoid a PHP notice in wp_new_comment() if user ID is not passed. 
see #23231.
Built from https://develop.svn.wordpress.org/trunk@28922


git-svn-id: http://core.svn.wordpress.org/trunk@28721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 11:03:14 +00:00
Sergey Biryukov 706f85d814 Force a separator in get_wp_title_rss() if it was inadvertently filtered out by the theme. 
fixes #22362.
Built from https://develop.svn.wordpress.org/trunk@28921


git-svn-id: http://core.svn.wordpress.org/trunk@28720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 10:11:15 +00:00
Sergey Biryukov 8dcf86f94d Display consistent preview links for drafts. 
props mordauk.
fixes #28350.
Built from https://develop.svn.wordpress.org/trunk@28920


git-svn-id: http://core.svn.wordpress.org/trunk@28719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 10:02:16 +00:00
Andrew Ozz 5168f9c7c6 Secure embeds in the editor (first run): 
- When the user pastes an embeddable http URL, try to get the https embed.
- If an embed provider doesn't support ssl embeds, show a placeholder/error message.
- Revise the way we return error messages.
See #28195, #28507.
Built from https://develop.svn.wordpress.org/trunk@28919


git-svn-id: http://core.svn.wordpress.org/trunk@28718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 05:49:16 +00:00
Drew Jaynes c97a364b79 General inline documentation improvements in wp-includes/functions.php. 
First run. See #26185.

Built from https://develop.svn.wordpress.org/trunk@28918


git-svn-id: http://core.svn.wordpress.org/trunk@28717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 03:56:15 +00:00
Drew Jaynes 36be4e5703 Improve inline documentation for `date_i18n()`, `_http_build_query()`, `wp_checkdate()`, and `wp_auth_check()`. 
Props morganestes.
See #26185.

Built from https://develop.svn.wordpress.org/trunk@28917


git-svn-id: http://core.svn.wordpress.org/trunk@28716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 03:47:16 +00:00
Sergey Biryukov c8adae8ec7 Normalize 'user_id' and 'user_ID' values in wp_new_comment() before passing the comment data to 'preprocess_comment' filter. 
props dkotter.
fixes #23231.
Built from https://develop.svn.wordpress.org/trunk@28915


git-svn-id: http://core.svn.wordpress.org/trunk@28714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 00:41:16 +00:00
Scott Taylor 63c4cd485f Revert [28911] for performance concerns. 
See #14157.

Built from https://develop.svn.wordpress.org/trunk@28914


git-svn-id: http://core.svn.wordpress.org/trunk@28713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 23:43:14 +00:00
Scott Taylor 21864a98d0 Add a function, `get_comments_number_text()`, that returns instead of echoing. `comments_number()` wraps it. 
Props kapeels, nbachiyski.
Fixes #10177.

Built from https://develop.svn.wordpress.org/trunk@28912


git-svn-id: http://core.svn.wordpress.org/trunk@28711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 23:13:15 +00:00
Scott Taylor f7ac459a61 Use `includes_url( ..., 'relative' )` in `script-loader.php` in lieu of hard-coding `/wp-includes/....` everywhere. 
Fixes #14157.

Built from https://develop.svn.wordpress.org/trunk@28911


git-svn-id: http://core.svn.wordpress.org/trunk@28710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:56:14 +00:00
Andrew Nacin 4695573f51 Add initial unit tests for multisite's bootstrap. 
props jeremyfelt.
fixes #27884.

Built from https://develop.svn.wordpress.org/trunk@28910


git-svn-id: http://core.svn.wordpress.org/trunk@28709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:51:16 +00:00
Drew Jaynes a10aff4d92 Convert documentation of default arguments in `wp_list_authors()` to the hash-notation style. 
Props Viper007Bond.
Fixes #28684.

Built from https://develop.svn.wordpress.org/trunk@28909


git-svn-id: http://core.svn.wordpress.org/trunk@28708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:34:14 +00:00
Scott Taylor 9e2eb6aa62 Use `includes_url()` in `wlwmanifest_link()`. 
Props nacin.
See #14157.

Built from https://develop.svn.wordpress.org/trunk@28908


git-svn-id: http://core.svn.wordpress.org/trunk@28707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:27:15 +00:00
Scott Taylor 53968da5e2 `WP_Scripts->in_default_dir()` should use the `WPINC` constant 
Props wojtek.szkutnik
See #14157.

Built from https://develop.svn.wordpress.org/trunk@28907


git-svn-id: http://core.svn.wordpress.org/trunk@28706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:23:15 +00:00
Scott Taylor 8dd3c0e909 `wlwmanifest_link()` should use the `WPINC` constant 
Props wojtek.szkutnik
See #14157.

Built from https://develop.svn.wordpress.org/trunk@28905


git-svn-id: http://core.svn.wordpress.org/trunk@28704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:17:14 +00:00
Scott Taylor c8852cc909 Use the `WPINC` constant when loading `class-phpass.php` 
Props wojtek.szkutnik
See #14157.

Built from https://develop.svn.wordpress.org/trunk@28903


git-svn-id: http://core.svn.wordpress.org/trunk@28702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:12:16 +00:00
Sergey Biryukov a8d0832a15 Notify developers when register_post_type() or register_taxonomy() fails because of post type or taxonomy key length. 
props mattheweppelsheimer.
fixes #28683.
Built from https://develop.svn.wordpress.org/trunk@28902


git-svn-id: http://core.svn.wordpress.org/trunk@28701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 21:54:14 +00:00
Drew Jaynes 6216aa2331 Add documentation for the default playlist shortcode attributes in `wp_playlist_shortcode()`. 
Props taylorde.
Fixes #28678.

Built from https://develop.svn.wordpress.org/trunk@28901


git-svn-id: http://core.svn.wordpress.org/trunk@28700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 21:29:17 +00:00
Andrew Nacin 708f73ccc9 Add index key support for wp_list_pluck(), à la array_column(). 
props trepmal.
fixes #28666.

Built from https://develop.svn.wordpress.org/trunk@28900


git-svn-id: http://core.svn.wordpress.org/trunk@28699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 21:26:17 +00:00
Drew Jaynes 5f08eed052 Re-document default arguments in `wp_link_pages()` using the hash-notation style. 
Props taylorde.
Fixes #28680.

Built from https://develop.svn.wordpress.org/trunk@28899


git-svn-id: http://core.svn.wordpress.org/trunk@28698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 18:56:16 +00:00
Sergey Biryukov ae0e22b61c Fix feature pointer positioning issues for both LTR and RTL. 
fixes #28062.
Built from https://develop.svn.wordpress.org/trunk@28897


git-svn-id: http://core.svn.wordpress.org/trunk@28696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 16:06:14 +00:00
John Blackbourn 60ff3a61f9 Conditionally set the the `secure` flag on the test cookie, post password cookie, settings cookies, and comment author cookies depending on whether the front end and/or admin area are served over `https`. Fixes #28427 
Built from https://develop.svn.wordpress.org/trunk@28895


git-svn-id: http://core.svn.wordpress.org/trunk@28694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 13:25:16 +00:00
John Blackbourn de664966b0 Introduce `is_https_url()` for testing whether the scheme for a given URL is `https`. See #28487. 
Built from https://develop.svn.wordpress.org/trunk@28894


git-svn-id: http://core.svn.wordpress.org/trunk@28693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 11:32:15 +00:00
Drew Jaynes e7f7fcbab8 General phpDoc fixes in wp-includes/plugin.php. 
See #28516.

Built from https://develop.svn.wordpress.org/trunk@28891


git-svn-id: http://core.svn.wordpress.org/trunk@28690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 09:19:15 +00:00
Sergey Biryukov 341eca6024 List the expected @param type first. 
see #28516.
Built from https://develop.svn.wordpress.org/trunk@28889


git-svn-id: http://core.svn.wordpress.org/trunk@28688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 08:47:14 +00:00
Sergey Biryukov 7bb7693dd1 More tweaks to @param docs in wp-includes/plugin.php. 
see #28516.
Built from https://develop.svn.wordpress.org/trunk@28888


git-svn-id: http://core.svn.wordpress.org/trunk@28687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 08:42:16 +00:00
Drew Jaynes ff109ddc5a First-run documention of `WP_Query` argument defaults. 
Props siobhan for some language tweaks. Props DrewAPicture.
See #25367.

Built from https://develop.svn.wordpress.org/trunk@28887


git-svn-id: http://core.svn.wordpress.org/trunk@28686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 23:03:17 +00:00
Scott Taylor 62075239b8 Update `@param` docs in `plugin.php` 
Props dkotter.
Fixes #28516.

Built from https://develop.svn.wordpress.org/trunk@28886


git-svn-id: http://core.svn.wordpress.org/trunk@28685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 04:50:15 +00:00
Scott Taylor 0289b98648 After [28883], `remove_filter()` should set `$GLOBALS['wp_filter'][ $tag ]` to `array()` when empty. 
Props wonderboymusic, sphoid.
Fixes #28142.

Built from https://develop.svn.wordpress.org/trunk@28884


git-svn-id: http://core.svn.wordpress.org/trunk@28683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 04:38:15 +00:00
Scott Taylor 9275c87190 `remove_all_filters()` should set to `array()`, not call `unset()`. 
Props nacin, c3mdigital.
Fixes #19306.

Built from https://develop.svn.wordpress.org/trunk@28883


git-svn-id: http://core.svn.wordpress.org/trunk@28682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 04:27:15 +00:00
Scott Taylor 0e3c4450cb `wp_extract_urls()` should not match dates. 
Updates unit tests.

Props hinnerk, sergej.mueller.
Fixes #28222.

Built from https://develop.svn.wordpress.org/trunk@28882


git-svn-id: http://core.svn.wordpress.org/trunk@28681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 04:16:14 +00:00
Scott Taylor 2e81419d4c In multisite, on the `updated_option` action, if the option name is one of: 'blogname', 'siteurl', 'post_count' - refresh the blog details cache for the current blog id. 
Adds unit test.

Props kovshenin.
Fixes #26410.

Built from https://develop.svn.wordpress.org/trunk@28881


git-svn-id: http://core.svn.wordpress.org/trunk@28680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 04:07:16 +00:00
Scott Taylor 13d0a45932 If the `get_the_excerpt()` is called out of bounds of a global `$post`, return ''. 
Fixes #22413.

Built from https://develop.svn.wordpress.org/trunk@28880


git-svn-id: http://core.svn.wordpress.org/trunk@28679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 04:01:14 +00:00
Scott Taylor cf95c6ecc2 Add `->get_quality()` method to `WP_Image_Editor` class. 
Adds unit tests.

Props markoheijnen.
Fixes #28154.

Built from https://develop.svn.wordpress.org/trunk@28879


git-svn-id: http://core.svn.wordpress.org/trunk@28678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 03:50:15 +00:00
Sergey Biryukov a6a2183bf6 Fix typo in a comment. 
props JustinSainton.
see #20496.
Built from https://develop.svn.wordpress.org/trunk@28878


git-svn-id: http://core.svn.wordpress.org/trunk@28677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 03:30:16 +00:00
Scott Taylor dad07f85b8 Fix the spacing between the wp-pointer arrow and bubble in LTR and RTL. 
Fixes #28062.


Built from https://develop.svn.wordpress.org/trunk@28877


git-svn-id: http://core.svn.wordpress.org/trunk@28676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 02:26:16 +00:00
Scott Taylor 8b3bb6cc2d Remove obsolete `wp_cache_delete('get_pages', 'posts')` from `clean_post_cache()`. 
Fixes #27459.

Built from https://develop.svn.wordpress.org/trunk@28875


git-svn-id: http://core.svn.wordpress.org/trunk@28674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 02:16:14 +00:00
Scott Taylor a60b01b138 Perform a canonical redirect for posts that are published but are visited at a `?p=123&preview=true` URL. 
Props amit, joostdevalk.
Fixes #20496.

Built from https://develop.svn.wordpress.org/trunk@28874


git-svn-id: http://core.svn.wordpress.org/trunk@28673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 02:13:15 +00:00
Scott Taylor f09663f784 Remove remaining Heartbeat API experimental notices 
Props DH-Shredder.
Fixes #28626.

Built from https://develop.svn.wordpress.org/trunk@28872


git-svn-id: http://core.svn.wordpress.org/trunk@28672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 02:06:14 +00:00
Scott Taylor 71090a7f12 Remove title attributes in `wp_authenticate_username_password()`. 
Props joedolson.
Fixes #26547.

Built from https://develop.svn.wordpress.org/trunk@28870


git-svn-id: http://core.svn.wordpress.org/trunk@28670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-27 20:05:15 +00:00
Sergey Biryukov 819d4f972c Correct filter documentation in wp_nav_menu(). 
props dlh.
fixes #28657.
Built from https://develop.svn.wordpress.org/trunk@28867


git-svn-id: http://core.svn.wordpress.org/trunk@28667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-27 03:37:16 +00:00
Andrew Ozz db501d7f72 TinyMCE: force 'font-weight: bold` for <strong> and <b> inside the editor or Chrome and Safari may replace them with spans on pasting. Fixes #28656. 
Built from https://develop.svn.wordpress.org/trunk@28866


git-svn-id: http://core.svn.wordpress.org/trunk@28666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-27 03:00:15 +00:00
Sergey Biryukov 4d9286ad21 Avoid a PHP notice and warning on language selection screen. 
props meekyhwang.
fixes #28648.
Built from https://develop.svn.wordpress.org/trunk@28865


git-svn-id: http://core.svn.wordpress.org/trunk@28665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-27 00:25:15 +00:00
Sergey Biryukov aebf8f0fea Make sure the first number in LIMIT clause in WP_Query::get_posts() is always an integer. 
fixes #23383.
Built from https://develop.svn.wordpress.org/trunk@28864


git-svn-id: http://core.svn.wordpress.org/trunk@28664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-27 00:04:16 +00:00
Scott Taylor 4ad56ce548 Make sure the audio player's time tooltip is visible in the media modal for Audio Details. 
Fixes #28453.


Built from https://develop.svn.wordpress.org/trunk@28863


git-svn-id: http://core.svn.wordpress.org/trunk@28663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 20:29:14 +00:00
Dominik Schilling b7c93eb3d0 Customizer: Introduce a "panel" API to organize multiple sections into a one section. 
Create a panel via `$GLOBALS['wp_customize']->add_panel( $panel_id, $args )` and use `$panel_id` for the `panel` argument in `$GLOBALS['wp_customize']->add_section( $section_id, $args )`. That's it.
As an example all widget area sections are now summarized into one panel. Feedback appreciated.

props celloexpressions.
see #27406.
Built from https://develop.svn.wordpress.org/trunk@28861


git-svn-id: http://core.svn.wordpress.org/trunk@28662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 20:17:15 +00:00
Scott Taylor a21d9cdacf Do not touch `absint()`. Reverts [28855]. 
Built from https://develop.svn.wordpress.org/trunk@28858


git-svn-id: http://core.svn.wordpress.org/trunk@28661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 18:45:14 +00:00
Scott Taylor ff8e9774ae Revert [28856] at nacin's behest. See #23383. 
Built from https://develop.svn.wordpress.org/trunk@28857


git-svn-id: http://core.svn.wordpress.org/trunk@28660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 18:34:15 +00:00
Scott Taylor cd93bc05e5 `absint()` should always return `PHP_INT_MAX` if the resulting value exceeds it. 
See [28855].
Fixes #23383.

Built from https://develop.svn.wordpress.org/trunk@28856


git-svn-id: http://core.svn.wordpress.org/trunk@28659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 18:24:15 +00:00
Scott Taylor bae2b054ad Add a second optional parameter to `absint()` to limit the result to `PHP_INT_MAX`. 
See #23383.

Built from https://develop.svn.wordpress.org/trunk@28855


git-svn-id: http://core.svn.wordpress.org/trunk@28658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 17:52:15 +00:00
Sergey Biryukov 81b8b6cfbc XML-RPC: Make sure wp.newPost does not produce a fatal error when a post_date field is included in the data. 
props dllh.
fixes #28601.
Built from https://develop.svn.wordpress.org/trunk@28854


git-svn-id: http://core.svn.wordpress.org/trunk@28657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 17:43:14 +00:00
Scott Taylor 9997f77d7f Use less greedy regex in `wptexturize()`. Adds unit tests. 
Props miqrogroove.
See #28564.

Built from https://develop.svn.wordpress.org/trunk@28852


git-svn-id: http://core.svn.wordpress.org/trunk@28656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 17:15:14 +00:00
Sergey Biryukov 1c227553b9 Fix unexpected replacement of a previous tag when selecting a tag from autosuggest results. 
props camdensegal.
fixes #28471.
Built from https://develop.svn.wordpress.org/trunk@28851


git-svn-id: http://core.svn.wordpress.org/trunk@28655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 16:08:14 +00:00
Sergey Biryukov d7f9b38c3e XML-RPC: Add wp.deleteMediaItem as an alias to wp_deletePost. 
props fahmiadib.
fixes #5310.
Built from https://develop.svn.wordpress.org/trunk@28849


git-svn-id: http://core.svn.wordpress.org/trunk@28653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 15:21:15 +00:00
Andrew Ozz b9fd9db83b Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640. 
Built from https://develop.svn.wordpress.org/trunk@28847


git-svn-id: http://core.svn.wordpress.org/trunk@28651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 04:15:15 +00:00
Scott Taylor 2efb8f8507 When `wp_oembed_add_provider()` or `wp_oembed_remove_provider()` is called before the `plugins_loaded` hook has, store the values statically on the `WP_oEmbed` object and add them just-in-time when the object is instantiated. 
This ensures that all plugins have an accurate provider list when `apply_filters( 'oembed_providers', $providers )` is called. 

Props kovshenin.
Fixes #28284.

Built from https://develop.svn.wordpress.org/trunk@28846


git-svn-id: http://core.svn.wordpress.org/trunk@28650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 02:30:15 +00:00
Scott Taylor 38e39c93ea In `kses.php`, ensure that `$allowedposttags`, `$allowedtags`, and `$allowedentitynames` are added to the global namespace. 
Props Jaza613.
Fixes #28582.


Built from https://develop.svn.wordpress.org/trunk@28845


git-svn-id: http://core.svn.wordpress.org/trunk@28649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 02:14:15 +00:00
Scott Taylor c725b77068 Check for the existence of `$post` before using it in `get_the_ID()`. Return `false` if it doesn't exist. 
Props UmeshSingla.
Fixes #17034.

Built from https://develop.svn.wordpress.org/trunk@28844


git-svn-id: http://core.svn.wordpress.org/trunk@28648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 02:05:14 +00:00
Scott Taylor 4bcf6b2d6a Add mime support for 3gp, 3g2 and 3gpp video formats. These are not supported by MediaElement or the WP media shortcodes, just an FYI. 
Props azaozz, m_uysl.
Fixes #23380.

Built from https://develop.svn.wordpress.org/trunk@28841


git-svn-id: http://core.svn.wordpress.org/trunk@28645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 01:43:15 +00:00
Scott Taylor 6bcb24a344 In `wp_localize_script()`, instantiate the `$wp_scripts` global instead of bailing when it is called before `wp_enqueue_scripts`. This allows `wp_enqueue_media()` to be called on the front end with no JS errors. 
Props ericlewis.
Fixes #24724.

Built from https://develop.svn.wordpress.org/trunk@28840


git-svn-id: http://core.svn.wordpress.org/trunk@28644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 01:38:15 +00:00
Scott Taylor 6ab2f15b0b Dynamically prepend screen reader text to the attachment filters dropdown and the search box in the media modal. 
Props SergeyBiryukov.
Fixes #25102.

Built from https://develop.svn.wordpress.org/trunk@28839


git-svn-id: http://core.svn.wordpress.org/trunk@28643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 01:28:16 +00:00
Scott Taylor 6c3ce75b1c Race conditions can cause `.uploader-window` to be visible with opacity of `0`. It will cause the user to have to refresh the page or inspect the element to hide it. Add a delay in `wp.media.view.UploaderWindow.hide()` to ensure that the uploader window is indeed hidden. 
Props kovshenin.
Fixes #27341.

Built from https://develop.svn.wordpress.org/trunk@28838


git-svn-id: http://core.svn.wordpress.org/trunk@28642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 01:20:15 +00:00
Scott Taylor 69b0077edf `return false` in `has_nav_menu()` if the `$location` does not exist in the `$_wp_registered_nav_menus` global. 
Props SergeyBiryukov.
Fixes #27735.

Built from https://develop.svn.wordpress.org/trunk@28836


git-svn-id: http://core.svn.wordpress.org/trunk@28640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 00:57:15 +00:00
Scott Taylor 0233933f22 `get_blog_details()->post_count` should update on more actions than just `publish_post`. 
Adds unit test.

Props 5um17, midxcat, strangerstudios.
Fixes #27952.

Built from https://develop.svn.wordpress.org/trunk@28835


git-svn-id: http://core.svn.wordpress.org/trunk@28639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 00:53:15 +00:00
John Blackbourn c9ba310e25 Switch to SSL for the Flickr and Slideshare oEmbed endpoints. Add support for SSL embeds on flic.kr. See #28507. 
Built from https://develop.svn.wordpress.org/trunk@28834


git-svn-id: http://core.svn.wordpress.org/trunk@28638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-25 23:36:14 +00:00
Scott Taylor 8c39368644 Optimize the `wptexturize()` loop: 
* Take the ampersand pattern out of the loop for speed.
* Fix old bugs in the ampersand pattern.
* Refactor `_wptexturize_pushpop_element()` without PCRE for speed.
* Update unit tests.

Props miqrogroove.
Fixes #28623.

Built from https://develop.svn.wordpress.org/trunk@28831


git-svn-id: http://core.svn.wordpress.org/trunk@28635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-25 17:49:14 +00:00
Andrew Ozz c8ce9e2815 wpLink: support whole URLs including query/fragment when pre-filling the URL field. Fixes #19992 
Built from https://develop.svn.wordpress.org/trunk@28828


git-svn-id: http://core.svn.wordpress.org/trunk@28632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-25 00:37:15 +00:00
Sergey Biryukov c6ef7d05e0 Allow for easier adding of custom class variables when extending WP_Customize_Section or WP_Customize_Setting. 
props rhurling.
fixes #27315.
Built from https://develop.svn.wordpress.org/trunk@28827


git-svn-id: http://core.svn.wordpress.org/trunk@28631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 22:56:14 +00:00
Scott Taylor cc0c90e05a When selecting a fallback menu in `wp_nav_menu()`, the "first" menu is retrieved from an unsorted query. When retrieving a fallback menu, pass `array( 'orderby' => 'name' )` to `wp_get_nav_menus()` to return a menu consistently. 
Props lukecarbis.
Fixes #28126.

Built from https://develop.svn.wordpress.org/trunk@28826


git-svn-id: http://core.svn.wordpress.org/trunk@28630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 17:25:15 +00:00
Scott Taylor 7b83df547d Simplify the setting of `$args['include']` in `wp_get_nav_menu_items()`. 
Props UmeshSingla.
Fixes #28515.

Built from https://develop.svn.wordpress.org/trunk@28825


git-svn-id: http://core.svn.wordpress.org/trunk@28629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 17:17:14 +00:00
Scott Taylor 0ba605c55c Ensure that a `has_children` parameter is given to `Walker::start_el()`. 
Adds unit tests.

Props scribu, obenland.
Fixes #14041.

Built from https://develop.svn.wordpress.org/trunk@28824


git-svn-id: http://core.svn.wordpress.org/trunk@28628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 17:06:14 +00:00
Sergey Biryukov 60285aa687 Use direct typecasting instead of intval() for better performance. 
props kovshenin.
see #25788.
Built from https://develop.svn.wordpress.org/trunk@28823


git-svn-id: http://core.svn.wordpress.org/trunk@28627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 16:06:14 +00:00
Sergey Biryukov 781750550f Merge two Animoto oEmbed patterns. 
props kovshenin.
see #28265.
Built from https://develop.svn.wordpress.org/trunk@28822


git-svn-id: http://core.svn.wordpress.org/trunk@28626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 15:56:14 +00:00
Scott Taylor 856e5ef55e Remove `noscript` from `wpautop()`'s list of block elements. 
Props mdawaffe.
Fixes #27268.

Built from https://develop.svn.wordpress.org/trunk@28817


git-svn-id: http://core.svn.wordpress.org/trunk@28624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:54:17 +00:00
Scott Taylor 43320a5825 `wp.mce.embedView.fetch()` and `wp.media.view.EmbedLink.fetch()` need to pass the same parameters. 
Fixes #28532.

Built from https://develop.svn.wordpress.org/trunk@28816


git-svn-id: http://core.svn.wordpress.org/trunk@28623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:40:14 +00:00
Scott Taylor 04933ab8cf Add a filter/docs: 'oembed_remote_get_args' to `WP_oEmbed->discover()` and `->_fetch_with_format()`. 
Props leewillis77, DrewAPicture.
Fixes #23442.

Built from https://develop.svn.wordpress.org/trunk@28815


git-svn-id: http://core.svn.wordpress.org/trunk@28622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:28:15 +00:00
Scott Taylor 3ebd519a3e In `$wpdb->update()`, prevent explosions when `$where` is empty. 
Adds unit tests.

Props UmeshSingla, wonderboymusic.
Fixes #26106

Built from https://develop.svn.wordpress.org/trunk@28814


git-svn-id: http://core.svn.wordpress.org/trunk@28621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:24:14 +00:00
Scott Taylor 919ff69120 In `comment_form()`, allow `name_submit` to be passed to change the `name` attribute of the submit button. 
Props obenland.
Fixes #22792.

Built from https://develop.svn.wordpress.org/trunk@28813


git-svn-id: http://core.svn.wordpress.org/trunk@28620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:10:15 +00:00
Scott Taylor 317e5c9616 Adjust CSS for "Moved to the trash" message for a pingback in the dashboard. 
Props zoerooney, codenameEli.
Fixes #28286.

Built from https://develop.svn.wordpress.org/trunk@28811


git-svn-id: http://core.svn.wordpress.org/trunk@28619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:03:16 +00:00
Sergey Biryukov 8b272f4379 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly. 
fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28808


git-svn-id: http://core.svn.wordpress.org/trunk@28617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 22:21:15 +00:00
Scott Taylor 54915274fa Use the proper height property when calculating video size in `wp_underscore_video_template()`. 
Props Fab1en.
See #28190.

Built from https://develop.svn.wordpress.org/trunk@28807


git-svn-id: http://core.svn.wordpress.org/trunk@28616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 20:35:18 +00:00
Sergey Biryukov 9ceb642b2a Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata(). 
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28806


git-svn-id: http://core.svn.wordpress.org/trunk@28615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 14:48:14 +00:00
Sergey Biryukov 2b8460af62 Simplify the code for calculating plugin API check timeout. 
props leewillis77.
fixes #28600.
Built from https://develop.svn.wordpress.org/trunk@28805


git-svn-id: http://core.svn.wordpress.org/trunk@28614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 14:31:14 +00:00
Sergey Biryukov ab06b01eb8 Don't kill an empty search query. 
see #11330.
Built from https://develop.svn.wordpress.org/trunk@28804


git-svn-id: http://core.svn.wordpress.org/trunk@28613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 13:34:15 +00:00
Sergey Biryukov d2fc1773ae Prevent multiple hierarchical posts with the same slug from being displayed in single post template. 
fixes #28611.
Built from https://develop.svn.wordpress.org/trunk@28803


git-svn-id: http://core.svn.wordpress.org/trunk@28612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 13:15:16 +00:00
Sergey Biryukov 64e67b0dbb Revert [28776] and use a correct variable instead. 
props miqrogroove.
fixes #28575.
Built from https://develop.svn.wordpress.org/trunk@28802


git-svn-id: http://core.svn.wordpress.org/trunk@28611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-22 22:13:16 +00:00
Sergey Biryukov e1fb15dd4a Fix MediaElement i18n. 
props Namibia, eherman24.
fixes #28366 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28801


git-svn-id: http://core.svn.wordpress.org/trunk@28610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-22 14:16:14 +00:00
Sergey Biryukov 4690d6a592 Add @ticket references. 
see #16854, #19198.
Built from https://develop.svn.wordpress.org/trunk@28800


git-svn-id: http://core.svn.wordpress.org/trunk@28609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-22 01:41:16 +00:00
Andrew Ozz c936468da1 TinyMCE: revert 158b742410 and 576fa77aa2 as they may cause selection restore problems in old IE. See #28391. 
Built from https://develop.svn.wordpress.org/trunk@28795


git-svn-id: http://core.svn.wordpress.org/trunk@28608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-21 01:15:15 +00:00
Andrew Nacin bbff31baca Stop denying wp-includes/* in our default robots.txt. 
props joostdevalk.
fixes #28604.

Built from https://develop.svn.wordpress.org/trunk@28794


git-svn-id: http://core.svn.wordpress.org/trunk@28607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 21:02:14 +00:00
Andrew Nacin dc0aca09f5 Fix documentation for wp_create_nonce() which wrongly suggests these tokens are actually numbers used once. 
Built from https://develop.svn.wordpress.org/trunk@28793


git-svn-id: http://core.svn.wordpress.org/trunk@28606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 20:47:14 +00:00
Scott Taylor 269bd96f65 Posts in the Trash should not drag attachment pages down with them. 
Props ericlewis.
Fixes #14639.

Built from https://develop.svn.wordpress.org/trunk@28791


git-svn-id: http://core.svn.wordpress.org/trunk@28604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 19:14:15 +00:00
Scott Taylor 011f2aad7e Add Animoto to the list of oEmbed providers. Example video: http://animoto.com/play/MlRRgXHhoT8gOZyHanM6TA. 
Props lritter.
Fixes #28265.


Built from https://develop.svn.wordpress.org/trunk@28790


git-svn-id: http://core.svn.wordpress.org/trunk@28603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 18:57:15 +00:00
Scott Taylor 878dd70e79 Whitespace in `navMenuL10n` after [28707]. 
Fixes #23076.


Built from https://develop.svn.wordpress.org/trunk@28789


git-svn-id: http://core.svn.wordpress.org/trunk@28602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 18:30:15 +00:00
Scott Taylor 33c096aa71 Reinstate the changes from [28579] with some adjustments: 
* Check `! empty( $postarr['file'] )` before calling `update_attached_file()`
* Add a unit test: `test_update_attachment_fields()`
* Run the same logic for empty `guid` for attachments that always ran in `wp_insert_post()`, as per #18310. This fixes a unit test that would have broken when this ticket was marked closed.
* Updated the unit test in `Tests_Media::test_wp_prepare_attachment_for_js()` to account for `url` no longer being empty

Props kovshenin, wonderboymusic.
See #21963.

Built from https://develop.svn.wordpress.org/trunk@28788


git-svn-id: http://core.svn.wordpress.org/trunk@28601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 18:27:14 +00:00
Scott Taylor b930c3a6fe Cleanup `wp_widget_rss_form()` after [28734]. "$$input used sanitized variables which contained actual values, unlike $inputs[$input] which in that context contains data about which input fields are hidden." 
Props kovshenin.
Fixes #27881.

Built from https://develop.svn.wordpress.org/trunk@28787


git-svn-id: http://core.svn.wordpress.org/trunk@28600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 17:29:14 +00:00
Scott Taylor 378b4cd896 Cleanup after [28671]: 
* Set better defaults in `paginate_links()`, so that themes don't have to calculate them on their own, like Twenty Fourteen does now.
* Don't set page 1 to `?page=1` or `/page/1/` - that will force a canonical redirect.
* Add and cleanup unit tests

Props obenland, SergeyBiryukov, wonderboymusic.
Fixes #24606.

Built from https://develop.svn.wordpress.org/trunk@28785


git-svn-id: http://core.svn.wordpress.org/trunk@28598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 17:12:15 +00:00
Scott Taylor 0abf8699f3 Further adjustments after [8364], listen to an editor instance event instead of delegating a body click when attempting to pause all players belonging to a particular MCE view. 
Props avryl.
Fixes #27971.

Built from https://develop.svn.wordpress.org/trunk@28784


git-svn-id: http://core.svn.wordpress.org/trunk@28597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 16:30:16 +00:00
Scott Taylor 22e5b6932a Revert [28613] and [28664]. A good idea, but too much BC baggage. 
See #28099.


Built from https://develop.svn.wordpress.org/trunk@28783


git-svn-id: http://core.svn.wordpress.org/trunk@28596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 16:21:17 +00:00
John Blackbourn 6782686192 Increase the timeout for plugin and theme update checks based on how many are being checked. Props dd32. Fixes #25788 
Built from https://develop.svn.wordpress.org/trunk@28782


git-svn-id: http://core.svn.wordpress.org/trunk@28595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 23:21:16 +00:00
John Blackbourn 9e85d070a8 Remove SSL verification by default for requests to wp-cron.php. Props sivel, rhurling. Fixes #12609. 
Built from https://develop.svn.wordpress.org/trunk@28781


git-svn-id: http://core.svn.wordpress.org/trunk@28594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 22:53:19 +00:00
Sergey Biryukov ce0d1a026c Move preg_match() that should only run once out of the loop. 
props dllh.
fixes #28575.
Built from https://develop.svn.wordpress.org/trunk@28776


git-svn-id: http://core.svn.wordpress.org/trunk@28589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 00:01:16 +00:00
Scott Taylor 9834317785 Diambiguate `type` and `shortcode` in TinyMCE view classes and their attached `view.View` class. Has the added feature of not causing JS errors. 
See #28532.

Built from https://develop.svn.wordpress.org/trunk@28775


git-svn-id: http://core.svn.wordpress.org/trunk@28588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 23:03:15 +00:00
Andrew Nacin c504fb41a1 Allow a language to be chosen before installing WordPress. First pass. 
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 

Built from https://develop.svn.wordpress.org/trunk@28774


git-svn-id: http://core.svn.wordpress.org/trunk@28587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 19:58:15 +00:00
Scott Taylor b2f6e1f674 In `wptexturize()` + tests: 
* Allow well-formed HTML inside of shortcode attributes
* Restrict recursion. HTML is allowed but ignored.
* Do not allow exotic HTML comments in shortcode attributes.
* Continue to ignore the [ and ] chars if they appear in any HTML attribute.
* Update related regex patterns.
* Update unit tests.

Props miqrogroove.
Fixes #28564.

Built from https://develop.svn.wordpress.org/trunk@28773


git-svn-id: http://core.svn.wordpress.org/trunk@28586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 19:49:15 +00:00
Sergey Biryukov 585213b0b6 Don't generate adjacent links in wp_head() for attachments. 
props kovshenin.
fixes #21658.
Built from https://develop.svn.wordpress.org/trunk@28770


git-svn-id: http://core.svn.wordpress.org/trunk@28583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 00:05:16 +00:00
Sergey Biryukov 8b4b3697e0 Pass WP_Customize_Setting instance to 'customize_save_*' action. 
props danielbachhuber.
fixes #27979.
Built from https://develop.svn.wordpress.org/trunk@28769


git-svn-id: http://core.svn.wordpress.org/trunk@28582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 23:58:16 +00:00
Andrew Ozz 46f17ee039 TinyMCE: update to 4.0.28+. Includes all changes until 09-06-2014: 32cb108d41. Changelog: 32cb108d41/changelog.txt. 
See #28391.
Built from https://develop.svn.wordpress.org/trunk@28768


git-svn-id: http://core.svn.wordpress.org/trunk@28581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 23:49:15 +00:00
Sergey Biryukov f0a3d5cfa8 Pass WP_Customize_Setting instance to 'customize_preview_*' and 'customize_update_*' actions. 
props dustyn, DrewAPicture.
fixes #27979.
Built from https://develop.svn.wordpress.org/trunk@28767


git-svn-id: http://core.svn.wordpress.org/trunk@28580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 23:35:15 +00:00
Scott Taylor f1a15dd4fe Fix abbreviations mixed with quotes, example: `'99% of people'`. 
Add/alter unit tests.

Props miqrogroove.
Fixes #26850.

Built from https://develop.svn.wordpress.org/trunk@28765


git-svn-id: http://core.svn.wordpress.org/trunk@28578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 20:19:14 +00:00
Scott Taylor 2bac3b660f In `wptexturize()`, adjust for the treatment of abbreviated years at the end of quotations. 
Silence some unit tests that have never passed and may no longer be applicable.

Props miqrogroove.
Fixes #18549.

Built from https://develop.svn.wordpress.org/trunk@28764


git-svn-id: http://core.svn.wordpress.org/trunk@28577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 20:14:15 +00:00
Scott Taylor 3b3fb72ce3 Add unit tests to confirm that `---` is properly converted to `&#8212;` by `wptexturize()` where appropriate. 
Props miqrogroove.
Fixes #28483.

Built from https://develop.svn.wordpress.org/trunk@28763


git-svn-id: http://core.svn.wordpress.org/trunk@28576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 18:07:14 +00:00
Scott Taylor f7ac0eed90 Add Unit Tests for i18n and `wptexturize()`. Don't confuse closing single quotes and apostrophes. 
See #27426.

Built from https://develop.svn.wordpress.org/trunk@28762


git-svn-id: http://core.svn.wordpress.org/trunk@28575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 17:57:14 +00:00
Scott Taylor 337e5f7ae4 `wptexturize()` adjustments: 
* Only place an apostrophe before a number when it has exactly two digits.
* Never match '99' with the single prime pattern.
* Always assume '99' is an abbreviated year at the end of a quotation.
* Add unit tests.
* Resolves the unit test broken in [28721] for #8775.

See #26850.

Built from https://develop.svn.wordpress.org/trunk@28761


git-svn-id: http://core.svn.wordpress.org/trunk@28574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 17:41:15 +00:00
Sergey Biryukov e85c3deba5 Prevent get_post_class() and get_body_class() from returning duplicate classes. 
props Compute.
fixes #28541.
Built from https://develop.svn.wordpress.org/trunk@28760


git-svn-id: http://core.svn.wordpress.org/trunk@28573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 15:18:16 +00:00
Sergey Biryukov c171f2ef77 Fix labels on installation screen. 
props avryl.
fixes #28548.
Built from https://develop.svn.wordpress.org/trunk@28759


git-svn-id: http://core.svn.wordpress.org/trunk@28572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 14:37:16 +00:00
Andrew Ozz 5b4943bc6a TinyMCE wpView: fix selecting all of view's "text" in Safari, props avryl, fixes #28088 
Built from https://develop.svn.wordpress.org/trunk@28755


git-svn-id: http://core.svn.wordpress.org/trunk@28569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-16 00:12:15 +00:00
Andrew Ozz 84f3e30f7b wpView: improve handling of embed errors/error messages, see #28195 
Built from https://develop.svn.wordpress.org/trunk@28754


git-svn-id: http://core.svn.wordpress.org/trunk@28568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-15 22:53:16 +00:00
Sergey Biryukov 16595af731 Correct @return value for term_exists(). 
props simonwheatley.
fixes #28538.
Built from https://develop.svn.wordpress.org/trunk@28753


git-svn-id: http://core.svn.wordpress.org/trunk@28567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-14 14:57:16 +00:00
Scott Taylor 46a4208f6b Add "edit" mode for `[embed]` and URL media previews. 
See #28532.

Built from https://develop.svn.wordpress.org/trunk@28752


git-svn-id: http://core.svn.wordpress.org/trunk@28566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-13 21:42:15 +00:00
Sergey Biryukov 8c90ebaec7 wpLink: use simpler expressions to detect email address or URL. We are not validating user input here, just suggesting. 
see #19992.
Built from https://develop.svn.wordpress.org/trunk@28751


git-svn-id: http://core.svn.wordpress.org/trunk@28565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-13 21:26:15 +00:00
Andrew Ozz 15c902ea3a wpLink: use the proper instance of the editor when looking at the selection. Move the email and URL regexp to variables. See #19992 
Built from https://develop.svn.wordpress.org/trunk@28750


git-svn-id: http://core.svn.wordpress.org/trunk@28564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-13 21:14:16 +00:00
Andrew Ozz f88149c370 wpView: 
- Don't wrap single-line URLs in [embed]. Use them directly in generating a view.
- If the embedding HTML contains a script, "sandbox" it in an iframe to prevent it from changing the editor DOM.
- Automatically add toolbar and overlay when needed.
- Try to embed single-line URLs only if they are pasted in an empty paragraph.
Props avryl, see #28195
Built from https://develop.svn.wordpress.org/trunk@28748


git-svn-id: http://core.svn.wordpress.org/trunk@28562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-12 02:49:16 +00:00
Scott Taylor 43bf7f271f Don't use variable variables in `wp_salt()`. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28741


git-svn-id: http://core.svn.wordpress.org/trunk@28555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 18:36:15 +00:00
Scott Taylor 994ca59abd Don't use variable variables in `wp_insert_user()`. 
Add a local array, `$meta`, to provide substantial disambiguation among variables. 

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28740


git-svn-id: http://core.svn.wordpress.org/trunk@28554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 18:21:14 +00:00
Scott Taylor 07d4069444 Don't use variable variables in `plugins_url()`. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28739


git-svn-id: http://core.svn.wordpress.org/trunk@28553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 18:18:14 +00:00
Scott Taylor e5e8a83cf4 Don't use variable variables in `WP_Comment_Query::query()`. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28738


git-svn-id: http://core.svn.wordpress.org/trunk@28552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 17:58:14 +00:00
Scott Taylor c1e7c2d1de Don't use variable variables in `WP_Query::get_posts()`. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28737


git-svn-id: http://core.svn.wordpress.org/trunk@28551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 17:50:16 +00:00
Scott Taylor 17b17d1c78 Don't use variable variables in `get_terms()`. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28736


git-svn-id: http://core.svn.wordpress.org/trunk@28550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 17:41:14 +00:00
Drew Jaynes 66bcd85529 Improve inline documention for `set_transient()` and `set_site_transient()` to specify the 45- and 40-character limits for their respective transient name values. 
Props edwin-at-studiojoyo.com for the original patch.
See #15058, #13310. Fixes #28467.

Built from https://develop.svn.wordpress.org/trunk@28735


git-svn-id: http://core.svn.wordpress.org/trunk@28549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 16:33:15 +00:00
Scott Taylor ecf0e4702f Don't use a variable variable in `wp_widget_rss_form()`. Sidenote: the logic to show hidden fields is bizarre - would result in duplicate fields. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28734


git-svn-id: http://core.svn.wordpress.org/trunk@28548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 16:18:17 +00:00
Scott Taylor 980744f882 In `wp_insert_term()`, when no slug is provided, check for an existing term by name. If it exists, use that slug instead of calling `sanitize_title( $name )`. 
Prevents creating an endless number of terms like `A+` or `$$$$` in any given taxonomy.

Props wonderboymusic, SergeyBiryukov, aaroncampbell.
Fixes #17689.

Built from https://develop.svn.wordpress.org/trunk@28733


git-svn-id: http://core.svn.wordpress.org/trunk@28547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 02:28:14 +00:00
Andrew Ozz 620e6ebe37 Fix the layout of the Image Details modal, props gcorne, see #24716 [28682] 
Built from https://develop.svn.wordpress.org/trunk@28732


git-svn-id: http://core.svn.wordpress.org/trunk@28546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 00:23:14 +00:00
John Blackbourn 2d23c8fea7 A little more abstraction in the `WP_oEmbed` class. Fixes #24381. 
Built from https://develop.svn.wordpress.org/trunk@28728


git-svn-id: http://core.svn.wordpress.org/trunk@28542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 18:14:15 +00:00
Scott Taylor 658170b179 In `wptexturize()`, ensure that texturization does not corrupt contents of HTML elements, HTML comments, and smartcode attributes. 
Adds a variety of unit tests/assertions.

Props miqrogroove.
Fixes #12690, #8912, #27602.

Built from https://develop.svn.wordpress.org/trunk@28727


git-svn-id: http://core.svn.wordpress.org/trunk@28541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 14:34:13 +00:00
Scott Taylor 4c067bd327 In `wptexturize()`, allow dashes before and after curly quotes. Example: This is what she said---"Wow that is cool." 
Adds unit tests.

Props adamsilverstein, miqrogroove.
Fixes #20342.

Built from https://develop.svn.wordpress.org/trunk@28726


git-svn-id: http://core.svn.wordpress.org/trunk@28540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 14:22:15 +00:00
Scott Taylor 3d3c166f11 `wptexturize()` should handle apostrophes before primes. 
Props nacin, miqrogroove.
Fixes #22823.

Built from https://develop.svn.wordpress.org/trunk@28725


git-svn-id: http://core.svn.wordpress.org/trunk@28539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 14:14:17 +00:00
Drew Jaynes 5755eaf372 Improve inline documentation for the `wp_spaces_regexp` filter. 
Fixes #27588.

Built from https://develop.svn.wordpress.org/trunk@28724


git-svn-id: http://core.svn.wordpress.org/trunk@28538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 06:46:15 +00:00
Drew Jaynes 0290f79eac Add inline documentation for the `run_wptexturize` filter. 
Props miqrogroove for the original patch.
Fixes #19550.

Built from https://develop.svn.wordpress.org/trunk@28723


git-svn-id: http://core.svn.wordpress.org/trunk@28537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 06:29:14 +00:00
Scott Taylor 6a61826660 Set a variable for like-escaped string before looping in `WP_User_Query::get_search_sql()`. 
Props miqrogroove.
Fixes #10041.

Built from https://develop.svn.wordpress.org/trunk@28722


git-svn-id: http://core.svn.wordpress.org/trunk@28536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:45:16 +00:00
Scott Taylor f8b03aa528 Fix curly quotes around numbers when applicable. 
Adds unit tests.

Props filosofo, mrmist, aliso, MikeHansenMe, miqrogroove.
Fixes #8775.

Built from https://develop.svn.wordpress.org/trunk@28721


git-svn-id: http://core.svn.wordpress.org/trunk@28535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:43:14 +00:00
Scott Taylor 5219bbbbc9 In `WP_Comment_Query::get_search_sql()`, don't double-like-escape. 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28720


git-svn-id: http://core.svn.wordpress.org/trunk@28534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:20:16 +00:00
Scott Taylor 4666c1abe2 In `wptexturize()`, don't convert C-style hexadecimals to mathematical `×`. 
Adds unit tests.

Props harrym, kurtpayne, miqrogroove.
Fixes #19308.

Built from https://develop.svn.wordpress.org/trunk@28719


git-svn-id: http://core.svn.wordpress.org/trunk@28533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:18:15 +00:00
Scott Taylor 12e7d6744b In `wptexturize()`, treat `&nbsp;` like whitespace when texturizing hyphens. 
Adds unit tests.

Props redsweater, miqrogroove.
Fixes #23185.

Built from https://develop.svn.wordpress.org/trunk@28718


git-svn-id: http://core.svn.wordpress.org/trunk@28532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:09:15 +00:00
Scott Taylor 6cb51c9ceb `smilies_init()`, treat `&nbsp;` like whitespace when converting smilies. 
Adds unit tests.

Props miqrogroove.
Fixes #27587.

Built from https://develop.svn.wordpress.org/trunk@28717


git-svn-id: http://core.svn.wordpress.org/trunk@28531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:03:14 +00:00
Scott Taylor 66d2144e9a Ensure that `shortcode_unautop()` treats `&nbsp;` like whitespace. 
`shortcode_unautop()` and `wptexturize()` now use `wp_spaces_regexp()` instead of raw regex.

Adds unit tests.

Props miqrogroove.
See #27588.

Built from https://develop.svn.wordpress.org/trunk@28716


git-svn-id: http://core.svn.wordpress.org/trunk@28530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 01:55:15 +00:00
Scott Taylor b4b0efe701 Add a `$run_texturize` static var to `wptexturize()` that is filterable via a new run-once filter: `'run_wptexturize'`. Allows user to disable texturization. 
Needs filter docs.

Props nacin, SergeyBiryukov.
See #19550.

Built from https://develop.svn.wordpress.org/trunk@28715


git-svn-id: http://core.svn.wordpress.org/trunk@28529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 01:46:14 +00:00
Scott Taylor 05eeb16e30 Replace all uses of `like_escape()` with `$wpdb->esc_like()`. 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28712


git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:44:15 +00:00
Scott Taylor 82bdc78500 `LIKE` escape sanity: 
* Deprecate `like_escape()`
* Add a method to `$wpdb`, `->esc_like()`, and add unit tests

`$wpdb::esc_like()` is not used yet. As such, many unit tests will throw `Unexpected deprecated notice for like_escape`. Subsequent commits will alleviate this.

Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28711


git-svn-id: http://core.svn.wordpress.org/trunk@28527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:30:15 +00:00
John Blackbourn df7be9cd80 Correct the deprecated function parameter in `url_is_accessable_via_ssl()`. See #19555. 
Built from https://develop.svn.wordpress.org/trunk@28710


git-svn-id: http://core.svn.wordpress.org/trunk@28526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-09 22:27:14 +00:00
John Blackbourn d00b196084 Deprecate `url_is_accessable_via_ssl()`. Fixes #19555. Props jgadbois. 
Built from https://develop.svn.wordpress.org/trunk@28709


git-svn-id: http://core.svn.wordpress.org/trunk@28525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-09 22:03:18 +00:00
Scott Taylor 46f82b03e7 Add a function: `wp_spaces_regexp()`. It is not used yet. 
This function is required by a bunch of patches by miqrogroove. Needs filter docs.

Props miqrogroove.
See #27588.

Built from https://develop.svn.wordpress.org/trunk@28708


git-svn-id: http://core.svn.wordpress.org/trunk@28524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-09 19:30:14 +00:00
Scott Taylor b964ac0148 Live update the menu item title when the user is editing the "Navigation Label" field. 
Props celloexpressions.
See #23076.

Built from https://develop.svn.wordpress.org/trunk@28707


git-svn-id: http://core.svn.wordpress.org/trunk@28523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-09 18:39:15 +00:00
Scott Taylor c6d0dcc634 When a plain URL or email address is selected in the editor and "Insert/edit link" is clicked, pre-populate the URL field with the URL or `mailto:<email-address>`. 
Props tillkruess.
Fixes #19992.

Built from https://develop.svn.wordpress.org/trunk@28705


git-svn-id: http://core.svn.wordpress.org/trunk@28522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-09 15:35:14 +00:00
John Blackbourn 2901a1a88b Add some basic unit tests for HTTPS canonical redirects. See #27954. 
Built from https://develop.svn.wordpress.org/trunk@28704


git-svn-id: http://core.svn.wordpress.org/trunk@28521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-09 01:06:14 +00:00
Sergey Biryukov 5fb95760aa Fix JSHint error. 
props avryl.
see #24716.
Built from https://develop.svn.wordpress.org/trunk@28697


git-svn-id: http://core.svn.wordpress.org/trunk@28514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-08 12:33:16 +00:00
Sergey Biryukov 6d7e222ded Use get_pages() instead of a raw SQL query in get_body_class(). 
fixes #28159.
Built from https://develop.svn.wordpress.org/trunk@28696


git-svn-id: http://core.svn.wordpress.org/trunk@28513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-07 03:22:16 +00:00
Scott Taylor d8e57f0148 As per @gcorne's suggestion, when calling `wp.mce.views.register()`, automatically set `shortcode` equal to the passed `type` in the set of default args instead of introducing a `type` property. It is still overrideable by the args that are passed. 
See #28458.


Built from https://develop.svn.wordpress.org/trunk@28689


git-svn-id: http://core.svn.wordpress.org/trunk@28507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-06 14:22:22 +00:00
Scott Taylor 1bb24133d9 Improve inline doc descriptions in `media-views.js`. 
Props ericlewis.
See #28459.

Built from https://develop.svn.wordpress.org/trunk@28688


git-svn-id: http://core.svn.wordpress.org/trunk@28506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-06 14:13:17 +00:00
Andrew Ozz fbdb89b89a wpView: fix deselecting a view when clicking outside the iframe body. Props avryl, fixes #28268 
Built from https://develop.svn.wordpress.org/trunk@28687


git-svn-id: http://core.svn.wordpress.org/trunk@28505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-06 05:04:14 +00:00
Andrew Ozz 23b0443578 wpView: fire a `nodeChanged` event after selecting a view so the editor UI gets updated. Props avryl, fixes #28385 
Built from https://develop.svn.wordpress.org/trunk@28686


git-svn-id: http://core.svn.wordpress.org/trunk@28504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-06 04:43:17 +00:00
Andrew Ozz a59cf45c4d TinyMCE: remove &nbsp from empty paragraphs inside the visual editor, props avryl, fixes #28282 
Built from https://develop.svn.wordpress.org/trunk@28685


git-svn-id: http://core.svn.wordpress.org/trunk@28503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-06 04:20:14 +00:00
Andrew Ozz 60e323d911 wpView: use `data-mce-selected` instead of adding a class to mark a view as selected. This prevents adding an unneeded undo level. Props avryl, fixes #28313 
Built from https://develop.svn.wordpress.org/trunk@28684


git-svn-id: http://core.svn.wordpress.org/trunk@28502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-06 02:12:14 +00:00
Andrew Ozz d593293556 Fix JS error in tmpl-editor-gallery, `'string'.trim()` is not available in IE < 9. See #28089 
Built from https://develop.svn.wordpress.org/trunk@28683


git-svn-id: http://core.svn.wordpress.org/trunk@28501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-06 01:50:16 +00:00
Helen Hou-Sandí b5ef672c6b Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further. 
props ericlewis, shaunandrews, wonderboymusic.
see #24716.

Built from https://develop.svn.wordpress.org/trunk@28682


git-svn-id: http://core.svn.wordpress.org/trunk@28500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 22:01:18 +00:00
Scott Taylor ce508e95c2 Simplify the creation of MCE views somewhat: 
* Rename the `wp.mce.media` mixin (which was named too ambiguously) to `wp.mce.av`.
* Use the same technique for extending mixins for MCE base classes for views and their base.View property class
* `wp.mce.views.register()` should have default constructor logic if one is not passed.

Props avryl.
See #28458.


Built from https://develop.svn.wordpress.org/trunk@28680


git-svn-id: http://core.svn.wordpress.org/trunk@28498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 17:27:13 +00:00
Sergey Biryukov 6d5b7ea58f Deprecate get_all_category_ids(). Suggest get_terms() as a replacement. 
props winterDev, MikeHansenMe.
fixes #21200.
Built from https://develop.svn.wordpress.org/trunk@28679


git-svn-id: http://core.svn.wordpress.org/trunk@28497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 16:25:14 +00:00
Sergey Biryukov f9792ed973 Correct @return value for get_children(). 
props ghost1227.
fixes #28422.
Built from https://develop.svn.wordpress.org/trunk@28677


git-svn-id: http://core.svn.wordpress.org/trunk@28495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 15:53:14 +00:00
Sergey Biryukov c8a55d08e6 Add a note about return value in case of an expired transient to get_transient() and get_site_transient(). 
props ruud@joyo.
fixes #28462.
Built from https://develop.svn.wordpress.org/trunk@28676


git-svn-id: http://core.svn.wordpress.org/trunk@28494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 15:34:14 +00:00
Scott Taylor 5d89ee4b3b Media modal documentation: 
Add some clarity to default values for controllers.

Props ericlewis.
See #28459.


Built from https://develop.svn.wordpress.org/trunk@28675


git-svn-id: http://core.svn.wordpress.org/trunk@28493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 14:54:14 +00:00
Andrew Nacin f769530af3 Force SSL admin when siteurl is explicitly configured with HTTPS. 
see #27954.

Built from https://develop.svn.wordpress.org/trunk@28674


git-svn-id: http://core.svn.wordpress.org/trunk@28492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 14:09:18 +00:00
Sergey Biryukov 26d0ad5e12 Remove redundant 'Visit author homepage' title attributes for plugins and themes. 
props joedolson.
fixes #26554.
Built from https://develop.svn.wordpress.org/trunk@28673


git-svn-id: http://core.svn.wordpress.org/trunk@28491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 04:52:16 +00:00
Sergey Biryukov 02657dcd66 wp_insert_comment() and wp_new_comment() should check if the comment was successfully inserted into the database. 
props pento.
fixes #28254.
Built from https://develop.svn.wordpress.org/trunk@28672


git-svn-id: http://core.svn.wordpress.org/trunk@28490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 04:38:14 +00:00
Sergey Biryukov dbff41578e Avoid an empty href attribute in paginate_links(). Add unit tests. 
props obenland, Nessworthy.
fixes #24606.
Built from https://develop.svn.wordpress.org/trunk@28671


git-svn-id: http://core.svn.wordpress.org/trunk@28489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 02:10:15 +00:00
Sergey Biryukov c20cdfcc38 Add a filter to human_time_diff(). 
props slimndap.
fixes #27271.
Built from https://develop.svn.wordpress.org/trunk@28670


git-svn-id: http://core.svn.wordpress.org/trunk@28488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 00:39:14 +00:00
Sergey Biryukov fcd8152496 Add 'wp_title_parts' filter to wp_title(). 
props aaroncampbell, obenland.
fixes #17877.
Built from https://develop.svn.wordpress.org/trunk@28669


git-svn-id: http://core.svn.wordpress.org/trunk@28487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 00:28:15 +00:00
Sergey Biryukov f598eaa89b Move is_admin check to a more appropriate place. 
see #11330.
Built from https://develop.svn.wordpress.org/trunk@28668


git-svn-id: http://core.svn.wordpress.org/trunk@28486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 23:47:15 +00:00
Sergey Biryukov b33c95079b Avoid a PHP notice when using WP_Query::get_queried_object() in pre_get_posts action. 
props wpsmith.
fixes #28412.
Built from https://develop.svn.wordpress.org/trunk@28667


git-svn-id: http://core.svn.wordpress.org/trunk@28485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 23:43:15 +00:00
Scott Taylor 1aaa80f48e Prevent admin breakage for `s` in `WP_Query` after [28623]. 
See #11330.


Built from https://develop.svn.wordpress.org/trunk@28666


git-svn-id: http://core.svn.wordpress.org/trunk@28484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 20:03:15 +00:00
Scott Taylor 38819880ec Wrap individual meta query `WHERE` clases in parens, missed in `28659`. 
Props boonebgorges.
Fixes #25538.


Built from https://develop.svn.wordpress.org/trunk@28665


git-svn-id: http://core.svn.wordpress.org/trunk@28483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 18:21:15 +00:00
Scott Taylor 23a53beb7e After [28613], also kill queries that explicityly pass empty arrays to `category__in`, `tag__in`, `tag_slug__in`, and `author__in` to `WP_Query`. 
Adds unit tests.
Fixes #28099.

Built from https://develop.svn.wordpress.org/trunk@28664


git-svn-id: http://core.svn.wordpress.org/trunk@28482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 17:50:15 +00:00
Drew Jaynes 10e48ccbf2 Improve inline documentation for the `__construct()` and `add()` methods in `WP_Error` class. 
Props jdgrimes.
Fixes #28203.

Built from https://develop.svn.wordpress.org/trunk@28660


git-svn-id: http://core.svn.wordpress.org/trunk@28478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 06:06:14 +00:00
Scott Taylor a7c2180672 Fix SQL generation when `meta_query` has an `'relation' => 'OR'` for its queries and wants to `'orderby' => 'meta_value'`. 
Adds unit test.

Props jackreichert.
Fixes #25538.


Built from https://develop.svn.wordpress.org/trunk@28659


git-svn-id: http://core.svn.wordpress.org/trunk@28477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 05:48:14 +00:00
Drew Jaynes 290b377a31 Mark the `MYSQL_NEW_LINK` constant as deprecated in 3.9+ as no equivalent to the `$new_link` parameter exists in `mysqli_*` functions. 
Fixes #27933.

Built from https://develop.svn.wordpress.org/trunk@28657


git-svn-id: http://core.svn.wordpress.org/trunk@28475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 05:00:15 +00:00
Drew Jaynes 18a6253747 Improve inline documentation for wp-includes/load.php. 
Props ericlewis, DrewAPicture.
Fixes #24886.

Built from https://develop.svn.wordpress.org/trunk@28656


git-svn-id: http://core.svn.wordpress.org/trunk@28474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 04:12:17 +00:00
Drew Jaynes b0a1f67b6b Be more specific that `$post_id` does not default to the ID of the global `$post` in some cases. 
See [28654]. See #28388.

Built from https://develop.svn.wordpress.org/trunk@28655


git-svn-id: http://core.svn.wordpress.org/trunk@28473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 04:52:15 +00:00
Drew Jaynes 3724252959 Ensure `$post_id` is documented as optional where applicable. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28654


git-svn-id: http://core.svn.wordpress.org/trunk@28472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 04:44:16 +00:00
Drew Jaynes b0877f02a4 Make sure `$post` is properly documented as optional where applicable. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28653


git-svn-id: http://core.svn.wordpress.org/trunk@28471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 03:53:17 +00:00
Scott Taylor 91e6a8c017 Because of YouTube's overwhelming dominance in the online video space, we should help our users who paste bad URLs when possible. It is easy to fix `http://youtube.com/embed/acb1233` URLs by turning them into `http://youtube.com/watch?v=abc1233` embeds using an embed handler (we already have one to fix Google Video embeds). 
We should avoid doing this in almost every other case, but it's YouTube, and it's an easy error for a novice to make.

Fixes #24660.

Built from https://develop.svn.wordpress.org/trunk@28652


git-svn-id: http://core.svn.wordpress.org/trunk@28470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-02 01:22:15 +00:00
Sergey Biryukov 324565bb17 Add oEmbed support for TED talks. 
props pdclark.
fixes #28285.
Built from https://develop.svn.wordpress.org/trunk@28651


git-svn-id: http://core.svn.wordpress.org/trunk@28469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-02 00:46:14 +00:00
Scott Taylor 17271702ca In the spirit of [27622], add a few CSS rules to ensure that videos will be responsive, regardless of theme. 
Props Funkatronic.
Fixes #28414.

Built from https://develop.svn.wordpress.org/trunk@28650


git-svn-id: http://core.svn.wordpress.org/trunk@28468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-02 00:40:15 +00:00
Scott Taylor 4fd5ffe994 In `WPPlaylistView::ended()`, at the end of a playlist, set the index to `0` and call `->setCurrent()` instead of `->loadCurrent()` so that the first track is properly highlighted. 
Fixes #28428.

Built from https://develop.svn.wordpress.org/trunk@28649


git-svn-id: http://core.svn.wordpress.org/trunk@28467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-02 00:27:18 +00:00
Sergey Biryukov fd99912f65 Fix typo in mbstring_binary_safe_encoding() description. 
props ghost1227.
fixes #28423.
Built from https://develop.svn.wordpress.org/trunk@28648


git-svn-id: http://core.svn.wordpress.org/trunk@28466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-01 05:06:15 +00:00
Sergey Biryukov 9aadc44d5c Capitalize 'ID' correctly to avoid random failures of Tests_Tax_Query::test_term_taxonomy_id_field_no_taxonomy(). 
see #25284.
Built from https://develop.svn.wordpress.org/trunk@28647


git-svn-id: http://core.svn.wordpress.org/trunk@28465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-01 03:18:14 +00:00
Lance Willett c2f0505bcf Twenty Fourteen: change hardcoded pagination base to use the WordPress Rewrite object's `pagination_base` value instead. Document global variable usage properly. 
Props SergeyBiryukov, fixes #28405.
Built from https://develop.svn.wordpress.org/trunk@28645


git-svn-id: http://core.svn.wordpress.org/trunk@28463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-31 18:51:19 +00:00
Sergey Biryukov a8483f21e2 Adjacent links in wp_head() should only be generated for posts, not pages. 
props alexander.rohmann.
fixes #21658.
Built from https://develop.svn.wordpress.org/trunk@28641


git-svn-id: http://core.svn.wordpress.org/trunk@28459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 21:20:14 +00:00
Scott Taylor 552d84a8a8 In `WP_Image_Editor_GD::_save()`, pass `$compression_level` into the args array for `->make_image()`. 
Props MuViMoTV, markoheijnen, SergeyBiryukov, mikemanger, ericlewis.
Fixes #24380.


Built from https://develop.svn.wordpress.org/trunk@28640


git-svn-id: http://core.svn.wordpress.org/trunk@28458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 20:06:14 +00:00
Scott Taylor 2d6721dbc9 Fix an error caused by [28604] in `get_comments_number()` unit tests. 
Props SergeyBiryukov.
Fixes #26240.


Built from https://develop.svn.wordpress.org/trunk@28638


git-svn-id: http://core.svn.wordpress.org/trunk@28456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 19:47:14 +00:00
Scott Taylor cd96841632 `wp_xmlrpc_server::wp_getPage()` should `return new IXR_Error(` instead of `return(new IXR_Error(`. One of the few places that is unparseable by static analysis. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28636


git-svn-id: http://core.svn.wordpress.org/trunk@28454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 19:22:13 +00:00
Scott Taylor 061b5d398b Move `default` to the bottom in `_wp_mysql_week()`. 
See #28409.

Built from https://develop.svn.wordpress.org/trunk@28634


git-svn-id: http://core.svn.wordpress.org/trunk@28453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 18:10:15 +00:00
Scott Taylor af860fbe84 Cleanup for `switch` statements: 
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.


Built from https://develop.svn.wordpress.org/trunk@28633


git-svn-id: http://core.svn.wordpress.org/trunk@28452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 17:58:15 +00:00
Drew Jaynes cb0fc9c64b Update the `$secure_logged_in_cookie` variable in the 'secure_logged_in_cookie' hook docs following [28627]. 
See #15330.

Built from https://develop.svn.wordpress.org/trunk@28628


git-svn-id: http://core.svn.wordpress.org/trunk@28448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 15:20:16 +00:00
Andrew Nacin 733057e7d6 Use a secure logged_in_cookie when the home URL is forced HTTPS (see #27954). 
see #15330.

Built from https://develop.svn.wordpress.org/trunk@28627


git-svn-id: http://core.svn.wordpress.org/trunk@28447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 15:08:15 +00:00
Andrew Ozz 15a1f80885 TinyMCE in iOS: 
- Fix placing the caret at the bottom of longer posts when the keyboard is open.
- Disable resizing on switching editors and on show/hide the kitchen sink row.
See #28242
Built from https://develop.svn.wordpress.org/trunk@28626


git-svn-id: http://core.svn.wordpress.org/trunk@28446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 02:38:16 +00:00
Andrew Ozz 1e8b5ef008 TinyMCE: remove margins from the image toolbar wrapper, props avryl, fixes #28389 
Built from https://develop.svn.wordpress.org/trunk@28624


git-svn-id: http://core.svn.wordpress.org/trunk@28445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 22:59:14 +00:00
Scott Taylor ae3d1fccfb Simplify the logic for determining `isset( $this->query['s'] )` after [28612], and don't limit this logic to just the main query. 
Props SergeyBiryukov.
Fixes #11330.

Built from https://develop.svn.wordpress.org/trunk@28623


git-svn-id: http://core.svn.wordpress.org/trunk@28444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 20:50:15 +00:00
Scott Taylor d0bdcc3e7a If `post_status` is passed to `WP_Query` as an array containing `'any'` and anything else, don't exclude the other values if they match when running `any`'s exclusion logic. 
Adds unit tests.

Fixes #28007.

Built from https://develop.svn.wordpress.org/trunk@28622


git-svn-id: http://core.svn.wordpress.org/trunk@28443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 20:42:18 +00:00
Scott Taylor 96d788132a When queries are passed to `WP_Tax_Query`, the value for `operator` is assumed to be uppercase. This is an unnecessary constraint. In `->get_sql()`, cast it using `$operator = strtoupper( $query['operator'] )`. 
Props clifgriffin.
Fixes #27557.

Built from https://develop.svn.wordpress.org/trunk@28618


git-svn-id: http://core.svn.wordpress.org/trunk@28442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 17:53:15 +00:00
Helen Hou-Sandí 207bfa43b3 Fix a jshint error introduced in [28607]. see #23560. 
Built from https://develop.svn.wordpress.org/trunk@28617


git-svn-id: http://core.svn.wordpress.org/trunk@28441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 14:25:14 +00:00
Helen Hou-Sandí 3f1deae10b Don't use the box shadow focus styling for the admin menu or toolbar. see #28267. 
Built from https://develop.svn.wordpress.org/trunk@28616


git-svn-id: http://core.svn.wordpress.org/trunk@28440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 14:23:15 +00:00
Andrew Ozz e518fda253 Regex should be non-greedy, see #28389 
Built from https://develop.svn.wordpress.org/trunk@28615


git-svn-id: http://core.svn.wordpress.org/trunk@28439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 07:56:14 +00:00
Andrew Ozz 500bfe7a54 TinyMCE: fix problems with undo/redo after resizing an image several times. Fixes #28389. 
Built from https://develop.svn.wordpress.org/trunk@28614


git-svn-id: http://core.svn.wordpress.org/trunk@28438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 07:51:14 +00:00
Scott Taylor c367eb71e5 If `post__in` or `post_parent__in` is passed to `WP_Query` as an empty array, nuke the query. Both vars are currently only checked for truthiness after which they are ignored. Setting these vars at all indicates explicit filtering being desired. 
Adds unit test.

Fixes #28099.

Built from https://develop.svn.wordpress.org/trunk@28613


git-svn-id: http://core.svn.wordpress.org/trunk@28437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 06:04:15 +00:00
Scott Taylor dfb75f0833 When parsing the main query, if `s` is set to empty: `?s=` and `$this->is_main_query() && array_key_exists( 's', $this->query )` - kill the query instead of loading the homepage. This will load the search page with no results. 
Fixes #11330.


Built from https://develop.svn.wordpress.org/trunk@28612


git-svn-id: http://core.svn.wordpress.org/trunk@28436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 05:48:14 +00:00
Andrew Nacin 39b1c52808 Append the date to $wp_version in the build output, for nightly packages. 
props azaozz.
fixes #26751.

Built from https://develop.svn.wordpress.org/trunk@28611


git-svn-id: http://core.svn.wordpress.org/trunk@28435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 04:33:15 +00:00
Andrew Nacin 801df52e51 Force SSL on the frontend via canonical when the home URL uses the https scheme. 
fixes #27954.

Built from https://develop.svn.wordpress.org/trunk@28610


git-svn-id: http://core.svn.wordpress.org/trunk@28434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 04:13:13 +00:00
Andrew Nacin d29dc48134 Forcing SSL logins now forces SSL for the entire admin, with no middle ground. 
fixes #10267.

Built from https://develop.svn.wordpress.org/trunk@28609


git-svn-id: http://core.svn.wordpress.org/trunk@28433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 03:59:15 +00:00
Helen Hou-Sandí 78d90bd443 At long last, improved keyboard accessibility for the media modal. 
props lessbloat, grahamarmfield, sharonaustin, bramd.
see #23560.

Built from https://develop.svn.wordpress.org/trunk@28607


git-svn-id: http://core.svn.wordpress.org/trunk@28431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 03:39:15 +00:00
Andrew Ozz c4243e53d0 TinyMCE: update to 4.0.28. Also includes 43fff5b453. Part-props avryl for the patch on #27941, fixes #28391, #27941. 
Built from https://develop.svn.wordpress.org/trunk@28606


git-svn-id: http://core.svn.wordpress.org/trunk@28430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 00:59:15 +00:00
Scott Taylor fa38396998 Allow users to sort posts by `type` in `WP_Query`. 
Props DeBAAT.
Fixes #28214.

Built from https://develop.svn.wordpress.org/trunk@28605


git-svn-id: http://core.svn.wordpress.org/trunk@28429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 00:24:14 +00:00
Dominik Schilling d40280d0db Pass `$post->ID` to `get_comments_number` filter. 
Also fixes indentation and a typo in corresponding filter docs.

see #26240.
Built from https://develop.svn.wordpress.org/trunk@28604


git-svn-id: http://core.svn.wordpress.org/trunk@28428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 22:36:15 +00:00
Drew Jaynes 6989c5ab46 Fix parameter description for the `$post_id` argument in `get_comments_number()` to note that it is optional. 
Also fixes the corresponding filter docs, as `$post_id`, not `$post` is passed to the filter.

See [27156]. Fixes #26240.

Built from https://develop.svn.wordpress.org/trunk@28602


git-svn-id: http://core.svn.wordpress.org/trunk@28427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 22:05:18 +00:00
Andrew Nacin 3a2174002e Revert [28579] and [28582]. see #21963. 
Built from https://develop.svn.wordpress.org/trunk@28601


git-svn-id: http://core.svn.wordpress.org/trunk@28426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 18:14:15 +00:00
Sergey Biryukov e269d48b99 Display Dashboard icon instead of the home icon in toolbar when the link leads to Dashboard. 
props ghost1227.
fixes #26754.
Built from https://develop.svn.wordpress.org/trunk@28599


git-svn-id: http://core.svn.wordpress.org/trunk@28424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 13:42:14 +00:00
Sergey Biryukov 13cbcdd1ad Fix SlideShare oEmbed regex. 
props kovshenin.
fixes #28380.
Built from https://develop.svn.wordpress.org/trunk@28597


git-svn-id: http://core.svn.wordpress.org/trunk@28422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 13:32:17 +00:00
Scott Taylor 7e74b8909e RIP Viddler oEmbed support. 
More: https://gigaom.com/2014/02/07/viddler-gets-ready-to-delete-personal-videos/

See #28379.


Built from https://develop.svn.wordpress.org/trunk@28596


git-svn-id: http://core.svn.wordpress.org/trunk@28421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 22:00:14 +00:00
Scott Taylor c5790a80fc Update the Scribd oEmbed pattern to more actually represent which endpoints from the site are discoverable. 
See #28379.

Built from https://develop.svn.wordpress.org/trunk@28595


git-svn-id: http://core.svn.wordpress.org/trunk@28420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 21:55:14 +00:00
Scott Taylor 987e9905ac When parsing an `[embed]` shortcode into a TinyMCE view, don't attempt to append any returned `<script>`s to the editor's `<head>`. This affects only a few supported endpoints: Issuu and Twitter. 
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28594


git-svn-id: http://core.svn.wordpress.org/trunk@28419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 20:00:15 +00:00
Scott Taylor cb68638968 For YouTube playlist oEmbed, we need keep BC for `wp_oembed_remove_provider()` by not changing the existing YouTube endpoint keys. So, rather than merging the rules, the playlist endpoints should be on their own line. 
Props kovshenin.

See #28125, [28552].

Built from https://develop.svn.wordpress.org/trunk@28593


git-svn-id: http://core.svn.wordpress.org/trunk@28418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 18:43:14 +00:00
Sergey Biryukov 12ea0c3045 Pass anchor text to 'edit_post_link' and 'edit_comment_link' filters. 
props kwight.
fixes #28373.
Built from https://develop.svn.wordpress.org/trunk@28590


git-svn-id: http://core.svn.wordpress.org/trunk@28415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 13:43:14 +00:00
Sergey Biryukov aab2e48fa0 Update documentation for is_new_day(). 
props obenland.
fixes #28333.
Built from https://develop.svn.wordpress.org/trunk@28588


git-svn-id: http://core.svn.wordpress.org/trunk@28413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 11:41:14 +00:00
Sergey Biryukov f4a6632200 Clean up wp_widget_rss_output(): 
* Fix appending [&hellip;] to $summary.
* Use wp_trim_words() instead of wp_html_excerpt().
* Trim $title before checking if it's empty. props UmeshSingla.
* Use correct escaping function for $title.

fixes #28356.
Built from https://develop.svn.wordpress.org/trunk@28586


git-svn-id: http://core.svn.wordpress.org/trunk@28411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 11:08:14 +00:00
Sergey Biryukov 2b6c8462b3 Avoid a PHP notice in adjacent_image_link() if no images were found. 
props nabil_kadimi.
see #28361.
Built from https://develop.svn.wordpress.org/trunk@28584


git-svn-id: http://core.svn.wordpress.org/trunk@28409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 10:55:16 +00:00
Scott Taylor 8653099a83 In `wp_get_object_terms()`, before returning terms (and before running them through the 'wp_get_object_terms' filter) - run them through `$terms = array_values( array_unique( $terms, SORT_REGULAR ) )`. 
There will be "dupes" when the function is called with `'fields' => 'all_with_object_id'`, but the objects will actually be unique due to the `object_id` addition, so they shouldn't be filtered out. 

Adds unit tests. All other unit tests pass.

Fixes #11003.

Built from https://develop.svn.wordpress.org/trunk@28583


git-svn-id: http://core.svn.wordpress.org/trunk@28408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 03:29:14 +00:00
Scott Taylor 714aae91ea Fix some inline docs churn in `wp_insert_post()` after [28579]. 
Props kpdesign.
See #21963.


Built from https://develop.svn.wordpress.org/trunk@28582


git-svn-id: http://core.svn.wordpress.org/trunk@28407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 00:24:15 +00:00
Scott Taylor 3c1723afd7 When adding a URL in the `Insert from URL` state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields. 
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.

Built from https://develop.svn.wordpress.org/trunk@28581


git-svn-id: http://core.svn.wordpress.org/trunk@28406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:57:14 +00:00
Scott Taylor 89864b4a5a Don't pass embeds through `the_content()` when trying to render MCE previews, leverage `WP_Embed` and `do_shortcode()` instead. 
Props kovshenin.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28580


git-svn-id: http://core.svn.wordpress.org/trunk@28405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:43:15 +00:00
Scott Taylor b184336927 Combine `wp_insert_attachment()` and `wp_insert_post()`. `wp_insert_attachment()` becomes a wrapper. Update inline docs. 
Props wonderboymusic, DrewAPicture.
See #21963.

Built from https://develop.svn.wordpress.org/trunk@28579


git-svn-id: http://core.svn.wordpress.org/trunk@28404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:20:13 +00:00
Scott Taylor f3e71ae45f Add oEmbed support for Mixcloud. 
Props Jayjdk.
Fixes #27169.


Built from https://develop.svn.wordpress.org/trunk@28578


git-svn-id: http://core.svn.wordpress.org/trunk@28403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:09:14 +00:00
Scott Taylor 746397f18b Allow the settings view for galleries to be disabled when instantiating `wp.media.controller.GalleryEdit`. 
Props nd987.
Fixes #23116.

Built from https://develop.svn.wordpress.org/trunk@28577


git-svn-id: http://core.svn.wordpress.org/trunk@28402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 22:49:16 +00:00
Andrew Ozz 1ba1b3ec29 TinyMCE: fix saving the editor content on switching Visual -> Text, fixes #28353 
Built from https://develop.svn.wordpress.org/trunk@28576


git-svn-id: http://core.svn.wordpress.org/trunk@28401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-25 22:47:13 +00:00
Sergey Biryukov 4238d2f53f Fix typo in [28574]. 
see #28360.
Built from https://develop.svn.wordpress.org/trunk@28575


git-svn-id: http://core.svn.wordpress.org/trunk@28400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-25 16:12:14 +00:00
Sergey Biryukov ccb6ba9446 Replace $in_same_cat with $in_same_term in adjacent post functions for consistency. 
props ixkaito.
fixes #28360.
Built from https://develop.svn.wordpress.org/trunk@28574


git-svn-id: http://core.svn.wordpress.org/trunk@28399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-25 16:10:13 +00:00
Sergey Biryukov de9a9fd8ea Suggest get_current_site() as an alternative for get_current_site_name(). 
props jesin.
fixes #28346.
Built from https://develop.svn.wordpress.org/trunk@28573


git-svn-id: http://core.svn.wordpress.org/trunk@28398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-25 14:32:16 +00:00
Sergey Biryukov 4782165279 Fix inversed logic in Walker_Category::start_el(). see [28359]. 
Correct 'use_desc_for_title' parameter description.

see #26557.
Built from https://develop.svn.wordpress.org/trunk@28572


git-svn-id: http://core.svn.wordpress.org/trunk@28397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 13:42:15 +00:00
Sergey Biryukov ac434b5c39 Pass $post to 'protected_title_format' and 'private_title_format' filters. 
props johnjamesjacoby, DrewAPicture.
fixes #23724.
Built from https://develop.svn.wordpress.org/trunk@28571


git-svn-id: http://core.svn.wordpress.org/trunk@28396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 06:48:16 +00:00
Drew Jaynes 3e0521c2cf Add inline documentation for the `option_none_value` argument added to `wp_dropdown_users|categories()` in [28564]. 
Fixes #16625.

Built from https://develop.svn.wordpress.org/trunk@28570


git-svn-id: http://core.svn.wordpress.org/trunk@28395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 05:39:15 +00:00
Drew Jaynes a1955d78ee Use three-digit x.x.x style version for `@deprecated` phpDoc tags. 
See #18298.

Built from https://develop.svn.wordpress.org/trunk@28569


git-svn-id: http://core.svn.wordpress.org/trunk@28394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 05:23:14 +00:00
Andrew Ozz f7186fb198 TinyMCE: update to 4.0.26. Includes fixes for the 'paste' plugin (paste from Word/Excel, paste in WebKit/Blink), show/hide/isHidden in inline mode, drag/drop in tables and in Safari, and others. Fixes #28342, #28016, #28250 and #28067 
Built from https://develop.svn.wordpress.org/trunk@28568


git-svn-id: http://core.svn.wordpress.org/trunk@28393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 01:44:15 +00:00
Andrew Ozz 8bc84c0441 wpView: fix selecting a view's text string in Safari, props gcorne, fixes #28088 
Built from https://develop.svn.wordpress.org/trunk@28565


git-svn-id: http://core.svn.wordpress.org/trunk@28391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 20:56:14 +00:00
Scott Taylor 53ea68e838 `wp_dropdown_pages()` allows `option_none_value` to be passed. Add that arg to the `$defaults` for `wp_dropdown_users()` and `wp_dropdown_categories()` as well. 
Props solarissmoke. 
Fixes #16625.

Built from https://develop.svn.wordpress.org/trunk@28564


git-svn-id: http://core.svn.wordpress.org/trunk@28390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 20:47:15 +00:00
Scott Taylor b75c79500b Replaces all uses of `TEMPLATEPATH` and `STYLESHEETPATH` in core with `get_template_directory()` and `get_stylesheet_directory()`. 
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.

Props obenland, aaroncampbell. 
Fixes #18298.

Built from https://develop.svn.wordpress.org/trunk@28563


git-svn-id: http://core.svn.wordpress.org/trunk@28389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 20:12:15 +00:00
Scott Taylor 44c4b365a0 When adding queries to `tax_query`: if the query's `field` is `term_taxonomy_id`, don't require `taxonomy` to be specified. In `WP_Tax_Query::transform_query()`, `$query['taxonomy']` is never checked for the 'term_taxonomy_id' `case` because 'term_taxonomy_id' is the primary key being looked up. 
Adds unit tests.

Props helen.
Fixes #25284.


Built from https://develop.svn.wordpress.org/trunk@28562


git-svn-id: http://core.svn.wordpress.org/trunk@28388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 19:59:14 +00:00
Scott Taylor f50d5233f3 Truly check for `! empty()` instead of falsey `''` when determining whether to add `LIMIT` clause to SQL in `wp_get_archives()`. 
Props jjeaton for the initial patch.
Fixes #27834.

Built from https://develop.svn.wordpress.org/trunk@28560


git-svn-id: http://core.svn.wordpress.org/trunk@28386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 18:28:14 +00:00
Scott Taylor 3214d6d325 Read the `src` attribute for the `[embed]` shortcode if the shortcode's body is empty. 
These work:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"]`
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"][/embed]`

If you do:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"]http://any-other-url.com[/embed]`

... "http://any-other-url.com" will be the URL that is parsed.

Props kovshenin, aaroncampbell for making initial patches.
Fixes #24456.


Built from https://develop.svn.wordpress.org/trunk@28559


git-svn-id: http://core.svn.wordpress.org/trunk@28385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 18:06:13 +00:00
Scott Taylor e8181b0934 Allow `get_comments_number()` to officially accept `$post` or `$post_id`. Adds unit tests. 
Props coffee2code, JanHenkG.
Fixes #26240.

Built from https://develop.svn.wordpress.org/trunk@28558


git-svn-id: http://core.svn.wordpress.org/trunk@28384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 17:44:14 +00:00
John Blackbourn 03410a4067 Add CollegeHumor.com oEmbed support. Fixes #24497. Props johnzanussi. 
Built from https://develop.svn.wordpress.org/trunk@28557


git-svn-id: http://core.svn.wordpress.org/trunk@28383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 23:47:15 +00:00
Scott Taylor 10e1d66318 Viddler has had a new oEmbed endpoint for at least 10 months. Let us update to it. 
Props garhdez.
Fixes #24296.

Built from https://develop.svn.wordpress.org/trunk@28556


git-svn-id: http://core.svn.wordpress.org/trunk@28382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 23:17:15 +00:00
Scott Taylor fe044c84f7 Support Polldaddy's short URL format as a whitelisted oEmbed provider. 
Props donncha.
Fixes #28283.


Built from https://develop.svn.wordpress.org/trunk@28555


git-svn-id: http://core.svn.wordpress.org/trunk@28381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 23:13:14 +00:00
Scott Taylor ee43d258c2 Add Issuu to list of whitelisted oEmbed providers. 
Props issuu.
Fixes #28312.


Built from https://develop.svn.wordpress.org/trunk@28554


git-svn-id: http://core.svn.wordpress.org/trunk@28380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 21:50:14 +00:00
Scott Taylor 8d4d645629 Fix parsing in `wp_match_mime_types()` to allow some mime-types with `+` in them to appear in the list of filter links shown above the list table on `upload.php`. 
Props _duck.
Fixes #20672.


Built from https://develop.svn.wordpress.org/trunk@28553


git-svn-id: http://core.svn.wordpress.org/trunk@28379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 21:36:15 +00:00
Scott Taylor e0a57ed96a Support oEmbed matching for YouTube playlist URLs. 
Fixes #28125.

Built from https://develop.svn.wordpress.org/trunk@28552


git-svn-id: http://core.svn.wordpress.org/trunk@28378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 21:12:15 +00:00
Scott Taylor fcd6920bb8 In `is_user_option_local()`, `$user_id` is set conditionally, but never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28551


git-svn-id: http://core.svn.wordpress.org/trunk@28377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:18:14 +00:00
Scott Taylor dd25ef25d9 `$count` is set in `get_post_galleries()` and never used, relic from PFUI RIP. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28550


git-svn-id: http://core.svn.wordpress.org/trunk@28376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:13:14 +00:00
Scott Taylor abff6bf6cf `$gallery_div` is set twice in `gallery_shortcode()` before it is used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28549


git-svn-id: http://core.svn.wordpress.org/trunk@28375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:12:14 +00:00
Scott Taylor 09046cb2a3 In `get_attachment_icon_src()`, `$class` is set in 2 conditions but never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28548


git-svn-id: http://core.svn.wordpress.org/trunk@28374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:08:14 +00:00
Scott Taylor c5ba45a11b `break` is unreachable in `WP_Theme::translate_header()`. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28547


git-svn-id: http://core.svn.wordpress.org/trunk@28373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:05:14 +00:00
Scott Taylor 6177a39971 In `WP_Customize_Manager::register_controls()`, `$menu_locations` is set and never used. 
Built from https://develop.svn.wordpress.org/trunk@28546


git-svn-id: http://core.svn.wordpress.org/trunk@28372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:01:15 +00:00
Sergey Biryukov fdaa694ac7 Remove unnecessary array_reverse() from wp_get_post_revisions(). 
WP_Query properly handles multiple 'orderby' values since [28541].

fixes #26042.
Built from https://develop.svn.wordpress.org/trunk@28543


git-svn-id: http://core.svn.wordpress.org/trunk@28369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:51:14 +00:00
Scott Taylor e4bc49c244 Because PHP can be configured without `--filter`, it is not 100% safe to use `filter_var()`. This is problematic for casting `"false"` to `false`, as PHP always casts it to `true`. `FILTER_VALIDATE_BOOLEAN` fixes this, but it may not be available. 
Add a new function, `wp_validate_boolean()`, to replace `filter_var( $var, FILTER_VALIDATE_BOOLEAN )`.

Fixes #28170.


Built from https://develop.svn.wordpress.org/trunk@28542


git-svn-id: http://core.svn.wordpress.org/trunk@28368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:34:15 +00:00
Scott Taylor 333083debe Apply `order` to each passed value for `orderby` in `WP_Query`: 
* Since `orderby` in `WP_Query` can accept space-delimited sets, yet only one `order` value: when multiple values are passed (and `DESC` is the order), the default sort order `ASC` is being applied to all values before the last in the set.
* There is a unit test that sporadically fails since 3.6 in `tests/post/revision` due to multiple posts having the same `post_date` from being added so rapidly
* When ordering revisions in `wp_get_post_revisions()`, order by `post_date ID`
* Change the `order` value in `wp_get_post_revisions()` to `ASC`. This will produce SQL like: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID ASC`. Previously, this would have produced SQL like: `ORDER BY $wpdb->posts.post_date DESC`, and with the addition of ` ID`: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID DESC`. Clearly, wrong. The original SQL produced: `ORDER BY $wpdb->posts.post_date DESC`. As such, return the reversions in reverse order using `array_reverse()`. Not doing so would break "Preview Changes."
* Add unit tests to assert that all of this works.
* All existing unit tests pass with the change to ordering multiple `orderby`s in `WP_Query`.
* In the future, we should support independent `order` for each `orderby`, see #17065.

Props SergeyBiryukov, wonderboymusic.
Fixes #26042.

Built from https://develop.svn.wordpress.org/trunk@28541


git-svn-id: http://core.svn.wordpress.org/trunk@28367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:19:13 +00:00
Sergey Biryukov 9b9b8ec413 Use correct variable. see [28534], [28538]. 
see #22400.
Built from https://develop.svn.wordpress.org/trunk@28540


git-svn-id: http://core.svn.wordpress.org/trunk@28366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 17:40:14 +00:00
Scott Taylor b8d469600b These functions import `$wpdb` but do not use it. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28539


git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 17:37:14 +00:00