Commit Graph

11439 Commits

Author SHA1 Message Date
Dion Hulse 7a6fad844a WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments.
Built from https://develop.svn.wordpress.org/trunk@25305


git-svn-id: http://core.svn.wordpress.org/trunk@25267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 02:55:09 +00:00
Dion Hulse 6d1ffc62ea WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237
Built from https://develop.svn.wordpress.org/trunk@25304


git-svn-id: http://core.svn.wordpress.org/trunk@25266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 02:43:08 +00:00
Helen Hou-Sandí 8798685de5 Alignment standards for [25296]. props DrewAPicture. see #25171.
Built from https://develop.svn.wordpress.org/trunk@25300


git-svn-id: http://core.svn.wordpress.org/trunk@25263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 22:07:09 +00:00
Sergey Biryukov 05d55a400b Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250.
Built from https://develop.svn.wordpress.org/trunk@25298


git-svn-id: http://core.svn.wordpress.org/trunk@25261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 18:17:10 +00:00
Helen Hou-Sandí 304426cece Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171.
Built from https://develop.svn.wordpress.org/trunk@25297


git-svn-id: http://core.svn.wordpress.org/trunk@25260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 16:20:09 +00:00
Helen Hou-Sandí 89421ddeaa Add `media_submitbox_misc_sections` and `audio_submitbox_misc_sections` filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171.
Built from https://develop.svn.wordpress.org/trunk@25296


git-svn-id: http://core.svn.wordpress.org/trunk@25259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 16:19:10 +00:00
Sergey Biryukov 3b08ae25e4 Clarify a string in discussion settings. props Ipstenu, DrewAPicture. fixes #16705.
Built from https://develop.svn.wordpress.org/trunk@25295


git-svn-id: http://core.svn.wordpress.org/trunk@25258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 15:36:09 +00:00
Andrew Nacin 74092c3960 Correct @since in admin-footer. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25288


git-svn-id: http://core.svn.wordpress.org/trunk@25252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:38:09 +00:00
Scott Taylor a4841da471 Use `get_the_title()` when dealing with `post_type`-like items in the admin.
Props nacin, DrewAPicture.
Fixes #14975.


Built from https://develop.svn.wordpress.org/trunk@25285


git-svn-id: http://core.svn.wordpress.org/trunk@25249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:08:08 +00:00
Andrew Nacin e17beb58f7 Mark the hooks in custom-background.php as duplicates.
* image_size_names_choose should be documented in wp-includes/media.php
 * wp_create_file_in_uploads should be documented in custom-header.php

see #25229.

Built from https://develop.svn.wordpress.org/trunk@25283


git-svn-id: http://core.svn.wordpress.org/trunk@25247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:05:09 +00:00
Andrew Nacin 090e0e24b9 Document comment_edit_redirect.
props dustyf.
see #25229.

Built from https://develop.svn.wordpress.org/trunk@25282


git-svn-id: http://core.svn.wordpress.org/trunk@25246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:01:09 +00:00
Andrew Nacin 5e0040a6ca Add new ajax_query_attachments_args filter.
props alex-ye.
fixes #24285.

Built from https://develop.svn.wordpress.org/trunk@25279


git-svn-id: http://core.svn.wordpress.org/trunk@25243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 15:18:09 +00:00
Sergey Biryukov 897ddbd76c Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross.
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.
Built from https://develop.svn.wordpress.org/trunk@25277


git-svn-id: http://core.svn.wordpress.org/trunk@25242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 14:10:09 +00:00
Dion Hulse db6cf37f91 WP_Filesystem: FTP Sockets: Avoid using the file_exists() / is_exists() / exists() PemFTP functionality as it's buggy on ncFTPd servers, switching to listing the file instead which is what we use for the FTP Extension transport. Fixes #14049
Built from https://develop.svn.wordpress.org/trunk@25274


git-svn-id: http://core.svn.wordpress.org/trunk@25240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 08:29:09 +00:00
Andrew Nacin 9fdfa7ef5c Short descriptions for inline docs should end with a period, per the vast majority of core. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25273


git-svn-id: http://core.svn.wordpress.org/trunk@25239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 01:38:09 +00:00
Dion Hulse 443aa35cfc Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704
Built from https://develop.svn.wordpress.org/trunk@25272


git-svn-id: http://core.svn.wordpress.org/trunk@25238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 01:33:09 +00:00
Andrew Nacin 5cb01f0b9b Stop using get_blogaddress_by_domain() when updating the siteurl/homeurl from the network admin.
props jeremyfelt, SergeyBiryukov.
fixes #18242. see #25235.

Built from https://develop.svn.wordpress.org/trunk@25261


git-svn-id: http://core.svn.wordpress.org/trunk@25229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 18:49:09 +00:00
Scott Taylor bb0761e475 Remove redundant checks in some update functions. Adds some readability/coding standards cleanup.
Props miqrogroove, azaozz.
Fixes #22828.

Built from https://develop.svn.wordpress.org/trunk@25256


git-svn-id: http://core.svn.wordpress.org/trunk@25224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 17:05:15 +00:00
Scott Taylor 31f26dc3ce Remove lingering instances of call time pass-by-reference, limited to instances of `callable` - use `$this` instead of `&$this`.
Props jdgrimes.
See #25160.


Built from https://develop.svn.wordpress.org/trunk@25254


git-svn-id: http://core.svn.wordpress.org/trunk@25222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 16:34:09 +00:00
Andrew Nacin 5a1109b40b Hook docs for admin-footer.php.
props natejacobs.
see #25229.

Built from https://develop.svn.wordpress.org/trunk@25252


git-svn-id: http://core.svn.wordpress.org/trunk@25220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 16:21:09 +00:00
Andrew Nacin 4bb33bf19c Inline documentation for the welcome_panel hook.
props natejacobs.
see #25229.

Built from https://develop.svn.wordpress.org/trunk@25250


git-svn-id: http://core.svn.wordpress.org/trunk@25218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 16:07:09 +00:00
Scott Taylor ffe8f1b13a Remove unnecessary checks before setting `$wp_settings_*` arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional `array`.
Props scribu.
Fixes #17884.


Built from https://develop.svn.wordpress.org/trunk@25240


git-svn-id: http://core.svn.wordpress.org/trunk@25210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 19:07:09 +00:00
Andrew Nacin 4e30ca031b Clarify a database upgrade string, for 3.7.
props SergeyBiryukov.
fixes #24845.

Built from https://develop.svn.wordpress.org/trunk@25237


git-svn-id: http://core.svn.wordpress.org/trunk@25207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 17:50:09 +00:00
Dion Hulse 4231f4668a Core Auto Updates: Add a initial skin to allow capturing the output from the upgrader without displaying it (such as we need during cron calls).
This has been copied almost verbatim from the automatic-updater plugin with a few style tweaks and additional upgrade-possible check. See #22704

Built from https://develop.svn.wordpress.org/trunk@25228


git-svn-id: http://core.svn.wordpress.org/trunk@25198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 07:17:09 +00:00
Dion Hulse bc02809fe3 Upgrader: Split the UI "skins" out from the main Upgrader file into a seperate file to reduce the length of the files. See #22704
Built from https://develop.svn.wordpress.org/trunk@25227


git-svn-id: http://core.svn.wordpress.org/trunk@25197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 06:35:10 +00:00
Sergey Biryukov a9cb64b537 Avoid 'Only variables should be passed by reference' notice on Widgets screen. props jdgrimes. fixes #25225.
Built from https://develop.svn.wordpress.org/trunk@25226


git-svn-id: http://core.svn.wordpress.org/trunk@25196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 05:11:09 +00:00
Dion Hulse 88702eba45 Core Updates: Switch to using a new 1.7 version check API which will return extra auto-update packages when requested over SSL. The new API has switched to returning JSON. See #22704
Built from https://develop.svn.wordpress.org/trunk@25219


git-svn-id: http://core.svn.wordpress.org/trunk@25190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-03 03:22:10 +00:00
Sergey Biryukov 145809b457 Consolidate similar menu locations strings. props DrewAPicture. fixes #24945.
Built from https://develop.svn.wordpress.org/trunk@25218


git-svn-id: http://core.svn.wordpress.org/trunk@25189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-03 01:42:10 +00:00
Sergey Biryukov 68ebb31a97 Set min-height for menu item title. props garyc40. fixes #16787.
Built from https://develop.svn.wordpress.org/trunk@25211


git-svn-id: http://core.svn.wordpress.org/trunk@25183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 17:35:10 +00:00
Sergey Biryukov 89aed6d7e8 Avoid 'Only variables should be passed by reference' notice on plugin search. props daankortenbach. fixes #25217.
Built from https://develop.svn.wordpress.org/trunk@25210


git-svn-id: http://core.svn.wordpress.org/trunk@25182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 13:54:10 +00:00
Sergey Biryukov eccd3e42df Deprecate wp_nav_menu_locations_meta_box(), unused since [23441]. props DrewAPicture. fixes #24942.
Built from https://develop.svn.wordpress.org/trunk@25209


git-svn-id: http://core.svn.wordpress.org/trunk@25181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 11:26:09 +00:00
Sergey Biryukov 0d0c87041c Move get_real_file_to_edit() upper in the file for consistency with the existing order of functions. Some phpdoc fixes and additions. see #23680.
Built from https://develop.svn.wordpress.org/trunk@25208


git-svn-id: http://core.svn.wordpress.org/trunk@25180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 11:19:10 +00:00
Sergey Biryukov 5a8dc364d1 Fix a grammar error on Permalink Settings screen. props celloexpressions. fixes #25210.
Built from https://develop.svn.wordpress.org/trunk@25206


git-svn-id: http://core.svn.wordpress.org/trunk@25178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 10:04:10 +00:00
Sergey Biryukov 6760d294bb Update phpdoc for get_user_to_edit(), get_userdata(), and get_user_by(). props tivnet. fixes #24992.
Built from https://develop.svn.wordpress.org/trunk@25204


git-svn-id: http://core.svn.wordpress.org/trunk@25176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 03:25:09 +00:00
Sergey Biryukov 00c9232a19 Move get_real_file_to_edit() to wp-admin/includes/deprecated.php. props iamfriendly. fixes #23680.
Built from https://develop.svn.wordpress.org/trunk@25201


git-svn-id: http://core.svn.wordpress.org/trunk@25173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-01 12:37:12 +00:00
Andrew Nacin 8e56222a1a Nav menus: Allow assigning a new menu to an existing location when no theme setting is currently saved.
props ocean90.
see #25064, for trunk.

Built from https://develop.svn.wordpress.org/trunk@25195


git-svn-id: http://core.svn.wordpress.org/trunk@25167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-31 01:37:08 +00:00
Andrew Nacin 0496b1acfd Hide 'Database Upgrade Required' on admin/network/upgrade.php when you are not being asked to upgrade, to prevent confusion.
props duck_.
see #24845. see #23540.

Built from https://develop.svn.wordpress.org/trunk@25191


git-svn-id: http://core.svn.wordpress.org/trunk@25163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-31 00:57:10 +00:00
Andrew Ozz cd4d1460c6 Fix folding/unfolding of the admin menu on new installs, props SergeyBiryukov, fixes #24921 for 3.6.1.
Built from https://develop.svn.wordpress.org/trunk@25186


git-svn-id: http://core.svn.wordpress.org/trunk@25158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-30 17:11:08 +00:00
Dion Hulse d221f04e60 Plugin Upgrader: Plugin_Upgrader::upgrade() returns nothing in event of success, every other install(), upgrade() and bulk_upgrade() method returns true, so return true;
Built from https://develop.svn.wordpress.org/trunk@25181


git-svn-id: http://core.svn.wordpress.org/trunk@25153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-30 07:38:09 +00:00
Dion Hulse d3bd82f0ac Theme Upgrader: Be super-careful and check the contents of the $wp_theme_directories variable before merging it, if someone has changed it directly, or worse, unset it, this could've resulted in the $protected_directories being empty. See [25082] See #22501
Built from https://develop.svn.wordpress.org/trunk@25180


git-svn-id: http://core.svn.wordpress.org/trunk@25152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-30 07:35:09 +00:00
Andrew Nacin af70c14d6d Add signup_id primary key to $wpdb->signups, and add better indexes.
props josephscott, pento, barry.
see #15004.

Built from https://develop.svn.wordpress.org/trunk@25179


git-svn-id: http://core.svn.wordpress.org/trunk@25151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-30 04:30:08 +00:00
Andrew Nacin cb154ad4f5 Move wp-config-sample.php to the root of develop.svn.
wp-config.php is now created in the root. wp-config-sample.php is properly copied over to the build directory for syncing to core.svn.

Add some ignores.

fixes #25185, see #24976.


Built from https://develop.svn.wordpress.org/trunk@25173


git-svn-id: http://core.svn.wordpress.org/trunk@25147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-29 20:46:09 +00:00
Andrew Nacin f16aee063e Avoid validating wildcard hostnames in populate_network() when multisite is already activated.
props jeremyfelt.
fixes #25182.

Built from https://develop.svn.wordpress.org/trunk@25171


git-svn-id: http://core.svn.wordpress.org/trunk@25146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-29 19:31:09 +00:00
Andrew Nacin 63568b0b61 Return to 'Item' for term updated messages for the link_category taxonomy.
props SergeyBiryukov, pavelevap.
fixes #18714.

Built from https://develop.svn.wordpress.org/trunk@25158


git-svn-id: http://core.svn.wordpress.org/trunk@25137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-28 18:59:09 +00:00
Andrew Nacin 09e92faa6c Use Dropbox's zxcvbn library for our password meter.
The library was added in [25156].

props duck_.
see #21737.

Built from https://develop.svn.wordpress.org/trunk@25157


git-svn-id: http://core.svn.wordpress.org/trunk@25136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-28 16:09:10 +00:00
Dominik Schilling 1eb25761ee Replace duplicated lines in [25143] with an assignment. see #18714.
Built from https://develop.svn.wordpress.org/trunk@25144


git-svn-id: http://core.svn.wordpress.org/trunk@25124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-27 21:25:09 +00:00
Andrew Nacin 737330ac4b Add a terms_updated_messages filter to edit-tags.php, along with taxonomy-specific strings.
props johnbillion.
fixes #18714.

Built from https://develop.svn.wordpress.org/trunk@25143


git-svn-id: http://core.svn.wordpress.org/trunk@25123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-27 21:13:08 +00:00
Helen Hou-Sandí 94bacd5887 Make shift-click checkbox range selection work in both directions. props c3mdigital, SergeyBiryukov. fixes #23427.
Built from https://develop.svn.wordpress.org/trunk@25141


git-svn-id: http://core.svn.wordpress.org/trunk@25121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-27 20:50:10 +00:00
Andrew Nacin aa6d5ddb3e Don't create an edit link to a non-UI post type in the media list table.
props johnbillion.
fixes #20453.

Built from https://develop.svn.wordpress.org/trunk@25140


git-svn-id: http://core.svn.wordpress.org/trunk@25120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-27 20:49:10 +00:00
Andrew Nacin 159e67efe2 Only show 'Preview' on the custom header screen if there is something to show.
props nickmomrik.
fixes #14531.

Built from https://develop.svn.wordpress.org/trunk@25135


git-svn-id: http://core.svn.wordpress.org/trunk@25115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-27 12:27:10 +00:00