Commit Graph

91 Commits

Author SHA1 Message Date
Sergey Biryukov bf29bb4441 Coding Standards: Use strict comparison for JS fragment in some admin files.
Follow-up to [48083].

Props nayanchamp7, rnaby.
Fixes #52845, #41988.
Built from https://develop.svn.wordpress.org/trunk@50541


git-svn-id: http://core.svn.wordpress.org/trunk@50154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 14:13:08 +00:00
Sergey Biryukov 001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov 8662d9a74d I18N: Split translatable strings located on the same line preceded with a translator comment, where the first string needs that comment, but the second does not.
Props johnbillion.
See #44360.
Built from https://develop.svn.wordpress.org/trunk@45927


git-svn-id: http://core.svn.wordpress.org/trunk@45738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-02 00:43:55 +00:00
Sergey Biryukov 16b8d91baa I18N: Improve translator comments.
* Add missing translator comments.
* Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.
Built from https://develop.svn.wordpress.org/trunk@45926


git-svn-id: http://core.svn.wordpress.org/trunk@45737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-01 17:13:59 +00:00
Gary Pendergast a02b5cc2a8 Coding Standards: Mark the handful of hook names with uppercase characters or hyphens as ignored.
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45599


git-svn-id: http://core.svn.wordpress.org/trunk@45410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 01:45:56 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Sergey Biryukov fd0564d2bc Docs: Remove incorrect `@param` tags for `admin_print_footer_scripts-{$hook_suffix}` and `admin_footer-{$hook_suffix}` dynamic actiona.
Remove `@global` tags as well as they are not suited to describe a function parameter and are documented in the description of the actions.

Props keesiemeijer.
Fixes #39527.
Built from https://develop.svn.wordpress.org/trunk@39755


git-svn-id: http://core.svn.wordpress.org/trunk@39693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-09 14:38:41 +00:00
Drew Jaynes 22adda2aa0 Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation.
Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.

Props ramiy.
See #37748.

Built from https://develop.svn.wordpress.org/trunk@38307


git-svn-id: http://core.svn.wordpress.org/trunk@38248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 18:25:31 +00:00
Drew Jaynes 2ee0027bc1 Docs: Improve usefulness of DocBlocks for ajax-actions.php functions introduced in 4.6.
See #37318.

Built from https://develop.svn.wordpress.org/trunk@38022


git-svn-id: http://core.svn.wordpress.org/trunk@37963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-09 13:23:30 +00:00
Drew Jaynes bef05b469b Docs: Standardize DocBlock summaries for hooks that serve to "print" something to use third-person singular verbs.
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37560


git-svn-id: http://core.svn.wordpress.org/trunk@37528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-25 16:05:27 +00:00
Drew Jaynes c3055cc190 Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37488


git-svn-id: http://core.svn.wordpress.org/trunk@37456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:01:30 +00:00
Sergey Biryukov 1bd88850f7 Administration: Introduce `admin_print_footer_scripts-$hook_suffix"`, a dynamic version of the `admin_print_footer_scripts` hook.
This is now more consistent with the generic `admin_print_scripts` and the dynamic `admin_print_scripts-$hook_suffix` hooks fired in `wp-admin/admin-header.php`.

Props tfrommen.
Fixes #34334.
Built from https://develop.svn.wordpress.org/trunk@37279


git-svn-id: http://core.svn.wordpress.org/trunk@37245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 15:17:27 +00:00
Scott Taylor b56b9b3e5c Add `@global` annotations for `wp-admin/*`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Dominik Schilling a7ba89b027 Accessibility: Add landmark roles to WordPress admin areas.
props afercia, joedolson.
fixes #31450.
Built from https://develop.svn.wordpress.org/trunk@31955


git-svn-id: http://core.svn.wordpress.org/trunk@31934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 13:17:27 +00:00
Drew Jaynes 2faf449f51 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/*.
Also includes some changes to move hook docs to directly precede hook lines. This is necessary to prevent DocBlock-matching confusion when core is parsed.

Affects DocBlocks for the following hooks:
* `wp_ajax_ . $_REQUEST['action']`
* `wp_ajax_nopriv_ . $_REQUEST['action']`
* `admin_footer- . $GLOBALS['hook_suffix']`
* `admin_head-$hook_suffix`
* `admin_post_nopriv_{$action}`
* `admin_post_{$action}`
* `load-  . $page_hook`
* `load- . $plugin_page`
* `load-importer- . $importer`
* `load- . $pagenow`
* `admin_action_ . $_REQUEST['action']`
* `async_upload_{$type}`
* `add_meta_boxes_ . $post_type`
* `{$taxonomy}_pre_edit_form`
* `{$taxonomy}_term_edit_form_tag`
* `{$taxonomy}_edit_form_fields`
* `{$taxonomy}_edit_form`
* `after-{$taxonomy}-table`
* `{$taxonomy}_pre_add_form`
* `{$taxonomy}_term_new_form_tag`
* `{$taxonomy}_add_form_fields`
* `{$taxonomy}_add_form`
* `media_upload_$type`
* `media_upload_$tab`
* `install_plugins_pre_$tab`
* `install_plugins_$tab`
* `install_themes_pre_{$tab}`
* `install_themes_{$tab}`
* `update-core-custom_{$action}`
* `update-custom_{$action}`
* `user_{$name}_label`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30649


git-svn-id: http://core.svn.wordpress.org/trunk@30639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:42:24 +00:00
Andrew Nacin dce0b9adea Use SSL when linking to WordPress.org. see #27115.
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:14:15 +00:00
Drew Jaynes 7d9b9027bd Fixes for hooks documentation in wp-admin/admin-footer.php.
Adds some new lines, some hook-line spacing, docs-specific variables, and other language tweaks.

See #26869, #25229, [25252].

Built from https://develop.svn.wordpress.org/trunk@27145


git-svn-id: http://core.svn.wordpress.org/trunk@27012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-09 20:28:12 +00:00
Andrew Nacin 70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository.
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 02:29:52 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Ryan Boren b87d4b77e5 Pinking shears
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:38:10 +00:00
Andrew Nacin 74092c3960 Correct @since in admin-footer. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25288


git-svn-id: http://core.svn.wordpress.org/trunk@25252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:38:09 +00:00
Andrew Nacin 9fdfa7ef5c Short descriptions for inline docs should end with a period, per the vast majority of core. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25273


git-svn-id: http://core.svn.wordpress.org/trunk@25239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 01:38:09 +00:00
Andrew Nacin 5a1109b40b Hook docs for admin-footer.php.
props natejacobs.
see #25229.

Built from https://develop.svn.wordpress.org/trunk@25252


git-svn-id: http://core.svn.wordpress.org/trunk@25220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 16:21:09 +00:00
Andrew Nacin 290d479e79 Rename div#footer to div#wpfooter in the admin. Namespace one of our major elements and avoid clashing with widgets with the id of 'footer'. props andrewryno, koopersmith. see #14466.
git-svn-id: http://core.svn.wordpress.org/trunk@21878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 23:03:35 +00:00
nacin 7c9d817511 Improve code readability and execution in admin-footer by removing a now-unnecessary implode(). props TobiasBg, fixes #21422.
git-svn-id: http://core.svn.wordpress.org/trunk@21366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-30 19:37:51 +00:00
koopersmith dcf34868ed Revise admin bar items based on user testing. Post at http://wp.me/pbNCB-qz. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 18:45:32 +00:00
nacin 4adc74c379 Update Feedback support URL.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-30 05:26:40 +00:00
nbachiyski 51e91e68c3 Exclude link tags from internationalized strings in Credits and Freedoms links in the admin footer
git-svn-id: http://svn.automattic.com/wordpress/trunk@18529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-11 04:33:22 +00:00
westi 866b39c617 Move the in_admin_footer action out of p#footer-left.alignleft so it is just in div#footer to allow for it to be used more flexibly. Fixes #17358 props aaroncampbell.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-05 12:04:19 +00:00
nacin 54f42be38d Switch to 'Freedoms'. see #17383.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 05:17:28 +00:00
nacin d130158fa5 Make the footer text code a bit easier to read. see #17383, #17384.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 01:45:42 +00:00
nacin 2e98bd9563 s/Your Rights/Rights/ in the footer. see #17383.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 01:41:34 +00:00
nacin aa12c37960 Credits page. see #17384.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 01:36:05 +00:00
nacin 7f13fe523d Add 'Your Rights' screen to the admin. props matt, jane, ryan, markjaquith, westi. see #17383.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 01:10:54 +00:00
koopersmith 29ca82dba7 Fix footer whitespace/clearing issues, support two-line footer for low widths. see #17324.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-11 20:27:59 +00:00
markjaquith 8d87f5dcb4 Big UI style update. props koopersmith. see #17324
git-svn-id: http://svn.automattic.com/wordpress/trunk@17800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 20:15:05 +00:00
dd32 84887d6386 Remove dead browse happy code. Has not been used for 18months in core admin. Props ocean90. Fixes #4833
git-svn-id: http://svn.automattic.com/wordpress/trunk@14233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-25 08:40:37 +00:00
nacin 4c1b910030 First pass on network.php improvements. see #12094
git-svn-id: http://svn.automattic.com/wordpress/trunk@13571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-03 07:43:32 +00:00
azaozz 4105845402 Stop direct loading of files in wp-admin that should only be included, for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@11768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-03 00:04:45 +00:00
ryan e8b025b971 Check if get_site_option() is defined. It isn't when auto upgrading from <= 2.7.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-16 05:05:11 +00:00
markjaquith b5d4fae306 New admin_footer_text filter. props JohnLamansky. fixes #9552
git-svn-id: http://svn.automattic.com/wordpress/trunk@10976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-17 03:17:40 +00:00
ryan 4290916159 Make can_compress_scripts a site option. Add site option wrappers for WP.
git-svn-id: http://svn.automattic.com/wordpress/trunk@10593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-02-18 23:38:11 +00:00
azaozz 3f7facfbe6 Add action hook in admin footer so plugins can output scripts there on specific pages only, props GamerZ, fixes #8859
git-svn-id: http://svn.automattic.com/wordpress/trunk@10362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-15 00:08:20 +00:00
azaozz fc7d871678 Split the script queue in head and footer part, concatenate and compress the default js and css, first run, see #8628
git-svn-id: http://svn.automattic.com/wordpress/trunk@10357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-14 14:18:51 +00:00
azaozz ac1ccbba3a CSS cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@9964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-29 15:52:17 +00:00
azaozz 375aa1f81c Hide actions in management tables, show on hover; improve comments table; fix "Configure" link position on dashboard, fixes #8386
git-svn-id: http://svn.automattic.com/wordpress/trunk@9934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-28 04:33:35 +00:00
azaozz 0b17615051 Fix #favorite-actions position in IE7, footer position, horizontal scrollbar and expansion of postboxes in IE7, put back Browse Happy, fixes #8280
git-svn-id: http://svn.automattic.com/wordpress/trunk@9852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-24 00:20:34 +00:00
westi b55b7a2ccf Format the clear DIVs properly. Fixes #8294 props sivel.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-21 17:55:35 +00:00
azaozz 36ebfb1ada Several small fixes: edit-category-form, admin-footer, plugins
git-svn-id: http://svn.automattic.com/wordpress/trunk@9538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-05 22:52:59 +00:00
markjaquith fd24df7b4a Implement admin footer with margin, not height, so that people can add stuff to it.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-29 03:51:16 +00:00