Scott Taylor
e41e38183d
In `customize.php`, check that `$autofocus` is an `array` after running `wp_unslash()` instead of before. This is admittedly to skip a traversable hint in Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30164
git-svn-id: http://core.svn.wordpress.org/trunk@30164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:17:22 +00:00
Scott Taylor
106da1e9e6
In `WP_Meta_Query->get_sql_for_clause()`, the empty initialization of `$where` is dead code and can be removed.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30163
git-svn-id: http://core.svn.wordpress.org/trunk@30163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:03:22 +00:00
Scott Taylor
fbd6efdfb8
In `_wp_json_convert_string()`, when `$use_mb` is `false`, perhaps pass a variable that actually exists to `wp_check_invalid_utf8()`.
...
Introduced in [30055].
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30162
git-svn-id: http://core.svn.wordpress.org/trunk@30162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:00:24 +00:00
Scott Taylor
cd9bb04981
In `gallery_shortcode()`, when the `link` attribute is equal to `file`, make sure to pass `$attr` as the 6th (!) argument, not 5th, to `wp_get_attachment_link()`.
...
Props bradyvercher.
Fixes #27402 .
Built from https://develop.svn.wordpress.org/trunk@30161
git-svn-id: http://core.svn.wordpress.org/trunk@30161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 21:47:24 +00:00
Scott Taylor
382d93ddf9
Remove failing unit test after [30090].
...
Fixes #30194 .
Built from https://develop.svn.wordpress.org/trunk@30160
git-svn-id: http://core.svn.wordpress.org/trunk@30160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 21:11:22 +00:00
Scott Taylor
878d074e84
Allow `get_pages()`, with `child_of` passed to it, to work with interrupted hierarchies.
...
Adds unit test.
Fixes #18962 .
Built from https://develop.svn.wordpress.org/trunk@30159
git-svn-id: http://core.svn.wordpress.org/trunk@30159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:44:21 +00:00
Scott Taylor
d5e4583475
All duplicate slugs across different post types.
...
Adds unit test.
Props mboynes, nacin.
Fixes #18962 .
Built from https://develop.svn.wordpress.org/trunk@30158
git-svn-id: http://core.svn.wordpress.org/trunk@30158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:37:24 +00:00
Scott Taylor
849a993269
Check `$_current_page` before using it in `Walker_Page->start_el()`.
...
Props jeremyfelt.
Fixes #26901 .
Built from https://develop.svn.wordpress.org/trunk@30157
git-svn-id: http://core.svn.wordpress.org/trunk@30157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:29:22 +00:00
Scott Taylor
60b73c589c
Display error message when Media Library upload fails.
...
Props gcorne.
Fixes #29891 .
Built from https://develop.svn.wordpress.org/trunk@30156
git-svn-id: http://core.svn.wordpress.org/trunk@30156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:25:23 +00:00
Scott Taylor
be08f576df
Improve some `post_status`-related documentation.
...
Props ericlewis.
See #30230 .
Built from https://develop.svn.wordpress.org/trunk@30155
git-svn-id: http://core.svn.wordpress.org/trunk@30155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:20:23 +00:00
Scott Taylor
0b9c1be743
In `WP_List_Table`, add a property, `$modes`, to allow `WP_Media_List_Table` to inherit `->view_switcher()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30154
git-svn-id: http://core.svn.wordpress.org/trunk@30154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 19:56:24 +00:00
Scott Taylor
be707cd614
In `wp_xmlrpc_server` methods, for comprehensibility:
...
* initialize arrays in loops, instead of overriding an uninitialized array each time
* in `->blogger_getRecentPosts()` and `->mw_getRecentPosts()`, remove the extra loops by only setting one `array`
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30153
git-svn-id: http://core.svn.wordpress.org/trunk@30153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 19:45:25 +00:00
Jeremy Felt
0ba8ceb6ea
Split tests for is_main_site()
...
Break multiple assertions from one method into multiple methods with one assertion each.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30152
git-svn-id: http://core.svn.wordpress.org/trunk@30152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 05:18:22 +00:00
Jeremy Felt
8785f07ee1
Expand and clarify tests for get_blog_post()
...
Remove unnecessary user factory use. Be explicit about test scenarios.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30151
git-svn-id: http://core.svn.wordpress.org/trunk@30151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:47:22 +00:00
Drew Jaynes
09a1f68f07
Fix a couple of spacing and wrapping indents in the `WP_Date_Query::__construct()` hash notation.
...
See [30142]. See #28063 .
Built from https://develop.svn.wordpress.org/trunk@30150
git-svn-id: http://core.svn.wordpress.org/trunk@30150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:31:22 +00:00
Drew Jaynes
a929ac44e1
Relocate hook docs so they directly precede the hook lines moved into foreach statements in [30140].
...
It's necessary for hook docs to directly precede hook lines so the parser can correctly match them up. This change relocates hook docs for `update_{$meta_type}_meta`, `update_postmeta`, `updated_{$meta_type}_meta`, and `updated_postmeta`.
Fixes #11683 .
Built from https://develop.svn.wordpress.org/trunk@30149
git-svn-id: http://core.svn.wordpress.org/trunk@30149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:18:23 +00:00
Boone Gorges
8b18debcd0
Clean up 'post-thumbnail' theme support unit tests.
...
* Separate into smaller test methods.
* Remove incorrect tests. A number of assertions in the existing test have always incorrectly described the behavior of `current_theme_supports( 'post-thumbnails' )`, but no one ever noticed because the tests had been designed to bail when `_wp_render_title_tag()` did not exist. The failures finally became visible when that function was introduced in [30074].
See #18548 .
Built from https://develop.svn.wordpress.org/trunk@30148
git-svn-id: http://core.svn.wordpress.org/trunk@30148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:01:21 +00:00
Lance Willett
df455aa106
Twenty Fourteen: update table styles in editor CSS file for new TinyMCE class names.
...
Props slobodanmanic, fixes #28703 .
Built from https://develop.svn.wordpress.org/trunk@30147
git-svn-id: http://core.svn.wordpress.org/trunk@30147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:47:21 +00:00
Lance Willett
c604fd15b0
Twenty Fourteen: fix keyboard focus on Appearance > Header view.
...
Props florianziegler, fixes #29787 .
Built from https://develop.svn.wordpress.org/trunk@30146
git-svn-id: http://core.svn.wordpress.org/trunk@30146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:44:23 +00:00
Lance Willett
609335eef1
Twenty Ten and Eleven: don't display modified excerpt link in wp-admin.
...
Props kraftbj, fixes #30026 .
Built from https://develop.svn.wordpress.org/trunk@30145
git-svn-id: http://core.svn.wordpress.org/trunk@30145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:40:25 +00:00
Boone Gorges
c07582cb64
Improve default argument formatting in `WP_Date_Query::__construct()`.
...
Built from https://develop.svn.wordpress.org/trunk@30144
git-svn-id: http://core.svn.wordpress.org/trunk@30144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:29:21 +00:00
Lance Willett
6ddbf3c8bd
Twenty Fourteen: Make featured content in Customizer contextual to the front page.
...
Props celloexpressions, fixes #29578 .
Built from https://develop.svn.wordpress.org/trunk@30143
git-svn-id: http://core.svn.wordpress.org/trunk@30143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:26:21 +00:00
Boone Gorges
92536aae65
Introduced `dayofweek_iso` time param for `WP_Date_Query`.
...
The initial `dayofweek` param sets day 1 to Sunday. This is out of step with
ISO standards, which calls Monday day 1. To maintain backward compatibility
with the existing parameter, we introduce the new `dayofweek_iso` for the
new, more compliant param.
Props mboynes.
Fixes #28063 .
Built from https://develop.svn.wordpress.org/trunk@30142
git-svn-id: http://core.svn.wordpress.org/trunk@30142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:24:21 +00:00
Boone Gorges
96b42c2fdc
Allow resource_type to be specified in `get_ancestors()`.
...
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.
Props filosofo.
Fixes #15029 .
Built from https://develop.svn.wordpress.org/trunk@30141
git-svn-id: http://core.svn.wordpress.org/trunk@30141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 02:58:23 +00:00
Boone Gorges
c27548265e
Pass all updated meta IDs to filters in `update_metadata()`.
...
Props wonderboymusic.
Fixes #11683 .
Built from https://develop.svn.wordpress.org/trunk@30140
git-svn-id: http://core.svn.wordpress.org/trunk@30140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 02:39:24 +00:00
Scott Taylor
65ab0a188e
In `wp_xmlrpc_server->pingback_ping()`, remove the internal variable `$way` each time it is set and not used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30139
git-svn-id: http://core.svn.wordpress.org/trunk@30139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:50:21 +00:00
Scott Taylor
4f6745e9aa
In `wp_xmlrpc_server` methods, don't set `$blog_id` internally if it is never used, which is almost always. Updates the docs.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30138
git-svn-id: http://core.svn.wordpress.org/trunk@30138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:44:23 +00:00
Scott Taylor
0d3270282d
In `wp_xmlrpc_server->_prepare_comment()`, `$comment_date` is set internally but never used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30137
git-svn-id: http://core.svn.wordpress.org/trunk@30137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:29:24 +00:00
Scott Taylor
fcbc7b5a78
In `Custom_Image_Header->step_2()`, `$type` is set internally but never used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30136
git-svn-id: http://core.svn.wordpress.org/trunk@30136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:24:22 +00:00
Scott Taylor
02f3c92b39
Fix failing unit tests after [30096]: use `assertEqualSets()`.
...
Built from https://develop.svn.wordpress.org/trunk@30135
git-svn-id: http://core.svn.wordpress.org/trunk@30135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:11:44 +00:00
Boone Gorges
e9f6ee53bb
Fix database schema update introduced in [30121].
...
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.
Fixes #22023 .
Built from https://develop.svn.wordpress.org/trunk@30134
git-svn-id: http://core.svn.wordpress.org/trunk@30134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:11:22 +00:00
Scott Taylor
8d0e8942eb
[28785] introduced a bug, where encoded query arguments were decoded by `parse_str()` inside of `wp_parse_str()` but never re-encoded later on.
...
This encodes them, adds unit test.
Props obenland.
Fixes #29636 .
Built from https://develop.svn.wordpress.org/trunk@30133
git-svn-id: http://core.svn.wordpress.org/trunk@30133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:54:23 +00:00
Scott Taylor
c19b3d1740
Fix unit test for video shortcode after [30082].
...
Fixes #30078 .
Built from https://develop.svn.wordpress.org/trunk@30132
git-svn-id: http://core.svn.wordpress.org/trunk@30132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:49:21 +00:00
Scott Taylor
29deacc30c
Revisions modules should not rely on global settings:
...
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax
Props ericlewis, wonderboymusic.
Fixes #30219 .
Built from https://develop.svn.wordpress.org/trunk@30131
git-svn-id: http://core.svn.wordpress.org/trunk@30131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:39:24 +00:00
Scott Taylor
d1d93b7cda
Set `revision.settings` via short-circuit check for `window` property: `window._wpRevisionsSettings || {}`
...
Props ericlewis.
Fixes #30218 .
Built from https://develop.svn.wordpress.org/trunk@30130
git-svn-id: http://core.svn.wordpress.org/trunk@30130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:20:22 +00:00
Scott Taylor
a4963672d6
Add a single responsibility function for outputting Revisions JS templates: `wp_print_revision_templates()`.
...
Use it in `wp-admin/revision.php`.
Props ericlewis.
Fixes #30220 .
Built from https://develop.svn.wordpress.org/trunk@30129
git-svn-id: http://core.svn.wordpress.org/trunk@30129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:15:24 +00:00
Scott Taylor
7cbb7552da
Allow revision Backbone classes to be used on pages other than `revision.php`.
...
Props ericlewis.
Fixes #30221 .
Built from https://develop.svn.wordpress.org/trunk@30128
git-svn-id: http://core.svn.wordpress.org/trunk@30128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:08:21 +00:00
Scott Taylor
f1634f7c8f
Add some JSDoc blocks to `revisions.js`.
...
Props ericlewis.
See #30222 .
Built from https://develop.svn.wordpress.org/trunk@30127
git-svn-id: http://core.svn.wordpress.org/trunk@30127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 23:55:22 +00:00
Dominik Schilling
461507452a
Customizer: Improve `ColorControl`'s `wpColorPicker` to update UI based on setting changes.
...
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.
props westonruter.
fixes #30031 .
Built from https://develop.svn.wordpress.org/trunk@30126
git-svn-id: http://core.svn.wordpress.org/trunk@30126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:45:22 +00:00
Scott Taylor
7eefc4d1e1
JSHint after [30124].
...
Built from https://develop.svn.wordpress.org/trunk@30125
git-svn-id: http://core.svn.wordpress.org/trunk@30125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:38:21 +00:00
Scott Taylor
a6cb067481
JSHint after [30120].
...
Built from https://develop.svn.wordpress.org/trunk@30124
git-svn-id: http://core.svn.wordpress.org/trunk@30124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:35:22 +00:00
Dominik Schilling
2e76a697f6
Fix JSHint errors introduced in [30120].
...
see #30193 .
Built from https://develop.svn.wordpress.org/trunk@30123
git-svn-id: http://core.svn.wordpress.org/trunk@30123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:28:24 +00:00
Drew Jaynes
66c47f29bb
Correct references of `@uses $wpdb` in core documentation to use `@global`.
...
See #30191 , [30105].
Fixes #30217 .
Built from https://develop.svn.wordpress.org/trunk@30122
git-svn-id: http://core.svn.wordpress.org/trunk@30122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 17:56:22 +00:00
Boone Gorges
70631df84a
Bump db_version and add upgrade routine for schema change in [30056].
...
Fixes #22023 .
Built from https://develop.svn.wordpress.org/trunk@30121
git-svn-id: http://core.svn.wordpress.org/trunk@30121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 16:03:22 +00:00
Scott Taylor
999e0fbd99
Add verbose docs to `media-views.js`.
...
Props ericlewis.
See #30193 .
Built from https://develop.svn.wordpress.org/trunk@30120
git-svn-id: http://core.svn.wordpress.org/trunk@30120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 15:20:23 +00:00
Drew Jaynes
e8f68802c6
Correct two parameter types in the `wp_save_post_revision_check_for_changes` hook documentation.
...
Props johnbillion.
Fixes #30185 .
Built from https://develop.svn.wordpress.org/trunk@30119
git-svn-id: http://core.svn.wordpress.org/trunk@30119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 23:50:22 +00:00
Boone Gorges
6745b8a870
Move `term_exists()` tests to their own file.
...
Built from https://develop.svn.wordpress.org/trunk@30118
git-svn-id: http://core.svn.wordpress.org/trunk@30118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:53:22 +00:00
Sergey Biryukov
94fa6e1615
Use correct file name in a hook comment.
...
props wedi.
fixes #30200 .
Built from https://develop.svn.wordpress.org/trunk@30117
git-svn-id: http://core.svn.wordpress.org/trunk@30117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:35:28 +00:00
Sergey Biryukov
b823b2f3c1
Twenty Fifteen: Change version compare string to '4.1-alpha' to avoid an error for alpha and beta testers during development.
...
fixes #30137 .
Built from https://develop.svn.wordpress.org/trunk@30116
git-svn-id: http://core.svn.wordpress.org/trunk@30116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 11:57:22 +00:00
Boone Gorges
93ae51e801
Unserialize `get_metadata()` results when 'key' is omitted.
...
Props mattkeys, nacin.
Fixes #15030 .
Built from https://develop.svn.wordpress.org/trunk@30115
git-svn-id: http://core.svn.wordpress.org/trunk@30115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 10:25:22 +00:00