Andrea Fercia
340fd28d82
Accessibility: Improve focus management in the Media Views.
...
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()
Fixes #43169 .
Built from https://develop.svn.wordpress.org/trunk@45524
git-svn-id: http://core.svn.wordpress.org/trunk@45335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 21:03:52 +00:00
Andrea Fercia
9f579ea448
Administration: Improve the horizontal centering of the Site Health tabs.
...
Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
Fixes #46881 .
Built from https://develop.svn.wordpress.org/trunk@45522
git-svn-id: http://core.svn.wordpress.org/trunk@45333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:31:52 +00:00
Andrea Fercia
9f7f9d2d89
Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position.
...
Fixes #45094 .
Built from https://develop.svn.wordpress.org/trunk@45520
git-svn-id: http://core.svn.wordpress.org/trunk@45331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:21:54 +00:00
Andrew Ozz
d0c1b77cda
Privacy tools:
...
- Move the (remaining) privacy tools related functions from `wp-admin/includes/file.php` to `wp-admin/includes/privacy-tools.php`.
- Move the `WP_User_Request` class to a separate file.
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45519
git-svn-id: http://core.svn.wordpress.org/trunk@45330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 23:54:53 +00:00
Sergey Biryukov
3b69e493f6
I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page.
...
Props pedromendonca, garrett-eclipse.
Fixes #47475 .
Built from https://develop.svn.wordpress.org/trunk@45515
git-svn-id: http://core.svn.wordpress.org/trunk@45326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 14:14:51 +00:00
Peter Wilson
a5e57d7245
Site health: Introduce `view_site_health_checks` capability.
...
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.
The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.
The capability is granted on the `user_has_cap` filter.
Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Fixes #46957 .
Built from https://develop.svn.wordpress.org/trunk@45507
git-svn-id: http://core.svn.wordpress.org/trunk@45318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 07:42:52 +00:00
John Blackbourn
c9b51df3d0
I18N: Allow the length of automatically generated excerpts to be localized.
...
This introduces three new strings that can be used to control the maximum length of automatically generated excerpts for posts, comments, and draft post previews in the dashboard. Optionally combined with the existing word count type control this allows languages which include many multibyte characters to specify more appropriate maximum excerpt lengths.
Props miyauchi, birgire, johnbillion
Fixes #44541
Built from https://develop.svn.wordpress.org/trunk@45505
git-svn-id: http://core.svn.wordpress.org/trunk@45316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 18:42:52 +00:00
Andrea Fercia
935c35fe34
Accessibility: Improve the Screen Options and Help buttons order.
...
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]
Props vrimill, mukesh27 for reporting and testing.
Fixes #45094 .
Built from https://develop.svn.wordpress.org/trunk@45503
git-svn-id: http://core.svn.wordpress.org/trunk@45314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:31:53 +00:00
Andrea Fercia
be14c6e5c6
Administration: Improve the Screen Options and Help buttons focus style after [45501].
...
Amends [45501].
See #46749 .
Built from https://develop.svn.wordpress.org/trunk@45502
git-svn-id: http://core.svn.wordpress.org/trunk@45313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:07:52 +00:00
Andrea Fercia
17034e2a4e
Administration: Remove extra border from the Screen Options and Help buttons.
...
The extra border was visible in the responsive view for smaller screens after [32844].
Props jitendrabanjara1991.
Fixes #46749 .
Built from https://develop.svn.wordpress.org/trunk@45501
git-svn-id: http://core.svn.wordpress.org/trunk@45312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 14:50:52 +00:00
Andrew Ozz
7cee029897
Privacy tools: remove some left-over code and fix inline comment.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45500
git-svn-id: http://core.svn.wordpress.org/trunk@45311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 00:30:51 +00:00
Andrea Fercia
6a9bcaeaa9
Accessibility: Improve accessibility of all the media views form controls.
...
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8
Fixes #47141 .
Fixes #47122 .
Built from https://develop.svn.wordpress.org/trunk@45499
git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:45:02 +00:00
Andrea Fercia
d5333b9593
Fix the media player controls bar width in the media views.
...
Props vaishalipanchal, chetan200891.
Fixes #47457 .
Built from https://develop.svn.wordpress.org/trunk@45497
git-svn-id: http://core.svn.wordpress.org/trunk@45308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 13:29:52 +00:00
Sergey Biryukov
baa2cd69b8
Media: Restore correct arrow direction in RTL in Attachment Details modal.
...
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.
Props ramiy, SergeyBiryukov.
Fixes #46289 .
Built from https://develop.svn.wordpress.org/trunk@45495
git-svn-id: http://core.svn.wordpress.org/trunk@45306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 01:25:52 +00:00
desrosj
4c0620bdf8
Privacy: Remove inline CSS within personal data request list tables.
...
The `.hidden` class can be used to show and hide UI elements instead.
Props birgire, pratikthink, garrett-eclipse.
Fixes #44839 .
Built from https://develop.svn.wordpress.org/trunk@45490
git-svn-id: http://core.svn.wordpress.org/trunk@45301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-04 23:40:55 +00:00
Sergey Biryukov
32d761ce7d
I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.
...
Props ramiy.
Fixes #47227 .
Built from https://develop.svn.wordpress.org/trunk@45488
git-svn-id: http://core.svn.wordpress.org/trunk@45299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-01 22:10:52 +00:00
Sergey Biryukov
13da094c39
Upgrade/Install: Correct operator precedence for an error code in `WP_Ajax_Upgrader_Skin::error()`.
...
Props jrf.
Fixes #47441 .
Built from https://develop.svn.wordpress.org/trunk@45487
git-svn-id: http://core.svn.wordpress.org/trunk@45298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 14:14:52 +00:00
Sergey Biryukov
0d40c54f9b
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/media.css`.
...
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45484
git-svn-id: http://core.svn.wordpress.org/trunk@45295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:45:50 +00:00
Sergey Biryukov
412ffd0aaf
Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place.
...
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.
See #46530 .
Built from https://develop.svn.wordpress.org/trunk@45483
git-svn-id: http://core.svn.wordpress.org/trunk@45294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:40:52 +00:00
desrosj
349d95f27a
Docs: Add missing function documentation for `list_plugin_updates()`.
...
Introduced in [9543].
Props priyankkpatel, mukesh27.
Fixes #47424 .
Built from https://develop.svn.wordpress.org/trunk@45480
git-svn-id: http://core.svn.wordpress.org/trunk@45291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:10:52 +00:00
Sergey Biryukov
fdc6b9583b
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/revisions.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46517 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45468
git-svn-id: http://core.svn.wordpress.org/trunk@45279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:16:52 +00:00
Sergey Biryukov
ca6aa01705
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/list-tables.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46515 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45467
git-svn-id: http://core.svn.wordpress.org/trunk@45278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:15:52 +00:00
Sergey Biryukov
afaeca95cf
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/login.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46514 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45466
git-svn-id: http://core.svn.wordpress.org/trunk@45277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:09:52 +00:00
Sergey Biryukov
1899a99c35
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/install.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46513 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45465
git-svn-id: http://core.svn.wordpress.org/trunk@45276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:53:53 +00:00
Sergey Biryukov
03814826b2
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/forms.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46512 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45464
git-svn-id: http://core.svn.wordpress.org/trunk@45275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:49:53 +00:00
Andrea Fercia
41accccad6
Administration: Improve the Site Health tables layout for small screens.
...
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.
Fixes #46960 .
Built from https://develop.svn.wordpress.org/trunk@45463
git-svn-id: http://core.svn.wordpress.org/trunk@45274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 18:22:51 +00:00
Sergey Biryukov
52d478cb0d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/edit.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46511 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45462
git-svn-id: http://core.svn.wordpress.org/trunk@45273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:05:53 +00:00
Sergey Biryukov
ce25e2f34d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/dashboard.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46510 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45461
git-svn-id: http://core.svn.wordpress.org/trunk@45272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:03:52 +00:00
Sergey Biryukov
9860a4366d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-widgets.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46509 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45460
git-svn-id: http://core.svn.wordpress.org/trunk@45271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:01:53 +00:00
desrosj
bb3c264350
Administration: Add missing filter documentation for Site Health auto update tests.
...
Props johnbillion, mukesh27.
Fixes #47388 .
Built from https://develop.svn.wordpress.org/trunk@45459
git-svn-id: http://core.svn.wordpress.org/trunk@45270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 13:59:51 +00:00
Andrew Ozz
6de52463a7
Script loader: prevent sorting of the `load` array in the query string when passing the script handles to load-scripts.php and load-styles.php.
...
Fixes #45346 #26886 .
Built from https://develop.svn.wordpress.org/trunk@45456
git-svn-id: http://core.svn.wordpress.org/trunk@45267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 02:43:55 +00:00
Sergey Biryukov
51ee349942
Docs: Add a comment about the reinstated `wp-admin/options-privacy.php`.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45454
git-svn-id: http://core.svn.wordpress.org/trunk@45265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 03:03:52 +00:00
Sergey Biryukov
96b4570781
Privacy: Remove reinstated `wp-admin/options-privacy.php` from `$_old_files`.
...
Fix WPCS violations in [45448].
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45453
git-svn-id: http://core.svn.wordpress.org/trunk@45264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 02:40:53 +00:00
Andrew Ozz
2f7f0ad901
Fix typo in [45451] and move the redirect to the proper location.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45452
git-svn-id: http://core.svn.wordpress.org/trunk@45263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 23:21:51 +00:00
Andrew Ozz
cbcccbd5b6
Privacy tools: restore `privacy.php` to its "proper" use to output the Privacy tab on the About screen, see [42814]. Then add the Privacy tab updates from freedoms.php.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45451
git-svn-id: http://core.svn.wordpress.org/trunk@45262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:57:52 +00:00
John Blackbourn
6aab3f2f05
Docs: Improve documentation for some more variadic functions.
...
Fixes #37402
Built from https://develop.svn.wordpress.org/trunk@45450
git-svn-id: http://core.svn.wordpress.org/trunk@45261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:48:51 +00:00
Andrew Ozz
87acdab81d
Privacy tools: Organize privacy functions into logical files and classes.
...
Props xkon, birgire, desrosj, garrett-eclipse, azaozz.
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45448
git-svn-id: http://core.svn.wordpress.org/trunk@45259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 20:50:53 +00:00
Sergey Biryukov
cd9c6ce36e
I18N: Merge duplicate "Add Comment" strings.
...
Props ramiy.
Fixes #47246 .
Built from https://develop.svn.wordpress.org/trunk@45441
git-svn-id: http://core.svn.wordpress.org/trunk@45252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:43:52 +00:00
Sergey Biryukov
dd7956c674
I18N: Use consistent error messages when importing or exporting content.
...
Props ramiy.
Fixes #42269 .
Built from https://develop.svn.wordpress.org/trunk@45440
git-svn-id: http://core.svn.wordpress.org/trunk@45251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:09:52 +00:00
Sergey Biryukov
702f7d4e8d
I18N: Merge duplicate "not allowed to manage options" strings.
...
Props ramiy.
Fixes #42271 .
Built from https://develop.svn.wordpress.org/trunk@45439
git-svn-id: http://core.svn.wordpress.org/trunk@45250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 16:00:52 +00:00
Sergey Biryukov
b97a2d4366
I18N: Merge duplicate "Loading..." strings.
...
Props ramiy.
Fixes #47248 .
Built from https://develop.svn.wordpress.org/trunk@45438
git-svn-id: http://core.svn.wordpress.org/trunk@45249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:46:52 +00:00
Sergey Biryukov
21a12ce6cd
I18N: Merge similar strings in Edit Media help tabs.
...
Props ramiy.
Fixes #46919 .
Built from https://develop.svn.wordpress.org/trunk@45437
git-svn-id: http://core.svn.wordpress.org/trunk@45248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:38:53 +00:00
Sergey Biryukov
9f4c2fcbae
I18N: Merge duplicate "Try Again" strings.
...
Props ramiy.
Fixes #47251 .
Built from https://develop.svn.wordpress.org/trunk@45433
git-svn-id: http://core.svn.wordpress.org/trunk@45244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 14:40:51 +00:00
Sergey Biryukov
6c50f22e4e
I18N: Remove unnecessary markup from plugin action messages, for consistency with the rest of the admin.
...
Props ramiy.
Fixes #47238 .
Built from https://develop.svn.wordpress.org/trunk@45432
git-svn-id: http://core.svn.wordpress.org/trunk@45243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 14:36:51 +00:00
Sergey Biryukov
f5db16738e
Administration: Merge similar "file does not exist" messages in plugin and theme editors.
...
Props ramiy.
Fixes #47249 .
Built from https://develop.svn.wordpress.org/trunk@45431
git-svn-id: http://core.svn.wordpress.org/trunk@45242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 12:35:51 +00:00
Sergey Biryukov
c77e771c84
Date/Time: Replace all instances of `date()` with `gmdate()`.
...
Use of `date()` in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).
`gmdate()` is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.
Props nielsdeblaauw, Rarst.
Fixes #46438 . See #44491 .
Built from https://develop.svn.wordpress.org/trunk@45424
git-svn-id: http://core.svn.wordpress.org/trunk@45235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 00:12:54 +00:00
Andrea Fercia
fc17576fd2
Accessibility: Improve toggling the "Post locked" information visibility.
...
- effectively hides the "Post locked" information from assistive technologies
- when a post is locked, reveals the "Post locked" information without CSS animation
- the height CSS animation didn't work anyways after [24906]
See #24553 .
Fixes #44946 .
Built from https://develop.svn.wordpress.org/trunk@45417
git-svn-id: http://core.svn.wordpress.org/trunk@45228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 17:15:52 +00:00
Andrea Fercia
48d9d94881
Accessibility: Improve settings tables and forms after [45403].
...
- adds `role="presentation"` to the edit comment table
- removes a few pointless `<fieldset>` elements
- adds a few missing `<label>` elements
- adds the CSS class `class="td-full"` to table rows spanning to multiple cells
- adds explicit `scope="row"` attribute to the table headers in `options-permalink.php`: this table is better communicated as data table
- uses consistent label association in the "Privacy Settings" page
- in the installation page "Set up your database connection": associates descriptions to their inout fields using `aria-describedby`
- improves the link to gravatar.com in the `user-edit.php` page
See #46899 .
Fixes #47390 .
Built from https://develop.svn.wordpress.org/trunk@45416
git-svn-id: http://core.svn.wordpress.org/trunk@45227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 15:19:53 +00:00
Sergey Biryukov
00c60ccd33
CSS Coding Standards: Update unitless values for `line-height` in `wp-admin/css/widgets.css` with more precise calculations.
...
Props ianbelanger.
Fixes #46531 .
Built from https://develop.svn.wordpress.org/trunk@45415
git-svn-id: http://core.svn.wordpress.org/trunk@45226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:44:52 +00:00
Sergey Biryukov
962da3db60
CSS Coding Standards: Update unitless values for `line-height` in `wp-admin/css/nav-menus.css` with more precise calculations.
...
Props ianbelanger.
Fixes #46516 .
Built from https://develop.svn.wordpress.org/trunk@45414
git-svn-id: http://core.svn.wordpress.org/trunk@45225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:42:52 +00:00