Commit Graph

32139 Commits

Author SHA1 Message Date
Boone Gorges 7de3499949 In `get_terms()`, don't store `WP_Term` objects in cache.
Fixes #34282.
Built from https://develop.svn.wordpress.org/trunk@35117


git-svn-id: http://core.svn.wordpress.org/trunk@35082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:58:24 +00:00
Scott Taylor fc842e33c9 Users: when passing a `WP_User` instance to `wp_update_user()`, ensure that the user password is not accidentally double-hashed. This is terrifying.
Adds unit tests.

Props tbcorr, salcode.
Fixes #28435.

Built from https://develop.svn.wordpress.org/trunk@35116


git-svn-id: http://core.svn.wordpress.org/trunk@35081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:48:24 +00:00
Sergey Biryukov c332da3e12 Feeds: Pass the feed name to `do_feed_{$feed}` action.
Props johnbillion.
See #34259.
Built from https://develop.svn.wordpress.org/trunk@35115


git-svn-id: http://core.svn.wordpress.org/trunk@35080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:44:23 +00:00
Scott Taylor c9babc4cdd Users: allow `-1` (no limit, use with extreme caution on large sites) as the value for `number` in `WP_User_Query` - similar to `posts_per_page => -1` in `WP_Query`.
Adds unit tests.

Props mordauk, jesin, nofearinc.
Fixes #28631.

Built from https://develop.svn.wordpress.org/trunk@35114


git-svn-id: http://core.svn.wordpress.org/trunk@35079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:40:24 +00:00
Scott Taylor 5bb40ab27d Widgets: after [35106], ensure that the widget required by the unit test is registered.
See #19450.

Built from https://develop.svn.wordpress.org/trunk@35113


git-svn-id: http://core.svn.wordpress.org/trunk@35078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:37:12 +00:00
Boone Gorges bec9315360 In term meta lazy-loading tests, force `WP_Query` to cache results.
By default, `WP_Query` will not cache query results when using a persistent
object cache. The lazyload tests, however, depend on the cache being set during
each `WP_Query`, because the object cache is cleared between tests.

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35112


git-svn-id: http://core.svn.wordpress.org/trunk@35077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:36:48 +00:00
Boone Gorges 07b7e7b3c7 Remove dead code from `WP_Query::lazyload_term_meta()`.
Built from https://develop.svn.wordpress.org/trunk@35111


git-svn-id: http://core.svn.wordpress.org/trunk@35076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:36:25 +00:00
Sergey Biryukov 2c12662eff Remove obsolete code from `WP_Users_List_Table::get_sortable_columns().
Sorting by post count was disabled in [17024].

Props jdgrimes.
See #15861.
Built from https://develop.svn.wordpress.org/trunk@35110


git-svn-id: http://core.svn.wordpress.org/trunk@35075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:25:25 +00:00
Sergey Biryukov 319d0e8bf0 Replace `get_bloginfo( 'wpurl' )` with `admin_url()` for plugin activation error message.
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
Fixes #34280.
Built from https://develop.svn.wordpress.org/trunk@35109


git-svn-id: http://core.svn.wordpress.org/trunk@35074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:12:24 +00:00
Boone Gorges 5d07f8eb46 In cache tests, determine cache class name dynamically.
Some cache backends may use a class name other than `WP_Object_Cache` for their
cache drop-in. For example, certain versions of the APC Object Cache plugin
have a shim called `APC_Object_Cache`.

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35108


git-svn-id: http://core.svn.wordpress.org/trunk@35073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:07:25 +00:00
Sergey Biryukov 34732f5a80 Replace `get_bloginfo( 'wpurl' )` with `admin_url()` in plugin editor.
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
See #34280.
Built from https://develop.svn.wordpress.org/trunk@35107


git-svn-id: http://core.svn.wordpress.org/trunk@35072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:05:24 +00:00
Scott Taylor 05cd8a447e Widgets: When using `the_widget()`, the `$before_widget` argument only receives the widget class if using the default sidebar arguments. Run `sprintf` after parsing the args to fix this.
Adds unit test.

Props coffee2code.
Fixes #19450.

Built from https://develop.svn.wordpress.org/trunk@35106


git-svn-id: http://core.svn.wordpress.org/trunk@35071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:49:48 +00:00
Sergey Biryukov 426944c744 Replace `get_bloginfo( 'wpurl' )` with `site_url()` in `rsd_link()`.
Ensure the correct scheme is used for the `application/rsd+xml` link URL.

Props johnbillion.
See #34280.
Built from https://develop.svn.wordpress.org/trunk@35105


git-svn-id: http://core.svn.wordpress.org/trunk@35070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:49:26 +00:00
Drew Jaynes 649382a7f1 Widgets: Rename the `$name` parameter in `is_registered_sidebar()` to `$sidebar_id` and adjust the accepted types to `string|int` as sidebar IDs can be numeric.
See #24878.

Built from https://develop.svn.wordpress.org/trunk@35104


git-svn-id: http://core.svn.wordpress.org/trunk@35069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:45:25 +00:00
Scott Taylor 2e6865a7fb Widgets: add a default filter for `widget_text` (used by the Text widget), `balanceTags`, which respects the option for `use_balanceTags`.
Props MikeHansenMe.
Fixes #23083.

Built from https://develop.svn.wordpress.org/trunk@35103


git-svn-id: http://core.svn.wordpress.org/trunk@35068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:40:26 +00:00
Scott Taylor aa92c9555a Widgets: add a function, `is_registered_sidebar()` - helps us avoid touching the `$wp_registered_sidebars` global.
Props GaryJ, wonderboymusic.
Fixes #24878.

Built from https://develop.svn.wordpress.org/trunk@35102


git-svn-id: http://core.svn.wordpress.org/trunk@35067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:33:25 +00:00
Boone Gorges ff0b621719 Don't match partial roles in `WP_User_Query`.
Because 'role=ocean90' shouldn't match 'role=bocean901'.

Props bocean901, ocean90.
Fixes #22212.
Built from https://develop.svn.wordpress.org/trunk@35101


git-svn-id: http://core.svn.wordpress.org/trunk@35066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:32:25 +00:00
Scott Taylor e7c2544a89 Widgets: when getting settings, and none exist, set them to empty to avoid extraneous database queries on subsequent requests.
Adds unit tests.

Props kovshenin, MikeHansenMe, dlh.
Fixes #26876.

Built from https://develop.svn.wordpress.org/trunk@35100


git-svn-id: http://core.svn.wordpress.org/trunk@35065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:13:24 +00:00
Scott Taylor a31d7e37dc Color Picker: when opening and closing, toggle a `wp-picker-active` class on the wrapper.
Props norcross.
Fixes #29471.

Built from https://develop.svn.wordpress.org/trunk@35099


git-svn-id: http://core.svn.wordpress.org/trunk@35064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:08:25 +00:00
Drew Jaynes 48811702cd Feeds: Simplify logic for checking if the `do_feed_{$feed}` action is hooked to any callbacks.
See [35097] for where the aforementioned hook was renamed to actually be dynamic, thus rendering creation of the extra `$hook` variable moot.

See #34264.

Built from https://develop.svn.wordpress.org/trunk@35098


git-svn-id: http://core.svn.wordpress.org/trunk@35063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:07:25 +00:00
Drew Jaynes b234b5d896 Feeds: Adjust the `do_feed_{$feed}` hook name to actually be dynamic, rather than pre-storing the tag name in a variable and referencing that.
Props johnbillion.
Fixes #34264.

Built from https://develop.svn.wordpress.org/trunk@35097


git-svn-id: http://core.svn.wordpress.org/trunk@35062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:03:25 +00:00
Sergey Biryukov b30dcc3f62 Format the number of comments in `wp-includes/embed-template.php` for the locale.
Props johnbillion.
Fixes #34276.
Built from https://develop.svn.wordpress.org/trunk@35096


git-svn-id: http://core.svn.wordpress.org/trunk@35061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:02:25 +00:00
Scott Taylor 8941648ead XML-RPC: Add a filter, `xmlrpc_memory_limit`, to allow the value of `$xmlrpc_memory_limit` to be increased.
Props ankit.gade.
Fixes #29957.

Built from https://develop.svn.wordpress.org/trunk@35095


git-svn-id: http://core.svn.wordpress.org/trunk@35060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:01:24 +00:00
Drew Jaynes bcc7f8d079 Plugins: Introduce the `delete_plugin` transactional hook, which fires immediately after a plugin deletion attempt occurs.
Props Veraxus for the initial patch.
Fixes #26904.

Built from https://develop.svn.wordpress.org/trunk@35094


git-svn-id: http://core.svn.wordpress.org/trunk@35059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 00:57:25 +00:00
Drew Jaynes ad6a1303dc Login: Pass the username and `WP_User` object to the `retrieve_password_title` filter.
Adding these parameters creates parity with the `retrieve_password_message` filter, used for modifying the message body of the same password reset email.

Props sudar.
Fixes #34252.

Built from https://develop.svn.wordpress.org/trunk@35093


git-svn-id: http://core.svn.wordpress.org/trunk@35058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 00:51:24 +00:00
Sergey Biryukov 7ef095171a In `number_format_i18n()`, check if `$wp_locale` is set before using it.
Props pauldewouters.
Fixes #31553.
Built from https://develop.svn.wordpress.org/trunk@35092


git-svn-id: http://core.svn.wordpress.org/trunk@35057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 00:30:24 +00:00
Sergey Biryukov e6987f3c31 Correct the `post_date` format in `WP_Date_Query` tests.
It should be `'Y-m-d H:i:s'` in order to match the regex in `get_gmt_from_date()` if `'timezone_string'` option is not set.

Props pbearne.
Fixes #34277.
Built from https://develop.svn.wordpress.org/trunk@35091


git-svn-id: http://core.svn.wordpress.org/trunk@35056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 23:40:24 +00:00
John Blackbourn 00388a1dbf Add missing `@since` params and update the docs for `site_icon_url()` and `has_site_icon()`.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35090


git-svn-id: http://core.svn.wordpress.org/trunk@35055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 23:28:24 +00:00
John Blackbourn 76b77ff4d1 Remove another unnecessary `function_exists()` call.
See [35087]
See #32522

Built from https://develop.svn.wordpress.org/trunk@35089


git-svn-id: http://core.svn.wordpress.org/trunk@35054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 23:20:24 +00:00
Drew Jaynes cffce78d35 Version bump.
Built from https://develop.svn.wordpress.org/trunk@35088


git-svn-id: http://core.svn.wordpress.org/trunk@35053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 22:59:25 +00:00
John Blackbourn 993d5c1c4b Remove an unnecessary `function_exists()` call which was included in the oEmbed feature plugin for compatibility with WordPress < 4.3.
See #32522

Built from https://develop.svn.wordpress.org/trunk@35087


git-svn-id: http://core.svn.wordpress.org/trunk@35052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 22:54:24 +00:00
John Blackbourn 1a04fde012 Correct two escaping functions used in `wp-includes/embed-template.php`.
See #32522

Built from https://develop.svn.wordpress.org/trunk@35086


git-svn-id: http://core.svn.wordpress.org/trunk@35051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 22:52:24 +00:00
John Blackbourn 7cb0dcc9a6 Add missing `@since` docs for the filters in `wp-includes/embed-template.php`
See #32522, #32246

Built from https://develop.svn.wordpress.org/trunk@35085


git-svn-id: http://core.svn.wordpress.org/trunk@35050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 22:51:24 +00:00
John Blackbourn 2dd5ad6327 Correct the `@since` doc for `WP_Query::is_embed()`.
See #32522

Built from https://develop.svn.wordpress.org/trunk@35084


git-svn-id: http://core.svn.wordpress.org/trunk@35049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 22:13:25 +00:00
Scott Taylor 75426585fb oEmbed: add fallback icons (not used yet) for older browsers.
Props melchoyce.
See #34204.

Built from https://develop.svn.wordpress.org/trunk@35083


git-svn-id: http://core.svn.wordpress.org/trunk@35048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 21:17:25 +00:00
John Blackbourn a2609c13fa Add `$transient` as a parameter to the `set_transient_{transient}` action.
Props SergeyBiryukov
Fixes #34269

Built from https://develop.svn.wordpress.org/trunk@35082


git-svn-id: http://core.svn.wordpress.org/trunk@35047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 21:02:25 +00:00
Scott Taylor affe1ab5ad Media: avoid "divide by zero" in `wp_get_attachment_image_srcset_array()`.
Fixes #34238.

Built from https://develop.svn.wordpress.org/trunk@35081


git-svn-id: http://core.svn.wordpress.org/trunk@35046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 21:00:26 +00:00
Drew Jaynes 8b49acdd0e Docs: Specify the default image size in the `$size` parameter description for the `image_send_to_editor` hook.
See #34257. See #32246. See [35058].

Built from https://develop.svn.wordpress.org/trunk@35080


git-svn-id: http://core.svn.wordpress.org/trunk@35045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 17:18:24 +00:00
Drew Jaynes f7e92fc346 Docs: Normalize spacing in the DocBlock for `get_image_send_to_editor()` following [35056].
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35079


git-svn-id: http://core.svn.wordpress.org/trunk@35044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 17:16:24 +00:00
Drew Jaynes 2d677edb1f Docs: The `$size` parameter for the `get_image_tag` hook also accepts an array.
See #34257. See [35038].

Built from https://develop.svn.wordpress.org/trunk@35078


git-svn-id: http://core.svn.wordpress.org/trunk@35043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 17:11:24 +00:00
Drew Jaynes 36ef44735d Docs: The `$size` parameter for the `get_image_tag_class` hook also accepts an array.
See #34257. See [35037].

Built from https://develop.svn.wordpress.org/trunk@35077


git-svn-id: http://core.svn.wordpress.org/trunk@35042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 17:09:25 +00:00
Drew Jaynes bc631019d0 Docs: Adjust documentation for the `$size` parameter in `the_post_thumbnail_url()` to clarify the required order of width and height values when passing an array.
Fixes #34257. Whew!

Built from https://develop.svn.wordpress.org/trunk@35076


git-svn-id: http://core.svn.wordpress.org/trunk@35041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 17:00:26 +00:00
Drew Jaynes 5e67b71443 Docs: The `post_thumbnail_size` hook can also accept an array (already supported).
See #34257. See [35069].

Built from https://develop.svn.wordpress.org/trunk@35075


git-svn-id: http://core.svn.wordpress.org/trunk@35040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:57:24 +00:00
Drew Jaynes 03a39f75b3 Docs: The `$size` parameters in the `begin_fetch_post_thumbnail_html` and `end_fetch_post_thumbnail_html` hooks can also accept an array (already supported).
See #34257. See #32246. See [35070] and [35071].

Built from https://develop.svn.wordpress.org/trunk@35074


git-svn-id: http://core.svn.wordpress.org/trunk@35039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:56:24 +00:00
Drew Jaynes dcb18faab8 Docs: Normalize spacing in the `post_thumbnail_html` hook doc following [35072].
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35073


git-svn-id: http://core.svn.wordpress.org/trunk@35038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:53:24 +00:00
Drew Jaynes 476655b0e0 Docs: Adjust documentation for the `$size` parameter in the `post_thumbnail_html` hook doc to clarify the required order of width and height values when an array is passed.
Also adds the `array` type to the parameter documentation (already supported).

See #34257.

Built from https://develop.svn.wordpress.org/trunk@35072


git-svn-id: http://core.svn.wordpress.org/trunk@35037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:52:24 +00:00
Drew Jaynes 1564eb43b4 Docs: Adjust documentation for the `$size` parameter in the `end_fetch_post_thumbnail_html` hook doc to clarify the required order of width and height values when an array is passed.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35071


git-svn-id: http://core.svn.wordpress.org/trunk@35036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:50:25 +00:00
Drew Jaynes 91d5909507 Docs: Adjust documentation for the `$size` parameter in the `begin_fetch_post_thumbnail_html` hook doc to clarify the required order of width and height values when an array is passed.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35070


git-svn-id: http://core.svn.wordpress.org/trunk@35035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:49:24 +00:00
Drew Jaynes fe0d59a061 Docs: Adjust documentation for the `$size` parameter in the `post_thumbnail_size` hook doc to clarify the required order of width and height values when an array is passed.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35069


git-svn-id: http://core.svn.wordpress.org/trunk@35034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:48:25 +00:00
Drew Jaynes 2091ff358d Docs: Adjust documentation for the `$size` parameter in `get_the_post_thumbnail()` to clarify the required order of width and height values when passing an array.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35068


git-svn-id: http://core.svn.wordpress.org/trunk@35033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:47:25 +00:00