85384297a6
Query: Ensure that queries work correctly with post type names with special characters.
...
Built from https://develop.svn.wordpress.org/trunk@39952
git-svn-id: http://core.svn.wordpress.org/trunk@39889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-26 13:33:45 +00:00
a44f8db73d
Customize: Always enqueue `customize-preview` stylesheet in the customizer preview to style selective refresh and visual edit shortcuts.
...
Enqueues the style along with the `customize-preview` script in the manager instead of via the `widgets` and `nav_menus` components, ensuring that the stylesheet is loaded for users who cannot manage widgets or nav menus.
Props dlh.
See #27403 .
Fixes #39498 .
Built from https://develop.svn.wordpress.org/trunk@39951
git-svn-id: http://core.svn.wordpress.org/trunk@39888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-26 03:47:41 +00:00
d10f451770
Docs: Add missing file header to `wp-admin/includes/noop.php`, introduced in [34037].
...
Props carl-alberto.
Fixes #39690 .
Built from https://develop.svn.wordpress.org/trunk@39950
git-svn-id: http://core.svn.wordpress.org/trunk@39887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-25 23:10:43 +00:00
1a18262fd5
Menus: Prevent notice thrown in class-walker-page.php.
...
Calling `Walker_Page::walk()` directly was causing an `Undefined index: item_spacing` notice to be thrown, this adds an `isset()` check to prevent it.
Props bhargavbhandari90.
Fixes #39564 .
Built from https://develop.svn.wordpress.org/trunk@39949
git-svn-id: http://core.svn.wordpress.org/trunk@39886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-24 23:29:42 +00:00
832b16b966
Multisite: Show menu items in `My Sites > Network Admin` admin bar menu based on more precise capability checks.
...
Previously the menu items would all be displayed solely based on the `manage_network` capability. This change provides parity with the network admin menu.
Unit tests for the network admin menu functionality of `wp_admin_bar_my_sites_menu()` have been added.
Props chandrapatel.
Fixes #39082 .
Built from https://develop.svn.wordpress.org/trunk@39948
git-svn-id: http://core.svn.wordpress.org/trunk@39885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-24 16:29:40 +00:00
82dc367cd4
Multisite: Replace `is_super_admin()` with a proper capability check when showing a notice about `WPLANG`.
...
In multisite, the notice is displayed to users that have the `manage_network_options` capability. In non-multisite, the notice is displayed to users with the `manage_options` capability.
Props Dhaval Parekh.
Fixes #39207 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39947
git-svn-id: http://core.svn.wordpress.org/trunk@39884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-24 13:13:41 +00:00
34ad21bcfa
Multisite: Remove unnecessary `is_super_admin()` check when adding an existing user to a site.
...
Prior to this change, a super admin user that is added to a site who they are already a member of would still get reinvited.
Props supercoder.
Fixes #39220 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39946
git-svn-id: http://core.svn.wordpress.org/trunk@39883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-24 12:03:43 +00:00
36fa7f72c0
Multisite: Replace `is_super_admin()` with `manage_network_users` when trying to import new users.
...
Props bhargavbhandari90.
Fixes #39212 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39945
git-svn-id: http://core.svn.wordpress.org/trunk@39882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-24 11:39:40 +00:00
ff74a4cb7b
Multisite: Replace `is_super_admin()` with `manage_network` when showing a message to the network administrator in `wp-signup.php`.
...
Props jignesh.nakrani.
Fixes #39209 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39944
git-svn-id: http://core.svn.wordpress.org/trunk@39881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-24 11:08:42 +00:00
6fcb0e8b7f
Multisite: Replace `is_super_admin()` with `manage_network_users` when trying to change the role of oneself.
...
Props abhishek kaushik.
Fixes #39204 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39943
git-svn-id: http://core.svn.wordpress.org/trunk@39880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-24 11:04:44 +00:00
64694c6742
Twenty Seventeen: Improve typography for Simplified Chinese (`zh_CN`).
...
Props ze3kr, Dharm1025.
Fixes #39379 .
Built from https://develop.svn.wordpress.org/trunk@39942
git-svn-id: http://core.svn.wordpress.org/trunk@39879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-24 07:27:44 +00:00
ca832f66f3
Text Changes: Add a period to the only `wp_die()` message that didn't have it: "Invalid plugin page".
...
Props Presskopp.
Fixes #39664 .
Built from https://develop.svn.wordpress.org/trunk@39941
git-svn-id: http://core.svn.wordpress.org/trunk@39878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-22 02:33:42 +00:00
bf1e6d1226
Docs: After [39939], "locales" should be plural.
...
See #39658 .
Built from https://develop.svn.wordpress.org/trunk@39940
git-svn-id: http://core.svn.wordpress.org/trunk@39877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-21 17:26:41 +00:00
bee96601bd
I18N: Add support for Bosnian locale in `remove_accents()`.
...
Applies "letter D with stroke" replacement made in [38646] for Serbian (`sr_RS`) to Bosnian (`bs_BA`) as well.
Props H3llas for the report.
Fixes #39658 .
Built from https://develop.svn.wordpress.org/trunk@39939
git-svn-id: http://core.svn.wordpress.org/trunk@39876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-21 17:16:43 +00:00
35d5918a1d
Posts, Post Types: Preserve author filter in list table after entering a page number in paging input.
...
Props sagarprajapati.
Fixes #39523 .
Built from https://develop.svn.wordpress.org/trunk@39938
git-svn-id: http://core.svn.wordpress.org/trunk@39875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-21 02:22:26 +00:00
8f0e75db16
Users: Preserve role filter in list table after entering a page number in paging input.
...
Props kailanitish90, sagarprajapati.
Fixes #39435 .
Built from https://develop.svn.wordpress.org/trunk@39937
git-svn-id: http://core.svn.wordpress.org/trunk@39874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-21 02:21:43 +00:00
4fbcfe3a8c
Docs: After [38672], update `$type` parameter description for `submit_button()` and `get_submit_button()`.
...
Remove the mention of `secondary` and `delete` classes as core values, add `small` and `large`.
Props afercia.
Fixes #23477 .
Built from https://develop.svn.wordpress.org/trunk@39936
git-svn-id: http://core.svn.wordpress.org/trunk@39873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 20:37:42 +00:00
41fc0c0f5a
Multisite: Replace `is_super_admin()` with `manage_network_users` when trying to add an existing user via username.
...
Props dhanendran.
Fixes #39202 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39935
git-svn-id: http://core.svn.wordpress.org/trunk@39872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 17:49:41 +00:00
c22fea9120
Multisite: Replace `is_super_admin()` with `manage_network_users` when checking for users autocomplete capabilities.
...
Props ashokkumar24.
Fixes #39201 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39934
git-svn-id: http://core.svn.wordpress.org/trunk@39871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 17:43:42 +00:00
6e5cd6d397
Multisite: Replace `is_super_admin()` with `manage_network_options` in `wp-admin/options.php`.
...
Props sathyapulse.
Fixes #39200 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39933
git-svn-id: http://core.svn.wordpress.org/trunk@39870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 17:39:41 +00:00
dd23a8f48c
Multisite: Do not check for `is_super_admin()` when trying to set user settings.
...
The checks were introduced in [22256] to prevent user settings to be set for super admins that were not a member of the current site. However the latter should apply to any kind of user, so the `is_super_admin()` check is redundant. Furthermore, removing these checks is necessary for the ongoing effort to get rid of `is_super_admin()` checks in general.
Props chandrapatel for initial patch.
Fixes #39199 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39932
git-svn-id: http://core.svn.wordpress.org/trunk@39869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 17:33:41 +00:00
e9056c039d
REST API: Add `group` and description to `WP_Test_REST_Request_Validation`.
...
Props danielbachhuber.
Fixes #39654 .
Built from https://develop.svn.wordpress.org/trunk@39931
git-svn-id: http://core.svn.wordpress.org/trunk@39868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 17:13:40 +00:00
c8de21c0c5
Multisite: Display correct scheme for the main site in `site-info.php`.
...
Props greatislander.
Fixes #39365 .
Built from https://develop.svn.wordpress.org/trunk@39930
git-svn-id: http://core.svn.wordpress.org/trunk@39867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 17:03:41 +00:00
8062df694f
Multisite: Correct and improve i18n strings in `wp-signup.php`.
...
The strings addressing the network administrator in `wp-signup.php` were still using the old terminology of blogs and sites. Furthermore concatenation of the strings has been removed to make them i18n-friendly.
Props jignesh.nakrani, SergeyBiryukov.
Fixes #39611 .
Built from https://develop.svn.wordpress.org/trunk@39929
git-svn-id: http://core.svn.wordpress.org/trunk@39866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 16:52:39 +00:00
8d8f5616b7
Menus: trigger an event when menu items are added or removed.
...
Fire a `menu-item-added` event after a menu item is added to the DOM. Fire a `menu-removing-item` event before a menu item is removed from the DOM. Enables hooking into and responding to menu changes.
Props welcher, adamsilverstein.
Fixes #31218 .
Built from https://develop.svn.wordpress.org/trunk@39928
git-svn-id: http://core.svn.wordpress.org/trunk@39865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 16:15:42 +00:00
0b338e2f58
Customize: Remove redundant context for "Reorder" and "Done" strings in nav menu and widget area controls to ensure consistent translations.
...
Props pavelevap, Presskopp.
Fixes #33747 .
Built from https://develop.svn.wordpress.org/trunk@39927
git-svn-id: http://core.svn.wordpress.org/trunk@39864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 06:00:42 +00:00
6f8644aeb2
Media: Pass the current attachment object to `display_media_states` filter, for consistency with `display_post_states`.
...
Props pbiron, chriseverson.
Fixes #39628 .
Built from https://develop.svn.wordpress.org/trunk@39926
git-svn-id: http://core.svn.wordpress.org/trunk@39863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-20 05:20:41 +00:00
371c072b38
Media: After [36837], check the correct theme modification name for custom logo in `_media_states()`.
...
Props pbiron, mitraval192.
Fixes #39627 .
Built from https://develop.svn.wordpress.org/trunk@39925
git-svn-id: http://core.svn.wordpress.org/trunk@39862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-19 02:03:41 +00:00
3e6c892f89
Customize: Allow custom post types to be used in starter content.
...
Changes `WP_Customize_Nav_Menus::insert_auto_draft_post()` so it can be invoked for a `post_type` that is not registered (yet).
See #38615 , #38114 .
Fixes #39610 .
Built from https://develop.svn.wordpress.org/trunk@39924
git-svn-id: http://core.svn.wordpress.org/trunk@39861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-19 00:01:46 +00:00
1326d9e2c7
REST API: Correctly serve the index with PATH_INFO
...
When hitting the index, untrailingslashit() would make the REST route empty, which would then use the fallback inside WP_REST_Server. This isn't a problem most of the time, but WP_REST_Server contains a fallback to PATH_INFO. Combined with PATH_INFO permalinks, this would give a 404 on the API index, as it attempts to look up a route for "/wp-json/".
Props ccprog.
Fixes #39432 .
Built from https://develop.svn.wordpress.org/trunk@39923
git-svn-id: http://core.svn.wordpress.org/trunk@39860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 05:40:40 +00:00
dc133c3f2d
REST API: Allow shortcircuiting rest_pre_insert_comment
...
rest_pre_insert_{post_type} allows returning a WP_Error from the filter to shortcircuit actually creating the object, so it makes sense to do so for comments too.
Props dspilka.
Fixes #39578 .
Built from https://develop.svn.wordpress.org/trunk@39922
git-svn-id: http://core.svn.wordpress.org/trunk@39859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 05:18:41 +00:00
096b09d941
dbDelta: Ignore index subparts when checking for duplicate indices.
...
If index lengths change in table definitions, we don't recreate the index - instead, we throw a database error, as `dbDelta()` tries to create a new index with the same name.
It's better to leave the index as is, MySQL doesn't have an efficient process for resizing indices, and dropping/creating is a slow process which we don't want to trigger automatically.
Fixes #34870 .
Built from https://develop.svn.wordpress.org/trunk@39921
git-svn-id: http://core.svn.wordpress.org/trunk@39858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 04:01:42 +00:00
3c1ce66767
Users: Introduce `signup_site_meta` and `signup_user_meta` for filtering signup metadata in `wpmu_signup_blog()` and `wpmu_signup_user()`, respectively.
...
Props Mista-Flo.
Fixes #39223 .
Built from https://develop.svn.wordpress.org/trunk@39920
git-svn-id: http://core.svn.wordpress.org/trunk@39857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 03:53:42 +00:00
4a1108b9f9
Build/Test Tools: Add `assertNotFalse()` method to `WP_UnitTestCase` and use it where appropriate.
...
Props peterwilsoncc.
Fixes #39219 .
Built from https://develop.svn.wordpress.org/trunk@39919
git-svn-id: http://core.svn.wordpress.org/trunk@39856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 03:40:43 +00:00
6b89d68cc1
Build/Test Tools: Correctly reference function names in `@covers` entries.
...
Props pbearne.
Fixes #39235 .
Built from https://develop.svn.wordpress.org/trunk@39918
git-svn-id: http://core.svn.wordpress.org/trunk@39855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 02:44:43 +00:00
54001e2756
List Tables: Pass the `$which` parameter to `restrict_manage_posts` filter instance in `WP_Media_List_Table`, missed in [37422].
...
Props wpsmith.
Fixes #38772 .
Built from https://develop.svn.wordpress.org/trunk@39917
git-svn-id: http://core.svn.wordpress.org/trunk@39854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 02:38:42 +00:00
66a39611f6
TinyMCE: strip browser inserted `<u>` and <font>` tags from inside links when copying and pasting in IE and Edge.
...
Fixes #39570 .
Built from https://develop.svn.wordpress.org/trunk@39916
git-svn-id: http://core.svn.wordpress.org/trunk@39853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-17 01:25:44 +00:00
1071dfb4ec
User Query: Cast `$user_total` as an `int`.
...
The `$user_total` member of `WP_User_Query`, and corresponding `get_total()` method, have always been documented as returning an `int`. `$user_total`, however, is populated by `$wpdb->get_var()`, which returns
a string (containing an integer value). Casting the return value from `get_var()` as an `int` rectifies this discrepency.
Props runciters.
Fixes #39297 .
Built from https://develop.svn.wordpress.org/trunk@39915
git-svn-id: http://core.svn.wordpress.org/trunk@39852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 23:24:45 +00:00
458746f631
Tests: `wpautop()` should not add extra `</p>` before `<figcaption>`.
...
Props pbearne.
See #39307 .
Built from https://develop.svn.wordpress.org/trunk@39914
git-svn-id: http://core.svn.wordpress.org/trunk@39851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 17:57:43 +00:00
fa20ce762a
REST API: Improve test coverage of single user endpoint for public data.
...
Add test coverage for requests of a single user resource for authors of post types registered as:
- public = true, show_in_rest = true: success without auth.
- public = true, show_in_rest = false: fail without auth.
- public = false, show_in_rest = true: success without auth.
- public = false, show_in_rest = false: fail without auth.
See #38878 .
Fixes #39546 .
Built from https://develop.svn.wordpress.org/trunk@39913
git-svn-id: http://core.svn.wordpress.org/trunk@39850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 16:21:43 +00:00
85ee190163
Formatting: fix `wpautop()` to stop adding paragraph tags around `<figcaption>`.
...
Fixes #39307 for trunk.
Built from https://develop.svn.wordpress.org/trunk@39912
git-svn-id: http://core.svn.wordpress.org/trunk@39849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 01:06:40 +00:00
ee3052fdbe
Docs: some improvements/fixes for editor.js.
...
See #38933 .
Built from https://develop.svn.wordpress.org/trunk@39911
git-svn-id: http://core.svn.wordpress.org/trunk@39848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 00:49:41 +00:00
82a8065f70
TinyMCE: ensure the inline toolbar is shown and properly positioned when there are several wpview blocks in the editor and the user selects one after the other.
...
Props gitlost.
Fixes #38849 .
Built from https://develop.svn.wordpress.org/trunk@39910
git-svn-id: http://core.svn.wordpress.org/trunk@39847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-16 00:22:43 +00:00
1ba4484186
Twenty Seventeen: Remove duplicate `global $post` declaration in `twentyseventeen_front_page_section()`.
...
Props ixkaito.
Fixes #39590 .
Built from https://develop.svn.wordpress.org/trunk@39909
git-svn-id: http://core.svn.wordpress.org/trunk@39846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 12:50:39 +00:00
4d546a12cf
I18N: Reference correct placeholder in a translator comment added in [30333].
...
See #30264 .
Built from https://develop.svn.wordpress.org/trunk@39908
git-svn-id: http://core.svn.wordpress.org/trunk@39845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 08:07:43 +00:00
9ba7ab1cfc
Users: Display the name of user being edited on Edit User screen.
...
Props seanchayes.
Fixes #28182 .
Built from https://develop.svn.wordpress.org/trunk@39907
git-svn-id: http://core.svn.wordpress.org/trunk@39844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 07:14:39 +00:00
649d554294
Themes: Add a unit test for `get_theme_feature_list()` to make sure that the list of theme features pulled from the WordPress.org API returns the expected data structure.
...
Props iandunn.
Fixes #28121 .
Built from https://develop.svn.wordpress.org/trunk@39906
git-svn-id: http://core.svn.wordpress.org/trunk@39843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 06:50:43 +00:00
6e3073c1eb
Posts, Post Types: Increase the height of post slug input to prevent certain characters from being cut in Firefox on Windows.
...
Props Ankit K Gupta, Presskopp.
Fixes #28084 .
Built from https://develop.svn.wordpress.org/trunk@39905
git-svn-id: http://core.svn.wordpress.org/trunk@39842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 04:03:43 +00:00
35c91b7c0d
TinyMCE: prevent the inline toolbar from appearing on partially selected wpview nodes. This can happen when HTML is initially loaded in the editor and wpview is the first node, or sometimes on repeatedly pasting the same wpview.
...
Props gitlost.
Fixes #38849 .
Built from https://develop.svn.wordpress.org/trunk@39904
git-svn-id: http://core.svn.wordpress.org/trunk@39841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 03:00:43 +00:00
45f3ee380c
TinyMCE: when inserting a wpview, place the caret after is so the user can continue typing without interruption.
...
Props iseulde.
Fixes #39337 .
Built from https://develop.svn.wordpress.org/trunk@39903
git-svn-id: http://core.svn.wordpress.org/trunk@39840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-15 02:41:40 +00:00
Dominik Schilling
Weston Ruter
Sergey Biryukov
Peter Wilson
Felix Arntz
Adam Silverstein
Ryan McCue
Gary Pendergast
Andrew Ozz
James Nylen