Commit Graph

152 Commits

Author SHA1 Message Date
Scott Taylor e3d58a5b23 Make `url_to_postid()` work for custom post type URLs. Use `get_post_types()` and `get_taxonomies()` instead of directly accessing globals. Adds unit test.
Props faishal, for the globals fix.
Fixes #19744.


Built from https://develop.svn.wordpress.org/trunk@25659


git-svn-id: http://core.svn.wordpress.org/trunk@25576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 19:42:09 +00:00
Andrew Nacin 205a4d583d Add documentation for the new flush_rewrite_rules_hard filter. fixes #23491.
Built from https://develop.svn.wordpress.org/trunk@25464


git-svn-id: http://core.svn.wordpress.org/trunk@25385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-16 22:00:09 +00:00
Scott Taylor 2f267f6a2a Add filter `flush_rewrite_rules_hard` to give devs chance to prevent writing to file when hard-flushing rewrite rules.
Props jeremyfelt, nacin.
Fixes #23491.


Built from https://develop.svn.wordpress.org/trunk@25328


git-svn-id: http://core.svn.wordpress.org/trunk@25290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 22:19:09 +00:00
Scott Taylor dd7a6d66af Only variables should be passed by reference.
Props Askapache.
Fixes #23032.


Built from https://develop.svn.wordpress.org/trunk@25263


git-svn-id: http://core.svn.wordpress.org/trunk@25231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 21:53:09 +00:00
Scott Taylor d03b6f9df5 Avoids incorrect results when `url_to_postid()` checking is not strict enough. Adds a bunch of Unit Tests for `url_to_postid()', which is currently only tested lightly in some XML-RPC tests.
Props gcorne, gradyetc.
Fixes #20560.


Built from https://develop.svn.wordpress.org/trunk@25258


git-svn-id: http://core.svn.wordpress.org/trunk@25226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 17:29:13 +00:00
Jon Cave b0f446b5ba Introduce a new endpoint mask for all archives, fixes #16303.
git-svn-id: http://core.svn.wordpress.org/trunk@24812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 19:18:19 +00:00
Jon Cave dffea4e020 Drop leading / by retrieving the inner subpattern when matching attachment endpoints.
Fixes #22619


git-svn-id: http://core.svn.wordpress.org/trunk@24809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 19:02:08 +00:00
Andrew Nacin 17ddaa8de0 delete_user_setting() and remove_action() were getting called with too many args. props rlerdorf. see #24210.
git-svn-id: http://core.svn.wordpress.org/trunk@24125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:25:15 +00:00
Andrew Nacin bf4d00e320 Remove bogus pagination rules from the comments permastruct. (As in, comments/page/?([0-9]{1,})/?$.) props wonderboymusic, fixes #21138.
git-svn-id: http://core.svn.wordpress.org/trunk@23524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 18:35:13 +00:00
Mark Jaquith a24c40fb00 Consistently use $wp_rewrite->index instead of hardcoding "index.php".
props wonderboymusic. fixes #7337

git-svn-id: http://core.svn.wordpress.org/trunk@23305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-18 13:44:22 +00:00
Andrew Nacin a79310d45c Update the old wp-app.php rule to allow for a trailing slash followed by endpoint data. props wonderboymusic. fixes #22035.
git-svn-id: http://core.svn.wordpress.org/trunk@22441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 21:27:02 +00:00
Ryan Boren 8bb0fc5079 Revert [22365]. see #21167
git-svn-id: http://core.svn.wordpress.org/trunk@22403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 19:45:51 +00:00
Jon Cave 86d88f8b2d Actually pass old permalink structure with permalink_structure_changed action
Props doublesharp. Fixes #22351.


git-svn-id: http://core.svn.wordpress.org/trunk@22398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 12:41:33 +00:00
Ryan Boren c0274c4fa7 preg_quote() the permalink structure so that regex special chars such as dots are correctly handled. Props SergeyBiryukov. fixes #21167
git-svn-id: http://core.svn.wordpress.org/trunk@22365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 14:13:29 +00:00
Mark Jaquith e3dc0220ff Make Multisite work when WordPress is installed in a subdirectory. You can now have WordPress Multisite as an SVN external or a Git submodule! props johnjamesjacoby, evansolomon, duck_, jakemgold, nacin, markjaquith. see #19796
git-svn-id: http://core.svn.wordpress.org/trunk@22042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 06:07:21 +00:00
Andrew Nacin dc49f24a6c Remove ms-files.php rewriting from WordPress multisite. fixes #19235.
Keep existing networks compatible with a ms_files_rewriting network option.



git-svn-id: http://core.svn.wordpress.org/trunk@21823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 22:22:20 +00:00
Andrew Nacin fffed3c5d2 Remove accidental cruft in [21804] caused by renaming variables. see #21509.
git-svn-id: http://core.svn.wordpress.org/trunk@21819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 20:15:56 +00:00
Andrew Nacin 9d204841ee Remove AtomPub from core.
* Will be replaced with http://wordpress.org/extend/plugins/atom-publishing-protocol/.
 * Introduces an action, xmlrpc_rsd_apis, to add APIs to xmlrpc.php?rsd.
 * Introduces support for 'error' being 403 and 50x in class-wp.php.
 * Removes 'Remote Publishing' from Writing Settings (see [21804]). Keeps the remote_publishing settings section.

DB version is bumped to generate the new wp-app rewrite rule and remove the old enable_app option.

props wonderboymusic.
fixes #21509.



git-svn-id: http://core.svn.wordpress.org/trunk@21818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 20:11:39 +00:00
Andrew Nacin 1b99559639 Use site_url() in WP_Rewrite::mod_rewrite_rules(), rather than get_option(). props JustinSainton. fixes #21186.
git-svn-id: http://core.svn.wordpress.org/trunk@21810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 01:44:48 +00:00
Jon Cave 4a94c500f2 Reinstate paged rewrite rules for the post permalink structure.
Removal of this stopped pagination working for bare category URLs when
certain %category% based permalink structures were in used.

Reverts one more piece of [19737]. Props SergeyBiryukov. See #21209.


git-svn-id: http://core.svn.wordpress.org/trunk@21705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-03 22:06:28 +00:00
duck_ 176317abcf Set $walk_dirs = true for post rewrite rule generation. See #21020 for trunk.
Partial revert of r19737 and r19778 as some users were relying on this behaviour.


git-svn-id: http://core.svn.wordpress.org/trunk@21112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-25 20:41:14 +00:00
nacin 548baad816 Remove wp-register.php.
* Don't remove it on update. If you have it now, you'll keep it. New installs won't get it.
 * Peform a redirect using rewrite + canonical to the new location, if the file doesn't exist.
props SergeyBiryukov.
fixes #18544.


git-svn-id: http://svn.automattic.com/wordpress/trunk@20596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 20:49:57 +00:00
ryan d910c26182 Pinking shears 6-20000
git-svn-id: http://svn.automattic.com/wordpress/trunk@20000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-27 19:46:52 +00:00
duck_ b6edf3ddd2 Pages must be paged (/page/x/) to allow for the page_for_posts option. See #19876.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-01 19:19:32 +00:00
duck_ 2f4c545761 Use new $args parameter for (WP_Rewrite::)add_permastruct(). Fixes #16092.
Use array_intersect_key() to keep WP_Rewrite::$extra_permastructs free of unnecessary/unknown keys + values.


git-svn-id: http://svn.automattic.com/wordpress/trunk@19779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-28 21:00:59 +00:00
duck_ e05c96316f Add the $query parameter to add_rewrite_tag() so that it matches WP_Rewrite::add_rewrite_tag(). Fixes #19871.
Also rename some other parameters so that they all match.


git-svn-id: http://svn.automattic.com/wordpress/trunk@19756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-25 22:48:24 +00:00
duck_ 8361ce4be1 Improve the inline documentation of rewrite endpoints. See #16303.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-25 21:58:23 +00:00
duck_ e85445c826 Improve documentation of WP_Rewrite. Fixes #19897.
In particular WP_Rewrite::$front, WP_Rewrite::$root, WP_Rewrite::$use_verbose_page_rules and WP_Rewrite::generate_rewrite_rules(). As well as some code indentation prettification.


git-svn-id: http://svn.automattic.com/wordpress/trunk@19752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-25 21:44:02 +00:00
duck_ bddf5d4ba8 Upgrade add_permastruct() to allow more control over WP_Rewrite::generate_rewrite_rules(). See #16092.
The third argument is now a configuration array that mirrors the parameters of generate_rewrite_rules()
and allows for add_permastruct() specific args (i.e. with_front). The full configuration is stored in
WP_Rewrite::$extra_permastructs to be used by WP_Rewrite::rewrite_rules().


git-svn-id: http://svn.automattic.com/wordpress/trunk@19743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-24 18:27:18 +00:00
duck_ 03fa135546 Set $paged and $walk_dirs to false in calls to WP_Rewrite::generate_rewrite_rules() for posts/pages. See #19876.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-23 19:03:56 +00:00
duck_ 15cd5752b2 Simplify code in WP_Rewrite::page_rewrite_rules() and remove out-of-date documenation. Fixes #19875.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-22 17:21:29 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
ryan d3030023cf Avoid notice when handling malformed permalink structure. Props SergeyBiryukov. fixes #18883
git-svn-id: http://svn.automattic.com/wordpress/trunk@19322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-17 18:43:33 +00:00
nacin f11bc146f7 Use correct capture group in IIS7 multisite subdirectory rewrite rules. props carlospaulino, eduplessis, ruslany. fixes #17708.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 22:57:37 +00:00
nacin 239e36bc0a We know that pagename is being assigned to $matches-something, so skip the variable variable. props duck_. see #18991.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 22:49:45 +00:00
westi 738904e996 Escape the dot so that it only matches dot any not any character in the old feed files redirect.
Bump the db version so the rules regenerate.
See #18384

git-svn-id: http://svn.automattic.com/wordpress/trunk@18715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-19 12:15:43 +00:00
duck_ 0995987f25 Fix rewrite documentation typo and clarify with "rules array" over "this/the structure". props SergeyBiryukov. see #16687
git-svn-id: http://svn.automattic.com/wordpress/trunk@18566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-18 17:57:22 +00:00
markjaquith 4a610eaa7b Eliminate verbose rewrite rules for ambiguous rewrite structures, resulting in massive performance gains. props andy, otto42, duck_. Nice work everyone! see #16687
git-svn-id: http://svn.automattic.com/wordpress/trunk@18541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-12 01:55:08 +00:00
nacin 3fb35c6739 Remove the old root feed files. Bump the db version so rewrite rules can regenerate. Don't add these files to old_files to leave them on existing installs. fixes #18384.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-12 01:41:23 +00:00
markjaquith 9de72e9bfd Direct rdf/rss redirects, to save a double redirect. props westi. see #4967
git-svn-id: http://svn.automattic.com/wordpress/trunk@18538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-11 23:45:02 +00:00
nacin bd5090cbd6 Don't fetch auto-draft pages in WP_Rewrite::page_uri_index(). props duck_, see #17176.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-14 19:47:29 +00:00
ryan 04487fc268 Constructor cleanup. Props ocean90. fixes #16768
git-svn-id: http://svn.automattic.com/wordpress/trunk@17771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-29 20:05:12 +00:00
markjaquith 59f5dff476 Correctly handle PATHINFO CPTs and CTs that specify with_front=false. fixes #16807 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@17518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-03-10 04:24:48 +00:00
ryan 1d6b027adc Revert [15987] [15988] [15989]. Props SergeyBiryukov. see #9824 fixes #16041
git-svn-id: http://svn.automattic.com/wordpress/trunk@17226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-06 03:59:22 +00:00
nacin e1eec3925a More @since. props SergeyBiryukov, fixes #15445.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 09:25:21 +00:00
scribu ff33f41daf Remove excess comments from url_to_postid(). See #15771
git-svn-id: http://svn.automattic.com/wordpress/trunk@16878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-11 09:28:36 +00:00
scribu 5bc9f1051c Use is_singular in url_to_postid(). See #15771
git-svn-id: http://svn.automattic.com/wordpress/trunk@16877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-11 09:25:02 +00:00
dd32 bc8dc99e43 Check to see if WP_Query has returned any posts before blindly accessing posts. Fixes #15771
git-svn-id: http://svn.automattic.com/wordpress/trunk@16872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-11 06:35:47 +00:00
nacin 0d7979ea9a s/flush/flush_rules/ in a comment. fixes #15474, props hakre.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-18 19:21:54 +00:00