Drew Jaynes
0aaa2900eb
Docs: Add a version to the file header for wp-admin/includes/comment.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35262
git-svn-id: http://core.svn.wordpress.org/trunk@35228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 14:34:25 +00:00
Ella Iseulde Van Dorpe
9845e08340
TinyMCE: Drag and drop link with image
...
Make sure images don't loose their link after drag and drop.
Fixes #28272 .
Built from https://develop.svn.wordpress.org/trunk@35261
git-svn-id: http://core.svn.wordpress.org/trunk@35227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 11:05:23 +00:00
John Blackbourn
532e1fb856
Some cleanup that was missed in [35259].
...
See #33728 , #24853
Built from https://develop.svn.wordpress.org/trunk@35260
git-svn-id: http://core.svn.wordpress.org/trunk@35226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 06:26:24 +00:00
John Blackbourn
46a191dfcc
Some rewrite endpoint tests in preparation for new endpoint masks. More to come.
...
See #33728 , #24853
Built from https://develop.svn.wordpress.org/trunk@35259
git-svn-id: http://core.svn.wordpress.org/trunk@35225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 06:24:24 +00:00
John Blackbourn
9564ccf373
Preserve the public and private query var properties on the global `WP` instance when using `WP_UnitTestCase::go_to()`. These properties apply to the application state, not the current request.
...
See #34346
Built from https://develop.svn.wordpress.org/trunk@35258
git-svn-id: http://core.svn.wordpress.org/trunk@35224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 05:01:24 +00:00
John Blackbourn
53f5767ee1
Add `is_embed()` to `WP_UnitTestCase::assertQueryTrue()` and update the relevant embed tests.
...
See #32522
Built from https://develop.svn.wordpress.org/trunk@35257
git-svn-id: http://core.svn.wordpress.org/trunk@35223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 04:51:25 +00:00
John Blackbourn
c01a64ad31
Move the `test_is_home_should_be_false_when_visiting_custom_endpoint_without_a_registered_query_var_and_page_on_front_is_set()` test into a more appropriate place.
...
See #25143
Built from https://develop.svn.wordpress.org/trunk@35256
git-svn-id: http://core.svn.wordpress.org/trunk@35222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 01:35:24 +00:00
John Blackbourn
0b845bed03
Correct a test after r35253.
...
See #34272
Built from https://develop.svn.wordpress.org/trunk@35255
git-svn-id: http://core.svn.wordpress.org/trunk@35221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 00:56:24 +00:00
John Blackbourn
9da3b964fc
Remove an IDE-specific rule in `.gitignore`. These should be managed in the user's `~/.gitignore_global` file.
...
Fixes #34345
Built from https://develop.svn.wordpress.org/trunk@35254
git-svn-id: http://core.svn.wordpress.org/trunk@35220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 00:16:24 +00:00
Sergey Biryukov
d76d340036
Embeds: After [35235], replace some missed `oembed` references with `embed`.
...
Props peterwilsoncc.
Fixes #34272 .
Built from https://develop.svn.wordpress.org/trunk@35253
git-svn-id: http://core.svn.wordpress.org/trunk@35219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 23:26:47 +00:00
John Blackbourn
5576cd3978
Introduce `map_deep()`, a utility function that recursively maps a callable function to every item in an array or object. Works like `array_walk_recursive()` but works with objects too.
...
Updates `rawurlencode_deep()`, `urlencode_deep()`, and `stripslashes_deep()` to use `map_deep()`. Introduces `urldecode_deep()` for completeness.
Props wpmuguru, nbachiyski, boonebgorges, MikeHansenMe, chriscct7, realloc, johnbillion
Fixes #22300
Built from https://develop.svn.wordpress.org/trunk@35252
git-svn-id: http://core.svn.wordpress.org/trunk@35218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 23:26:24 +00:00
Weston Ruter
f676fdcee3
Customizer: Fix `margin-top` calculation for Themes section.
...
Ensure that the Themes section calculates its `margin-top` as a panel, since the section behaves as one. Fixes regression caused by [35231].
See #33567 .
Built from https://develop.svn.wordpress.org/trunk@35251
git-svn-id: http://core.svn.wordpress.org/trunk@35217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 22:41:25 +00:00
Scott Taylor
443ce28304
Media: in `wp_get_attachment_image_sizes()`, ensure that `$img_width` exists when the image does not.
...
Props kraftbj.
See #33641 .
Built from https://develop.svn.wordpress.org/trunk@35250
git-svn-id: http://core.svn.wordpress.org/trunk@35216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 22:12:24 +00:00
Scott Taylor
c7b0db99a6
Unit Tests: better fixtures for `Tests_Meta_Slashes` and `Tests_WP_Customize_Section`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35249
git-svn-id: http://core.svn.wordpress.org/trunk@35215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 21:29:24 +00:00
Scott Taylor
11d1e8af8b
Unit Tests: better fixtures for `Tests_User_WpSetCurrentUser`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35248
git-svn-id: http://core.svn.wordpress.org/trunk@35214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 21:19:24 +00:00
Scott Taylor
32bb609d88
Unit Tests: better fixtures for `Tests_User`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35247
git-svn-id: http://core.svn.wordpress.org/trunk@35213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 21:15:25 +00:00
Scott Taylor
a9134691d4
Unit Tests: better fixtures for `Tests_AdminBar`. Don't force-delete some posts: some filter callbacks are no-ops on Multisite if the post is vanquished.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35246
git-svn-id: http://core.svn.wordpress.org/trunk@35212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 20:49:24 +00:00
Scott Taylor
4204afdd40
Unit Tests: better fixtures for `Tests_Admin_Includes_Post`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35245
git-svn-id: http://core.svn.wordpress.org/trunk@35211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 19:48:23 +00:00
Scott Taylor
d54f567862
Unit Tests: `WP_UnitTest_Generator_Sequence` needs a static incrementer - otherwise, it assumes every test class is a reset, which it no longer is (it is now static).
...
While we're at it, remove unnecessary `tearDown()` code.
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35244
git-svn-id: http://core.svn.wordpress.org/trunk@35210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 19:25:24 +00:00
Scott Taylor
7d7c85b83d
Unit Tests: after [35242], declare some missing instance props on individual test classes.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35243
git-svn-id: http://core.svn.wordpress.org/trunk@35209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 18:30:24 +00:00
Scott Taylor
7f8dca02b7
Unit Tests: after [35225], make `factory` a method/getter on `WP_UnitTestCase` and add magic methods for BC for every plugin that is extending `WP_UnitTestCase` and accessing the `$factory` instance prop.
...
Props nerrad, wonderboymusic.
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35242
git-svn-id: http://core.svn.wordpress.org/trunk@35208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 18:03:25 +00:00
Drew Jaynes
8a386cb24f
Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35241
git-svn-id: http://core.svn.wordpress.org/trunk@35207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 15:13:25 +00:00
Drew Jaynes
767d091c74
Docs: Improve the hook doc for the `get_post_status` filter, introduced in [35233].
...
Also adds a missing parameter description for `$post`.
See #23458 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35240
git-svn-id: http://core.svn.wordpress.org/trunk@35206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 14:24:25 +00:00
Ella Iseulde Van Dorpe
08f71faac3
JSHint after [35238]
...
Built from https://develop.svn.wordpress.org/trunk@35239
git-svn-id: http://core.svn.wordpress.org/trunk@35205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:11:24 +00:00
Ella Iseulde Van Dorpe
47e364de42
Admin: fix repositioning notices
...
Fixes #34294 .
Props afercia.
Built from https://develop.svn.wordpress.org/trunk@35238
git-svn-id: http://core.svn.wordpress.org/trunk@35204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:04:26 +00:00
Drew Jaynes
10d94ea673
Docs: Add a missing file header for wp-admin/includes/class-wp-list-table.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35237
git-svn-id: http://core.svn.wordpress.org/trunk@35203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 06:07:24 +00:00
Weston Ruter
c7a951194d
Customizer: Add unit test for `WP_Customize_Widgets::is_panel_active()`.
...
See #33052 .
Built from https://develop.svn.wordpress.org/trunk@35236
git-svn-id: http://core.svn.wordpress.org/trunk@35202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 04:44:25 +00:00
Sergey Biryukov
a908d2d4b1
Embeds: Rename files, functions, and hooks added in [34903] to make it more clear what is oEmbed-specific and what isn't.
...
See https://core.trac.wordpress.org/ticket/34272#comment:7 for full list of renamed functions and hooks.
Props swissspidy.
Fixes #34272 .
Built from https://develop.svn.wordpress.org/trunk@35235
git-svn-id: http://core.svn.wordpress.org/trunk@35201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 01:21:25 +00:00
Sergey Biryukov
1157540283
Replace Quick Edit and Bulk Edit headings with `<legend>` elements.
...
Props afercia.
Fixes #34289 .
Built from https://develop.svn.wordpress.org/trunk@35234
git-svn-id: http://core.svn.wordpress.org/trunk@35200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:45:25 +00:00
Aaron Jorbin
b778726e74
Improve `get_post_permalink` compatibility with non standard post status
...
This adds a new filter named `get_post_status` to the function named `get_post_status` which can be used to make additional post types behave like unpublished post status in `get_post_permalink`.
Props misterbisson, antpb, iamfriendly
Fixes #23458
Built from https://develop.svn.wordpress.org/trunk@35233
git-svn-id: http://core.svn.wordpress.org/trunk@35199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:44:26 +00:00
Sergey Biryukov
7c2919c02b
Merge two strings for expanding accordion and Customizer sections.
...
Props pavelevap.
Fixes #33939 .
Built from https://develop.svn.wordpress.org/trunk@35232
git-svn-id: http://core.svn.wordpress.org/trunk@35198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:28:25 +00:00
Weston Ruter
6bcd8ad757
Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview.
...
Widgets panel will not wait to display until the preview loads.
Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.
Fixes #33052 .
Fixes #33567 .
Built from https://develop.svn.wordpress.org/trunk@35231
git-svn-id: http://core.svn.wordpress.org/trunk@35197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:48:25 +00:00
Sergey Biryukov
5c8522c022
Merge two warning strings.
...
Props pavelevap.
Fixes #29740 .
Built from https://develop.svn.wordpress.org/trunk@35230
git-svn-id: http://core.svn.wordpress.org/trunk@35196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:31:25 +00:00
Sergey Biryukov
f98136c1b5
Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
...
Props afercia.
Fixes #34255 .
Built from https://develop.svn.wordpress.org/trunk@35229
git-svn-id: http://core.svn.wordpress.org/trunk@35195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:02:25 +00:00
Sergey Biryukov
ac630ba233
Embeds: In `print_oembed_embed_styles()`, load non-minified file if `SCRIPT_DEBUG` is true.
...
This is consistent with `print_oembed_embed_scripts()`.
Props MikeHansenMe.
Fixes #34321 .
Built from https://develop.svn.wordpress.org/trunk@35228
git-svn-id: http://core.svn.wordpress.org/trunk@35194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 22:43:24 +00:00
Boone Gorges
4430e5dbbb
Return `null` from `get_term()` on taxonomy mismatch.
...
[34997] caused `get_term()` to return an error object in the case when
`$taxonomy` did not match the taxonomy of the located term. This was an
inadvertant change from the previous behavior, when `get_term()` would return
null in these cases.
Props dlh.
See #14162 . Fixes #34332 .
Built from https://develop.svn.wordpress.org/trunk@35227
git-svn-id: http://core.svn.wordpress.org/trunk@35193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 21:42:25 +00:00
Scott Taylor
efb224e831
Unit Tests: PHP 5.2, I Hate You and You Are Bringing Me Down.
...
#YOLOFriday
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35226
git-svn-id: http://core.svn.wordpress.org/trunk@35192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 21:15:25 +00:00
Scott Taylor
a2a65a06bd
Unit Tests: one `$factory` to rule them all, and it shall be `static`.
...
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.
Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values.
#YOLOFriday
Built from https://develop.svn.wordpress.org/trunk@35225
git-svn-id: http://core.svn.wordpress.org/trunk@35191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 21:05:25 +00:00
Scott Taylor
3693228a9b
Unit Tests: since [32953], we can just use `self::delete_user()` instead of using `if` logic for Multisite.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35224
git-svn-id: http://core.svn.wordpress.org/trunk@35190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 19:52:27 +00:00
Sergey Biryukov
7fdbebdd7d
In `WP_Posts_List_Table`, correct the type for `$comment_pending_count`.
...
See #11381 .
Built from https://develop.svn.wordpress.org/trunk@35223
git-svn-id: http://core.svn.wordpress.org/trunk@35189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 18:25:25 +00:00
Sergey Biryukov
dcf23c5e2a
In `WP_Media_List_Table`, rename `$pending_count` to `$comment_pending_count` and mark it as protected, for consistency with `WP_Posts_List_Table`.
...
See #11381 .
Built from https://develop.svn.wordpress.org/trunk@35222
git-svn-id: http://core.svn.wordpress.org/trunk@35188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 18:23:27 +00:00
Drew Jaynes
1cb39b180f
Docs: Standardize the file header summary for wp-admin/includes/file.php.
...
Also adds an `@since` version and corrects the `@subpackage` value.
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35221
git-svn-id: http://core.svn.wordpress.org/trunk@35187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 16:56:26 +00:00
Andrea Fercia
dc0e7e1a79
Accessibility: Improve headings hierarchy in the Theme browser modal dialog.
...
Fixes #34288 .
Built from https://develop.svn.wordpress.org/trunk@35220
git-svn-id: http://core.svn.wordpress.org/trunk@35186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 15:56:25 +00:00
Andrea Fercia
7f4a0ebbf3
Bump H4 headings to H2 in the Updates screen for better accessibility.
...
Fixes #34265 .
Built from https://develop.svn.wordpress.org/trunk@35219
git-svn-id: http://core.svn.wordpress.org/trunk@35185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 15:45:28 +00:00
Dominik Schilling
0df9abe092
Travis CI: Use a pinned version of the object cache drop-in.
...
Props tollmanz.
See #31491 .
Built from https://develop.svn.wordpress.org/trunk@35218
git-svn-id: http://core.svn.wordpress.org/trunk@35184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 14:16:28 +00:00
Ella Iseulde Van Dorpe
bafdd96ebf
TinyMCE: add lang attribute
...
This is needed to make `hyphens: auto;` work correctly.
Fixes #32555 .
Built from https://develop.svn.wordpress.org/trunk@35217
git-svn-id: http://core.svn.wordpress.org/trunk@35183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 10:11:27 +00:00
Ella Iseulde Van Dorpe
ef01315cac
TinyMCE: make sure markers are removed after first init
...
This is only relevant to non embeddable URLs.
After first init, markers were set but not removed,
causing an edited URL to revert when switching to text mode
or any paragraph after the URL to just contain that URL.
Fixes #33954 .
Built from https://develop.svn.wordpress.org/trunk@35216
git-svn-id: http://core.svn.wordpress.org/trunk@35182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 05:43:26 +00:00
Helen Hou-Sandí
fc02ca2d01
Account for icon alignment using text-indent in RTL.
...
fixes #33808 .
Built from https://develop.svn.wordpress.org/trunk@35215
git-svn-id: http://core.svn.wordpress.org/trunk@35181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 00:58:25 +00:00
Scott Taylor
438c2462e1
Unit Tests: add `SpeedTrapListener` to `phpunit/includes` and add the config node to `phpunit.xml.dist`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35214
git-svn-id: http://core.svn.wordpress.org/trunk@35180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 00:28:23 +00:00
Dominik Schilling
dd753ef3ad
Travis: Extend our test suite with a memcached instance.
...
To test persistent object caching Travis CI runs now a build on PHP 5.6 with memached enabled. The build uses the drop-in from https://github.com/tollmanz/wordpress-pecl-memcached-object-cache which is based on the PECL memcached extension.
Props pento, ocean90.
Fixes #31491 .
Built from https://develop.svn.wordpress.org/trunk@35213
git-svn-id: http://core.svn.wordpress.org/trunk@35179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 22:52:25 +00:00