Commit Graph

94 Commits

Author SHA1 Message Date
desrosj 2a920d0912 Build/Test Tools: Backport GitHub Action and build improvements to the 4.6 branch.
This backports several build and test tool improvements to the 4.6 branch. Most notably, this includes:

- The changes required to allow each workflow to be triggered by the `workflow_dispatch` event so that tests can be run on a schedule [50590].
- Splitting single site and multisite tests into parallel jobs [50379].
- Split slow tests into separate, parallel jobs for PHP <= 5.6 [50444].
- Better branch and path scoping for GitHub Action workflows when running on `pull_request` [50432,50479].
- Several `devDependency` updates.

Merges [50379,50387,50416,50432,50435,50436,50444,50446,50473,50474,50476,50479,50485,50486,50487,50545,50579,50590] to the 4.6 branch.
See #50401, #51801, #51802, #52548, #52612, #52624, #52625, #52645, #52653, #52658, #52660, #52667.
Built from https://develop.svn.wordpress.org/branches/4.6@50637


git-svn-id: http://core.svn.wordpress.org/branches/4.6@50249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 15:34:24 +00:00
desrosj 0211c38565 Build/Test Tools: Support NodeJS 14.x in the 4.6 branch.
This updates the 4.6 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.

This also replaces the `npm-shrinkwrap.json` with a `package-lock.json` file. Lock files were not supported in earlier versions of NPM, but can now be used.

In addition to backporting the package updates that happened after branching 4.6, dependencies that were removed in future releases have also been updated to their latest versions.

Props desrosj, dd32, netweb, jorbin.
Merges [42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185] to the 4.6 branch.
See #52341.

Built from https://develop.svn.wordpress.org/branches/4.6@50206


git-svn-id: http://core.svn.wordpress.org/branches/4.6@49879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 04:17:44 +00:00
Helen Hou-Sandí 6d28c85bc7 System fonts: Don't quote single-word font names, per our coding standards.
props ocean90, netweb.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@38152


git-svn-id: http://core.svn.wordpress.org/trunk@38093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-26 16:39:30 +00:00
Dominik Schilling f160f2afd1 Toolbar: Allow 0 as a value for the `tabindex` property of a menu item.
To enhance accessibility for items without a link you can now define `tabindex="0"`, which makes descendant dropdowns accessible.

Props joedolson, afercia, ocean90.
Fixes #32495.
Built from https://develop.svn.wordpress.org/trunk@38035


git-svn-id: http://core.svn.wordpress.org/trunk@37976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-12 11:18:30 +00:00
Helen Hou-Sandí 8776694a33 Use numeric font weights instead of keywords.
When Open Sans was in use, the `300`, `400`, and `600` weights were loaded. `400` is the equivalent of `normal`; however, `bold` is equivalent to `700`, not `600`. With the move to system fonts, we need to be specific rather than relying on the lack of a `700` weight. Not all system fonts include a `600` weight; in those instances, they will use the `bold`/`700` weight.

The WordPress CSS Coding Standards have been updated accordingly.

props coderste.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37740


git-svn-id: http://core.svn.wordpress.org/trunk@37705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-17 18:37:28 +00:00
Helen Hou-Sandí 848501711a System font: The stack does not work with the `font` shorthand property.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37442


git-svn-id: http://core.svn.wordpress.org/trunk@37410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 01:45:27 +00:00
Helen Hou-Sandí a726a9f51f Admin font: Remove a redundant `sans-serif` declaration.
props samantha-miller.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37419


git-svn-id: http://core.svn.wordpress.org/trunk@37385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 02:14:28 +00:00
Jeremy Felt ced66ed4e7 Multisite: Use the admin-multisite Dashicon for sites
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.

Props Ipstenu, ocean90.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37365


git-svn-id: http://core.svn.wordpress.org/trunk@37331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 17:13:26 +00:00
Jeremy Felt db3d5a6bea Revert [37362], which incorrectly changed Dashicons CSS
`dashicons.css` is an external-ish library and the change there is incorrect.

See #36754.

Built from https://develop.svn.wordpress.org/trunk@37364


git-svn-id: http://core.svn.wordpress.org/trunk@37330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:29:27 +00:00
Jeremy Felt 172af4e0ce Multisite: Use the admin-multisite Dashicon in the admin menu and bar
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Props Ipstenu.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37362


git-svn-id: http://core.svn.wordpress.org/trunk@37328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 04:29:26 +00:00
Helen Hou-Sandí a800cf654b Drop Open Sans in the admin in favor of system fonts.
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37361


git-svn-id: http://core.svn.wordpress.org/trunk@37327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 22:07:37 +00:00
Andrea Fercia fcb3e5ec2f Accessibility: Improve the color contrast ratio for the input placeholders.
Also, cleans up a bit the CSS removing rules for elements that don't use
placeholders any more.

Fixes #35777.
Built from https://develop.svn.wordpress.org/trunk@36619


git-svn-id: http://core.svn.wordpress.org/trunk@36586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 23:29:26 +00:00
Andrea Fercia 30866ceb5d Accessibility: Improve color contrast updating any `#999` gray used for text or icons to a darker gray.
Fixes #35660.
Built from https://develop.svn.wordpress.org/trunk@36587


git-svn-id: http://core.svn.wordpress.org/trunk@36554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:44:27 +00:00
Aaron Jorbin d507b5636f Set cssmin compatibility to ie7
This matches the autoprefixer setting. This changes all compiled CSS.

Fixes #34540.
Props christophherr, peterwilsoncc, netweb


Built from https://develop.svn.wordpress.org/trunk@35684


git-svn-id: http://core.svn.wordpress.org/trunk@35648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:28:25 +00:00
Aaron Jorbin 627844ca34 Bump grunt-contrib-cssmin to 0.14.0
This updates the underlying version of cssmin

Fixes #34177


Built from https://develop.svn.wordpress.org/trunk@35541


git-svn-id: http://core.svn.wordpress.org/trunk@35505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-05 17:58:28 +00:00
Helen Hou-Sandí 28c77bec72 RIP `#21759b`, the old WordPress Blue.
The final lingering instances were all for hidden accessibility helper text.

fixes #34388.

Built from https://develop.svn.wordpress.org/trunk@35340


git-svn-id: http://core.svn.wordpress.org/trunk@35306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:36:28 +00:00
Andrea Fercia 579246ab4a Multisite: Improve the Admin Bar parent menu items color on hover and focus.
Props Nikschavan for the initial patch.
Fixes #34040.
Built from https://develop.svn.wordpress.org/trunk@35265


git-svn-id: http://core.svn.wordpress.org/trunk@35231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 16:22:24 +00:00
Sergey Biryukov e19cda5c2d Toolbar: Improve padding of toolbar submenu items on small screens.
Props tillkruess.
Fixes #28608.
Built from https://develop.svn.wordpress.org/trunk@35132


git-svn-id: http://core.svn.wordpress.org/trunk@35097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:40:25 +00:00
Scott Taylor 596431bd21 Admin Bar: fix the alignment of secondary menu item arrows.
Props juhise.
Fixes #33836.

Built from https://develop.svn.wordpress.org/trunk@35125


git-svn-id: http://core.svn.wordpress.org/trunk@35090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:54:24 +00:00
John Blackbourn bc6af23302 Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests.
Fixes #25162

Built from https://develop.svn.wordpress.org/trunk@34122


git-svn-id: http://core.svn.wordpress.org/trunk@34090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 17:10:26 +00:00
Scott Taylor d22fbc7545 Grunt RTL CSS: `swap-dashicons-left-right-arrows` in `rtlcss:properties` expects double-quoted `content` strings in CSS. It doesn't swap single-quoted values.
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.

Built from https://develop.svn.wordpress.org/trunk@34011


git-svn-id: http://core.svn.wordpress.org/trunk@33980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 20:22:25 +00:00
Sergey Biryukov b4fbbf53cf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/user-new.php`.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33884


git-svn-id: http://core.svn.wordpress.org/trunk@33853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 08:46:52 +00:00
Helen Hou-Sandí 28c1600e6e Toolbar: Disambiguate links to the dashboard vs. to the customizer.
All links in the site name menu now point to admin screens, and Customize is its own top-level link. This makes it clear which context you are about to enter.

fixes #32924. see #32678.

Built from https://develop.svn.wordpress.org/trunk@33130


git-svn-id: http://core.svn.wordpress.org/trunk@33101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:03:24 +00:00
Helen Hou-Sandí f85306c65a Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.

Built from https://develop.svn.wordpress.org/trunk@33056


git-svn-id: http://core.svn.wordpress.org/trunk@33027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:29:25 +00:00
Aaron Jorbin c9307fc95a Update Grunt dev-dependencies
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).

Props wonderboymusic
See #31700


Built from https://develop.svn.wordpress.org/trunk@32988


git-svn-id: http://core.svn.wordpress.org/trunk@32959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 14:51:30 +00:00
Helen Hou-Sandí 2636199e54 Toolbar: Search item consistency for focus state and IE8.
props afercia.
fixes #31322.

Built from https://develop.svn.wordpress.org/trunk@32074


git-svn-id: http://core.svn.wordpress.org/trunk@32053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:08:28 +00:00
Helen Hou-Sandí bfda508c18 Update more instances of default admin blues and grays.
props hugobaeta.
fixes #31234.

Built from https://develop.svn.wordpress.org/trunk@32051


git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 21:20:27 +00:00
Helen Hou-Sandí 0d870b2d4e Toolbar: Protect against Firefox font rendering interference by themes.
props cbaldelomar.
fixes #30021.

Built from https://develop.svn.wordpress.org/trunk@31824


git-svn-id: http://core.svn.wordpress.org/trunk@31806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 22:04:27 +00:00
Helen Hou-Sandí bcda24004a Update the default admin color scheme for more unity and refinement.
This removes the red channel from blues and cools the grays a bit for a more cohesive and purposeful color scheme.

props hugobaeta.
fixes #31234.

Built from https://develop.svn.wordpress.org/trunk@31422


git-svn-id: http://core.svn.wordpress.org/trunk@31403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 22:18:26 +00:00
Andrew Ozz 1e9f5755aa Admin toolbar: remove unneeded overrides of `z-index` and `left` on screens narrower than 782px. Props avryl, babbardel. Fixes #29867.
Built from https://develop.svn.wordpress.org/trunk@30764


git-svn-id: http://core.svn.wordpress.org/trunk@30754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 03:01:24 +00:00
Dominik Schilling c2d9591122 Toolbar: Make Customize support classes work on narrow viewports too.
fixes #30571.
Built from https://develop.svn.wordpress.org/trunk@30713


git-svn-id: http://core.svn.wordpress.org/trunk@30703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 22:01:26 +00:00
John Blackbourn a5fa87325b Don't fix the position of the admin toolbar submenus when the viewport is below 600px. This avoids them becoming detached from the admin toolbar when scrolling.
Fixes #29905
Props avryl

Built from https://develop.svn.wordpress.org/trunk@30706


git-svn-id: http://core.svn.wordpress.org/trunk@30696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 06:49:22 +00:00
Helen Hou-Sandí 06201646c3 Use a brighter blue against dark backgrounds in the admin menu and toolbar.
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.

props melchoyce. fixes #30323.

Built from https://develop.svn.wordpress.org/trunk@30313


git-svn-id: http://core.svn.wordpress.org/trunk@30312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 20:28:22 +00:00
Dominik Schilling de8961d631 Update the versions of several devDependencies in `package.json`.
Run `npm update` in the project root to receive updates.

props mjbanks, jorbin, netweb.
see #27340.
Built from https://develop.svn.wordpress.org/trunk@29270


git-svn-id: http://core.svn.wordpress.org/trunk@29052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:41:44 +00:00
Helen Hou-Sandí 2f399f18b7 Remove a toolbar CSS hack for a Chrome bug that no longer appears to exist. props avryl. fixes #28606. see #18868.
Built from https://develop.svn.wordpress.org/trunk@28981


git-svn-id: http://core.svn.wordpress.org/trunk@28770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 20:20:15 +00:00
Helen Hou-Sandí 3f1deae10b Don't use the box shadow focus styling for the admin menu or toolbar. see #28267.
Built from https://develop.svn.wordpress.org/trunk@28616


git-svn-id: http://core.svn.wordpress.org/trunk@28440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-29 14:23:15 +00:00
Sergey Biryukov e269d48b99 Display Dashboard icon instead of the home icon in toolbar when the link leads to Dashboard.
props ghost1227.
fixes #26754.
Built from https://develop.svn.wordpress.org/trunk@28599


git-svn-id: http://core.svn.wordpress.org/trunk@28424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-28 13:42:14 +00:00
Andrew Nacin 11c3695c77 Dev/build tools: Use grunt-autoprefixer for CSS vendor prefixes.
We'll be using it for two distinct tasks:
 * Core CSS files will keep prefixes. `grunt autoprefixer:core` will update files directly in src/ as a pre-commit step, rather than doing it on build.
 * Color CSS files will receive prefixes when they are built.

This commit:
 * Adds prefixes we were missing to core CSS.
 * Removes prefixes that we no longer need from core CSS.
 * Removes all prefixes from colors CSS.

props ocean90.
fixes #27078.

Built from https://develop.svn.wordpress.org/trunk@27174


git-svn-id: http://core.svn.wordpress.org/trunk@27038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-13 08:30:17 +00:00
Scott Taylor 0347a8944e Update the versions of several `devDependencies` in `package.json`. `grunt-cssjanus` has been updated to `0.2.2`, we no longer need the fork. Run `npm install` to receive updates for `node_modules` in the project root.
Props yoavf, TobiasBg.
Fixes #26073.


Built from https://develop.svn.wordpress.org/trunk@27053


git-svn-id: http://core.svn.wordpress.org/trunk@26927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 04:43:30 +00:00
Matt Thomas 7d002a5e84 Responsive improvements to submenus in the adminbar:
- Remove .ab-sub-wrapper rules in the 782px media query, as they're duplicates of the rules set on line 161.
- Reposition the arrows for submenus at responsive sizes where the menus are taller.
- Set the submenu position to static at smartphone sizes, so it's not positioned outside of its parent (and thus offscreen).

Fixes #26720, props undergroundnetwork, iammattthomas.



Built from https://develop.svn.wordpress.org/trunk@27006


git-svn-id: http://core.svn.wordpress.org/trunk@26883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:38:24 +00:00
Dominik Schilling dea41019ef Dashicons: Update to the latest dashicons files.
props empireoflight, melchoyce.
see #26518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26925


git-svn-id: http://core.svn.wordpress.org/trunk@26806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 22:26:10 +00:00
Andrew Nacin ee5fec7c6c Adjust widths of toolbar items at mobile sizes for better fitting on narrow screens. Fixes toolbar wrapping when using multisite.
props iammattthomas.
see #26537 for trunk.

Built from https://develop.svn.wordpress.org/trunk@26920


git-svn-id: http://core.svn.wordpress.org/trunk@26801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 21:24:12 +00:00
Andrew Ozz 448a401f77 Make older mobile browsers and IE7 usable:
- Text labels in the toolbar.
- Image icons in the visual editor.
- Some IE7 structural css fixes.
Fixes #26369.
Built from https://develop.svn.wordpress.org/trunk@26819


git-svn-id: http://core.svn.wordpress.org/trunk@26706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 02:41:10 +00:00
Andrew Nacin 1154c059ef RTL font-family overrides. (Tahoma generally, and Arial for Hebrew.)
props yoavf.
fixes #24977.

Built from https://develop.svn.wordpress.org/trunk@26816


git-svn-id: http://core.svn.wordpress.org/trunk@26703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 01:31:11 +00:00
Matt Thomas 4d48df2d58 Change the site menu icon from a globe to home, which is a better metaphor for what it does. Fixes #25971.
Built from https://develop.svn.wordpress.org/trunk@26812


git-svn-id: http://core.svn.wordpress.org/trunk@26699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 00:41:09 +00:00
Matt Thomas 01b1a66317 Make the padding added for top-level toolbar items in r26675 more specific and reinstate the previous 10px padding for links within dropdown menus. Fixes #26484.
Built from https://develop.svn.wordpress.org/trunk@26808


git-svn-id: http://core.svn.wordpress.org/trunk@26695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-08 20:44:10 +00:00
Andrew Ozz f7c176ca46 Toolbar:
- Fix submenus in responsive mode (were ignoring the .hover class on a parent).
- Improve top level items hiding.
Fixes #26476.
Built from https://develop.svn.wordpress.org/trunk@26803


git-svn-id: http://core.svn.wordpress.org/trunk@26690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-08 17:15:11 +00:00
Matt Thomas 4d1b5e1c32 Comment out these touch-related styles as they break toolbar dropdowns in Chrome for Android. Fixes #25972.
Built from https://develop.svn.wordpress.org/trunk@26770


git-svn-id: http://core.svn.wordpress.org/trunk@26658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 04:59:13 +00:00
Matt Thomas 03ab0cc95f Provide a default generic avatar icon in the My Account menu if avatars are disabled, ensuring that the link is visible at responsive sizes. See #25858.
Built from https://develop.svn.wordpress.org/trunk@26744


git-svn-id: http://core.svn.wordpress.org/trunk@26633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 21:23:10 +00:00
Matt Thomas c74da427f4 Add new fit-content rules to accompany intrinsic width on adminbar dropdown wrappers. Fixes #26430, props Jayjdk.
Built from https://develop.svn.wordpress.org/trunk@26735


git-svn-id: http://core.svn.wordpress.org/trunk@26624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:16:10 +00:00