Commit Graph

16278 Commits

Author SHA1 Message Date
Scott Taylor cb3ef90d24 Protect `<pre>` tags when parsing oEmbed responses in `WP_oEmbed::_strip_newlines()` in `DOMDocument` is available.
Fixes #31214.

Built from https://develop.svn.wordpress.org/trunk@31415


git-svn-id: http://core.svn.wordpress.org/trunk@31396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 19:11:27 +00:00
John Blackbourn 4d12ccadd8 Add `$expiration` as a parameter to the `pre_set_transient_{$transient}` filter.
Props mgibbs189
Fixes #30576

Built from https://develop.svn.wordpress.org/trunk@31414


git-svn-id: http://core.svn.wordpress.org/trunk@31395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 17:12:26 +00:00
Scott Taylor cd4fc46cf2 oEmbed discovery fails on encoded link URLs: decode HTML chars in the HTML-encoded URLs that are returned.
Props cweiske.
Fixes #31213.

Built from https://develop.svn.wordpress.org/trunk@31413


git-svn-id: http://core.svn.wordpress.org/trunk@31394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 16:13:26 +00:00
Sergey Biryukov 7ff18dae4e Add `.comment-reply-login` class to `get_post_reply_link()`, for consistency with `get_comment_reply_link()`.
props johnjamesjacoby.
fixes #31298.
Built from https://develop.svn.wordpress.org/trunk@31412


git-svn-id: http://core.svn.wordpress.org/trunk@31393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 16:11:28 +00:00
Sergey Biryukov 491ecc4c1c Use `require_once()` to prevent a fatal error if `_wp_admin_bar_init()` is called twice.
props danielbachhuber.
fixes #31287.
Built from https://develop.svn.wordpress.org/trunk@31411


git-svn-id: http://core.svn.wordpress.org/trunk@31392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 15:59:26 +00:00
Gary Pendergast daf711a338 Shiny Updates: Replace `$.post()` calls with `wp.ajax.post()`, and clean up a bunch of the now unnecessary code.
See #29820


Built from https://develop.svn.wordpress.org/trunk@31409


git-svn-id: http://core.svn.wordpress.org/trunk@31390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 05:06:28 +00:00
Sergey Biryukov 97698eb127 Always pass back the custom classes `get_post_class()` was called with, even if the post was not found.
props F J Kaiser, Bueltge.
fixes #22271.
Built from https://develop.svn.wordpress.org/trunk@31408


git-svn-id: http://core.svn.wordpress.org/trunk@31389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 04:00:26 +00:00
Scott Taylor 3cd585a457 oEmbed discovery fails on XHTML head links, adjust the regex to not match `/`.
Props cweiske.
Fixes #31212.

Built from https://develop.svn.wordpress.org/trunk@31407


git-svn-id: http://core.svn.wordpress.org/trunk@31388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 23:37:28 +00:00
Scott Taylor 64e19e98a3 Use `Math.round()` instead of `Math.floor()` when determining page of attachments to query in `wp.media.model.Query.sync`.
This was causing an infinite loop of AJAX requests - so.... good catch!

Props Veritaserum.
Fixes #31116.

Built from https://develop.svn.wordpress.org/trunk@31406


git-svn-id: http://core.svn.wordpress.org/trunk@31387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 22:54:28 +00:00
Scott Taylor 6cb16f7a21 Remove unused media JS files.
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31405


git-svn-id: http://core.svn.wordpress.org/trunk@31386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 22:45:28 +00:00
Sergey Biryukov 0e65ae6176 Remove redundant string with a typo introduced in [25481].
see #31217.
Built from https://develop.svn.wordpress.org/trunk@31404


git-svn-id: http://core.svn.wordpress.org/trunk@31385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 07:53:28 +00:00
Sergey Biryukov 12f4004989 Replace generic "Dear user" greeting in email notifications with a more personalized one.
props Ipstenu.
fixes #31217.
Built from https://develop.svn.wordpress.org/trunk@31403


git-svn-id: http://core.svn.wordpress.org/trunk@31384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 07:47:27 +00:00
Sergey Biryukov 973d157615 Switch to a string placeholder, as `number_format_i18n()` returns a string.
see #26553.
Built from https://develop.svn.wordpress.org/trunk@31402


git-svn-id: http://core.svn.wordpress.org/trunk@31383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 05:45:28 +00:00
Sergey Biryukov fdfd15aacc Use `_n()` in `comments_popup_link()` when setting the default string to display if there are more than one comment.
see #26553.
Built from https://develop.svn.wordpress.org/trunk@31401


git-svn-id: http://core.svn.wordpress.org/trunk@31382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 02:51:28 +00:00
Sergey Biryukov f166a51809 Update body class when switching between admin color schemes.
props valendesigns.
fixes #30488.
Built from https://develop.svn.wordpress.org/trunk@31400


git-svn-id: http://core.svn.wordpress.org/trunk@31381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 02:23:28 +00:00
Sergey Biryukov 65e1a767c4 Set svn:eol-style for [31373].
see #28510.
Built from https://develop.svn.wordpress.org/trunk@31399


git-svn-id: http://core.svn.wordpress.org/trunk@31380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 02:13:28 +00:00
Scott Taylor 1235221921 Export the proper class in `media/views/image-details.js`
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31393


git-svn-id: http://core.svn.wordpress.org/trunk@31374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 23:46:28 +00:00
Boone Gorges 72f18cb067 Don't parse empty 'tax_input' keys in `edit_post()`.
This fixes a bug introduced in [31359] where saving a tax_input that contained
only whitespace would result in a random tag being erroneously added to the
post.

See #30615.
Built from https://develop.svn.wordpress.org/trunk@31392


git-svn-id: http://core.svn.wordpress.org/trunk@31373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 22:54:28 +00:00
Gary Pendergast 980668299c WPDB: When checking to see if we can use utf8mb4, we also need to make sure PHP's MySQL client library is capable of using utf8mb4.
See #21212


Built from https://develop.svn.wordpress.org/trunk@31391


git-svn-id: http://core.svn.wordpress.org/trunk@31372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 22:28:28 +00:00
John Blackbourn 93fced2d15 Revert [30696] pending further investigation.
See #31011, #13071

Built from https://develop.svn.wordpress.org/trunk@31390


git-svn-id: http://core.svn.wordpress.org/trunk@31371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 21:50:29 +00:00
Aaron Jorbin c99149419d Add translator comments for new strings.
These strings were added in [31388].

Props ocean90.
Fixes 26553.


Built from https://develop.svn.wordpress.org/trunk@31389


git-svn-id: http://core.svn.wordpress.org/trunk@31370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 20:15:27 +00:00
Aaron Jorbin 4f08e9d383 Use screen reader text instead of a title attribute in comments_popup_link
To better understand screen reader text, check out https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/

Screen Reader text improves the user experience for screen reader users. It provides additional context for links, document forms and other pieces of a page that may exist visually, but are lost when looking only at the html of a site.  This does change the output of comments_popup_link if you don't pass in values for $zero, $one, $more or $none. Theme authors can and should style <code>.screen-reader-text</code> in ways that are recommended in the above article to hide it visually.

Props joedolson
Fixes #26553




Built from https://develop.svn.wordpress.org/trunk@31388


git-svn-id: http://core.svn.wordpress.org/trunk@31369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 19:27:28 +00:00
Scott Taylor 586ff8676a After [31386], this needs to happen in `audio-video.manifest.js`.
See #31058.

Built from https://develop.svn.wordpress.org/trunk@31387


git-svn-id: http://core.svn.wordpress.org/trunk@31368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 18:45:26 +00:00
Scott Taylor afa3a03ff8 Avoid an IE8 JS error when removing a MediaElement player.
Props afercia.
Fixes #31058.

Built from https://develop.svn.wordpress.org/trunk@31386


git-svn-id: http://core.svn.wordpress.org/trunk@31367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 18:43:27 +00:00
Scott Taylor b191013198 Media JS files:
* In media manifests, ditch IIFEs and global injection, these get dynamically scoped via Browserify
* Remove the `debug` option from `browserify:media`
* Add `jshint:media` to `jshint:corejs`
* Add a trailing newline to all new module files

Props iseulde.
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31385


git-svn-id: http://core.svn.wordpress.org/trunk@31366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 16:01:29 +00:00
Dominik Schilling 941075c8ca Improve the Customize experience on mobile.
Before: https://make.wordpress.org/flow/2015/02/02/a-peek-at-the-customizer-on-an-iphone-6/
After: https://make.wordpress.org/flow/2015/02/03/vizrec-for-28784-improve-the-customize-experience-on-mobile-iphone-6-28784-diff-4-2-alpha-31325/

props celloexpressions.
see #28784.
Built from https://develop.svn.wordpress.org/trunk@31384


git-svn-id: http://core.svn.wordpress.org/trunk@31365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 12:36:28 +00:00
Dion Hulse 502515974c Updates: Display plugin update rows even for plugins which are not hosted by WordPress.org or the HTTP request times out on.
See #29583.
Fixes #30767 for trunk.

Built from https://develop.svn.wordpress.org/trunk@31382


git-svn-id: http://core.svn.wordpress.org/trunk@31363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 06:32:26 +00:00
Drew Jaynes 947d04f323 Improve return and parameter documentation for `check_admin_referer()`, `check_ajax_referer()`, and `wp_verify_nonce()`.
Also update and clarify docsfor the `check_admin_referer` and `check_ajax_referer` hooks.

Props johnbillion, DrewAPicture.
Fixes #31055.

Built from https://develop.svn.wordpress.org/trunk@31381


git-svn-id: http://core.svn.wordpress.org/trunk@31362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 04:57:27 +00:00
Scott Taylor ef12a2cc8c Bind `this` at calltime instead of letting `self` spill down into closures.
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31380


git-svn-id: http://core.svn.wordpress.org/trunk@31361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 04:45:28 +00:00
Scott Taylor 308ae4c887 Make sure that `media/views.js` doesn't load Models that already exist in `media/models.js`.
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31379


git-svn-id: http://core.svn.wordpress.org/trunk@31360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 04:14:26 +00:00
Gary Pendergast 04a0e21734 WPDB: The `mysqli_query()` call in `wpdb::set_charset()` had the parameters the wrong way around.
Built from https://develop.svn.wordpress.org/trunk@31374


git-svn-id: http://core.svn.wordpress.org/trunk@31355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 01:26:29 +00:00
Scott Taylor d568679946 Split the media JS files into modules:
* Add a new folder in `wp-includes/js`, `media`
* Create manifest files for `views`, `models`, `grid`, and `audio-video`
* Make `browserify` an `npm` dependency
* Add Grunt tasks for `browserify` and `uglify:media` on `build` and `watch`
* Update the paths loaded for media files in `script-loader`
* All new files were created using `svn cp` from their original location

Please run `npm install`. While developing media JS, you must run `grunt watch`.

See #28510.

Built from https://develop.svn.wordpress.org/trunk@31373


git-svn-id: http://core.svn.wordpress.org/trunk@31354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 00:43:50 +00:00
Gary Pendergast 66af41688c WPDB: Some character set tests were failing if `DB_CHARSET` was empty, or a non-utf8 character set.
Built from https://develop.svn.wordpress.org/trunk@31372


git-svn-id: http://core.svn.wordpress.org/trunk@31353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 00:39:22 +00:00
Gary Pendergast 55742904c0 WPDB: When we're removing invalid text text from strings with multiple different character sets, `wpdb::strip_invalid_text()` wasn't correctly switching connection character sets.
Fixes #31262


Built from https://develop.svn.wordpress.org/trunk@31371


git-svn-id: http://core.svn.wordpress.org/trunk@31352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 00:34:25 +00:00
Dominik Schilling 3aea5f144b Customizer: Introduce an API to create WP_Customize_Settings for dynamically-created settings.
* Introduce WP_Customize_Manager::add_dynamic_settings() to register dynamically-created settings.
* Introduce `customize_dynamic_setting_args` filter to pass an array of args to a dynamic setting's constructor.
* Add unit tests for WP_Customize_Manager and WP_Customize_Widgets.
* See WP_Customize_Widgets as an example.

props westonruter.
fixes #30936.
Built from https://develop.svn.wordpress.org/trunk@31370


git-svn-id: http://core.svn.wordpress.org/trunk@31351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-08 23:11:25 +00:00
Boone Gorges 17330354bc Add `orderby=meta_value_num` support to `WP_User_Query`.
Props tyxla, genkisan.
Fixes #27887.
Built from https://develop.svn.wordpress.org/trunk@31369


git-svn-id: http://core.svn.wordpress.org/trunk@31350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-08 16:59:22 +00:00
Sergey Biryukov 623981c8d6 Use a positive wording for translations update notice.
props DrewAPicture, siobhan, netweb.
fixes #28199.
Built from https://develop.svn.wordpress.org/trunk@31368


git-svn-id: http://core.svn.wordpress.org/trunk@31349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-08 04:09:22 +00:00
Boone Gorges 669fa39005 Late escaping in `get_terms()` and `WP_Tax_Query`.
Props vortfu, dd32.
Built from https://develop.svn.wordpress.org/trunk@31367


git-svn-id: http://core.svn.wordpress.org/trunk@31348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-08 01:59:24 +00:00
Boone Gorges 90639872e8 In `WP_Query::get_queried_object()`, avoid PHP notices when `is_tax` is paired with an empty `tax_query`.
It's possible to have an empty `tax_query` and `is_tax=true` when the initial
query contains a taxonomy var (and is processed as such during
`WP_Query::parse_query()`) but the taxonomy var is unset during a 'parse_query'
callback. While this kind of behavior is not necessarily something we need to
support, we should continue to avoid PHP notices in such cases, as we did prior
to WP 4.1.

Fixes #31246.
Built from https://develop.svn.wordpress.org/trunk@31366


git-svn-id: http://core.svn.wordpress.org/trunk@31347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-07 19:50:24 +00:00
Sergey Biryukov 09c1d34b96 Remove unnecessary `array_shift()` usage in `get_terms()` for better performance.
props bswatson, VolodymyrC.
fixes #31182.
Built from https://develop.svn.wordpress.org/trunk@31365


git-svn-id: http://core.svn.wordpress.org/trunk@31346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-07 19:45:25 +00:00
Sergey Biryukov 137204b033 In `_wp_menu_output()`, `$submenu_items` is an array and should be initialized as such.
props ipm-frommen.
fixes #31257.
Built from https://develop.svn.wordpress.org/trunk@31364


git-svn-id: http://core.svn.wordpress.org/trunk@31345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-07 17:57:24 +00:00
Sergey Biryukov 1e0905793c Avoid inadvertent stomping of the original `$args` parameter passed to `plugins_api_result` and `themes_api_result` filters in `plugins_api()` and `themes_api()`, respectively.
Fixes a regression introduced in [25956].

props Corphi, obenland.
fixes #29079.
Built from https://develop.svn.wordpress.org/trunk@31363


git-svn-id: http://core.svn.wordpress.org/trunk@31344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-07 06:21:22 +00:00
Andrew Ozz c8892dfaa2 TinyMCE: ensure the image toolbar stays visible when the image is much wider than the editor. Props iseulde, fixes #20696 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31362


git-svn-id: http://core.svn.wordpress.org/trunk@31343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 23:00:23 +00:00
Andrew Ozz c765424ad5 Editor: prevent errors in editor-expand when the Text editor is not used. Props iseulde, fixes #31163.
Built from https://develop.svn.wordpress.org/trunk@31361


git-svn-id: http://core.svn.wordpress.org/trunk@31342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 22:25:23 +00:00
Dominik Schilling 8fe95c9e65 Customizer: Add changelog entry for the 'default' parameter added in [31329].
props westonruter.
see #30988.
Built from https://develop.svn.wordpress.org/trunk@31360


git-svn-id: http://core.svn.wordpress.org/trunk@31341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 21:14:24 +00:00
Boone Gorges b9e661dcae Parse non-hierarchical tag input into term IDs before sending to `wp_insert_post()`.
When editing a post, non-hierarchical taxonomy terms are sent as the
comma-separated list entered into the tax_input metabox. Passing these
values directly to `wp_update_post()` meant that they were interpreted as
term slugs rather than term names, causing mismatches when a typed string
matched the slug of one term and the name of a different term. We fix the
problem by preprocessing tax_input data sent from post.php, converting it to
unambiguous term_ids before saving.

Props boonebgorges, ArminBraun.
Fixes #30615.
Built from https://develop.svn.wordpress.org/trunk@31359


git-svn-id: http://core.svn.wordpress.org/trunk@31340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 20:32:22 +00:00
Gary Pendergast d7c6ac95bc Upgrades: wp_usermeta is a global table in multisite, so it should only be upgraded by the single site routines when we're not in a multisite install.
See #21212


Built from https://develop.svn.wordpress.org/trunk@31358


git-svn-id: http://core.svn.wordpress.org/trunk@31339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 13:41:22 +00:00
Drew Jaynes e5a5992e2c Update the DocBlock for `wp_dropdown_categories()` to reflect that the entire `$args` parameter array is optional instead of individual arugments.
See #30306.

Built from https://develop.svn.wordpress.org/trunk@31357


git-svn-id: http://core.svn.wordpress.org/trunk@31338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 09:04:22 +00:00
Drew Jaynes 15eaa179df Adjust the DocBlock for `wp_dropdown_pages()` to mark the entire `$args` parameter array as optional instead of each individual argument.
See #12494.

Built from https://develop.svn.wordpress.org/trunk@31356


git-svn-id: http://core.svn.wordpress.org/trunk@31337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 08:56:23 +00:00
Drew Jaynes 19ba9e3715 Add documentation for the `$value_field` argument added to `wp_dropdown_pages()` in [31338].
See #12494.

Built from https://develop.svn.wordpress.org/trunk@31355


git-svn-id: http://core.svn.wordpress.org/trunk@31336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 08:51:23 +00:00
Gary Pendergast 7444799a82 Upgrades: When upgrading a table to utf8mb4, we should run the `ALTER TABLE` query, even if it doesn't have any text columns. This will update the table's default character set, so that any text columns added in the future will have the expected character set.
See #21212 


Built from https://develop.svn.wordpress.org/trunk@31354


git-svn-id: http://core.svn.wordpress.org/trunk@31335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 05:59:23 +00:00
Aaron Jorbin 8c362e1d8d Travis hates tabs.
Related [31352]

see #30755

Built from https://develop.svn.wordpress.org/trunk@31353


git-svn-id: http://core.svn.wordpress.org/trunk@31334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 05:58:23 +00:00
Aaron Jorbin e69b9b1dc5 Update Travis-ci Slack notification token
see #30755


Built from https://develop.svn.wordpress.org/trunk@31352


git-svn-id: http://core.svn.wordpress.org/trunk@31333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 05:52:23 +00:00
Gary Pendergast 555a9f0912 Upgrades: When deciding if we can upgrade a table to utf8mb4, make sure we're checking the character set, not the collation.
Bump the DB version as well, as the update in [31349] wouldn't have triggered for anyone who tried it.

See #21212


Built from https://develop.svn.wordpress.org/trunk@31351


git-svn-id: http://core.svn.wordpress.org/trunk@31332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 05:26:21 +00:00
Aaron Jorbin 13fcbb5706 Temporarily (I hope) remove PHP 5.2 from tests being run on travis-ci
Travis-ci has disabled PHP 5.2. This has happened before when 5.2 didn't compile and then was restored when that was fixed.

upstream: https://github.com/travis-ci/travis-ci/issues/3152
related: https://github.com/WP-API/WP-API/issues/846

See #31244.


Built from https://develop.svn.wordpress.org/trunk@31350


git-svn-id: http://core.svn.wordpress.org/trunk@31331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 05:14:21 +00:00
Gary Pendergast b2cf823105 WPDB: If a site is using the `utf8` charset, and their version of MySQL supports `utf8mb4`, auto-upgrade them to `utf8mb4`.
This patch also resizes some indexes, to allow for the 767 byte index size limit in standard MySQL installs.

See #21212


Built from https://develop.svn.wordpress.org/trunk@31349


git-svn-id: http://core.svn.wordpress.org/trunk@31330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 04:51:22 +00:00
Andrew Nacin fd70baf919 Remove leading space from the definition of a global cache group.
This only applied in a rare situation during the switch_to_blog() process where no global groups were currently defined.

see #31243.

Built from https://develop.svn.wordpress.org/trunk@31348


git-svn-id: http://core.svn.wordpress.org/trunk@31329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 03:26:22 +00:00
Andrew Nacin 116d1d354e Add useremail and userslugs as global cache groups. fixes #31243.
Built from https://develop.svn.wordpress.org/trunk@31347


git-svn-id: http://core.svn.wordpress.org/trunk@31328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 03:24:23 +00:00
Boone Gorges 7560f446f9 Use field-specific sanitization in `WP_Tax_Query::transform_query()`.
When terms are entered into the database, term fields are sanitized with
`sanitize_term_field()`. To ensure that the `SELECT ... WHERE` queries in
`WP_Tax_Query::transform_query()` are not broken by overzealous sanitization,
`sanitize_term_field()` should be used in that case as well. This fixes a bug
where a tax_query using 'field=name' would fail if the 'terms' parameter
contained characters (like spaces) that were improperly removed by
`sanitize_title_for_query()`.

Fixes #27810.
Built from https://develop.svn.wordpress.org/trunk@31346


git-svn-id: http://core.svn.wordpress.org/trunk@31327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 02:02:23 +00:00
Gary Pendergast 5e4d135411 Shiny Updates: Fix a PHP warning when installing new plugins.
Props lgladdy for the initial patch.

See #29820


Built from https://develop.svn.wordpress.org/trunk@31345


git-svn-id: http://core.svn.wordpress.org/trunk@31326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 00:34:21 +00:00
Boone Gorges 4169032f6f Use minified jquery-ui-core file during qunit:compiled Grunt task.
[30989] made jQuery UI Core a dependency for QUnit tests. This change did not
account for the fact that jQuery JS assets are minimized (and non-minimized
versions unavailable) when `grunt copy` populates the `/build` directory. To
ensure that QUnit tests pass when run during `grunt qunit:compiled`, we
manually fix the asset path to read 'core.min.js'.

See #25781.
Built from https://develop.svn.wordpress.org/trunk@31344


git-svn-id: http://core.svn.wordpress.org/trunk@31325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 20:36:22 +00:00
Helen Hou-Sandí fa053ea65b MCE views: Always refresh the view after updating a gallery.
This allows things like caption changes to be synced, as they are tied to the attachment and not the shortcode.

props iseulde.
fixes #31239.

Built from https://develop.svn.wordpress.org/trunk@31343


git-svn-id: http://core.svn.wordpress.org/trunk@31324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 20:12:22 +00:00
Boone Gorges 6c45fe1cac Another array syntax fix for Customizer tests.
See [31339], #30988.
Built from https://develop.svn.wordpress.org/trunk@31342


git-svn-id: http://core.svn.wordpress.org/trunk@31323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:55:23 +00:00
Boone Gorges 69504de9d8 jshint fixes for shiny updates JS.
As introduced in [31333].

Props iseulde.
See #29820.
Built from https://develop.svn.wordpress.org/trunk@31341


git-svn-id: http://core.svn.wordpress.org/trunk@31322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:52:22 +00:00
Boone Gorges 7bde88d02e Modify `meta_query orderby syntax to use array keys as clause "handles".
The implementation of `meta_query` orderby introduced in [31312] put clause
identifiers into a 'name' parameter of the clause. For greater clarity, this
changeset updates the syntax to use the associative array key used when
defining `meta_query` parameters, instead of the 'name' parameter.

Props Funkatronic, DrewAPicture.
Fixes #31045.
Built from https://develop.svn.wordpress.org/trunk@31340


git-svn-id: http://core.svn.wordpress.org/trunk@31321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:38:23 +00:00
Boone Gorges a8f8813e83 Use temporary variable for array in `Tests_Customize_Setting::test_preview_standard_types_multidimensional()`.
The syntax previously used - `call_user_func( 'foo' )['bar']`, where `foo()`
returns an array - is not valid on all supported versions of PHP, and was
breaking the CI builds.

See #30988.
Built from https://develop.svn.wordpress.org/trunk@31339


git-svn-id: http://core.svn.wordpress.org/trunk@31320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:19:23 +00:00
Boone Gorges 14767d6c69 Introduce `'value_field'` parameter to `wp_dropdown_pages()`.
This parameter allows developers to choose the post field that will be used to
fill in the 'option' attribute of the generated dropdown markup.

See [31006] #30306 for a parallel enhancement in `wp_dropdown_categories()`.

Props jfarthing84.
Fixes #12494.
Built from https://develop.svn.wordpress.org/trunk@31338


git-svn-id: http://core.svn.wordpress.org/trunk@31319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:04:23 +00:00
Boone Gorges d1764d86e4 Use hash notation for `wp_dropdown_pages()` argument documentation.
Built from https://develop.svn.wordpress.org/trunk@31337


git-svn-id: http://core.svn.wordpress.org/trunk@31318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:00:25 +00:00
Drew Jaynes 10eb2173c0 Clarify inline documentation for `WP_Date_Query` to better explain the relationship between an individual clause's 'compare' argument and various integer-based date arguments.
If the 'compare' argument equals 'IN' or 'NOT IN', arrays of any number of specific, valid values are accepted and simply considered based on the value of 'operator' (OR or AND). If the 'compare' argument is a range such as 'BETWEEN' or 'NOT BETWEEN', arrays of only two valid values are accepted.
 
Props boonebgorges.
Fixes #31036.

Built from https://develop.svn.wordpress.org/trunk@31336


git-svn-id: http://core.svn.wordpress.org/trunk@31317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 06:17:21 +00:00
Gary Pendergast 27aa3e92d7 Shiny Updates: If the current user is not allowed to install/update plugins, we should return a JSON error, so it can be used by the JS handlers.
See #29820


Built from https://develop.svn.wordpress.org/trunk@31335


git-svn-id: http://core.svn.wordpress.org/trunk@31316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 06:16:23 +00:00
Gary Pendergast b7926a518a Shiny Updates: Add capability checks to the ajax callbacks, to ensure the current user is allowed to install/update plugins.
See #29820


Built from https://develop.svn.wordpress.org/trunk@31334


git-svn-id: http://core.svn.wordpress.org/trunk@31315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 06:05:22 +00:00
Gary Pendergast 9c69213f2b Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
This also includes JS architecture that can be expanded to support theme, core and language pack updates.

Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture

See #29820


Built from https://develop.svn.wordpress.org/trunk@31333


git-svn-id: http://core.svn.wordpress.org/trunk@31314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 04:19:23 +00:00
Andrew Ozz f13cb317a4 Fix displaying long tag names in the Tags postbox. Props trishasalas, carolinegeven, iseulde. Fixes #18946.
Built from https://develop.svn.wordpress.org/trunk@31332


git-svn-id: http://core.svn.wordpress.org/trunk@31313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-04 22:15:25 +00:00
Helen Hou-Sandí 62e65c3a35 Accessibility: remove remaining instances of accesskey.
It is a poorly implemented browser feature, not particularly discoverable, and causes more problems than it helps solve.

props afercia.
fixes #29715.

Built from https://develop.svn.wordpress.org/trunk@31331


git-svn-id: http://core.svn.wordpress.org/trunk@31312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-04 03:46:24 +00:00
Helen Hou-Sandí 641f767fd9 Themes: Allow version number in the overlay to be selected.
props johneckman.
fixes #31205.

Built from https://develop.svn.wordpress.org/trunk@31330


git-svn-id: http://core.svn.wordpress.org/trunk@31311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 15:15:25 +00:00
Dominik Schilling 9d162f0945 Ensure that `WP_Customize_Setting::value()` returns default value for setting if not dirty.
There was regression introduced by #28580 where only changed (dirty) settings now are POST'ed to the Customizer preview.

* Allow WP_Customize_Manager::post_value() to accept a second $default argument.
* Introduce WP_Customize_Manager::unsanitized_post_values() for accessing previously-private member variable _post_values.
* Do require_once instead of require for Customizer classes.
* Add unit tests for WP_Customize_Manager and WP_Customize_Setting.

props westonruter.
fixes #30988.
Built from https://develop.svn.wordpress.org/trunk@31329


git-svn-id: http://core.svn.wordpress.org/trunk@31310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 10:15:21 +00:00
Dion Hulse 121f83ab39 Remove an extra indent from most of media-new.php.
Built from https://develop.svn.wordpress.org/trunk@31328


git-svn-id: http://core.svn.wordpress.org/trunk@31309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 07:47:22 +00:00
Dion Hulse e8f032c747 WP_Upgrader: Remove references to non-existant variables that have never existed.
Props jdgrimes. Fixes  #29087

Built from https://develop.svn.wordpress.org/trunk@31327


git-svn-id: http://core.svn.wordpress.org/trunk@31308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 06:18:24 +00:00
Dion Hulse 92cb5936f1 Remove an unused parameter on install_plugins_upload().
Props michalzuber. Fixes #28964

Built from https://develop.svn.wordpress.org/trunk@31326


git-svn-id: http://core.svn.wordpress.org/trunk@31307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 06:14:22 +00:00
Sergey Biryukov 7690d9b1aa Add `'widget_nav_menu_args'` filter for Custom Menu widget arguments.
props cyman, DrewAPicture.
fixes #29463.
Built from https://develop.svn.wordpress.org/trunk@31325


git-svn-id: http://core.svn.wordpress.org/trunk@31306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 02:56:23 +00:00
Sergey Biryukov 7c97e59ed6 When using WP_Query's `'fields' => 'ids'` (or `'fields' => 'id=>parent'`), make sure the returned result is always an array of integers.
fixes #31194. see #27252.
Built from https://develop.svn.wordpress.org/trunk@31324


git-svn-id: http://core.svn.wordpress.org/trunk@31305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 02:29:25 +00:00
Boone Gorges eec82f9330 In `get_sample_permalink()`, override 'future' status before generating permalink.
In [31114], `get_permalink()` was modified to prevent pretty permalinks from
being generated for posts with the 'future' post status. This inadvertently
broke the pretty permalink preview for scheduled posts. The fix is to include
the 'future' status in the list of statuses that `get_sample_permalink()` fakes
as 'publish' before it fetches a permalink.

Props DrewAPicture.
Fixes #30910.
Built from https://develop.svn.wordpress.org/trunk@31323


git-svn-id: http://core.svn.wordpress.org/trunk@31304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-02 16:50:22 +00:00
Dominik Schilling 628cec4f1a jQuery UI: Add `jquery-ui-core` as dependency for `jquery-ui-progressbar`.
props tyxla.
fixes #31208.
Built from https://develop.svn.wordpress.org/trunk@31322


git-svn-id: http://core.svn.wordpress.org/trunk@31303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-02 10:34:23 +00:00
Boone Gorges 55dafd966b When querying for a specific post, allow posts with a non-public status to be returned as long as that status is specified.
This makes it possible to, for example, retrieve a specific post using the
`p` parameter of `WP_Query`, even if the post is in the Trash, by including
the `post_status=trash` parameter.

Props ebinnion.
Fixes #29167.
Built from https://develop.svn.wordpress.org/trunk@31321


git-svn-id: http://core.svn.wordpress.org/trunk@31302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-01 20:26:25 +00:00
Sergey Biryukov a82763b7b6 Menus: Don't display "Move" text without direction if there is only one menu item.
props kucrut for initial patch.
fixes #30765.
Built from https://develop.svn.wordpress.org/trunk@31320


git-svn-id: http://core.svn.wordpress.org/trunk@31301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-01 05:29:26 +00:00
Dominik Schilling 5bc0c84c35 i18n tools: Sync makepot.php with i18n.svn.
fixes #31193.
Built from https://develop.svn.wordpress.org/trunk@31319


git-svn-id: http://core.svn.wordpress.org/trunk@31300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 22:02:23 +00:00
Sergey Biryukov f824de609d Reduce the size of the WordPress logo tap target on log in screen on mobile, to avoid unexpected redirect away from the form.
props mzak.
fixes #31185.
Built from https://develop.svn.wordpress.org/trunk@31318


git-svn-id: http://core.svn.wordpress.org/trunk@31299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 21:32:22 +00:00
Andrew Ozz 0a668f1586 Separate the tests for IE conditional comments support in WP_Scripts. Props valendesigns, see 16024.
Built from https://develop.svn.wordpress.org/trunk@31317


git-svn-id: http://core.svn.wordpress.org/trunk@31298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 20:41:22 +00:00
Sergey Biryukov 7d99c51b3b Themes: Remove a Chrome workaround that causes theme screenshots to look too crisp and no longer appears to be relevant.
props mzak.
fixes #26584.
Built from https://develop.svn.wordpress.org/trunk@31316


git-svn-id: http://core.svn.wordpress.org/trunk@31297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 20:39:25 +00:00
Dominik Schilling 9d227201eb i18n tools: Exclude wp-includes/class-pop3.php in wp_frontend().
The external library uses the underscore alias for the native gettext() function. Makepot extracts these strings too, which results in having 25 unused translations.

fixes #31179.
Built from https://develop.svn.wordpress.org/trunk@31315


git-svn-id: http://core.svn.wordpress.org/trunk@31296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 20:28:23 +00:00
Dominik Schilling befce33421 i18n tools: Tabs, not spaces for indentation.
Built from https://develop.svn.wordpress.org/trunk@31314


git-svn-id: http://core.svn.wordpress.org/trunk@31295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 19:52:23 +00:00
Boone Gorges f345a72c58 Prevent terms in a show_in_quick_edit=false taxonomy from being updated by a faked AJAX request.
The UI for these taxonomies was hidden in [31308], but it remained possible to
send a direct POST request to the `inline-edit` endpoint to bypass the
restriction. The current changeset fixes this.

Props meloniq.
Fixes #26948.
Built from https://develop.svn.wordpress.org/trunk@31313


git-svn-id: http://core.svn.wordpress.org/trunk@31294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 19:38:24 +00:00
Boone Gorges ca30c725a0 Improve support for ordering `WP_Query` results by postmeta.
`WP_Meta_Query` clauses now support a 'name' parameter. When building a
`WP_Query` object, the value of 'orderby' can reference this 'name', so that
it's possible to order by any clause in a meta_query, not just the first one
(as when using 'orderby=meta_value'). This improvement also makes it possible
to order by multiple meta query clauses (or by any other eligible field plus
a meta query clause), using the array syntax for 'orderby' introduced in [29027].

Props Funkatronic, boonebgorges.
Fixes #31045.
Built from https://develop.svn.wordpress.org/trunk@31312


git-svn-id: http://core.svn.wordpress.org/trunk@31293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 15:48:24 +00:00
Sergey Biryukov 3c416b8c87 Remove redundant parameter.
see #30753.
Built from https://develop.svn.wordpress.org/trunk@31311


git-svn-id: http://core.svn.wordpress.org/trunk@31292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 02:12:22 +00:00
Sergey Biryukov c17737b7ac Add a unit test that expects wp_parse_args() to treat `'true'` and `'false'` in a query string as strings.
props voldemortensen for initial patch.
see #30753.
Built from https://develop.svn.wordpress.org/trunk@31310


git-svn-id: http://core.svn.wordpress.org/trunk@31291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 02:02:23 +00:00
Drew Jaynes ac4aae99e6 Add changelog entries to the `post_gallery` and `post_playlist` hook docs for the `$instance` variable that was added in [31304].
Props ninnypants for the initial patch.
Fixes #31151.

Built from https://develop.svn.wordpress.org/trunk@31309


git-svn-id: http://core.svn.wordpress.org/trunk@31290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 00:33:22 +00:00
Boone Gorges e4f8d5e0bc Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases.
See #26948.
Built from https://develop.svn.wordpress.org/trunk@31308


git-svn-id: http://core.svn.wordpress.org/trunk@31289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 19:29:22 +00:00
Boone Gorges abce542e5f Introduce 'show_in_quick_edit' parameter for `register_taxonomy()`.
Setting 'show_in_quick_edit' to false when registering a custom taxonomy will
hide the taxonomy when editing posts using Quick Edit.

The new 'quick_edit_show_taxonomy' filter allows this behavior to be filtered
on a finer scale, as when you want a given taxonomy to be hidden for one post
type but not for others.

Props hlashbrooke.
Fixes #26948.
Built from https://develop.svn.wordpress.org/trunk@31307


git-svn-id: http://core.svn.wordpress.org/trunk@31288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 19:18:23 +00:00
Boone Gorges 9b0ee1c6f5 Introduce `setExpectedDeprecated()` and `setExpectedIncorrectUsage()` methods to `WP_UnitTestCase.
These methods provide a procedural alternative to the `@expectedDeprecated`
and `@expectedIncorrectUsage` test annotations, and parallel PHPUnit's native
`setExpectedException()`.

Props prasoon2211, jdgrimes.
Fixes #28486.
Built from https://develop.svn.wordpress.org/trunk@31306


git-svn-id: http://core.svn.wordpress.org/trunk@31287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 16:48:23 +00:00
Sergey Biryukov 5289e92ef5 Rename `$instances` to `$instance` in wp_audio_shortcode() and wp_video_shortcode() for consistency with gallery_shortcode() and wp_playlist_shortcode().
see #31151.
Built from https://develop.svn.wordpress.org/trunk@31305


git-svn-id: http://core.svn.wordpress.org/trunk@31286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 16:06:22 +00:00
Sergey Biryukov fa86f3ef9c Pass the current shortcode instance ID to `post_gallery` and `post_playlist` filters.
props justincwatt.
fixes #31151.
Built from https://develop.svn.wordpress.org/trunk@31304


git-svn-id: http://core.svn.wordpress.org/trunk@31285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 16:02:21 +00:00
Sergey Biryukov b05014805f Don't display the Help tab reference in Page Attributes meta box if Help tab was removed.
props bananastalktome.
fixes #31164.
Built from https://develop.svn.wordpress.org/trunk@31303


git-svn-id: http://core.svn.wordpress.org/trunk@31284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 15:34:24 +00:00
Boone Gorges eddf93639b In `get_adjacent_post()`, return private post if the current user has the capacity to read it.
This mirrors the check that happens post-query in `WP_Query`. See #30911.

Props bswatson.
Fixes #30287.
Built from https://develop.svn.wordpress.org/trunk@31302


git-svn-id: http://core.svn.wordpress.org/trunk@31283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 02:20:23 +00:00
Boone Gorges 1f51936d8c Add unit tests for 'show_option_all' behavior of `wp_list_categories()`.
See #21881.
Built from https://develop.svn.wordpress.org/trunk@31301


git-svn-id: http://core.svn.wordpress.org/trunk@31282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 01:40:23 +00:00
Sergey Biryukov 5ac0568ee3 Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
props tomdxw.
fixes #30927.
Built from https://develop.svn.wordpress.org/trunk@31300


git-svn-id: http://core.svn.wordpress.org/trunk@31281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 21:15:22 +00:00
Boone Gorges cf68b77790 Add tests for `get_category_parents()`.
See #30415.
Built from https://develop.svn.wordpress.org/trunk@31299


git-svn-id: http://core.svn.wordpress.org/trunk@31280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 20:49:26 +00:00
Dominik Schilling 72229b25c8 Add New User: Remove trailing whitespace from button labels.
fixes #31175.
Built from https://develop.svn.wordpress.org/trunk@31298


git-svn-id: http://core.svn.wordpress.org/trunk@31279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 14:54:21 +00:00
Drew Jaynes de1f0a0487 Avoid confusion by clarifying an inline comment on logic for performing multisite upgrades.
Props dmchale for the initial patch.
Fixes #30837.

Built from https://develop.svn.wordpress.org/trunk@31297


git-svn-id: http://core.svn.wordpress.org/trunk@31278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:53:21 +00:00
Drew Jaynes 9a17233ca1 Fix an inaccurate summary and description in the DocBlock for `wpmu_validate_user_signup()`.
Props ericlewis.
Fixes #31141.

Built from https://develop.svn.wordpress.org/trunk@31296


git-svn-id: http://core.svn.wordpress.org/trunk@31277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:46:22 +00:00
Drew Jaynes db993f6598 Add a missing description for the `$_diff_threshold` property in the `WP_Text_Diff_Renderer_Table` class.
Props ipm-frommen.
Fixes #31008.

Built from https://develop.svn.wordpress.org/trunk@31295


git-svn-id: http://core.svn.wordpress.org/trunk@31276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:36:22 +00:00
Drew Jaynes d7a51b3fc2 Add missing descriptions to the `$blogid` and `$siteid` property DocBlocks in the `wpdb` class.
Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31294


git-svn-id: http://core.svn.wordpress.org/trunk@31275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:35:22 +00:00
Drew Jaynes 0f20ecca9c Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/taxonomy.php.
Also adds a few missing parameter descriptions.

Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31293


git-svn-id: http://core.svn.wordpress.org/trunk@31274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:34:22 +00:00
Drew Jaynes f3033f34c6 Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/post.php
Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31292


git-svn-id: http://core.svn.wordpress.org/trunk@31273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:32:22 +00:00
Andrew Nacin 994b57a190 Update readme recommendations. fixes #31173.
Built from https://develop.svn.wordpress.org/trunk@31291


git-svn-id: http://core.svn.wordpress.org/trunk@31272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 05:10:22 +00:00
Dion Hulse 65e7885c01 HTTP API: Fix an issue where the `limit_response_size` parameter wasn't working properly with large documents and the cURL transport.
Fixes #31172

Built from https://develop.svn.wordpress.org/trunk@31290


git-svn-id: http://core.svn.wordpress.org/trunk@31271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 03:58:23 +00:00
Boone Gorges 78e5576ed8 Add basic unit tests for `get_page_of_comment()`.
See #11334.
Props jeremyfelt.
Built from https://develop.svn.wordpress.org/trunk@31289


git-svn-id: http://core.svn.wordpress.org/trunk@31270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 02:31:22 +00:00
Boone Gorges 8627216105 When updating the name a hierarchical term with Quick Edit, update the corresponding option in the Parent dropdown.
Props garyc40, rmarks.
Fixes #14565.
Built from https://develop.svn.wordpress.org/trunk@31288


git-svn-id: http://core.svn.wordpress.org/trunk@31269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 01:53:22 +00:00
Boone Gorges dcca015ffc Don't use term IDs for array indexes when caching object terms.
Uncached results pulled from `wp_get_object_terms()` are zero-indexed (ie 0,
1, 2...). As a result, `get_the_terms()` was returning a strictly different
array when pulling from the cache and when the cache was empty.

Props joshlevinson.
Fixes #31086.
Built from https://develop.svn.wordpress.org/trunk@31287


git-svn-id: http://core.svn.wordpress.org/trunk@31268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-28 20:43:23 +00:00
Boone Gorges 67d36f845d Improve organiation of tax_query and meta_query unit tests.
`meta_query` tests have been moved to `tests/phpunit/tests/query/metaQuery.php` and `tax_query` tests to `tests/phpunit/tests/query/taxQuery.php`. This is an improvement because (a) it better corresponds to the way that other `WP_Query` parameter tests are organized, (b) splitting meta and tax tests into separate classes simplifies the required `@group` annotations, and (c) the tests have nothing to do with posts per se, and so do not belong in the `post` subdirectory.

The tests previously found at `tests/phpunit/tests/query/taxQuery.php` have been moved to `isTerm.php` in the same directory. These tests are related to the `is_*` functions that have to do with taxonomy terms, like `is_category()`.

See #26999.
Built from https://develop.svn.wordpress.org/trunk@31286


git-svn-id: http://core.svn.wordpress.org/trunk@31267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-27 20:04:23 +00:00
Boone Gorges e199d2420f Ensure that 'hierarchical' is respected in `get_terms()` when multiple taxonomies are passed.
Previously, attempts to descend the family tree of each term were done using
the first taxonomy in the `$taxonomies` array, with the result that terms not
belonging to that taxonomy were not found and their children not properly
parsed. We fix this bug by fetching each term's taxonomy with the SQL query,
and then using that taxonomy to get the correct children for each term.

Fixes #31118.
Built from https://develop.svn.wordpress.org/trunk@31285


git-svn-id: http://core.svn.wordpress.org/trunk@31266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-26 19:04:21 +00:00
Boone Gorges af6e0f5c55 Ensure that 'pad_counts' is not discarded when the first of multiple taxonomies passed to `get_terms()` is non-hierarchical.
See #31118.
Built from https://develop.svn.wordpress.org/trunk@31284


git-svn-id: http://core.svn.wordpress.org/trunk@31265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-26 18:09:22 +00:00
Lance Willett cfba917080 Twenty Fifteen: move RSS icon style rule lower to prevent it from being overridden by other social icon rules.
Props iamtakashi, fixes #31129.

Built from https://develop.svn.wordpress.org/trunk@31283


git-svn-id: http://core.svn.wordpress.org/trunk@31264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-26 15:58:23 +00:00
Sergey Biryukov 5aadff88f6 Remove duplicate label on installation screen.
props Ankit K Gupta.
fixes #31131.
Built from https://develop.svn.wordpress.org/trunk@31282


git-svn-id: http://core.svn.wordpress.org/trunk@31263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 19:39:23 +00:00
Sergey Biryukov 98da858b40 Revert [30027]. These fields are already sufficiently labeled; duplicate labels can lead to confused behavior for screen readers.
see #31117, #30101.
Built from https://develop.svn.wordpress.org/trunk@31281


git-svn-id: http://core.svn.wordpress.org/trunk@31262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 18:33:22 +00:00
Boone Gorges 5bfab3becd Do not run certain cache-hit tests on multisite.
These tests fail on multisite if run after a test that creates
`wpmu_create_blog()`, because `wpmu_create_blog()` defines `WP_INSTALLING`,
which results in unexpected cache misses. See [28965] for a similar fix.
Built from https://develop.svn.wordpress.org/trunk@31280


git-svn-id: http://core.svn.wordpress.org/trunk@31261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 12:59:23 +00:00
Sergey Biryukov 53a704a67a Fix a typo in [30138].
see #30224.
Built from https://develop.svn.wordpress.org/trunk@31279


git-svn-id: http://core.svn.wordpress.org/trunk@31260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 09:48:21 +00:00
Andrew Nacin 1b8f71041b Allow $autoload in add_option() to receive false.
props dllh.
fixes #31119.

Built from https://develop.svn.wordpress.org/trunk@31278


git-svn-id: http://core.svn.wordpress.org/trunk@31259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 07:51:23 +00:00
Boone Gorges 4b8277237f In `Tests_Ajax_ReplytoComment::test_blocked_comment()`, don't stop blocking comments until test is complete.
The test uses the `_block_comments()` method to prevent comment inserts from
happening. Since [31263], failed comment inserts lead to the comment content's
being stripped of invalid characters and inserted again. By immediately
unhooking itself after first being run, `_block_comments()` was causing the
INSERT block to work only for the first attempt, while the second attempt was
going through, causing the test to fail. As a fix, we move the
`remove_filter()` call to the class's `tearDown()` method - sufficient for
cleanup, but late enough that *all* comment inserts will be blocked for the
test method in question.

See #21212.
Since [31263], comment INSERT queries that were pseudo-bl
Built from https://develop.svn.wordpress.org/trunk@31277


git-svn-id: http://core.svn.wordpress.org/trunk@31258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 03:39:24 +00:00
Boone Gorges acef0e2dcc In `get_terms()`, check hierarchy for all `$taxonomies` before bailing early from 'parent' or 'child_of'.
There is a pre-check in `get_terms()` that prevents an unnecessary database
query if the 'parent' or 'child_of' parameter is not found in the cached term
hierarchy (since a term without an index in the hierarchy cache has no
descendants). Previously, only the first item in the `$taxonomies` array was
being checked, with the result that an empty array was being erroneously
returned in cases where the 'parent' or 'child_of' term is in a subsequent
taxonomy.

See #31118.
Built from https://develop.svn.wordpress.org/trunk@31276


git-svn-id: http://core.svn.wordpress.org/trunk@31257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 02:46:25 +00:00
Boone Gorges 43fceb39c0 Introduce 'childless' parameter to `get_terms()`.
This new parameter allows developers to limit queried terms to terminal nodes -
ie, those without any descendants.

As part of the improvement, some internal logic in `get_terms()` has been
consolidated. Parameters that resolve to a NOT IN clause containing term IDs
('exclude', 'exclude_tree', and 'childless') are now parsed into a single
"exclusions" array before the SQL clause is generated.

Props theMikeD, horike.
Fixes #29839.
Built from https://develop.svn.wordpress.org/trunk@31275


git-svn-id: http://core.svn.wordpress.org/trunk@31256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-24 18:48:23 +00:00
Sergey Biryukov 15fc97b1cf Quick Edit: Don't save the post if Enter is pressed on the Cancel link.
props afercia.
fixes #30345.
Built from https://develop.svn.wordpress.org/trunk@31274


git-svn-id: http://core.svn.wordpress.org/trunk@31255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-24 15:07:22 +00:00
Dominik Schilling ee417ec560 jQuery UI: Add missing dependencies for puff and scale effects.
see #31113.
Built from https://develop.svn.wordpress.org/trunk@31273


git-svn-id: http://core.svn.wordpress.org/trunk@31254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-23 22:39:23 +00:00
Aaron Jorbin a4a1273d3a Improve accessibility of nav menu locations form.
A couple of small tweaks to the nav menu locations form that make it friendlier to assistive technology.  These include:
 * labels for selects
 * better context for the "Edit" link.  We hide "edit" from screen readers and instead give them a phrase with context since they may not be able to take advantage of the visual context

Additionally, there are some minor css tweaks to improve the visual alignment of the rows.
We also remove duplicate IDs and use classes instead.

Props afercia.
fixes #31090.


Built from https://develop.svn.wordpress.org/trunk@31272


git-svn-id: http://core.svn.wordpress.org/trunk@31253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-23 18:18:26 +00:00
Boone Gorges 04216633b2 Add classes for custom taxonomy terms in `get_post_class()`.
Props sillybean.
Fixes #16223.
Built from https://develop.svn.wordpress.org/trunk@31271


git-svn-id: http://core.svn.wordpress.org/trunk@31252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-23 15:41:22 +00:00
Boone Gorges d45a650846 Introduce 'parent' parameter to `wp_get_object_terms()`.
Props mikeschinkel.
Fixes #15675.
Built from https://develop.svn.wordpress.org/trunk@31270


git-svn-id: http://core.svn.wordpress.org/trunk@31251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-23 14:57:22 +00:00
Sergey Biryukov a47a5a1779 In wp_update_user(), make sure $userdata['ID'] is set before using it.
props tyxla.
fixes #31097.
Built from https://develop.svn.wordpress.org/trunk@31269


git-svn-id: http://core.svn.wordpress.org/trunk@31250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 14:46:23 +00:00
Lance Willett 3982471a5c Twenty Eleven and Twelve: fill in support for `screen-reader-text` class.
Props obenland, fixes #31095.
Built from https://develop.svn.wordpress.org/trunk@31268


git-svn-id: http://core.svn.wordpress.org/trunk@31249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 00:56:22 +00:00
Lance Willett 87279ec9ea Twenty Eleven: fix indentation (spaces to tabs). See #29127.
Built from https://develop.svn.wordpress.org/trunk@31267


git-svn-id: http://core.svn.wordpress.org/trunk@31248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 00:44:22 +00:00
Lance Willett ff5628169e Twenty Ten: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31266


git-svn-id: http://core.svn.wordpress.org/trunk@31247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 00:42:44 +00:00
Lance Willett dcf53d5bbb Twenty Eleven: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31265


git-svn-id: http://core.svn.wordpress.org/trunk@31246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 00:42:23 +00:00
Gary Pendergast dc0f9e0079 Comments: When a comment fails to insert, remove invalid characters from the email and URL fields, too.
See [31263], #21212


Built from https://develop.svn.wordpress.org/trunk@31264


git-svn-id: http://core.svn.wordpress.org/trunk@31245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 23:18:22 +00:00
Gary Pendergast 8196266d26 Comments: When a comment fails to insert, remove any invalid characters and try again.
See #21212


Built from https://develop.svn.wordpress.org/trunk@31263


git-svn-id: http://core.svn.wordpress.org/trunk@31244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 23:04:23 +00:00
Lance Willett d9cda71f18 Twenty Twelve: more fixes for escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31262


git-svn-id: http://core.svn.wordpress.org/trunk@31243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 21:06:23 +00:00
Lance Willett 078de57052 Twenty Twelve: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31261


git-svn-id: http://core.svn.wordpress.org/trunk@31242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 21:00:21 +00:00
Lance Willett c25f0ae8f8 Twenty Thirteen: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31260


git-svn-id: http://core.svn.wordpress.org/trunk@31241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 20:49:22 +00:00
Boone Gorges 48ff8e7ab4 A few more wordpress.com https assets in unit tests.
See #31091.
Built from https://develop.svn.wordpress.org/trunk@31259


git-svn-id: http://core.svn.wordpress.org/trunk@31240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 18:58:23 +00:00
Boone Gorges a121f09d1c Use https URLs for wordpress.com assets in `Tests_HTTP_Functions`.
The http->https redirects were breaking some of the tests.

Fixes #31091.
Built from https://develop.svn.wordpress.org/trunk@31258


git-svn-id: http://core.svn.wordpress.org/trunk@31239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 18:44:23 +00:00
Boone Gorges b690195b0e Move GD-specific resize test to GD-specific resize test file.
This makes it so that we don't have to mark the test as skipped when running
through Imagick tests.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@31257


git-svn-id: http://core.svn.wordpress.org/trunk@31238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 18:28:22 +00:00
Boone Gorges cf4db26358 Remove skipped unit tests related to proposed `map_deep()`.
The tests have been added as a patch to #22300.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@31256


git-svn-id: http://core.svn.wordpress.org/trunk@31237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 17:58:22 +00:00
Dominik Schilling b4bb289b5d Customizer: Hide the reorder-widgets button when a widget area is empty.
props celloexpressions.
fixes #27787.
Built from https://develop.svn.wordpress.org/trunk@31255


git-svn-id: http://core.svn.wordpress.org/trunk@31236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 22:45:22 +00:00
Boone Gorges 81c0f75332 Remove `WP_Post_IDs_Iterator` tests.
The tests have been moved to a patch on the ticket where the class has been
proposed, #22435.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@31254


git-svn-id: http://core.svn.wordpress.org/trunk@31235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 22:00:23 +00:00
Boone Gorges be6048aed2 Remove skipped tests related to the proposed Export API.
These tests have been added as a patch to #22435.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@31253


git-svn-id: http://core.svn.wordpress.org/trunk@31234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 20:58:21 +00:00
Dominik Schilling 0c0675627b Customizer: If there's only one available sidebar, hide the move-widget button.
props celloexpressions.
fixes #30690.
Built from https://develop.svn.wordpress.org/trunk@31252


git-svn-id: http://core.svn.wordpress.org/trunk@31233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 20:36:21 +00:00
Boone Gorges 9059dc8e88 `WP_Date_Query` date validation should not fail for hour = 0.
Props ChriCo, tyxla.
Fixes #31067 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31251


git-svn-id: http://core.svn.wordpress.org/trunk@31232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 19:13:22 +00:00
Lance Willett 17f69a89d4 Twenty Fourteen: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31250


git-svn-id: http://core.svn.wordpress.org/trunk@31231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 19:03:23 +00:00
Gary Pendergast 109d87363d Texturize: Add "em" as a cockney term, so that "'em" is texturized with an apostrophe, instead of an open quote.
Fixes #29813.

Props miqrogroove.


Built from https://develop.svn.wordpress.org/trunk@31249


git-svn-id: http://core.svn.wordpress.org/trunk@31230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 18:44:26 +00:00
Boone Gorges 61f5f38dcd Better loop detection for `_pad_term_counts()`.
The `$ancestors` check must be reset for each term in order for term counts
to be correct.

Fixes #20635.
Built from https://develop.svn.wordpress.org/trunk@31248


git-svn-id: http://core.svn.wordpress.org/trunk@31229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 16:52:22 +00:00
Sergey Biryukov 067ee8c476 Remove inaccurate part of {$taxonomy}_add_form_fields action description.
props joostdekeijzer.
fixes #31052.
Built from https://develop.svn.wordpress.org/trunk@31247


git-svn-id: http://core.svn.wordpress.org/trunk@31228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 15:31:23 +00:00
Drew Jaynes d95586e943 Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php.
Also generally improve existing parameter, return, and other documentation in various function DocBlocks.

Props morganestes.
Fixes #30825.

Built from https://develop.svn.wordpress.org/trunk@31246


git-svn-id: http://core.svn.wordpress.org/trunk@31227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 09:15:22 +00:00
Drew Jaynes e0b3db1e09 Remove a stray period introduced in [31242].
Props SergeyBiryukov.
See #31048.

Built from https://develop.svn.wordpress.org/trunk@31245


git-svn-id: http://core.svn.wordpress.org/trunk@31226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:47:24 +00:00
Drew Jaynes d41e669efe Ensure the correct list of default tabs for the Plugin Install screen are documented.
Props stevenkword.
Fixes #31017.

Built from https://develop.svn.wordpress.org/trunk@31244


git-svn-id: http://core.svn.wordpress.org/trunk@31225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:44:22 +00:00
Drew Jaynes 3a0726d7b8 Add more complete documentation for parameters, globals, and return values to the DocBlocks for `remove_shortcode()`, `shortcode_exists()`, and `do_shortcode()`.
Props SergeyBiryukov.
Fixes #31048.

Built from https://develop.svn.wordpress.org/trunk@31243


git-svn-id: http://core.svn.wordpress.org/trunk@31224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:40:24 +00:00
Drew Jaynes a8e2ae2117 Ensure both parameters and the return for `has_shortcode()` are fully documented.
Props cais, SergeyBiryukov
See #31048.

Built from https://develop.svn.wordpress.org/trunk@31242


git-svn-id: http://core.svn.wordpress.org/trunk@31223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:36:25 +00:00
Sergey Biryukov eff3b8925b Display correct title in Archives widget if the type of archive was changed using the 'widget_archives_dropdown_args' filter.
props floriansimeth for initial patch.
fixes #31024.
Built from https://develop.svn.wordpress.org/trunk@31241


git-svn-id: http://core.svn.wordpress.org/trunk@31222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:26:24 +00:00
Sergey Biryukov eedb4857ba Strip HTML tags when searching for installed themes.
props enej, SergeyBiryukov, obenland.
fixes #27561.
Built from https://develop.svn.wordpress.org/trunk@31240


git-svn-id: http://core.svn.wordpress.org/trunk@31221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 20:40:23 +00:00
Sergey Biryukov 247cdad571 attachment_url_to_postid() should always return an integer.
props nathan_dawson, ashfame.
fixes #31044.
Built from https://develop.svn.wordpress.org/trunk@31239


git-svn-id: http://core.svn.wordpress.org/trunk@31220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 20:33:23 +00:00
Drew Jaynes bee439858b Minor fix for inline doc syntax in a changelog entry for `wp_get_object_terms()`.
See #28688.

Built from https://develop.svn.wordpress.org/trunk@31238


git-svn-id: http://core.svn.wordpress.org/trunk@31219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 19:05:22 +00:00
Boone Gorges a639c5905e Add `@since` annotation for 'orderby' values introduced in [31236].
See #28688.
Built from https://develop.svn.wordpress.org/trunk@31237


git-svn-id: http://core.svn.wordpress.org/trunk@31218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 19:03:24 +00:00
Boone Gorges 42ec13030c Additional 'orderby' values for `wp_get_object_terms()`.
Adds support for ordering by 'taxonomy', 'term_taxonomy_id', and 'parent'.

Props ChriCo.
Fixes #28688.
Built from https://develop.svn.wordpress.org/trunk@31236


git-svn-id: http://core.svn.wordpress.org/trunk@31217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 18:57:23 +00:00
Andrew Ozz 00436f6886 TinyMCE: fix vertical positioning of the image toolbar when there are several instances of the editor. Props avryl, fixes #31028.
Built from https://develop.svn.wordpress.org/trunk@31235


git-svn-id: http://core.svn.wordpress.org/trunk@31216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 17:56:23 +00:00
Sergey Biryukov 7d2ec003da Customizer: Replicate behavior from options-reading.php and hide front page options if there are no pages.
props Clorith.
fixes #27630.
Built from https://develop.svn.wordpress.org/trunk@31234


git-svn-id: http://core.svn.wordpress.org/trunk@31215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 06:01:24 +00:00
Boone Gorges 9c99ff8fe3 Add unit tests for 'orderby' and 'order' param of `wp_get_object_terms()`.
Built from https://develop.svn.wordpress.org/trunk@31233


git-svn-id: http://core.svn.wordpress.org/trunk@31214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 20:39:44 +00:00
Boone Gorges a245838c42 Correct `wp_get_object_terms()` documentation.
The 'orderby' parameter accepts a number of values that have never been
properly documented.
Built from https://develop.svn.wordpress.org/trunk@31232


git-svn-id: http://core.svn.wordpress.org/trunk@31213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 20:39:23 +00:00
Boone Gorges 03512a2a02 Standardize the docblock for `wp_get_object_terms()`.
The enumeration of the `$args` parameter has been moved from the long
description to an array hash associated with the proper `@param` attribute.
Built from https://develop.svn.wordpress.org/trunk@31231


git-svn-id: http://core.svn.wordpress.org/trunk@31212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 20:09:47 +00:00
Boone Gorges a917a904bd Move `wp_get_object_terms()` tests into their own file.
See #26999.
Built from https://develop.svn.wordpress.org/trunk@31230


git-svn-id: http://core.svn.wordpress.org/trunk@31211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 20:09:26 +00:00
Sergey Biryukov 34d06ee6b7 Add a changelog entry for the new parameter added in [31228].
props DrewAPicture.
fixes #31015.
Built from https://develop.svn.wordpress.org/trunk@31229


git-svn-id: http://core.svn.wordpress.org/trunk@31210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 17:31:23 +00:00
Sergey Biryukov 4e90a18c7c Pass $force_reauth value to the 'login_url' filter.
props jfarthing84, MikeHansenMe.
fixes #31015.
Built from https://develop.svn.wordpress.org/trunk@31228


git-svn-id: http://core.svn.wordpress.org/trunk@31209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 17:20:23 +00:00
Sergey Biryukov 8b50aef14c Customizer: Make "Search widgets" input sticky.
props celloexpressions.
fixes #30751.
Built from https://develop.svn.wordpress.org/trunk@31227


git-svn-id: http://core.svn.wordpress.org/trunk@31208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 13:15:23 +00:00
Sergey Biryukov 823ab1efdf Customizer: Fix form tag replacement in WP_Customize_Widgets::get_widget_control() after [31200].
see #30126.
Built from https://develop.svn.wordpress.org/trunk@31226


git-svn-id: http://core.svn.wordpress.org/trunk@31207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 13:11:23 +00:00
Sergey Biryukov 768624cb99 Use the site's local time to create the first post during installation.
props extendwings.
fixes #29296.
Built from https://develop.svn.wordpress.org/trunk@31225


git-svn-id: http://core.svn.wordpress.org/trunk@31206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 10:07:23 +00:00
Sergey Biryukov b87b8f2bb3 Introduce has_header_image() to check whether a header image is set.
props GunGeekATX, voldemortensen.
fixes #16268.
Built from https://develop.svn.wordpress.org/trunk@31224


git-svn-id: http://core.svn.wordpress.org/trunk@31205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 06:34:23 +00:00
Andrew Ozz 9d3ea188d7 Add support for IE conditional comments for WP_Scripts to match the functionality of WP_Styles, including unit tests. Props filosofo, aaroncampbell, ethitter, georgestephanis, valendesigns. Fixes #16024.
Built from https://develop.svn.wordpress.org/trunk@31223


git-svn-id: http://core.svn.wordpress.org/trunk@31204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 01:37:22 +00:00
Andrew Ozz f609d9d89a TinyMCE: add breaking out of blockquotes by pressing Enter twice. Togging blockquote on|off with the button and the shortcut is unchanged. Props avryl, fixes #23110.
Built from https://develop.svn.wordpress.org/trunk@31222


git-svn-id: http://core.svn.wordpress.org/trunk@31203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 23:36:22 +00:00
Scott Taylor 5458a4da21 `wp_set_object_terms()` takes `$taxonomy` as a string. Update `@param`.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31221


git-svn-id: http://core.svn.wordpress.org/trunk@31202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 23:27:25 +00:00
Scott Taylor 02a1f35ac8 Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`. 
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31220


git-svn-id: http://core.svn.wordpress.org/trunk@31201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 22:51:21 +00:00
Scott Taylor eeda68bbda Fix some erroneous `@param` annotations.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31219


git-svn-id: http://core.svn.wordpress.org/trunk@31200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 22:44:25 +00:00
Boone Gorges fffd8c8e2d In `get_edit_term_link()`, default to a valid `$object_type`.
The $object_type param is used to set the 'post_type' query var, which
determines the post type menu that will be expanded when clicking through to
the term edit page. Not all taxonomies are associated with Posts, so it makes
sense to default to a post_type that the taxonomy is actually associated with.

Props DzeryCZ, juliobox.
Fixes #29251.
Built from https://develop.svn.wordpress.org/trunk@31218


git-svn-id: http://core.svn.wordpress.org/trunk@31199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:37:23 +00:00
Scott Taylor 0f6d0b84d1 Remove unused local vars in `delete_plugins()`, `delete_theme()`, `WP_Date_Query->validate_date_values()`, `global_terms()`, and `WP_Text_Diff_Renderer_Table->_changed()`.
This will clear out the "Unused Code" label in the next Scrutinizer report.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31217


git-svn-id: http://core.svn.wordpress.org/trunk@31198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:19:22 +00:00
Scott Taylor 7c5038feb6 Calling `->chown()` and `->chgrp()` in `WP_Filesystem_ftpsockets` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31216


git-svn-id: http://core.svn.wordpress.org/trunk@31197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:10:23 +00:00
Scott Taylor 6fa7021d62 Calling `->chown()` and `->chgrp()` in `WP_Filesystem_FTPext` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31215


git-svn-id: http://core.svn.wordpress.org/trunk@31196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:07:24 +00:00
Lance Willett f6fd49b357 Twenty Fifteen: keep sub-menus open when visiting sub-menu pages, to show context when navigating a site.
Props jartes, fixes #30722.
Built from https://develop.svn.wordpress.org/trunk@31214


git-svn-id: http://core.svn.wordpress.org/trunk@31195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 19:17:22 +00:00
Scott Taylor b8dd1f9c69 By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors.
There are plenty of other kinds of errors, but this label will be cleared out.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31213


git-svn-id: http://core.svn.wordpress.org/trunk@31194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 19:13:23 +00:00
Scott Taylor bc55996a0b `@param` cleanup:
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31212


git-svn-id: http://core.svn.wordpress.org/trunk@31193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 19:03:23 +00:00
Scott Taylor cde4c83091 [31210] broke Supportflow on dotorg, which declares these methods as `protected`. Switch to `protected` for the noop methods. The subclasses can make them more visible using `public`.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31211


git-svn-id: http://core.svn.wordpress.org/trunk@31192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 18:37:24 +00:00
Scott Taylor 3fb283db0a Add 2 noop methods to `WP_List_Table`: `->column_default()` and `->column_cb()`.
`WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class.

These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31210


git-svn-id: http://core.svn.wordpress.org/trunk@31191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:42:22 +00:00
Scott Taylor 895794f74d In `WP_Filesystem_Base` subclasses that set `$wp_base`, remove this dead code.
Unused since [8009] - "Make WP_Filesystem work with new directory constants"

There is currently no declared field and no `@property` annotation.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31209


git-svn-id: http://core.svn.wordpress.org/trunk@31190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:23:22 +00:00
Scott Taylor b29a20b90a `WP_Filesystem_Base` should declare `$errors` and `$options` as fields for use by subclasses.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31208


git-svn-id: http://core.svn.wordpress.org/trunk@31189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:10:43 +00:00
Boone Gorges 35f3f7bf63 Bail out of hierarchy loops in `_get_term_children()`.
This prevents infinite loops that lead to PHP nesting limit fatal errors.

Props boonebgorges, sgrant.
Fixes #24461.
Built from https://develop.svn.wordpress.org/trunk@31207


git-svn-id: http://core.svn.wordpress.org/trunk@31188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:10:22 +00:00
Boone Gorges 991bfdebc1 Bail out of hierarchy loops in `_pad_term_counts()`.
Taxonomy hierarchy loops should not occur naturally, but when they do, the
logic of `_pad_term_counts()` could result in infinite loops, leading to
timeouts. We avoid this by breaking when a loop is detected.

Fixes #20635.
Built from https://develop.svn.wordpress.org/trunk@31206


git-svn-id: http://core.svn.wordpress.org/trunk@31187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 16:46:23 +00:00
Scott Taylor 86f29795a4 Add `<s>` to `$allowedtags` in KSES.
From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/s :
"The <strike> element, alter ego of the <s> element is obsolete and should not be used on Web sites any more."

`<strike>` shall remain for BC, but `<s>` should not be stripped from the author (et al) role's HTML input.

Props paulschreiber.
Fixes #30954.

Built from https://develop.svn.wordpress.org/trunk@31205


git-svn-id: http://core.svn.wordpress.org/trunk@31186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 16:07:23 +00:00