Pascal Birchler
8222b85aa2
Themes: Show templates from both parent and child theme when calling `WP_Theme::get_post_templates()`.
...
Props birgire for initial patch.
Fixes #41717 .
Built from https://develop.svn.wordpress.org/trunk@41975
git-svn-id: http://core.svn.wordpress.org/trunk@41809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 20:08:47 +00:00
Weston Ruter
0343b1a2c8
Code Editor: Keep linting and its error reporting configured when `lint` option is changed dynamically.
...
Also explicitly disable `lint` option for SCSS and LESS.
See #12423 .
Built from https://develop.svn.wordpress.org/trunk@41974
git-svn-id: http://core.svn.wordpress.org/trunk@41808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 19:55:46 +00:00
Konstantin Obenland
91ad9114d0
Customize: Ease extendability of filter drawer
...
By moving the `wporg` conditional inside the method body, the filter drawer can be overridden without having to also override the entire section template.
Props celloexpressions.
Closes #42212 .
Built from https://develop.svn.wordpress.org/trunk@41973
git-svn-id: http://core.svn.wordpress.org/trunk@41807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 18:58:46 +00:00
Andrea Fercia
69518459e6
Customize: Make sure the FTP credentials modal is visible.
...
The customizer and the theme installer use `visibility: hidden` on the body when
they open full-overlays screens. The FTP credentials modal needs a visibility
property set back to `visible` to be visible over those overlays.
Props purnendu.
Fixes #42205 .
Built from https://develop.svn.wordpress.org/trunk@41972
git-svn-id: http://core.svn.wordpress.org/trunk@41806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 17:54:53 +00:00
Sergey Biryukov
703713756a
Tests: Fix typo in `test_do_action_with_multiple_callbacks_on_different_priorities()`.
...
Props withinboredom.
Fixes #42311 .
Built from https://develop.svn.wordpress.org/trunk@41971
git-svn-id: http://core.svn.wordpress.org/trunk@41805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 13:04:49 +00:00
Peter Wilson
ca45ec136f
Build/Test tools: Move `wp_doing_ajax` defintion from class setup to test setup.
...
Moves defintion of ajax request in `WP_Ajax_UnitTestCase` to `setUp()` method to account for hooks being reset as part of `tearDown()`.
Props matthias.thiel for report.
Fixes #41561 .
Built from https://develop.svn.wordpress.org/trunk@41970
git-svn-id: http://core.svn.wordpress.org/trunk@41804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 05:11:47 +00:00
Weston Ruter
990c6d5a42
Customize: Keep frontend preview link updated to reflect the current state of previewed URL, active theme, and autosaved state.
...
See #39896 .
Built from https://develop.svn.wordpress.org/trunk@41969
git-svn-id: http://core.svn.wordpress.org/trunk@41803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 00:41:47 +00:00
Weston Ruter
5e7e44aba7
Customize: Update 'Save & Activate' reference to 'Publish & Activate' in themes help tab text.
...
See #39896 .
Fixes #42305 .
Built from https://develop.svn.wordpress.org/trunk@41968
git-svn-id: http://core.svn.wordpress.org/trunk@41802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-22 20:03:51 +00:00
John Blackbourn
74cf14cdf3
Docs: Correct docs introduced in [41965].
...
See #16778
Built from https://develop.svn.wordpress.org/trunk@41967
git-svn-id: http://core.svn.wordpress.org/trunk@41801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 22:42:51 +00:00
Dion Hulse
cb1b49bca5
Tests: Return an exit code of 1 in the event that the database server for tests is unavailable.
...
This allows for automated scripts & test suites to handle the failure of the test suite easier.
Props danielbachhuber
Fixes #41916
Built from https://develop.svn.wordpress.org/trunk@41966
git-svn-id: http://core.svn.wordpress.org/trunk@41800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 14:14:48 +00:00
Gary Pendergast
8608b710b7
Docs: Expand the docs for the `core_version_check_query_args` filter.
...
Add documentation for the parameters in the `$query` parameter.
Props MattyRob.
Fixes #16778 .
Built from https://develop.svn.wordpress.org/trunk@41965
git-svn-id: http://core.svn.wordpress.org/trunk@41799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 13:46:50 +00:00
Gary Pendergast
0847fab645
Media: Don't backdate media uploaded to pages.
...
When media is uploaded to a post, the upload directory is set according to the date of the post, so that the media URLs in the post match when the post was published.
A page is a slightly different beast, pages often live for years, and are regularly updated to stay relevant. This change causes media uploaded to pages to use the upload date to determine the upload directory.
Fixes #10752 .
Built from https://develop.svn.wordpress.org/trunk@41964
git-svn-id: http://core.svn.wordpress.org/trunk@41798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 13:27:48 +00:00
Dion Hulse
26f9c6b909
Transients: Clear expired transients from the database in a daily cron task.
...
Fixes #41699
Built from https://develop.svn.wordpress.org/trunk@41963
git-svn-id: http://core.svn.wordpress.org/trunk@41797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 13:22:49 +00:00
Gary Pendergast
f7fcb2cd5b
Updates: Add the `core_version_check_query_args` filter.
...
This filter allows the data being sent for core update checks to be controlled for privacy concerns.
Props toscho, MattyRob, swissspidy, pento.
Fixes #16778 .
Built from https://develop.svn.wordpress.org/trunk@41962
git-svn-id: http://core.svn.wordpress.org/trunk@41796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 11:55:47 +00:00
Weston Ruter
0c1c0980e7
Customize: Improve back-compat for `wp.customize.Control` subclasses that expect `options.params` to be present for direct manipulation before calling parent `initialize` method.
...
Fixes known incompatibility with Make theme.
Amends [41726].
See #30741 .
Built from https://develop.svn.wordpress.org/trunk@41961
git-svn-id: http://core.svn.wordpress.org/trunk@41795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 08:51:48 +00:00
Weston Ruter
1f735509af
Customize: Allow control subclasses to add to the `deferred` object before the base class initializes.
...
Update the `CodeEditorControl`'s `codemirror` deferred to be set before calling the parent class's `initialize` method. Since the `ready` method may be called directly by `initialize` it may be too late to add a new `Deferred` to the control's `deferred` property after calling the base control class's `initialize`.
Amends [41958].
See #41897 .
Built from https://develop.svn.wordpress.org/trunk@41960
git-svn-id: http://core.svn.wordpress.org/trunk@41794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 08:44:52 +00:00
Sergey Biryukov
45655bb928
Docs: Document `$wp_version` global in `wp_initial_constants()`.
...
Props mt8.biz.
Fixes #42259 .
Built from https://develop.svn.wordpress.org/trunk@41959
git-svn-id: http://core.svn.wordpress.org/trunk@41793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 22:04:56 +00:00
Weston Ruter
47c555f8ed
Customize: Add `codemirror` deferred object to `CodeEditorControl` which is resolved when CodeMirror is initialized.
...
CodeMirror gets initialized once the control's containing section is expanded. The deferred will be rejected if user preference for syntax highlighting is disabled.
Also move jsdoc from `wp.customize.Control` to intended `wp.customize.Control#initialize()`.
See #41897 , #12423 .
Built from https://develop.svn.wordpress.org/trunk@41958
git-svn-id: http://core.svn.wordpress.org/trunk@41792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 21:48:46 +00:00
Weston Ruter
81c87e7d5e
Code Editor: Improve ability to create Customizer `CodeEditorControl` instances in JS, lessening PHP dependencies.
...
Allow `CodeEditorControl` to be instantiated with a `editor_settings` param which is merged with `wp.codeEditor.defaultSettings`.
Also:
* Turn redundant "CSS Code" control label into screen reader text for Additional CSS.
* Remove `code-editor` as script dependency for `custom-html-widgets` since enqueueing is determined by `wp_enqueue_code_editor()`.
* Remove useless exporting of `code_type` param to JS in `WP_Customize_Code_Editor_Control`.
* Add `disabled` class to Custom HTML widget's Save button when linting errors are present.
* Remove redundant `span` inside CodeEditorControl's `label`.
See #41897 , #12423 , #41872 .
Built from https://develop.svn.wordpress.org/trunk@41957
git-svn-id: http://core.svn.wordpress.org/trunk@41791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 16:39:48 +00:00
Sergey Biryukov
33012ad740
Customize: Use typographic quotation marks in the strings added in [41768].
...
Props audrasjb, tobifjellner.
Fixes #42290 . See #40104 .
Built from https://develop.svn.wordpress.org/trunk@41956
git-svn-id: http://core.svn.wordpress.org/trunk@41790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 14:07:47 +00:00
Sergey Biryukov
f80db51d0f
Menus: Remove an extra space in the `<ul>` tag in `Walker_Nav_Menu::start_lvl()`.
...
Fixes #42289 .
Built from https://develop.svn.wordpress.org/trunk@41955
git-svn-id: http://core.svn.wordpress.org/trunk@41789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 10:40:46 +00:00
Mel Choyce
d31ab27d26
Customize Menus: Update capitalization of "next" to match case on the "Next" button.
...
Props hardeepasrani.
Fixes #42287 .
Built from https://develop.svn.wordpress.org/trunk@41954
git-svn-id: http://core.svn.wordpress.org/trunk@41788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 10:34:49 +00:00
Mel Choyce
4d41bf7127
Customization Locking: Update error message to use existing strings.
...
Props ramiy.
See #42024 .
Built from https://develop.svn.wordpress.org/trunk@41953
git-svn-id: http://core.svn.wordpress.org/trunk@41787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 10:32:53 +00:00
Weston Ruter
a402312a8d
Customize: Prevent using default template for a base control when it has content rendered on the server.
...
Also prevent invalid `type` attribute from being added to a `select` element.
See #30738 .
Fixes #42286 .
Built from https://develop.svn.wordpress.org/trunk@41952
git-svn-id: http://core.svn.wordpress.org/trunk@41786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 03:30:46 +00:00
Weston Ruter
6913ad9219
Widgets: Improve extensibility of the Gallery widget and of media widgets generally.
...
* Introduce a `widget_{$id_base}_instance_schema` filter for plugins to add new properties to a media widget's instance schema.
* Pass all of a gallery widget's instance props to the gallery media frame, not just the ones that core supports.
See #32417 , #41914 .
Fixes #42285 .
Built from https://develop.svn.wordpress.org/trunk@41951
git-svn-id: http://core.svn.wordpress.org/trunk@41785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 23:44:48 +00:00
Weston Ruter
ea21ad6cc1
Customize: Prevent re-highlighting "Add Items" button after available nav menu items pane has already been opened.
...
Amends [41930].
Props bpayton.
See #42114 .
Built from https://develop.svn.wordpress.org/trunk@41950
git-svn-id: http://core.svn.wordpress.org/trunk@41784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 18:38:47 +00:00
Weston Ruter
c8105f1460
Customize: Fix alignment of Customize, Activate, and Live Preview buttons appearing on the Themes admin screen.
...
Amends [41893].
Props Mahvash-Fatima.
See #42215 .
Fixes #42275 .
Built from https://develop.svn.wordpress.org/trunk@41949
git-svn-id: http://core.svn.wordpress.org/trunk@41783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 18:10:47 +00:00
Weston Ruter
d695648084
Customize: Fix rendering issues in theme browsing when opening theme details or performing search in Safari.
...
Props sayedwp.
See #37661 .
Fixes #42052 .
Built from https://develop.svn.wordpress.org/trunk@41948
git-svn-id: http://core.svn.wordpress.org/trunk@41782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 17:57:47 +00:00
Weston Ruter
b1a9139b46
Customize: Prevent drawing attention to save button if status unchanged from publish; account for changes to status/date when alerting about unsaved changes.
...
Also fix malformed ESLint directive from [41933].
Amends [41932].
See #39896 , #42211 .
Built from https://develop.svn.wordpress.org/trunk@41947
git-svn-id: http://core.svn.wordpress.org/trunk@41781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 17:42:54 +00:00
Gary Pendergast
609da14d59
About page: Update the privacy policy dashes.
...
If one were to insert 1—3 dashes into a sentence - on purpose - they should use the correct da–
sh.
See #40794 .
Built from https://develop.svn.wordpress.org/trunk@41946
git-svn-id: http://core.svn.wordpress.org/trunk@41780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 15:36:47 +00:00
John Blackbourn
06eba419fe
Build/Test tools: Document the return value of `WP_UnitTestCase::factory()`.
...
See #41017
Built from https://develop.svn.wordpress.org/trunk@41945
git-svn-id: http://core.svn.wordpress.org/trunk@41779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 15:33:48 +00:00
Gary Pendergast
31a3c8e744
About page: Update the privacy policy language.
...
See #40794 .
Built from https://develop.svn.wordpress.org/trunk@41944
git-svn-id: http://core.svn.wordpress.org/trunk@41778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 15:26:48 +00:00
Mel Choyce
02ff01d331
About Page: Commit initial strings for 4.9.
...
Props kristastevens, dd32, hlashbrooke.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@41943
git-svn-id: http://core.svn.wordpress.org/trunk@41777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 13:57:48 +00:00
Sergey Biryukov
3aa0c23274
Docs: After [37329], update the documentation for `register_widget()` and `unregister_widget()`.
...
Both functions can accept a `WP_Widget` instance object instead of a `WP_Widget` subclass name, same as `WP_Widget_Factory::register()` and `::unregister()`.
Props behzod.
Fixes #42270 .
Built from https://develop.svn.wordpress.org/trunk@41942
git-svn-id: http://core.svn.wordpress.org/trunk@41776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 13:51:50 +00:00
Sergey Biryukov
1accb992f8
Menus: Pass `$recent_args` parameter to `nav_menu_items_{$post_type_name}_recent` filter.
...
Props welcher, eclev91.
Fixes #39849 .
Built from https://develop.svn.wordpress.org/trunk@41941
git-svn-id: http://core.svn.wordpress.org/trunk@41775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 13:05:55 +00:00
Sergey Biryukov
9c4fb24458
Docs: Reference `WP_Comment_Query::__construct()` as the source of information on accepted arguments in `get_comments()` and `get_approved_comments()`.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@41940
git-svn-id: http://core.svn.wordpress.org/trunk@41774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 08:49:47 +00:00
Weston Ruter
bdefa6bf34
Post WordPress 4.9 Beta 3 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@41939
git-svn-id: http://core.svn.wordpress.org/trunk@41773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 05:08:48 +00:00
Weston Ruter
0ae160dec1
WordPress 4.9 Beta 3.
...
Built from https://develop.svn.wordpress.org/trunk@41938
git-svn-id: http://core.svn.wordpress.org/trunk@41772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 04:43:48 +00:00
Joe McGill
d21f6799a6
Customizer: Improve handling of crops in the media library.
...
This is a follow up on r41732, implementing the following improvements:
* Attachment parent info is now stored in attachment meta rather than a
separate post meta key.
* Attachments created from contextual crops (e.g. header, logos, etc.) are
filtered out of the media library using a new `_filterContext` method in
`wp.media.controller.Library`.
Props joemcgill, westonruter.
See #21819 .
Built from https://develop.svn.wordpress.org/trunk@41937
git-svn-id: http://core.svn.wordpress.org/trunk@41771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 04:18:47 +00:00
Weston Ruter
20aad6b5c5
Customize: Consistently use `input_attrs` as control param key in JS instead of `inputAttrs`.
...
See #30738 , #41897 .
Built from https://develop.svn.wordpress.org/trunk@41936
git-svn-id: http://core.svn.wordpress.org/trunk@41770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 03:25:47 +00:00
Weston Ruter
f8d16c8aed
Customize: Move control's fallback selection of default content template to `renderContent` method to align with sections and panels.
...
* Only use default control content template when a more specific template doesn't exist.
* Remove extraneous whitespace from being output in `WP_Customize_Control::render()` method.
* Move Custom Header template printing to `customize_controls_print_footer_scripts` action.
See #30738 .
Built from https://develop.svn.wordpress.org/trunk@41935
git-svn-id: http://core.svn.wordpress.org/trunk@41769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 03:04:49 +00:00
Sergey Biryukov
c81acd7cef
I18N: Unify permission error message in `wp-admin/ms-delete-site.php`.
...
Props ramiy.
Fixes #42268 .
Built from https://develop.svn.wordpress.org/trunk@41934
git-svn-id: http://core.svn.wordpress.org/trunk@41768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 00:48:50 +00:00
Weston Ruter
887998f7ed
Widgets: Harden logic for checking for valid media URLs.
...
* Update deprecated `isHostedVideo` method to always return `true` since all oEmbeds are now supported.
* Disable `scanImage` for non-image media widgets.
* Ensure embed URL field element is matched from current media frame instance due to bug where media frames are not destroyed upon closing.
* Update error message for invalid video URLs to ask user to check the URL for validity.
Props gk.loveweb, octalmage, westonruter.
See #42039 , #40935 .
Fixes #41052 .
Built from https://develop.svn.wordpress.org/trunk@41933
git-svn-id: http://core.svn.wordpress.org/trunk@41767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 00:07:54 +00:00
Weston Ruter
ed686152f5
Customize: Draw attention to save button after collapsing the publish settings section when the changeset status or date had been changed.
...
Props bpayton, westonruter.
See #42114 , #39896 .
Fixes #42211 .
Built from https://develop.svn.wordpress.org/trunk@41932
git-svn-id: http://core.svn.wordpress.org/trunk@41766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 23:06:49 +00:00
Sergey Biryukov
15c8976cc4
Dashboard: Add missing URL to "Help with testing" link in Gutenberg callout.
...
See #41316 .
Built from https://develop.svn.wordpress.org/trunk@41931
git-svn-id: http://core.svn.wordpress.org/trunk@41765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 22:41:46 +00:00
Weston Ruter
b65d6eb680
Customize: Draw attention to "Add Items" button after creating a new menu.
...
Introduce `wp.customize.utils.highlightButton()` and `wp.customize.Menus.MenuSection#highlightNewItemButton()`.
Props bpayton, melchoyce, afercia, westonruter.
Fixes #42114 .
Built from https://develop.svn.wordpress.org/trunk@41930
git-svn-id: http://core.svn.wordpress.org/trunk@41764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 22:00:50 +00:00
Sergey Biryukov
71dca590dc
Build/Test Tools: Clean up `$_REQUEST` and `$GLOBALS` after modifying them in `_test_list_hierarchical_page()`.
...
Props birgire.
Fixes #42044 .
Built from https://develop.svn.wordpress.org/trunk@41929
git-svn-id: http://core.svn.wordpress.org/trunk@41763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 21:48:48 +00:00
Sergey Biryukov
0f06f90341
Rewrite Rules: Remove redundant `if` condition in `extract_from_markers()`.
...
Props Dency, yahil, appchecker.
Fixes #39920 .
Built from https://develop.svn.wordpress.org/trunk@41928
git-svn-id: http://core.svn.wordpress.org/trunk@41762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 21:28:46 +00:00
Sergey Biryukov
0afafb7a1b
I18N: Unify error messages in XML-RPC methods `wp_deleteCategory()` and `wp_deleteComment()`.
...
Props ramiy.
Fixes #39019 .
Built from https://develop.svn.wordpress.org/trunk@41927
git-svn-id: http://core.svn.wordpress.org/trunk@41761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 21:12:51 +00:00
Sergey Biryukov
50db4bceb0
Administration: After [41120], check for a registered action before sending a Bad Request HTTP response status code.
...
Props Clorith.
Fixes #42240 .
Built from https://develop.svn.wordpress.org/trunk@41926
git-svn-id: http://core.svn.wordpress.org/trunk@41760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 21:01:49 +00:00