Commit Graph

13405 Commits

Author SHA1 Message Date
Scott Taylor 85731fc99b In `multi_resize()` image editor methods, assert that `null` can only be passed for one of the arguments, not both. Add a lot more unit test assertions to ensure this.
Props pbearne, DH-Shredder.
Fixes #26823.


Built from https://develop.svn.wordpress.org/trunk@27794


git-svn-id: http://core.svn.wordpress.org/trunk@27630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 20:40:17 +00:00
Scott Taylor 1d6f31dc52 Remove `tracknumbers` from the UI, can still be overridden as a playlist shortcode attribute.
See #27535.


Built from https://develop.svn.wordpress.org/trunk@27793


git-svn-id: http://core.svn.wordpress.org/trunk@27629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 20:27:15 +00:00
Helen Hou-Sandí 502dab46e5 Affix the audio view toolbar to the bottom as opposed to the top of the view. Otherwise it's not accessible when the view is the first item in the content. Said views keep a newline underneath, so there's space for it to appear there instead. fixes #27548, see #27320.
Built from https://develop.svn.wordpress.org/trunk@27792


git-svn-id: http://core.svn.wordpress.org/trunk@27628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 20:10:15 +00:00
Andrew Ozz 56b7043a90 Set the default font family to inherit (Open Sans) in all TinyMCE modals, change the cursor to pointer when hovering over Quicktags buttons. Props avryl, see #27279
Built from https://develop.svn.wordpress.org/trunk@27791


git-svn-id: http://core.svn.wordpress.org/trunk@27627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 19:19:14 +00:00
Dominik Schilling 4038e52276 Add some missing CSS prefixes. props `grunt autoprefixer:core`.
Built from https://develop.svn.wordpress.org/trunk@27790


git-svn-id: http://core.svn.wordpress.org/trunk@27626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 19:17:15 +00:00
Scott Taylor 26773541ab Make sure Playlist states that are `audio` are marked as such with proper localized strings.
See #27554.

Built from https://develop.svn.wordpress.org/trunk@27789


git-svn-id: http://core.svn.wordpress.org/trunk@27625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 18:37:17 +00:00
Scott Taylor ff6c0731fa Move counting of attachments for audio/video to the backend, instead of using a `reduce` function in JS.
See #27554.


Built from https://develop.svn.wordpress.org/trunk@27788


git-svn-id: http://core.svn.wordpress.org/trunk@27624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 18:16:16 +00:00
Andrew Nacin e1be2d21d8 Avoid JS errors when edit image is not available, such as outside of post editing.
props gcorne.
fixes #27551.

Built from https://develop.svn.wordpress.org/trunk@27787


git-svn-id: http://core.svn.wordpress.org/trunk@27623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 18:15:15 +00:00
Andrew Nacin bd0df204a1 Remove the TinyMCE image toolbar when the image is deleted via the keyboard.
props gcorne.
fixes #27527.

Built from https://develop.svn.wordpress.org/trunk@27786


git-svn-id: http://core.svn.wordpress.org/trunk@27622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 18:07:14 +00:00
Scott Taylor 4f868ad882 There is no more `video-playlist` shortcode. To use video, it is now `[playlist type="video" ....]`. Also deleting core playlist styles. The `style` attribute is still supported, defaulting to `light`. Our core style support was 4-5 CSS rules.
See #27552. Leaving open for comments and potential bugs.


Built from https://develop.svn.wordpress.org/trunk@27785


git-svn-id: http://core.svn.wordpress.org/trunk@27621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 17:58:15 +00:00
Andrew Nacin 68bfa704cf Remove unused JS variables after [27770]. see #27013.
Built from https://develop.svn.wordpress.org/trunk@27783


git-svn-id: http://core.svn.wordpress.org/trunk@27619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 17:31:14 +00:00
Andrew Nacin 3eb91d047c Add post_parent to the private query vars list. Fixes detached media queries.
props SergeyBiryukov.
fixes #27532.

Built from https://develop.svn.wordpress.org/trunk@27782


git-svn-id: http://core.svn.wordpress.org/trunk@27618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 16:37:16 +00:00
Andrew Nacin 995cc6f6ec Preserve comments in Masonry shim. see [27780], see #27510.
Built from https://develop.svn.wordpress.org/trunk@27781


git-svn-id: http://core.svn.wordpress.org/trunk@27617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 07:33:16 +00:00
Andrew Nacin 1bc06760de Update minified jQuery Masonry shim. see [27779], see #27510.
Built from https://develop.svn.wordpress.org/trunk@27780


git-svn-id: http://core.svn.wordpress.org/trunk@27616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 07:32:14 +00:00
Andrew Nacin 043bc12b49 TinyMCE: Differentiate active and hover states for toolbar buttons like the kitchen sink.
This restores 3.8 behavior.

see #27279.

Built from https://develop.svn.wordpress.org/trunk@27778


git-svn-id: http://core.svn.wordpress.org/trunk@27615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 07:19:15 +00:00
Helen Hou-Sandí 443ab3001e MCE view controls:
* Move controls back over to the left, as they were before. Wide images and muscle memory have been causing frustration.
* Improve the experience and unify the UI of media view controls. Audio and video views now require an initial click to select before further interaction.
* CSS clean up and organization.

fixes #27320, #27542.

Built from https://develop.svn.wordpress.org/trunk@27777


git-svn-id: http://core.svn.wordpress.org/trunk@27614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 07:02:16 +00:00
Andrew Nacin 6c70420b42 Editor: Fix line height on 'Drop files to upload'.
props Nao.
fixes #27541.

Built from https://develop.svn.wordpress.org/trunk@27773


git-svn-id: http://core.svn.wordpress.org/trunk@27610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 04:08:14 +00:00
Helen Hou-Sandí 2406bba954 Match TinyMCE modal form element focus styling to the admin. props paulwilde. see #27173.
Built from https://develop.svn.wordpress.org/trunk@27771


git-svn-id: http://core.svn.wordpress.org/trunk@27608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 02:36:14 +00:00
Andrew Ozz 15549e75f3 Remove containment of scrolling inside the editor for now. See #27013
Built from https://develop.svn.wordpress.org/trunk@27770


git-svn-id: http://core.svn.wordpress.org/trunk@27607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 02:35:14 +00:00
Andrew Nacin 86843194b8 Revert [27738] as the patient exhibited side effects. see #23862.
Built from https://develop.svn.wordpress.org/trunk@27768


git-svn-id: http://core.svn.wordpress.org/trunk@27605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 01:31:15 +00:00
Scott Taylor 0a2e85d3f0 Use `wp_parse_id_list()` when parsing `exclude_tree` in `get_pages()`. Add unit tests to ensure a URL string, array with string as value, and array with array as value for `exclude_tree` can be used to specify multiple IDs.
Props cgaffga, roothorick, hakre, tbrams for patches across the years.
Fixes #9153.


Built from https://develop.svn.wordpress.org/trunk@27767


git-svn-id: http://core.svn.wordpress.org/trunk@27604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 01:18:14 +00:00
Andrew Ozz b2b6d416f3 Add aria-label to the DFW buttons, props joedolson, fixes #26555
Built from https://develop.svn.wordpress.org/trunk@27766


git-svn-id: http://core.svn.wordpress.org/trunk@27603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 01:14:15 +00:00
Helen Hou-Sandí c3b59e06b8 Better, more consistent styling for plugin details Thickbox and TinyMCE help.
props avryl. fixes #26952.

Built from https://develop.svn.wordpress.org/trunk@27765


git-svn-id: http://core.svn.wordpress.org/trunk@27602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 00:08:15 +00:00
Andrew Ozz cb489f5a9c Add the 'attachment_' prefix to caption IDs after editing, see #24409
Built from https://develop.svn.wordpress.org/trunk@27764


git-svn-id: http://core.svn.wordpress.org/trunk@27601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 00:07:14 +00:00
Andrew Nacin 2133c89e8f Remove select and input from wpautop()'s HTML blocks list.
props rachelbaker, DH-Shredder.
fixes #22230.

Built from https://develop.svn.wordpress.org/trunk@27761


git-svn-id: http://core.svn.wordpress.org/trunk@27598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 00:01:15 +00:00
Scott Taylor d4e46e3f8d Fix double avatars and JS errors when spamming/trashing comments.
Props avryl, SergeyBiryukov.
Fixes #27329.
 

Built from https://develop.svn.wordpress.org/trunk@27759


git-svn-id: http://core.svn.wordpress.org/trunk@27596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 23:14:15 +00:00
Andrew Nacin bb129b90f0 Add an .html4-captions class to the editor when HTML5 captions are not supported, for theme use.
see #26642.

Built from https://develop.svn.wordpress.org/trunk@27758


git-svn-id: http://core.svn.wordpress.org/trunk@27595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 23:13:15 +00:00
Andrew Nacin ed993e4c5c Properly render the image details modal when the image references an invalid attachment.
props gcorne.
fixes #27537.

Built from https://develop.svn.wordpress.org/trunk@27756


git-svn-id: http://core.svn.wordpress.org/trunk@27593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 22:56:14 +00:00
Scott Taylor f947924b0a In `wp_list_pages()`, add the `current_page_item` class where applicable when used with a custom post type.
Adds a unit test.

Props nacin.
Fixes #17590.


Built from https://develop.svn.wordpress.org/trunk@27755


git-svn-id: http://core.svn.wordpress.org/trunk@27592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 22:47:14 +00:00
Andrew Nacin 9669fc94ef Fix excluded_terms passed to get_adjacent_posts_rel_link().
props adelval.
fixes #22406.

Built from https://develop.svn.wordpress.org/trunk@27754


git-svn-id: http://core.svn.wordpress.org/trunk@27591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 22:32:15 +00:00
Dominik Schilling a2eb248e0b Widget Customizer: First pass for inline docs.
props DrewAPicture.
see #27534.
Built from https://develop.svn.wordpress.org/trunk@27753


git-svn-id: http://core.svn.wordpress.org/trunk@27590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 22:29:15 +00:00
Helen Hou-Sandí 5f062ee60c Post lock dialog should not appear above the auth check login prompt.
props lkwdwrd. fixes #27263.

Built from https://develop.svn.wordpress.org/trunk@27752


git-svn-id: http://core.svn.wordpress.org/trunk@27589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 22:24:14 +00:00
Scott Taylor 76ac10ba11 Don't display the "Show Artist Name in Tracklist" input in settings for Video Playlists.
See #27535.


Built from https://develop.svn.wordpress.org/trunk@27751


git-svn-id: http://core.svn.wordpress.org/trunk@27588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 22:12:16 +00:00
Scott Taylor b6f768bd30 `jshint` fixes for [27734].
Built from https://develop.svn.wordpress.org/trunk@27750


git-svn-id: http://core.svn.wordpress.org/trunk@27587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 21:41:15 +00:00
Andrew Nacin 52cc239578 Revert [27166].
We should not be accounting for improper assignment of WP_Query properties.

fixes #26321.

Built from https://develop.svn.wordpress.org/trunk@27746


git-svn-id: http://core.svn.wordpress.org/trunk@27583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 18:43:14 +00:00
Andrew Nacin bf5447f435 WP_Theme: Return false from the display() method when get() fails.
Fixes a potential warning on the themes page when the active theme is deleted.

fixes #26873.

Built from https://develop.svn.wordpress.org/trunk@27745


git-svn-id: http://core.svn.wordpress.org/trunk@27582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 18:22:13 +00:00
Scott Taylor 0c34f4f136 Make the CSS selector for current playlist item `<img>` more specific so the width is properly constrained.
Hide the `<audio>` element in the playlist to prevent a flicker when loading - MEjs hides the audio element anyway.

See #27525.


Built from https://develop.svn.wordpress.org/trunk@27742


git-svn-id: http://core.svn.wordpress.org/trunk@27579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 16:51:16 +00:00
Andrew Nacin fbbc31f3c5 Inline documentation for hooks in wp-includes/kses.php.
props siobhyb, DrewAPicture.
fixes #25800.

Built from https://develop.svn.wordpress.org/trunk@27739


git-svn-id: http://core.svn.wordpress.org/trunk@27576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 14:57:15 +00:00
Andrew Nacin f5999e5d50 WP class: Remove duplication of the post_type query var, also specified as a public QV.
props prettyboymp.
fixes #23862.

Built from https://develop.svn.wordpress.org/trunk@27738


git-svn-id: http://core.svn.wordpress.org/trunk@27575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 14:45:16 +00:00
Scott Taylor 3171da9986 Pass the default mime-type icon as the image for a track when a featured image is not selected for an item in a playlist. Image display in general can be toggled on/off in the modal via Playlist Settings.
Fixes #27525.


Built from https://develop.svn.wordpress.org/trunk@27735


git-svn-id: http://core.svn.wordpress.org/trunk@27572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 12:45:15 +00:00
Scott Taylor b1316b9392 Always localize `mediaelement` when passing settings to the page via JSON. `wp-mediaelement` only gets triggered for audio and video shortcodes, playlists need the path passed to the page as well, as they don't enqueue `wp-mediaelement`.
See #27509.


Built from https://develop.svn.wordpress.org/trunk@27734


git-svn-id: http://core.svn.wordpress.org/trunk@27571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 12:15:15 +00:00
Scott Taylor eddc48def7 Don't make `mce-view` a dependency for `media-audiovideo`. Make `media-audiovideo` and `wp-playlist` dependencies for `mce-view` and only enqueue `mce-view` in the admin in `wp_enqueue_media()`. MCE views don't need to be included when media is loaded on the front end.
Fixes #27509.


Built from https://develop.svn.wordpress.org/trunk@27733


git-svn-id: http://core.svn.wordpress.org/trunk@27570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 12:11:14 +00:00
Drew Jaynes 7037289a98 Inline documentation for hooks in wp-includes/script-loader.php.
Fixes #27520.

Built from https://develop.svn.wordpress.org/trunk@27732


git-svn-id: http://core.svn.wordpress.org/trunk@27569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 05:52:15 +00:00
Drew Jaynes e58c1d08e7 Inline documentation for hooks in wp-includes/class.wp-scripts.php.
Props kpdesign for a wording switcheroo.
Fixes #27518.

Built from https://develop.svn.wordpress.org/trunk@27731


git-svn-id: http://core.svn.wordpress.org/trunk@27568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 05:48:14 +00:00
Drew Jaynes c2ebd66843 Inline documentation for hooks in wp-includes/class-wp-xmlrpc-server.php.
Props kpdesign and DrewAPicture.
Fixes #27506.

Built from https://develop.svn.wordpress.org/trunk@27730


git-svn-id: http://core.svn.wordpress.org/trunk@27567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 05:44:16 +00:00
Andrew Ozz c66f166956 TinyMCE: fix the More and Next Page tags behavior:
- Append them inside top level <p> tags.
- If the caret is not in a top level <p>, create new paragraph after the current top level tag.
- Do not change placement when edited in the Text editor.
See #27378
Built from https://develop.svn.wordpress.org/trunk@27729


git-svn-id: http://core.svn.wordpress.org/trunk@27566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 02:08:15 +00:00
Helen Hou-Sandí aee8de682b Ensure buttons don't get overly tall in responsive views when a browser (oh, Firefox) enforces a line-height on buttons. props azaozz. fixes #27409.
Built from https://develop.svn.wordpress.org/trunk@27727


git-svn-id: http://core.svn.wordpress.org/trunk@27564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 21:23:14 +00:00
Helen Hou-Sandí 52d2920891 Use Dashicon-style images for mime type icons. Actually moving to Dashicons via the font can be explored later, but has theme/plugin implications and requires too many changes to make it for 3.9. props melchoyce for the icons. fixes #26650.
Built from https://develop.svn.wordpress.org/trunk@27726


git-svn-id: http://core.svn.wordpress.org/trunk@27563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 21:10:15 +00:00
Andrew Nacin c095ad4500 Multisite: Lowercase REQUEST_URI when matching paths.
props markjaquith, jeremyfelt.
fixes #26403.

Built from https://develop.svn.wordpress.org/trunk@27724


git-svn-id: http://core.svn.wordpress.org/trunk@27561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 21:05:14 +00:00
Drew Jaynes a10a55cf87 Fix a typo in the `deleted_{$meta_type}_meta` hook description.
Props aliso.
Fixes #25826.

Built from https://develop.svn.wordpress.org/trunk@27723


git-svn-id: http://core.svn.wordpress.org/trunk@27560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 20:34:15 +00:00