Commit Graph

32514 Commits

Author SHA1 Message Date
Drew Jaynes de5e9d01a9 Docs: Add a summary, version, and `@access` tag to the property DocBlock for `WP_Locale->number_format`.
See [5308] for where the property was initially introduced.
See [31083] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34489


git-svn-id: http://core.svn.wordpress.org/trunk@34453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 13:26:24 +00:00
Dominik Schilling 97146ee2cb Customizer: Update tests for [34487].
Fixes #33634.
Built from https://develop.svn.wordpress.org/trunk@34488


git-svn-id: http://core.svn.wordpress.org/trunk@34452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 11:32:26 +00:00
Dominik Schilling 833e92b7da Customizer: Use the plural label for available menu item types.
Fixes #33634.
Built from https://develop.svn.wordpress.org/trunk@34487


git-svn-id: http://core.svn.wordpress.org/trunk@34451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 09:16:25 +00:00
Dominik Schilling 340b7a5289 Edit Post: Add missing periods.
See #31858.
Built from https://develop.svn.wordpress.org/trunk@34486


git-svn-id: http://core.svn.wordpress.org/trunk@34450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 08:54:26 +00:00
Drew Jaynes e5e03e787c Docs: Link up a hook reference with an inline `@see` tag in the return description for `get_locale()`.
Missed in [34484].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34485


git-svn-id: http://core.svn.wordpress.org/trunk@34449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:51:23 +00:00
Drew Jaynes 81e135955a Docs: Fix the summary for `get_locale()`.
Also update the description to properly link up hook references with inline `@see` tags.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34484


git-svn-id: http://core.svn.wordpress.org/trunk@34448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:50:24 +00:00
Drew Jaynes 1c761505b6 Docs: Clarify the file header summary for wp-includes/l10n.php and add the version it was introduced.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34483


git-svn-id: http://core.svn.wordpress.org/trunk@34447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:47:24 +00:00
Drew Jaynes f64c19aa95 Docs: Split the DocBlock summary for `__()` into a summary and description.
Also, notate the default value for the optional `$domain` parameter.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34482


git-svn-id: http://core.svn.wordpress.org/trunk@34446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:43:26 +00:00
Drew Jaynes 90f61eff52 Docs: Add a summary to the hook doc for the `nav_menu_item_args` filter, introduced in [34471].
Fixes #29417.

Built from https://develop.svn.wordpress.org/trunk@34481


git-svn-id: http://core.svn.wordpress.org/trunk@34445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 05:09:24 +00:00
Scott Taylor 4e9c1692b0 Post Thumbnails: In `get_the_post_thumbnail_url()`, return `false` instead of empty string when no URL is available.
Fixes #33070.

Built from https://develop.svn.wordpress.org/trunk@34480


git-svn-id: http://core.svn.wordpress.org/trunk@34444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 04:38:25 +00:00
Scott Taylor 03d630d705 Unit Tests: after [34477], make `Tests_Link_GetPostCommentsFeedLink` more respectable.
See #33693.

Built from https://develop.svn.wordpress.org/trunk@34479


git-svn-id: http://core.svn.wordpress.org/trunk@34443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 04:32:25 +00:00
Gary Pendergast 1b91141437 WPDB: When attempting to fall back to `ext/mysql` in `db_connect()`, return the result of the fall back.
While it doesn't affect Core, we should also be passing the `$allow_bail` parameter, for anything that uses it differently.

Props markoheijnen, johnbillion.

Fixes #33105.


Built from https://develop.svn.wordpress.org/trunk@34478


git-svn-id: http://core.svn.wordpress.org/trunk@34442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 04:30:25 +00:00
Scott Taylor 43b7192e8e Feeds/Links: after [34336], use a different meat cleaver to fix Rewrite spillage across test cases.
Fixes #33693.

Built from https://develop.svn.wordpress.org/trunk@34477


git-svn-id: http://core.svn.wordpress.org/trunk@34441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 04:20:25 +00:00
Scott Taylor 7a154ca666 WP: after [34443], calling `get_queried_object()` messes up unit tests. We can just clone the `$post` prop and call it a day.
Fixes #20226.

Built from https://develop.svn.wordpress.org/trunk@34476


git-svn-id: http://core.svn.wordpress.org/trunk@34440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:54:24 +00:00
Scott Taylor b6e70baa04 Plugins: on the plugins admin screen, the "has been deleted" string needs a plural.
Props jmayhak.
Fixes #33239.

Built from https://develop.svn.wordpress.org/trunk@34475


git-svn-id: http://core.svn.wordpress.org/trunk@34439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:42:25 +00:00
Scott Taylor ffb8ae1a63 Date/Time: Add unit tests for `the_date()`.
Props jubstuff.
Fixes #33750.

Built from https://develop.svn.wordpress.org/trunk@34474


git-svn-id: http://core.svn.wordpress.org/trunk@34438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:34:24 +00:00
Scott Taylor d6155dd405 Edit Post: After [33666], separate the translation string for pages, avoiding HTML usage.
Props ramiy.
Fixes #31858.

Built from https://develop.svn.wordpress.org/trunk@34473


git-svn-id: http://core.svn.wordpress.org/trunk@34437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:28:24 +00:00
Scott Taylor 8cc5a142e4 Media Modal: move the translation strings for `insertIntoPost` and `uploadedToThisPost` to the `get_post_type_labels()` array as `insert_into_item` and `uploaded_to_this_item`.
Props flixos90.
Fixes #33616.

Built from https://develop.svn.wordpress.org/trunk@34472


git-svn-id: http://core.svn.wordpress.org/trunk@34436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:22:24 +00:00
Scott Taylor 0c1f92e301 Nav Menus: Add a 'nav_menu_item_args' filter to `Walker_Nav_Menu::start_el()`.
Props bjornjohansen.
Fixes #29417.

Built from https://develop.svn.wordpress.org/trunk@34471


git-svn-id: http://core.svn.wordpress.org/trunk@34435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:17:24 +00:00
Scott Taylor d165b25920 Include fourth array parameter in return value doc block for `wp_get_attachment_image_src()`.
Props kadamwhite.
Fixes #33905.

Built from https://develop.svn.wordpress.org/trunk@34470


git-svn-id: http://core.svn.wordpress.org/trunk@34434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:14:24 +00:00
Scott Taylor 2071978a3f After [34341], add translation strings.
Props ramiy.
Fixes #31862.

Built from https://develop.svn.wordpress.org/trunk@34469


git-svn-id: http://core.svn.wordpress.org/trunk@34433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:09:24 +00:00
Gary Pendergast 0f27ceae56 Tests: Remove a `var_dump()` added in [34373].
See #33070.


Built from https://develop.svn.wordpress.org/trunk@34468


git-svn-id: http://core.svn.wordpress.org/trunk@34432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:08:26 +00:00
Scott Taylor 25f206e01f List Tables: add JS code to dynamically toggle the `disabled` attribute of the Bulk Actions dropdown and Apply button.
Props wonderboymusic, pareshradadiya.
Fixes #31634.

Built from https://develop.svn.wordpress.org/trunk@34467


git-svn-id: http://core.svn.wordpress.org/trunk@34431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 01:07:24 +00:00
Scott Taylor df9c242a5e Users: in `WP_User::__unset()`, don't reset the deprecated prop `id` to `ID`. Still throw the deprecated notice.
Update unit test.

Fixes #20043.

Built from https://develop.svn.wordpress.org/trunk@34466


git-svn-id: http://core.svn.wordpress.org/trunk@34430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 00:49:25 +00:00
Scott Taylor 627e7a56d3 Widgets: when passing a string arg value to `dynamic_sidebar()`, don't reset `$index` when the arg's sanitized value matches the sanitized name of a sidebar.
Adds unit test.

Props tyxla, fjarrett.
Fixes #23423.

Built from https://develop.svn.wordpress.org/trunk@34465


git-svn-id: http://core.svn.wordpress.org/trunk@34429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 00:30:24 +00:00
Scott Taylor ad2ddad259 Recent Posts Widget: remove HTML fragment caching. The cache currently doesn't work cross-scheme and causes mixed content issues for links. The widget was written pre-`$split_the_query`, after which post objects can be served from the cache.
Fixes #27565.

Built from https://develop.svn.wordpress.org/trunk@34464


git-svn-id: http://core.svn.wordpress.org/trunk@34428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 00:17:24 +00:00
Scott Taylor a2914473cc Calendar Widget: remove the `title` attribute for days and replace with `aria-label`. Spruce up some of this nasty code. Delete unnecessary bits.
Props wonderboymusic, elusiveunit, 5um17. 
Fixes #30297.

Built from https://develop.svn.wordpress.org/trunk@34463


git-svn-id: http://core.svn.wordpress.org/trunk@34427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 23:57:27 +00:00
John Blackbourn bdcf5717de Send a 500 HTTP response code when the server's PHP or MySQL checks fail.
Fixes #33689
Props jeichorn

Built from https://develop.svn.wordpress.org/trunk@34462


git-svn-id: http://core.svn.wordpress.org/trunk@34426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 21:57:26 +00:00
Scott Taylor 652a3030e1 Comments: allow meta boxes for Discussion and Comments in extenuating circumstances.
* Discussion: Post Type stops supporting comments, but comments and/or pings are open on a post. 
* Comments: Post is published or private, the post type has stopped supporting comments, but comments and/or pings are open on a post.

Currently, there is no way to toggle those settings off.

Props couturefreak, wonderboymusic, rachelbaker.
Fixes #28080.

Built from https://develop.svn.wordpress.org/trunk@34461


git-svn-id: http://core.svn.wordpress.org/trunk@34425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 19:49:26 +00:00
Boone Gorges 3c028a80d4 Allow `comment_exists()` to match based on GMT date.
The `comment_date_gmt` field of the `wp_comments` table is indexed, which makes
`WHERE` matches against the field much faster than against the unindexed
`comment_date`. For bulk operations like data import, the speed difference can
be meaningful.

We continue to default to 'blog' for `$timezone`, to preserve compatibility
with existing uses.

Props apokalyptik.
Fixes #33871.
Built from https://develop.svn.wordpress.org/trunk@34460


git-svn-id: http://core.svn.wordpress.org/trunk@34424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 18:16:26 +00:00
John Blackbourn 13109ed129 Add an entry for Cloudup to the list of oEmbed providers.
See #26278

Built from https://develop.svn.wordpress.org/trunk@34459


git-svn-id: http://core.svn.wordpress.org/trunk@34423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 16:00:25 +00:00
John Blackbourn af1517279e Avoid a PHP notice if the `last_updated` property isn't present in a plugin's data from the Plugins API.
Fixes #33024
Props icetee

Built from https://develop.svn.wordpress.org/trunk@34458


git-svn-id: http://core.svn.wordpress.org/trunk@34422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 15:10:25 +00:00
Boone Gorges 6fd566d97b Fix `comment_exists()` unit test introduced in [34456].
See #33871.
Built from https://develop.svn.wordpress.org/trunk@34457


git-svn-id: http://core.svn.wordpress.org/trunk@34421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 14:47:26 +00:00
Boone Gorges e82de129f4 Add unit test for `comment_exists()`.
See #33871.
Built from https://develop.svn.wordpress.org/trunk@34456


git-svn-id: http://core.svn.wordpress.org/trunk@34420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 14:35:26 +00:00
Boone Gorges 9d7a685a20 Multisite: Don't limit site titles to 50 chars.
This restriction dates from ye olden times, ie https://mu.trac.wordpress.org/changeset/1140.
It is no longer relevant.

Props chriscct7, theode.
Fixes #33973.
Built from https://develop.svn.wordpress.org/trunk@34455


git-svn-id: http://core.svn.wordpress.org/trunk@34419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 14:24:24 +00:00
Boone Gorges a034a3394a Bail early when invalid ID is passed to `get_comment_class()`.
This helps to avoid PHP notices later in the function.

Props walterebert, dipesh.kakadiya, DrewAPicture.
Fixes #33947.
Built from https://develop.svn.wordpress.org/trunk@34454


git-svn-id: http://core.svn.wordpress.org/trunk@34418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 14:09:26 +00:00
Boone Gorges 79c3a17060 Add a few simple tests for `get_comment_class()`.
Props walterebert, dipesh.kakadiya.
See #33947.
Built from https://develop.svn.wordpress.org/trunk@34453


git-svn-id: http://core.svn.wordpress.org/trunk@34417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 14:05:27 +00:00
Scott Taylor 6dc400395c Links: the `esc_html()` additions in [34444] aren't very nice to screen reader `<span>`s. Revert those specific calls.
See #14900.

Built from https://develop.svn.wordpress.org/trunk@34452


git-svn-id: http://core.svn.wordpress.org/trunk@34416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 04:26:27 +00:00
Sergey Biryukov 18d95526f6 Make the `'register_post_type_args'` filter introduced in [34242] available for built-in post types too.
Props MikeSchinkel.
Fixes #17447.
Built from https://develop.svn.wordpress.org/trunk@34451


git-svn-id: http://core.svn.wordpress.org/trunk@34415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 22:32:24 +00:00
John Blackbourn 2d694c931a Add tests for some missing capabilities, including `do_not_allow`.
See #32394.

Built from https://develop.svn.wordpress.org/trunk@34450


git-svn-id: http://core.svn.wordpress.org/trunk@34414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 22:18:25 +00:00
John Blackbourn 36adca9092 Correct a capability name in the roles and capabilities mapping. The `delete_others_pages` key was missing, and the `delete_others_posts` key was duplicated.
Introduced in [32812].

See #32394.

Built from https://develop.svn.wordpress.org/trunk@34449


git-svn-id: http://core.svn.wordpress.org/trunk@34413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 22:16:26 +00:00
Aaron Jorbin 8494e6294a Add test image for test_exif_keywords test
[34374] added a test that relies on a new test image. This test image wasn't included in the commit.  This fixes the broken Tests_Image_Meta::test_exif_keywords test.

Props swissspidy, SteveHoneyNZ.
Fixes #33772.


Built from https://develop.svn.wordpress.org/trunk@34448


git-svn-id: http://core.svn.wordpress.org/trunk@34412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 21:43:25 +00:00
John Blackbourn ca1c40abbc Implement a test for capabilities for a custom post type that uses `capability_type => page`.
See #17253

Built from https://develop.svn.wordpress.org/trunk@34447


git-svn-id: http://core.svn.wordpress.org/trunk@34411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 21:01:24 +00:00
Scott Taylor 939d9b7395 Remove some unused globals and/or their docs.
See ##33491.

Built from https://develop.svn.wordpress.org/trunk@34446


git-svn-id: http://core.svn.wordpress.org/trunk@34410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 20:27:25 +00:00
Scott Taylor d866a40d09 After [34444​], `wp_get_shortlink()` can call `get_queried_object_id()` instead of using the `$wp_query` global.
See #14900.

Built from https://develop.svn.wordpress.org/trunk@34445


git-svn-id: http://core.svn.wordpress.org/trunk@34409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 20:09:23 +00:00
Scott Taylor 7cbd096c2b Links: use consistent late-escaping in some HTML link-generation functions:
* `post_comments_feed_link()`
* `edit_post_link()`
* `edit_comment_link()`
* `edit_bookmark_link()`
* `rel_canonical()`

Props niallkennedy, wonderboymusic.
Fixes #14900.

Built from https://develop.svn.wordpress.org/trunk@34444


git-svn-id: http://core.svn.wordpress.org/trunk@34408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 20:06:24 +00:00
Scott Taylor 4cdd0b1688 PINGBACKS: After [34442], switch to `is_singular()` to check attachments and pages as well.
See #20226.

Built from https://develop.svn.wordpress.org/trunk@34443


git-svn-id: http://core.svn.wordpress.org/trunk@34407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 19:10:29 +00:00
Scott Taylor 3bbd53c717 PINGBACKS: rather than sending the `X-Pingback` HTTP header on every single request for fun, perhaps only send it on single posts with pings open.
See #20226.

Built from https://develop.svn.wordpress.org/trunk@34442


git-svn-id: http://core.svn.wordpress.org/trunk@34406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 18:47:25 +00:00
Drew Jaynes 32358bbcdd Docs: Actually, the subpackage for `Walker_Page` should be Template.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34441


git-svn-id: http://core.svn.wordpress.org/trunk@34405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 15:09:24 +00:00
Drew Jaynes 07cb271a45 Docs: Add a file header to wp-includes/widgets/class-wp-widget-text.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Text`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34440


git-svn-id: http://core.svn.wordpress.org/trunk@34404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 15:04:26 +00:00