4c019c6aee
Comments: Fix a fatal error in Comments meta box after [34223].
...
Props tyxla.
Fixes #33893 . See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34231
git-svn-id: http://core.svn.wordpress.org/trunk@34195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 11:37:25 +00:00
faa54e4dc2
Docs: Make a minor adjustment to the description syntax for the optional `$comment` argument in the DocBlock for `comment_link()`, introduced in [34071].
...
See #33638 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34230
git-svn-id: http://core.svn.wordpress.org/trunk@34194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 11:02:24 +00:00
3c73b53f66
Docs: Remove markdown from the DocBlock summary for `WP_List_Table::get_primary_column()`, introduced in [34166].
...
The PHP inline documentation standards for [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description summaries] call for not using an markup or markdown. Also, using the full Class::method() in this context allows for better clarity in what is being referenced.
See #33854 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34229
git-svn-id: http://core.svn.wordpress.org/trunk@34193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 10:51:25 +00:00
c52a7d863e
Docs: Add a changelog entry for the switch to using `wp_get_attachment_url()` instead of the guid for determining the header image URL in `Custom_Image_Header::step_3()`.
...
The change was introduced in [34188].
See #33319 .
Built from https://develop.svn.wordpress.org/trunk@34228
git-svn-id: http://core.svn.wordpress.org/trunk@34192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 10:43:25 +00:00
4279a9c39e
Docs: Improve documentation for the `WP_Object_Cache` class.
...
Spaces out parameter documentation for readability, fixes some minor syntactical issues, and adds some missing `@access` tags or reorders tags according to the PHP docs standards.
Also, documents `&$found`, the fourth parameter for the `get()` method, and adds missing parameter and return descriptions for the `_exists()` utility method.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34227
git-svn-id: http://core.svn.wordpress.org/trunk@34191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 10:03:26 +00:00
5172621c1d
Docs: Remove an errant change made to a `_deprecated_function()` call in `wp_cache_reset()` introduced in [34225].
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34226
git-svn-id: http://core.svn.wordpress.org/trunk@34190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 09:42:24 +00:00
4e4737685e
Docs: Add more complete documentation for top-level object cache functionality.
...
Adds some `@see` tags for corresponding `WP_Object_Cache` methods to DocBlocks for top-level functions. Also adds a standard description for the `@global` tags, spacing for parameter docs readability, and finally, properly marks optional parameters as such.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34225
git-svn-id: http://core.svn.wordpress.org/trunk@34189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 09:40:25 +00:00
a7ea95f53a
Docs: Add documentation for `$object_id`, the optional second parameter in `current_user_can()` and `WP_User::has_cap()`, and the optional third parameter in `map_meta_cap()`.
...
This change introduces the vernacular of "meta" vs "primitive" capabilities to core docs, and providing examples for each inline and attempts to make it clear that `$object_id` is really only useful if the passed `$capability` is of the meta cap variety.
Props jliman for the initial patch.
Fixes #32694 .
Built from https://develop.svn.wordpress.org/trunk@34224
git-svn-id: http://core.svn.wordpress.org/trunk@34188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 07:36:32 +00:00
5920e8eb13
Move `WP_Post_Comments_List_Table` to its own file.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34223
git-svn-id: http://core.svn.wordpress.org/trunk@34187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 06:53:24 +00:00
61bef72b95
Fix a typo in `wptexturize()` and `wp_replace_in_html_tags()` comments.
...
Props bobbingwide.
See #15694 .
Built from https://develop.svn.wordpress.org/trunk@34222
git-svn-id: http://core.svn.wordpress.org/trunk@34186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 05:54:26 +00:00
1bd52ae1aa
Fire Action when mail exception is thrown.
...
new action is wp_mail_failed which contains a WP_Error object with the phpmailerException code, message and an array with the mail information. Plugins can hook in and log when mails fail to send due to a phpmailer issue.
Props soulseekah
Fixes #18926
Built from https://develop.svn.wordpress.org/trunk@34221
git-svn-id: http://core.svn.wordpress.org/trunk@34185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 23:51:23 +00:00
628caeb487
Customizer: Smooth animation for closing accordions in the available nav menu items pane.
...
Props tyxla.
Fixes #33360 for trunk.
Built from https://develop.svn.wordpress.org/trunk@34219
git-svn-id: http://core.svn.wordpress.org/trunk@34183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 23:40:24 +00:00
a7e229637e
Improve validation of `user_login` and `user_nicename` length.
...
The `user_login` field only allows 60 characters, and `user_nicename` allows
50. However, there are no protections in the interface, and few in the code,
that prevent the creation of users with values in excess of these limits. Prior
to recent changes in `$wpdb`, users were generally created anyway, MySQL
having performed the necessary truncation. More recently, the `INSERT`s and
`UPDATE`s simply fail, with no real feedback on the nature of the failure.
This changeset addresses the issue in a number of ways:
* On the user-new.php and network/user-new.php panels, don't allow input in excess of the maximum field length.
* In `wp_insert_user()`, throw an error if the value provided for `'user_login'` or `'user_nicename'` exceeds the maximum field length.
* In `wp_insert_user()`, when using `'user_login'` to generate a default value for `'user_nicename'`, ensure that the nicename is properly truncated, even when suffixed for uniqueness (username-2, etc).
Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges.
Fixes #33793 .
Built from https://develop.svn.wordpress.org/trunk@34218
git-svn-id: http://core.svn.wordpress.org/trunk@34182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 22:14:26 +00:00
cfbd3c2cc0
Omit the `ORDER BY` clause when updating object term cache.
...
The `ORDER BY` clause was forcing filesorts on large tables, and is
unnecessary, since term order doesn't matter when updating the cache.
Props mbrandys, wonderboymusic.
Fixes #28922 .
Built from https://develop.svn.wordpress.org/trunk@34217
git-svn-id: http://core.svn.wordpress.org/trunk@34181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 20:53:33 +00:00
4139daea5e
Apply the new `'respond_link'` filter in `comments_popup_link()` if `$number` is `0` before outputting the URL.
...
Props joedolson.
Fixes #29454 .
Built from https://develop.svn.wordpress.org/trunk@34216
git-svn-id: http://core.svn.wordpress.org/trunk@34180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 20:46:35 +00:00
8573a86def
In `WP::parse_request()`, don't add query vars of non-viewable post types to `WP::public_query_vars`. In `register_post_type()`, don't add query vars of non-viewable post types to `WP::public_query_vars`.
...
In `_unregister_post_type()` (unit tests), don't add query vars of non-viewable post types to `WP::public_query_vars`.
Adds unit test.
Fixes #30018 .
Built from https://develop.svn.wordpress.org/trunk@34215
git-svn-id: http://core.svn.wordpress.org/trunk@34179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 18:54:30 +00:00
d5e02c6129
After [34188], fix unit test for image header.
...
See #33319 .
Built from https://develop.svn.wordpress.org/trunk@34214
git-svn-id: http://core.svn.wordpress.org/trunk@34178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 18:44:48 +00:00
a9e5cfddc7
Implement `wp_login_url()` and `wp_registration_url()` in places where `wp-login.php` is currently hard-coded.
...
See #31495
Props GregLone
Built from https://develop.svn.wordpress.org/trunk@34213
git-svn-id: http://core.svn.wordpress.org/trunk@34177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 17:11:35 +00:00
f5edeb11d0
`WP_Comment_Query`: add `comment__in` to allowed values for `$orderby`.
...
Adds unit tests.
Fixes #33883 .
Built from https://develop.svn.wordpress.org/trunk@34212
git-svn-id: http://core.svn.wordpress.org/trunk@34176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 16:35:44 +00:00
72651400ba
Add `parent__in` and `parent__not_in` query vars to `WP_Comment_Query`.
...
Adds unit tests.
Fixes #33882 .
Built from https://develop.svn.wordpress.org/trunk@34205
git-svn-id: http://core.svn.wordpress.org/trunk@34169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 16:23:39 +00:00
0a4bf88cc9
Docs: Update the hook doc summary for the `wp_http_ixr_client_headers` filter, introduced in [34164].
...
The idea is to try to reflect what the filterable value is rather than why it's filterable.
Fixes #24598 .
Built from https://develop.svn.wordpress.org/trunk@34203
git-svn-id: http://core.svn.wordpress.org/trunk@34167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 16:16:43 +00:00
ff3ae0e747
Don't redirect to the Term list table after submitting the form on the Edit Term page.
...
Props chiragswadia, UmeshSingla, rhyswynne, afercia.
Fixes #17455 .
Built from https://develop.svn.wordpress.org/trunk@34202
git-svn-id: http://core.svn.wordpress.org/trunk@34166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 15:59:42 +00:00
b07b68490f
Allow `get_lastpostdate()`, `get_lastpostmodified()`, and `_get_last_post_time()` to accept `$post_type` and cache separately.
...
Props _duck, SergeyBiryukov.
See #17455 .
Built from https://develop.svn.wordpress.org/trunk@34201
git-svn-id: http://core.svn.wordpress.org/trunk@34165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 15:25:31 +00:00
4a34994e54
Allow `wp_page_menu()` to accept `'walker'`, `'before'`, and `'after'` to allow custom markup.
...
Fixes #11095 .
Built from https://develop.svn.wordpress.org/trunk@34200
git-svn-id: http://core.svn.wordpress.org/trunk@34164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 15:06:30 +00:00
57d2420ae5
Similar to #33386 , don't use `guid` when retrieving URL for a cropped header image in the Customizer.
...
Props polevaultweb.
Fixes #33319 .
Built from https://develop.svn.wordpress.org/trunk@34188
git-svn-id: http://core.svn.wordpress.org/trunk@34156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 14:46:32 +00:00
80165bfc4a
Comments: When setting the `colspan` value for inline edit/reply, make sure it's actually a table and the value is not empty.
...
Props afercia.
Fixes #33596 .
Built from https://develop.svn.wordpress.org/trunk@34179
git-svn-id: http://core.svn.wordpress.org/trunk@34147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 13:44:34 +00:00
a5a8ae45a6
Remove outdated references to the `preview_post_link` filter docs.
...
See #24345
Props paulwilde
Built from https://develop.svn.wordpress.org/trunk@34178
git-svn-id: http://core.svn.wordpress.org/trunk@34146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 10:32:31 +00:00
541dbb2711
Remove the ability to view the post listing screen and post editing screen for post types with `show_ui` set to `false`. It is unexpected and unintended behaviour that this is allowed.
...
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_post_type()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu`, `show_in_nav_menus`, and `show_in_admin_bar` are `false`.
Fixes #33763
Props swissspidy, johnbillion
Built from https://develop.svn.wordpress.org/trunk@34177
git-svn-id: http://core.svn.wordpress.org/trunk@34145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 10:27:29 +00:00
caf90ec1c6
Improve the docblocks for the `get_preview_post_link()` function and the `preview_post_link` filter.
...
See #24345
Built from https://develop.svn.wordpress.org/trunk@34176
git-svn-id: http://core.svn.wordpress.org/trunk@34144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:25:25 +00:00
9cd91030a6
Correct the value of the `preview` query variable added by `get_preview_post_link()`.
...
See #24345
Props kitchin
Built from https://develop.svn.wordpress.org/trunk@34175
git-svn-id: http://core.svn.wordpress.org/trunk@34143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:16:24 +00:00
fdb8400379
Place the filter docblock for `http_api_transports` immediately above the filter.
...
See #33413
Props dd32
Built from https://develop.svn.wordpress.org/trunk@34174
git-svn-id: http://core.svn.wordpress.org/trunk@34142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:12:25 +00:00
1bed706d27
Missed files from [34172].
...
See #33877
Built from https://develop.svn.wordpress.org/trunk@34173
git-svn-id: http://core.svn.wordpress.org/trunk@34141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:09:24 +00:00
ec0544e053
Initialise `$_SERVER[ 'REMOTE_ADDR' ]` during the test bootstrap so individual tests need not.
...
Fixes #33877
Fixes #25162
Built from https://develop.svn.wordpress.org/trunk@34172
git-svn-id: http://core.svn.wordpress.org/trunk@34140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:05:28 +00:00
ab6d1fa247
Use `get_attached_file()` in `attachment_submitbox_metadata()`.
...
Props kitchin.
Fixes #33386 .
Built from https://develop.svn.wordpress.org/trunk@34171
git-svn-id: http://core.svn.wordpress.org/trunk@34139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:18:25 +00:00
54829b6305
Create a function, `get_preview_post_link()`, to DRY the logic for applying the `'preview_post_link'` filter to a URL.
...
Props TomHarrigan, wonderboymusic.
Fixes #24345 .
Built from https://develop.svn.wordpress.org/trunk@34170
git-svn-id: http://core.svn.wordpress.org/trunk@34138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:15:25 +00:00
ee42803e21
Move `WP_Screen` to its own file.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34169
git-svn-id: http://core.svn.wordpress.org/trunk@34137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:08:24 +00:00
fde014e85e
Move the admin Nav Menu Walker subclasses into their own files. Load in `nav-menu.php` to remain BC.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34168
git-svn-id: http://core.svn.wordpress.org/trunk@34136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:02:25 +00:00
ed25b09942
Update post thumbnail functions to allow a `WP_Post` to be passed.
...
Adds unit tests.
Props swissspidy, Rahe.
Fixes #33723 .
Built from https://develop.svn.wordpress.org/trunk@34167
git-svn-id: http://core.svn.wordpress.org/trunk@34135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 03:46:25 +00:00
780487556b
Add a doc block to `WP_List_Table::get_primary_column()`.
...
Fixes #33854 .
Built from https://develop.svn.wordpress.org/trunk@34166
git-svn-id: http://core.svn.wordpress.org/trunk@34134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 03:35:25 +00:00
ab777c54cc
Ensure that widget carets close when dragging an expanded widget.
...
Props sdavis2702, mindctrl.
Fixes #33578 .
Built from https://develop.svn.wordpress.org/trunk@34165
git-svn-id: http://core.svn.wordpress.org/trunk@34133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 03:10:24 +00:00
1b0121a841
Add a filter to allow custom headers to be sent via the WP HTTP IXR client: `'wp_http_ixr_client_headers'`.
...
Props ericmann.
Fixes #24598 .
Built from https://develop.svn.wordpress.org/trunk@34164
git-svn-id: http://core.svn.wordpress.org/trunk@34132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 02:54:24 +00:00
191400f9e6
Don't ever use the `guid` value when retrieving URLs for media, use `wp_get_attachment_url()`. Use `get_attached_file()` for path to file.
...
Fixes #33386 .
Built from https://develop.svn.wordpress.org/trunk@34163
git-svn-id: http://core.svn.wordpress.org/trunk@34131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 02:50:25 +00:00
d7d5789088
TwentyFifteen|Sixteen themes have a `<div id="content">` in the header. Change the `<div>` IDs in `wp-activate.php` and `wp-signup.php` to be unique to each page.
...
Props jfarthing84.
Fixes #33843 .
Built from https://develop.svn.wordpress.org/trunk@34162
git-svn-id: http://core.svn.wordpress.org/trunk@34130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 02:09:24 +00:00
69e3a390b2
In `_wp_ajax_delete_comment_response()`, read the new `'all'` prop returned by `get_comment_count()` via `wp_count_comments()` when setting `$total`. `'all'` doesn't include `spam` in its count.
...
Updates unit tests.
Props dipesh.kakadiya.
Fixes #32362 .
Built from https://develop.svn.wordpress.org/trunk@34161
git-svn-id: http://core.svn.wordpress.org/trunk@34129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 01:47:25 +00:00
cf2aaf8393
In `get_avatar_data()`, promote `stdClass` objects to `WP_Comment` if passed.
...
Props DrewAPicture, ocean90.
Fixes #32619 .
Built from https://develop.svn.wordpress.org/trunk@34160
git-svn-id: http://core.svn.wordpress.org/trunk@34128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 01:34:25 +00:00
387f271ea5
After [34070], account for the new ID in Quick Edit JS.
...
Props afercia.
Fixes #33770 .
Built from https://develop.svn.wordpress.org/trunk@34159
git-svn-id: http://core.svn.wordpress.org/trunk@34127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 01:31:26 +00:00
31c2bfd69d
More bonkers comment cache cleanup: toggle `wp_defer_comment_counting()` in `wp_insert_post()` and `wp_insert_attachment()`. Move the cache deletion in `wp_update_comment_count_now()` to before the `get_post()` call, so that the caches get deleted even if the post has already been deleted and the function returns early.
...
See #33875 .
Built from https://develop.svn.wordpress.org/trunk@34158
git-svn-id: http://core.svn.wordpress.org/trunk@34126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 00:58:26 +00:00
8479ff90bc
Ensure that the count cache for `all` is in sync with `comment-{$post_id}` values. These are the values most often relied-upon by the list table for comments.
...
Adds unit tests.
See #33875 .
Built from https://develop.svn.wordpress.org/trunk@34136
git-svn-id: http://core.svn.wordpress.org/trunk@34104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:39:24 +00:00
e932a2dc5d
XMLRPC: Don't allow private posts to be sticky.
...
See #20662 .
Built from https://develop.svn.wordpress.org/trunk@34135
git-svn-id: http://core.svn.wordpress.org/trunk@34103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:38:23 +00:00
3778cae8ec
Shortcodes: don't allow unclosed HTML elements in attributes
...
Built from https://develop.svn.wordpress.org/trunk@34134
git-svn-id: http://core.svn.wordpress.org/trunk@34102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:36:24 +00:00
097c4fd2f4
List tables: escape user e-mails
...
Better safe than sorry.
Built from https://develop.svn.wordpress.org/trunk@34133
git-svn-id: http://core.svn.wordpress.org/trunk@34101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:33:25 +00:00
1a01a9ab55
In the `edit-comments.php` admin handler, toggle `wp_defer_comment_counting()` so that only unique post IDs have their comment count updated. Currently, if you delete 50 comments from the same post, the count would get reset 50 times. Not joking.
...
See #33875 .
Built from https://develop.svn.wordpress.org/trunk@34132
git-svn-id: http://core.svn.wordpress.org/trunk@34100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:24:26 +00:00
60367d567d
The "counts" cache for comments by post id is never invalidated. Neither `wp_update_comment_count()` nor `wp_update_comment_count_now()` touch the cache.
...
Adds unit test.
See #33875 .
Built from https://develop.svn.wordpress.org/trunk@34131
git-svn-id: http://core.svn.wordpress.org/trunk@34099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:04:26 +00:00
7639a89a1f
`wp_unspam_comment()` can accept a full object instead of comment_ID to reduce cache/db lookups..
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34130
git-svn-id: http://core.svn.wordpress.org/trunk@34098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 21:47:25 +00:00
b1bc8a6522
More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups.
...
See ##33638.
Built from https://develop.svn.wordpress.org/trunk@34129
git-svn-id: http://core.svn.wordpress.org/trunk@34097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 21:40:24 +00:00
b2a30103ae
In `WP_List_Table`, make a new `public` method, `->get_primary_column()`, and revert [34101] due to BC issues.
...
Fixes #33854 .
Built from https://develop.svn.wordpress.org/trunk@34128
git-svn-id: http://core.svn.wordpress.org/trunk@34096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 20:29:26 +00:00
4d33644373
In `WP_Media_List_Table`, fetch all pending comment counts at once, instead of for each row in the loop.
...
See #11381 .
Built from https://develop.svn.wordpress.org/trunk@34127
git-svn-id: http://core.svn.wordpress.org/trunk@34095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 19:25:25 +00:00
dbe4a770d5
Implement unit tests which use reflection to test functions in pluggable.php. This means any changes to these functions will need explicit changes to their corresponding tests, which helps prevent unintentional breakage.
...
Fixes #33867
Built from https://develop.svn.wordpress.org/trunk@34126
git-svn-id: http://core.svn.wordpress.org/trunk@34094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 19:15:27 +00:00
ef474c6970
Accept 'ID' as a valid `$field` in `get_user_by()`.
...
We already accept 'id'. `ID` more closely matches the database and
`WP_User` schemas.
Props Shelob9.
Fixes #33869 .
Built from https://develop.svn.wordpress.org/trunk@34125
git-svn-id: http://core.svn.wordpress.org/trunk@34093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 18:58:26 +00:00
a78e850e9c
Add the site icon meta tags to `wp-login.php`.
...
See #33597
Props iworks
Built from https://develop.svn.wordpress.org/trunk@34124
git-svn-id: http://core.svn.wordpress.org/trunk@34092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 18:02:24 +00:00
3a0db2a22f
Fix the case-sensitivity of some HTTP class usage.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34123
git-svn-id: http://core.svn.wordpress.org/trunk@34091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 17:37:25 +00:00
bc6af23302
Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests.
...
Fixes #25162
Built from https://develop.svn.wordpress.org/trunk@34122
git-svn-id: http://core.svn.wordpress.org/trunk@34090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 17:10:26 +00:00
edd0f2b32f
Docs: Add missing parameter and return descriptions for `Walker::get_number_of_root_elements()`.
...
Fixes #33662 .
Built from https://develop.svn.wordpress.org/trunk@34121
git-svn-id: http://core.svn.wordpress.org/trunk@34089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 15:33:27 +00:00
d9bc36d068
Escape class attribute in `edit_post_link()` after [34098].
...
Props Offereins.
See #30563 .
Built from https://develop.svn.wordpress.org/trunk@34117
git-svn-id: http://core.svn.wordpress.org/trunk@34085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 13:01:25 +00:00
4af3a3374e
Passwords: Deprecate second parameter of `wp_new_user_notification()`.
...
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.
Adds unit tests.
Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654 .
(Don't ask for new pluggables kthxbye)
Built from https://develop.svn.wordpress.org/trunk@34116
git-svn-id: http://core.svn.wordpress.org/trunk@34084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 12:43:26 +00:00
97c0303f41
Docs: Add a changelog entry for the `$class` argument added to `edit_post_link()` in [34098].
...
Fixes #30563 .
Built from https://develop.svn.wordpress.org/trunk@34115
git-svn-id: http://core.svn.wordpress.org/trunk@34083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 12:20:26 +00:00
d36ffeb160
Passwords: Trigger a `wp-check-valid-field` event when the password field is filled with a password by `generatePassword()`.
...
Updates event handler in `wpAjax.invalidateForm()` to support `wp-check-valid-field`.
See #33406 .
Built from https://develop.svn.wordpress.org/trunk@34114
git-svn-id: http://core.svn.wordpress.org/trunk@34082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 10:39:27 +00:00
5020135a10
Add sanity checks in `map_meta_cap()`, return `'do_not_allow'` when posts don't exist.
...
Adds unit test.
Props ocean90, nerrad, filosofo.
Fixes #23162 .
Built from https://develop.svn.wordpress.org/trunk@34113
git-svn-id: http://core.svn.wordpress.org/trunk@34081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 04:44:26 +00:00
49803a45f3
Send multisite site/user signup emails via hooked functions.
...
Site and user signup notifications are moved to the new actions
`'after_signup_site'` and `'after_signup_user'`. Site and user activation
notifications are moved to the existing actions `'wpmu_activate_blog'` and
`'wpmu_activate_user'`.
Props dshanske, thomaswm, jeremyfelt.
See #33587..
Built from https://develop.svn.wordpress.org/trunk@34112
git-svn-id: http://core.svn.wordpress.org/trunk@34080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 03:28:24 +00:00
ecc4106ed1
Add an argument to `parent_dropdown()`, `$post`, to allow it to be called for an arbitrary post.
...
Fixes #23162 .
Built from https://develop.svn.wordpress.org/trunk@34111
git-svn-id: http://core.svn.wordpress.org/trunk@34079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 03:20:25 +00:00
172e37b007
Move `Walker_Category` and `Walker_CategoryDropdown` into their own files via `svn cp`. Remove them from `category-template.php`. Load them in `category.php`. `svn cp` `category.php` over to `category-functions.php`, which also loads now in `category.php`.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34110
git-svn-id: http://core.svn.wordpress.org/trunk@34078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 03:10:24 +00:00
4cec121d0b
Move `Walker_Page` and `Walker_PageDropdown` into their own files via `svn cp`. Remove them from `post-template.php`. Load them in `post.php`.
...
`post-template.php` loads after `post.php` in `wp-settings.php`. It could probably also be loaded in `post.php`, but avoiding that for the moment.
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34109
git-svn-id: http://core.svn.wordpress.org/trunk@34077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 02:59:24 +00:00
07c6fad006
In `wp_link_pages()`, ensure that `$prev` is greater than `0`.
...
Props betzster.
Fixes #25273 .
Built from https://develop.svn.wordpress.org/trunk@34108
git-svn-id: http://core.svn.wordpress.org/trunk@34076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 02:46:24 +00:00
b62bcef1b1
Send password-change email notifications via hook.
...
`wp_password_change_notification()` is now called at the 'after_password_reset'
action, rather than being invoked directly from the `reset_password()` function.
In order to make it possible to call `wp_password_change_notification()` as a
`do_action()` callback, the function signature has to be changed so that the
`$user` parameter is expected to be a value rather than a reference. Since
PHP 5.0, objects are passed by reference, so `&$user` was unnecessary anyway.
Props dshanske, thomaswm.
See #33587 .
Built from https://develop.svn.wordpress.org/trunk@34107
git-svn-id: http://core.svn.wordpress.org/trunk@34075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 02:45:25 +00:00
c614849786
Send comment notification emails via a hooked function.
...
Previously, `wp_notify_postauthor()` and `wp_notify_moderator()` were called
directly from `wp_new_comment()`, making it difficult to modify or suppress
default notification emails.
Props dshanske, thomaswm.
See #33587 .
Built from https://develop.svn.wordpress.org/trunk@34106
git-svn-id: http://core.svn.wordpress.org/trunk@34074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 02:17:26 +00:00
373d73f781
Turn off `autocomplete` for the `new-post-slug` field.
...
Props johnbillion.
Fixes #32752 .
Built from https://develop.svn.wordpress.org/trunk@34105
git-svn-id: http://core.svn.wordpress.org/trunk@34073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 02:03:25 +00:00
476b5c2046
When running on windows systems, normalise the capitalisation of the drive letter for more reliable string comparisons.
...
Props tyxla
Fixes #33265
Built from https://develop.svn.wordpress.org/trunk@34104
git-svn-id: http://core.svn.wordpress.org/trunk@34072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 01:59:25 +00:00
bae7312f03
Pass `$r` and `$pages` to the 'wp_dropdown_pages' and 'wp_list_pages' filters.
...
Props bigdawggi, SergeyBiryukov.
Fixes #23734 .
Built from https://develop.svn.wordpress.org/trunk@34103
git-svn-id: http://core.svn.wordpress.org/trunk@34071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 01:32:24 +00:00
9604c74f62
Objects are passed by-reference since PHP 5. In `_get_custom_object_labels()`, cast `$object->labels` back to `object` before returning. This function is weird.
...
Adds unit test.
Props Toro_Unit.
Fixes #33023 .
Built from https://develop.svn.wordpress.org/trunk@34102
git-svn-id: http://core.svn.wordpress.org/trunk@34070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 01:23:26 +00:00
ae6a3aee7f
Make `WP_List_Table::get_primary_column_name()` public in list table classes that have it.
...
Fixes #33854 .
Built from https://develop.svn.wordpress.org/trunk@34101
git-svn-id: http://core.svn.wordpress.org/trunk@34069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 01:12:25 +00:00
5077d917a3
Check if the `$post_type` passed to `get_post_type_object()` is a `scalar` value. Non-scalars were producing PHP warnings.
...
Adds unit tests.
Props Kloon.
Fixes #30013 .
Built from https://develop.svn.wordpress.org/trunk@34100
git-svn-id: http://core.svn.wordpress.org/trunk@34068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 00:03:24 +00:00
fa1e1a8850
Multisite: Implement the `get_by_path` method in `WP_Network`.
...
Move the internals of `get_network_by_path()` to `WP_Network()` and allow network objects to be retrieved by passing a requested domain and path.
Props johnjamesjacoby, jeremyfelt, drewapicture, wonderboymusic.
See #31985 .
Built from https://develop.svn.wordpress.org/trunk@34099
git-svn-id: http://core.svn.wordpress.org/trunk@34067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 23:40:24 +00:00
c745c2deb3
In `edit_post_link()`, add an argument for the class attribute that defaults to `post-edit-link`.
...
Props voldemortensen.
Fixes #30563 .
Built from https://develop.svn.wordpress.org/trunk@34098
git-svn-id: http://core.svn.wordpress.org/trunk@34066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 23:34:24 +00:00
16b4096779
Multisite: Introduce the `WP_Network` class.
...
A `WP_Network` object initially matches a row from `wp_site` and is populated with additional properties used by WordPress core. The first iteration is used to retrieve an existing network based on data passed to the class.
* A network can be retrieved by its ID through `WP_Network::get_instance()`, following in the steps of `WP_Post` and `WP_Comment`.
* A network object can be created or completed by passing initial properties in as a standard object to `new WP_Network()`.
Using these methods, we are now able to populate the global `$current_site` during load via this class.
Props johnjamesjacoby, jeremyfelt, drewapicture, wonderboymusic.
See #31985 .
Built from https://develop.svn.wordpress.org/trunk@34097
git-svn-id: http://core.svn.wordpress.org/trunk@34065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 23:31:26 +00:00
2a6793c7b2
Bump H3 headings to H2 on the Writing Settings screen for better accessibility.
...
Props mrahmadawais.
Fixes #33651 .
Built from https://develop.svn.wordpress.org/trunk@34096
git-svn-id: http://core.svn.wordpress.org/trunk@34064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 16:48:26 +00:00
7f772bdaff
Comments: Fix inline edit/reply on small screens.
...
props ocean90, SergeyBiryukov.
fixes #33596 .
Built from https://develop.svn.wordpress.org/trunk@34094
git-svn-id: http://core.svn.wordpress.org/trunk@34062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 12:47:27 +00:00
bd801ae5db
Customize: Remove redundant `aria-label` attributes.
...
Adds an `$options` array argument to `WP_Screen::render_screen_options()` to allow the `div#screen-options-wrap` element to be omitted when `wrap` value is `false`.
Props afercia, westonruter.
Fixes #33182 .
Built from https://develop.svn.wordpress.org/trunk@34093
git-svn-id: http://core.svn.wordpress.org/trunk@34061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 06:16:26 +00:00
f7a00464d5
Tests: Update `Tests_Feed_RSS::test_items` to expect new comment permalink structure.
...
Introduced in [34075] for posts without comments.
Props netweb.
Fixes #19893 .
Built from https://develop.svn.wordpress.org/trunk@34092
git-svn-id: http://core.svn.wordpress.org/trunk@34060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 23:31:25 +00:00
1ff03c9d6e
Fail gracefully when checking mapped cap against unregistered post type.
...
Post type objects are reponsible for mapping their capabilities to core caps.
As a result, when the post type is no longer registered, the caps are no
longer mapped. This causes problems when a post is left in the database after
the post type is no longer present, and WP does an 'edit_post' or other cap
check against it: a PHP notice is thrown, and the cap check always fails.
As a more graceful fallback, we map all post-type-dependent caps onto
'edit_others_posts', which allows highly privileged users to be able to
access orphaned content (such as comments belonging to disabled post types),
while minimizing the possibility of unintended privilege escalation.
We also add a `_doing_it_wrong()` notice, so that developers and site
administrators are aware that the cap mapping is failing in the absence of
the registered post type.
Props mitchoyoshitaka, DrewAPicture, imath, codeelite, boonebgorges, nofearinc, SergeyBiryukov, jorbin, dlh.
Fixes #16956 .
Built from https://develop.svn.wordpress.org/trunk@34091
git-svn-id: http://core.svn.wordpress.org/trunk@34059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 21:27:25 +00:00
c0a0d4ba50
Use stricter sanitization for meta query clause keys.
...
By forcing all clause keys to be strings, we make it possible to use strict
comparison when validating values of 'orderby' as passed to `WP_Query`. This
eliminates situations where the presence of numeric clause keys could result
in an improperly validated 'orderby' value.
Props nikolov.tmw.
Fixes #32937 .
Built from https://develop.svn.wordpress.org/trunk@34090
git-svn-id: http://core.svn.wordpress.org/trunk@34058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 21:06:24 +00:00
fc884dc7ec
Allow `setup_postdata()` to accept a post ID.
...
Previously, it accepted only a full post object.
Props sc0ttclark, mordauk, wonderboymusic.
Fixes #30970 .
Built from https://develop.svn.wordpress.org/trunk@34089
git-svn-id: http://core.svn.wordpress.org/trunk@34057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 20:58:23 +00:00
e0b1340461
Remove extraneous table join in `get_adjacent_post()`.
...
Since [29248], a table join has not been necessary to process the
`$excluded_terms` parameter of `get_adjacent_post()`. Aside from adding extra
overhead, this join meant that post records that don't have any corresponding
rows in `wp_term_relationships` were erroneously excluded from results.
Fixes #32833 .
Built from https://develop.svn.wordpress.org/trunk@34088
git-svn-id: http://core.svn.wordpress.org/trunk@34056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 20:34:24 +00:00
4d5cd90b46
Revert [34013] and parts of [33970].
...
* `_WP_Editors::wp_mce_translation()` can't be changed without changing strings in TinyMCE and plugins.
* `\u2026` is escaped by `json_encode()` to `\\u2026`, makes `\u2026` visible in our UI.
See #32875 .
Built from https://develop.svn.wordpress.org/trunk@34087
git-svn-id: http://core.svn.wordpress.org/trunk@34055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 20:03:24 +00:00
720cea8cf9
Themes: Don't use HTML entities for placeholders.
...
See #32875 .
Built from https://develop.svn.wordpress.org/trunk@34086
git-svn-id: http://core.svn.wordpress.org/trunk@34054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 19:48:24 +00:00
8977166746
In `wp_insert_post()`, when setting `$post_author`, use `isset()` instead of `! empty()` to allow `0` to be passed as the value for `$post_author`.
...
Adds unit tests.
Props ericdaams, wonderboymusic.
Fixes #32585 .
Built from https://develop.svn.wordpress.org/trunk@34085
git-svn-id: http://core.svn.wordpress.org/trunk@34053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 18:54:25 +00:00
8591f94b0a
`WP_Posts_List_Table`: there are a cadre of `edit.php` URLs that are generated by string-building instead of using our handy functions. Create a helper method, `->get_edit_link()` that standardizes the generation and escaping of these URLs.
...
Props BdN3504 for the initial patch on the ticket.
Fixes #32376 .
Built from https://develop.svn.wordpress.org/trunk@34084
git-svn-id: http://core.svn.wordpress.org/trunk@34052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 17:13:25 +00:00
a2aca8d063
Use `table-layout: auto` (instead of `fixed`) on `table.fixed` to ensure that things like date/time don't horrendously wrap on small screens. Before/After screenshots attached to the ticket.
...
Props gaelan.
Fixes #32691 .
Built from https://develop.svn.wordpress.org/trunk@34083
git-svn-id: http://core.svn.wordpress.org/trunk@34051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 16:04:25 +00:00
5a21742a6f
`wp_delete_post()`: add a filter, 'pre_delete_post', to allow bailout from the function if the filter returns a non-null value.
...
Props boonebgorges.
Fixes #32933 .
Built from https://develop.svn.wordpress.org/trunk@34082
git-svn-id: http://core.svn.wordpress.org/trunk@34050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 15:59:24 +00:00
891b76e034
`sanitize_post()`: the default value for `$context` is 'display'. The documentation says the default for `sanitize_post_field()` is 'display', but there is no default for the arg. Make the argument: `$context = 'default'`.
...
Props morganestes.
Fixes #33117 .
Built from https://develop.svn.wordpress.org/trunk@34081
git-svn-id: http://core.svn.wordpress.org/trunk@34049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 15:46:25 +00:00
0b412d3333
`sanitize_post()` is polymorphic, add an `is_array()` check for `$post` before operating on it as an array.
...
Props morganestes.
Fixes #33118 .
Built from https://develop.svn.wordpress.org/trunk@34080
git-svn-id: http://core.svn.wordpress.org/trunk@34048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 15:38:27 +00:00
620abd39a1
Bundled Themes: Update `Tested up to`.
...
Props mercime.
Fixes #33794 .
Built from https://develop.svn.wordpress.org/trunk@34079
git-svn-id: http://core.svn.wordpress.org/trunk@34047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 12:47:25 +00:00
281faeb69d
After [34076], fix the logic for `post_status` in months dropdown.
...
See #21015 .
Built from https://develop.svn.wordpress.org/trunk@34077
git-svn-id: http://core.svn.wordpress.org/trunk@34045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 08:19:24 +00:00
eb230b5424
List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination.
...
Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.
Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824 , #21015 , #21856 .
Built from https://develop.svn.wordpress.org/trunk@34076
git-svn-id: http://core.svn.wordpress.org/trunk@34044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 08:13:24 +00:00
41c5bfb493
Comments: `get_comments_link()` should return a link with `#respond` as the hash instead of `#comments` if `get_comments_number()` returns `0`.
...
Props cgrymala, wonderboymusic.
Fixes #19893 .
Built from https://develop.svn.wordpress.org/trunk@34075
git-svn-id: http://core.svn.wordpress.org/trunk@34043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 07:36:25 +00:00
ed83979728
AJAX Reply to Comment: check the `edit_comment` cap when parent comment will be auto-approved.
...
Props rachelbaker.
Fixes #23939 .
Built from https://develop.svn.wordpress.org/trunk@34074
git-svn-id: http://core.svn.wordpress.org/trunk@34042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 07:19:25 +00:00
1a203b5328
Better default values in `WP_Query::get_queried_object()`.
...
Setting the default value of the `queried_object_id` property to `0` meant
that, when called early enough in the WP bootstrap, `get_queried_object()`
could short-circuit the normal query by fooling it into thinking that the
request was for a page with id 0. Setting the default value to `null` instead
avoids this problem.
Props gradyetc, jazbek.
Fixes #31355 .
Built from https://develop.svn.wordpress.org/trunk@34073
git-svn-id: http://core.svn.wordpress.org/trunk@34041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 03:37:23 +00:00
4dbaf63b67
Edit Comment screen: remove the "View Comment" button (actually a link) from the publish meta box. Mimic the "Edit URL/Permalink" UI from the Edit Post screen to show the comment link below the screen title, but make it an actual link, not a button.
...
Props ocean90, DrewAPicture, wonderboymusic.
Fixes #19168 .
Built from https://develop.svn.wordpress.org/trunk@34072
git-svn-id: http://core.svn.wordpress.org/trunk@34040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 03:20:24 +00:00
1cbda0e1eb
Comments: `comment_link()` currently takes no arguments, yet `get_comment_link()` does. Allow `comment_link()` to optionally take the same arguments.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34071
git-svn-id: http://core.svn.wordpress.org/trunk@34039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 03:16:23 +00:00
821939d6d1
Quick Edit: fix an ID attribute name collision by renaming one of the author fields `author-name`.
...
Props afercia.
Fixes #33770 .
Built from https://develop.svn.wordpress.org/trunk@34070
git-svn-id: http://core.svn.wordpress.org/trunk@34038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 02:35:25 +00:00
b453af5718
When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on `commentsBox`, `->load()`, that resets `st` (cool name) to the number of visible `<tr>`s before calling `->get()`. This will account for spam'd and trash'd comments when returning comments at the proper offset.
...
Props utkarshpatel.
Fixes #33829 .
Built from https://develop.svn.wordpress.org/trunk@34069
git-svn-id: http://core.svn.wordpress.org/trunk@34037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 02:28:26 +00:00
a69e71fafe
Settings, password field: fix placement of the error icon and removal of the error class.
...
Props liljimmi, adamsilverstein.
Fixes #33406 for trunk.
Built from https://develop.svn.wordpress.org/trunk@34068
git-svn-id: http://core.svn.wordpress.org/trunk@34036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 00:10:25 +00:00
a751eccdf2
Bump H3 headings to H2 on the Plugin Editor screen for better accessibility.
...
Fixes #33839 .
Built from https://develop.svn.wordpress.org/trunk@34067
git-svn-id: http://core.svn.wordpress.org/trunk@34035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 00:08:24 +00:00
f446d01b4c
Bump H3 headings to H2 on the Theme Editor screen for better accessibility.
...
Props mrahmadawais.
Fixes #33660 .
Built from https://develop.svn.wordpress.org/trunk@34066
git-svn-id: http://core.svn.wordpress.org/trunk@34034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 00:00:24 +00:00
085d051305
Nav Menus: fix the quick search spinner position on Operating Systems that show scrollbars.
...
Fixes #33290 .
Built from https://develop.svn.wordpress.org/trunk@34065
git-svn-id: http://core.svn.wordpress.org/trunk@34033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:52:25 +00:00
5f5ea8c3e2
Quick Edit: fix the Tags auto-suggest tooltip visibility.
...
Be sure to hide the `jquery.suggest` Tags textarea tooltip also when using the keyboard to Save/Cancel.
Props rommelxcastro for the initial patch.
Fixes #32580 .
Built from https://develop.svn.wordpress.org/trunk@34064
git-svn-id: http://core.svn.wordpress.org/trunk@34032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:34:25 +00:00
e1ccdf760e
Settings: properly set the password field label on loading.
...
See #33778 .
Built from https://develop.svn.wordpress.org/trunk@34062
git-svn-id: http://core.svn.wordpress.org/trunk@34030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:05:24 +00:00
0406f50cfb
Settings: reassign the label when switching password fields so it always highlights the visible field.
...
Props umesh.nevase.
Fixes #33778 for trunk.
Built from https://develop.svn.wordpress.org/trunk@34061
git-svn-id: http://core.svn.wordpress.org/trunk@34029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 22:52:26 +00:00
efcdeea2f1
Passwords: Refresh password fields when content is pasted into fields.
...
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.
Props peterwilsoncc, adamsilverstein.
Fixes #33398 .
Built from https://develop.svn.wordpress.org/trunk@34060
git-svn-id: http://core.svn.wordpress.org/trunk@34028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 21:52:27 +00:00
cd7c0f0b0d
Introduce `wp_validate_action( $action = '' )`, a helper function that checks `$_REQUEST` for `action` and returns it, or empty string if not present. If `$action` is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types.
...
Implementing this removes 27 uses of direct superglobal access in the admin.
For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php
See #33837 .
Built from https://develop.svn.wordpress.org/trunk@34059
git-svn-id: http://core.svn.wordpress.org/trunk@34027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 21:08:26 +00:00
d6f26e4c7c
Site Icon: For preview fall back to `full` size URL when `thumbnail` size doesn't exist.
...
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.
Props tyxla.
Fixes #33417 .
Built from https://develop.svn.wordpress.org/trunk@34056
git-svn-id: http://core.svn.wordpress.org/trunk@34024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 20:13:25 +00:00
09b159e494
About: Remove period from placeholder.
...
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.
Props extendwings, chriscct7.
Fixes #33429 .
Built from https://develop.svn.wordpress.org/trunk@34054
git-svn-id: http://core.svn.wordpress.org/trunk@34022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 19:27:24 +00:00
a03488dbf6
Users: Import the global var `$wp_hasher` in `wp_new_user_notification()`.
...
Adds `@global` entries to the DocBlock.
Fixes #33826 .
Built from https://develop.svn.wordpress.org/trunk@34052
git-svn-id: http://core.svn.wordpress.org/trunk@34020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 19:10:26 +00:00
008dca20b4
Docs: Fix DocBlock formatting for `wp_insert_term()`.
...
Built from https://develop.svn.wordpress.org/trunk@34051
git-svn-id: http://core.svn.wordpress.org/trunk@34019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 18:48:24 +00:00
fa7bc4fda0
Upgrade MediaElement to 2.18.1 - monkey-patches to allow H264 in Chromium.
...
Changelog: https://github.com/johndyer/mediaelement/compare/2.17.0...2.18.1
See #33798 .
Built from https://develop.svn.wordpress.org/trunk@34050
git-svn-id: http://core.svn.wordpress.org/trunk@34018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 18:35:26 +00:00
2f0fc3b97d
After [34048], restore the `else` statement for `h` (height of video) in `wp_underscore_video_template()`.
...
See #33798 .
Built from https://develop.svn.wordpress.org/trunk@34049
git-svn-id: http://core.svn.wordpress.org/trunk@34017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 18:30:26 +00:00
4b4f08c7a0
In [30082], hardcoded heights were removed on the front end for videos rendered via shortcode. These values were not removed from the admin, which was an oversight.
...
See #33798 .
Built from https://develop.svn.wordpress.org/trunk@34048
git-svn-id: http://core.svn.wordpress.org/trunk@34016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 18:27:25 +00:00
8ec224c2f9
Revert [34009], broke uploads.
...
See #24934 .
Built from https://develop.svn.wordpress.org/trunk@34047
git-svn-id: http://core.svn.wordpress.org/trunk@34015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 18:04:26 +00:00
0ffe65cf5c
Use `_x()` instead of string hacks for weekday and month abbreviations.
...
Props johnbillion.
Fixes #33716 .
Built from https://develop.svn.wordpress.org/trunk@34046
git-svn-id: http://core.svn.wordpress.org/trunk@34014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 15:36:25 +00:00
99c85c5b45
Update the length limit in `set_transient()` docs after [34030].
...
Props OriginalEXE.
Fixes #13310 .
Built from https://develop.svn.wordpress.org/trunk@34045
git-svn-id: http://core.svn.wordpress.org/trunk@34013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 15:10:27 +00:00
d9b7d915c2
Document `@return` value for `wp_unschedule_event()`.
...
See #33475 .
Built from https://develop.svn.wordpress.org/trunk@34044
git-svn-id: http://core.svn.wordpress.org/trunk@34012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 11:35:24 +00:00
f130fd6c32
Better align table headers with table cells on success screen after installing.
...
Props umesh.nevase.
Fixes #33796 .
Built from https://develop.svn.wordpress.org/trunk@34043
git-svn-id: http://core.svn.wordpress.org/trunk@34011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 11:26:26 +00:00
db4f22bfb5
After [33961], pass `$comment` to `get_comment_link()` where possible to avoid extra cache/db lookups.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34042
git-svn-id: http://core.svn.wordpress.org/trunk@34010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 06:21:25 +00:00
c3f642bea9
After [33961], pass `$comment` to `get_comment_date()` where possible to avoid extra cache/db lookups.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34041
git-svn-id: http://core.svn.wordpress.org/trunk@34009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 06:15:24 +00:00
58c3c30e8d
After [33961], pass `$comment` to `comment_class()` where possible to avoid extra cache/db lookups.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34040
git-svn-id: http://core.svn.wordpress.org/trunk@34008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 06:12:24 +00:00
fc328f5484
After [33961], pass `$comment` to `get_comment_author_link()` where possible to avoid extra cache/db lookups.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34039
git-svn-id: http://core.svn.wordpress.org/trunk@34007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 06:05:24 +00:00
4465a83b95
After [34015], handle orphaned comments in the Dashboard comments widget. Pass full `$comment` versus just passing the comment ID when possible.
...
See #33710 .
Built from https://develop.svn.wordpress.org/trunk@34038
git-svn-id: http://core.svn.wordpress.org/trunk@34006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 05:56:24 +00:00
b9bbdabfe7
Create a new file, `wp-admin/includes/noop.php`, which loads all of the noop functions for `load-script|styles.php` and is only loaded by those files. DRYs in the process.
...
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34037
git-svn-id: http://core.svn.wordpress.org/trunk@34005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 05:04:23 +00:00
db9c5c81f5
Move ad hoc functions from `wp-admin/credits.php` to `wp-admin/includes/credits.php`, which is only included by the former.
...
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34036
git-svn-id: http://core.svn.wordpress.org/trunk@34004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 04:55:26 +00:00
cb462fa5ab
Add unit tests for `get_term()`.
...
These tests will be useful as we begin to refactor in favor of `WP_Term`.
See #14162 .
Built from https://develop.svn.wordpress.org/trunk@34035
git-svn-id: http://core.svn.wordpress.org/trunk@34003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 03:11:24 +00:00
39fb7992a9
Require numeric IDs in user deletion functions.
...
`wp_delete_user()` and `wpmu_delete_user()` both require an `$id` parameter.
Previously, the functions did not verify that the value passed was, in fact,
a number. As such, passing an object or any other entity that would be cast
to int `1` would result in user 1 being deleted. We fix this by enforcing
the requirement that `$id` be numeric.
Props dipesh.kakadiya, utkarshpatel, juliobox.
Fixes #33800 .
Built from https://develop.svn.wordpress.org/trunk@34034
git-svn-id: http://core.svn.wordpress.org/trunk@34002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 02:25:23 +00:00
9a8a28998d
Move `wp_delete_user()` tests to their own file.
...
See #33800 .
Built from https://develop.svn.wordpress.org/trunk@34033
git-svn-id: http://core.svn.wordpress.org/trunk@34001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 01:51:25 +00:00
0d85038ce6
Schema: Increase the length of `wp_options.option_name`.
...
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring.
Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.
Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.
Fixes #13310 .
Built from https://develop.svn.wordpress.org/trunk@34030
git-svn-id: http://core.svn.wordpress.org/trunk@33999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 01:26:24 +00:00
c09b0477b2
Flush rewrite rules upon theme switch
...
Themes can ( and do ) but shouldn't include custom rewrite rules.This can lead to hard to debug issues for theme authors. Theme changes are not a ultra common conclusion. Flushing the rewrite rules on theme switch will lead to a clean slate for each theme which helps make debugging easier.
And @nacin said we should do this 5 years ago at WordCamp Mid Atlantic.
Fixes #14849
Built from https://develop.svn.wordpress.org/trunk@34028
git-svn-id: http://core.svn.wordpress.org/trunk@33997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 23:50:24 +00:00
9bf86a74d0
Set the `secure` flag on the `wp-saving-post` cookie when using HTTPS.
...
This cookie doesn't contain any sensitive information, but this change brings its behaviour in line with all other core cookies.
Fixes #31056
Built from https://develop.svn.wordpress.org/trunk@34027
git-svn-id: http://core.svn.wordpress.org/trunk@33996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 22:42:23 +00:00
5918b30cdd
Move `network_settings_add_js()` from `wp-admin/network/settings.php` to `wp-admin/includes/ms.php`.
...
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34026
git-svn-id: http://core.svn.wordpress.org/trunk@33995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 22:24:24 +00:00
2d2e3c911e
Move `confirm_delete_users()` from `wp-admin/network/users.php` to `wp-admin/includes/ms.php`.
...
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34025
git-svn-id: http://core.svn.wordpress.org/trunk@33994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 22:23:46 +00:00
bd0a6bbf8c
Create `wp-admin/includes/network.php` via `svn cp` and only load it in `wp-admin/network.php`. Move the functions there.
...
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34023
git-svn-id: http://core.svn.wordpress.org/trunk@33992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 22:01:24 +00:00
1d68ccec25
Move ad hoc Options functions to `wp-admin/includes/options.php`:
...
* Move `options_discussion_add_js()` from `wp-admin/options-discussion.php`
* Move `options_general_add_js()` from `wp-admin/options-general.php`
* Move `options_permalink_add_js()` from `wp-admin/options-permalink.php`
* Move `options_reading_add_js()` from `wp-admin/options-reading.php`
* Move `options_reading_blog_charset()` from `wp-admin/options-reading.php`
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34022
git-svn-id: http://core.svn.wordpress.org/trunk@33991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 21:45:24 +00:00
a40e30e7f4
Move 2 ad hoc user admin functions:
...
* Move `use_ssl_preference()` from `wp-admin/user-edit.php` to `wp-admin/includes/user.php`.
* Move `admin_created_user_email()` from `wp-admin/user-new.php` to `wp-admin/includes/user.php`.
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34021
git-svn-id: http://core.svn.wordpress.org/trunk@33990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 21:33:33 +00:00
503aa8b76d
Move `redirect_post()` from `wp-admin/post.php` to `wp-admin/includes/post.php`.
...
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34020
git-svn-id: http://core.svn.wordpress.org/trunk@33989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 21:31:24 +00:00
Sergey Biryukov
Drew Jaynes
Scott Taylor
Aaron Jorbin
Weston Ruter
Boone Gorges
John Blackbourn
Dominik Schilling
Nikolay Bachiyski
Dion Hulse
Jeremy Felt
Andrea Fercia
Helen Hou-Sandí
Andrew Ozz
Gary Pendergast