2dad79f6c5
Always sanitize user_nicename in wp_insert_user().
...
Previously, a 'user_nicename' parameter passed into the function was
unsanitized. This could result in a mismatch between the sanitized nicename
generated automatically at user creation, resulting in broken author archive
permalinks.
Props joemcgill.
Fixes #29696 .
Built from https://develop.svn.wordpress.org/trunk@29819
git-svn-id: http://core.svn.wordpress.org/trunk@29585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 18:54:17 +00:00
fd4e3023d6
In `wp_delete_attachment()`: account for orphan sizes by looping over the sizes stored in metadata, instead of relying on the current sizes stored in `$_wp_additional_image_sizes`.
...
Props JoshuaAbenazer, desrosj, markoheijnen.
Fixes #24518 .
Built from https://develop.svn.wordpress.org/trunk@29816
git-svn-id: http://core.svn.wordpress.org/trunk@29582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 15:32:16 +00:00
067feb9691
Remember when we added the `style` attribute to playlists? Fix `dark`.
...
Props karpstrucking.
Fixes #29530 .
Built from https://develop.svn.wordpress.org/trunk@29814
git-svn-id: http://core.svn.wordpress.org/trunk@29580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 05:28:16 +00:00
d8c913b3f9
Add the `date` filter from media grid to the media modal.
...
Props janhenckens, wonderboymusic.
Fixes #28990 .
Built from https://develop.svn.wordpress.org/trunk@29813
git-svn-id: http://core.svn.wordpress.org/trunk@29579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:32:16 +00:00
202ede7696
After [29811], combine 2 `if` statements.
...
Built from https://develop.svn.wordpress.org/trunk@29812
git-svn-id: http://core.svn.wordpress.org/trunk@29578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:16:17 +00:00
b885885b67
Media Grid/List Table parity: when `MEDIA_TRASH` is `true` and `trash` is the current filter for the grid, add a second bulk action button: "Delete Selected"
...
Fixes #29742 .
Built from https://develop.svn.wordpress.org/trunk@29811
git-svn-id: http://core.svn.wordpress.org/trunk@29577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:13:16 +00:00
0797823c55
Add a class attribute for submit button in comment form.
...
props bainternet.
fixes #20446 .
Built from https://develop.svn.wordpress.org/trunk@29809
git-svn-id: http://core.svn.wordpress.org/trunk@29575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 01:44:15 +00:00
7d8322aa65
WP_Comment_Query: comment__in, comment__not_in, post__in, post__not_in.
...
Props nofearinc, mordauk, boonebgorges
Fixes #25386
Built from https://develop.svn.wordpress.org/trunk@29808
git-svn-id: http://core.svn.wordpress.org/trunk@29574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 01:41:16 +00:00
258496edb6
In the `wp_new_blog_notification()` email template, include the login url.
...
Props obenland, georgestephanis.
Fixes #21089 .
Built from https://develop.svn.wordpress.org/trunk@29806
git-svn-id: http://core.svn.wordpress.org/trunk@29572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 01:28:16 +00:00
6ee7e6061a
Add classes to form containers on taxonomy screens.
...
props jarednova.
fixes #28196 .
Built from https://develop.svn.wordpress.org/trunk@29803
git-svn-id: http://core.svn.wordpress.org/trunk@29570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 00:29:16 +00:00
ebe813ca54
Add a namespace to the click handler registration for `.insert-media` in `media-editor.js`: `click.add-media-button`.
...
This is a stopgap to allow devs to override the default behavior.
Fixes #23096 .
Built from https://develop.svn.wordpress.org/trunk@29802
git-svn-id: http://core.svn.wordpress.org/trunk@29569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-01 19:08:16 +00:00
d2c99a5646
Add a default filter to `title_save_pre`: `trim`, because extra whitespace.
...
Props nikolov.tmw, avryl.
Fixes #19904 .
Built from https://develop.svn.wordpress.org/trunk@29801
git-svn-id: http://core.svn.wordpress.org/trunk@29568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-01 18:58:16 +00:00
3f1fcc7d71
Version bump.
...
Built from https://develop.svn.wordpress.org/trunk@29800
git-svn-id: http://core.svn.wordpress.org/trunk@29567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-01 14:59:19 +00:00
40dd52b228
Improve parameter sanitization in WP_Date_Query::build_query().
...
* Don't run non-numeric values through intval() for sanitization; this transforms them into 1s and 0s, which can cause unintended results.
* Be more generous about numeric array keys (don't require 0 and 1) in BETWEEN and NOT BETWEEN clauses.
Fixes #29801 .
Built from https://develop.svn.wordpress.org/trunk@29797
git-svn-id: http://core.svn.wordpress.org/trunk@29566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-30 14:04:18 +00:00
bf52618636
Update documentation for `wp_get_nav_menus()` to reflect that the default value for the the 'orderby' argument was changed from 'none' to 'name' in 4.1.
...
Props curtjen.
Fixes #29460 .
Built from https://develop.svn.wordpress.org/trunk@29796
git-svn-id: http://core.svn.wordpress.org/trunk@29565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 23:35:17 +00:00
504d4ad5eb
Change the default orderby value in wp_get_nav_menus() to 'name'.
...
props voldemortensen, igmoweb.
fixes #29460 .
Built from https://develop.svn.wordpress.org/trunk@29792
git-svn-id: http://core.svn.wordpress.org/trunk@29564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 15:45:16 +00:00
e1f2b3b9e2
Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org)
...
see #27115
Built from https://develop.svn.wordpress.org/trunk@29789
git-svn-id: http://core.svn.wordpress.org/trunk@29561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 13:37:16 +00:00
0d3b83551f
Use HTTPS URLs for core.trac.wordpress.org
...
see #27115
Built from https://develop.svn.wordpress.org/trunk@29788
git-svn-id: http://core.svn.wordpress.org/trunk@29560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 13:28:16 +00:00
740df917fa
Remove unnecessary semicolon.
...
props ixkaito.
fixes #29784 .
Built from https://develop.svn.wordpress.org/trunk@29784
git-svn-id: http://core.svn.wordpress.org/trunk@29556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 10:30:16 +00:00
5516c48975
PHPMailer: Merge upstream commit (PR274).
...
props zodiac1978.
fixes #27946 .
Built from https://develop.svn.wordpress.org/trunk@29783
git-svn-id: http://core.svn.wordpress.org/trunk@29555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 10:28:17 +00:00
37a0c36d38
The joys of `wptexturize()`:
...
* Revert parts of [28773] and [28727] and [29748].
* Do not crash PHP. Make the shortcode quantifier possessive to avoid backtracks.
* Reduce backtracking in long HTML comments by 100x.
* Do not ignore unclosed HTML comments.
* Do not break unregistered shortcodes, e.g. `[hello attr="value"]`.
* Do not break HTML in shortcode attributes, e.g. `[hello attr="<"]`.
* Do not match for shortcodes when there is extra whitespace, e.g. `[ hello ]`.
* Add unit tests to show #12690 was not fully resolved.
* Tested PHP 5.2.4, 5.2.13, 5.4.32, and 5.5.8.
Adds/modifies unit tests.
Props miqrogroove.
See #29557 .
Built from https://develop.svn.wordpress.org/trunk@29781
git-svn-id: http://core.svn.wordpress.org/trunk@29553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 04:07:15 +00:00
1967dfe898
In `paginate_links()`, ensure that query string args are propagated to the resulting paginated links.
...
Adds unit tests that use `DOMDocument` since `assertTag` is being deprecated - see #29545 , [29746].
Props obenland, wonderboymusic.
Fixes #29636 .
Built from https://develop.svn.wordpress.org/trunk@29780
git-svn-id: http://core.svn.wordpress.org/trunk@29552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 04:03:16 +00:00
75d347b259
Add `size` to the UI for Gallery Settings in the media modal. Ensure that the TinyMCE view is refreshed when size changes.
...
Props richardmtl, noplanman, wonderboymusic.
Fixes #18143 .
Built from https://develop.svn.wordpress.org/trunk@29779
git-svn-id: http://core.svn.wordpress.org/trunk@29551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 03:45:16 +00:00
b646f9df6a
Allow bookmarks to be ordered by `link_description` in `get_bookmarks()`.
...
Fixes #29763 .
Built from https://develop.svn.wordpress.org/trunk@29778
git-svn-id: http://core.svn.wordpress.org/trunk@29550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 03:12:17 +00:00
668e758a78
Media Grid: when the modal is open, don't respond to arrow keys when `<textarea>` has focus.
...
Props ryelle.
Fixes #29725 .
Built from https://develop.svn.wordpress.org/trunk@29777
git-svn-id: http://core.svn.wordpress.org/trunk@29549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 03:00:17 +00:00
7a55ab9164
Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@29776
git-svn-id: http://core.svn.wordpress.org/trunk@29548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 00:14:18 +00:00
d7de59cb00
Use Tahoma for RTL in general and Arial for Hebrew in editor styles.
...
fixes #29553 .
Built from https://develop.svn.wordpress.org/trunk@29773
git-svn-id: http://core.svn.wordpress.org/trunk@29545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-27 11:10:16 +00:00
3a724fcf81
Use correct i18n function after [29768].
...
props TobiasBg.
fixes #29751 .
Built from https://develop.svn.wordpress.org/trunk@29769
git-svn-id: http://core.svn.wordpress.org/trunk@29541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-26 20:54:18 +00:00
51895fac81
Merge two similar strings.
...
props pavelevap.
fixes #29751 .
Built from https://develop.svn.wordpress.org/trunk@29768
git-svn-id: http://core.svn.wordpress.org/trunk@29540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-26 19:30:17 +00:00
ab1c46af42
TinyMCE wpView: when pasting/inserting content before a view, add new paragraph above it and insert the content there. Props avryl, fixes #29380 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@29766
git-svn-id: http://core.svn.wordpress.org/trunk@29538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-26 00:21:16 +00:00
8889ba6a68
Create correct permalinks for child posts of hierarchical post types when default permalinks are used.
...
props loushou.
fixes #29615 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29765
git-svn-id: http://core.svn.wordpress.org/trunk@29537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-24 21:30:19 +00:00
10e0807cce
Add context for 'Trash' string in media modal.
...
props pavelevap.
fixes #29739 .
Built from https://develop.svn.wordpress.org/trunk@29764
git-svn-id: http://core.svn.wordpress.org/trunk@29536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-24 13:49:20 +00:00
dd25a715b2
Improve and clarify inline commenting inside the `check_comment()` function.
...
Adds logical explanations of what some of the various comment checks are checking for, as well as some general cleanup and syntax fixes.
Fixes #29734 .
Built from https://develop.svn.wordpress.org/trunk@29763
git-svn-id: http://core.svn.wordpress.org/trunk@29535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-23 18:49:17 +00:00
9824f40920
Improve documentation in the `check_comments()` docblock.
...
* Removes two duplicate sentences from the long description
* Tightens up phrasing elsewhere in the long description for specific checks
* Clarifies the parameter and return descriptions, and adds periods
See #29734 .
Built from https://develop.svn.wordpress.org/trunk@29762
git-svn-id: http://core.svn.wordpress.org/trunk@29534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-23 18:47:15 +00:00
ee9d74dc05
Ordering by `RAND()`:
...
The shortcode callbacks for `gallery` and `playlist` check for `'RAND' == $atts['order']`, which isn't a valid value for `order`. Remove those checks and update the docs.
In `WP_Query`, if the value of `orderby` is `rand`, `order` is irrelevant and should be unset.
Adds unit tests.
Fixes #29629 .
Built from https://develop.svn.wordpress.org/trunk@29760
git-svn-id: http://core.svn.wordpress.org/trunk@29532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-23 03:52:15 +00:00
e3eaed1c78
Add two properties to `media.model.Attachments.propmap`: `include` and `exclude`, which are aliases for `post__in` and `post__not_in`.
...
This allows you to instantiate a library that includes and/or excludes specific attachments by passing a single ID or an array of IDs.
Example usage:
{{{
wp.media({frame: 'post', library: {include: [414, 415]}}).open()
wp.media({frame: 'post', library: {include: 414}}).open()
wp.media({frame: 'post', library: {exclude: [414, 415]}}).open()
wp.media({frame: 'post', library: {exclude: 414}}).open()
}}}
Fixes #26587 .
Built from https://develop.svn.wordpress.org/trunk@29759
git-svn-id: http://core.svn.wordpress.org/trunk@29531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-23 03:38:16 +00:00
491c91196f
`wp_extract_urls()` needs to also grab URLs with query strings and hashes.
...
Updates unit test.
Props hauvong, dlh.
Fixes #29314 .
Built from https://develop.svn.wordpress.org/trunk@29756
git-svn-id: http://core.svn.wordpress.org/trunk@29528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-23 02:50:19 +00:00
f30266acb9
Media Grid:
...
* In Bulk Edit mode, don't attempt to delete or trash an attachment that doesn't have a `delete` nonce. The subsequent `_requery()` will then properly display the attachment still present in the library.
* Remove all updated models from the selection at the same time to avoid async race conditions. The selection is reset when the grid's `select` mode is deactivated, but this allows this view instance to be more portable.
This fix allows users to set caps on individual attachments without confusing the grid's library. This issue was present for bulk actions in general, had nothing to do with `MEDIA_TRASH` specifically.
Fixes #29597 .
Built from https://develop.svn.wordpress.org/trunk@29755
git-svn-id: http://core.svn.wordpress.org/trunk@29527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 18:52:16 +00:00
cca3890c84
Add some missing information to the inline docs for `get_post_types()`.
...
* Improves the `@see` reference for `register_post_type()` to mention that it contains information about accepted arguments
* Adds a description of the accepted values for the `$operator` parameter
* Fixes a typo
Fixes #29721 .
Built from https://develop.svn.wordpress.org/trunk@29752
git-svn-id: http://core.svn.wordpress.org/trunk@29524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 08:55:18 +00:00
75ff6ae302
Add safeguards for when ext/hash is not compiled with PHP.
...
see #29518 , for trunk.
Built from https://develop.svn.wordpress.org/trunk@29751
git-svn-id: http://core.svn.wordpress.org/trunk@29523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-20 17:28:18 +00:00
2008fc0c89
Correct 'wp_get_attachment_image_attributes' filter docs.
...
props tillkruess.
fixes #29701 .
Built from https://develop.svn.wordpress.org/trunk@29750
git-svn-id: http://core.svn.wordpress.org/trunk@29522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-18 12:36:17 +00:00
0a848a6171
`wptexturize()` improvements:
...
* Expand the `wptexturize()` RegEx to include the list of registered shortcodes.
* Avoid backtracking after `[` chars by not filtering params in registered shortcodes. This will cause escaped shortcodes and their params to become texturized if not registered.
* Registered shortcode params will never be texturized, even when escaped.
* Move all tests involving unregistered shortcodes to a new and improved unit.
* Update one test involving HTML within shortcode params.
Props miqrogroove.
See #29557 .
Built from https://develop.svn.wordpress.org/trunk@29748
git-svn-id: http://core.svn.wordpress.org/trunk@29520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-17 15:14:17 +00:00
793f814303
Make sure the $parent argument of wp_insert_attachment() still works as expected after [28579].
...
prop jesin, dikiy_forester.
fixes #29646 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29745
git-svn-id: http://core.svn.wordpress.org/trunk@29519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-15 14:24:17 +00:00
5727b51538
Correct @return value for WP_User_Query::get_total().
...
props jesin.
fixes #29656 .
Built from https://develop.svn.wordpress.org/trunk@29744
git-svn-id: http://core.svn.wordpress.org/trunk@29518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-13 22:24:17 +00:00
9f066b2a1d
Correct some @since values added in [29739].
...
see #28459 .
Built from https://develop.svn.wordpress.org/trunk@29743
git-svn-id: http://core.svn.wordpress.org/trunk@29517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-13 12:18:18 +00:00
b67ba6fb1c
`WP_oEmbed::_strip_newlines` is called as a filter callback for `oembed_dataparse`, must be public. It was marked as private for fun in [14109] and then made `private` officially in [28507].
...
Fixes #29647 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29742
git-svn-id: http://core.svn.wordpress.org/trunk@29516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-12 22:54:16 +00:00
ae21b1884d
kses: Add colgroup.
...
props collinsinternet.
fixes #29433 .
Built from https://develop.svn.wordpress.org/trunk@29740
git-svn-id: http://core.svn.wordpress.org/trunk@29514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-12 05:51:17 +00:00
836e0f8cd5
Add some `@since` annotations to `media-views.js`.
...
Props DrewAPicture.
See #28459 .
Built from https://develop.svn.wordpress.org/trunk@29739
git-svn-id: http://core.svn.wordpress.org/trunk@29513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-12 03:36:16 +00:00
d70552abba
After [29733], version bump for MediaElement.
...
Built from https://develop.svn.wordpress.org/trunk@29736
git-svn-id: http://core.svn.wordpress.org/trunk@29510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-11 19:47:16 +00:00
a1245a4a67
Allow arbitrary subdomains for the oEmbed endpoint for Slideshare.
...
Props Latz.
Fixes #29427 .
Built from https://develop.svn.wordpress.org/trunk@29735
git-svn-id: http://core.svn.wordpress.org/trunk@29509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-11 19:25:16 +00:00
Boone Gorges
Scott Taylor
Sergey Biryukov
Drew Jaynes
Mark Jaquith
Andrew Nacin
Andrew Ozz