Commit Graph

38226 Commits

Author SHA1 Message Date
Gary Pendergast 884648e54b WordPress 5.0 Beta 4.
Built from https://develop.svn.wordpress.org/branches/5.0@43895


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-13 01:02:48 +00:00
Gary Pendergast 70cd0fa3c3 Script Loader: Fix an error introduced in [43893].
`wp_common_block_scripts_and_styles()` should only exit early if we're in the admin and the current screen isn't the block editor.

See #45302.

Built from https://develop.svn.wordpress.org/branches/5.0@43894


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-13 00:25:48 +00:00
Gary Pendergast 6b97594e65 Scripts: Fix a PHP error in admin-ajax calls.
When making an ajax request, `wp_enqueue_registered_block_scripts_and_styles()` checked if `is_admin()` was true before accessing `$current_screen`, rather than checking if `$current_screen` was defined. This is usually fine, execept for in ajax requests.

Props ocean90, foreverpinetree, pento.
See #45203.


Built from https://develop.svn.wordpress.org/branches/5.0@43893


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 23:38:47 +00:00
allancole 31692a5f6e Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update applies the following changes:

- Improve menu UI to support keyboard, click and touch interactions
- Improve variable scoping and js performance in menu interaction javascript
- Improve custom-colors for selected text, buttons and menu hover styles
- Improve margins structure for more consistency between editor and frontend
- Improve discussion avatars for simpler wording and better performance
- Improve fonts in list widgets and list blocks 
- Improve comment responsive spacing and avatar display
- Improve various block styles to make them consistent between the editor and frontend
- Add tabbed browsing support for ie11
- Add backwards compatibility support for older versions of WordPress
- Add fallback styles for older versions of WP where Gutenberg is activated and then deactivated (backwards compatibility)
- Add `sizes` attribute for featured images to improve responsive performance
- Add focus-within polyfill
- Add a footer menu for secondary page links
- Fix editor styles to prevent conflicts with plugins that add meta boxes to the editor
- Fix columns block issues on small screens
- Fix empty-space font text cursor issue in Gutenberg editor
- Fix RTL floating styles so that left/right floats are honored
- Fix cover image block margins/padding
- Fix invalid rgba style
- Fix php warning when returning attributes
- Fix gallery widget margins to improve gallery grids
- Fix .entry-content selectors to prevent shortcodes, plugins and other unknown content from breaking the layout
- Remove translation escaping to follow code standards in previous default themes
- Remove custom color output in the fronten header when default color is selected
- Remove fly-out sub-sub-sub-menu behavior on desktop to prevent sub-menus from falling off the screen
- General code clean up and coding standards improvements

Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, mukeshpanchal27, burhandodhy, crunnells, Ismail-elkorchi, aryaprakasa, @tlxo, @themeroots, @whizbangik, @yingles, @youthkee, @brentswisher, @smy315, @ahmadawais, @desi-developer.


Built from https://develop.svn.wordpress.org/branches/5.0@43892


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 23:20:51 +00:00
youknowriad 67bd8ce94c Block Editor: Update @wordpress dependencies to the latest version matching Gutenberg 4.3.0
- Update the editor,edit-post,components,block-library,nux and list-reusable blocks packages
 - Also add a missing wp-date dependency to the editor script

Props atimmer
See #45145.


Built from https://develop.svn.wordpress.org/branches/5.0@43891


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 17:02:54 +00:00
Andrew Ozz 059f413ade Fix linting after [43889].
See #45264.

Built from https://develop.svn.wordpress.org/branches/5.0@43890


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 13:57:48 +00:00
Andrew Ozz 48f893b42f Block Editor: Fix the TinyMCE `wordpress` plugin to handle hiding/showing of toolbars in the classic block. Change the classic block toolbar to use the (now fixed) `wp_adv` button.
Fixes #45264.
Built from https://develop.svn.wordpress.org/branches/5.0@43889


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 10:35:49 +00:00
Andrew Ozz ca2055af34 Block Editor: A little cleanup to `render_block()`. Always normalize `$block['attrs']` to array in `'render_block'` filter.
See #45145.
Built from https://develop.svn.wordpress.org/branches/5.0@43888


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 10:03:48 +00:00
Gary Pendergast e39fe11309 Docs: Future-proof comments referencing 5.0 TODOs.
Some Customizer-related files contain inline comments referencing work to do for #42364 for 5.0. Those comments are now outdated as #42364 was moved to the 5.1 milestone.

Props dlh.
See #45115.


Built from https://develop.svn.wordpress.org/branches/5.0@43887


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 04:23:48 +00:00
Gary Pendergast cb09a64dc6 Build Tools: Add non-minified `@wordpress` scripts to the build output.
Props atimmer.
See #45156.


Built from https://develop.svn.wordpress.org/branches/5.0@43886


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 04:19:49 +00:00
Gary Pendergast 8f8f3bb91d Block Editor: Hide the Custom Fields meta box option if that meta box has been removed.
Some plugins remove the Custom Fields meta box, particularly when they provide functionality that replaces it. The block editor would correctly not display this meta box in these circumstances, but it still showed the option to display or hide it.

Props pento, noisysocks.
See #45282.



Built from https://develop.svn.wordpress.org/branches/5.0@43885


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 03:38:50 +00:00
Gary Pendergast 54368e50b6 Block Editor: Update `@wordpress` dependencies to the latest version.
Changes of note:
- Includes the new Annotations API package.
- `wp-polyfill-ecmascript.js` is renamed to `wp-polyfill.js`.
- `strip_dynamic_blocks()` has been removed in favour of `excerpt_remove_blocks()`.
- The PHP block parser is now syncing from the `block-serialization-default-parser` package.
- `do_blocks()` uses the new parser.
- The `do_block` filter has been removed from `do_blocks()`, in favour of a `render_block` filter in `render_block()`.

See #45145, #45190, #45264, #45282.


Built from https://develop.svn.wordpress.org/branches/5.0@43884


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 02:27:57 +00:00
Gary Pendergast fdf428e44f Tests: Fix tests broken in PHP 5.x after [43879].
See #45290.


Built from https://develop.svn.wordpress.org/branches/5.0@43883


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-09 09:44:49 +00:00
Gary Pendergast cd22d51724 Meta Boxes: Add the `block_editor_meta_box_hidden_fields` action.
Lacking an appropriate action in the classic editor, plugins that add meta boxes have historically hooked into various actions in order to add hidden input fields.

This change also adds backwards compatibility for two of the most common: `edit_form_after_title`, and `edit_form_advanced`.

Props pento, danielbachhuber.
See #45283.


Built from https://develop.svn.wordpress.org/branches/5.0@43882


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-09 09:06:47 +00:00
Gary Pendergast 09324db9d2 Tests: Fix a failing test after [43879].
See #45290.


Built from https://develop.svn.wordpress.org/branches/5.0@43881


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-09 08:56:47 +00:00
Gary Pendergast 98e9bbdc19 Block Editor: Prevent the meta box form from being accidentally submitted.
Meta boxes are loaded inside a wrapper form, that the block editor submits as part of the saving process. It shouldn't be submitted manually.

See #45284.

Built from https://develop.svn.wordpress.org/branches/5.0@43880


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-09 08:33:46 +00:00
Gary Pendergast 7c19654f33 Formatting: Ensure `wpautop()` isn't run on content generated from blocks.
As `do_blocks()` is run before `wpautop()` in `the_content` filter, we can remove in a Just In Time fashion, before that filter is run.

After `wpautop()`s original priority has passed, we can re-add it in a Just Too Late fashion, to ensure it's available if `the_content` filter is run multiple times on a page load.

Props pento, nerrad.
Fixes #45290.


Built from https://develop.svn.wordpress.org/branches/5.0@43879


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-09 08:29:47 +00:00
herregroen c22a63ec3a I18N: Set translations for all WordPress packages scripts.
Calls `wp_set_script_translations` for all packages scripts that have translations. Also correctly sets the domain on the translations.

Props omarreiss, pento, ocean90.
Fixes #45161.

Built from https://develop.svn.wordpress.org/branches/5.0@43878


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-08 11:34:48 +00:00
Dominik Schilling 3d6cb1b458 Script Loader: Ensure default packages are registered when loaded via load-scripts.php.
Props CantoThemes, ocean90.
See #45271.
Built from https://develop.svn.wordpress.org/branches/5.0@43877


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-08 09:24:51 +00:00
laurelfulford 1e73770c39 Twenty Seventeen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Seventeen's Gutenberg support, added in #45045. This commit includes the following fixes:

* Update editor placeholder text to use the correct font family.
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment. 
 
Props pento, davidakennedy.
Fixes #45246.


Built from https://develop.svn.wordpress.org/branches/5.0@43876


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 06:17:47 +00:00
laurelfulford c42f50371e Twenty Sixteen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Sixteen's Gutenberg support, added in #45044. This commit includes the following fixes:

* Center text and bullets in list-based widget blocks, when block itself is centered.
* Correct styles for the editor placeholder text, so it's not inheriting a darker gray from the theme's CSS. 
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Reset Cover blocks as `display: flex` when they are centered, to maintain their original appearance.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment. 
 
Props pento, davidakennedy.
Fixes #45245.


Built from https://develop.svn.wordpress.org/branches/5.0@43875


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 06:06:48 +00:00
laurelfulford 115f10be59 Twenty Fifteen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Fifteen's Gutenberg support, added in #45043. This commit includes the following fixes:

* Center text and bullets in list-based widget blocks, when block itself is centered.
* Add a margin to blocks that are aligned to the left or to the right, to create space.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment. 

Props pento, davidakennedy.
Fixes #45244.


Built from https://develop.svn.wordpress.org/branches/5.0@43874


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 05:57:46 +00:00
laurelfulford 720d54d544 Twenty Fourteen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Fourteen's Gutenberg support, added in #45042. This commit includes the following fixes:

* Update editor placeholder text to use the correct font family.
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Remove unnecessary spacing from the Columns block.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Simplify selectors used to set editor width to just `.wp-block`.

Props pento, davidakennedy.
Fixes #45243.


Built from https://develop.svn.wordpress.org/branches/5.0@43873


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 01:26:47 +00:00
laurelfulford b61dd6109c Twenty Thirteen: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Thirteen's Gutenberg support, added in #45041. This commit includes the following fixes:

* Center text and bullets in list-based widget blocks, when block itself is centered.
* Prevent full and wide aligned blocks from getting wider than Twenty Thirteen's design.
* Prevent wide aligned blocks from getting too wide, as they can seem out of proportion with the full aligned blocks.
* Make sure full and wide blocks display at the correct width in the editor.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Make sure wide and full aligned Table blocks span the available width on the front end.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.


Props pento, davidakennedy.
Fixes #45242.


Built from https://develop.svn.wordpress.org/branches/5.0@43872


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 01:22:48 +00:00
laurelfulford 8362e6601e Twenty Twelve: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Twelve's Gutenberg support, added in #45040. This commit includes the following fixes:

* Update editor placeholder text to use the correct font family.
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.


Props pento, davidakennedy.
Fixes #45240.


Built from https://develop.svn.wordpress.org/branches/5.0@43871


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 01:10:47 +00:00
laurelfulford f89d4e6bb2 Twenty Eleven: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Eleven's Gutenberg support, added in #45039. This commit includes the following fixes:

* Center text and bullets in list-based widget blocks when block itself is centered.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment. 

Props pento, davidakennedy.
Fixes #45239.


Built from https://develop.svn.wordpress.org/branches/5.0@43870


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 01:01:48 +00:00
laurelfulford 8532f185b6 Twenty Ten: Fix issues with theme's Gutenberg support.
A handful of issues were missed in Twenty Ten's Gutenberg support, added in #45038. This commit includes the following fixes:

* Update editor placeholder text to use the correct font family and size.
* Remove unnecessary spacing from the Columns block.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block.
* Simplify selectors used to set editor width to just `.wp-block`.

Fixes #45238.


Built from https://develop.svn.wordpress.org/branches/5.0@43869


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 00:50:48 +00:00
laurelfulford 6f076d4d51 Bundled Themes: Add theme support for responsive embeds
Add `add_theme_support( 'responsive-embeds' );` to all of the responsive default themes as part of their Gutenberg support. This makes sure any embeds coming from the new block-based editor maintain their aspect ratios at different screen sizes.

Fixes #45274.


Built from https://develop.svn.wordpress.org/branches/5.0@43868


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-06 00:25:50 +00:00
Andrew Ozz 23be3ef6e6 TinyMCE:
- Fix parsing of the init array in script-loader.
- Do not JSON encode the options object when outputting it from PHP.
- Remove JSON decoding of TinyMCE's `style_formats` option.

Fixes #45221.
Built from https://develop.svn.wordpress.org/branches/5.0@43867


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-05 08:39:49 +00:00
Gary Pendergast 3e1ae54884 Tests: Skip symlinked theme file tests if the links could not be created, or if `symlink()` is not available
Merges [42812,42819] to the 5.0 branch.

Props SergeyBiryukov.
Fixes #43508.

Built from https://develop.svn.wordpress.org/branches/5.0@43866


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-05 02:47:49 +00:00
Gary Pendergast 6d71fad8d3 Post WordPress 5.0 Beta 3 version bump.
Built from https://develop.svn.wordpress.org/branches/5.0@43865


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-05 00:19:47 +00:00
Gary Pendergast 47da460a3a WordPress 5.0 Beta 3.
Built from https://develop.svn.wordpress.org/branches/5.0@43864


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-05 00:07:47 +00:00
Gary Pendergast a46a68ad7f Meta Boxes: Add curly brackets missed in [43861].
This was causing the custom meta box to be incorrectly added to post types that don't support it.

Props ocean90, epointal.
Fixes #45257,

Built from https://develop.svn.wordpress.org/branches/5.0@43863


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-04 23:23:49 +00:00
danielbachhuber 56842f36aa REST API: Prevent duplicate firing of `rest(_after)?_insert_attachment` actions.
Props danielbachhuber, peterwilsoncc.
Fixes #45269.
See #42864.

Built from https://develop.svn.wordpress.org/branches/5.0@43862


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-03 14:14:49 +00:00
Gary Pendergast 325cb107d1 Build Tools: Update the `@wordpress` packages.
This brings support for the custom fields meta box to the block editor.

The `webpack` and `copy-webpack-plugin` packages have also been updated.

See #45145.
Fixes #45257.


Built from https://develop.svn.wordpress.org/branches/5.0@43861


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-03 07:57:54 +00:00
allancole c53ad88930 Importing Twenty Nineteen, our new default theme for 2019, set for 5.0.
Let Gutenberg shine with this simple, fast, and powerful theme. Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, mukeshpanchal27, burhandodhy, crunnells, Ismail-elkorchi, aryaprakasa.

Built from https://develop.svn.wordpress.org/branches/5.0@43860


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-02 23:53:49 +00:00
herregroen 69867a34db I18N: Improve JavaScript translation support.
Improves upon [43825] by adding unit tests to cover additional use-cases and changes loading translations to only occur when outputting the script to allow setting translations on dependencies.

Props atimmer, omarreiss, nerrad, swissspidy, ocean90.
Fixes #45103.

Built from https://develop.svn.wordpress.org/branches/5.0@43859


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 13:51:47 +00:00
Gary Pendergast e0664765b6 Editor: Cast the result of the `default_content`, `default_title`, and `default_excerpt` filters.
If a plugin returns a non-string value (or returns `null`) on these filters, it can cause errors in the block editor. Casting them as a string prevents these errors.

Props dd32.
See #45236.


Built from https://develop.svn.wordpress.org/branches/5.0@43858


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 05:20:47 +00:00
Gary Pendergast 6ad646a080 Block Editor: Remove CodeMirror settings.
CodeMirror is no longer used in the block editor, so we don't need to load the settings.

Props noisysocks.
Fixes #45248.


Built from https://develop.svn.wordpress.org/branches/5.0@43857


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 05:07:47 +00:00
Gary Pendergast d9e31a1bb9 Block Editor: Don't show back compat or incompatible meta boxes in Options.
Meta boxes that exist for back compat, or that are incompatible with the block editor aren't displayed, so they don't need an option to display or hide them in the Options dialog.

Props noisysocks.
Fixes #45249.


Built from https://develop.svn.wordpress.org/branches/5.0@43856


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 04:33:46 +00:00
Gary Pendergast 049d3a6db8 Posts: Remove the slug from Quick Edit for posts that are not `is_post_type_viewable()`.
This is a followup to [43728], which added the same check, but using the `publicly_queryable` option. This behaviour is incorrect for `_builtin` post types, which go by the logic in `is_post_type_viewable()`, instead.

See #43278.

Built from https://develop.svn.wordpress.org/branches/5.0@43855


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 02:35:46 +00:00
Gary Pendergast eb4031a209 Blocks: Add "Export as JSON" action to the `wp_block` post list screen.
Remove the "Quick Edit" for `wp_block`s, too, as they don't need any of that functionality.

Props noisysocks.
Fixes #45247.


Built from https://develop.svn.wordpress.org/branches/5.0@43854


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 02:25:47 +00:00
Gary Pendergast a3b620f104 Build Tools: Switch to Node 10.13.0.
Now that Node 10 is the LTS branch, with 10.13.0 as the first LTS release, let's use that for building WordPress.

See #45241.


Built from https://develop.svn.wordpress.org/branches/5.0@43853


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-01 02:02:47 +00:00
danielbachhuber 7c929a2922 REST API: Fix array syntax after [43851].
I thought I was writing JavaScript. Alas.

See #45196.

Built from https://develop.svn.wordpress.org/branches/5.0@43852


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:19:17 +00:00
danielbachhuber 40b2c11980 REST API: Regenerate fixure schema after introduction of new endpoints.
This fixture schema ensures `wp-api-generated.js` doesn't change when running tests in local dev environments.

Fixes #45196.

Built from https://develop.svn.wordpress.org/branches/5.0@43851


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:18:26 +00:00
danielbachhuber d5e3670372 REST API: Restore access to audio/video metadata functions.
Ensures `wp_read_video_metadata()`/`wp_read_audio_metadata()` functions are available when uploading video and audio. Fixes error introduced in [43589].

Props ocean90.
See #43757.

Built from https://develop.svn.wordpress.org/branches/5.0@43850


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:17:35 +00:00
danielbachhuber b277797add Blocks: Include necessary labels for the 'wp_block' post type.
See #45098

Built from https://develop.svn.wordpress.org/branches/5.0@43849


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:16:44 +00:00
Gary Pendergast 1fb36474cb FTP/PemFTP Library: Fix some PHP notices.
- `ftp_base::glob()` used `each()`, which is deprecated as of PHP 7.2.
- `ftp_base::fget()` was missing the decleration of its third parameter, `$rest`.

Props itowhid06.
See #44489.


Built from https://develop.svn.wordpress.org/branches/5.0@43848


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:15:54 +00:00
Gary Pendergast 59c4bcebcc Build Tools: Update the `@wordpress` packages.
Trunk now matches Gutenberg 4.2 RC1.

See #45145.


Built from https://develop.svn.wordpress.org/branches/5.0@43847


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 18:15:02 +00:00
danielbachhuber bb2de34edb l10n: Avoid calling `is_user_logged_in()` in `determine_locale()`.
`is_user_logged_in()` is a pluggable function, and loaded after plugins are loaded. If a plugin calls `__()` too early, `is_user_logged_in()` is missing and WordPress will fatal. `get_user_locale()` already handles this scenario for us, so it's safe to rely on exclusively.

See #44758.
Fixes #45235.

Built from https://develop.svn.wordpress.org/branches/5.0@43846


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-31 02:33:53 +00:00