Commit Graph

4862 Commits

Author SHA1 Message Date
Scott Taylor 2f328cc4c1 In `wp_ajax_replyto_comment()`, if `$_POST['comment_type']` is set, use it for the value of `$comment_type`, which the `compact()` call has assumed is set since [8720]. It never was.
`wp_comment_reply()`'s output can be complete overridden by the `wp_comment_reply` filter, so this check is justified and makes the AJAX callback more flexible.

Props nerrad.
Fixes #29704.

Built from https://develop.svn.wordpress.org/trunk@29758


git-svn-id: http://core.svn.wordpress.org/trunk@29530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-23 03:29:16 +00:00
Scott Taylor 9768b89cc7 If the current user does not have the `delete_posts` cap on the current post type, don't list `delete` or `trash` as bulk actions for the relevant context of Post list table.
Props mvd7793.
Fixes #20175.

Built from https://develop.svn.wordpress.org/trunk@29757


git-svn-id: http://core.svn.wordpress.org/trunk@29529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-23 02:58:16 +00:00
Sergey Biryukov 26124b9aad Pass the attachment ID to the 'image_add_caption_text' filter.
fixes #29607.
Built from https://develop.svn.wordpress.org/trunk@29754


git-svn-id: http://core.svn.wordpress.org/trunk@29526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 10:11:16 +00:00
Sergey Biryukov 79d017a024 Add 'image_add_caption_text' filter for changing the pre-parse caption text before output to the editor.
props collinsinternet, DrewAPicture.
fixes #29607.
Built from https://develop.svn.wordpress.org/trunk@29753


git-svn-id: http://core.svn.wordpress.org/trunk@29525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 09:56:17 +00:00
Andrew Nacin 1447092f6e Don't set ftp_credentials option when installling. see #29635.
Built from https://develop.svn.wordpress.org/trunk@29749


git-svn-id: http://core.svn.wordpress.org/trunk@29521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-17 17:58:15 +00:00
Scott Taylor d0a327b0b9 Make the URL output in `_thickbox_path_admin_subfolder()` use `includes_url()`.
Props voldemortensen.
Fixes #14157.

Built from https://develop.svn.wordpress.org/trunk@29741


git-svn-id: http://core.svn.wordpress.org/trunk@29515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-12 22:31:18 +00:00
Scott Taylor 69998d452b In `media_handle_upload()`, don't call `wp_read_image_metadata()` on things that aren't images (like videos). We never caught this error, because we are suppressing it by calling `@wp_read_image_metadata()`.
Props jrf for the initial patch.
Fixes #28907.

Built from https://develop.svn.wordpress.org/trunk@29737


git-svn-id: http://core.svn.wordpress.org/trunk@29511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-11 20:15:17 +00:00
Andrew Ozz 69e7171f41 Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602
Built from https://develop.svn.wordpress.org/trunk@29729


git-svn-id: http://core.svn.wordpress.org/trunk@29503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-10 22:40:16 +00:00
Scott Taylor fa0acbe3bb Don't overwrite the `length` property unnecessarily when generating metadata for audio and video files.
Props jrf, wonderboymusic.
Fixes #29176.

Built from https://develop.svn.wordpress.org/trunk@29728


git-svn-id: http://core.svn.wordpress.org/trunk@29502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-10 21:57:15 +00:00
Sergey Biryukov 1eb26d3ff3 Use https for apps.wordpress.org links.
props pento.
fixes #29595 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29721


git-svn-id: http://core.svn.wordpress.org/trunk@29495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-09 06:29:15 +00:00
Andrew Nacin f7392ef917 Pinking shears.
Built from https://develop.svn.wordpress.org/trunk@29707


git-svn-id: http://core.svn.wordpress.org/trunk@29481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-04 15:23:16 +00:00
Andrew Nacin 00fac0639d Link to apps.wordpress.org instead of wordpress.org/mobile.
props pento.
fixes #29496.

Built from https://develop.svn.wordpress.org/trunk@29703


git-svn-id: http://core.svn.wordpress.org/trunk@29477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-04 14:22:15 +00:00
Sergey Biryukov 2ff943b7b0 Restore the post type's view_item label for preview links that don't submit the changes.
fixes #28350.
Built from https://develop.svn.wordpress.org/trunk@29695


git-svn-id: http://core.svn.wordpress.org/trunk@29470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 11:33:16 +00:00
Dominik Schilling de59e21b62 Language Pack Upgrader: Allow to disable asynchronously translation updates.
* Don't touch VCS installs.
* Use the `async_update_translation` filter (which corresponds exactly to `auto_update_translation`) to entirely disable it, or based on the update offer. 

props nacin, ocean90.
fixes #28571.
Built from https://develop.svn.wordpress.org/trunk@29694


git-svn-id: http://core.svn.wordpress.org/trunk@29469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 10:38:17 +00:00
Andrew Nacin 8a9186b878 Media Library: Fix media trash handling.
props ocean90, obenland.
fixes #29469.

Built from https://develop.svn.wordpress.org/trunk@29690


git-svn-id: http://core.svn.wordpress.org/trunk@29465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 06:47:16 +00:00
Dion Hulse e8f6320bb4 Language Pack Upgrader: Remove ALL pre-existing filters before performing a translation update these filters may act in an unexpected way during the upgrade process.
See #29230. Fixes #29425.

Built from https://develop.svn.wordpress.org/trunk@29685


git-svn-id: http://core.svn.wordpress.org/trunk@29460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 05:38:14 +00:00
Andrew Nacin 4080e96339 Ensure oEmbed previews listen to [embed] width/height attributes.
props azaozz.
fixes #29474.

Built from https://develop.svn.wordpress.org/trunk@29681


git-svn-id: http://core.svn.wordpress.org/trunk@29456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 00:40:16 +00:00
Helen Hou-Sandí 433210a907 Plugin install: Better styling to accommodate plugin icons.
fixes #29466.

Built from https://develop.svn.wordpress.org/trunk@29679


git-svn-id: http://core.svn.wordpress.org/trunk@29454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 19:47:16 +00:00
Dominik Schilling c6af00d8b0 Language Pack Upgrader: Check return value before accessing the first array key.
Prevents a fatal error when Language_Pack_Upgrader::bulk_upgrade() returns a WP_Error object.

fixes #29470.
Built from https://develop.svn.wordpress.org/trunk@29675


git-svn-id: http://core.svn.wordpress.org/trunk@29450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 18:28:17 +00:00
Dominik Schilling 81d600dcca Install: Only show the language chooser when we have access to the filesystem without asking for credentials.
fixes #29397.
Built from https://develop.svn.wordpress.org/trunk@29673


git-svn-id: http://core.svn.wordpress.org/trunk@29448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 18:07:18 +00:00
Sergey Biryukov 5faf09a261 Restore 'insert-media-button' as an ID attribute for the first instance of media_buttons(). Remove IDs for subsequent instances.
props nacin.
fixes #28090.
Built from https://develop.svn.wordpress.org/trunk@29671


git-svn-id: http://core.svn.wordpress.org/trunk@29445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 09:08:16 +00:00
Andrew Nacin 683238567d Plugin install: The sort callback doesn't need to be public.
props helen.
fixes #28673.

Built from https://develop.svn.wordpress.org/trunk@29666


git-svn-id: http://core.svn.wordpress.org/trunk@29440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 06:51:16 +00:00
Helen Hou-Sandí b80c5d3e51 Comments: Simplify JS for inline edit and reply.
fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@29662


git-svn-id: http://core.svn.wordpress.org/trunk@29436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 03:57:18 +00:00
Helen Hou-Sandí 6926e9aea6 Media: Translate a string for the search placeholder.
props alex-ye.
fixes #29448.

Built from https://develop.svn.wordpress.org/trunk@29659


git-svn-id: http://core.svn.wordpress.org/trunk@29433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-01 19:54:16 +00:00
Helen Hou-Sandí 42afb446db Media: `views_upload` filter expects an array, not a string.
see #28946.

Built from https://develop.svn.wordpress.org/trunk@29641


git-svn-id: http://core.svn.wordpress.org/trunk@29415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-27 03:06:27 +00:00
Andrew Nacin 69204000ca Adjust [29634] so the Upload Plugin button can be shown. see #29236.
Built from https://develop.svn.wordpress.org/trunk@29637


git-svn-id: http://core.svn.wordpress.org/trunk@29411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-27 02:59:16 +00:00
Andrew Nacin 8f6fbcdc52 Plugin installer: Minor adjustments to aid with discovery.
fixes #29387.

Built from https://develop.svn.wordpress.org/trunk@29636


git-svn-id: http://core.svn.wordpress.org/trunk@29410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-27 02:53:16 +00:00
Andrew Nacin ac3dd27737 Plugin/Theme Uploads: New capabilities; unify UIs; ensure compatibility with old filters.
Introduce upload_plugins and upload_themes capabilities to allow blocking of plugin and theme uploads, versus the old hacky (and not secure) ways of just hiding UI tabs. These are simply meta capabilities that map to install_plugins and install_themes.
 
Also:
 * Use the same nice design for the plugin upload screen as the theme upload screen.
 * Better compatibility for the old install_themes_tabs filter added in [29002]. see #28578.
 * Ensure using the install_plugins_tabs filter to remove the upload tab removes the new button.
 * Use 'Add Plugins' instead of 'Install Plugins' to match 'Add Themes'.

fixes #29236.

Built from https://develop.svn.wordpress.org/trunk@29634


git-svn-id: http://core.svn.wordpress.org/trunk@29408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-27 01:32:18 +00:00
Dominik Schilling a32210ef42 Language Form: The language option for `$wp_local_package` should get the same attributes as the other languages.
see #15677.
Built from https://develop.svn.wordpress.org/trunk@29633


git-svn-id: http://core.svn.wordpress.org/trunk@29407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 22:27:16 +00:00
Dominik Schilling d544610681 Language packs: No WPLANG anymore.
* The WPLANG constant is no longer needed. Remove define('WPLANG', ''); from wp-config-sample.php. Populate WPLANG option based on the WPLANG constant. When get_option('WPLANG') is an empty string it will override WPLANG.
* Introduce translations_api() which is available to communicate with the translation API. Move translation install related functions to a new file.
* Replace mu_dropdown_languages() with wp_dropdown_languages(). wp_dropdown_languages() is now populated by the translation API.
* Remove wp_install_load_language() and allow load_default_textdomain() to switch a core translation.

fixes #13069, #15677, #19760, #28730, #29281. 
Built from https://develop.svn.wordpress.org/trunk@29630


git-svn-id: http://core.svn.wordpress.org/trunk@29404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 19:59:16 +00:00
Helen Hou-Sandí 9e8b9a78ca Media library: Unify headers between view modes.
Includes back compat for `views_upload` links. These look a little awkward, but do not appear to be commonly used. Also prevents the view mode links from being dropped on smaller screens so a user doesn't get "stuck" in the list view.

This is different from other list tables, but aligns well with other uploaded content management screens (themes, plugins).

props pento, helen.
fixes #28946.

Built from https://develop.svn.wordpress.org/trunk@29625


git-svn-id: http://core.svn.wordpress.org/trunk@29399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 15:58:15 +00:00
Dominik Schilling 32030a073f RTL: Fix modal alignments.
* Prevent horizontal scrollbars in Chrome.
* URL fields should be always LTR.
* Force the plugin details to be LTR for all screens, see #19778.

fixes #29352.
Built from https://develop.svn.wordpress.org/trunk@29623


git-svn-id: http://core.svn.wordpress.org/trunk@29397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 12:55:16 +00:00
Dominik Schilling 9972b54e62 Theme Upgrader: Set `is_multi` to true when doing bulk upgrades.
fixes #29234.
Built from https://develop.svn.wordpress.org/trunk@29622


git-svn-id: http://core.svn.wordpress.org/trunk@29396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 09:24:17 +00:00
Dominik Schilling 5a67538b40 Language Pack Upgrader: Remove any pre-existing package checks and then set the new one for translations.
fixes #29230.
Built from https://develop.svn.wordpress.org/trunk@29621


git-svn-id: http://core.svn.wordpress.org/trunk@29395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 09:20:18 +00:00
Scott Taylor 149346ff6e MCE View sandboxes:
* Use a `MutationObserver` to listen to the `body` class of the parent editor frame.
* In `wpview_media_sandbox_styles()`, only return the MEjs stylesheets.
* In `wp_ajax_parse_media_shortcode()` and `wp_ajax_parse_embed()`, return an object instead of an HTML blob to allow passing `body` and `head` separately	

Props avryl, azaozz.
Fixes #29048.

Built from https://develop.svn.wordpress.org/trunk@29615


git-svn-id: http://core.svn.wordpress.org/trunk@29389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:46:15 +00:00
Helen Hou-Sandí b1b7d5f3a2 Only show one search form for the plugin installer.
The field dropdown now appears in the filter bar only when doing a search.

see #28785.

Built from https://develop.svn.wordpress.org/trunk@29597


git-svn-id: http://core.svn.wordpress.org/trunk@29371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 16:03:16 +00:00
Andrew Nacin 4261ce75a6 Plugins: Only show details link if user can install plugins.
fixes #17902.

Built from https://develop.svn.wordpress.org/trunk@29595


git-svn-id: http://core.svn.wordpress.org/trunk@29369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:28:17 +00:00
Sergey Biryukov b06652da92 Install Plugins: Don't wp_die() if API can't be reached.
props johnbillion.
fixes #29361.
Built from https://develop.svn.wordpress.org/trunk@29594


git-svn-id: http://core.svn.wordpress.org/trunk@29368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:02:17 +00:00
Andrew Nacin 491f5cec39 Screen: Move editor scrolling screen option to the proper place.
see [29336], see #28328.

Built from https://develop.svn.wordpress.org/trunk@29588


git-svn-id: http://core.svn.wordpress.org/trunk@29362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 17:57:16 +00:00
Andrew Nacin bb4db92621 Plugin install: Add icons to compatible/incompatible. see #29313.
Built from https://develop.svn.wordpress.org/trunk@29586


git-svn-id: http://core.svn.wordpress.org/trunk@29360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 17:26:15 +00:00
Dominik Schilling 3a980c39c8 Apply accessibility improvements to Plugins screen too.
props SergeyBiryukov.
fixes #29342.
Built from https://develop.svn.wordpress.org/trunk@29583


git-svn-id: http://core.svn.wordpress.org/trunk@29357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:22:16 +00:00
Dominik Schilling 49937c88f9 Plugin compatibility is based on your version of WordPress, not your install.
fixes #29313.
Built from https://develop.svn.wordpress.org/trunk@29581


git-svn-id: http://core.svn.wordpress.org/trunk@29355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:14:16 +00:00
Dominik Schilling 6c9853930a Add missing array keys for connection type in `request_filesystem_credentials()`.
see [28456].
fixes #29347.

Built from https://develop.svn.wordpress.org/trunk@29580


git-svn-id: http://core.svn.wordpress.org/trunk@29354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:04:18 +00:00
Andrew Ozz 42258a6d89 TinyMCE wpView: fix showing errors for non-embeddable URLs, no-ssl or no items. Props avryl, fixes #29114, see #29268.
Built from https://develop.svn.wordpress.org/trunk@29577


git-svn-id: http://core.svn.wordpress.org/trunk@29351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 18:55:15 +00:00
Sergey Biryukov 039df6aac6 Plugin compatibility warnings should be red, not green.
props avryl.
fixes #29309.
Built from https://develop.svn.wordpress.org/trunk@29574


git-svn-id: http://core.svn.wordpress.org/trunk@29348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 03:57:19 +00:00
Andrew Nacin e32fc4df46 Export: Add wxr_export_skip_commentmeta filter to match the _postmeta filter.
props cfinke.
fixes #28745.

Built from https://develop.svn.wordpress.org/trunk@29573


git-svn-id: http://core.svn.wordpress.org/trunk@29347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 01:48:17 +00:00
Andrew Nacin 0eed9373e2 Introduce plugin icons in the installer.
See http://wp.me/p2AvED-2P8 for the announcement and how to implement these.

props tellyworth.
see #28785.

Built from https://develop.svn.wordpress.org/trunk@29569


git-svn-id: http://core.svn.wordpress.org/trunk@29343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 19:11:17 +00:00
Andrew Ozz 53c047263b TinyMCE wpView: add a filter for the stylesheet URLs loaded in the sandbox iframes. See #29048.
Built from https://develop.svn.wordpress.org/trunk@29559


git-svn-id: http://core.svn.wordpress.org/trunk@29334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 21:34:15 +00:00
Dominik Schilling 048b96f80d Media: Remove scan for lost attachments.
This hasn't been worked for 4 years.

fixes #29169.

Built from https://develop.svn.wordpress.org/trunk@29550


git-svn-id: http://core.svn.wordpress.org/trunk@29326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 17:09:15 +00:00
Andrew Ozz bb862e8221 TinyMCE wpView: show an error when no items are found while parsing a audio/video/playlist shortcode. Props avryl, fixes #29114.
Built from https://develop.svn.wordpress.org/trunk@29546


git-svn-id: http://core.svn.wordpress.org/trunk@29322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 23:23:16 +00:00