8894c0f1a2
Coding Standards: Use strict comparison in `wp-admin/widgets.php`.
...
Props jenilk.
Fixes #49000 .
Built from https://develop.svn.wordpress.org/trunk@46964
git-svn-id: http://core.svn.wordpress.org/trunk@46764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 12:55:03 +00:00
5b9fd2d7e7
Coding Standards: Use strict comparison in `wp-admin/includes/network.php`.
...
Props ataurr.
Fixes #48994 .
Built from https://develop.svn.wordpress.org/trunk@46963
git-svn-id: http://core.svn.wordpress.org/trunk@46763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 12:37:06 +00:00
6d40400756
Coding Standards: Use strict comparison in `wp-admin/edit-tags.php`.
...
Props passoniate.
Fixes #48985 .
Built from https://develop.svn.wordpress.org/trunk@46962
git-svn-id: http://core.svn.wordpress.org/trunk@46762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-15 10:46:02 +00:00
087282e810
Coding Standards: Use strict comparison in `wp-admin/term.php`.
...
Props vinita29.
Fixes #48983 .
Built from https://develop.svn.wordpress.org/trunk@46961
git-svn-id: http://core.svn.wordpress.org/trunk@46761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-15 09:45:01 +00:00
0b8438a6d2
I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders.
...
Props ramiy.
Fixes #48863 .
Built from https://develop.svn.wordpress.org/trunk@46957
git-svn-id: http://core.svn.wordpress.org/trunk@46756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-13 21:27:05 +00:00
db18e7d50b
Upgrade/Install: Improve the appearance of language selection on install:
...
* Remove a stray chevron.
* Improve focus and hover styles.
Props garrett-eclipse, audrasjb.
Fixes #48927 .
Built from https://develop.svn.wordpress.org/trunk@46887
git-svn-id: http://core.svn.wordpress.org/trunk@46687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 23:03:03 +00:00
9b91ffde04
Docs: Improve documentation for `wp_dashboard_browser_nag()` and `dashboard_browser_nag_class()`.
...
Props grapplerulrich.
Fixes #48932 .
Built from https://develop.svn.wordpress.org/trunk@46880
git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 10:59:05 +00:00
6ddf02b188
Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters.
...
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599 .
Built from https://develop.svn.wordpress.org/trunk@46868
git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 21:03:02 +00:00
a209908501
Administration: Standardize form control height and alignment across the admin.
...
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.
Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420 .
Built from https://develop.svn.wordpress.org/trunk@46866
git-svn-id: http://core.svn.wordpress.org/trunk@46666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 20:26:03 +00:00
dd47d5aa81
Media: Use consistent width for Scale and Crop inputs.
...
Follow-up to [46359].
Props sabernhardt, audrasjb.
Fixes #48907 .
Built from https://develop.svn.wordpress.org/trunk@46856
git-svn-id: http://core.svn.wordpress.org/trunk@46656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 16:23:02 +00:00
9648c368f0
Help/About: Add a hover effect for links on About pages.
...
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.
Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582 .
Built from https://develop.svn.wordpress.org/trunk@46852
git-svn-id: http://core.svn.wordpress.org/trunk@46652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 15:31:05 +00:00
dcf0cb68a2
Administration: Correct checkbox width in list tables on smaller screens.
...
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.
Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815 .
Built from https://develop.svn.wordpress.org/trunk@46845
git-svn-id: http://core.svn.wordpress.org/trunk@46645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 14:26:02 +00:00
ac690426eb
Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created.
...
This ensures that the actual UI controls state matches the visually conveyed state.
Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409 .
Built from https://develop.svn.wordpress.org/trunk@46842
git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:49:03 +00:00
d53103ed62
Docs: Further docblock corrections and improvements.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46826
git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 13:23:01 +00:00
f93ee2ca76
Docs: Increase the specificity of various docblock parameter types and return types.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46823
git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 22:43:04 +00:00
aa1fdcbd52
Docs: Correct various docblocks documentation.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46821
git-svn-id: http://core.svn.wordpress.org/trunk@46621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 22:23:04 +00:00
7d84502589
Text Changes: Rename Comment Blacklist option to be more inclusive
...
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.
Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900 .
Built from https://develop.svn.wordpress.org/trunk@46820
git-svn-id: http://core.svn.wordpress.org/trunk@46620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 18:12:02 +00:00
2165eef44c
Accessibility: Administration: Correct active button color for the alternative color schemes.
...
Follow-up to [46815].
Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598 .
Built from https://develop.svn.wordpress.org/trunk@46817
git-svn-id: http://core.svn.wordpress.org/trunk@46617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 22:12:03 +00:00
20e18613d0
Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
...
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.
Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585 .
Built from https://develop.svn.wordpress.org/trunk@46815
git-svn-id: http://core.svn.wordpress.org/trunk@46615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 21:32:03 +00:00
38ad319fdf
I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings.
...
Props ramiy.
Fixes #48875 .
Built from https://develop.svn.wordpress.org/trunk@46812
git-svn-id: http://core.svn.wordpress.org/trunk@46612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-04 10:36:01 +00:00
a5e52e04ee
Docs: Move the canonical DocBlock for `handle_bulk_actions-{$screen}` action to `wp-admin/edit.php`.
...
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.
Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857 .
Built from https://develop.svn.wordpress.org/trunk@46811
git-svn-id: http://core.svn.wordpress.org/trunk@46611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-03 13:58:05 +00:00
135e608b46
Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original.
...
Fixes #48736 .
Built from https://develop.svn.wordpress.org/trunk@46809
git-svn-id: http://core.svn.wordpress.org/trunk@46609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-01 18:26:05 +00:00
0221a593b9
Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile.
...
Props donmhico, jeremyfelt.
Fixes #48799 .
Built from https://develop.svn.wordpress.org/trunk@46807
git-svn-id: http://core.svn.wordpress.org/trunk@46607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-30 00:42:01 +00:00
1d1c74385f
REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter.
...
See #48839 .
Built from https://develop.svn.wordpress.org/trunk@46804
git-svn-id: http://core.svn.wordpress.org/trunk@46604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 22:04:02 +00:00
2a0489ec49
Docs: Replace `@returns` tags in JS docs with `@return`.
...
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46800
git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 18:01:03 +00:00
4a4afbd68c
Docs: Add missing full stops to `@returns` tags in JS docs, per the documentation standards.
...
Props shital-patel, kalpshit.
Fixes #48305 .
Built from https://develop.svn.wordpress.org/trunk@46799
git-svn-id: http://core.svn.wordpress.org/trunk@46599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 16:56:02 +00:00
acd0a3ca99
Site Health: Add a test for PHP default timezone.
...
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.
WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.
Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692 .
Built from https://develop.svn.wordpress.org/trunk@46797
git-svn-id: http://core.svn.wordpress.org/trunk@46597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 15:48:03 +00:00
6f86cedb09
Menus: Improve the wording of instructions for dragging the items into the preferred order.
...
Props amolv, equin0x80, dlh.
Fixes #48184 .
Built from https://develop.svn.wordpress.org/trunk@46791
git-svn-id: http://core.svn.wordpress.org/trunk@46591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 19:51:01 +00:00
d8b251f0af
Administration: Properly wrap long titles in list tables on smaller screens.
...
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805 .
Built from https://develop.svn.wordpress.org/trunk@46790
git-svn-id: http://core.svn.wordpress.org/trunk@46590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 16:52:02 +00:00
f4165a697d
Upgrade/Install: Provide a default label for "Continue" button in language selection form.
...
Prevents an empty continue button if a translation isn't yet available.
Props sathyapulse.
Fixes #48776 .
Built from https://develop.svn.wordpress.org/trunk@46784
git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 15:19:04 +00:00
63fefb540a
Users: Use correct variable when displaying the Additional Capabilities list in user profile.
...
Addresses a regression in [45926].
Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725 .
Built from https://develop.svn.wordpress.org/trunk@46782
git-svn-id: http://core.svn.wordpress.org/trunk@46582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 14:01:03 +00:00
2a85fe21d8
Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
...
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box
Split "Manage widgets or menus" into separate items for consistency with other links.
For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.
Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone
Props afercia, audrasjb, karmatosed.
Fixes #48406 .
Built from https://develop.svn.wordpress.org/trunk@46770
git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 19:57:05 +00:00
c786eaa1df
Coding Standards: Fix WPCS issue in [46763].
...
See #48777 .
Built from https://develop.svn.wordpress.org/trunk@46764
git-svn-id: http://core.svn.wordpress.org/trunk@46564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 19:21:03 +00:00
26a750e162
Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`.
...
Props sathyapulse, zodiac1978.
Fixes #48777 .
Built from https://develop.svn.wordpress.org/trunk@46763
git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 18:51:01 +00:00
56af5db74f
Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
...
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592 .
Built from https://develop.svn.wordpress.org/trunk@46758
git-svn-id: http://core.svn.wordpress.org/trunk@46558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-22 00:04:02 +00:00
44d5372825
I18N: Correct translator comment for `By %s` string in Plugins list table.
...
Follow-up to [44541].
See #45898 .
Built from https://develop.svn.wordpress.org/trunk@46755
git-svn-id: http://core.svn.wordpress.org/trunk@46555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-21 00:08:02 +00:00
71725aeb95
Accessibility: Add an `aria-current` attribute to the Media Library switch links.
...
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.
Props mayanksonawat, afercia.
Fixes #48271 .
Built from https://develop.svn.wordpress.org/trunk@46746
git-svn-id: http://core.svn.wordpress.org/trunk@46546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:51:02 +00:00
eec579dd86
Widgets: Avoid to move focus to the Image Widget "Insert from URL" field.
...
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169 .
Props dufresnesteven.
See #43169 .
Fixes #48588 .
Built from https://develop.svn.wordpress.org/trunk@46745
git-svn-id: http://core.svn.wordpress.org/trunk@46545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:23:02 +00:00
306045277e
Administration: Switch `rgb()` CSS property for paused plugin error message in Plugins list table to `rgba()`.
...
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.
Props manikmist09.
Fixes #48629 .
Built from https://develop.svn.wordpress.org/trunk@46744
git-svn-id: http://core.svn.wordpress.org/trunk@46544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 13:18:03 +00:00
5aa3a51264
Docs: Update broken source code link in `WP_Filesystem_SSH2` class.
...
Props mryoga, finchps.
Fixes #48467 .
Built from https://develop.svn.wordpress.org/trunk@46742
git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 16:16:02 +00:00
418db0297e
Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages.
...
Props garrett-eclipse.
Fixes #48676 .
Built from https://develop.svn.wordpress.org/trunk@46739
git-svn-id: http://core.svn.wordpress.org/trunk@46539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 07:43:01 +00:00
927aa4b44c
Docs: Fix typo in `wp_credits_section_title()` description.
...
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.
Props hareesh-pillai.
Fixes #48674 .
Built from https://develop.svn.wordpress.org/trunk@46738
git-svn-id: http://core.svn.wordpress.org/trunk@46538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-16 21:04:01 +00:00
4ec53dc54c
Docs: Remove incorrect `@return` tags.
...
Props diddledan.
Fixes #48613 , #48614 .
Built from https://develop.svn.wordpress.org/trunk@46732
git-svn-id: http://core.svn.wordpress.org/trunk@46532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-14 09:57:03 +00:00
6ceb0279af
Help/About: Move images to the CDN.
...
Props ryelle.
Fixes #47708 .
Built from https://develop.svn.wordpress.org/trunk@46724
git-svn-id: http://core.svn.wordpress.org/trunk@46524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:30:03 +00:00
2265c36568
Help/About: Update the 5.3 About page.
...
* Remove extra padding on the Credits tab.
Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46709
git-svn-id: http://core.svn.wordpress.org/trunk@46509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 20:45:04 +00:00
ba249d8951
Help/About: Update the 5.3 About page.
...
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.
Previously [46556], [46572], [46616].
Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46705
git-svn-id: http://core.svn.wordpress.org/trunk@46505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 16:07:03 +00:00
3d623995a8
Docs: In various `@return` tags, list the expected type first, instead of `WP_Error`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46696
git-svn-id: http://core.svn.wordpress.org/trunk@46496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 02:43:03 +00:00
82dfb2d151
Docs: Miscellaneous docblock corrections in `wp-admin/includes/plugin.php`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46695
git-svn-id: http://core.svn.wordpress.org/trunk@46495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 00:05:01 +00:00
2af39e45cb
Docs: Improve documentation for `deactivate_plugins()` and `activate_plugins()`.
...
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352 .
Built from https://develop.svn.wordpress.org/trunk@46694
git-svn-id: http://core.svn.wordpress.org/trunk@46494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-10 23:05:03 +00:00
0e79d4d101
Coding Standards: Fix WPCS issue in [46684].
...
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46687
git-svn-id: http://core.svn.wordpress.org/trunk@46487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:33:02 +00:00
Sergey Biryukov
John Blackbourn
Aaron Jorbin
Andrew Ozz
Dominik Schilling
Andrea Fercia