Commit Graph

20 Commits

Author SHA1 Message Date
Scott Taylor 2f513d3320 Fix some `hackificator` odds and ends in `wp-admin`:
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Drew Jaynes b4903834cf Remove some debug cruft accidentally committed in [27670].
See #27430.

Built from https://develop.svn.wordpress.org/trunk@27671


git-svn-id: http://core.svn.wordpress.org/trunk@27514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 02:38:17 +00:00
Drew Jaynes 1a0881f341 Inline documentation for hooks in wp-admin/includes/menu.php.
Also fixes syntax for a few unrelated multi-line comments in the file.

Props kpdesign for some minor cleanup.
Fixes #27430.

Built from https://develop.svn.wordpress.org/trunk@27670


git-svn-id: http://core.svn.wordpress.org/trunk@27513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 02:35:14 +00:00
Mark Jaquith 1b84d2140a Prevent an offset error if the first menu item is a separator.
props phill_brown. fixes #23182

git-svn-id: http://core.svn.wordpress.org/trunk@24455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-20 16:45:45 +00:00
Andrew Nacin b11654ce74 Revert [23871] - Customize should be added to the menu, but not hacked in as first. see #21413.
git-svn-id: http://core.svn.wordpress.org/trunk@24048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:33:39 +00:00
Mark Jaquith 8c4aeb9188 Add "Customize" as first item under Appearance menu.
fixes #21413. props ryanhellyer, obenland, DrewAPicture

git-svn-id: http://core.svn.wordpress.org/trunk@23871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:39:54 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan e261ac43e7 Avoid 'Only variables should be passed by reference' warnings. Props SergeyBiryukov. see #18975
git-svn-id: http://svn.automattic.com/wordpress/trunk@19072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-27 20:00:09 +00:00
ryan 6623ea4b4a Avoid pass by ref warning. Props arena. see #18975
git-svn-id: http://svn.automattic.com/wordpress/trunk@18997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-18 20:38:18 +00:00
ryan 9a1be60235 Avoid notice with empty menu. Props ansimation, SergeyBiryukov. fixes #18085
git-svn-id: http://svn.automattic.com/wordpress/trunk@18740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-21 20:17:22 +00:00
ryan 538658c4de Use array_pop( array_keys() ) instead of end() to find the end of the array. end() finds that last item added, which is not reliable with plugins that add items to the end and then sort them up with custom_menu_order. see #17629
git-svn-id: http://svn.automattic.com/wordpress/trunk@18109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-01 21:27:42 +00:00
ryan 9f677a0847 Use wp-menu-separator after Settings and before the first plugin top-level. Remove trailing separators. fixes #17629
git-svn-id: http://svn.automattic.com/wordpress/trunk@18089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-01 14:41:43 +00:00
ryan 3fc5956921 s/seperator/separator/. Props brandonburke. fixes #17610
git-svn-id: http://svn.automattic.com/wordpress/trunk@18084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-31 19:58:36 +00:00
ryan e68292421d Fix notices. Props ocean90. fixes #17528
git-svn-id: http://svn.automattic.com/wordpress/trunk@18038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 16:46:40 +00:00
ryan ae8f4a2a80 If there is only one submenu and it is has same destination as the parent, remove the submenu. fixes #17528
git-svn-id: http://svn.automattic.com/wordpress/trunk@18034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 16:05:52 +00:00
ryan a216b1ed8f Fix undefined offset warnings on pages the current user does not have perms for. Props wpdavis. fixes #15469
git-svn-id: http://svn.automattic.com/wordpress/trunk@16471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-18 19:55:05 +00:00
ryan 9c31fd7c70 First pass of user admin. Network admin and screen cleanups. see #14696
git-svn-id: http://svn.automattic.com/wordpress/trunk@15746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-07 19:34:18 +00:00
ryan 2a7220b15a Revert [15717]; it had extra bits in it
git-svn-id: http://svn.automattic.com/wordpress/trunk@15718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-04 19:28:31 +00:00
ryan d78d29dfc4 Fix user edit urls for network admin
git-svn-id: http://svn.automattic.com/wordpress/trunk@15717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-04 19:26:40 +00:00
ryan 21e3f0f7fa Network Admin, first pass. see #14435
git-svn-id: http://svn.automattic.com/wordpress/trunk@15481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-30 20:34:54 +00:00