Commit Graph

38378 Commits

Author SHA1 Message Date
Mel Choyce 625cae3537 Help/About: Minor updates.
- Updated the various images.
- Added new "developer happiness" images.
- Fixed the responsive figcaption styles.
- Added a link to wporg plugin favorites as a shortcode to get to the classic plugin.
- Renamed "cover image" to "cover."
- Updated CSS to account for small-screen issues.

Props desrosj, audrasjb, antpb, jjj, elrae, Otto42, afercia, karmatosed, kjellr, alexislloyd, melchoyce.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43946


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-28 17:31:47 +00:00
Gary Pendergast 07ebb6262c Block Editor: Clarify a translator comment in meta box handling.
Props ocean90.
See #45217.


Built from https://develop.svn.wordpress.org/branches/5.0@43945


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-27 06:39:48 +00:00
Gary Pendergast c52f62f1f5 Post WordPress 5.0 RC1 version bump.
Built from https://develop.svn.wordpress.org/branches/5.0@43944


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-23 09:41:45 +00:00
Gary Pendergast 3c89b67e4e WordPress 5.0 RC1.
Built from https://develop.svn.wordpress.org/branches/5.0@43943


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-23 09:14:45 +00:00
youknowriad 91c4d2295b Block Editor: Fix the WordPress packages and vendor script registration.
The version is set properly and the scripts are automatically loaded in the footer.
This patch also includes a revert for the reusable blocks enqueue script.

Props pento, swissspidy.
Fixes #45402.
See #45396.

Built from https://develop.svn.wordpress.org/branches/5.0@43942


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-23 08:35:45 +00:00
Gary Pendergast be60664fe1 Block Editor: Add a placeholder for meta boxes that don't work in the block editor.
If a meta box is registered with the `__block_editor_compatible_meta_box` set to `false`, it's indicating that it doesn't work in the block editor. If that's the case, we can add a place holder to inform the user that they'll need to use the classic interface to work with this meta box.

Props pento, jorgefilipecosta, peterwilsoncc, karmatosed, noisysocks, dd32.
See #45217.


Built from https://develop.svn.wordpress.org/branches/5.0@43941


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-23 08:15:46 +00:00
Gary Pendergast 0a164850fc Query: Remove nextpage block delimiters when setting up global post data.
`WP_Query::setup_postdata()` splits the post up by `<!--nextpage-->`, which causes invalid block data to be contained in the post content.

This change removes the `<!-- wp:nextpage -->` and `<!-- /wp:nextpage -->`, as well.

Props pento, youknowriad, azaozz, noisysocks.
See #45401.


Built from https://develop.svn.wordpress.org/branches/5.0@43940


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-23 00:42:45 +00:00
youknowriad 97e84f8a03 Block Editor: Refresh nonces used by wp.apiFetch.
Adds heartbeat nonces refreshing support to wp.apiFetch requests.

Props pento, adamsilverstein, dd32, desrosj.
Fixes #45113. 

Built from https://develop.svn.wordpress.org/branches/5.0@43939


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 19:40:46 +00:00
gziolo a69e8cf788 About: Update Freedoms page to include illustrations.
@cathibosco has made some great illustrations of the Four Freedoms on https://wordpress.org/about/. Let's bring that over to the admin Freedoms page.

Props @melchoyce, @cathibosco, @boemedia, @karmatosed, @tobifjellner, @helen, @matveb, @mcsf.
Fixes #45386.


Built from https://develop.svn.wordpress.org/branches/5.0@43938


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 18:03:45 +00:00
lonelyvegan eaaa8c7dc6 Help/About: Add copy for new block editor.
Adds information about the new block editor (Gutenberg) and the Classic Editor
to the about page.

Props @pixelverbieger, @ocean90, @melchoyce, @boemedia, @sami.keijonen, @TimothyBlynJacobs, @xkon, @afercia, @Otto42, @pento.
Fixes #45178.


Built from https://develop.svn.wordpress.org/branches/5.0@43937


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 15:24:45 +00:00
youknowriad db6ae8a9be Block Editor: Fix loading the script handling the "Manage Reusable Blocks" page.
This ensures the "import from JSON" and "export JSON" buttons are shown properly.
The script is loaded in the footer because it relies on the DOM being already there.

Props noisysocks, mukesh27.
Fixes #45396.

Built from https://develop.svn.wordpress.org/branches/5.0@43936


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 07:25:45 +00:00
noisysocks 7ade352f0f Block Editor: Update @wordpress package dependencies
Updates packages:

- block-library
- components
- edit-post
- editor
- format-library
- list-reusable-blocks
- nux

See #45145

Built from https://develop.svn.wordpress.org/branches/5.0@43935


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 06:05:51 +00:00
Gary Pendergast a7a70768ae WPDB: Check that `$wpdb->last_result` is countable before counting with it.
`wpdb::get_col()` iterates over `$wpdb->last_result`, which can be a non-countable value, should the preceeding query have failed.

Props spacedmonkey, desrosj.
See #45299.


Built from https://develop.svn.wordpress.org/branches/5.0@43934


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 03:59:44 +00:00
Gary Pendergast e0ff022be6 Build Tools: Don't minimise CSS in the unminimised files.
See #45201.


Built from https://develop.svn.wordpress.org/branches/5.0@43933


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 03:21:46 +00:00
Gary Pendergast 7d19c028be Build Tools: Tweak the webpack config for unminified files.
[43931] unintentionally caused the unminified files to wrap the code in an `eval()` call. 

See #45201.


Built from https://develop.svn.wordpress.org/branches/5.0@43932


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 03:12:49 +00:00
Gary Pendergast b93a84709d Build Tools: Don't include `.map` files in the build.
These files are fairly large, and while they're useful in development, they're not needed in the final build.

Props pento, mcsf.
See #45201.


Built from https://develop.svn.wordpress.org/branches/5.0@43931


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 02:05:47 +00:00
Peter Wilson 2c86860c5e Formatting: Revert pre-save filter adding `rel="noopener"`.
Removes filters adding `rel="noopener"` to links targeting `_blank`.

Previous implementation could introduce blank `rel` attributes and could corrupt JSON data when saving via the customizer.

See #43187.
Reverts [43732] and [43733] from the 5.0 branch.


Built from https://develop.svn.wordpress.org/branches/5.0@43930


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-22 00:24:48 +00:00
allancole 64fb03bd3a Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update changes the following: 

- Add dynamic theme version to stylesheet enqueue.

Props grapplerulrich, kjellr.


Built from https://develop.svn.wordpress.org/branches/5.0@43929


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 22:43:48 +00:00
allancole bfca06c5ac Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update changes the following: 

- Fixes link colors within solid-color pullquote blocks.

Props kjellr, xkon.


Built from https://develop.svn.wordpress.org/branches/5.0@43928


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 22:30:49 +00:00
allancole f1924dd922 Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update changes the following: 

- Fix social-menu and site-logo alignment.

Props kjellr, xkon.


Built from https://develop.svn.wordpress.org/branches/5.0@43927


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 20:14:49 +00:00
allancole 37875754c1 Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update changes the following: 

- Add PHPCS code quality fixes for functions.php
- Update stylesheets with a fresh Sass re-compile

Props xkon, kjellr


Built from https://develop.svn.wordpress.org/branches/5.0@43926


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 19:57:48 +00:00
youknowriad 7f07660ca8 Core Editor: Specify script versions for the WordPress packages and their vendor dependencies.
Using the package.json versions of the npm dependencies as versions when registering 
the WordPress scripts.

Props dimadin, dd32.
Fixes #45187.

Built from https://develop.svn.wordpress.org/branches/5.0@43925


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 19:46:48 +00:00
youknowriad c749dc382f Block Editor: Clarify PHP Docs of the block_version function.
Clarify the return value.

Props desrosj, mukesh27.
Fixes #45342.

Built from https://develop.svn.wordpress.org/branches/5.0@43924


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 19:39:49 +00:00
youknowriad 3ab0f22ec6 Block Editor: Fix PHP warning showing up when loading editor styles while in RTL.
In RTL languages, WordPress adds style-editor-rtl.css editor styles to the global $editor_styles
This patch ignores handling these styles if the file is not preset.

Props desrosj, mostafa.s1990.
Fixes #45288.

Built from https://develop.svn.wordpress.org/branches/5.0@43923


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 19:30:48 +00:00
Mel Choyce cec4083b46 About Page: Update images and de-italicize a11y note.
Props @matveb, @kjellr, @Alexis Lloyd, @courtney0burton, @melchoyce.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43922


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 17:00:48 +00:00
mcsf 0d5fd392e8 Warn users of Gutenberg plugin of its deactivation upon 5.0 upgrade.
Fixes #45073.


Built from https://develop.svn.wordpress.org/branches/5.0@43921


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 16:35:48 +00:00
mcsf ba1c444bf3 Block Editor: Show privacy help notice on Privacy Policy page.
When editing a page set to be the Privacy Policy page, display a help notice
containing a link to the Privacy Policy guide.

This changeset ports this functionality to the new Block Editor.

Props desrosj.
Fixes #45057.


Built from https://develop.svn.wordpress.org/branches/5.0@43920


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 16:18:49 +00:00
danielbachhuber 0fb5da94e6 Block Editor: Update @WordPress dependencies to match Gutenberg 4.5.1.
Updates packages: annotations,
api-fetch,
block-library,
blocks,
components,
core-data,
data,
dom, edit-post,
editor,
format-library,
jest-console,
jest-preset-default,
keycodes,
html-entities,
list-reusable-blocks,
notices,
nux,
rich-text,
scripts,
token-list, url,
viewport

Fixes undefined notices in some blocks. Removes incorrect `'gutenberg'` textdomain too.

See #45145

Built from https://develop.svn.wordpress.org/branches/5.0@43919


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 15:09:57 +00:00
danielbachhuber 6b781c6823 REST API: Preserve unknown, respect `null` in server-side block rendering.
* Skips validation where there is no attribute definition, but keeps the attribute value. Previously, the attribute would be omitted from the attributes passed to `render_callback`. Notably, this resolves an issue where `render_callback` cannot receive a block's `align` and `customClassName` attribute values, since these are defined as a client-side filter.
* Validates `null` as a proper value in its own right. Previously, a client implementation of a block could track `{"attribute":null}` as an explicitly empty value, and the server would wrongly initiate defaulting behavior. The new behavior will now only populate a default value if the attribute is not defined at all, including when unset in its being invalid per the attribute schema.

Props aduth, noisysocks, youknowriad.
See #45145 for the patch, #45098 for the original ticket.

Built from https://develop.svn.wordpress.org/branches/5.0@43918


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 14:44:48 +00:00
danielbachhuber ded3bf63b7 REST API: Always include `title.raw`/`content.raw` for Blocks in `context=view`.
Demarcations for reusable blocks are always expected to be accessible by clients.

Props noisysocks, youknowriad.
See #45145 for the patch, #45098 for the original ticket.

Built from https://develop.svn.wordpress.org/branches/5.0@43917


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 14:35:48 +00:00
danielbachhuber c06c2fe2d6 Block Editor: Expose value of `user_can_richedit()`.
In order for the Block Editor to know whether to allow visual editing, it needs to know the value of `user_can_richedit()`.

Props youknowriad.
Fixes #45375.

Built from https://develop.svn.wordpress.org/branches/5.0@43916


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 14:11:48 +00:00
Andrew Ozz f979e79d54 TinyMCE: Fix the keyboard shortcut (Alt+Shift+H) to not open the default Block Editor help modal and change the title of the help modal to "Classic Block Keyboard Shortcuts" in the Classic BLock. Also remove Alt+Shift+Z in the Classic Block as it conflicts with the Block Editor.
Fixes #45365.
Built from https://develop.svn.wordpress.org/branches/5.0@43915


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 12:28:48 +00:00
Andrew Ozz 5e278d5892 TinyMCE: Run the "wp_editor_settings" and "disable_captions" filters for the Classic block. Fixes possible regressions in plugins that use these filters, also plugins that use them to add filters for the buttons, external plugins, etc.
Fixes #45348.


Built from https://develop.svn.wordpress.org/branches/5.0@43914


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 12:18:51 +00:00
Mel Choyce 110a98f5e7 About Page: Initial About Page design and strings for 5.0.
Props @pixelverbieger, @ocean90, @karmatosed, @pento, @boemedia, @lonelyvegan, @sami.keijonen, @TimothyBlynJacobs, @xkon, @afercia, @laurelfulford, @joostdevalk, @ipstenu, @matveb, @joen, @tinkerbelly, @chanthaboune, @kjellr, @alexislloyd, @melchoyce.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43913


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 02:39:49 +00:00
Gary Pendergast aea8dfd090 Upgrade/Install: Split `Sample Page`, `Hello World`, and `Privacy Policy` content.
[43820] converted the content to blocks, but included block markers in the translateable strings, which made translations difficult to do accurately.

Props desrosj, dd32, ocean90.
See #45151.


Built from https://develop.svn.wordpress.org/branches/5.0@43912


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 01:48:49 +00:00
laurelfulford 2b17adc00e Twenty Sixteen: Update theme’s wide image styles to include Image Blocks
Twenty Sixteen includes functionality and styles that make full-size images extend wider than the content when they are added to posts, and appear below the post meta. This update adds the same behavior to image blocks and their captions.

Fixes: #45380.


Built from https://develop.svn.wordpress.org/branches/5.0@43911


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 01:05:50 +00:00
Gary Pendergast f2dc6be776 i18n: Remove the `wp_get_jed_locale_data()` function.
This function was used as a translation workaround in the Gutenberg plugin, it has been replaced in core with the `wp_set_script_translations()` functionality, instead.

See #45111.


Built from https://develop.svn.wordpress.org/branches/5.0@43910


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-21 01:03:48 +00:00
allancole bf1668333f Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update changes the following: 

- Fix JS errors in customizer caused by menu scripts
- Fix footer menu spacing
- Fix pullquote block borders to follow Gutenberg’s described style
- Fix editor-only styles so they don't appear on the frontend when not needed
- Fix search field widget width on mobile
- Fix :visited .button link colors
- Fix Block toolbar position in the editor
- Fix off-canvas mobile menu to prevent text from overflowing
- Improve column block formatting for the editor and frontend
- Improve CSS optimization for selectors that add `dashes` to multi-level lists
- Improve editor font sizes to use pixels over ems
- Improve styles for galleries in the Classic Editor block
- Improve priority+ more-menu threshold to allow more space for menu-items
- Improve logo size on mobile devices
- Improve customizer color options to present a single, unified color option
- Improve print stylesheet for better spacing and colors
- Add more color options to Gutenberg editor 

Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, jorbin, netweb, b-07, khleomix, audrasjb, nielslange, mmaumio, richsalvucci, littlebigthing, dimadin, joyously, anevins, peterwilsoncc, dannycooper, iCaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, grapplerulrich, ocean90, joshfeck, frankew, AbdulWahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, nao, mayukojpn, enodekciw, ketuchetan, atanasangelovdev, poena, sharaz, artisticasad, mukesh27, burhandodhy, crunnells, aprakasa, themeroots, imonly_ik, tlxo, youthkee, brentswisher, smyoon315, mrahmadawais, desideveloper, Kau-Boy, mor10, mikeyarce, dingo_bastard


Built from https://develop.svn.wordpress.org/branches/5.0@43909


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-19 21:27:51 +00:00
danielbachhuber bcfb6d34f2 REST API: Include fields with null schema in `get_fields_for_response()`.
In [43736], we prevented rendering fields when not present in `?_fields=`. However, because `get_fields_for_response()` is dependent on `get_item_schema()`, any custom fields registered with a null schema would be incorrectly excluded from the response. Because the REST API permits a null schema for `register_rest_field()`, those fields should be included in the available fields for a response.

Fixes #45220.

Built from https://develop.svn.wordpress.org/branches/5.0@43908


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-19 14:10:50 +00:00
Gary Pendergast b8906e5e95 Post WordPress 5.0 Beta 5 version bump.
Built from https://develop.svn.wordpress.org/branches/5.0@43907


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-16 01:07:48 +00:00
Gary Pendergast 35108f5e4b WordPress 5.0 Beta 5.
Built from https://develop.svn.wordpress.org/branches/5.0@43906


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-16 00:58:48 +00:00
Gary Pendergast 3fa1bd8241 Build Tools: Minify the package CSS when building.
CSS coming from the `@wordpress` packages wasn't being minified in the build. This had the noteable side effect of causing RTL CSS to not be loaded when `SCRIPT_DEBUG` was set to `false`.

Props websupporter.
See #45330.


Built from https://develop.svn.wordpress.org/branches/5.0@43905


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-16 00:23:49 +00:00
allancole 2a8d718307 Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update changes the following: 

- Improve menu UI to support keyboard navigation in both directions
- Improve more-menu-link visibility when no menu items are hidden
- Improve text-selection custom colors for better contrast and legibility
- Improve support for sticky toolbars in the editor
- Improve table element fonts
- Add .button class support 
- Remove translation escaping
- Fix menu JS to prevent unused touched event listeners
- Fix duplicate more-menu-link issue on selective refresh in the customizer
- Fix editor font-weights for headings
- Fix search form input style
- Fix nested blockquote styles
- Fix download block button style when download text stretches more than one line
- Fix audio block centering issue
- Fix align-full blocks in the editor so they don’t create horizontal scrollbars
- Fix editor to prevent Gutenberg's meta boxes area from overlapping the content

Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, ntwb, b-07, khleomix, audrasjb, nielslange, mmaumio, richsalvucci, littlebigthing, dimadin, joyously, anevins12, peterwilsoncc, DannyCooper, WPprodigy, siriokun, briannaorg, 00travelgirl00, shahjehanali1, ianbelanger79, nadim1992, Ismail-elkorchi, nativeinside, iamchetanp, grappler, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, jasmussen, laurelfulford, mdawaffe, kraftbj, dereksmart, naokomc, mayukojpn, enodekciw, chetansatasiya, ketuchetan, atanas-angelov-dev, carolinan, sharazghouri, artisan-asad, mukeshpanchal27, mukesh27, burhandodhy, @crunnells, aryaprakasa, tlxo, themeroots, whizbangik, yingles, tlxo, youthkee, brentswisher, smy315, ahmadawais, desi-developer, 2ndkauboy, mor10.

Built from https://develop.svn.wordpress.org/branches/5.0@43904


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-16 00:14:49 +00:00
aduth 2ae0f9e6b4 Block Editor: Update @wordpress dependencies to match Gutenberg 4.4.0
Updates packages: annotations, api-fetch, block-library, blocks, components, compose, core-data, data, date, edit-post, editor, element, format-library, i18n, list-reusable-blocks, notices, nux, plugins, rich-text, viewport

Updates changed dependencies in script-loader.php

Upgrades React from 16.5.2 to 16.6.3

See #45145

Built from https://develop.svn.wordpress.org/branches/5.0@43903


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-16 00:10:55 +00:00
Gary Pendergast 5e150a2264 Tests: Update a test that relied on the Hello Dolly plugin version.
[43900] changed the plugin version, causing a unit test failure.

See #45345.


Built from https://develop.svn.wordpress.org/branches/5.0@43902


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-16 00:02:48 +00:00
Gary Pendergast 5ad2582000 Block Editor: Load TinyMCE inline scripts later.
Previously, the TinyMCE inline scripts were added on the `init` action in the block editor. In the classic editor, however, these scripts are loaded when the TinyMCE window is printed, and some plugins rely on them being loaded later, so they can attach to the appropriate filters.

See #45338.


Built from https://develop.svn.wordpress.org/branches/5.0@43901


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-15 23:53:49 +00:00
Gary Pendergast 1f13d6144d Hello Dolly: Hide the lyrics in the block editor.
I'm sorry, Hello Dolly. You're my favourite plugin, but the way you output your lyrics doesn't play nicely with the block editor, particuarly on mobile devices.

This isn't Farewell Dolly, you're still on every other admin page, and I know you'll come back better and stronger.

Props joen.
See #45345.


Built from https://develop.svn.wordpress.org/branches/5.0@43900


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-15 23:38:48 +00:00
Gary Pendergast 80dd8b9b83 Nav Menus: Fix a PHP 7.3 error when switching themes.
When switching themes, `wp_map_nav_menu_locations()` is used to ensure nav menus are placed in the relevant menu location. Occasionally, menus are registered to locations with numeric slugs, rather than strings. `wp_map_nav_menu_locations()` assumed it would be the latter, and ran `stripos()` on those numeric slugs. This behaviour is deprecated in PHP 7.3.

As this is the last known PHP 7.3 incompatibility, this commit also removes PHP 7.3 from Travis' `allowed_failures` list.

Props desrosj, jorbin.
See #45018.


Built from https://develop.svn.wordpress.org/branches/5.0@43899


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-15 23:20:48 +00:00
herregroen 73a19c6116 I18N: Fix warnings in JavaScript translations.
Fixes an undefined index PHP warning in the load_script_textdomain function and a non-interrupting JS error when registering a domain which has no translations.

Props omarreiss, ocean90, georgestephanis.
Fixes #45256.

Built from https://develop.svn.wordpress.org/branches/5.0@43898


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-15 14:37:49 +00:00
danielbachhuber 5cf84bd3f7 REST API: Avoid using 'parent' as path argument name for autosaves.
When 'parent' is set as the path argument name, it gets passed down through to the `create_item()` method and can erroneously reset the 'parent' value on the post itself. Instead, we rename the argument to 'id' and replicate the revision controller's `get_items_permissions_check()` to instead reference 'id'.

Also ensures revision query params (of which there are many) aren't exposed as the query params for autosaves (of which there are two).

Props TimothyBlynJacobs.
See #43316.

Built from https://develop.svn.wordpress.org/branches/5.0@43897


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-15 12:57:51 +00:00