Commit Graph

15 Commits

Author SHA1 Message Date
joedolson a3a61c5a3e General: Remove role="navigation" from nav elements.
Role="navigation" was required for assistive technology to recognize HTML5 element's native ARIA roles while HTML5 and ARIA were being introduced. With the deprecation of IE11, the role attribute is only required when mapping elements that don't have native role.

Props costdev, mukesh27.
Fixes #54054.
Built from https://develop.svn.wordpress.org/trunk@51967


git-svn-id: http://core.svn.wordpress.org/trunk@51556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-01 21:47:13 +00:00
Sergey Biryukov 4811dad603 I18N: Use consistent pattern for placeholder references in translator comments for some bundled theme strings.
Follow-up to [42827], [44562], [50234].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@51157


git-svn-id: http://core.svn.wordpress.org/trunk@50766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-15 15:38:57 +00:00
Sergey Biryukov 001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Gary Pendergast c008959e9e Coding Standards: Fix the minor `WordPress.WP.I18n` violations.
`WordPress.WP.I18n.MissingTranslatorsComment` is in progress in #44360.

See #45934.


Built from https://develop.svn.wordpress.org/trunk@44562


git-svn-id: http://core.svn.wordpress.org/trunk@44393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:04:49 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Andrew Nacin f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett d373d0982b Twenty Thirteen: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256.
Built from https://develop.svn.wordpress.org/trunk@25522


git-svn-id: http://core.svn.wordpress.org/trunk@25442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 19:34:10 +00:00
Lance Willett 693d4e0984 Twenty Thirteen: remove `html5` arguments now that `add_theme_support` call is in place. Props obenland, see r24421 and #23850.
git-svn-id: http://core.svn.wordpress.org/trunk@24423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 18:29:32 +00:00
Lance Willett 90ce925c46 Twenty Thirteen: remove mention of `twentythirteen_comment()` in PHPDoc, props zeo. Closes #24482.
git-svn-id: http://core.svn.wordpress.org/trunk@24401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-03 21:35:26 +00:00
Lance Willett 561ce28892 Twenty Thirteen: fix a few closing container comments. Props to DrewAPicture for the initial patch. Fixes #23802.
git-svn-id: http://core.svn.wordpress.org/trunk@23755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-19 19:25:56 +00:00
Lance Willett 29753503f5 Twenty Thirteen: remove custom comment callback in favor of core `comment_form()` defaults. Props obenland, closes #22005. See #20088.
git-svn-id: http://core.svn.wordpress.org/trunk@23696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-14 16:36:14 +00:00
Lance Willett 0c694a7500 Twenty Thirteen: use new HTML5 comment form argument, and adjust CSS selectors a bit. Closes #23702, see #15080.
git-svn-id: http://core.svn.wordpress.org/trunk@23690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 22:45:08 +00:00
Lance Willett 9e4ce0a952 Twenty Thirteen: remove searchform.php template once core search form accepts HTML5 argument. Props obenland, fixes #23701.
git-svn-id: http://core.svn.wordpress.org/trunk@23673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 17:44:27 +00:00
Mark Jaquith d1d3076d5a Introduce the Twenty Thirteen theme.
props matt, joen, obenland, lancewillett. see #23504

git-svn-id: http://core.svn.wordpress.org/trunk@23452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-18 23:08:56 +00:00