Commit Graph

66 Commits

Author SHA1 Message Date
davidbaumwald ab6c10948f Coding Standards: Removing unnecessary parentheses from `require_once` in `wp-admin/options-privacy.php`.
In [47198], parentheses were removed from `include` and `require` statements, as they are language constructs, not function calls.  However, [50161] introduced a new `require_once` instance in `wp-admin/options-privacy.php`.  This change removes the unnecessary parentheses.

See #53627.
Built from https://develop.svn.wordpress.org/trunk@50631


git-svn-id: http://core.svn.wordpress.org/trunk@50243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 15:36:08 +00:00
TimothyBlynJacobs 9bab39685a Privacy: Redesign the Privacy settings pages.
The Privacy settings pages now use the same design patterns as the Site Health screen. Additionally, each privacy policy guide is now contained in an accordion to make the page easier to navigate when multiple plugins are in use.

Props xkon, hedgefield, garrett-eclipse, hellofromTonya, paaljoachim, joedolson.
Fixes #49264.

Built from https://develop.svn.wordpress.org/trunk@50161


git-svn-id: http://core.svn.wordpress.org/trunk@49840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-02 20:14:03 +00:00
Sergey Biryukov 1651342d2b Privacy: Improve clarity of privacy error strings.
Primarily this adds "user privacy" to the strings for privacy requests, so they are more easily distinguished from other system actions within logs.

Props garrett-eclipse, carike, birgire.
Fixes #51351.
Built from https://develop.svn.wordpress.org/trunk@49090


git-svn-id: http://core.svn.wordpress.org/trunk@48852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-04 03:23:09 +00:00
Helen Hou-Sandí 447b526379 Privacy: Remove extraneous colon from settings screen.
Props vinita29, garrett-eclipse.
Fixes #50414.

Built from https://develop.svn.wordpress.org/trunk@48965


git-svn-id: http://core.svn.wordpress.org/trunk@48727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-09 19:43:08 +00:00
Sergey Biryukov a6949956d1 Administration: Capitalize `Trash` consistently in various messages and comments.
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.

Props garrett-eclipse, aandrewdixon, Presskopp.
Fixes #45317.
Built from https://develop.svn.wordpress.org/trunk@47233


git-svn-id: http://core.svn.wordpress.org/trunk@47033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 04:12:07 +00:00
Sergey Biryukov 47ed56f38f Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.
Built from https://develop.svn.wordpress.org/trunk@47198


git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 06:33:11 +00:00
Sergey Biryukov 60c651ad6a I18N: Add missing placeholders to some translators comments in `wp-admin`.
Props ramiy.
Fixes #49248.
Built from https://develop.svn.wordpress.org/trunk@47093


git-svn-id: http://core.svn.wordpress.org/trunk@46893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 15:43:04 +00:00
Sergey Biryukov e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation.
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Sergey Biryukov be6bbe4b5d Administration: Replace legacy `updated` message type in `add_settings_error()` calls with `success`.
See #44640.
Built from https://develop.svn.wordpress.org/trunk@45818


git-svn-id: http://core.svn.wordpress.org/trunk@45629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-16 00:39:55 +00:00
Sergey Biryukov 96b4570781 Privacy: Remove reinstated `wp-admin/options-privacy.php` from `$_old_files`.
Fix WPCS violations in [45448].

See #43895.
Built from https://develop.svn.wordpress.org/trunk@45453


git-svn-id: http://core.svn.wordpress.org/trunk@45264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 02:40:53 +00:00
Andrew Ozz 87acdab81d Privacy tools: Organize privacy functions into logical files and classes.
Props xkon, birgire, desrosj, garrett-eclipse, azaozz.
See #43895.
Built from https://develop.svn.wordpress.org/trunk@45448


git-svn-id: http://core.svn.wordpress.org/trunk@45259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 20:50:53 +00:00
Andrew Nacin aaf5d77d35 Remove options-privacy.php, as intended by [21838]. see #16416. see #22349.
git-svn-id: http://core.svn.wordpress.org/trunk@23050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:16:54 +00:00
Andrew Nacin 7fd32ab9fc Fold Privacy Settings into Reading Settings, moving blog_public (search engine/robots) to options-reading and removing options-privacy.
When blog_public only has two values (as judged by whether the blog_privacy_selector action is used), convert from radio buttons to a checkbox, and rename from 'Site Visibility' to a more specific 'Search Engine Visibility'.

The text and implementation may change a bit. see #16416.



git-svn-id: http://core.svn.wordpress.org/trunk@21838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-13 17:28:57 +00:00
nacin 4c566cebc6 Help text tweaks for the Settings screens. props jane. see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 00:52:31 +00:00
koopersmith ed2c35ad0a Update help text on settings pages. props Ipstenu, see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-29 16:58:58 +00:00
nacin bfb98c193e s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
ryan 3ad1f67958 Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 03:12:37 +00:00
nacin b5d445aa84 First pass on clarifying Settings > Privacy. props designsimply, markjaquith. see #16416.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-16 06:53:19 +00:00
westi 1443193079 Help Tab text updatates. Fixes #17312 prop dougwrites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-01 15:37:04 +00:00
nacin 9cb6e158fc Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 15:24:49 +00:00
nacin 1cd758dc89 Help text edits. props dougwrites, fixes #15346.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 06:37:03 +00:00
scribu 1cce7d7830 Introduce submit_button(). Props markjaquith for initial patch. See #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@15810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-14 19:58:06 +00:00
nacin 34c1fa6d0b target=blank for help. props jorbin, see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@15132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-03 21:00:39 +00:00
ryan 17129fb62e Cut 'em out, move 'em on, trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@15116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-02 20:04:07 +00:00
ryan 08334aed6e Entities cleanup for help. Props zeo. see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@15094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-01 17:44:38 +00:00
nacin 14b39ec9dc Settings help. props duck_, see #13467.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 19:05:59 +00:00
nacin 94d540f05d Change "Blog" to "Site" in the Settings panels.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-18 17:46:25 +00:00
ryan 22d0a6c641 Remove Sphere from search list. Props niallkennedy. fixes #10637
git-svn-id: http://svn.automattic.com/wordpress/trunk@11855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-20 20:58:44 +00:00
ryan a8890b9160 Add some CYA cap checks.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-01 21:12:17 +00:00
markjaquith 119b39cec2 deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-18 15:11:07 +00:00
markjaquith bdf8e8fb38 Use a semantic class name for text targeted to screen readers. props filosofo. fixes #9791
git-svn-id: http://svn.automattic.com/wordpress/trunk@11312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-12 22:40:56 +00:00
ryan 6f81ec436c Fix hiding off offscreen legends in Firefox. Props Denis-de-Bernardy. fixes #9783
git-svn-id: http://svn.automattic.com/wordpress/trunk@11283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-11 22:11:13 +00:00
markjaquith 6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 19:43:53 +00:00
ryan 808079dc32 Use invisible class for hiding labels and legends.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-04 21:28:58 +00:00
ryan 9ef2afc85b attr escaping. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-28 06:37:51 +00:00
ryan e89192b1a8 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-09 18:03:31 +00:00
ryan bd78058d90 Use settings_fields()
git-svn-id: http://svn.automattic.com/wordpress/trunk@9954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-28 21:57:58 +00:00
azaozz 7c68e6945a Screen icons
git-svn-id: http://svn.automattic.com/wordpress/trunk@9903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-26 13:51:25 +00:00
azaozz 17083f0ce8 Fix button styling inconsistency on settings pages, props sivel, fixes #7975
git-svn-id: http://svn.automattic.com/wordpress/trunk@9369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-27 20:41:05 +00:00
westi c1f7aeb0b9 More options pages updates.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-25 21:29:18 +00:00
markjaquith edc8069294 Do not put an overline for submit buttons at the top (TODO: figure out our style for options pages)
git-svn-id: http://svn.automattic.com/wordpress/trunk@9320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-24 10:45:58 +00:00
markjaquith 4d2d655490 Covering our XSS bases
git-svn-id: http://svn.automattic.com/wordpress/trunk@9233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-17 20:06:22 +00:00
markjaquith 61f911c42e Bring back the H2s. Rough draft.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-17 20:02:03 +00:00
matt aeffa88551 Bringing save button back to top of all option pages.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-14 01:18:52 +00:00
ryan ea0ce44d87 h2 removal per wireframes. Props Viper007Bond. see #7552
git-svn-id: http://svn.automattic.com/wordpress/trunk@9032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-29 22:06:23 +00:00
ryan 54049c5f41 add_settings_section() and add_settings_field(). see #7682
git-svn-id: http://svn.automattic.com/wordpress/trunk@8855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-09 22:31:22 +00:00
ryan bcc617c59c Add settings registration and whitelisting. Props donncha. see #7277
git-svn-id: http://svn.automattic.com/wordpress/trunk@8802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-04 01:11:18 +00:00
ryan 5aa7cbcf37 Move Setting menu to top-level. see #7552
git-svn-id: http://svn.automattic.com/wordpress/trunk@8705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-21 23:18:51 +00:00
ryan d3b414932c Collapse crazyhorse to trunk. Incoming! see #7552
git-svn-id: http://svn.automattic.com/wordpress/trunk@8691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-20 21:42:31 +00:00
westi 7f894ae416 phpdoc for wp-admin. See #7496 props santosj.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-14 06:30:38 +00:00