Drew Jaynes
8f6188ae53
Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Two arguments in `_walk_bookmarks()`
* A code snippet in the class header for `WP_Roles`
* A code snippet in the class header for `WP_HTTP_Proxy`
* Inline code fixes in the summary and a parameter description for `WP_oEmbed::discover()`
* An argument description in `_WP_Editors::parse_settings()`
* Inline code fixes in the summary and a parameter description the `embed_oembed_discover` hook.
Props rarst.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30536
git-svn-id: http://core.svn.wordpress.org/trunk@30525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 04:42:22 +00:00
Drew Jaynes
6d0cdd7148
Remove HTML `<head>` tags from DocBlock summaries in wp-admin/admin-header.php.
...
Also better-specify the `$hook_suffix` value in the `admin_head-$hook_suffix` hook docs per hook documentation precedent.
Props rarst for the initial patch.
See #30473
Built from https://develop.svn.wordpress.org/trunk@30535
git-svn-id: http://core.svn.wordpress.org/trunk@30524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 04:27:23 +00:00
Gary Pendergast
12684e0ec8
`json_encode()` returns different results for non UTF-8 strings in PHP 5.5+, versus earlier versions of PHP.
...
This fixes the unit tests that fail in earlier versions, see #30471 for fixing this globally in `wp_json_encode()`.
Built from https://develop.svn.wordpress.org/trunk@30534
git-svn-id: http://core.svn.wordpress.org/trunk@30523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 01:56:24 +00:00
Gary Pendergast
18ae2c0b44
Split the tests for `wp_json_encode()` into smaller chunks (let's all them "units"). Skip a couple of these tests when running on older versions of PHP that don't support the tested functionality.
...
See #28786 .
Built from https://develop.svn.wordpress.org/trunk@30533
git-svn-id: http://core.svn.wordpress.org/trunk@30522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 23:52:23 +00:00
Drew Jaynes
0fb8811fb6
Improve return description for `get_file_data()` documentation.
...
Also convert an incorrect use of `@see` to `@link`.
Props 5um17 for the initial patch.
Fixes #30466 .
Built from https://develop.svn.wordpress.org/trunk@30532
git-svn-id: http://core.svn.wordpress.org/trunk@30521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 17:57:22 +00:00
Andrew Ozz
e8a4452f05
Color Schemes: fix the pointer UP arrow color, fixes #30460 .
...
Built from https://develop.svn.wordpress.org/trunk@30531
git-svn-id: http://core.svn.wordpress.org/trunk@30520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 01:26:23 +00:00
Boone Gorges
58256224fe
Remove failing `test_network_limit()` XML-RPC test.
...
Test added as a patch on #21292 .
Props MikeHansenMe.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30530
git-svn-id: http://core.svn.wordpress.org/trunk@30519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 01:23:22 +00:00
Boone Gorges
20302cbd82
Better rewrite rule flushing in `test_permalink_without_title()`.
...
This ensures that the test is not polluted by permalink structure changes in
earlier tests.
Built from https://develop.svn.wordpress.org/trunk@30529
git-svn-id: http://core.svn.wordpress.org/trunk@30518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 01:20:24 +00:00
Boone Gorges
144d7ed48c
Ensure that `wpdb_exposed_methods_for_testing` is available to all tests.
...
It should be defined in a common library file so that all tests have access to
it, even when run in isolation.
See [30345], #21212 .
Built from https://develop.svn.wordpress.org/trunk@30528
git-svn-id: http://core.svn.wordpress.org/trunk@30517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 00:47:22 +00:00
Boone Gorges
de1f2d6ad7
Ensure `sanitize_user()` expected test values are lowercase on multisite.
...
[30524] neglected to account for the fact that multisite forces user logins to
lowercase.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30527
git-svn-id: http://core.svn.wordpress.org/trunk@30516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 21:30:24 +00:00
Boone Gorges
21771656ea
Stop checking Trac to skip tests against open tickets.
...
In general, skipped tests should live only in patches, which are committed at
the same time that the corresponding bug is fixed. In cases where it's
necessary to skip a test, use `markTestSkipped()` to declare this fact
explicitly.
We continue to check Trac when using `WP_UnitTestCase` to run non-core tests.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30526
git-svn-id: http://core.svn.wordpress.org/trunk@30515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 21:11:24 +00:00
Boone Gorges
a18e2f68c7
Repair the `seems_utf8()` tests that use Big5 encoding.
...
* Provide sample data that is actually encoded in Big5.
* Do some actual assertions against that data.
Props akumria.
Fixes #30455 .
Built from https://develop.svn.wordpress.org/trunk@30525
git-svn-id: http://core.svn.wordpress.org/trunk@30514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:57:24 +00:00
Boone Gorges
503defbf43
Remove failing test related to the 'offset' param of `WP_Query`.
...
This test has been added as a patch to #18897 .
Props MikeHansenMe.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30524
git-svn-id: http://core.svn.wordpress.org/trunk@30513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:46:22 +00:00
Boone Gorges
6a5c146953
Remove failing test related to `wp_list_pages()`.
...
The test has been added as a patch to #27326 .
Props MikeHansenMe.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30523
git-svn-id: http://core.svn.wordpress.org/trunk@30512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:44:22 +00:00
Boone Gorges
181fec554f
Remove failing test related to `wp_unique_post_slug()`.
...
The test has been added as a patch to #18962 .
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30522
git-svn-id: http://core.svn.wordpress.org/trunk@30511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:42:22 +00:00
Boone Gorges
7481a15ad8
Remove failing `is_textdomain_loaded()` test.
...
The removed test has been added as a patch to the original ticket, #21319 .
Props MikeHansenMe.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30521
git-svn-id: http://core.svn.wordpress.org/trunk@30510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:37:22 +00:00
Boone Gorges
4c40127397
Remove failing assertions from `is_serialized()` tests.
...
They have been moved to new test methods, which have been attached as a patch
to the ticket #9930 .
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30520
git-svn-id: http://core.svn.wordpress.org/trunk@30509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:35:22 +00:00
Boone Gorges
4f47412a03
Remove failing test in the `hooks` group.
...
The removed test has been added as a patch to #21169 .
Props MikeHansenMe.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30519
git-svn-id: http://core.svn.wordpress.org/trunk@30508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:26:22 +00:00
Boone Gorges
f1b5a879c5
Remove skipped tests for `WP_Export_Query`.
...
These tests have been added as a patch to the ticket where the new
functionality was originally proposed, #22435 .
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30518
git-svn-id: http://core.svn.wordpress.org/trunk@30507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:23:22 +00:00
Boone Gorges
550f8ad9e8
Remove skipped tests for unimplemented JS plural functions.
...
The tests have been added as a patch for the original ticket, #22229 .
Props MikeHansenMe.
See #22229 .
Built from https://develop.svn.wordpress.org/trunk@30517
git-svn-id: http://core.svn.wordpress.org/trunk@30506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:12:23 +00:00
Boone Gorges
3042b7afd5
Remove failing test for unimplemented `wp_mail()` enhancement.
...
The removed test has been added as a patch to the original ticket, #15448 .
Props MikeHansenMe.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30516
git-svn-id: http://core.svn.wordpress.org/trunk@30505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 20:06:25 +00:00
Boone Gorges
025d1b388b
Improvements to encoded character formatting tests.
...
In `sanitize_title_with_dashes()` and `sanitize_user()` tests, we break large
test methods into smaller ones in order to isolate those that actually describe
the bug being reported in ticket #10823 . The unit tests that are continuing to
fail have been attached as a patch to that ticket.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30515
git-svn-id: http://core.svn.wordpress.org/trunk@30504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 19:54:21 +00:00
Boone Gorges
3422675eda
Remove failing tests related to square brackets being stripped in URL sanitizers.
...
These tests have been added as a patch to their original ticket, #16859 .
Props MikeHansenMe.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30514
git-svn-id: http://core.svn.wordpress.org/trunk@30503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 15:40:22 +00:00
Boone Gorges
c4d9abb74f
Remove failing tests related to `WP_User::__unset()`.
...
These tests have been added as a patch to their original ticket, #20043 .
Props MikeHansenMe.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30513
git-svn-id: http://core.svn.wordpress.org/trunk@30502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 15:36:22 +00:00
Boone Gorges
cb4f0c8b8e
Declare user_email when setting up fixtures for `count_user_posts()` tests.
...
Because `setUpBeforeClass()` is called statically and creates its own factory
object, the iterator logic from previous tests is not carried over to these
fixtures, and we risk the possibility of user_email clashes when the tests are
run in certain limited configurations.
Built from https://develop.svn.wordpress.org/trunk@30512
git-svn-id: http://core.svn.wordpress.org/trunk@30501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 15:05:22 +00:00
Boone Gorges
cc10fa74a5
Improve performance of post revision order test.
...
`test_revision_order()` was written ([28541], #26042 ) to ensure that revision
order was properly preserved in two different cases: (1) where the post_date
varied (in which case the revisions would be sorted by post_date DESC) and
(2) where the post_date was the same (in which case sorting would fall back on
ID DESC). In an attempt to ensure that both of these scenarios arose in the
context of a single test, 100 posts were created. We can make the process far
more efficient by manually creating the revisions with the post_dates
explicitly declared, and splitting the two different cases into two separate
test methods.
This test was previously the single worst offender in the entire suite, taking
upwards of 15 seconds to run. All that most maddens and torments; all that stirs
up the lees of things; all truth with malice in it; all that cracks the sinews
and cakes the brain; all the subtle demonisms of life and thought; all evil, to
crazy Boone, were visibly personified, and made practically assailable in
`test_revision_order()`.
See #30017 .
Built from https://develop.svn.wordpress.org/trunk@30511
git-svn-id: http://core.svn.wordpress.org/trunk@30500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 14:18:23 +00:00
Boone Gorges
9f40944e49
Remove some failing unit tests from the `post` group.
...
These tests have been added as a patch to ticket #19373 .
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30510
git-svn-id: http://core.svn.wordpress.org/trunk@30499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 12:04:25 +00:00
Andrew Ozz
d3604f485d
TinyMCE: set the image toolbar's z-index to be the same as the other TinyMCE panels, or it is under the editor when in fullscreen mode. See #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30509
git-svn-id: http://core.svn.wordpress.org/trunk@30498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-22 02:43:24 +00:00
John Blackbourn
78367f22d5
Abstract the theme browser route paths into attributes so they can be easily overridden.
...
Fixes #30116
Props matveb
Built from https://develop.svn.wordpress.org/trunk@30508
git-svn-id: http://core.svn.wordpress.org/trunk@30497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 17:30:22 +00:00
John Blackbourn
b66c58f76a
Update the inline docs for `wp_die()` to reflect parameter changes made in r30355
...
See #10551
Built from https://develop.svn.wordpress.org/trunk@30507
git-svn-id: http://core.svn.wordpress.org/trunk@30496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 17:08:23 +00:00
John Blackbourn
53a9e3b420
Add support for `WP_Error` objects passed to `wp_send_json_error()`. The error object gets output as an array of error codes and messages, rather than as an empty object.
...
Fixes #28978
Props paulschreiber
Built from https://develop.svn.wordpress.org/trunk@30506
git-svn-id: http://core.svn.wordpress.org/trunk@30495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:56:23 +00:00
Helen Hou-Sandí
97b412af37
Admin notices: Add more variety and make more generically usable.
...
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.
Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.
props avryl, melchoyce.
fixes #27418 .
Built from https://develop.svn.wordpress.org/trunk@30505
git-svn-id: http://core.svn.wordpress.org/trunk@30494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:41:25 +00:00
Helen Hou-Sandí
c83f96ec61
Sessions UI: Ensure screen readers provide feedback on action taken.
...
Also fixes some invalid HTML that occurs on DOM changes.
props joedolson.
fixes #30364 .
Built from https://develop.svn.wordpress.org/trunk@30504
git-svn-id: http://core.svn.wordpress.org/trunk@30493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:25:23 +00:00
Helen Hou-Sandí
541e6d31af
oEmbed: Add support for the Vine endpoint.
...
props niallkennedy.
fixes #30426 .
Built from https://develop.svn.wordpress.org/trunk@30503
git-svn-id: http://core.svn.wordpress.org/trunk@30492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:04:23 +00:00
Drew Jaynes
b0db6e6deb
Convert `<title>` to "title tag" in the DocBlock summary for the `admin_title` hook.
...
Fixes #30437 .
Built from https://develop.svn.wordpress.org/trunk@30502
git-svn-id: http://core.svn.wordpress.org/trunk@30491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 07:12:23 +00:00
Sergey Biryukov
8f2842a07e
Replace invalid use of ltrim() in attachment_url_to_postid() with substr().
...
props bradyvercher.
fixes #30346 .
Built from https://develop.svn.wordpress.org/trunk@30501
git-svn-id: http://core.svn.wordpress.org/trunk@30490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 06:35:22 +00:00
Sergey Biryukov
aad05ece16
Set min-height for menu item title. Add a fallback for empty-titled items.
...
props philiparthurmoore.
fixes #30283 .
Built from https://develop.svn.wordpress.org/trunk@30500
git-svn-id: http://core.svn.wordpress.org/trunk@30489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 05:57:22 +00:00
John Blackbourn
2aabde8f74
Remove whitespace accidentally introduced in r30498
...
See #30335
Built from https://develop.svn.wordpress.org/trunk@30499
git-svn-id: http://core.svn.wordpress.org/trunk@30488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 04:01:22 +00:00
John Blackbourn
196e069c5b
`split_shared_term` is an action, not a filter.
...
See #30335
Built from https://develop.svn.wordpress.org/trunk@30498
git-svn-id: http://core.svn.wordpress.org/trunk@30487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 03:51:21 +00:00
Drew Jaynes
a6fc2d610b
Minor syntactical adjustments to the inline documentation for the `revision_text_diff_options` hook.
...
Converts backticked-inline-code to inline `@see` tags (for the full benefit of Code Reference automagical behavior).
See [30396]. See #24908 .
Built from https://develop.svn.wordpress.org/trunk@30497
git-svn-id: http://core.svn.wordpress.org/trunk@30486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 03:50:24 +00:00
Drew Jaynes
2fda44cb77
Add an entry to the changelog for `wp_make_link_relative()` noting that intentional support was added for relative URLs.
...
See #30373 .
Built from https://develop.svn.wordpress.org/trunk@30496
git-svn-id: http://core.svn.wordpress.org/trunk@30485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 03:44:23 +00:00
John Blackbourn
3ace1fac81
Only output an optgroup for installed languages in `wp_dropdown_languages()` if translations are available.
...
See #30335
Built from https://develop.svn.wordpress.org/trunk@30495
git-svn-id: http://core.svn.wordpress.org/trunk@30484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 03:20:22 +00:00
Boone Gorges
57e358da63
Improve cleanup of cached term_ids after shared terms are split.
...
* If the split term ID is stored as 'default_category', 'default_link_category', or 'default_email_category', update it to the new ID.
* If the split term ID is associated with a nav menu item, update that piece of postmeta to the new ID.
Props mboynes.
See #30335 .
Built from https://develop.svn.wordpress.org/trunk@30494
git-svn-id: http://core.svn.wordpress.org/trunk@30483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 03:17:22 +00:00
Boone Gorges
14e6c301ea
Pass the taxonomy of the split tt_id to the 'split_shared_term' filter.
...
Props mboynes.
See #30335 .
Built from https://develop.svn.wordpress.org/trunk@30493
git-svn-id: http://core.svn.wordpress.org/trunk@30482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 03:14:23 +00:00
Boone Gorges
6f9eaf5df5
Store data about old and new term IDs when shared terms are split.
...
Props mboynes.
See #30335 .
Built from https://develop.svn.wordpress.org/trunk@30492
git-svn-id: http://core.svn.wordpress.org/trunk@30481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 03:13:22 +00:00
Dion Hulse
330ab9d484
Update the bundled root CA's used for outgoing HTTPS requests.
...
Fixes #30434
Built from https://develop.svn.wordpress.org/trunk@30491
git-svn-id: http://core.svn.wordpress.org/trunk@30480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 03:03:22 +00:00
Andrew Ozz
c22be8dbe8
TinyMCE: change the default font size from 100% to 16px to fix some back-compat issues, fixes #30038 .
...
Built from https://develop.svn.wordpress.org/trunk@30490
git-svn-id: http://core.svn.wordpress.org/trunk@30479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 22:23:24 +00:00
Drew Jaynes
fd1f5bb3ad
Update the DocBlock changelogs for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks following [30358], where `$depth` parameters were added.
...
Props kpdesign.
See [30358]. Fixes #19064 .
Built from https://develop.svn.wordpress.org/trunk@30485
git-svn-id: http://core.svn.wordpress.org/trunk@30474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 18:26:23 +00:00
Andrew Nacin
f9408af336
4.1-beta2-30484
...
Built from https://develop.svn.wordpress.org/trunk@30484
git-svn-id: http://core.svn.wordpress.org/trunk@30473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 17:45:25 +00:00
Helen Hou-Sandí
6225c63cf1
Media a11y: Don't set role=checkbox for the attachment details view.
...
Some unnecessary attributes were inherited from the attachment view, which created difficulties with screen readers.
fixes #30390 .
Built from https://develop.svn.wordpress.org/trunk@30483
git-svn-id: http://core.svn.wordpress.org/trunk@30471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 17:15:23 +00:00