53c8c68365
Administration: Ensure collapse menu is usable with a keyboard
...
Currently, the "Collapse menu" item is not focusable and keyboard users can't collapse/expand the admin menu. This aims to fix it so that screen readers no longer announce it as a clickable but it remains unfocusable and thus unusable. So it's now a button.
Quoting joedolson at WordCamp Chicago 2014:
"If it's supposed to act like a button, it should be a button."
Also includes a grunt:precommit run that picked up some postcss changes to src/wp-includes/css/customize-preview.css
Fixes #29958 .
Props ajercia, ipm-frommen for an iterative patch, valendesigns for an iterative patch, GaryJ for feedback, joedolson for feedback, helen for feedback
Built from https://develop.svn.wordpress.org/trunk@39141
git-svn-id: http://core.svn.wordpress.org/trunk@39081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-04 17:18:57 +00:00
f4c3b8352e
Customize: Use `button` with `svg` as click target instead of `:before` content, improving clickability of edit shortcuts in Firefox.
...
Props sirbrillig, celloexpressions, delawski.
See #38532 .
Built from https://develop.svn.wordpress.org/trunk@39136
git-svn-id: http://core.svn.wordpress.org/trunk@39076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-04 17:16:26 +00:00
726cd04bac
Customize: Let edit shortcuts be persistently visible when controls pane is expanded, hidden when collapsed, and always visible in mobile preview. Remove initial flash of edit shortcuts.
...
Props westonruter, sirbrillig.
Fixes #27403 .
Built from https://develop.svn.wordpress.org/trunk@39131
git-svn-id: http://core.svn.wordpress.org/trunk@39071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-04 17:13:57 +00:00
5f4497f0af
Docs: Fix multiple trivial typos throughout a variety of core files.
...
Props ottok.
Fixes #38489 .
Built from https://develop.svn.wordpress.org/trunk@39051
git-svn-id: http://core.svn.wordpress.org/trunk@38993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-31 06:28:32 +00:00
7b0abd1cea
Accessibility: Hide the Toolbar sub-menu icons from assistive technologies.
...
CSS generated content is going to be rendered for speech output more and more in
the next future. When it's not intended to be available for speech output, for
example with font icons, then special care should be used to hide it from
assistive technologies. At the moment, the only reliable way to do this is making
use of a wrapper element and set `aria-hidden="true"` on it.
Fixes #37513 .
Built from https://develop.svn.wordpress.org/trunk@38984
git-svn-id: http://core.svn.wordpress.org/trunk@38927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-27 20:53:30 +00:00
022ee8ec36
Customize: Remove unnecessary code for edit shortcuts which is no longer required due to moving buttons inside of partial placement containers.
...
Props sirbrillig.
Amends [38967].
See #27403 .
Built from https://develop.svn.wordpress.org/trunk@38972
git-svn-id: http://core.svn.wordpress.org/trunk@38915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-26 22:38:33 +00:00
71afe657b6
Customize: Add edit shortcuts in customizer preview to visually expose editable elements and focus on the corresponding controls when clicked.
...
* Edit shortcuts show initially for a moment and then fade away so as to not get in the way of the preview.
* Visibility of edit shortcuts is toggled by clicking/touching anywhere inert in the document.
* Implements UI for mobile and touch devices which do not support shift-click.
* Adds `editShortcutVisibility` state.
* Adds new methods to `wp.customize.selectiveRefresh.Partial` for managing edit shortcuts.
Incorporates aspects of the Customize Direct Manipulation feature plugin.
Props sirbrillig, mattwiebe, celloexpressions, melchoyce, westonruter, afercia.
Fixes #27403 .
Built from https://develop.svn.wordpress.org/trunk@38967
git-svn-id: http://core.svn.wordpress.org/trunk@38910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-26 20:03:32 +00:00
5dda286548
TinyMCE: adjust the shortcuts position and font size in the Formats drop-down to better match the shortcuts in the buttons tooltips.
...
See #38063 .
Built from https://develop.svn.wordpress.org/trunk@38937
git-svn-id: http://core.svn.wordpress.org/trunk@38880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-26 00:37:30 +00:00
913926c1bd
TinyMCE: make keyboard shortcuts more discoverable by adding them to the buttons tooltips and in the Formats drop-down.
...
Props mor10, azaozz.
Fixes #38063 .
Built from https://develop.svn.wordpress.org/trunk@38897
git-svn-id: http://core.svn.wordpress.org/trunk@38840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-25 01:40:31 +00:00
c388eeca8d
TinyMCE: restore the monospace font in textareas in the TinyMCE UI. Make it same as in the Text editor.
...
Fixes #38125 .
Built from https://develop.svn.wordpress.org/trunk@38801
git-svn-id: http://core.svn.wordpress.org/trunk@38744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-16 22:51:28 +00:00
7627255d7e
Toolbar: Update links to the about page if current user can't access the dashboard of the current site.
...
Add missing focus styling for menu items with an icon.
Fixes #37949 .
Built from https://develop.svn.wordpress.org/trunk@38660
git-svn-id: http://core.svn.wordpress.org/trunk@38603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-27 19:01:29 +00:00
93ad7eab80
Administration: Use #fff instead of `white`
...
Cleans up a few places where the CSS coding standards were not being followed.
Fixes #37576 .
Props Presskopp, johnpgreen, netweb
Built from https://develop.svn.wordpress.org/trunk@38501
git-svn-id: http://core.svn.wordpress.org/trunk@38442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 18:14:31 +00:00
15edc78f6f
TinyMCE: fix toolbars alignment in RTL.
...
Fixes #37760 for trunk.
Built from https://develop.svn.wordpress.org/trunk@38349
git-svn-id: http://core.svn.wordpress.org/trunk@38290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-25 01:20:30 +00:00
6d28c85bc7
System fonts: Don't quote single-word font names, per our coding standards.
...
props ocean90, netweb.
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@38152
git-svn-id: http://core.svn.wordpress.org/trunk@38093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-26 16:39:30 +00:00
f160f2afd1
Toolbar: Allow 0 as a value for the `tabindex` property of a menu item.
...
To enhance accessibility for items without a link you can now define `tabindex="0"`, which makes descendant dropdowns accessible.
Props joedolson, afercia, ocean90.
Fixes #32495 .
Built from https://develop.svn.wordpress.org/trunk@38035
git-svn-id: http://core.svn.wordpress.org/trunk@37976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-12 11:18:30 +00:00
07cef1ce62
Editor, link checker:
...
- Add white outline for contrast on darker backgrounds.
- Change red colour in toolbar.
Props iseulde. Props rockwell15 for the initial patch.
See #36638 .
Built from https://develop.svn.wordpress.org/trunk@37751
git-svn-id: http://core.svn.wordpress.org/trunk@37716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-19 13:01:28 +00:00
accf240d37
Editor: after inserting a link detect if the URL is broken, first run.
...
Props iseulde, azaozz.
See #36638 .
Built from https://develop.svn.wordpress.org/trunk@37741
git-svn-id: http://core.svn.wordpress.org/trunk@37706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-17 20:41:28 +00:00
8776694a33
Use numeric font weights instead of keywords.
...
When Open Sans was in use, the `300`, `400`, and `600` weights were loaded. `400` is the equivalent of `normal`; however, `bold` is equivalent to `700`, not `600`. With the move to system fonts, we need to be specific rather than relying on the lack of a `700` weight. Not all system fonts include a `600` weight; in those instances, they will use the `bold`/`700` weight.
The WordPress CSS Coding Standards have been updated accordingly.
props coderste.
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37740
git-svn-id: http://core.svn.wordpress.org/trunk@37705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-17 18:37:28 +00:00
848501711a
System font: The stack does not work with the `font` shorthand property.
...
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37442
git-svn-id: http://core.svn.wordpress.org/trunk@37410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 01:45:27 +00:00
b1804afeaf
Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
...
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.
Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.
Props ocean90.
Fixes #36835 .
Built from https://develop.svn.wordpress.org/trunk@37431
git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 18:41:31 +00:00
a726a9f51f
Admin font: Remove a redundant `sans-serif` declaration.
...
props samantha-miller.
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37419
git-svn-id: http://core.svn.wordpress.org/trunk@37385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 02:14:28 +00:00
ced66ed4e7
Multisite: Use the admin-multisite Dashicon for sites
...
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.
Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.
Props Ipstenu, ocean90.
Fixes #36754 .
Built from https://develop.svn.wordpress.org/trunk@37365
git-svn-id: http://core.svn.wordpress.org/trunk@37331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 17:13:26 +00:00
db3d5a6bea
Revert [37362], which incorrectly changed Dashicons CSS
...
`dashicons.css` is an external-ish library and the change there is incorrect.
See #36754 .
Built from https://develop.svn.wordpress.org/trunk@37364
git-svn-id: http://core.svn.wordpress.org/trunk@37330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:29:27 +00:00
610215ceb1
Revive `grunt-rtlcss`, which does not appear to enjoy syntax errors.
...
props netweb.
see #36753 , #29792 .
Built from https://develop.svn.wordpress.org/trunk@37363
git-svn-id: http://core.svn.wordpress.org/trunk@37329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:22:27 +00:00
172af4e0ce
Multisite: Use the admin-multisite Dashicon in the admin menu and bar
...
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.
Props Ipstenu.
Fixes #36754 .
Built from https://develop.svn.wordpress.org/trunk@37362
git-svn-id: http://core.svn.wordpress.org/trunk@37328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 04:29:26 +00:00
a800cf654b
Drop Open Sans in the admin in favor of system fonts.
...
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.
At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.
There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.
The style remains registered, as it is almost certainly in use by themes and plugins.
props mattmiklic.
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37361
git-svn-id: http://core.svn.wordpress.org/trunk@37327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 22:07:37 +00:00
12599ea170
TinyMCE, inline link: Make styles for the autocomplete results available on front end.
...
Also, replace the generic `.alignright` class with a more specific class to avoid styling issues with themes which have padding/margin attached to `.alignright`.
Props azaozz, imath.
Fixes #36461 .
Built from https://develop.svn.wordpress.org/trunk@37174
git-svn-id: http://core.svn.wordpress.org/trunk@37141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-11 15:12:29 +00:00
2618ccf64d
Editor, wpLink:
...
- Restore the bottom half of the modal.
- Make it always expanded and remove the toggle. It is used as advanced link options now, no need to have simple mode.
Props iseulde, adamsilverstein, azaozz.
Fixes #36359 .
Built from https://develop.svn.wordpress.org/trunk@37154
git-svn-id: http://core.svn.wordpress.org/trunk@37120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-01 21:13:29 +00:00
f8a66d7bf2
Update TinyMCE and jQuery UI button styles
...
Part props liljimmi.
Fixes #35571 .
Built from https://develop.svn.wordpress.org/trunk@37076
git-svn-id: http://core.svn.wordpress.org/trunk@37043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-24 00:57:28 +00:00
02523f91c2
Dashicons: Update to the latest files.
...
Updates .dashicons-googleplus (f462) and adds three new icons, .dashicons-move (f545), .dashicons-laptop (f547), and .dashicons-paperclip (f546).
Props liljimmi, melchoyce, empireoflight, aargh-a-knot.
See #34221 .
Built from https://develop.svn.wordpress.org/trunk@37036
git-svn-id: http://core.svn.wordpress.org/trunk@37003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-18 20:26:26 +00:00
90f70fab53
TinyMCE, inline link:
...
- Add back the bottom box-shadow on the Apply button.
- Shrink `.mce-btn.mce-primary` to compensate for the bottom box-shadow.
- Tighten up/reduce the margins between the buttons.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@37004
git-svn-id: http://core.svn.wordpress.org/trunk@36971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-16 04:29:27 +00:00
571cf91329
TinyMCE, inline link:
...
- Remove bottom box-shadow from the Apply button so it matches the rest.
- Change the tooltip for the cogwheel button to Link options.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@37001
git-svn-id: http://core.svn.wordpress.org/trunk@36968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-16 02:04:27 +00:00
b9a3602070
wpLink: fix accessibility issues:
...
- Add role=dialog and an aria-labelledby attribute to the modal container.
- Change the modal title to h1.
- Remove one ` ` that gets read out as `blank` by screen readers.
- Replace the Cancel link with a button.
- Clean up unused CSS.
Props afercia.
Fixes #30468 .
Built from https://develop.svn.wordpress.org/trunk@36991
git-svn-id: http://core.svn.wordpress.org/trunk@36958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 20:55:26 +00:00
13c885bdce
TinyMCE, inline link:
...
- Remove unused user setting for wpLink.
- Remove redundant text and variable from wp_link_dialog().
Props afercia, azaozz.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@36985
git-svn-id: http://core.svn.wordpress.org/trunk@36952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 01:39:26 +00:00
a71f14b8d9
Accessibility: Reduce the WordPress shades of grey, Episode 3.
...
Also, removes some no more used CSS.
See #35783 .
Built from https://develop.svn.wordpress.org/trunk@36904
git-svn-id: http://core.svn.wordpress.org/trunk@36872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 19:51:26 +00:00
d27ae61355
Customize: Remove selective refresh error message from appearing inline within the preview.
...
The error message will still be available in the developer console.
Removes part of [36586].
See #27355 .
Fixes #36164 .
Built from https://develop.svn.wordpress.org/trunk@36890
git-svn-id: http://core.svn.wordpress.org/trunk@36857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 04:37:28 +00:00
b5cc1c7dfa
TinyMCE:
...
- Fix the icon for the native dialogs close button.
- Highlight the button on :focus.
See #36035 .
Built from https://develop.svn.wordpress.org/trunk@36857
git-svn-id: http://core.svn.wordpress.org/trunk@36824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 22:01:27 +00:00
bd161f342d
TinyMCE: fix the close button position in the paste in text mode warning.
...
See #36035 .
Built from https://develop.svn.wordpress.org/trunk@36799
git-svn-id: http://core.svn.wordpress.org/trunk@36766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-02 01:15:27 +00:00
d0b708fcb9
TinyMCE textpattern:
...
- Add description of the new patterns to the Shortcuts help modal.
- Fix the layout a bit and make the patterns in two columns.
- Disable the `textpatterns` plugin in IE < 9.
See #33300 .
Built from https://develop.svn.wordpress.org/trunk@36761
git-svn-id: http://core.svn.wordpress.org/trunk@36728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-28 19:00:27 +00:00
771cfe22ba
TinyMCE, inline link dialog:
...
- Remove the bottom half of the (old) modal and add autocomplete on the URL field.
- Disable the inline edit dialog in old IE (7, 8 and 9). Use only the modal there.
- Fix in IE10 and 11.
- Fix (most?) remaining edge cases.
- Fix focusing the inline dialog, the modal and the editor.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@36677
git-svn-id: http://core.svn.wordpress.org/trunk@36644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-24 06:20:26 +00:00
fcb3e5ec2f
Accessibility: Improve the color contrast ratio for the input placeholders.
...
Also, cleans up a bit the CSS removing rules for elements that don't use
placeholders any more.
Fixes #35777 .
Built from https://develop.svn.wordpress.org/trunk@36619
git-svn-id: http://core.svn.wordpress.org/trunk@36586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 23:29:26 +00:00
30866ceb5d
Accessibility: Improve color contrast updating any `#999` gray used for text or icons to a darker gray.
...
Fixes #35660 .
Built from https://develop.svn.wordpress.org/trunk@36587
git-svn-id: http://core.svn.wordpress.org/trunk@36554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:44:27 +00:00
6b775d4afe
Customize: Add selective refresh framework with implementation for widgets and re-implementation for nav menus.
...
See https://make.wordpress.org/core/2016/02/16/selective-refresh-in-the-customizer/ .
Props westonruter, valendesigns, DrewAPicture, ocean90.
Fixes #27355 .
Built from https://develop.svn.wordpress.org/trunk@36586
git-svn-id: http://core.svn.wordpress.org/trunk@36553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:41:28 +00:00
4ac63be963
Accessibility: improve the color contrast ratio for the TinyMCE button icons.
...
Also, tries to use the new grays from the Design Handbook wherever applicable.
Props michaelarestad, afercia.
Fixes #35604 .
Built from https://develop.svn.wordpress.org/trunk@36528
git-svn-id: http://core.svn.wordpress.org/trunk@36495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-15 21:11:28 +00:00
af25083b6f
Accessibility: Improve the color contrast ratio replacing the residual occurrences of the `#777` gray.
...
Uses the existing `#72777c` on white backgrounds and the new `#555d66` "dark medium gray" on darker backgrounds.
Fixes #35605 .
Built from https://develop.svn.wordpress.org/trunk@36396
git-svn-id: http://core.svn.wordpress.org/trunk@36363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-26 00:04:26 +00:00
3663a5bca5
TinyMCE: add inline link dialog
...
First run.
Links the advanced button to the "old" dialog for now.
See #33301 .
Built from https://develop.svn.wordpress.org/trunk@36384
git-svn-id: http://core.svn.wordpress.org/trunk@36351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-23 00:08:26 +00:00
ae1575bd80
Media: make the Image Editor usable with a keyboard.
...
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.
Fixes #28864 .
Built from https://develop.svn.wordpress.org/trunk@36223
git-svn-id: http://core.svn.wordpress.org/trunk@36190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 19:13:26 +00:00
1b3ee7098a
Media: set the image editor spinner on the smallest possible area.
...
When using spinners as background images, the re-painted area should be the smallest
possible one. See similar performance issue in #31196 , #33311 , #33322 , and #34951 .
Fixes #35296 .
Built from https://develop.svn.wordpress.org/trunk@36162
git-svn-id: http://core.svn.wordpress.org/trunk@36128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 16:49:28 +00:00
d3eea5477c
Media: Fix icons for HiDPI displays on the media modal after [32952].
...
Props vtieu.
Fixes #35200 .
Built from https://develop.svn.wordpress.org/trunk@36122
git-svn-id: http://core.svn.wordpress.org/trunk@36088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 18:32:29 +00:00
f7f14d94f3
Accessibility: Improvements for the Authentication Check modal dialog "Close X".
...
Removes the title attribute and uses a `<button>` element instead of a `<div>`.
Also simplifies the CSS and takes care of the hover/focus style.
Fixes #35142 .
Built from https://develop.svn.wordpress.org/trunk@36014
git-svn-id: http://core.svn.wordpress.org/trunk@35979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:51:26 +00:00
Aaron Jorbin
Weston Ruter
Drew Jaynes
Andrea Fercia
Andrew Ozz
Dominik Schilling
Helen Hou-Sandí
Jeremy Felt
Ella Iseulde Van Dorpe
Mel Choyce