WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
44,979 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

376 Commits

Author SHA1 Message Date
Gary Pendergast aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Gary Pendergast a779284c00 General: Reformat inline `if ()` statements inside HTML tags. 
This pattern occurs a handful of times across the codebase:

`<div class="foo<?php if ( $bar ) { echo ' baz'; } ?>">`

Unfortunately, it doesn't really play nicely with `phpcbf`, so all instances need to be removed in preperation for auto code formatting.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42217


git-svn-id: http://core.svn.wordpress.org/trunk@42046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-23 04:09:49 +00:00
Weston Ruter 5e7e44aba7 Customize: Update 'Save & Activate' reference to 'Publish & Activate' in themes help tab text. 
See #39896.
Fixes #42305.

Built from https://develop.svn.wordpress.org/trunk@41968


git-svn-id: http://core.svn.wordpress.org/trunk@41802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-22 20:03:51 +00:00
Weston Ruter c8105f1460 Customize: Fix alignment of Customize, Activate, and Live Preview buttons appearing on the Themes admin screen. 
Amends [41893].
Props Mahvash-Fatima.
See #42215.
Fixes #42275.

Built from https://develop.svn.wordpress.org/trunk@41949


git-svn-id: http://core.svn.wordpress.org/trunk@41783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-19 18:10:47 +00:00
Andrea Fercia 575e60e96c Administration: Improve consistency of the "not found" strings. 
Partially reverts [41608] restoring the original strings without the word `query`.

See #37430.
Fixes #42231.

Built from https://develop.svn.wordpress.org/trunk@41878


git-svn-id: http://core.svn.wordpress.org/trunk@41712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-16 18:14:48 +00:00
Weston Ruter 35b5c9e762 Customize: Eliminate use of customize-loader in core so Customizer is opened consistently in `top` window. 
* Open the door for future browser history feature in #28536, which is currently not feasible when customize-loader is used.
* Remove customizer-loader from being used on admin screens for Dashboard, Themes, non-shiny theme install/update.
* Keep the customize-loader functionality available for plugins, for the time being. It may become deprecated.
* Ensure `return` param in customizer links in Themes screen update to reflect `search` updated by `pushState`.
* Persist `return` when reloading Customizer due to theme switch, autosave restoration, or changeset trashing.
* Use `location.replace()` instead of changing `location.href` when trashing.
* Hide theme browser while Themes screen is loading when there is a `search` to prevent flash of unfiltered themes.
* Use throttling instead of debouncing when searching themes to ensure that screen is updated immediately on page load.
* Fix encoding and decoding of `search` param between URL and search field.
* Add support for dismissing autosaves when closing customize-loader, when it is used by plugins.
* Skip sending changeset UUID to customize-loader for population in browser location if changeset branching is not enabled.

See #28536.
Fixes #40254.

Built from https://develop.svn.wordpress.org/trunk@41797


git-svn-id: http://core.svn.wordpress.org/trunk@41631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-09 16:04:48 +00:00
Andrea Fercia 1f4dab28fe Accessibility: Improve the Theme Details modal accessibility. 
- sets the modal content to `role="document"` to make screen readers switch back to browse mode
- standardizes the Themes screen and Customizer modals interaction
- Themes screen modal: sets initial focus on the modal overlay instead of the primary button, avoiding to "skip" content for keyboard and screen reader users

Fixes #42055.

Built from https://develop.svn.wordpress.org/trunk@41658


git-svn-id: http://core.svn.wordpress.org/trunk@41492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-01 13:48:46 +00:00
Pascal Birchler 1f5c7470fb Plugins: Improve error messages on plugins screen. 
This unifies the layout and wording of error messages on both the plugins screen and the themes screen.

Props tinkerbelly, juhise, Ankit K Gupta, m1tk00, swissspidy, mrahmadawais, danieltj.
Fixes #37430.

Built from https://develop.svn.wordpress.org/trunk@41608


git-svn-id: http://core.svn.wordpress.org/trunk@41443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-09-27 08:46:45 +00:00
Andrea Fercia cc9d3cfbb3 Themes: Fix missing search field in the Theme Install screen after [40572]. 
Props desrosj, cristianozanca for reporting.
Fixes #34881.

Built from https://develop.svn.wordpress.org/trunk@40586


git-svn-id: http://core.svn.wordpress.org/trunk@40456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-08 15:59:44 +00:00
Andrea Fercia 471f1e7201 Accessibility: Wrap the installed themes search field within a form element. 
Valid code is important not just to formally meet the specification, but also to
ensure user agents, including assistive technologies, can accurately interpret
and parse content. When HTML elements are not used in the recommended way,
user agents may render them in unexpected ways. It can also become a problem for
compatibility with older or even future browsers, devices, or other software.
See W3C WCAG 4.1.1.

Props takayukister, aryamaaru.
Fixes #34881.

Built from https://develop.svn.wordpress.org/trunk@40572


git-svn-id: http://core.svn.wordpress.org/trunk@40442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-05 19:02:45 +00:00
Andrea Fercia a9600d1a53 Accessibility: Remove inappropriate content from the Themes screen heading. 
Props joedolson.

See #26601.

Built from https://develop.svn.wordpress.org/trunk@39528


git-svn-id: http://core.svn.wordpress.org/trunk@39468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-12-06 23:12:41 +00:00
Sergey Biryukov 529e242a39 I18N: Merge two 'ERROR:' strings. 
Props ramiy.
Fixes #38860.
Built from https://develop.svn.wordpress.org/trunk@39307


git-svn-id: http://core.svn.wordpress.org/trunk@39247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-11-19 01:09:30 +00:00
Pascal Birchler f88c248a52 Themes: After [38788], further improve the update button when there's no update package. 
Prevents running shiny install when no package exists.


Fixes #37774.
Built from https://develop.svn.wordpress.org/trunk@38855


git-svn-id: http://core.svn.wordpress.org/trunk@38798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-10-21 10:36:46 +00:00
Pascal Birchler e4d7dd2b8a Upgrade/Install: Refresh update counts after page load. 
By enqueuing the updates script in the footer and passing the number of available updates to it after page load, the update bubbles will be more accurate.

Props ocean90, swissspidy.
Fixes #13071.
Built from https://develop.svn.wordpress.org/trunk@38827


git-svn-id: http://core.svn.wordpress.org/trunk@38770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-10-19 10:27:29 +00:00
Pascal Birchler a60ac4684b Themes: Do not show an update button if there's no update package. 
This updates the list view to match the existing behaviour in the single theme modal.

Props tristangemus for initial patch.
Fixes #37774.
Built from https://develop.svn.wordpress.org/trunk@38788


git-svn-id: http://core.svn.wordpress.org/trunk@38731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-10-14 13:33:29 +00:00
Andrea Fercia d65a038ca3 Accessibility: Remove target=_blank from the Plugins, Themes, Media, Update, and Tools screens help tabs links. 
Stop taking control of users' browsers.

Props rianrietveld.
Fixes #38215. See #23432.

Built from https://develop.svn.wordpress.org/trunk@38722


git-svn-id: http://core.svn.wordpress.org/trunk@38665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-10-04 07:08:29 +00:00
Andrea Fercia eeefec932f Administration: Improve the usage of the button CSS classes. 
Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

- Adds the `button` class to all primary buttons make them responsive
- Removes all `secondary-button` classes and replaces it with button when needed. `button-secondary` shouldn't be used and exists just for backward compatibility reasons
- Replaces classes inside `submit_button()` with a shorthand for some buttons, and use an empty string for the default `button` class. Passing `button` is unnecessary
- Adjusts `get_submit_button()` to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

Built from https://develop.svn.wordpress.org/trunk@38672


git-svn-id: http://core.svn.wordpress.org/trunk@38615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-09-28 19:54:28 +00:00
Sergey Biryukov 92343be1f4 I18N: Allow for WordPress Plugin/Theme Directory URLs to be localized. 
Props ramiy.
Fixes #37501.
Built from https://develop.svn.wordpress.org/trunk@38325


git-svn-id: http://core.svn.wordpress.org/trunk@38266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 01:19:39 +00:00
Sergey Biryukov 0be3a84ad0 I18N: After [38057], consistently use a context for other instances of `Activate %s`, `Network Activate %s`, and `Delete %s` strings. 
See #37290.
Built from https://develop.svn.wordpress.org/trunk@38071


git-svn-id: http://core.svn.wordpress.org/trunk@38012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-16 23:20:29 +00:00
Dominik Schilling 98d03cb738 Update/Install: Give context to some install/update strings to allow for differentiation between theme and plugin translations. 
Props swissspidy, SergeyBiryukov.
Fixes #37290.
Built from https://develop.svn.wordpress.org/trunk@38057


git-svn-id: http://core.svn.wordpress.org/trunk@37998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-13 17:32:29 +00:00
Dominik Schilling 25e66e4f1e Text Changes: Unify permission error messages. 
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.

Props ramiy, Presskopp.
Fixes #34521.
Built from https://develop.svn.wordpress.org/trunk@37914


git-svn-id: http://core.svn.wordpress.org/trunk@37855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-29 15:16:29 +00:00
Konstantin Obenland 8c82515ab6 Update/Install: Shiny Updates v2. 
Gone are the days of isolation and feelings of "meh", brought on by The Bleak Screen of Sadness. For a shiny knight has arrived to usher our plugins and themes along their arduous journey of installation, updates, and the inevitable fate of ultimate deletion.

Props swissspidy, adamsilverstein, mapk, afragen, ocean90, ryelle, j-falk, michael-arestad, melchoyce, DrewAPicture, AdamSoucie, ethitter, pento, dd32, kraftbj, Ipstenu, jorbin, afercia, stephdau, paulwilde, jipmoors, khag7, svovaf, jipmoors, obenland.
Fixes #22029, #25828, #31002, #31529, #31530, #31773, #33637, #35032.


Built from https://develop.svn.wordpress.org/trunk@37714


git-svn-id: http://core.svn.wordpress.org/trunk@37680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-15 16:37:29 +00:00
Sergey Biryukov 45b7930627 Text Changes: Consistently refer to https://wordpress.org/plugins/ and https://wordpress.org/themes/ as WordPress Plugin Directory and WordPress Theme Directory, respectively. 
Props mpol.
Fixes #35938.
Built from https://develop.svn.wordpress.org/trunk@37297


git-svn-id: http://core.svn.wordpress.org/trunk@37263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-04-22 06:57:26 +00:00
Sergey Biryukov 9cb7cab875 I18N: Remove `<a>` tags from translatable strings in `wp-admin/themes.php`. 
Props ramiy.
Fixes #35745.
Built from https://develop.svn.wordpress.org/trunk@36657


git-svn-id: http://core.svn.wordpress.org/trunk@36624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-02-23 23:39:25 +00:00
Pascal Birchler 81e9462ca3 Themes: Improve error messages for broken themes. 
Props mayukojpn for initial patch.
Fixes #35286.
Built from https://develop.svn.wordpress.org/trunk@36638


git-svn-id: http://core.svn.wordpress.org/trunk@36605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-02-23 17:20:27 +00:00
Andrea Fercia 62d8fda8dd After [36171] remove all the occurrences of the old CSS clearfix. 
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.

See #26396.
Built from https://develop.svn.wordpress.org/trunk@36422


git-svn-id: http://core.svn.wordpress.org/trunk@36389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-30 13:46:27 +00:00
Konstantin Obenland c0e903a040 Themes: Clear floated theme cards on Themes page. 
Also maintains visual separation for Broken Themes table on searches that
return no results.

See [36171] for `.wp-clearfix`.

Props 5um17, obenland, valendesigns, afercia.
Fixes #26646.


Built from https://develop.svn.wordpress.org/trunk@36270


git-svn-id: http://core.svn.wordpress.org/trunk@36237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-12 17:13:29 +00:00
Weston Ruter 8fed77574c Customize: Return user to referring URL when leaving Customizer in absence of `return` query param. 
When referring URL is not available, default returning user to frontend URL instead of admin URL. Themes page is updated to include the `return` path in Customizer links.

Props McGuive7, westonruter.
Fixes #32637.

Built from https://develop.svn.wordpress.org/trunk@35483


git-svn-id: http://core.svn.wordpress.org/trunk@35447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-11-01 06:40:28 +00:00
Andrea Fercia dc0e7e1a79 Accessibility: Improve headings hierarchy in the Theme browser modal dialog. 
Fixes #34288.
Built from https://develop.svn.wordpress.org/trunk@35220


git-svn-id: http://core.svn.wordpress.org/trunk@35186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 15:56:25 +00:00
Sergey Biryukov 09ee95ea49 Themes: Add Install Parent Theme button for child themes that are missing a parent theme. 
Props rabmalin for initial patch.
Fixes #32668.
Built from https://develop.svn.wordpress.org/trunk@35187


git-svn-id: http://core.svn.wordpress.org/trunk@35153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:11:24 +00:00
Sergey Biryukov 662ad721ec Remove stray closing tag in `wp-admin/themes.php`. 
Props tfrommen.
Fixes #34237.
Built from https://develop.svn.wordpress.org/trunk@34994


git-svn-id: http://core.svn.wordpress.org/trunk@34959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 21:17:25 +00:00
Helen Hou-Sandí dd08157024 Notices: Add styles for use against white backgrounds. 
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.

There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.

props paulwilde, hugobaeta, melchoyce.
fixes #32244.

Built from https://develop.svn.wordpress.org/trunk@34365


git-svn-id: http://core.svn.wordpress.org/trunk@34329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-21 15:26:25 +00:00
Scott Taylor a5529285d1 `_wpThemeSettings.l10n.searchPlaceholder` is an input placeholder and doesn't handle UTF-8 or HTML entities properly. In lieu of using literal Unicode here, use `...`. 
See #32875.

Built from https://develop.svn.wordpress.org/trunk@34014


git-svn-id: http://core.svn.wordpress.org/trunk@33983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 20:36:24 +00:00
Scott Taylor 02ae926dfd Round 2 of: We should use ellipses &hellip; / … instead of three dots/periods ... e.g Loading… not Loading... 
Props yoavf.
Fixes #32875.

Built from https://develop.svn.wordpress.org/trunk@33970


git-svn-id: http://core.svn.wordpress.org/trunk@33939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 04:39:25 +00:00
Sergey Biryukov bc0a1e1c4b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/themes.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33866


git-svn-id: http://core.svn.wordpress.org/trunk@33834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:45:21 +00:00
Sergey Biryukov 5a97ff5206 Bump H3 headings to H2 on Themes screen for better accessibility. 
props joehills.
fixes #33560.
Built from https://develop.svn.wordpress.org/trunk@33820


git-svn-id: http://core.svn.wordpress.org/trunk@33788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 03:51:21 +00:00
Dominik Schilling 8679a93f16 Themes: Remove legacy theme preview. 
The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!

fixes #33178.
Built from https://develop.svn.wordpress.org/trunk@33492


git-svn-id: http://core.svn.wordpress.org/trunk@33459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-29 18:36:26 +00:00
Sergey Biryukov 13a1818d89 Replace empty table header with a table cell. 
props afercia.
fixes #33047.
Built from https://develop.svn.wordpress.org/trunk@33456


git-svn-id: http://core.svn.wordpress.org/trunk@33423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-28 10:19:24 +00:00
Dion Hulse 412013a158 Allow HTML/entities in the Active Theme Name in the themes.php & Customizer templates. 
Props iCaleb
Fixes #33036

Built from https://develop.svn.wordpress.org/trunk@33327


git-svn-id: http://core.svn.wordpress.org/trunk@33299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-20 01:46:24 +00:00
Konstantin Obenland bd974d7bf2 Use a less element-specific class name for links within page titles. 
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.

Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@33067


git-svn-id: http://core.svn.wordpress.org/trunk@33038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 16:42:24 +00:00
Konstantin Obenland 7dc1d06e64 Proper heading for admin screens. 
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 15:41:25 +00:00
Sergey Biryukov 13af7e1d72 Merge two strings from theme details dialog. 
props McGuive7.
fixes #32047.
Built from https://develop.svn.wordpress.org/trunk@32332


git-svn-id: http://core.svn.wordpress.org/trunk@32303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-02 09:11:25 +00:00
Gary Pendergast e2d3bdf615 Correctly escape theme version numbers when displaying them. 
Props collinsinternet.


Built from https://develop.svn.wordpress.org/trunk@32170


git-svn-id: http://core.svn.wordpress.org/trunk@32145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-20 06:27:25 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org. 
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-12 21:29:32 +00:00
Andrew Ozz 2d36b8ff4a Accessibility improvements for Themes screen: fix keyboard events and callbacks for the Search field, increase trigger timeout a bit, improve Esc. key handling. 
Props joedolson, adamsilverstein, afercia, DrewAPicture. Fixes #26600.
Built from https://develop.svn.wordpress.org/trunk@31994


git-svn-id: http://core.svn.wordpress.org/trunk@31973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-03 02:32:28 +00:00
Helen Hou-Sandí d85f8fe326 Admin notices: Make (most) core notices dismissible. 
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

Built from https://develop.svn.wordpress.org/trunk@31973


git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 22:06:28 +00:00
Dominik Schilling 2c036f589e Remove a stray > introduced in [31905]. 
see #31776.
Built from https://develop.svn.wordpress.org/trunk@31915


git-svn-id: http://core.svn.wordpress.org/trunk@31894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-27 23:20:27 +00:00
Dominik Schilling 55519962cc Improve newly added strings for i18n: 
* Use a placeholder for the theme name to be able to reorder words.
* Uppercase D for "Theme Details" to match existing strings.
* Merge two revision date formats.
* Add translator comment to strings with placeholders.

props obenland.
see #31776.
Built from https://develop.svn.wordpress.org/trunk@31905


git-svn-id: http://core.svn.wordpress.org/trunk@31884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-26 20:56:26 +00:00
Sergey Biryukov f7df99549a Themes: Add feedback for screen readers when search results are changed. 
props obenland, joedolson.
see #26600.
Built from https://develop.svn.wordpress.org/trunk@31497


git-svn-id: http://core.svn.wordpress.org/trunk@31478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-22 10:15:26 +00:00
Dominik Schilling 18349e84cf Remove a stray $ from [30793]. 
props ipm-frommen.
see #30553.
Built from https://develop.svn.wordpress.org/trunk@30794


git-svn-id: http://core.svn.wordpress.org/trunk@30784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-09 11:27:22 +00:00
Dominik Schilling 332e0a7f82 Themes: Use Customizer deep-links inside the theme modal. 
props DrewAPicture, ocean90.
see #25569, #25571.
fixes #30553.
Built from https://develop.svn.wordpress.org/trunk@30793


git-svn-id: http://core.svn.wordpress.org/trunk@30783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 22:23:23 +00:00
John Blackbourn 6fcf4ed3c5 Prevent the deletion of a theme while it has an active child theme. 
Fixes #29580
Props karpstrucking, jesin

Built from https://develop.svn.wordpress.org/trunk@30697


git-svn-id: http://core.svn.wordpress.org/trunk@30687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 02:21:24 +00:00
John Blackbourn d88ed475b0 Switch to a `403` response code in places where it is more appropriate than a `500` due to permissions errors. 
Fixes #10551
Props nacin

Built from https://develop.svn.wordpress.org/trunk@30356


git-svn-id: http://core.svn.wordpress.org/trunk@30355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-16 06:16:22 +00:00
Sergey Biryukov 15a1e0731e Use proper functions for escaped translations. 
pros jcastaneda.
fixes #30012.
Built from https://develop.svn.wordpress.org/trunk@29961


git-svn-id: http://core.svn.wordpress.org/trunk@29708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-18 20:11:18 +00:00
Sergey Biryukov f25962ac14 Themes: Make "Live Preview" the primary action and "Activate" secondary. 
props celloexpressions.
fixes #26899.
Built from https://develop.svn.wordpress.org/trunk@29957


git-svn-id: http://core.svn.wordpress.org/trunk@29704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-18 18:17:20 +00:00
Dominik Schilling e3e1433e9a Themes: Make it possible to delete broken themes. 
props ideag, obenland.
fixes #28165.
Built from https://develop.svn.wordpress.org/trunk@29924


git-svn-id: http://core.svn.wordpress.org/trunk@29676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-16 19:46:18 +00:00
Helen Hou-Sandí 713857625e Make filter bar CSS less verbose and redundant. 
Also removes an unused handler in the theme feature filter.

see #28794.

Built from https://develop.svn.wordpress.org/trunk@29596


git-svn-id: http://core.svn.wordpress.org/trunk@29370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-25 15:58:15 +00:00
Sergey Biryukov e370ae439d Fix duplicate Customize button in theme details modal. 
props afercia.
fixes #28987.
Built from https://develop.svn.wordpress.org/trunk@29324


git-svn-id: http://core.svn.wordpress.org/trunk@29105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-29 16:02:16 +00:00
Helen Hou-Sandí c4b561bb6c Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794. 
Built from https://develop.svn.wordpress.org/trunk@29217


git-svn-id: http://core.svn.wordpress.org/trunk@29001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 03:40:16 +00:00
Dominik Schilling 57c914f75a Customizer: Add meta capability `customize` which is mapped to `edit_theme_options`. 
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.

props westonruter, nacin.
fixes #28605.
Built from https://develop.svn.wordpress.org/trunk@29170


git-svn-id: http://core.svn.wordpress.org/trunk@28954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 19:01:16 +00:00
Sergey Biryukov ff00c377ec Show a "No themes found" message if the search for an installed theme doesn't produce any results. 
props gauravmittal1995 for initial patch.
fixes #28587.
Built from https://develop.svn.wordpress.org/trunk@28890


git-svn-id: http://core.svn.wordpress.org/trunk@28689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 09:16:14 +00:00
Scott Taylor 2f513d3320 Fix some `hackificator` odds and ends in `wp-admin`: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:04:16 +00:00
Andrew Nacin dcb39d4dad Themes: Hide 'Add New' with no JS. see #27055. 
Built from https://develop.svn.wordpress.org/trunk@27936


git-svn-id: http://core.svn.wordpress.org/trunk@27766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 23:06:16 +00:00
Andrew Nacin 8ff7cf5c3e Themes screen: Use a normal error for WP_Theme errors. 
see #27235 for trunk.

Built from https://develop.svn.wordpress.org/trunk@27760


git-svn-id: http://core.svn.wordpress.org/trunk@27597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-26 23:37:25 +00:00
Andrew Nacin deb8779af5 More translation cleanups. 
Affects widgets (see #27112), custom headers (see #21785), theme installer (see #27055, reverts [27614]), and some media stuff. Untranslates some complicated strings that need additional study.

see #27453.

Built from https://develop.svn.wordpress.org/trunk@27620


git-svn-id: http://core.svn.wordpress.org/trunk@27463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 08:18:14 +00:00
Andrew Nacin dce0b9adea Use SSL when linking to WordPress.org. see #27115. 
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 04:14:15 +00:00
Mark Jaquith acb65e13c3 Improve pushState, replaceState and routing for Themes page 
* Uses `pushState()` generally
* Uses `replaceState()` when updating a search query (so no history cruft from typing)

fixes #27198. props gcorne, adamsilverstein.
Built from https://develop.svn.wordpress.org/trunk@27268


git-svn-id: http://core.svn.wordpress.org/trunk@27124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 19:22:13 +00:00
Sergey Biryukov 8363d0660b Use .screen-reader-text class instead of an alt attribute for overlay button labels on Themes screen. 
props bramd.
fixes #26603 for trunk.
Built from https://develop.svn.wordpress.org/trunk@27119


git-svn-id: http://core.svn.wordpress.org/trunk@26986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-07 17:33:12 +00:00
Andrew Nacin e18a013956 Themes screen: Add aria-describedby attributes to provide better information to screen readers. 
props joedolson for initial patch.
fixes #26602 for trunk.

Built from https://develop.svn.wordpress.org/trunk@27012


git-svn-id: http://core.svn.wordpress.org/trunk@26889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-22 21:00:11 +00:00
Andrew Nacin 9e942606c8 Keyboard navigation friendliness for themes.php. 
props matveb, azaozz, jorbin.
see #26527.

Built from https://develop.svn.wordpress.org/trunk@26922


git-svn-id: http://core.svn.wordpress.org/trunk@26803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-08 21:35:09 +00:00
Andrew Nacin c06ed485b8 Don't use a JS reserved word in a Backbone template, this breaks IE8. 
props ocean90.
fixes #26539.

Built from https://develop.svn.wordpress.org/trunk@26853


git-svn-id: http://core.svn.wordpress.org/trunk@26740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-11 22:49:09 +00:00
Ryan Boren 07c16fd23c The Pinking Shears stir from their slumber, awakened by what may seem, to those 
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.

Built from https://develop.svn.wordpress.org/trunk@26851


git-svn-id: http://core.svn.wordpress.org/trunk@26738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-11 19:49:11 +00:00
Andrew Nacin 87265a374b Themes: use explicit 'search installed themes' label and placeholder. 
fixes #26496.

Built from https://develop.svn.wordpress.org/trunk@26827


git-svn-id: http://core.svn.wordpress.org/trunk@26714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-09 07:41:10 +00:00
Ryan Boren b07b8d4fe8 Make the Backbone routes pushSTate capable with ?theme=themename type urls instead of hashes. Same applies to search queries. 
Props adamsilverstein, nacin
fixes #25963

Built from https://develop.svn.wordpress.org/trunk@26767


git-svn-id: http://core.svn.wordpress.org/trunk@26655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-07 03:11:10 +00:00
Andrew Nacin 7ab63ed719 Update the help text on themes.php. The Install Themes tab is now an Add New button. 
props ethitter.
fixes #26285.

Built from https://develop.svn.wordpress.org/trunk@26759


git-svn-id: http://core.svn.wordpress.org/trunk@26647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-07 00:45:10 +00:00
Andrew Nacin 32736c45ff Remove screenshotGallery. see #25948. 
Built from https://develop.svn.wordpress.org/trunk@26728


git-svn-id: http://core.svn.wordpress.org/trunk@26617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-06 17:11:10 +00:00
Andrew Nacin df48cebeb4 No-JavaScript and no-Customizer support for the new Themes screen. 
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.

This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.

No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.

The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.

fixes #25964.

Built from https://develop.svn.wordpress.org/trunk@26726


git-svn-id: http://core.svn.wordpress.org/trunk@26615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-06 16:11:10 +00:00
Andrew Nacin 9ecfa135d8 Map old -width theme tags to new -layout tags for the purposes of translation in the admin. 
see #21442.

Built from https://develop.svn.wordpress.org/trunk@26725


git-svn-id: http://core.svn.wordpress.org/trunk@26614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-06 14:37:10 +00:00
Andrew Nacin d1dcd30c5f Themes: Switch to a text overlay instead of an icon on hover. Numerous reasons outlined in the ticket. 
props shaunandrews.
fixes #26440.

Built from https://develop.svn.wordpress.org/trunk@26708


git-svn-id: http://core.svn.wordpress.org/trunk@26597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-05 23:43:11 +00:00
Andrew Nacin 08430e2684 Theme: When showing an author in the grid (during a search), don't include the author's link. 
fixes #26433.

Built from https://develop.svn.wordpress.org/trunk@26684


git-svn-id: http://core.svn.wordpress.org/trunk@26574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-05 19:08:10 +00:00
Andrew Nacin 72f9712a1f Themes: Refine how we display the current theme. 
props shaunandrews, kwight, matveb.
see #26003.

Built from https://develop.svn.wordpress.org/trunk@26681


git-svn-id: http://core.svn.wordpress.org/trunk@26571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-05 18:42:16 +00:00
Andrew Nacin fce306232a Allow HTML in the theme name for the themes.php template. 
props matveb.
fixes #26411.

Built from https://develop.svn.wordpress.org/trunk@26638


git-svn-id: http://core.svn.wordpress.org/trunk@26528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-04 21:41:10 +00:00
Andrew Nacin bb32d28c75 For the current theme, display all available actions, as dictated by the admin menu. 
Restores 3.7 behavior. This could include things like Header and Background as well as theme options pages.

see #25948.

Built from https://develop.svn.wordpress.org/trunk@26531


git-svn-id: http://core.svn.wordpress.org/trunk@26424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 18:58:09 +00:00
Dion Hulse 0e5af31e0f Themes: Update notifiations shouldn't be a <a> if they're not links, data.update already contains <p> tags. See #25948 
Built from https://develop.svn.wordpress.org/trunk@26524


git-svn-id: http://core.svn.wordpress.org/trunk@26417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 08:38:10 +00:00
Dion Hulse ea219afa23 Themes: Standardise on dot notation for object access in the Templates. See #25948 
Built from https://develop.svn.wordpress.org/trunk@26523


git-svn-id: http://core.svn.wordpress.org/trunk@26416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 07:34:10 +00:00
Dion Hulse b6a102f1f5 Themes: Remove some HTML from a new string and put it in the replacement value instead. See #25948 
Built from https://develop.svn.wordpress.org/trunk@26522


git-svn-id: http://core.svn.wordpress.org/trunk@26415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 07:20:09 +00:00
Dion Hulse 6c9356b360 Themes: Indent the HTML for proper indentation after r26519 added an extra div. See #25961, #26192 
Built from https://develop.svn.wordpress.org/trunk@26520


git-svn-id: http://core.svn.wordpress.org/trunk@26413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 07:14:10 +00:00
Dion Hulse 4829e81966 Themes: Make the Theme Detail view div use more of the available viewport, Fix the Header and Footer in the viewport and only scroll the theme details, Prefix some more theme CSS classes. Props shaunandrews for the initial viewport patch. Fixes #25961, #26192 
Built from https://develop.svn.wordpress.org/trunk@26519


git-svn-id: http://core.svn.wordpress.org/trunk@26412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 07:12:09 +00:00
Dion Hulse ec734890a9 Themes: Add a updated Help text. Props designsimply & hanni. See #26285 
Built from https://develop.svn.wordpress.org/trunk@26517


git-svn-id: http://core.svn.wordpress.org/trunk@26410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 03:23:10 +00:00
Sergey Biryukov 8ddb058d36 Fix Customize link in theme info window. props kovshenin. see #25948. 
Built from https://develop.svn.wordpress.org/trunk@26508


git-svn-id: http://core.svn.wordpress.org/trunk@26402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-01 21:09:10 +00:00
Dominik Schilling 19b3779e0e Themes: Fix HTML markup for screenshots. props kovshenin. fixes #25959. 
Built from https://develop.svn.wordpress.org/trunk@26504


git-svn-id: http://core.svn.wordpress.org/trunk@26398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-01 18:00:09 +00:00
Dominik Schilling cc11eeac5b Themes: Merge theme.css into wp-admin.css. fixes #25966. 
Built from https://develop.svn.wordpress.org/trunk@26484


git-svn-id: http://core.svn.wordpress.org/trunk@26381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-30 17:32:10 +00:00
Dominik Schilling e5ab876603 Themes: Add missing close tag, see [26462]. see #25959. 
Built from https://develop.svn.wordpress.org/trunk@26473


git-svn-id: http://core.svn.wordpress.org/trunk@26371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-29 17:17:11 +00:00
Dion Hulse 0af3bf7748 Themes: Restore a label accidentally removed in r26470. Props SergeyBiryukov. See #25948 
Built from https://develop.svn.wordpress.org/trunk@26472


git-svn-id: http://core.svn.wordpress.org/trunk@26370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-29 12:04:11 +00:00
Dion Hulse 8ad620e51f Themes: Do extra Cap checks before outputting links, and use full URI's. See #25948 
Built from https://develop.svn.wordpress.org/trunk@26470


git-svn-id: http://core.svn.wordpress.org/trunk@26368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-29 09:01:09 +00:00
Dion Hulse 2c78650fd0 Themes: Add a default image for when a theme doesn't have a screenshot. Props matveb. See #25959 
Built from https://develop.svn.wordpress.org/trunk@26462


git-svn-id: http://core.svn.wordpress.org/trunk@26360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-29 04:04:11 +00:00
Dion Hulse 483824f8fb Themes: Display Activated/Deleted messages below the H2, before the Themes. See #26305 
Built from https://develop.svn.wordpress.org/trunk@26461


git-svn-id: http://core.svn.wordpress.org/trunk@26359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-29 02:40:09 +00:00
Dion Hulse 72166b14ad Themes: Remove an unused Delete Theme link on the multiple view. See #25948 
Built from https://develop.svn.wordpress.org/trunk@26459


git-svn-id: http://core.svn.wordpress.org/trunk@26357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-29 01:55:10 +00:00
Dominik Schilling 2597e857be Appearance Themes: Don't show theme actions if the current theme doesn't support menus or widgets. 
props MikeHansenMe.
fixes #25949.
Built from https://develop.svn.wordpress.org/trunk@26335


git-svn-id: http://core.svn.wordpress.org/trunk@26237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-23 12:15:10 +00:00
Dion Hulse 61ed60c619 Themes: Move the escaping of content from JS back to PHP. This allows us to take advantage of the display() WP_Theme method to translate the text properly, and to strip out any HTML tags we don't wish to display. Fixes #26100. See #25948 
Built from https://develop.svn.wordpress.org/trunk@26316


git-svn-id: http://core.svn.wordpress.org/trunk@26220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-22 02:34:10 +00:00