Commit Graph

20929 Commits

Author SHA1 Message Date
Daryl Koopersmith b2db6270ee Media: Restore 3.4 editor behavior and remove TinyMCE views.
* Reactivates the `wpgallery` and `wpeditimage` TinyMCE plugins. Deactivates the `wpviews` TinyMCE plugin.
* Moves still-relevant logic from `mce-views.js` to `media-upload.js` and `shortcode.js`.
* No longer include `wp-includes/js/mce-views.js`. This code will not be used in 3.5, and should be considered unstable.
* Currently, this is the real 3.4 experience; as such, editing triggers the old modals. Changing this is the next major step.

When reassessing views, we should look over all of these tickets and anticipate these bugs accordingly.

fixes #21813, #22123, #22155, #22161, #22257, #22266, #22318, #22407, see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 07:17:22 +00:00
Andrew Nacin ad53112897 Pass 'blank' to Gravatar rather than sending blank.gif for Gravatar to proxy. props miqrogroove, fixes #22354.
git-svn-id: http://core.svn.wordpress.org/trunk@22566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 05:29:56 +00:00
Andrew Nacin 30d4885613 Avoid notices with [22426]. props pross. fixes #22420.
git-svn-id: http://core.svn.wordpress.org/trunk@22565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 05:09:23 +00:00
Andrew Nacin 61577966d4 Pass the post ID from the_shortlink() to wp_get_shortlink() to avoid a change in filters. props SergeyBiryukov, fixes #21309.
git-svn-id: http://core.svn.wordpress.org/trunk@22564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 05:05:34 +00:00
Andrew Nacin 7b74142364 Revert accordion-delay code from [22400] that was causing problems. props lessbloat. fixes #21283.
git-svn-id: http://core.svn.wordpress.org/trunk@22563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 05:03:33 +00:00
Andrew Nacin 927c2c48d5 Sharper HiDPI alignment icons for TinyMCE. props lessbloat. fixes #22431.
git-svn-id: http://core.svn.wordpress.org/trunk@22562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 03:41:47 +00:00
Daryl Koopersmith 5ed166d269 Media: Activate the featured image toolbar when the media dialog is first opened. see #21390, #21776.
git-svn-id: http://core.svn.wordpress.org/trunk@22561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 02:39:54 +00:00
Mark Jaquith ca7b159cc7 Squash a PHP notice in the XML-RPC server.
git-svn-id: http://core.svn.wordpress.org/trunk@22560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 22:35:41 +00:00
Andrew Nacin f1f045cdde 3.5-beta3
git-svn-id: http://core.svn.wordpress.org/trunk@22559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 04:06:51 +00:00
Daryl Koopersmith 8e775dff4b Media: Better image detection in the embed from URL tab. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 03:33:41 +00:00
Daryl Koopersmith 0188fc3e52 Media: Add support for applicable *-upload-ui hooks.
Supports pre-upload-ui, pre-plupload-upload-ui, post-plupload-upload-ui, post-upload-ui.

see #22186, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 01:50:08 +00:00
Daryl Koopersmith 65e35e3d76 Media: Improve backwards compatibility for image_size_names_choose filter. see #22186, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 01:23:18 +00:00
Andrew Nacin 6f44d7c5bd SimplePie: Ensure the DOMNode::getLineNo() method exists. props rmccue. fixes #22425.
git-svn-id: http://core.svn.wordpress.org/trunk@22555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 00:49:15 +00:00
Daryl Koopersmith b5ab7bbbc9 Media: Properly insert caption shortcodes for attachments.
git-svn-id: http://core.svn.wordpress.org/trunk@22554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 00:32:04 +00:00
Ryan Boren 02d80201fa In wp_crop_image(), preserve both src_file and src. src_file must be preserved even when url fopen is used so that we don't try to save to a filename based on the url.
see #6821


git-svn-id: http://core.svn.wordpress.org/trunk@22553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 00:03:55 +00:00
Daryl Koopersmith 8c73f531b9 Media: Add an "upload more files" button to upload states. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-12 23:52:17 +00:00
Bot (Assets) 8c60f41b2f Compress scripts/styles: 3.5-beta2-22551. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@22551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-12 22:58:31 +00:00
Andrew Ozz 114c42a3b5 TinuMCE: update to 3.5.7, fixes #21173
git-svn-id: http://core.svn.wordpress.org/trunk@22550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-12 21:20:46 +00:00
Andrew Nacin 78f0c0a9df Revert [22421]. see #6821. see #22308. see #22419.
git-svn-id: http://core.svn.wordpress.org/trunk@22549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-12 07:47:41 +00:00
Daryl Koopersmith 1ec12cccb9 Media: Allow successive embed URLs. see [22547], #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-12 06:02:03 +00:00
Daryl Koopersmith 2d87f983ad Media: Add Embed from URL tab.
Note: There is a bug that currently blocks adding several successive embeds.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-12 05:57:12 +00:00
Bot (Assets) e84d1f724d Compress scripts/styles: 3.5-beta2-22546.
git-svn-id: http://core.svn.wordpress.org/trunk@22546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 22:58:32 +00:00
Andrew Nacin 49a0dc9a27 In switch_theme(), make sure there are no residual template_root or stylesheet_root options remaining if there is only one theme root registered. see #22252.
git-svn-id: http://core.svn.wordpress.org/trunk@22545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 21:51:27 +00:00
Andrew Nacin a756c8bfcd Ensure $_wp_default_headers is set before iterating over it in get_custom_header(). props jeffsebring. fixes #22221.
git-svn-id: http://core.svn.wordpress.org/trunk@22544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 19:11:27 +00:00
Daryl Koopersmith 498e4c1366 Media: Ensure variables in the attachment details template have defined defaults.
* Adds styling to the upload progress bar in the attachment details template.
* Defines the `filename` attribute when Plupload creates the client-side `Attachment` model.

fixes #22410, see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 05:16:41 +00:00
Daryl Koopersmith 1e19ec5fb4 Media in QuickPress: Ensure wpActiveEditor is set when the "Add Media" button is clicked. fixes #22021, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 01:40:47 +00:00
Daryl Koopersmith 82213846c3 Media: Add backwards compatibility for attachment_fields_to_edit and attachment_fields_to_save. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 01:26:42 +00:00
Bot (Assets) bbb099b2dd Compress scripts/styles: 3.5-beta2-22540.
git-svn-id: http://core.svn.wordpress.org/trunk@22540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 22:58:34 +00:00
Daryl Koopersmith 0422f833a8 Media templates: Alter escaping regular expression to prevent it from aggresively consuming input meant for interpolation. see #22344, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 21:38:14 +00:00
Ryan Boren 31e669df5a Pass an attachment ID, not a file path, to _load_image_to_edit_path() from wp_crop_image(). This fixes handling of attachments that require url fopen to access the image.
Allow passing urls instead of just file paths to WP_Image_Editor_Imagick::load() and WP_Image_Editor_GD::load() so that attachments requiring URL fopen can be handled.

see #6821


git-svn-id: http://core.svn.wordpress.org/trunk@22538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 20:42:27 +00:00
Daryl Koopersmith 790464193d Media: Add custom URL as an option to attachment display properties. see #21390, #22206.
git-svn-id: http://core.svn.wordpress.org/trunk@22537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 20:36:46 +00:00
Andrew Ozz e7a27494b7 Admin menu: sync the .folded and @media .auto-fold styles, fixes #21998
git-svn-id: http://core.svn.wordpress.org/trunk@22536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 19:41:12 +00:00
Daryl Koopersmith 43c289dee6 Media: Automatically strip any non-image items from the collection when creating a gallery.
Also changes the rules for when the "new gallery" button shows:
* More than two items must be selected.
* At least one of them must be an image.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 19:25:39 +00:00
Daryl Koopersmith 04b85c399d Media: Allow the modal sidebar to scroll. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 19:10:04 +00:00
Daryl Koopersmith 2396b66c98 Media: Watch additional search events. Properly captures clearing the search box. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 18:56:11 +00:00
Daryl Koopersmith 30e0a600bf Media: Add title, caption, and alt text, and attachment info to sidebar.
* Improve sidebar styles.
* Separate the hybrid title/caption field.
* Improve the sidebar image thumbnail.
* Remove filenames from inside the non-image icon thumbnail.
* Properly sync title/caption/alt.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 18:25:04 +00:00
Andrew Nacin e7767b1eba Add comments to time intervals we cannot express with the constants. Fix a comment. props SergeyBiryukov. fixes #20987.
git-svn-id: http://core.svn.wordpress.org/trunk@22531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 18:13:09 +00:00
Daryl Koopersmith 944066ef83 Media: Account for a race condition when deleting an edit gallery frame. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 09:57:28 +00:00
Daryl Koopersmith 9c20d148b9 Media: Add instructions to drag and drop to reorder images on gallery and batch edit pages.
Removes search boxes from these pages as well.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 09:11:33 +00:00
Daryl Koopersmith ead998c57d Media: Keep the selected featured image in the media modal in sync with the page. fixes #22404, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 08:40:35 +00:00
Bot (Translations) 14295d4374 POT, generated from r22524
git-svn-id: http://core.svn.wordpress.org/trunk@22527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 08:18:55 +00:00
Bot (Translations) d4112e9ea1 POT, generated from r22524
git-svn-id: http://core.svn.wordpress.org/trunk@22526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 08:18:50 +00:00
Bot (Translations) c776b44bad POT, generated from r22524
git-svn-id: http://core.svn.wordpress.org/trunk@22525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 08:18:43 +00:00
Andrew Nacin 14b13a0935 Don't unnecessarily translate media upload tab strings. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 07:56:17 +00:00
Daryl Koopersmith bed08350f4 Media: Backwards compatibility for media_upload_tabs.
* Adds `createIframeStates()` to the `MediaFrame` view. It creates states and bindings for the `media_upload_tabs` output, and is included on `MediaFrame.Post` by default.
* Hijacks `tb_remove()` when the media modal is open to ensure the modal closes correctly.
* Adds a `chromeless` parameter to thickbox media tab URLs to render the UI without the old row of tabs.

see #22186, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 07:51:37 +00:00
Andrew Nacin 809bb5a8f7 Update the JS version of the shortcode regex to match [22382]. props SergeyBiryukov. fixes #17657.
git-svn-id: http://core.svn.wordpress.org/trunk@22522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 07:23:55 +00:00
Andrew Nacin e14ff50cfb Don't allow non-image uploads for custom headers and backgrounds. props kovshenin. fixes #22149.
git-svn-id: http://core.svn.wordpress.org/trunk@22521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 05:36:37 +00:00
Andrew Nacin 2d13e264a4 URLs should be esc_url(), not esc_attr().
git-svn-id: http://core.svn.wordpress.org/trunk@22520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 05:30:51 +00:00
Andrew Nacin 1429581c94 Customizer uploader control: Pass arrays of extensions around instead. see #22149.
git-svn-id: http://core.svn.wordpress.org/trunk@22519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 04:59:46 +00:00
Andrew Nacin 7ba61388a4 Use event delegation for Add Media, allowing the event to bubble up to #wpbody. Keeps the Add Media button functional on a second use of QuickPress. fixes #22255.
git-svn-id: http://core.svn.wordpress.org/trunk@22518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 04:39:44 +00:00