WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
41,734 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

28938 Commits

Author SHA1 Message Date
Sergey Biryukov 91a38c62ea Tests: Place `remove_filter()` calls for `_wp_update_comment_data_filter()` before the assertions, for consistency with other tests. 
Follow-up to [48154], [48222].

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48231


git-svn-id: http://core.svn.wordpress.org/trunk@48000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 12:29:03 +00:00
Sergey Biryukov 8ac810e460 Comments: Add a `@since` note to the `wp_update_comment_data` filter about returning a `WP_Error` value. 
Remove the ability to short-circuit comment update by returning `false` from the filter for now.

This was inconsistent with the `pre_comment_approved` filter, and should not be necessary if a more descriptive reason can be given by always using `WP_Error`.

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48230


git-svn-id: http://core.svn.wordpress.org/trunk@47999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 12:03:04 +00:00
Sergey Biryukov 265239b2e5 Coding Standards: Add missing visibility keywords to `Tests_Comment` methods. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48229


git-svn-id: http://core.svn.wordpress.org/trunk@47998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 11:40:06 +00:00
Sergey Biryukov 0a23967d0c Tests: Remove unnecessary i18n from `_wp_update_comment_data_filter()`. 
Follow-up to [48154], [48217].

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48228


git-svn-id: http://core.svn.wordpress.org/trunk@47997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 11:36:02 +00:00
Sergey Biryukov 4532d5a30a Comments: Correct `$wpdb->prepare()` usage in `_wp_batch_update_comment_type()`. 
Follow-up to [47597], [48225].

See #50513, #49236.
Built from https://develop.svn.wordpress.org/trunk@48227


git-svn-id: http://core.svn.wordpress.org/trunk@47996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 11:30:02 +00:00
Sergey Biryukov 345549a412 Docs: Correct `$wp_query` global reference in `render_block()`. 
See #49927, #49572.
Built from https://develop.svn.wordpress.org/trunk@48226


git-svn-id: http://core.svn.wordpress.org/trunk@47995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 11:16:00 +00:00
Sergey Biryukov 18c5348b2f Comments: Introduce `wp_update_comment_type_batch_size` filter for the comment batch size in `_wp_batch_update_comment_type()`. 
Follow-up to [47597].

Props dchymko.
Fixes #50513. See #49236.
Built from https://develop.svn.wordpress.org/trunk@48225


git-svn-id: http://core.svn.wordpress.org/trunk@47994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 11:06:02 +00:00
gziolo 0249959306 Editor: Introduce block context 
Backports a new block context feature from Gutenberg. The purpose of this feature is to be able to establish values in a block hierarchy which can be consumed by blocks anywhere lower in the same hierarchy. These values can be established either by the framework, or by other blocks which provide these values. See documentation: https://github.com/WordPress/gutenberg/blob/master/docs/designers-developers/developers/block-api/block-context.md

Props aduth, epiqueras.
Fixes #49927.


Built from https://develop.svn.wordpress.org/trunk@48224


git-svn-id: http://core.svn.wordpress.org/trunk@47993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 11:04:04 +00:00
Sergey Biryukov 0a805dbee6 Docs: Add a `@since` note to `edit_comment()` about the new return value. 
Follow-up to [48154].

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48223


git-svn-id: http://core.svn.wordpress.org/trunk@47992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 01:04:03 +00:00
Sergey Biryukov b9d52142c8 Tests: Remove unnecessary `tearDown()` method in `Tests_Ajax_EditComment`. 
Restoring the hook-related globals to their state at `setUp()` is addressed by `WP_UnitTestCase_Base::_restore_hooks()`.

Follow-up to [48154].

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48222


git-svn-id: http://core.svn.wordpress.org/trunk@47991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 01:00:04 +00:00
Sergey Biryukov ca11e26edb Docs: Remove `@return void` from some tests, per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48221


git-svn-id: http://core.svn.wordpress.org/trunk@47990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 00:44:04 +00:00
Sergey Biryukov 89242ed8e5 Docs: Improve documentation for Ajax comment tests per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48220


git-svn-id: http://core.svn.wordpress.org/trunk@47989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 00:43:01 +00:00
Sergey Biryukov 7a235fc584 Docs: Correct documentation for the `filter` parameter of `get_category()` and `get_tag()`. 
Follow-up to [48197].

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48219


git-svn-id: http://core.svn.wordpress.org/trunk@47988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-30 00:04:05 +00:00
Sergey Biryukov f5942603c0 Comments: Make `wp_update_comment()` return a `WP_Error` object for a canceled update, if `$wp_error` parameter is true. 
Remove redundant checks for `wp_update_comment()` results being `false`, as the function always returns a `WP_Error` object now if `$wp_error` is true.

Follow-up to [48154], [48215], [48216].

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48218


git-svn-id: http://core.svn.wordpress.org/trunk@47987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-29 23:42:03 +00:00
Sergey Biryukov c6824c4330 Tests: Remove unnecessary i18n from `_wp_update_comment_data_filter()`. 
Follow-up to [48154].

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48217


git-svn-id: http://core.svn.wordpress.org/trunk@47986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-29 23:09:05 +00:00
Sergey Biryukov e2936bd7e5 Comments: Make `wp_update_comment()` return a `WP_Error` object on database error, if `$wp_error` parameter is true. 
Follow-up to [48154], [48215].

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48216


git-svn-id: http://core.svn.wordpress.org/trunk@47985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-29 23:06:04 +00:00
Sergey Biryukov d8a08ecada Comments: Minor adjustments to `wp_update_comment()`: 
* Revert the logic of `$wp_error` checks to avoid negation.
* Clarify the return value, restore the edits from [47017].
* Update `wp_update_comment_data` filter check to allow `false` to prevent the update.

Follow-up to [48154].

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48215


git-svn-id: http://core.svn.wordpress.org/trunk@47984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-29 22:44:03 +00:00
Sergey Biryukov 347e831768 Docs: Improve documentation for the `$prev_value` parameter and return result of various metadata update functions. 
Props stevenlinx.
Fixes #50502. See #49572.
Built from https://develop.svn.wordpress.org/trunk@48214


git-svn-id: http://core.svn.wordpress.org/trunk@47983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-29 21:22:09 +00:00
gziolo 7d19adab35 Chore: Update package-lock.json file 
Improve the shape of package-lock.json file to make it stable. The main change is that both dependencies of WordPress packages that use npm aliases are listed as development dependencies: puppeteer and prettier. This patch includes also block.json files for dynamic blocks copied from WordPress packages.

Props ellatrix.
Fixes #50420.


Built from https://develop.svn.wordpress.org/trunk@48213


git-svn-id: http://core.svn.wordpress.org/trunk@47982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-29 11:50:29 +00:00
Sergey Biryukov 37dea23ce8 Docs: Document the return value of `wp_get_attachment_metadata()` using hash notation. 
Props stevenlinx.
Fixes #50505.
Built from https://develop.svn.wordpress.org/trunk@48212


git-svn-id: http://core.svn.wordpress.org/trunk@47981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-29 11:20:08 +00:00
Sergey Biryukov 5a60d4b3b0 Customize: Do not allow changesets to be deleted when someone is editing them. 
This makes the behavior consistent with that of locked posts, which can't be deleted via the list tables when another user is editing them.

Props dlh.
Fixes #50501.
Built from https://develop.svn.wordpress.org/trunk@48211


git-svn-id: http://core.svn.wordpress.org/trunk@47980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-29 10:33:08 +00:00
Sergey Biryukov 71244fc29e Customize: Ensure the default message in `LockedNotification` is set to a string instead of `null`. 
This avoids a JS error when passing the message to `wp.a11y.speak()` when showing the "changeset is locked" overlay to prevent two users from editing the same changeset simultaneously.

Props dlh.
Fixes #50500.
Built from https://develop.svn.wordpress.org/trunk@48210


git-svn-id: http://core.svn.wordpress.org/trunk@47979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-29 09:49:05 +00:00
Sergey Biryukov cd0349b301 Themes: Add a return value to theme functions calling `locate_template()`: 
* `get_header()`
* `get_footer()`
* `get_sidebar()`
* `get_template_part()`

These functions now return false if the template file could not be found, to allow for easier debugging.

Props tferry, sphakka, johnbillion, pento, davidbinda, desrosj, birgire, garrett-eclipse, williampatton, davidbaumwald, SergeyBiryukov.
Fixes #40969.
Built from https://develop.svn.wordpress.org/trunk@48209


git-svn-id: http://core.svn.wordpress.org/trunk@47978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 23:10:04 +00:00
Sergey Biryukov 570b6e0866 Comments: Rename the `$avoid_die` parameter of `wp_allow_comment()` and `wp_new_comment()` to `$wp_error`. 
This makes the function signatures more consistent with `wp_update_comment()` and `wp_set_comment_status()`.

`wp_check_comment_flood()` is left as the only function with the `$avoid_die` parameter for now, as it does not return a `WP_Error` object.

Follow-up to [48154], [48207].

See #39732.
Built from https://develop.svn.wordpress.org/trunk@48208


git-svn-id: http://core.svn.wordpress.org/trunk@47977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 22:10:06 +00:00
Sergey Biryukov 8c721c9c34 Docs: Correct description for the `$avoid_die` parameter of `wp_check_comment_flood()`. 
The function always return a boolean value, never a `WP_Error` object.

See #49572, #39732.
Built from https://develop.svn.wordpress.org/trunk@48207


git-svn-id: http://core.svn.wordpress.org/trunk@47976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 21:42:03 +00:00
Sergey Biryukov 8d7a19cdc2 Bootstrap/Load: Remove special handling for `REQUEST_TIME` and `REQUEST_TIME_FLOAT` server values in `wp_magic_quotes()`. 
This was intended as a temporary fix until `add_magic_quotes()` is modified to leave non-string values untouched, which has now been done.

Follow-up to [47370], [48205].

See #48605.
Built from https://develop.svn.wordpress.org/trunk@48206


git-svn-id: http://core.svn.wordpress.org/trunk@47975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 21:09:05 +00:00
Sergey Biryukov d25cc189be Bootstrap/Load: Make sure `add_magic_quotes()` does not inappropriately recast non-string data types to string. 
Props donmhico, jrf, Veraxus, Rarst.
Fixes #48605.
Built from https://develop.svn.wordpress.org/trunk@48205


git-svn-id: http://core.svn.wordpress.org/trunk@47974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 21:04:02 +00:00
Sergey Biryukov 66591d00ab Code Modernization: Introduce the spread operator in `wp-includes/IXR`. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props kraftbj.
See #48267, #47678.
Built from https://develop.svn.wordpress.org/trunk@48204


git-svn-id: http://core.svn.wordpress.org/trunk@47973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 18:25:02 +00:00
Sergey Biryukov 3a6eeef571 Posts, Post Types: Return early from `WP_Posts_List_Table::formats_dropdown()` if the post type does not support post formats. 
This avoids an unnecessary database query for the `post_format` taxonomy.

Props Chouby.
Fixes #50496.
Built from https://develop.svn.wordpress.org/trunk@48203


git-svn-id: http://core.svn.wordpress.org/trunk@47972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:30:07 +00:00
Sergey Biryukov 42f06389c0 Security: Improve the wording of messages in `wp_get_auto_update_message()`. 
Props burhandodhy, johnbillion, apedog.
Fixes #50489.
Built from https://develop.svn.wordpress.org/trunk@48202


git-svn-id: http://core.svn.wordpress.org/trunk@47971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:18:03 +00:00
Sergey Biryukov 83d20390c6 Networks and Sites: Use a consistent wording when referring to site deletion on Delete Site screen. 
Props burhandodhy, dartiss.
Fixes #50494.
Built from https://develop.svn.wordpress.org/trunk@48201


git-svn-id: http://core.svn.wordpress.org/trunk@47970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:12:02 +00:00
Sergey Biryukov 00a40b1ef2 Docs: Capitalize "ID", when referring to a user ID, term ID, etc. in a more consistent way. 
Follow-up to [48104]

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48200


git-svn-id: http://core.svn.wordpress.org/trunk@47969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:09:04 +00:00
Sergey Biryukov 3336009e34 Docs: Replace "html" and "xhtml" instances in DocBlocks and comments with "HTML" and "XHTML". 
This ensures consistent capitalization where appropriate.

Props navidos, desrosj.
Fixes #50473.
Built from https://develop.svn.wordpress.org/trunk@48199


git-svn-id: http://core.svn.wordpress.org/trunk@47968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:02:06 +00:00
Sergey Biryukov c892c420b7 Docs: Miscellaneous DocBlock corrections. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48198


git-svn-id: http://core.svn.wordpress.org/trunk@47967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 11:53:04 +00:00
Sergey Biryukov 58ad216087 Docs: Improve documentation for optional parameters per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48197


git-svn-id: http://core.svn.wordpress.org/trunk@47966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 11:49:02 +00:00
Sergey Biryukov ee8e9905c4 Tests: Adjust the test for invalid username in `WP_Test_REST_Users_Controller` to match the new string. 
Follow-up to [48195].

See #47003.
Built from https://develop.svn.wordpress.org/trunk@48196


git-svn-id: http://core.svn.wordpress.org/trunk@47965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 07:51:05 +00:00
Sergey Biryukov 37d48e2f2e Users: Merge two similar error messages about usernames with invalid characters. 
Props ramiy, garrett-eclipse, chetan200891.
Fixes #47003.
Built from https://develop.svn.wordpress.org/trunk@48195


git-svn-id: http://core.svn.wordpress.org/trunk@47964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 23:44:09 +00:00
Sergey Biryukov 5c4290f999 I18N: Remove `<kbd>` tag from a translatable string on Edit Post screen. 
Props ramiy, tobifjellner.
Fixes #48874.
Built from https://develop.svn.wordpress.org/trunk@48194


git-svn-id: http://core.svn.wordpress.org/trunk@47963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 23:02:03 +00:00
Sergey Biryukov 9439c44b44 Docs: Synchronize some documentation for functions in `wp-includes/option.php`. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48193


git-svn-id: http://core.svn.wordpress.org/trunk@47962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 16:56:02 +00:00
John Blackbourn cdd52f8006 Docs: Improvements to the inline docs for metadata related functions. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48192


git-svn-id: http://core.svn.wordpress.org/trunk@47961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 16:34:05 +00:00
Sergey Biryukov abe112c750 Administration: Correct the URL for "Learn more about getting started" link in "Welcome to WordPress" panel. 
Props hareesh-pillai, johnbillion.
Fixes #50484.
Built from https://develop.svn.wordpress.org/trunk@48191


git-svn-id: http://core.svn.wordpress.org/trunk@47960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 12:45:04 +00:00
Sergey Biryukov eb468d3e6a Docs: Remove extra spaces from `@ticket` tag in unit tests. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48190


git-svn-id: http://core.svn.wordpress.org/trunk@47959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 12:04:03 +00:00
Sergey Biryukov 5aa7f46a4f Docs: Improve DocBlocks in `wp-includes/theme.php` per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48189


git-svn-id: http://core.svn.wordpress.org/trunk@47958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 12:02:03 +00:00
Sergey Biryukov 5771b7dff9 Bootstrap/Load: Make some adjustments to `wp_get_environment_type()`: 
* Rename the `wp_approved_environment_types` filter to `wp_environment_types`.
* Introduce `WP_ENVIRONMENT_TYPES` system variable and constant to complement the filter.
* Correct the argument type for the `wp_environment_types` filter.
* Cache the result in a static variable to ensure consistent return value.
* Rename the `stage` type to `staging`.

Follow-up to [47919].

Props dlh, dd32, TimothyBlynJacobs, johnbillion, pbiron.
See #33161.
Built from https://develop.svn.wordpress.org/trunk@48188


git-svn-id: http://core.svn.wordpress.org/trunk@47957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 10:36:06 +00:00
Sergey Biryukov cb9c2ae83f Taxonomy: Make sure `update_object_term_cache()` caches all terms that were not already cached. 
Due to an unintended `break` instruction from a previous iteration, the function cached only one term in each taxonomy.

Follow-up to [48055].

Props Chouby.
Fixes #50352.
Built from https://develop.svn.wordpress.org/trunk@48187


git-svn-id: http://core.svn.wordpress.org/trunk@47956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 22:31:08 +00:00
Sergey Biryukov 3079ab76dc Administration: Add missing comma to the message in "Post via email" section. 
Props kinjaldalwadi, sabernhardt.
Fixes #49238.
Built from https://develop.svn.wordpress.org/trunk@48186


git-svn-id: http://core.svn.wordpress.org/trunk@47955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 19:38:06 +00:00
Sergey Biryukov 40c389c95e Docs: Standardize on "Returning a value from the filter" vs. "Passing a value to the filter". 
The filter is the callback function added with `add_filter()`, therefore the hook passes a value to the filter, and the filter returns a value to change its behaviour.

The documentation is referring to the latter.

Props johnbillion.
See #49572, #16557.
Built from https://develop.svn.wordpress.org/trunk@48185


git-svn-id: http://core.svn.wordpress.org/trunk@47954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 18:49:09 +00:00
John Blackbourn eb9a6c9690 Docs: Miscellaneous docblock improvements. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48184


git-svn-id: http://core.svn.wordpress.org/trunk@47953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 18:40:04 +00:00
John Blackbourn dfdee40ed6 Docs: Clarify the description of functions that check for and perform updates. 
See #49572, #50052.
Built from https://develop.svn.wordpress.org/trunk@48183


git-svn-id: http://core.svn.wordpress.org/trunk@47952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 18:34:03 +00:00
desrosj 9ebcf0922c Docs: Reword inline docs for better readability and clarity. 
This improves the wording of the inline documentation for `redirect_guess_404_permalink()` and the related filters introduced in [47878].

Previously [47878,47885]
See #16557.
Built from https://develop.svn.wordpress.org/trunk@48182


git-svn-id: http://core.svn.wordpress.org/trunk@47951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 16:16:04 +00:00