Commit Graph

98 Commits

Author SHA1 Message Date
Andrew Nacin 23bc457498 Avoid racing TinyMCE, which avoids the creation of unnecessary autosaves. props azaozz. see #7392.
git-svn-id: http://core.svn.wordpress.org/trunk@24849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 03:37:14 +00:00
Andrew Nacin 85cf232e23 Autosave: Don't save an autosave unnecessarily when the post editor loads and TinyMCE is the default editor.
Delete such useless autosaves when we detect them in edit-form-advanced.php.

see #7392.



git-svn-id: http://core.svn.wordpress.org/trunk@24787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-24 05:37:53 +00:00
Andrew Nacin bbc4aa5317 Autosave:
* Remove editor.js as a dependency for autosave.js, as it was in 3.5.
 * Remove heartbeat.js as an implicit dependency.
 * Abstract out the serialization of title/content/excerpt for comparisons.

props azaozz.
fixes #24756.



git-svn-id: http://core.svn.wordpress.org/trunk@24774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-23 03:05:21 +00:00
Andrew Nacin 30344d57b8 Simplify heartbeat API.
* Move to a method to check connection errors, a better framework for future changes.
 * Remove start(), stop(), autostart.

props carldanley.
fixes #23216.



git-svn-id: http://core.svn.wordpress.org/trunk@24749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-19 01:39:48 +00:00
Andrew Nacin 4c17aa3707 Post type support for local autosaves. props azaozz. see #24756.
git-svn-id: http://core.svn.wordpress.org/trunk@24747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-19 00:22:22 +00:00
Andrew Nacin 5bb2f20164 Better 'Connection lost' notice that includes an indication of activity. fixes #24695.
git-svn-id: http://core.svn.wordpress.org/trunk@24743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 21:33:59 +00:00
Mark Jaquith 367e456472 Only add the autosave notice to the first `<h2>` on the page.
Props azaozz. See #24755.

git-svn-id: http://core.svn.wordpress.org/trunk@24710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-16 13:03:22 +00:00
Andrew Nacin a9a0d3b27d For an intermittent connection, only disable save and publish buttons when the request times out. An error still means a we have a connection.
props azaozz.
see #24695.



git-svn-id: http://core.svn.wordpress.org/trunk@24691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 21:07:44 +00:00
Andrew Ozz aff66a7d07 Autosave: properly set autosaveLast when TinyMCE is the default editor. Prevents firing autosave when there are no changes. See #23220
git-svn-id: http://core.svn.wordpress.org/trunk@24431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-09 00:45:01 +00:00
Andrew Ozz 27865da7a9 Remove saving of post_format in autosave and revisions, fixes #24455
git-svn-id: http://core.svn.wordpress.org/trunk@24397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-02 01:29:44 +00:00
Andrew Ozz f17d4bf90f Local autosaves: always set 'autosave = true' in the post data when triggering local autosave on form submit. Fixes cases where the form is submitted shortly after loading the Edit screen, local autosave hasn't run yet and there is no previous data to be merged. Fixes #23960.
git-svn-id: http://core.svn.wordpress.org/trunk@24328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:43:45 +00:00
Andrew Ozz a5da49fb85 Local autosaves: remove debug logging, see #23220
git-svn-id: http://core.svn.wordpress.org/trunk@24269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 23:26:36 +00:00
Andrew Ozz 4facd0d567 Local autosaves: show the notice above the post formats UI, see #23220
git-svn-id: http://core.svn.wordpress.org/trunk@24221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 18:23:05 +00:00
Andrew Ozz d0c5c59c94 Post locks and autosave:
- Move nonces refreshing from autosave to lock checking.
- Do autosave only when there is something to save.
See #23295

git-svn-id: http://core.svn.wordpress.org/trunk@24209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 22:52:55 +00:00
Andrew Ozz d2a8f064aa Post locks:
- Show 'Saving revision...' while autosaving after a post has been taken over. Change to 'Your latest changes were saved as a revision.' when autosave completes.
- Make sure a user exists before using $user->display_name.
- Add 'post_lock_text' action for extending the message text.

git-svn-id: http://core.svn.wordpress.org/trunk@24042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 03:08:51 +00:00
Mark Jaquith 412161de03 Standardize post format postmeta keys around the ones already used by the Crowd Favorite plugin.
props wonderboymusic. fixes #24010.

git-svn-id: http://core.svn.wordpress.org/trunk@24021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 20:57:44 +00:00
Andrew Ozz 33dd4b3d69 Revisions:
- Store the post format as meta on revisions (including autosaves).
- Add post formats data (post meta) when autosaving.
- Only add non-empty post formats data to revisions.
- Correct the post format when previewing a published post.
Props kovshenin, see #19570, see #20564.


git-svn-id: http://core.svn.wordpress.org/trunk@23928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-06 23:18:52 +00:00
Andrew Ozz 2466f6a726 Autosave: use heartbeat to determine when connection is lost and disable the Save and Publish buttons. Re-enable the buttons when connection is restored. Props dh-shredder, see #23220
git-svn-id: http://core.svn.wordpress.org/trunk@23886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-02 22:51:09 +00:00
Mark Jaquith c93e0231af Post Format UI.
* Icons
* Selection
* Prompt text
* Special fields
* Styling
* Sparkles

This is going to need testing, polish, and love.

see #19570. props melchoyce, helen, wonderboymusic, lessbloat, rachelbaker, aaroncampbell, DrewAPicture, ryelle.

git-svn-id: http://core.svn.wordpress.org/trunk@23843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 03:35:41 +00:00
Andrew Ozz 94553917a1 Local autosave: remove the locally stored data after a post is saved. This prevents false positives when several users edit the same post multiple times. See #23220
git-svn-id: http://core.svn.wordpress.org/trunk@23796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-25 23:43:06 +00:00
Andrew Ozz 30ad180d6a Create one autosave per user rather than a single autosave for all users. Remove unused code from autosave.js and wp_ajax_autosave(). See #23665.
git-svn-id: http://core.svn.wordpress.org/trunk@23735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 21:15:43 +00:00
Andrew Ozz 9a695d70bf Local autosave: remove the temp cookie after first use. Prevents false negative if the browser crashes. Add some temp logging to aid testing. See #23220
git-svn-id: http://core.svn.wordpress.org/trunk@23705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 06:15:14 +00:00
Mark Jaquith 6cfdb8a0e2 Wrap self.run in an anonymous function wrapper so self always gets the same scope.
props azaozz. fixes #23780

git-svn-id: http://core.svn.wordpress.org/trunk@23703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 02:32:05 +00:00
Andrew Ozz a224d8aaf7 Local autosave: set a temp cookie on submitting the form and change it on redirecting after the post is saved/updated, then use it to determine if saving worked properly. Removes the chance for false positives after saving/updating a post. See #23220
git-svn-id: http://core.svn.wordpress.org/trunk@23693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-14 03:06:07 +00:00
Andrew Ozz e9245269a7 Autosave to the browser's sessionStorage, compare this autosave to the post content on page load and let the user restore it when the data is not the same. First run, see #23220
git-svn-id: http://core.svn.wordpress.org/trunk@23683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 10:08:16 +00:00
Andrew Nacin 2301074821 Stop using deprecated jQuery API (.browser and .live). Do manual UA sniffing where still necessary. Improve selector performance by using delegated events. props ocean90. see #22975.
git-svn-id: http://core.svn.wordpress.org/trunk@23518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 18:05:28 +00:00
Ryan Boren eaefa67006 When inserting from URL in the media modal, retain query params and properly insert the caption code.
Props koopersmith
fixes #22796


git-svn-id: http://core.svn.wordpress.org/trunk@23110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 23:12:59 +00:00
Andrew Nacin a962e6f58b Autosave: Properly convert undefined fields to empty strings. This bug could cause issues if a post type didn't support the title and/or editor. see #22491.
git-svn-id: http://core.svn.wordpress.org/trunk@22794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 21:04:04 +00:00
Andrew Nacin 1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin 2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
Bot (Assets) 245cb4acba Compress scripts/styles: 3.5-alpha-21587.
git-svn-id: http://core.svn.wordpress.org/trunk@21587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-22 18:58:32 +00:00
bumpbot e5fcf53e85 Compress scripts/styles: 3.5-alpha-21304.
git-svn-id: http://core.svn.wordpress.org/trunk@21304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-23 00:58:20 +00:00
bumpbot a47dcdfcb9 Compress scripts/styles: 3.5-alpha-21301. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@21301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-22 02:58:18 +00:00
azaozz 24917dfbc8 Prevent error in autosave for CPTs without title or editor, props sorich87, fixes #18227
git-svn-id: http://svn.automattic.com/wordpress/trunk@19476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-29 18:06:56 +00:00
azaozz 5bc81f5d80 Workaround for WebKit bug when previewing posts, props SergeyBiryukov, fixes #18341
git-svn-id: http://svn.automattic.com/wordpress/trunk@19299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-15 18:48:55 +00:00
azaozz ca9e43f1c4 Send the 'wp-remove-post-lock' XHR only when the main window is unloaded (unloading the Thickbox iframe triggers it too), see #18515
git-svn-id: http://svn.automattic.com/wordpress/trunk@19258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-11 19:52:12 +00:00
azaozz 6f04738d59 Remove stray comma, fixes #18929
git-svn-id: http://svn.automattic.com/wordpress/trunk@18967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-13 19:46:13 +00:00
nacin de8cc0eae1 Release a user's post lock when the user leaves a post. see #18515.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-27 20:52:07 +00:00
azaozz 65f9c441a7 Replace .attr() with .prop() as per jQuery 1.6.1. Also fixes couple places where the JS wasn't working because attr('some', '') does not remove the HTML property now, see #17311
git-svn-id: http://svn.automattic.com/wordpress/trunk@18027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 01:04:12 +00:00
azaozz 3bb59dbc9c Fix autosave and word count for DFW HTML editor, always update word count on autosave, see #17136
git-svn-id: http://svn.automattic.com/wordpress/trunk@17936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-16 06:17:44 +00:00
azaozz e2baacdb2e Remove blocking alert when login cookie has expired.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-15 05:48:35 +00:00
azaozz a5f2b7d50c DFW: remove unneeded JS global, fix screen flash in WebKit, props koopersmith, see #17136
git-svn-id: http://svn.automattic.com/wordpress/trunk@17702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-26 01:19:26 +00:00
azaozz 258a8f6844 Distraction Free Writing mode, see #17136
git-svn-id: http://svn.automattic.com/wordpress/trunk@17695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-25 01:01:34 +00:00
azaozz e4bf0a4e78 Fix two rare regressions: alert when the login has expires and when post is edited by another user, fixes #16928
git-svn-id: http://svn.automattic.com/wordpress/trunk@17640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-16 02:37:44 +00:00
azaozz b8d696b2a6 Handle error response in autosave_update_slug(), props nacin, fixes #16975
git-svn-id: http://svn.automattic.com/wordpress/trunk@17565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-03-27 20:09:09 +00:00
nacin 38b834c848 Use separate ajax spinners for the Save Draft and Publish buttons on the post form. fixes #14582 with initial patch from wojtek.szkutnik.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-04 20:53:04 +00:00
ryan 7162ca097e autosave_update_post_ID() no longer needed. Fix button enable lag. Props duck_. fixes #13400
git-svn-id: http://svn.automattic.com/wordpress/trunk@14663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-15 14:03:46 +00:00
dd32 c7b7d67892 Remember the post_parent during autosaves. Props duck_. Fixes #12938
git-svn-id: http://svn.automattic.com/wordpress/trunk@14057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-10 12:39:01 +00:00
markjaquith 0f924eee99 Create post_status=auto-draft when creating a new post item. status changes to draft on first auto-save. now we always have a real post ID to work with. see #11889. fixes #11145. fixes #11990
git-svn-id: http://svn.automattic.com/wordpress/trunk@12987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-06 10:07:57 +00:00
azaozz b2966fba30 Merge post.js with page.js and slug.js, optimize categories and tags JS, standardize postboxes IDs and JS.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-13 10:02:42 +00:00