WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
26,898 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

13059 Commits

Author SHA1 Message Date
Drew Jaynes 9ef7c41a15 Inline docs syntax fixes following [28978]. 
See #28740.

Built from https://develop.svn.wordpress.org/trunk@29015


git-svn-id: http://core.svn.wordpress.org/trunk@28803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-07 16:42:16 +00:00
Sergey Biryukov 4a11203b06 Clarify a string on Add New User screen. 
props vancoder, collinsinternet.
fixes #27398.
Built from https://develop.svn.wordpress.org/trunk@29009


git-svn-id: http://core.svn.wordpress.org/trunk@28797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-07 00:54:14 +00:00
Andrew Nacin 4e2f1bd155 Introduce wp_dropdown_languages() and use it on general settings. 
Early rough cut. Obviously not fully implemented.

see #15677.

Built from https://develop.svn.wordpress.org/trunk@29007


git-svn-id: http://core.svn.wordpress.org/trunk@28795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-05 06:19:16 +00:00
Andrew Nacin 7a1351b411 Bring the language chooser to setup-config.php. 
see #28577.

Built from https://develop.svn.wordpress.org/trunk@29006


git-svn-id: http://core.svn.wordpress.org/trunk@28794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-05 05:14:15 +00:00
Andrew Nacin cb49dd0109 Don't include plugin.php twice in setup-config.php. 
fixes #28744. see #28740, [28978].

Built from https://develop.svn.wordpress.org/trunk@29005


git-svn-id: http://core.svn.wordpress.org/trunk@28793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-05 02:13:14 +00:00
Sergey Biryukov 4b7a9edd27 Reinstate 'install_themes_tabs' filter. 
props ghost1227.
fixes #28578.
Built from https://develop.svn.wordpress.org/trunk@29002


git-svn-id: http://core.svn.wordpress.org/trunk@28790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-04 23:58:15 +00:00
Helen Hou-Sandí 63f9cbd02a Media grid, round 2. Expect much more to come. 
* Instead of a sidebar for details, utilize a modal. The modal experience allows for a larger preview, editing images, audio/video previews, and previous/next navigation, like the theme browser. Think of it as an attachment browser.
* Show some details in the grid view to more easily distinguish items.

props ericlewis, wonderboymusic, JerrySarcastic. see #24716.

Built from https://develop.svn.wordpress.org/trunk@28993


git-svn-id: http://core.svn.wordpress.org/trunk@28781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-04 03:39:15 +00:00
Scott Taylor 0546378ce8 Make a new file: `media-grid.js`. This will be way more useful in later commits and help reduce churn and bloat in `media-views.js`. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@28992


git-svn-id: http://core.svn.wordpress.org/trunk@28780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-04 02:18:14 +00:00
John Blackbourn d73923eb4d If we already have a value for WPLANG when installing, insert this language at the top of the language selector and pre-select it. See #28577 
Built from https://develop.svn.wordpress.org/trunk@28984


git-svn-id: http://core.svn.wordpress.org/trunk@28773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 22:56:14 +00:00
John Blackbourn a4a9f52cc9 First pass at switching to radio inputs for the install screen language selector. Needs some more work. See #28577. Props jorbin 
Built from https://develop.svn.wordpress.org/trunk@28983


git-svn-id: http://core.svn.wordpress.org/trunk@28772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 22:53:16 +00:00
John Blackbourn 01b4fe872a Avoid a warning if the translations API call fails on step 1. Remove assignment inside an if statement. See #28577. 
Built from https://develop.svn.wordpress.org/trunk@28982


git-svn-id: http://core.svn.wordpress.org/trunk@28771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 22:31:16 +00:00
Drew Jaynes eedd151405 Note in the hook docs for `preview_post_link` that the `$post` parameter was added. 
See #28729.

Built from https://develop.svn.wordpress.org/trunk@28979


git-svn-id: http://core.svn.wordpress.org/trunk@28768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 20:05:14 +00:00
Andrew Nacin b35982cbff Simplify the setup-config.php UI flow and load process. 
When no configuration file is detected, we now redirect to setup-config.php. This process now uses the WordPress bootstrap, rather than a set of fragile hacks.

fixes #28740.

Built from https://develop.svn.wordpress.org/trunk@28978


git-svn-id: http://core.svn.wordpress.org/trunk@28767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 19:57:14 +00:00
Drew Jaynes d4dd02b4ae Remove backticks on `$post` variables in some short parameter descriptions. 
See [28653], [28654].
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28976


git-svn-id: http://core.svn.wordpress.org/trunk@28765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 19:28:14 +00:00
Drew Jaynes 0ac4474ce4 Fix an incomplete docblock for `wp_create_categories()` as part of `$post/$post_id` cleanup. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28975


git-svn-id: http://core.svn.wordpress.org/trunk@28764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 19:22:15 +00:00
John Blackbourn 38749f273c Use the admin scheme for theme preview URLs when installing new themes. See #21919. 
Built from https://develop.svn.wordpress.org/trunk@28974


git-svn-id: http://core.svn.wordpress.org/trunk@28763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 18:48:16 +00:00
Helen Hou-Sandí 5f6b531f70 Improve oEmbed caching. Introduces the concept of a TTL for oEmbed caches and a filter for `oembed_ttl`. 
We will no longer replace previously valid oEmbed responses with an `{{unknown}}` cache value. When this happens due to reaching a rate limit or a service going down, it is data loss, and is not acceptable. This means that oEmbed caches for a post are no longer deleted indiscriminately every time that post is saved.

oEmbed continues to be cached in post meta, with the addition of a separate meta key containing the timestamp of the last retrieval, which is used to avoid re-requesting a recently cached oEmbed response. By default, we consider a valued cached in the past day to be fresh. This can greatly reduce the number of outbound requests, especially in cases where a post containing multiple embeds is saved frequently.

The TTL used to determine whether or not to request a response can be filtered using `oembed_ttl`, thus allowing for the possibility of respecting the optional oEmbed response parameter `cache_age` or altering the period of time a cached value is considered to be fresh.

Now that oEmbeds are previewed in the visual editor as well as the media modal, oEmbed caches are often populated before a post is saved or published. By pre-populating and avoiding having to re-request that response, we also greatly reduce the chances of a stampede happening when a published post is visible before oEmbed caching is complete.

As it previously stood, a stampede was extremely likely to happen, as the AJAX caching was only triggered when `$_GET['message']` was 1. The published message is 6. We now trigger the caching every time `$_GET['message']` is present on the edit screen, as we are able to avoid triggering so many HTTP requests overall.

props markjaquith. fixes #14759. see #17210.

Built from https://develop.svn.wordpress.org/trunk@28972


git-svn-id: http://core.svn.wordpress.org/trunk@28761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 16:45:14 +00:00
Sergey Biryukov 4e75d406ec Pass $post object to 'preview_post_link' filter. 
props danielbachhuber.
fixes #28729.
Built from https://develop.svn.wordpress.org/trunk@28969


git-svn-id: http://core.svn.wordpress.org/trunk@28758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 14:42:15 +00:00
Sergey Biryukov 489693cd30 Remove non-breaking spaces from auto update email text. 
props trepmal.
fixes #28715.
Built from https://develop.svn.wordpress.org/trunk@28956


git-svn-id: http://core.svn.wordpress.org/trunk@28752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 12:46:17 +00:00
Sergey Biryukov 27ba686eee Simplify a condition in get_sample_permalink_html(). 
see #28350.
Built from https://develop.svn.wordpress.org/trunk@28948


git-svn-id: http://core.svn.wordpress.org/trunk@28745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 00:11:15 +00:00
Sergey Biryukov fc24029d65 Simplify logic in get_sample_permalink_html(), remove duplicated code. 
see #28350.
Built from https://develop.svn.wordpress.org/trunk@28947


git-svn-id: http://core.svn.wordpress.org/trunk@28744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-02 00:04:15 +00:00
Sergey Biryukov 16bb742b66 Display a correct preview link for drafts when permalinks are disabled. 
see #28350.
Built from https://develop.svn.wordpress.org/trunk@28946


git-svn-id: http://core.svn.wordpress.org/trunk@28743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 23:56:14 +00:00
Helen Hou-Sandí 38e5e13b1f Only apply metabox handle styles and JS events to `.postbox .hndle`, as opposed to all `h3`s in a `.postbox`. 
Developers previously relying on the `h3` behavior may be affected. You may want to investigate `do_meta_boxes()` rather than recreating markup.

props SergeyBiryukov, nabil_kadimi.
fixes #28485.

Built from https://develop.svn.wordpress.org/trunk@28940


git-svn-id: http://core.svn.wordpress.org/trunk@28738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-01 16:23:15 +00:00
Dominik Schilling b76d6afbbd Customizer: Reverse arrows in RTL. See #27406. 
props yoavf.
fixes #28669.
Built from https://develop.svn.wordpress.org/trunk@28931


git-svn-id: http://core.svn.wordpress.org/trunk@28729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 20:00:15 +00:00
Dominik Schilling 958ab24709 Customizer: Support `textarea` and commonly-used input types as control type in `WP_Customize_Control`. 
Add `input_attrs` property to support custom input attributes.

(Demo plugin attached to ticket.)

props celloexpressions.
fixes #28477.
Built from https://develop.svn.wordpress.org/trunk@28930


git-svn-id: http://core.svn.wordpress.org/trunk@28728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 19:48:13 +00:00
Helen Hou-Sandí e1db9240b7 Support descriptions for individual customizer controls. 
* Control title (label) markup will also only be output if specified.
* Control section descriptions are no longer italicized for visual hierarchy / differentiation.

props celloexpressions. fixes #27981.

Built from https://develop.svn.wordpress.org/trunk@28927


git-svn-id: http://core.svn.wordpress.org/trunk@28725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 15:55:17 +00:00
Sergey Biryukov 8dcf86f94d Display consistent preview links for drafts. 
props mordauk.
fixes #28350.
Built from https://develop.svn.wordpress.org/trunk@28920


git-svn-id: http://core.svn.wordpress.org/trunk@28719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 10:02:16 +00:00
Andrew Ozz 5168f9c7c6 Secure embeds in the editor (first run): 
- When the user pastes an embeddable http URL, try to get the https embed.
- If an embed provider doesn't support ssl embeds, show a placeholder/error message.
- Revise the way we return error messages.
See #28195, #28507.
Built from https://develop.svn.wordpress.org/trunk@28919


git-svn-id: http://core.svn.wordpress.org/trunk@28718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 05:49:16 +00:00
Sergey Biryukov 5f0b156155 Prevent bulk actions from being performed when Filter button is clicked. 
props jesin.
fixes #28555.
Built from https://develop.svn.wordpress.org/trunk@28916


git-svn-id: http://core.svn.wordpress.org/trunk@28715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 01:10:15 +00:00
Scott Taylor c8936195f6 Allow comments in the trash to marked as spam. 
Props mordauk.
Fixes #19256.

Built from https://develop.svn.wordpress.org/trunk@28913


git-svn-id: http://core.svn.wordpress.org/trunk@28712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 23:19:16 +00:00
Scott Taylor 0ef5c92164 Admin screens should use the `WPINC` constant 
Props wojtek.szkutnik
See #14157.

Built from https://develop.svn.wordpress.org/trunk@28906


git-svn-id: http://core.svn.wordpress.org/trunk@28705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:21:15 +00:00
Scott Taylor 3d0a869a21 `WP_Filesystem_Base->abspath()` should use the `WPINC` constant 
Props wojtek.szkutnik
See #14157.

Built from https://develop.svn.wordpress.org/trunk@28904


git-svn-id: http://core.svn.wordpress.org/trunk@28703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 22:16:15 +00:00
Sergey Biryukov 08cea559a5 Set date format before going into the loop to avoid a PHP notice if 'lastupdated' column is filtered out. 
props jeremyfelt.
fixes #27614.
Built from https://develop.svn.wordpress.org/trunk@28898


git-svn-id: http://core.svn.wordpress.org/trunk@28697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 18:11:14 +00:00
Sergey Biryukov ae0e22b61c Fix feature pointer positioning issues for both LTR and RTL. 
fixes #28062.
Built from https://develop.svn.wordpress.org/trunk@28897


git-svn-id: http://core.svn.wordpress.org/trunk@28696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 16:06:14 +00:00
John Blackbourn 548c41455a Remove the WordPress logo from the focusable elements on the install/update screens. Fixes #28674. Props stompweb 
Built from https://develop.svn.wordpress.org/trunk@28896


git-svn-id: http://core.svn.wordpress.org/trunk@28695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 14:10:15 +00:00
John Blackbourn 3f1c3dd4ca Normalise the schemes used in `get_home_path()` so it returns the correct path for sites using SSL in the admin area but not the front end. Fixes #25767. Props GregLone for the initial patch. 
Built from https://develop.svn.wordpress.org/trunk@28893


git-svn-id: http://core.svn.wordpress.org/trunk@28692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 10:29:14 +00:00
John Blackbourn 306dc7e646 Introduce a filter to control the minimum characters required for an AJAX term search. Fixes #13580. Props iamfriendly, brianlayman 
Built from https://develop.svn.wordpress.org/trunk@28892


git-svn-id: http://core.svn.wordpress.org/trunk@28691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 10:05:16 +00:00
Sergey Biryukov ff00c377ec Show a "No themes found" message if the search for an installed theme doesn't produce any results. 
props gauravmittal1995 for initial patch.
fixes #28587.
Built from https://develop.svn.wordpress.org/trunk@28890


git-svn-id: http://core.svn.wordpress.org/trunk@28689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 09:16:14 +00:00
Scott Taylor 9f1eb2b13e Add new action 'delete_user_form' in `wp-admin/users.php` and `wp-admin/network/users.php`. 
Props SergeyBiryukov, usermrpapa.
Fixes #27230.

Built from https://develop.svn.wordpress.org/trunk@28885


git-svn-id: http://core.svn.wordpress.org/trunk@28684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 04:43:16 +00:00
Helen Hou-Sandí 81f9d12b07 Make the posts list table mode a sticky user setting. props garyc40, azaozz, ericmann. fixes #16774, #20335. 
Built from https://develop.svn.wordpress.org/trunk@28876


git-svn-id: http://core.svn.wordpress.org/trunk@28675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 02:17:15 +00:00
Scott Taylor f09663f784 Remove remaining Heartbeat API experimental notices 
Props DH-Shredder.
Fixes #28626.

Built from https://develop.svn.wordpress.org/trunk@28872


git-svn-id: http://core.svn.wordpress.org/trunk@28672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-28 02:06:14 +00:00
Scott Taylor 650261b549 In deprecated media iframe code, `attachment_fields_to_save` filter should not be called twice after initial image upload in post. 
Props SergeyBiryukov.
Fixes #20720.

Built from https://develop.svn.wordpress.org/trunk@28871


git-svn-id: http://core.svn.wordpress.org/trunk@28671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-27 21:32:16 +00:00
Helen Hou-Sandí 831e5aa049 Don't switch contextual help tabs when tabbing around. props neil_pie. see #28209. 
Built from https://develop.svn.wordpress.org/trunk@28869


git-svn-id: http://core.svn.wordpress.org/trunk@28669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-27 19:10:16 +00:00
Sergey Biryukov 08332b50cb Avoid duplication of callbacks in theme browser sidebar each time the Next or Previous button is clicked. 
This makes the collapse/expand button work as expected.

fixes #28581.
Built from https://develop.svn.wordpress.org/trunk@28868


git-svn-id: http://core.svn.wordpress.org/trunk@28668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-27 16:06:15 +00:00
Dominik Schilling b7c93eb3d0 Customizer: Introduce a "panel" API to organize multiple sections into a one section. 
Create a panel via `$GLOBALS['wp_customize']->add_panel( $panel_id, $args )` and use `$panel_id` for the `panel` argument in `$GLOBALS['wp_customize']->add_section( $section_id, $args )`. That's it.
As an example all widget area sections are now summarized into one panel. Feedback appreciated.

props celloexpressions.
see #27406.
Built from https://develop.svn.wordpress.org/trunk@28861


git-svn-id: http://core.svn.wordpress.org/trunk@28662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 20:17:15 +00:00
Sergey Biryukov 1c227553b9 Fix unexpected replacement of a previous tag when selecting a tag from autosuggest results. 
props camdensegal.
fixes #28471.
Built from https://develop.svn.wordpress.org/trunk@28851


git-svn-id: http://core.svn.wordpress.org/trunk@28655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 16:08:14 +00:00
Helen Hou-Sandí fd1c4b7fed Slightly bump up the login logo size to avoid getting chopped off by Firefox's rounding problems. props SergeyBiryukov for the initial patch. fixes #28393. 
Built from https://develop.svn.wordpress.org/trunk@28850


git-svn-id: http://core.svn.wordpress.org/trunk@28654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 15:36:15 +00:00
Sergey Biryukov 901122689f Replace Y/m/d date format in general settings with a more popular one, Y-m-d. 
props gauravmittal1995.
fixes #28447.
Built from https://develop.svn.wordpress.org/trunk@28848


git-svn-id: http://core.svn.wordpress.org/trunk@28652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 14:29:17 +00:00
Andrew Ozz b9fd9db83b Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640. 
Built from https://develop.svn.wordpress.org/trunk@28847


git-svn-id: http://core.svn.wordpress.org/trunk@28651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 04:15:15 +00:00
Scott Taylor 9739b9b74d Only apply a subtle semi-transparent border to attachments that are images in the media list table. 
See [28842], #15860.


Built from https://develop.svn.wordpress.org/trunk@28843


git-svn-id: http://core.svn.wordpress.org/trunk@28647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 01:58:16 +00:00
Scott Taylor ec4934d66e Apply a subtle semi-transparent border to images in the media list table to avoid the "white on white (like a polar bear in Antarctica)" problem. 
Props ericlewis.
Fixes #15860.

Built from https://develop.svn.wordpress.org/trunk@28842


git-svn-id: http://core.svn.wordpress.org/trunk@28646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 01:52:15 +00:00
Scott Taylor 41ab39f42c In `media_buttons()`, add a static var `$instance` to increment the `id` attribute of `insert-media-button-%d` on each call. 
Props ericlewis.
Fixes #28090.

Built from https://develop.svn.wordpress.org/trunk@28837


git-svn-id: http://core.svn.wordpress.org/trunk@28641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 01:05:14 +00:00
Drew Jaynes add93833c3 Add braces missed while adding docs for the `option_page_capability_{$option_page}` hook. 
See [25372]. See #25229.

Built from https://develop.svn.wordpress.org/trunk@28833


git-svn-id: http://core.svn.wordpress.org/trunk@28637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-25 21:48:15 +00:00
Scott Taylor b650c4fb55 Bring the list of `upload_filetypes` for multisite into modernity based on .com upgrades and supported extensions for audio and video. 
Fixes #24434.

Built from https://develop.svn.wordpress.org/trunk@28832


git-svn-id: http://core.svn.wordpress.org/trunk@28636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-25 18:00:15 +00:00
Scott Taylor f907f0c57b The "old iframe media modal" has some pretty busted styles. Although this is a "deprecated" feature, clean up some of the broken styles. 
Props erayalakese for the JS patch.
Fixes #28220.


Built from https://develop.svn.wordpress.org/trunk@28830


git-svn-id: http://core.svn.wordpress.org/trunk@28634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-25 17:39:15 +00:00
Scott Taylor 543ad3cc91 Make the list of gallery attachments in the "old iframe media modal" break less. The "columns" are not aligned with the headers, but this would require a markup rewrite of a deprecated feature. 
Fixes #28098.


Built from https://develop.svn.wordpress.org/trunk@28829


git-svn-id: http://core.svn.wordpress.org/trunk@28633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-25 17:12:15 +00:00
Sergey Biryukov 124f1bc2f5 Add ISO date standard YYYY-MM-DD format to general settings. 
props mattheweppelsheimer.
fixes #28447.
Built from https://develop.svn.wordpress.org/trunk@28820


git-svn-id: http://core.svn.wordpress.org/trunk@28625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 09:50:14 +00:00
Scott Taylor 856e5ef55e Remove `noscript` from `wpautop()`'s list of block elements. 
Props mdawaffe.
Fixes #27268.

Built from https://develop.svn.wordpress.org/trunk@28817


git-svn-id: http://core.svn.wordpress.org/trunk@28624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:54:17 +00:00
Scott Taylor 317e5c9616 Adjust CSS for "Moved to the trash" message for a pingback in the dashboard. 
Props zoerooney, codenameEli.
Fixes #28286.

Built from https://develop.svn.wordpress.org/trunk@28811


git-svn-id: http://core.svn.wordpress.org/trunk@28619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:03:16 +00:00
Scott Taylor 396e77b643 Use unobtrusive JS for Comment list table row actions. 
Props aubreypwd.
Fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@28810


git-svn-id: http://core.svn.wordpress.org/trunk@28618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 23:55:16 +00:00
Sergey Biryukov 8b272f4379 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly. 
fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28808


git-svn-id: http://core.svn.wordpress.org/trunk@28617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 22:21:15 +00:00
Sergey Biryukov 9ceb642b2a Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata(). 
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28806


git-svn-id: http://core.svn.wordpress.org/trunk@28615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 14:48:14 +00:00
Scott Taylor 5357fecf1a Remove unused globals from `link-parse-opml.php` after [28743]. 
Props SergeyBiryukov.
Fixes #27881.

Built from https://develop.svn.wordpress.org/trunk@28786


git-svn-id: http://core.svn.wordpress.org/trunk@28599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-20 17:26:14 +00:00
Andrew Nacin a90a53d574 Narrower screen when choosing a language. see #28577. 
Built from https://develop.svn.wordpress.org/trunk@28780


git-svn-id: http://core.svn.wordpress.org/trunk@28593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 04:47:14 +00:00
Andrew Nacin 23de72f9e0 Fix variable usage in new language install choices. see #28577. 
Built from https://develop.svn.wordpress.org/trunk@28779


git-svn-id: http://core.svn.wordpress.org/trunk@28592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 04:37:15 +00:00
Helen Hou-Sandí 95deee2de5 Restore the ability to pass classes to admin menu submenu items, important for the Customize link. Accidentally left out in [24048]. fixes #28583. 
Built from https://develop.svn.wordpress.org/trunk@28778


git-svn-id: http://core.svn.wordpress.org/trunk@28591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 02:18:15 +00:00
Sergey Biryukov 1dd9c189e9 Fix copy/paste error in a comment. 
see #28581.
Built from https://develop.svn.wordpress.org/trunk@28777


git-svn-id: http://core.svn.wordpress.org/trunk@28590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 01:36:14 +00:00
Andrew Nacin c504fb41a1 Allow a language to be chosen before installing WordPress. First pass. 
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 

Built from https://develop.svn.wordpress.org/trunk@28774


git-svn-id: http://core.svn.wordpress.org/trunk@28587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 19:58:15 +00:00
Sergey Biryukov 5bd180bcbd Revert [28766]. 
see #28555.
Built from https://develop.svn.wordpress.org/trunk@28772


git-svn-id: http://core.svn.wordpress.org/trunk@28585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 02:23:13 +00:00
Sergey Biryukov d2a43e7cb2 Don't add # to URL when clicking 'OK' without changing the permalink. 
props avryl.
fixes #27594.
Built from https://develop.svn.wordpress.org/trunk@28771


git-svn-id: http://core.svn.wordpress.org/trunk@28584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 00:29:15 +00:00
Sergey Biryukov cd7618399e Prevent bulk actions from being performed when Filter button is clicked. 
props layotte.
fixes #28555.
Built from https://develop.svn.wordpress.org/trunk@28766


git-svn-id: http://core.svn.wordpress.org/trunk@28579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 22:17:14 +00:00
Sergey Biryukov c171f2ef77 Fix labels on installation screen. 
props avryl.
fixes #28548.
Built from https://develop.svn.wordpress.org/trunk@28759


git-svn-id: http://core.svn.wordpress.org/trunk@28572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 14:37:16 +00:00
Andrew Ozz 84f3e30f7b wpView: improve handling of embed errors/error messages, see #28195 
Built from https://develop.svn.wordpress.org/trunk@28754


git-svn-id: http://core.svn.wordpress.org/trunk@28568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-15 22:53:16 +00:00
Andrew Nacin aeac3e1654 Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This. 
fixes #28513.

Built from https://develop.svn.wordpress.org/trunk@28749


git-svn-id: http://core.svn.wordpress.org/trunk@28563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-12 18:09:13 +00:00
Scott Taylor 27523183bf Don't use variable variables in `touch_time()`. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28747


git-svn-id: http://core.svn.wordpress.org/trunk@28561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 21:05:16 +00:00
Scott Taylor 69fbe27f48 Don't use variable variables in `wp_reset_vars()`. Test by searching in list tables, etc. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28746


git-svn-id: http://core.svn.wordpress.org/trunk@28560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 20:00:15 +00:00
Scott Taylor 9a286d75fd Don't use variable variables in `user-new.php`. Test by causing errors when creating a new user. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28745


git-svn-id: http://core.svn.wordpress.org/trunk@28559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 19:54:13 +00:00
Scott Taylor fd838ccb2b Don't use variable variables in `setup-config.php` (Step 2). 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28744


git-svn-id: http://core.svn.wordpress.org/trunk@28558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 19:41:14 +00:00
Scott Taylor f014067f06 OPML: 
* Learn how OPML works, cry.
* Remove unused globals in `startElement()`
* Stop using variable variables in `startElement()`

Tested with the OPML importer plugin

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28743


git-svn-id: http://core.svn.wordpress.org/trunk@28557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 19:31:15 +00:00
Scott Taylor 812ea43343 Don't use variable variables in `wp_dashboard_plugins_output()`. Variable variables aren't the worst thing about this function. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28742


git-svn-id: http://core.svn.wordpress.org/trunk@28556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 18:55:14 +00:00
John Blackbourn eb62aecbc3 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt. 
Built from https://develop.svn.wordpress.org/trunk@28731


git-svn-id: http://core.svn.wordpress.org/trunk@28545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 19:15:13 +00:00
John Blackbourn 03131233e2 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein. 
Built from https://develop.svn.wordpress.org/trunk@28730


git-svn-id: http://core.svn.wordpress.org/trunk@28544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 18:50:14 +00:00
Scott Taylor 0da44fad8e `edit.php?post_type=attachment` should redirect to `upload.php`. Without the redirect, the user is presented with an empty list table. There are probably other issues to address overall, but this accomplishes what the ticket wants. 
Props knutsp.
Fixes #27951.

Built from https://develop.svn.wordpress.org/trunk@28729


git-svn-id: http://core.svn.wordpress.org/trunk@28543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 18:48:15 +00:00
Scott Taylor 05eeb16e30 Replace all uses of `like_escape()` with `$wpdb->esc_like()`. 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28712


git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:44:15 +00:00
Scott Taylor b964ac0148 Live update the menu item title when the user is editing the "Navigation Label" field. 
Props celloexpressions.
See #23076.

Built from https://develop.svn.wordpress.org/trunk@28707


git-svn-id: http://core.svn.wordpress.org/trunk@28523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-09 18:39:15 +00:00
Helen Hou-Sandí d558331e18 Properly indicate with the cursor that the editor can be vertically resized using the entire info bar, not just the handle displayed in the corner. 
props torresga. fixes #28420.

Built from https://develop.svn.wordpress.org/trunk@28703


git-svn-id: http://core.svn.wordpress.org/trunk@28520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-08 19:47:14 +00:00
Helen Hou-Sandí b5ef672c6b Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further. 
props ericlewis, shaunandrews, wonderboymusic.
see #24716.

Built from https://develop.svn.wordpress.org/trunk@28682


git-svn-id: http://core.svn.wordpress.org/trunk@28500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 22:01:18 +00:00
Sergey Biryukov 4b14fe0593 Remove one-time variable from add_settings_error(). 
props niallkennedy.
fixes #22228.
Built from https://develop.svn.wordpress.org/trunk@28681


git-svn-id: http://core.svn.wordpress.org/trunk@28499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 18:29:14 +00:00
Sergey Biryukov 26d0ad5e12 Remove redundant 'Visit author homepage' title attributes for plugins and themes. 
props joedolson.
fixes #26554.
Built from https://develop.svn.wordpress.org/trunk@28673


git-svn-id: http://core.svn.wordpress.org/trunk@28491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 04:52:16 +00:00
Drew Jaynes a6e536fba6 Make sure to use 3-digit x.x.x style for two 3.9.0 `@since` versions. 
Props netweb.
Fixes #28446.

Built from https://develop.svn.wordpress.org/trunk@28658


git-svn-id: http://core.svn.wordpress.org/trunk@28476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-04 05:35:16 +00:00
Drew Jaynes b0877f02a4 Make sure `$post` is properly documented as optional where applicable. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28653


git-svn-id: http://core.svn.wordpress.org/trunk@28471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 03:53:17 +00:00
Sergey Biryukov dc6b95589a Plugin activation/deletion errors should be styled as such. 
props johnbillion.
fixes #28260.
Built from https://develop.svn.wordpress.org/trunk@28646


git-svn-id: http://core.svn.wordpress.org/trunk@28464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-31 20:10:15 +00:00
Sergey Biryukov ee9d9133ac Avoid stomping of the $plugin variable in activate_plugin(). 
fixes #28102.
Built from https://develop.svn.wordpress.org/trunk@28644


git-svn-id: http://core.svn.wordpress.org/trunk@28462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 22:08:14 +00:00
Sergey Biryukov 66bfea485a Display the site scheme, not the current scheme on Edit Site screen in network admin. 
props johnbillion.
fixes #28406.
Built from https://develop.svn.wordpress.org/trunk@28643


git-svn-id: http://core.svn.wordpress.org/trunk@28461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 22:01:15 +00:00
Sergey Biryukov df597224e5 Add paragraph tags to 'Add Existing User' section on 'Add New User' screen in multisite. 
props jkudish, topher1kenobe.
fixes #20271.
Built from https://develop.svn.wordpress.org/trunk@28642


git-svn-id: http://core.svn.wordpress.org/trunk@28460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 21:51:14 +00:00
Scott Taylor ecdcfb55bb Make the image editor less jumpy when opening. 
Props eddiemoya, ericlewis.
Fixes #22793.


Built from https://develop.svn.wordpress.org/trunk@28639


git-svn-id: http://core.svn.wordpress.org/trunk@28457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 19:53:15 +00:00
Scott Taylor 9187e3bd55 Restore `$val` in `WP_Importer::bump_request_timeout()` - even though the parent class and `WP_Import` ignore the parameter, it creates an incompatible interface notice in the plugin. 
See [28629].


Built from https://develop.svn.wordpress.org/trunk@28637


git-svn-id: http://core.svn.wordpress.org/trunk@28455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 19:35:16 +00:00
Scott Taylor af860fbe84 Cleanup for `switch` statements: 
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.


Built from https://develop.svn.wordpress.org/trunk@28633


git-svn-id: http://core.svn.wordpress.org/trunk@28452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 17:58:15 +00:00
Drew Jaynes 1868c1fc4b Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php. 
Also add `@param` and `@return` descriptions.

See #28408.

Built from https://develop.svn.wordpress.org/trunk@28632


git-svn-id: http://core.svn.wordpress.org/trunk@28451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 17:38:14 +00:00
Scott Taylor c403768fa2 Remove some dead variable assignments. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28629


git-svn-id: http://core.svn.wordpress.org/trunk@28449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 16:59:14 +00:00
Andrew Ozz 15a1f80885 TinyMCE in iOS: 
- Fix placing the caret at the bottom of longer posts when the keyboard is open.
- Disable resizing on switching editors and on show/hide the kitchen sink row.
See #28242
Built from https://develop.svn.wordpress.org/trunk@28626


git-svn-id: http://core.svn.wordpress.org/trunk@28446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 02:38:16 +00:00
Helen Hou-Sandí 3f1deae10b Don't use the box shadow focus styling for the admin menu or toolbar. see #28267. 
Built from https://develop.svn.wordpress.org/trunk@28616


git-svn-id: http://core.svn.wordpress.org/trunk@28440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 14:23:15 +00:00
Helen Hou-Sandí ec121f9899 Better align link element focus with form focus styling, which also improves the visibility. props zamfeer. see #28267. 
Built from https://develop.svn.wordpress.org/trunk@28608


git-svn-id: http://core.svn.wordpress.org/trunk@28432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-29 03:58:14 +00:00
Sergey Biryukov 78a9cb855e Fix displaying taxonomies in bulk edit if the post type does not support titles. 
props scribu.
fixes #16793.
Built from https://develop.svn.wordpress.org/trunk@28600


git-svn-id: http://core.svn.wordpress.org/trunk@28425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 13:50:14 +00:00
Sergey Biryukov d3e6a5ded0 Remove obsolete code from wp_dashboard_setup(). 
props kitchin.
fixes #26604.
Built from https://develop.svn.wordpress.org/trunk@28592


git-svn-id: http://core.svn.wordpress.org/trunk@28417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 15:41:15 +00:00
Sergey Biryukov e94ee8f08c Move 'Documentation on date and time formatting' link under the 'Time Format' block. 
props gauravmittal1995.
fixes #28348.
Built from https://develop.svn.wordpress.org/trunk@28591


git-svn-id: http://core.svn.wordpress.org/trunk@28416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 14:50:14 +00:00
Sergey Biryukov 84422e6d7d Add BMP to the list of displayable image types. 
props ericlewis.
fixes #26808.
Built from https://develop.svn.wordpress.org/trunk@28589


git-svn-id: http://core.svn.wordpress.org/trunk@28414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 13:25:14 +00:00
Sergey Biryukov db9057f308 Remove redundant get_shortcode_regex() check. 
props kovshenin.
see #28195.
Built from https://develop.svn.wordpress.org/trunk@28587


git-svn-id: http://core.svn.wordpress.org/trunk@28412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 11:30:16 +00:00
Scott Taylor 3c1723afd7 When adding a URL in the `Insert from URL` state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields. 
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.

Built from https://develop.svn.wordpress.org/trunk@28581


git-svn-id: http://core.svn.wordpress.org/trunk@28406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:57:14 +00:00
Scott Taylor 89864b4a5a Don't pass embeds through `the_content()` when trying to render MCE previews, leverage `WP_Embed` and `do_shortcode()` instead. 
Props kovshenin.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28580


git-svn-id: http://core.svn.wordpress.org/trunk@28405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:43:15 +00:00
Scott Taylor 8b7b72d75e In `media_sideload_image()`, check the returned value of `download_url()` earlier to avoid attempting to `unlink()` an instance of `WP_Error`. 
Props georgestephanis. 
Fixes #28204.

Built from https://develop.svn.wordpress.org/trunk@28567


git-svn-id: http://core.svn.wordpress.org/trunk@28392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 21:33:14 +00:00
Scott Taylor 5b5b756edf In `get_terms_to_edit()`, call `get_object_term_cache()` before priming cache with `wp_get_object_terms()`. 
In `get_inline_data()`, do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.


Built from https://develop.svn.wordpress.org/trunk@28561


git-svn-id: http://core.svn.wordpress.org/trunk@28387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 19:29:14 +00:00
Scott Taylor 8d4d645629 Fix parsing in `wp_match_mime_types()` to allow some mime-types with `+` in them to appear in the list of filter links shown above the list table on `upload.php`. 
Props _duck.
Fixes #20672.


Built from https://develop.svn.wordpress.org/trunk@28553


git-svn-id: http://core.svn.wordpress.org/trunk@28379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 21:36:15 +00:00
Scott Taylor d22b5226a8 In `wp_dashboard_recent_posts()`, `$i` is set and never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28545


git-svn-id: http://core.svn.wordpress.org/trunk@28371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:56:15 +00:00
Scott Taylor 0e03abda62 `$theme_name` is set but no longer used in `wp_dashboard_right_now()`. The theme name is displayed with the call to `update_right_now_message()`. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28544


git-svn-id: http://core.svn.wordpress.org/trunk@28370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:54:13 +00:00
Scott Taylor b8d469600b These functions import `$wpdb` but do not use it. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28539


git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 17:37:14 +00:00
Sergey Biryukov 219321eedc Fix inconsistent header underlining and spacing in background update emails. 
fixes #28306.
Built from https://develop.svn.wordpress.org/trunk@28537


git-svn-id: http://core.svn.wordpress.org/trunk@28363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 09:41:15 +00:00
Sergey Biryukov 45d5e5d32f Use correct function name. 
props ericlewis.
fixes #28329.
Built from https://develop.svn.wordpress.org/trunk@28535


git-svn-id: http://core.svn.wordpress.org/trunk@28361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 07:59:16 +00:00
Scott Taylor 7de0b2b2c8 Upgrade `_WP_List_Table_Compat` to PHP5-style constructor. 
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28531


git-svn-id: http://core.svn.wordpress.org/trunk@28357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 17:20:17 +00:00
Scott Taylor 7415ae10a3 `hackificator` doesn't like mixed single/double-quoted attributes. These were 2 lingering instances in the admin. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28530


git-svn-id: http://core.svn.wordpress.org/trunk@28356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 17:10:15 +00:00
Scott Taylor 09ecc213c8 In `WP_Filesystem_Base`, the constructor is a noop, so it shouldn't even be declared. Setting it implies that `parent::__construct()` should be called by its subclasses. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28529


git-svn-id: http://core.svn.wordpress.org/trunk@28355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 16:46:14 +00:00
Scott Taylor 85f73cf458 Classes that have `__set()` also need `__isset()` and `__unset()`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28524


git-svn-id: http://core.svn.wordpress.org/trunk@28350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:52:14 +00:00
Scott Taylor 821246b4ae Some classes with `__get()` method also need `__set()`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28521


git-svn-id: http://core.svn.wordpress.org/trunk@28347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:31:15 +00:00
Scott Taylor dfa4de15fa Add missing access modifiers to methods/members in `Walker` and subclasses. Add a magic `__get()` method. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28514


git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:00:15 +00:00
Scott Taylor 2f513d3320 Fix some `hackificator` odds and ends in `wp-admin`: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:04:16 +00:00
Drew Jaynes 511eabe5f3 Improve inline documentation of default arguments for `post_format_meta_box()`, `post_tags_meta_box()`, and `post_categories_meta_box()`. 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@28499


git-svn-id: http://core.svn.wordpress.org/trunk@28325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 03:23:13 +00:00
Scott Taylor 130771a383 `hackificator` doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28497


git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:59:15 +00:00
Scott Taylor 1383990ae2 Add access modifier (`public`) to methods and members of `WP_Upgrader` and its subclasses. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28496


git-svn-id: http://core.svn.wordpress.org/trunk@28322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:29:15 +00:00
Scott Taylor 58ca85e106 Add access modifier (`public`) to methods and members of `WP_Upgrader_Skin` and its subclasses. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28495


git-svn-id: http://core.svn.wordpress.org/trunk@28321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:23:15 +00:00
Scott Taylor f090ff507d Add access modifiers to methods and members of `WP_Users_List_Table`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28494


git-svn-id: http://core.svn.wordpress.org/trunk@28320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:19:14 +00:00
Scott Taylor d28f6344de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28493


git-svn-id: http://core.svn.wordpress.org/trunk@28319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:17:15 +00:00
Scott Taylor 4e894f05f5 Add access modifier (`public`) to methods in `WP_Importer`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28492


git-svn-id: http://core.svn.wordpress.org/trunk@28318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:19:15 +00:00
Scott Taylor d5e35d187f Add access modifier (`public`) to members and methods in `WP_Filesystem_SSH2`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28491


git-svn-id: http://core.svn.wordpress.org/trunk@28317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:18:14 +00:00
Scott Taylor 41e1ecdfaf Add access modifier (`public`) to members and methods in `WP_Filesystem_ftpsockets`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28490


git-svn-id: http://core.svn.wordpress.org/trunk@28316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:14:14 +00:00
Scott Taylor 0dbc6b37a7 Add access modifier (`public`) to members and methods in `WP_Filesystem_FTPext`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28489


git-svn-id: http://core.svn.wordpress.org/trunk@28315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:12:15 +00:00
Scott Taylor eb750d0bd1 Add access modifier (`public`) to methods in `WP_Filesystem_Direct`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28488


git-svn-id: http://core.svn.wordpress.org/trunk@28314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:09:14 +00:00
Scott Taylor 7a378bc48f Add access modifiers to members and methods in `WP_Filesystem_Base`. Add magic `__get()` method for backwards compatibility. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28487


git-svn-id: http://core.svn.wordpress.org/trunk@28313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:06:14 +00:00
Scott Taylor e43e775c45 Add access modifier (`public`) to members and methods in `WP_Comments_List_Table` and `WP_Post_Comments_List_Table`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28486


git-svn-id: http://core.svn.wordpress.org/trunk@28312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 23:59:15 +00:00
Scott Taylor e917c14144 In `edit-link-form.php`, `hackificator` bails because there is a `</form>` with no open `<form>`. It exists, but is needlessly constructed with PHP. It always returns a `<form>`, only the `id` and `name` are different. The dynamic piece just returns the ID now. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28485


git-svn-id: http://core.svn.wordpress.org/trunk@28311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 22:07:15 +00:00
Scott Taylor a659275338 `hackificator` bails on this file because of mixed quote styles on some HTML attributes. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28484


git-svn-id: http://core.svn.wordpress.org/trunk@28310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 21:47:14 +00:00
Scott Taylor 6a765cdd03 Remove public keyword from some JS functions. Sorry. 
Props ocean90.
See #22234.


Built from https://develop.svn.wordpress.org/trunk@28483


git-svn-id: http://core.svn.wordpress.org/trunk@28309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 21:43:14 +00:00
Scott Taylor 68cfacf9ec `hackificator` bails on this file because the `<meta>` isn't self-closing. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28482


git-svn-id: http://core.svn.wordpress.org/trunk@28308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 21:36:15 +00:00
Scott Taylor 2e912d3108 Use proper access modifiers and add a magic `__get()` method to `Custom_Background` and `Custom_Image_Header`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28481


git-svn-id: http://core.svn.wordpress.org/trunk@28307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 21:31:16 +00:00
Scott Taylor b9afafffe3 `hackificator` complains if you call `include 'file.php'` without the parens, needs to be `include( 'file.php' )` 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28479


git-svn-id: http://core.svn.wordpress.org/trunk@28306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 20:52:15 +00:00
Scott Taylor 112ca4e055 Because the `WP_ADMIN` constant name can be bound in multiple files, all instances should check `! defined` first. `wp-admin/admin.php` already has this check. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28478


git-svn-id: http://core.svn.wordpress.org/trunk@28305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 20:42:16 +00:00
Scott Taylor fc23dc3551 The About page has a `<div>` that doesn't close. Also, `<hr>`s should self-close. `hackificator` complains about these things. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28477


git-svn-id: http://core.svn.wordpress.org/trunk@28304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 20:33:15 +00:00
Sergey Biryukov 8dacdb77be Fix wp_insert_link(), broken in [28406]/[28408]. 
see #22400.
Built from https://develop.svn.wordpress.org/trunk@28475


git-svn-id: http://core.svn.wordpress.org/trunk@28302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 09:56:15 +00:00
Drew Jaynes d75ca7aaaf Add inline documentation for default arguments in `wp_insert_category()`. 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@28474


git-svn-id: http://core.svn.wordpress.org/trunk@28301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 07:28:14 +00:00
Sergey Biryukov c453340a49 Update help text on Add Themes screen. 
props thomasvanderbeek.
fixes #28132.
Built from https://develop.svn.wordpress.org/trunk@28473


git-svn-id: http://core.svn.wordpress.org/trunk@28300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 23:44:15 +00:00
Scott Taylor 4ce9706db1 Add inline comment after fix in [28467]. 
Props jesin.
Fixes #28292.


Built from https://develop.svn.wordpress.org/trunk@28468


git-svn-id: http://core.svn.wordpress.org/trunk@28295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 15:42:14 +00:00
Scott Taylor bdd1ae2fc7 Restore `$soucrce` in `WP_Upgrader::install_package()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28467


git-svn-id: http://core.svn.wordpress.org/trunk@28294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 15:40:15 +00:00
Scott Taylor 8eb9f2ffe4 Eliminate use of `extract()` in `request_filesystem_credentials()`. 
The only property that doesn't need to be set to a variable is `$password`.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28456


git-svn-id: http://core.svn.wordpress.org/trunk@28283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:26:15 +00:00
Andrew Ozz f184243aa3 DFW: fix closing only the wpLink or media modal when pressing Esc. 
Built from https://develop.svn.wordpress.org/trunk@28455


git-svn-id: http://core.svn.wordpress.org/trunk@28282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:17:14 +00:00
Scott Taylor 39de969bf2 Update inline docs for `wp_handle_upload|sideload` to reflect their non-use of `extract()`. 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28452


git-svn-id: http://core.svn.wordpress.org/trunk@28279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 17:41:16 +00:00
Scott Taylor 632eb5b17e Eliminate use of `extract()` in `wp_handle_sideload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28451


git-svn-id: http://core.svn.wordpress.org/trunk@28278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 16:15:14 +00:00
Scott Taylor 4caf3e79f3 Eliminate use of `extract()` in `wp_handle_upload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28450


git-svn-id: http://core.svn.wordpress.org/trunk@28277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 16:10:38 +00:00
Sergey Biryukov abc830ca9d DFW: Properly handle Esc key when the content is focused or when switching browser tabs. 
props avryl.
fixes #28279.
Built from https://develop.svn.wordpress.org/trunk@28443


git-svn-id: http://core.svn.wordpress.org/trunk@28270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 10:43:14 +00:00
Scott Taylor b2d1e73fd5 Eliminate the use of `extract()` in `WP_Upgrader`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28418


git-svn-id: http://core.svn.wordpress.org/trunk@28245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:02:14 +00:00
Scott Taylor d74272ecf5 Eliminate one of the uses of `extract()` in `wp_handle_upload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28417


git-svn-id: http://core.svn.wordpress.org/trunk@28244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 04:31:14 +00:00
Scott Taylor fc59804352 Eliminate one of the uses of `extract()` in `wp_handle_sideload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28416


git-svn-id: http://core.svn.wordpress.org/trunk@28243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 04:29:15 +00:00
Scott Taylor a7a6cb5bef Eliminate use of `extract()` in `Walker_Category_Checklist::start_el()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28411


git-svn-id: http://core.svn.wordpress.org/trunk@28238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:14:14 +00:00
Scott Taylor 7ebab48f4c Eliminate use of `extract()` in `wp_terms_checklist()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28410


git-svn-id: http://core.svn.wordpress.org/trunk@28237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:09:15 +00:00
Scott Taylor a75f8137bc Eliminate use of `extract()` in `wp_star_rating()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28409


git-svn-id: http://core.svn.wordpress.org/trunk@28236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:57:14 +00:00
Scott Taylor ff665b2f38 (REALLY) Eliminate use of `extract()` in `wp_insert_link()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28408


git-svn-id: http://core.svn.wordpress.org/trunk@28235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:55:16 +00:00
Scott Taylor 54321f4c6e Eliminate use of `extract()` in `get_media_item()`. 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28407


git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:45:15 +00:00
Scott Taylor 5f06d0f50a Eliminate use of `extract()` in `wp_insert_link()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28406


git-svn-id: http://core.svn.wordpress.org/trunk@28233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:28:14 +00:00
Scott Taylor 1121efb54c Eliminate use of `extract()` in `display_setup_form()`. Only needs to read `password` and `password_message`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28396


git-svn-id: http://core.svn.wordpress.org/trunk@28224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-14 16:43:15 +00:00
Drew Jaynes a23cc5634f Properly split and document the `admin_post*` actions into the following four hooks: 
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action

See [28349], [28350], [28351].
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28394


git-svn-id: http://core.svn.wordpress.org/trunk@28222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 07:24:15 +00:00
Drew Jaynes 40a738c21c Clarify inline documentation for back-compat `load-*` action hooks. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28393


git-svn-id: http://core.svn.wordpress.org/trunk@28221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 06:28:15 +00:00
Scott Taylor fd9abeb0f9 Eliminate use of `extract()` in `post_tags_meta_box()` and `post_categories_meta_box()`. 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28391


git-svn-id: http://core.svn.wordpress.org/trunk@28219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:48:17 +00:00
Scott Taylor 9476cd33a3 Eliminate use of `extract()` in `WP_Terms_List_Table::display_rows_or_placeholder()`: 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28390


git-svn-id: http://core.svn.wordpress.org/trunk@28218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:37:14 +00:00
Scott Taylor aef35fe6a2 Eliminate use of `extract()` in `WP_List_Table::pagination()`: 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28389


git-svn-id: http://core.svn.wordpress.org/trunk@28217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:27:14 +00:00
Scott Taylor 530a107ec9 Eliminate use of `extract()` in `WP_Plugin_Install_List_Table::get_table_classes()`. It only needs to read `plural`, no need to extract. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28388


git-svn-id: http://core.svn.wordpress.org/trunk@28216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:17:14 +00:00
Scott Taylor 192e235672 Eliminate use of `extract()` in `WP_List_Table::ajax_response()`: 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28387


git-svn-id: http://core.svn.wordpress.org/trunk@28215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:14:14 +00:00
Scott Taylor 08d73b9e23 Eliminate use of `extract()` in `WP_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28386


git-svn-id: http://core.svn.wordpress.org/trunk@28214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:08:13 +00:00
Scott Taylor f617b8669a Eliminate use of `extract()` in `WP_Post_Comments_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28385


git-svn-id: http://core.svn.wordpress.org/trunk@28213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:04:14 +00:00
Scott Taylor 4c60b2e207 Eliminate use of `extract()` in `Custom_Image_Header::step_2()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28384


git-svn-id: http://core.svn.wordpress.org/trunk@28212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:54:14 +00:00
Drew Jaynes ec88da1ee3 Clarify documentation for *what* gets "automatically fired" when the `do_mu_upgrade` filter evaluates to true in Multisite. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28376


git-svn-id: http://core.svn.wordpress.org/trunk@28204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:18:14 +00:00
Drew Jaynes b4ca72583a Fix incomplete inline documentation for the `wp_header_image_attachment_metadata` filter. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28375


git-svn-id: http://core.svn.wordpress.org/trunk@28203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:13:15 +00:00
Scott Taylor 6bbc5b570c Eliminate use of `extract()` in `wp_insert_category()`. Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28374


git-svn-id: http://core.svn.wordpress.org/trunk@28202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 03:27:13 +00:00
Scott Taylor 2bea9fcc0b In `media_upload_gallery_form()`'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.


Built from https://develop.svn.wordpress.org/trunk@28368


git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:12:15 +00:00
Scott Taylor 88b96dc036 In `wp_read_image_metadata()`, the values from `exif_read_data()` should only override values from `iptcparse()` that are empty. 
Props SergeyBiryukov.
Fixes #23706.

Built from https://develop.svn.wordpress.org/trunk@28367


git-svn-id: http://core.svn.wordpress.org/trunk@28195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 05:54:15 +00:00
Scott Taylor e9f87b2688 Avoid a notice in `wp_save_image()` by checking `$meta['sizes']['thumbnail']` for `! empty()` before setting a variable to it. 
Props MikeHansenMe.
Fixes #17736.


Built from https://develop.svn.wordpress.org/trunk@28366


git-svn-id: http://core.svn.wordpress.org/trunk@28194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 03:42:14 +00:00
Scott Taylor 0b6729c3f9 In `WP_Terms_List_Table::single_row()`, call `sanitize_term()` on the passed term (`$tag`). 
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.

Built from https://develop.svn.wordpress.org/trunk@28360


git-svn-id: http://core.svn.wordpress.org/trunk@28188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:05:15 +00:00
Scott Taylor f22beb987c First pass at `wpview` logic for the `[embed]` shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28358


git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:36:18 +00:00
Drew Jaynes 81cfb9427a Fix mid-file section header style in wp-admin/includes/ajax-actions.php. 
See #28200.

Built from https://develop.svn.wordpress.org/trunk@28356


git-svn-id: http://core.svn.wordpress.org/trunk@28184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 05:02:13 +00:00
Drew Jaynes 0ef7244ce7 Add baseline doc blocks for all ajax handlers in ajax-actions.php. 
Fixes #28200.

Built from https://develop.svn.wordpress.org/trunk@28355


git-svn-id: http://core.svn.wordpress.org/trunk@28183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 05:00:19 +00:00
Drew Jaynes f609524261 Minor phpDoc fixes for the `got_rewrite`, `got_url_rewrite`, and `documentation_ignore_functions` hooks. 
Props GaryJ.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28352


git-svn-id: http://core.svn.wordpress.org/trunk@28180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 11:13:14 +00:00
Drew Jaynes c02696f43f Rename the `$action` hook in wp-admin/admin-post.php to `admin_post{$action}`. 
Also, clarify documentation of priv vs nopriv prefixing of the hook name.

See #26869.

Built from https://develop.svn.wordpress.org/trunk@28351


git-svn-id: http://core.svn.wordpress.org/trunk@28179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 11:00:15 +00:00
Drew Jaynes f427187fa8 Revert [28349] in favor of retaining the single dynamic `admin_post*` hook. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28350


git-svn-id: http://core.svn.wordpress.org/trunk@28178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 10:47:15 +00:00
Drew Jaynes a6755201d8 Convert and rename the `$action` hook in wp-admin/admin-post to two dynamic hook sets. 
* `admin_post_nopriv{$request_action}` is fired for logged-out users
* `admin_post{$request_action}` is fired for logged-in users

Props Otto42, DrewAPicture.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28349


git-svn-id: http://core.svn.wordpress.org/trunk@28177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 10:27:14 +00:00
Drew Jaynes 32e674f44e Use interpolation instead of concatenation for the `manage_{$screen->id}_columns` hook name. 
Props Otto42.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28348


git-svn-id: http://core.svn.wordpress.org/trunk@28176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 09:58:14 +00:00
Drew Jaynes 8906f83802 Use an interpolated hook name for `edit_{$post_type}_per_page` instead of `$per_page` and adjust docs accordingly. 
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.

Props Otto42 for the initial patch.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28347


git-svn-id: http://core.svn.wordpress.org/trunk@28175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 08:16:15 +00:00
Scott Taylor 1daa7d6723 Leverage `size_format()` when displaying `max_upload_size`: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.


Built from https://develop.svn.wordpress.org/trunk@28343


git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 18:25:14 +00:00
Scott Taylor 5f27d149a3 In `wp-admin/users.php`, `break` is unreachabled after `exit`. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28315


git-svn-id: http://core.svn.wordpress.org/trunk@28143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:19:14 +00:00
Scott Taylor 402d8b80fb In `core_upgrade_preamble()`, `$alternate` is set then never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28314


git-svn-id: http://core.svn.wordpress.org/trunk@28142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:17:18 +00:00
Scott Taylor e9bb9c0f12 In `wp-admin/theme-editor.php`, `break` is unreachabled after `exit`. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28313


git-svn-id: http://core.svn.wordpress.org/trunk@28141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:16:26 +00:00
Scott Taylor 517dbfaa21 In `wp-admin/post.php`, `break` is unreachabled after `exit`. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28312


git-svn-id: http://core.svn.wordpress.org/trunk@28140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:15:15 +00:00
Scott Taylor 327b38f298 In `wp-admin/plugins.php`, `break` is unreachabled after `exit`. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28311


git-svn-id: http://core.svn.wordpress.org/trunk@28139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:13:14 +00:00
Scott Taylor ac63c66c5a In `wp-admin/plugin-editor.php`, `break` is unreachabled after `exit`. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28310


git-svn-id: http://core.svn.wordpress.org/trunk@28138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:12:14 +00:00