383a5c6c24
In `wp-includes/plugin.php`, collapse 3 `else-newline-tab-if` statements.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31091
git-svn-id: http://core.svn.wordpress.org/trunk@31072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:13:24 +00:00
60b0cd7943
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31090
git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
a4ed093250
Enable Pretty Permalinks for new sites during install if the server supports it.
...
See #6481 , Props valendesigns, DrewAPicture & ericlewis
Built from https://develop.svn.wordpress.org/trunk@31089
git-svn-id: http://core.svn.wordpress.org/trunk@31070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:47:23 +00:00
bc4cd01190
In `wp-includes/taxonomy.php`:
...
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31087
git-svn-id: http://core.svn.wordpress.org/trunk@31068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:26:23 +00:00
29cd3fa5bf
PHP keywords and constants "true", "false", "null" should be in lower case - there was one lingering capitalized `false` in `_http_build_query()`.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31086
git-svn-id: http://core.svn.wordpress.org/trunk@31067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:14:23 +00:00
55fdfb529a
There is no need to use the `final` modifier inside a `final` class. Everything in it is `final` by default.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31085
git-svn-id: http://core.svn.wordpress.org/trunk@31066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:10:46 +00:00
905f35f289
In Customizer classes:
...
* `public final function` methods should be `final public function` - confusing Hack and aligns with PSR2
* Some methods were missing access modifiers
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31083
git-svn-id: http://core.svn.wordpress.org/trunk@31064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:02:24 +00:00
80915aaf16
`WP_Query->parse_tax_query()` - for BC, this method is not marked as protected. See [28987]. It needs an access modifier, it shall have `public`. The comment remains.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31081
git-svn-id: http://core.svn.wordpress.org/trunk@31062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:54:44 +00:00
ac4e67b82e
Perl-style comments should not be used
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31079
git-svn-id: http://core.svn.wordpress.org/trunk@31060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:52:24 +00:00
e029005847
Access Modifiers:
...
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31078
git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:44:23 +00:00
ff98cfcf45
Pinking Shears.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31077
git-svn-id: http://core.svn.wordpress.org/trunk@31058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:03:23 +00:00
9b0e279e82
In dashboard activity widget, display a front-end link if the user cannot edit the post.
...
props UaMV, DrewAPicture.
fixes #29025 .
Built from https://develop.svn.wordpress.org/trunk@31075
git-svn-id: http://core.svn.wordpress.org/trunk@31056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 00:26:22 +00:00
f2b5ac8ef1
Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices.
...
props ocean90.
fixes #30827 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31074
git-svn-id: http://core.svn.wordpress.org/trunk@31055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:43:24 +00:00
f601e45055
TinyMCE: Remove dashicon-no-alt.png, unused since [30694].
...
props kpdesign, MattyRob.
fixes #30791 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31073
git-svn-id: http://core.svn.wordpress.org/trunk@31054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:32:22 +00:00
da4a8f56f5
Theme install: Display an appropriate string if theme has not been rated yet.
...
props kevdotbadger, valendesigns.
fixes #28147 .
Built from https://develop.svn.wordpress.org/trunk@31072
git-svn-id: http://core.svn.wordpress.org/trunk@31053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:17:22 +00:00
3dcd0e2119
Add context for 'Previous' and 'Next' strings in get_the_posts_pagination().
...
fixes #30762 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31071
git-svn-id: http://core.svn.wordpress.org/trunk@31052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:07:22 +00:00
00ff6675a2
Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167 .
...
Built from https://develop.svn.wordpress.org/trunk@31070
git-svn-id: http://core.svn.wordpress.org/trunk@31051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 22:48:22 +00:00
23a5deba53
Customizer: Correctly display "Select" option in Navigation section dropdowns.
...
props kucrut.
fixes #30929 .
Built from https://develop.svn.wordpress.org/trunk@31069
git-svn-id: http://core.svn.wordpress.org/trunk@31050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 19:50:23 +00:00
833c148bb5
Dashicons: Fix typo in .dashicons-excerpt-view class.
...
props desrosj.
fixes #30832 .
Built from https://develop.svn.wordpress.org/trunk@31068
git-svn-id: http://core.svn.wordpress.org/trunk@31049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 09:02:23 +00:00
1c9e1836ac
Remove obsolete help sentence on Edit User screen.
...
fixes #30750 .
Built from https://develop.svn.wordpress.org/trunk@31067
git-svn-id: http://core.svn.wordpress.org/trunk@31048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 08:23:23 +00:00
7df3885d2e
Don't force newlines around URLs in WP_Embed::autoembed().
...
props chipx86, sgrant.
fixes #23776 .
Built from https://develop.svn.wordpress.org/trunk@31066
git-svn-id: http://core.svn.wordpress.org/trunk@31047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 07:51:22 +00:00
6299d3f617
Fix typo in a comment in slashing tests.
...
Built from https://develop.svn.wordpress.org/trunk@31065
git-svn-id: http://core.svn.wordpress.org/trunk@31046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 07:09:23 +00:00
c20f6afb05
Options: When updating options, make sure the user isn't trying to insert characters that aren't supported by the database character set.
...
See #30361 .
Built from https://develop.svn.wordpress.org/trunk@31064
git-svn-id: http://core.svn.wordpress.org/trunk@31045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 04:15:23 +00:00
727999d6fb
Add a description for the `$data` parameter in the DocBlock for the `customize_save_response` hook introduced in [31062].
...
Props westonruter.
Fixes #29098 .
Built from https://develop.svn.wordpress.org/trunk@31063
git-svn-id: http://core.svn.wordpress.org/trunk@31044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 01:48:24 +00:00
56981c7143
Customizer: Send JSON success for `customize_save` and allow response to be filtered.
...
props westonruter.
fixes #29098 .
Built from https://develop.svn.wordpress.org/trunk@31062
git-svn-id: http://core.svn.wordpress.org/trunk@31043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 21:47:23 +00:00
c6e7a90331
Autoprefixer for [31038].
...
see #30886 .
Built from https://develop.svn.wordpress.org/trunk@31061
git-svn-id: http://core.svn.wordpress.org/trunk@31042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 21:44:25 +00:00
e253251ef4
Remove space before comma in wp_notify_postauthor() and wp_notify_moderator().
...
see #30930 .
Built from https://develop.svn.wordpress.org/trunk@31060
git-svn-id: http://core.svn.wordpress.org/trunk@31041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 17:17:21 +00:00
71d255fde1
Remove padding from the comment notification emails in wp_notify_moderator().
...
See [30015] for wp_notify_postauthor().
props pavelevap.
fixes #30930 .
Built from https://develop.svn.wordpress.org/trunk@31059
git-svn-id: http://core.svn.wordpress.org/trunk@31040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 17:10:35 +00:00
7685e9dc97
Skip building the query in wp_count_posts() if cached results are used.
...
props MikeHansenMe.
fixes #30928 .
Built from https://develop.svn.wordpress.org/trunk@31058
git-svn-id: http://core.svn.wordpress.org/trunk@31039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 16:58:26 +00:00
da5b68a17e
Fix 'compare' parameter description in WP_Date_Query.
...
props dlh.
fixes #30925 .
Built from https://develop.svn.wordpress.org/trunk@31057
git-svn-id: http://core.svn.wordpress.org/trunk@31038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 03:36:21 +00:00
c2260dc85b
Remove obsolete inline comment.
...
props travisnorthcutt.
fixes #30924 .
Built from https://develop.svn.wordpress.org/trunk@31056
git-svn-id: http://core.svn.wordpress.org/trunk@31037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 01:57:22 +00:00
483e7a36d7
Use localized format for Last Updated date on Add Plugins screen.
...
props tyxla.
fixes #30717 .
Built from https://develop.svn.wordpress.org/trunk@31055
git-svn-id: http://core.svn.wordpress.org/trunk@31036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 01:03:23 +00:00
291de9cac1
Themes: Fix position of admin notice with .notice class.
...
fixes #30895 .
Built from https://develop.svn.wordpress.org/trunk@31054
git-svn-id: http://core.svn.wordpress.org/trunk@31035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 20:06:23 +00:00
1541bc1537
Pass comment author name and comment ID to 'get_comment_author_link' filter on Edit Comment screen, for consistency with [30092].
...
props tyxla.
fixes #30894 .
Built from https://develop.svn.wordpress.org/trunk@31053
git-svn-id: http://core.svn.wordpress.org/trunk@31034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 19:10:23 +00:00
e6a74136f9
`size_format()` incorrectly included a trailing space for `B` values: less than 1024 bytes.
...
Also add a unit test to check for this, so we don't do it again.
Fixes #30908 .
Props tillkruess.
Built from https://develop.svn.wordpress.org/trunk@31052
git-svn-id: http://core.svn.wordpress.org/trunk@31033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 13:13:23 +00:00
0e806f1695
WPDB: To ensure we're not asking MySQL to read data using queries that it can't handle, make sure that we run all read queries through the character set sanity checks.
...
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@31051
git-svn-id: http://core.svn.wordpress.org/trunk@31032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 04:40:22 +00:00
9704ee2a5c
WPDB Docs: Update the @since version from 4.1.0 to 4.2.0, for all the methods/members that were punted from 4.1.
...
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@31050
git-svn-id: http://core.svn.wordpress.org/trunk@31031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 03:51:22 +00:00
c975c8eeb0
Preinitialize WP_User::$data to an object in the event an empty user object is created. Avoids a "Creating default object from empty value" PHP Warning.
...
Fixes #28019
Built from https://develop.svn.wordpress.org/trunk@31049
git-svn-id: http://core.svn.wordpress.org/trunk@31030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 01:41:23 +00:00
05f1506d93
A couple more tweaks to the post-thumbnail-template.php description.
...
see #30867 .
Built from https://develop.svn.wordpress.org/trunk@31048
git-svn-id: http://core.svn.wordpress.org/trunk@31029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 23:10:21 +00:00
28c918e49c
Add tests for the 'post_status' behavior of `WP_Query`.
...
See #29167 .
Built from https://develop.svn.wordpress.org/trunk@31047
git-svn-id: http://core.svn.wordpress.org/trunk@31028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 20:36:22 +00:00
26436a4374
Remove non-built-in post statuses during each unit test teardown.
...
See #29167 .
Built from https://develop.svn.wordpress.org/trunk@31046
git-svn-id: http://core.svn.wordpress.org/trunk@31027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 20:06:26 +00:00
fb454239fb
In Media Views, use `this.listenTo( this.model, .... )` instead of `this.model.on( .... )` to fix garbage collection and to avoid "ghost views."
...
Fixes #30896 .
Built from https://develop.svn.wordpress.org/trunk@31045
git-svn-id: http://core.svn.wordpress.org/trunk@31026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 05:25:22 +00:00
be59efcfbf
ImageMagick expects TIFF files to have `.tiff` as an extension, so the key in `wp_get_mime_types()` should be `'tiff|tif'` not `'tif|tiff'` so the proper extension is returned in `WP_Image_Editor->get_extension()` subclass invocations.
...
Fixes #30211 .
Built from https://develop.svn.wordpress.org/trunk@31044
git-svn-id: http://core.svn.wordpress.org/trunk@31025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 03:09:22 +00:00
a9302b2e36
If `IMAGE_EDIT_OVERWRITE` is defined as `true`, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical).
...
Props hew.
Fixes #30394 .
Built from https://develop.svn.wordpress.org/trunk@31043
git-svn-id: http://core.svn.wordpress.org/trunk@31024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:52:24 +00:00
f79eb196df
Improve the handling of comma-separated mime-types in `wp_match_mime_types()`, particularly as pertains to the mime-type selector on the Media list table screen.
...
Props mdgl.
Fixes #30788 .
Built from https://develop.svn.wordpress.org/trunk@31042
git-svn-id: http://core.svn.wordpress.org/trunk@31023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:32:22 +00:00
ada7442b9e
After [31037], ensure that the library is passed as a map to the Media Grid instance. Remove useless query vars.
...
Fixes #30584 .
Built from https://develop.svn.wordpress.org/trunk@31041
git-svn-id: http://core.svn.wordpress.org/trunk@31022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:07:23 +00:00
de4d970d77
Preserve alpha transparency when rotating a PNG while GD is the active image editor.
...
Adds unit tests.
Props frankpw, voldemortensen.
Fixes #30596 .
Built from https://develop.svn.wordpress.org/trunk@31040
git-svn-id: http://core.svn.wordpress.org/trunk@31021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 22:02:24 +00:00
e678f9d051
In Media Grid, don't immediately load full size images if the requested size passed to `wp.media.view.Attachment.imageSize()` does not exist, look for other suitable sizes.
...
Fixes #30861 .
Built from https://develop.svn.wordpress.org/trunk@31039
git-svn-id: http://core.svn.wordpress.org/trunk@31020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 21:32:23 +00:00
a5cd4c0493
Fix spacing of `.compat-item .field` form widgets in media modal.
...
Props trepmal.
Fixes #30886 .
Built from https://develop.svn.wordpress.org/trunk@31038
git-svn-id: http://core.svn.wordpress.org/trunk@31019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 20:47:23 +00:00
c5f9a7c26a
Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library.
...
Fixes #30584 .
Built from https://develop.svn.wordpress.org/trunk@31037
git-svn-id: http://core.svn.wordpress.org/trunk@31018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 08:24:22 +00:00
Scott Taylor
Dion Hulse
Sergey Biryukov
Andrew Ozz
Gary Pendergast
Drew Jaynes
Dominik Schilling
Boone Gorges