Boone Gorges
b9e661dcae
Parse non-hierarchical tag input into term IDs before sending to `wp_insert_post()`.
...
When editing a post, non-hierarchical taxonomy terms are sent as the
comma-separated list entered into the tax_input metabox. Passing these
values directly to `wp_update_post()` meant that they were interpreted as
term slugs rather than term names, causing mismatches when a typed string
matched the slug of one term and the name of a different term. We fix the
problem by preprocessing tax_input data sent from post.php, converting it to
unambiguous term_ids before saving.
Props boonebgorges, ArminBraun.
Fixes #30615 .
Built from https://develop.svn.wordpress.org/trunk@31359
git-svn-id: http://core.svn.wordpress.org/trunk@31340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 20:32:22 +00:00
Boone Gorges
eec82f9330
In `get_sample_permalink()`, override 'future' status before generating permalink.
...
In [31114], `get_permalink()` was modified to prevent pretty permalinks from
being generated for posts with the 'future' post status. This inadvertently
broke the pretty permalink preview for scheduled posts. The fix is to include
the 'future' status in the list of statuses that `get_sample_permalink()` fakes
as 'publish' before it fetches a permalink.
Props DrewAPicture.
Fixes #30910 .
Built from https://develop.svn.wordpress.org/trunk@31323
git-svn-id: http://core.svn.wordpress.org/trunk@31304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-02 16:50:22 +00:00
Drew Jaynes
f3033f34c6
Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/post.php
...
Props ipm-frommen.
See #31008 .
Built from https://develop.svn.wordpress.org/trunk@31292
git-svn-id: http://core.svn.wordpress.org/trunk@31273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:32:22 +00:00
Scott Taylor
6704875855
Replace the 3 remaining occurrences of `wpspin` GIF with `spinner`.
...
Props avryl.
Fixes #27482 .
Built from https://develop.svn.wordpress.org/trunk@31187
git-svn-id: http://core.svn.wordpress.org/trunk@31168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 00:33:22 +00:00
Scott Taylor
c5f9a7c26a
Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library.
...
Fixes #30584 .
Built from https://develop.svn.wordpress.org/trunk@31037
git-svn-id: http://core.svn.wordpress.org/trunk@31018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 08:24:22 +00:00
Sergey Biryukov
0ef8e683f2
Revert [28948], which caused a regression.
...
see #29573 for trunk. see #28350 .
Built from https://develop.svn.wordpress.org/trunk@30791
git-svn-id: http://core.svn.wordpress.org/trunk@30781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 21:14:23 +00:00
Drew Jaynes
cc4ac906dc
Fix a typo in the return description for `get_sample_permalink()`.
...
Props TobiasBg.
Fixes #30591 .
Built from https://develop.svn.wordpress.org/trunk@30755
git-svn-id: http://core.svn.wordpress.org/trunk@30745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:46:23 +00:00
Drew Jaynes
23707b1ada
Convert various uses of `(optional)` in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP.
...
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.
Props coffee2code.
Fixes #30591 .
Built from https://develop.svn.wordpress.org/trunk@30753
git-svn-id: http://core.svn.wordpress.org/trunk@30743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:24:45 +00:00
Scott Taylor
2c32752abd
Improve various `@param` docs for `src/wp-admin/*`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30680
git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 01:00:22 +00:00
Drew Jaynes
78bb3e5ff5
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
...
Also adds a few inline `@see` cross-references as they apply.
Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`
See #30552 .
Built from https://develop.svn.wordpress.org/trunk@30648
git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:28:24 +00:00
Drew Jaynes
3ceb75bd8e
Specify a type (array) for the `$post_data` parameter in the DocBlock for `wp_autosave()`.
...
Props tillkruess.
See #30508 .
Built from https://develop.svn.wordpress.org/trunk@30645
git-svn-id: http://core.svn.wordpress.org/trunk@30635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 10:01:23 +00:00
Boone Gorges
c6e752b063
In `get_default_post_to_edit()`, let 'post_name' be passed to filter.
...
Previously, it was being overridden after the default post had been inserted
into the database, making it cumbersome to override with the 'wp_insert_post_data'
filter.
Props danielbachhuber.
Fixes #29847 .
Built from https://develop.svn.wordpress.org/trunk@30626
git-svn-id: http://core.svn.wordpress.org/trunk@30616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-29 19:26:23 +00:00
John Blackbourn
cd99d5915f
Decode the sample permalink shown to the user. This avoids showing encoded non-Latin characters in the sample permalink.
...
Fixes #16496
Props linuxologos
Built from https://develop.svn.wordpress.org/trunk@30364
git-svn-id: http://core.svn.wordpress.org/trunk@30363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 03:00:21 +00:00
Gary Pendergast
e61bebdbfc
If a saving a post fails, remove any invalid characters (such as emoji) from the primary text fields, then try to save it again.
...
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@30346
git-svn-id: http://core.svn.wordpress.org/trunk@30345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 21:34:22 +00:00
Scott Taylor
7d7a8aa0eb
Correct all `@return unknown` instances.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30202
git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:17:22 +00:00
Scott Taylor
64167f0845
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/post.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30198
git-svn-id: http://core.svn.wordpress.org/trunk@30198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:55:22 +00:00
Drew Jaynes
f8657d5890
Remove redundant and erroneous `@uses` tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
Built from https://develop.svn.wordpress.org/trunk@30105
git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
John Blackbourn
a866a7192f
Introduce some actions and filters which aid plugins in revisioning post meta.
...
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
* `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
* `wp_creating_autosave` action which is fired just before an autosave is created.
See #20564 .
Props mattheu, adamsilverstein.
Built from https://develop.svn.wordpress.org/trunk@30091
git-svn-id: http://core.svn.wordpress.org/trunk@30091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 19:02:21 +00:00
Drew Jaynes
f5cc9ba1be
Add a missing asterisk in the DocBlock for `write_post()`.
...
Also removes several `@uses` tags, which are no longer leveraged as part of the inline documentation standard.
Props tareq1988.
Fixes #30118 .
Built from https://develop.svn.wordpress.org/trunk@30034
git-svn-id: http://core.svn.wordpress.org/trunk@30034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-26 23:56:18 +00:00
Sergey Biryukov
2ff943b7b0
Restore the post type's view_item label for preview links that don't submit the changes.
...
fixes #28350 .
Built from https://develop.svn.wordpress.org/trunk@29695
git-svn-id: http://core.svn.wordpress.org/trunk@29470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 11:33:16 +00:00
Helen Hou-Sandí
9e8b9a78ca
Media library: Unify headers between view modes.
...
Includes back compat for `views_upload` links. These look a little awkward, but do not appear to be commonly used. Also prevents the view mode links from being dropped on smaller screens so a user doesn't get "stuck" in the list view.
This is different from other list tables, but aligns well with other uploaded content management screens (themes, plugins).
props pento, helen.
fixes #28946 .
Built from https://develop.svn.wordpress.org/trunk@29625
git-svn-id: http://core.svn.wordpress.org/trunk@29399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 15:58:15 +00:00
Drew Jaynes
097dc8ee15
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29206
git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Sergey Biryukov
4e75d406ec
Pass $post object to 'preview_post_link' filter.
...
props danielbachhuber.
fixes #28729 .
Built from https://develop.svn.wordpress.org/trunk@28969
git-svn-id: http://core.svn.wordpress.org/trunk@28758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 14:42:15 +00:00
Sergey Biryukov
27ba686eee
Simplify a condition in get_sample_permalink_html().
...
see #28350 .
Built from https://develop.svn.wordpress.org/trunk@28948
git-svn-id: http://core.svn.wordpress.org/trunk@28745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-02 00:11:15 +00:00
Sergey Biryukov
fc24029d65
Simplify logic in get_sample_permalink_html(), remove duplicated code.
...
see #28350 .
Built from https://develop.svn.wordpress.org/trunk@28947
git-svn-id: http://core.svn.wordpress.org/trunk@28744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-02 00:04:15 +00:00
Sergey Biryukov
16bb742b66
Display a correct preview link for drafts when permalinks are disabled.
...
see #28350 .
Built from https://develop.svn.wordpress.org/trunk@28946
git-svn-id: http://core.svn.wordpress.org/trunk@28743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-01 23:56:14 +00:00
Sergey Biryukov
8dcf86f94d
Display consistent preview links for drafts.
...
props mordauk.
fixes #28350 .
Built from https://develop.svn.wordpress.org/trunk@28920
git-svn-id: http://core.svn.wordpress.org/trunk@28719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-30 10:02:16 +00:00
Drew Jaynes
a6e536fba6
Make sure to use 3-digit x.x.x style for two 3.9.0 `@since` versions.
...
Props netweb.
Fixes #28446 .
Built from https://develop.svn.wordpress.org/trunk@28658
git-svn-id: http://core.svn.wordpress.org/trunk@28476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-04 05:35:16 +00:00
Scott Taylor
b8d469600b
These functions import `$wpdb` but do not use it.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28539
git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:37:14 +00:00
Scott Taylor
130771a383
`hackificator` doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28497
git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:59:15 +00:00
Drew Jaynes
8906f83802
Use an interpolated hook name for `edit_{$post_type}_per_page` instead of `$per_page` and adjust docs accordingly.
...
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.
Props Otto42 for the initial patch.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28347
git-svn-id: http://core.svn.wordpress.org/trunk@28175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 08:16:15 +00:00
Scott Taylor
2e417f0ca4
In `get_sample_permalink_html()`, `$view_link` is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28302
git-svn-id: http://core.svn.wordpress.org/trunk@28130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:11:14 +00:00
Andrew Nacin
cb4eb9c13f
Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
...
Reverts [27990] which did not fix it for authors and comment/ping status.
props dd32, DrewAPicture.
fixes #27792 .
Built from https://develop.svn.wordpress.org/trunk@28113
git-svn-id: http://core.svn.wordpress.org/trunk@27944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 07:48:14 +00:00
Andrew Nacin
2d710c6fad
Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
...
props kovshenin.
see [27964], see #27452 .
Built from https://develop.svn.wordpress.org/trunk@27990
git-svn-id: http://core.svn.wordpress.org/trunk@27820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 17:59:14 +00:00
Andrew Nacin
2f80a1c72f
Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation.
...
see #27452 .
Built from https://develop.svn.wordpress.org/trunk@27975
git-svn-id: http://core.svn.wordpress.org/trunk@27805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-06 22:08:15 +00:00
Andrew Nacin
1ec9b44673
Better checks for contributors when saving posts.
...
props dd32, kovshenin, plocha.
see #27452 .
Built from https://develop.svn.wordpress.org/trunk@27964
git-svn-id: http://core.svn.wordpress.org/trunk@27794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 21:19:14 +00:00
Scott Taylor
01d2062af3
Cleanup up the display, escaping, and handling of ID3 data for media. Rename `wp_get_relevant_id3_keys()` to `wp_get_attachment_id3_keys()`.
...
Props nacin.
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27869
git-svn-id: http://core.svn.wordpress.org/trunk@27700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 05:16:16 +00:00
Andrew Nacin
8acf74fe7b
Use correct formatting function. see [27864], see #27574 .
...
Built from https://develop.svn.wordpress.org/trunk@27866
git-svn-id: http://core.svn.wordpress.org/trunk@27697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 22:12:29 +00:00
Andrew Nacin
c95f232727
Cleanups for audio/video metadata, see [27862].
...
see #27574 .
Built from https://develop.svn.wordpress.org/trunk@27864
git-svn-id: http://core.svn.wordpress.org/trunk@27695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 21:08:14 +00:00
Scott Taylor
d947a55495
Metadata for audio and video files:
...
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27862
git-svn-id: http://core.svn.wordpress.org/trunk@27693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 19:28:16 +00:00
Scott Taylor
4eadc109f8
In `wp_create_post_autosave()`, intersect the `$new_autosave`'s keys with the keys from `_wp_post_revision_fields()` to ensure that all expected fields are present.
...
Props kovshenin.
Fixes #25416 .
Built from https://develop.svn.wordpress.org/trunk@27690
git-svn-id: http://core.svn.wordpress.org/trunk@27529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 20:32:14 +00:00
Drew Jaynes
155746131f
Inline documentation for hooks in wp-admin/includes/post.php.
...
Also moves the primary PHPDoc for the `edit_posts_per_page` hook to wp-admin/includes/post.php.
Props kpdesign for some cleanup.
Fixes #27431 .
Built from https://develop.svn.wordpress.org/trunk@27667
git-svn-id: http://core.svn.wordpress.org/trunk@27510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 01:49:14 +00:00
Andrew Nacin
ecab3c3535
Remove two new strings from post_preview().
...
see #25272 , #27453 .
Built from https://develop.svn.wordpress.org/trunk@27612
git-svn-id: http://core.svn.wordpress.org/trunk@27455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:49:14 +00:00
Andrew Nacin
064f3d7191
Improve the autosave error message on nonce failure.
...
see #27453 , #25272 .
Built from https://develop.svn.wordpress.org/trunk@27611
git-svn-id: http://core.svn.wordpress.org/trunk@27454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:47:22 +00:00
Andrew Nacin
b0188044a2
Heartbeat: Hooks should always receive unslashed data.
...
This affects the privileged hooks; the unprivileged hooks already received unslashed data.
props johnbillion, TobiasBg.
fixes #27260 .
Built from https://develop.svn.wordpress.org/trunk@27576
git-svn-id: http://core.svn.wordpress.org/trunk@27419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 00:15:15 +00:00
John Blackbourn
cc7f0b61ec
Correct the "View Post" button link when changing a post slug. Fixes #16477 . Props aubreypwd.
...
Built from https://develop.svn.wordpress.org/trunk@27508
git-svn-id: http://core.svn.wordpress.org/trunk@27351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 23:00:16 +00:00
Andrew Nacin
de769c267f
Editor: Show 'View Post' for any post the author can read.
...
This expands it to private posts and matches the logic in the toolbar.
props mordauk, SergeyBiryukov.
fixes #27059 .
Built from https://develop.svn.wordpress.org/trunk@27483
git-svn-id: http://core.svn.wordpress.org/trunk@27327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-09 13:53:14 +00:00
Andrew Nacin
39fcb291fe
Always convert auto-drafts to drafts in edit_draft() and _wp_translate_postdata().
...
This regressed due to refactoring in [26995]. This commit fixes Quick Draft.
see #25272 .
Built from https://develop.svn.wordpress.org/trunk@27405
git-svn-id: http://core.svn.wordpress.org/trunk@27252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 06:26:14 +00:00
Mark Jaquith
fb56a9942b
Eliminate some of our last remaining `create_function()` instances
...
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore
props obenland, markjaquith, nacin. fixes #14424
Built from https://develop.svn.wordpress.org/trunk@27373
git-svn-id: http://core.svn.wordpress.org/trunk@27222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 16:21:16 +00:00
Andrew Nacin
bf028ce1e3
Remove _relocate_children(), which has had no purpose for some time.
...
props SergeyBiryukov, scribu.
fixes #19367 .
Built from https://develop.svn.wordpress.org/trunk@27261
git-svn-id: http://core.svn.wordpress.org/trunk@27118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:10:14 +00:00