Commit Graph

20314 Commits

Author SHA1 Message Date
Andrew Nacin 33af30eb7f Use the regular post type UI for editing single media items (attachments).
* Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
 * Taxonomies attached to the media library now appear in the admin menu (if show_ui).
 * Editing, cropping, uploading, etc. is still very rough, but mostly functional.

API-wise:
 * New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
 * Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
 * wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
 * New edit_form_after_title hook.

props helenyhou, ocean90. see #21391.



git-svn-id: http://core.svn.wordpress.org/trunk@21948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 22:52:54 +00:00
Andrew Nacin ffaa2d0330 Revert JS from [21921] as it breaks saving when no post date fields are present. see #17180.
git-svn-id: http://core.svn.wordpress.org/trunk@21947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 22:27:51 +00:00
Peter Westwood 8b9ab93511 Export: Ignore auto-drafts when building the list of users for the export file. Fixes #21960.
git-svn-id: http://core.svn.wordpress.org/trunk@21946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 21:48:52 +00:00
Andrew Nacin 51326aaf91 Reset $taxonomy in single_row's default branch. props tott. fixes #21240.
git-svn-id: http://core.svn.wordpress.org/trunk@21945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 20:28:25 +00:00
Andrew Nacin c1b0670c2d Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598.
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 19:34:23 +00:00
Andrew Nacin 5a362d3ace Call clean_post_cache() in wp_insert_post() after the manual query to change GUID. Remove the second call to clean_post_cache() previously done on the save_post hook. see #11399.
git-svn-id: http://core.svn.wordpress.org/trunk@21943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 18:52:15 +00:00
Andrew Nacin a4831c82f0 Have wp_publish_post() wrap wp_insert_post() directly. see #11399.
git-svn-id: http://core.svn.wordpress.org/trunk@21942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 18:49:45 +00:00
Lance Willett b3f0c192d3 Twenty Twelve: change author template markup to use classes instead of IDs, fixes #21937.
git-svn-id: http://core.svn.wordpress.org/trunk@21941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 16:39:38 +00:00
Ryan Boren ba84c90e1b Allow remove_cap() to unset a negative capability. Props johnjamesjacoby. fixes #21786
git-svn-id: http://core.svn.wordpress.org/trunk@21940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 13:41:43 +00:00
Ryan Boren df21fa1cc6 Pass a term object to the delete_term actions. Props bigdawggi. fixes #20645
git-svn-id: http://core.svn.wordpress.org/trunk@21939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 13:27:56 +00:00
Ryan Boren 6b0b49c65b Update comment_parent in wp_update_comment(). Props JustinSainton. fixes #21706
git-svn-id: http://core.svn.wordpress.org/trunk@21938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 12:57:26 +00:00
Ryan Boren a8fa7b3ad2 Honor https in home option.
fixes #20759


git-svn-id: http://core.svn.wordpress.org/trunk@21937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 12:36:50 +00:00
Peter Westwood 2fcdb3395d XMLRPC: Support searching via wp.getPosts() fixes #21623 props ericmann.
git-svn-id: http://core.svn.wordpress.org/trunk@21936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 10:18:32 +00:00
Peter Westwood d8e08eb3c2 Widgets: Add support for display the post date in the Recent Posts widget. Fixes #21064 props lancewillett and SergeyBiryukov.
git-svn-id: http://core.svn.wordpress.org/trunk@21935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 10:05:54 +00:00
Andrew Nacin 5f2946ba42 Remove ui.css from WP's TinyMCE theme. It was left for back compat with a reference to editor-buttons.css, which was never updated to editor.css and no one noticed.
git-svn-id: http://core.svn.wordpress.org/trunk@21934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 03:13:19 +00:00
Lance Willett 6d132acb80 Twenty Twelve: rework markup and styles for status post format after discussion with drewstrojny and testing for float clearing. Closes #21743.
git-svn-id: http://core.svn.wordpress.org/trunk@21933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 21:51:48 +00:00
Lance Willett 3854197ba8 Twenty Twelve: update status post format styles and markup, props drewstrojny. See #21743.
git-svn-id: http://core.svn.wordpress.org/trunk@21932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 19:42:19 +00:00
Bot (Assets) 5e9365fc54 Compress scripts/styles: 3.5-alpha-21931.
git-svn-id: http://core.svn.wordpress.org/trunk@21931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 18:59:45 +00:00
Lance Willett 45a36f5fc0 Twenty Twelve: remove duplicate font-size rules, defined already for list items in this context.
git-svn-id: http://core.svn.wordpress.org/trunk@21930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 16:33:40 +00:00
Lance Willett e538b8c697 Twenty Twelve: update navigation script to check for missing button and menu children earlier; allows an empty menu to be set without showing the button. See #21678.
git-svn-id: http://core.svn.wordpress.org/trunk@21929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 16:28:27 +00:00
Ryan Boren 2b044bc85f * Avoid FOUND ROWS when no posts are found
* Set post_count and found_posts for all 'fields' queries.
* Set found_posts to post_count when limits are not used
* Update phpdoc for $found_posts and set_found_posts()

Props SergeyBiryukov, wonderboymusic

fixes #14426



git-svn-id: http://core.svn.wordpress.org/trunk@21928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 14:55:54 +00:00
Ryan Boren 75a9ce4b37 Remove unnecessary label. Props waclawjacek. fixes #17978
git-svn-id: http://core.svn.wordpress.org/trunk@21927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 13:59:39 +00:00
Ryan Boren d422b1e475 phpdoc cleanups for general-template.php. Props c3mdigital, SergeyBiryukov. fixes #21893
git-svn-id: http://core.svn.wordpress.org/trunk@21926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 13:52:36 +00:00
Ryan Boren 9e9d4ebd50 Allow granting the network admin email user super admin. Props JustinSainton, garyc40. fixes #16629
git-svn-id: http://core.svn.wordpress.org/trunk@21925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 13:50:35 +00:00
Ryan Boren 1513f1daea Suppress db errors when checking if the blog is already installed in install_blog(). Use DESCRIBE instead of SELECT. Props bpetty. fixes #21922
git-svn-id: http://core.svn.wordpress.org/trunk@21924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 13:39:46 +00:00
Peter Westwood e1b861e1cb Passwords: Make it possible for plugins to enforce extra password strength / validity rules during the reset process.
Adds a filter in the password reset process so that a plugin can enforce particular password rules on users to compliment the existing filtering in the Profile modification process.
Fixes #21778.


git-svn-id: http://core.svn.wordpress.org/trunk@21923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 11:01:29 +00:00
Peter Westwood fa8a509ff3 Posting: Improve the invalid date protection code based on feedback from nacin.
* Introduce a wp_checkdate() function with a single filter to centralise the code that validates dates.
 * Improve the error message
 * Correctly handle the return value of wp_insert_post which is not always a WP_Error on failure

Fixes #17180


git-svn-id: http://core.svn.wordpress.org/trunk@21922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 10:46:50 +00:00
Peter Westwood c05f6dc6dd Posting: Make it much harder to create posts with invalid dates by enforcing the post date tests in the UI and the backend code.
Previously you could quite easily send a new post into the back of beyond by specifying an invalid date like the 30th Feb and this was very confusing.
Sometimes it would seem to work and sometimes the post would end up very far in the past - depending on the mysql version and other factors.

Fixes #17180 props jkudish.


git-svn-id: http://core.svn.wordpress.org/trunk@21921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 21:43:35 +00:00
Bot (Assets) fabcc374fd Compress scripts/styles: 3.5-alpha-21920.
git-svn-id: http://core.svn.wordpress.org/trunk@21920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 18:59:36 +00:00
Ryan Boren ce9a613cb6 Improve performance of query in get_adjacent_post(). Get the ID and then call get_post(). Props apokalyptik, nacin, javert03. fixes #18120
git-svn-id: http://core.svn.wordpress.org/trunk@21919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 18:11:43 +00:00
Lance Willett 71fea496e8 Twenty Twelve: remove overflow rule from wrapper element to allow image styles to spill out into margins. Fixes #21926. See also #21381.
git-svn-id: http://core.svn.wordpress.org/trunk@21918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 17:38:30 +00:00
Andrew Nacin 52320dc5b3 It is 'Alternative Text', not 'Alternate Text'. props alecrust, RyanJKoehler. fixes #21176.
git-svn-id: http://core.svn.wordpress.org/trunk@21917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 16:55:43 +00:00
Andrew Nacin ef6148ba7e Flexible widths for select boxes above list tables. For posts, that means bulk actions and date/category filters. Opens up more room (can prevent wrapping) and allows for longer localized strings. props SergeyBiryukov, fixes #21752.
git-svn-id: http://core.svn.wordpress.org/trunk@21916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 15:44:01 +00:00
Ryan Boren 635d243951 Handle https for all oembed providers. Props johnjamesjacoby, gluten. fixes #20102
git-svn-id: http://core.svn.wordpress.org/trunk@21915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 13:46:05 +00:00
Ryan Boren a3cfe28527 Reduce reliance on global variables in the list tables. Allow passing a screen ID to the list tables so that ajax handlers can set the needed screen.
Props nacin
fixes #21871


git-svn-id: http://core.svn.wordpress.org/trunk@21914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 12:43:31 +00:00
Andrew Nacin bee6374953 Send nocache_headers() in the admin earlier, on the DB upgrade page. Prevents a potential redirect loop reproduced in Chrome from heavy caching of headers. props mdawaffe. see #21745.
git-svn-id: http://core.svn.wordpress.org/trunk@21913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 01:51:40 +00:00
Andrew Nacin bf3c8017a8 Introduce the xmlrpc_login_error filter, applied to the IXR_Error being returned by the server when login() fails. props JustinSainton, fixes #21907.
git-svn-id: http://core.svn.wordpress.org/trunk@21912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 01:36:47 +00:00
Andrew Nacin 1f9ce958f7 Deprecate user_pass_ok() in favor of wp_authenticate(). see #21907.
git-svn-id: http://core.svn.wordpress.org/trunk@21911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 01:35:35 +00:00
Andrew Nacin c178b59da3 XML-RPC: Have the deprecated login_pass_ok() method wrap login(). Move it below login() so the proper method is found first. see #21907.
git-svn-id: http://core.svn.wordpress.org/trunk@21910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 01:27:21 +00:00
Daryl Koopersmith f7ae81b15d Rename the attachment-thumbnail class in the media modal Attachment view to prevent conflicts with wp_get_attachment_image(). see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@21909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 01:10:17 +00:00
Daryl Koopersmith 2f4a7a42b7 Media JS: Prevent infinite scroll events from being unbound when Attachments views are re-rendered. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@21908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 01:00:34 +00:00
Daryl Koopersmith 1851f98eb9 Correct alignment of new buttons in media modal. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@21907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 00:48:41 +00:00
Daryl Koopersmith 3ec7265074 The first inklings of a gallery management screen.
* Adds `view.Workspace.Library` and `view.Workspace.Gallery` as extensions of `view.Workspace` to implement the individual screens
* Shifts the toolbar logic that was library-specific from the generic `Workspace` view to `Workspace.Library`.
* Adds a toolbar to the `Gallery` view.
* 'Create a gallery' and 'Return to media library' buttons toggle between the two views.
* 'Insert gallery into post' closes the modal, but does not actually perform its namesake action.
* Note that elements can still be deselected in the gallery view. This will be fixed in a future commit.

Improvements to avoid over-eager event unbinding:
* `Modal` views now properly detach their contents before replacing them with a new element.
* Likewise, `Workspace` views detach their main content blocks when re-rendering the view.

To test the gallery workflow (which is incomplete), run the following in your browser's console:

	`wp.media({ multiple: true });`

see #21809, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@21906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 00:34:00 +00:00
Andrew Nacin 2d1eae820f Avoid mangling UTF-8 strings that may be present in image metadata. props SergeyBiryukov for the unit tests [UT665]. fixes #9417.
git-svn-id: http://core.svn.wordpress.org/trunk@21905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 23:38:25 +00:00
Andrew Nacin 4185cade6d Stop outputting the default dir="ltr" in language_attributes(). props bergius. fixes #16852.
git-svn-id: http://core.svn.wordpress.org/trunk@21904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 23:08:46 +00:00
Andrew Nacin 087b6ace16 Remove unused edit-site nonce fields from site-users and site-themes. props jeremyfelt, fixes #21277.
git-svn-id: http://core.svn.wordpress.org/trunk@21903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 23:06:22 +00:00
Daryl Koopersmith 80e443d0df Media JS: Improve auto-add functionality in Workspace.render(). see #21390, [21901].
git-svn-id: http://core.svn.wordpress.org/trunk@21902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 22:59:57 +00:00
Daryl Koopersmith a9ca915252 Media JS: Improve signature for `Workspace.add()` to accept two arguments instead of an ambiguous object. see #21390, [21820], [21821].
git-svn-id: http://core.svn.wordpress.org/trunk@21901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 22:41:51 +00:00
Daryl Koopersmith 751ecf9fd5 Ensure the Attachments model properties are correctly set for Query collections.
After shifting sorting and searching logic from the `Query` collection in [21898], it became apparent that `Query` collections should also have an accurate `props` model, as the model controls the aforementioned searching and sorting.

see #21921, #21809, and #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@21900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 22:19:05 +00:00
Bot (Assets) 9481b4ae89 Compress scripts/styles: 3.5-alpha-21899.
git-svn-id: http://core.svn.wordpress.org/trunk@21899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 21:59:34 +00:00