9891448a42
Media: Rename several attachment related parameters from `$post_id` to `$attachment_id` for clarity, and improve related
...
documentation.
See #41017
Built from https://develop.svn.wordpress.org/trunk@41288
git-svn-id: http://core.svn.wordpress.org/trunk@41128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-22 11:12:44 +00:00
c080c0a2ea
Introduce `paged` argument to `WP_Comment_Query`.
...
Using `paged` with `number` allows developers to request
paginated comment results without having to do a manual offset
calculation.
Props AdamWills.
Fixes #38268 .
Built from https://develop.svn.wordpress.org/trunk@41287
git-svn-id: http://core.svn.wordpress.org/trunk@41127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-21 15:35:46 +00:00
1770cc7b87
Docs: Fix a typo in the DocBlock description for `add_shortcode()` introduced in [41281].
...
Props grapplerulrich.
See #37222 .
Built from https://develop.svn.wordpress.org/trunk@41286
git-svn-id: http://core.svn.wordpress.org/trunk@41126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 20:38:42 +00:00
0eecbf8baf
Docs: Clarify that `get_comments_number()` can return either a numeric string (for compatibility reasons) or 0 if the post doesn't exist.
...
Also update the hook doc for the `get_comments_number` filter to reflect the mixed type for `$count`.
Props kiranpotphode for the initial patch.
Fixes #38369 .
Built from https://develop.svn.wordpress.org/trunk@41285
git-svn-id: http://core.svn.wordpress.org/trunk@41125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 20:13:47 +00:00
f94c77661d
Docs: Improve the return description for `get_post_format_slugs()` to note that the array contains slugs as both keys and values.
...
Props danielbachhuber.
Fixes #38611 .
Built from https://develop.svn.wordpress.org/trunk@41284
git-svn-id: http://core.svn.wordpress.org/trunk@41124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 20:03:54 +00:00
15373a020d
Docs: Clarify that the second parameter passed to a shortcode callback is the shortcode content or null, rather than the content the shortcode was found in.
...
See #37222 .
Built from https://develop.svn.wordpress.org/trunk@41283
git-svn-id: http://core.svn.wordpress.org/trunk@41123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 19:56:45 +00:00
b2b6f48127
Shortcodes: Rename the `$func` parameter for `add_shortcode()` to `$callback` to improve clarity.
...
See #37222 . See #41017 .
Built from https://develop.svn.wordpress.org/trunk@41282
git-svn-id: http://core.svn.wordpress.org/trunk@41122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 19:48:45 +00:00
33997cc66c
Docs: Improve documentation for `add_shortcode()` by:
...
* Removing inline examples already listed in the Code Reference
* Improving the summary and description to explain how tag conflicts are handled
* Supplement the docs for the `$func` parameter by describing the three arguments passed to a shortcode callback.
Props grapplerulrich for the initial patch.
Fixes #37222 .
Built from https://develop.svn.wordpress.org/trunk@41281
git-svn-id: http://core.svn.wordpress.org/trunk@41121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 19:44:42 +00:00
abf8e91521
Docs: Add a note to the `register_taxonomy()` DocBlock that the object types defined in `$object_type` when modifying an already-registered taxonomy will be overwritten.
...
Props danielbachhuber and BjornW for the initial patches.
Fixes #34413 .
Built from https://develop.svn.wordpress.org/trunk@41280
git-svn-id: http://core.svn.wordpress.org/trunk@41120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 19:23:47 +00:00
bc15cff6f4
Build/Test tools: Revert [41278] because the PHP 5.2 environment on Travis doesn't support OpenSSL, hence the tests fail.
...
See #41676
Built from https://develop.svn.wordpress.org/trunk@41279
git-svn-id: http://core.svn.wordpress.org/trunk@41119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 12:59:43 +00:00
33570415d1
Build/Test tools: Don't skip tests which rely on OpenSSL when the `openssl` extension isn't loaded.
...
See #41676
Built from https://develop.svn.wordpress.org/trunk@41278
git-svn-id: http://core.svn.wordpress.org/trunk@41118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 12:31:43 +00:00
eccf27c514
Build/Test Tools: Remove unneeded commas to fix JSHint error introduced
...
in [41271].
See #30666 .
Built from https://develop.svn.wordpress.org/trunk@41277
git-svn-id: http://core.svn.wordpress.org/trunk@41117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 09:13:44 +00:00
ffa7e7d4ab
Docs: Improve the usefulness and accuracy of the file header for wp-cron.php.
...
Props stevenlinx for the initial patch.
Fixes #31401 .
Built from https://develop.svn.wordpress.org/trunk@41276
git-svn-id: http://core.svn.wordpress.org/trunk@41116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 04:37:45 +00:00
78da113bd0
Docs: Add a missing return description for the deprecated `get_screen_icon()` function.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@41275
git-svn-id: http://core.svn.wordpress.org/trunk@41115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 04:04:44 +00:00
510fb1fe85
Administration: Explicitly deprecate `screen_icon()` and `get_screen_icon()`, which were soft-deprecated in [26537] for 3.8.0.
...
Props ippei-sumida for the initial patch.
Fixes #41153 .
Built from https://develop.svn.wordpress.org/trunk@41274
git-svn-id: http://core.svn.wordpress.org/trunk@41114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 04:03:45 +00:00
a1ceeba8ac
Docs: Explicitly deprecate the `add_tab()`, `remove_tab()`, and `print_tab_image()` methods for `WP_Customize_Image_Control`, originally soft-deprecated in 4.1.
...
Props jrf.
See #41121 .
Built from https://develop.svn.wordpress.org/trunk@41273
git-svn-id: http://core.svn.wordpress.org/trunk@41113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-20 03:38:46 +00:00
d2b78649a2
Docs: Document user object parameters for a variety of functions in wp-includes/user.php as `WP_User` type instead of the more generic `object` type.
...
Props sebastianpisula.
Fixes #40945 .
Built from https://develop.svn.wordpress.org/trunk@41272
git-svn-id: http://core.svn.wordpress.org/trunk@41112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-19 20:19:44 +00:00
7f7d4ef451
Build/Test Tools: Add banner to minified CSS files
...
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto generated.
Props drewapicture, samuelsidler, netweb, valendesigns, kpdesign, nacin, jorbin
Fixes #30666
Built from https://develop.svn.wordpress.org/trunk@41271
git-svn-id: http://core.svn.wordpress.org/trunk@41111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-19 20:10:47 +00:00
2916cd9417
Media: bring the capability check in `wp_ajax_crop_image()` inline with those in `wp_ajax_imgedit_preview()` and `wp_ajax_image_editor()`.
...
This change means that a user can crop an image if they have the ability to edit its attachment post, without requiring the ability to access the Customizer.
Fixes #40193
Built from https://develop.svn.wordpress.org/trunk@41270
git-svn-id: http://core.svn.wordpress.org/trunk@41110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-19 13:30:43 +00:00
755a926b65
Multisite: Use correct capability for the Updates page in the network admin.
...
A user should not be required to have the `update_core` capability to access the Updates page. Having one of the update capabilities for core, plugins, themes and languages should be sufficient.
Fixes #41538 .
Built from https://develop.svn.wordpress.org/trunk@41269
git-svn-id: http://core.svn.wordpress.org/trunk@41109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-19 10:39:44 +00:00
f6ebc1a80c
Role/Capability: Introduce capabilities dedicated to installing and updating language files.
...
The new meta capabilities are called `install_languages` and `update_languages`. Prior to this change, there were no proper capability checks applied. Instead only the filesystem and related constants were checked, and for actual permissions a rather vague fallback was used where a user needed to have at least one of the other updating capabilities. In addition to being generally more verbose, the new capabilities make it possible for example to allow a user to update languages, but nothing else. By default they fall back to the original way of how they were handled.
Props johnbillion, flixos90.
Fixes #39677 .
Built from https://develop.svn.wordpress.org/trunk@41268
git-svn-id: http://core.svn.wordpress.org/trunk@41108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-18 18:31:44 +00:00
c14e0a0527
Post Thumbnails: Pass post ID to `post_thumbnail_size` filter.
...
In addition to the enhancement, tests for the filter usage including the new parameter have been added.
Props NathanAtmoz.
Fixes #39030 .
Built from https://develop.svn.wordpress.org/trunk@41267
git-svn-id: http://core.svn.wordpress.org/trunk@41107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-18 18:19:44 +00:00
7414759f92
Widgets: Add tests for `retrieve_widgets()`.
...
Helps with maintaining back compat when making changes in the future.
See #39693 .
Built from https://develop.svn.wordpress.org/trunk@41266
git-svn-id: http://core.svn.wordpress.org/trunk@41106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-18 15:04:43 +00:00
a806e2d3b3
Docs: Improve JavaScript documentation in autosave.js.
...
Add and improve JSDOC blocks.
Props carolinegeven.
Fixes #41203 .
Built from https://develop.svn.wordpress.org/trunk@41265
git-svn-id: http://core.svn.wordpress.org/trunk@41105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-18 14:24:45 +00:00
d856eda571
Docs: Improve JavaScript documentation in color-picker.js.
...
Add and improve JSDOC blocks.
Props carolinegeven, jjcomack, jipmoors.
Fixes #41063 .
Built from https://develop.svn.wordpress.org/trunk@41264
git-svn-id: http://core.svn.wordpress.org/trunk@41104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-18 13:10:44 +00:00
61d683989f
Tests: Rename ignored tests in `multisite.xml`.
...
For bonus :yolo: :friday:, this repeats [41262] for `multisite.xml`, which duplicates the ignored file list from `phpunit.xml.dist`.
See #41658 .
Built from https://develop.svn.wordpress.org/trunk@41263
git-svn-id: http://core.svn.wordpress.org/trunk@41103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-18 11:00:45 +00:00
190012c409
Tests: Rename ignored tests in `phpunit.xml.dist`.
...
Some of the files renamed in [41261] are listed in `phpunit.xml.dist`, as they need to be ignore in PHP 5.2.
This followup commit changes `phpunit.xml.dist` to match their new names.
See #41658 .
Built from https://develop.svn.wordpress.org/trunk@41262
git-svn-id: http://core.svn.wordpress.org/trunk@41102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-18 10:27:43 +00:00
01be3075b6
Tests: Rename tests with underscore in the name
...
There were a handful of files with an underscore in the name, which violated our naming scheme, and caused problems for anyone how enforced the scheme on their own systems.
This commit renames all of the files to the correct camelCase scheme.
Fixes #41658 .
Built from https://develop.svn.wordpress.org/trunk@41261
git-svn-id: http://core.svn.wordpress.org/trunk@41101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-18 09:58:46 +00:00
667f377cd0
Widgets: Prevent visual Text widget from decoding encoded HTML.
...
Also apply `the_editor_content` filters on widget `text` with `format_for_editor()` as is done for the post editor.
Amends [40631].
Props westonruter, azaozz.
See #35243 .
Fixes #41596 .
Built from https://develop.svn.wordpress.org/trunk@41260
git-svn-id: http://core.svn.wordpress.org/trunk@41100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-17 23:37:43 +00:00
b1d28c5e90
TinyMCE: Add the default `link` plugin without enabling it. This makes it easy for WordPress plugins to use it at places where `wplink` is not suitable, for example when initializing the editor from JS.
...
Props turtlepod.
Fixes #41590 .
Built from https://develop.svn.wordpress.org/trunk@41259
git-svn-id: http://core.svn.wordpress.org/trunk@41099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-17 21:04:45 +00:00
d5e3ea444d
Filesystem: Introduce the `pre_move_uploaded_file` filter.
...
Passing a non-null value to the filter will prevent the uploaded file from being moved to the uploads directory for any of the functions leveraging `_wp_handle_upload()`, such as `wp_handle_upload()` or `wp_handle_sideload()`.
Error reporting related to the file being moved will also be skipped.
Props ryan, Mte90.
Fixes #24603 .
Built from https://develop.svn.wordpress.org/trunk@41258
git-svn-id: http://core.svn.wordpress.org/trunk@41098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-16 21:59:43 +00:00
e80cf1d861
Canonical: Check first before attempting to include a 'path' value in the URL in `strip_fragment_from_url()`.
...
Props Mte90.
Fixes #40542 .
Built from https://develop.svn.wordpress.org/trunk@41257
git-svn-id: http://core.svn.wordpress.org/trunk@41097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-16 21:11:43 +00:00
ea92bb5f10
Customize: Harden color control's logic for obtaining default value to prevent JS error when non-string default supplied.
...
Props andreagobetti, yonivh for testing.
Fixes #37174 .
Built from https://develop.svn.wordpress.org/trunk@41256
git-svn-id: http://core.svn.wordpress.org/trunk@41096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-16 19:04:47 +00:00
e06146a9b5
Options, Meta APIs: Update the multisite unit tests after [41254], [41164], and [41163].
...
This moves some more previously Multisite-only tests into the main test suite, and makes small adjustments to their assertions.
See #39118 , #16470 , #39117
Built from https://develop.svn.wordpress.org/trunk@41255
git-svn-id: http://core.svn.wordpress.org/trunk@41095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-15 09:16:43 +00:00
b52e37f9bf
Options, Meta APIs: Require a confirmation link in an email to be clicked when an admin attempts to change the site admin email address.
...
This adds this previously Multisite-only functionality to single site installations too. This change prevents accidental or erroneous email address changes from potentially locking users out of their site.
Props MatheusGimenez, johnbillion
Fixes #39118
Built from https://develop.svn.wordpress.org/trunk@41254
git-svn-id: http://core.svn.wordpress.org/trunk@41094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-14 20:13:43 +00:00
b51f60de6d
Users: Display the "Your email address has not been updated yet" message when a user changes their profile email address from within network admin.
...
This ensures continuity with the regular profile editing screen and the user admin profile editing screen.
Fixes #41635
Built from https://develop.svn.wordpress.org/trunk@41253
git-svn-id: http://core.svn.wordpress.org/trunk@41093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-14 19:42:43 +00:00
75ad3494a8
Widgets: Expose link URL input field in Image widget to avoid having to open media modal to discover.
...
Props timmydcrawford, westonruter.
See #39993 .
Fixes #41274 .
Built from https://develop.svn.wordpress.org/trunk@41252
git-svn-id: http://core.svn.wordpress.org/trunk@41092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-14 17:56:42 +00:00
ae47e05f74
Widgets: Suppress PHP warnings raised by `DOMDocument::loadHTML()` in `WP_Widget_Text::is_legacy_instance()` which could appear in Text widget forms.
...
Also explicitly use HTML5 doctype when parsing Text widget contents in legacy mode detection.
Amends [41050].
See #40951 .
Fixes #41622 .
Built from https://develop.svn.wordpress.org/trunk@41251
git-svn-id: http://core.svn.wordpress.org/trunk@41091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-14 05:59:42 +00:00
d8bf666313
Emoji: Update Twemoji to 2.5.0.
...
Twemoji 2.3.0 has a rendering issue in Safari, emoji can sometimes be followed by U+FEOF (which is just a flag meaning "render the preceding character as emoji).
Twemoji wasn't catching this character correctly, and Safari rendered it incorrectly.
Twemoji 2.5.0 resolves this issue.
Fixes #41584 .
Built from https://develop.svn.wordpress.org/trunk@41250
git-svn-id: http://core.svn.wordpress.org/trunk@41090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-14 02:04:45 +00:00
18613c0010
Widgets: Add missing `open` class for expanded widgets in Customizer; utilize `open` class for expansion detection in Text and Media widgets.
...
Fixes #41625 .
Built from https://develop.svn.wordpress.org/trunk@41249
git-svn-id: http://core.svn.wordpress.org/trunk@41089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-13 06:25:43 +00:00
5c755f652b
Customize: Prevent attachment deletions from silently failing in media modals opened for Media widgets.
...
Amends [40640].
See #32417 .
Fixes #41609 .
Built from https://develop.svn.wordpress.org/trunk@41248
git-svn-id: http://core.svn.wordpress.org/trunk@41088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-13 06:11:43 +00:00
e956aa4176
Customize: Prevent wide widgets from being displayed as wide when Customizer is displayed in mobile breakpoint.
...
Fixes #41624 .
Built from https://develop.svn.wordpress.org/trunk@41247
git-svn-id: http://core.svn.wordpress.org/trunk@41087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-13 05:55:43 +00:00
a5d3688157
Customize: Update selector to add `max-height`/`max-width` for wide widgets to account for JS-driven Text widget and Media widgets.
...
Fixes #41623 .
Built from https://develop.svn.wordpress.org/trunk@41246
git-svn-id: http://core.svn.wordpress.org/trunk@41086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-13 05:42:42 +00:00
9c3cdaf3fb
Widgets: Fix extensibility of Text widgets so that JS logic will initialize on subclassed widgets.
...
Amends [40631].
See #35243 .
Fixes #41540 .
Built from https://develop.svn.wordpress.org/trunk@41245
git-svn-id: http://core.svn.wordpress.org/trunk@41085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-13 05:25:46 +00:00
300894da61
Customize: Prevent `_delete_option_fresh_site()` from hitting DB if `fresh_site` flag already cleared.
...
Amends [38991].
Props dlh, westonruter.
Fixes #41039 .
Built from https://develop.svn.wordpress.org/trunk@41244
git-svn-id: http://core.svn.wordpress.org/trunk@41084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-13 00:57:43 +00:00
6428de97a7
Customize: Fix PHP warning raised when deleting a setting from changeset via passing `null` as params in `WP_Customize_Manager::save_changeset_post()`.
...
Props dlh.
Fixes #41621 .
Built from https://develop.svn.wordpress.org/trunk@41243
git-svn-id: http://core.svn.wordpress.org/trunk@41083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-12 21:21:48 +00:00
473e1ba73b
Multisite: Remove references to `$wpdb->siteid` and use `get_current_network_id()` instead.
...
Props sathyapulse, spacedmonkey.
Fixes #41507 .
Built from https://develop.svn.wordpress.org/trunk@41242
git-svn-id: http://core.svn.wordpress.org/trunk@41082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-12 13:11:43 +00:00
820d3973a3
Multisite: Rename internal `$site_id` variables referencing networks to `$network_id`.
...
This change improves code clarity by using the current naming conventions for networks.
Props lemacarl.
Fixes #41510 .
Built from https://develop.svn.wordpress.org/trunk@41241
git-svn-id: http://core.svn.wordpress.org/trunk@41081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-12 12:48:47 +00:00
f0ee106d86
Media: Upgrade MediaElement.js from 4.2.3 to 4.2.5.
...
Props rafa8626.
See #39686 .
Built from https://develop.svn.wordpress.org/trunk@41240
git-svn-id: http://core.svn.wordpress.org/trunk@41080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-12 06:20:44 +00:00
f42a3a2440
Docs: Improve JavaScript documentation in audiovideo.manifest.js.
...
Add and improve JSDOC blocks.
Props nicollle, manuelaugustin.
Fixes #41602 .
Built from https://develop.svn.wordpress.org/trunk@41239
git-svn-id: http://core.svn.wordpress.org/trunk@41079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-11 20:37:45 +00:00
John Blackbourn
Boone Gorges
Drew Jaynes
Pascal Birchler
Aaron Jorbin
Felix Arntz
Konstantin Obenland
Adam Silverstein
Gary Pendergast
Weston Ruter
Andrew Ozz
Peter Wilson